Re: [8u] RFR: 8210647: libsaproc is being compiled without optimization
Looks ok to me. /Erik On 2018-11-15 06:57, Severin Gehwolf wrote: Hi, Could I please get reviews for this 8u backport of JDK-8210647. Since the build system is different in 8, the patch looks different. For the Windows build changes I've refactored the make file a bit so as to facilitate passing opt flags to the compiler. Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/ Testing: We have been using this in Fedora's JDK 8 for a while now and haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was kind enough to test this on Windows. Note: I'll also plan to backport JDK-8210836 and JDK-8212110 Thanks, Severin
Re: [8u] RFR: 8210647: libsaproc is being compiled without optimization
Hi JC, On Thu, 2018-11-15 at 08:37 -0800, JC Beyler wrote: > Hi Severin, > > That does look different ( > http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :) > > It looks good to me :), Thanks for the review! Cheers, Severin > Jc > > On Thu, Nov 15, 2018 at 6:58 AM Severin Gehwolf > wrote: > > Hi, > > > > Could I please get reviews for this 8u backport of JDK-8210647. > > Since > > the build system is different in 8, the patch looks different. For > > the > > Windows build changes I've refactored the make file a bit so as to > > facilitate passing opt flags to the compiler. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/ > > > > Testing: We have been using this in Fedora's JDK 8 for a while now > > and > > haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko > > was > > kind enough to test this on Windows. > > > > Note: I'll also plan to backport JDK-8210836 and JDK-8212110 > > > > Thanks, > > Severin > > > >
[8u] RFR: 8210647: libsaproc is being compiled without optimization
Hi, Could I please get reviews for this 8u backport of JDK-8210647. Since the build system is different in 8, the patch looks different. For the Windows build changes I've refactored the make file a bit so as to facilitate passing opt flags to the compiler. Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/ Testing: We have been using this in Fedora's JDK 8 for a while now and haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was kind enough to test this on Windows. Note: I'll also plan to backport JDK-8210836 and JDK-8212110 Thanks, Severin
RE: RFR: 8210647: libsaproc is being compiled without optimization.
Hi Severin, Looks good to me. Thanks, Sharath (not a Reviewer) -Original Message- From: Severin Gehwolf [mailto:sgehw...@redhat.com] Sent: Friday, September 14, 2018 7:04 PM To: build-dev; serviceability-dev Subject: RFR: 8210647: libsaproc is being compiled without optimization. Hi, Could I please get a review of this one-liner fix. It changes optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion). I've run servicability tests and haven't seen any new failures. Thoughts? Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ Thanks, Severin
Re: RFR: 8210647: libsaproc is being compiled without optimization.
A fix is waiting for review: https://bugs.openjdk.java.net/browse/JDK-8210836 Best Regards, Thomas On Tue, Sep 18, 2018 at 5:09 PM, Anthony Scarpino wrote: > I encountered this too when I build with ‘make’; however if I build through > JIB the error didn’t occur. > > Tony > >> On Sep 18, 2018, at 2:08 AM, Thomas Stüfe wrote: >> >> Hi Severin, >> >> I get reproducable build errors with your fix on my machine (Ubuntu 16.4). >> >> When I build release (no special build options), I get: >> >> /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c: >> In function ‘read_exec_segments’: >> /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:798:7: >> error: ignoring return value of ‘pread’, declared with attribute >> warn_unused_result [-Werror=unused-result] >> pread(ph->core->exec_fd, interp_name, exec_php->p_filesz, >> exec_php->p_offset); >> ^ >> >> When I remove your change (reset opt to NONE) error goes away. I have >> no idea why optimization influences warning level though. Any ideas? >> >> (Of course, one could just fix the warning, but I wonder if I am the >> only one with this problem) >> >> Best Regards, Thomas >> >> >> >> On Mon, Sep 17, 2018 at 6:25 AM, Sharath Ballal >> wrote: >>> Hi Severin, >>> >>> Looks good to me. >>> >>> >>> Thanks, >>> Sharath (not a Reviewer) >>> >>> >>> -Original Message- >>> From: Severin Gehwolf [mailto:sgehw...@redhat.com] >>> Sent: Friday, September 14, 2018 7:04 PM >>> To: build-dev; serviceability-dev >>> Subject: RFR: 8210647: libsaproc is being compiled without optimization. >>> >>> Hi, >>> >>> Could I please get a review of this one-liner fix. It changes optimization >>> of libsaproc from -O0 to -O3 (as per Magnus' suggestion). >>> I've run servicability tests and haven't seen any new failures. >>> Thoughts? >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 >>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ >>> >>> Thanks, >>> Severin >>> >>> >
Re: RFR: 8210647: libsaproc is being compiled without optimization.
I encountered this too when I build with ‘make’; however if I build through JIB the error didn’t occur. Tony > On Sep 18, 2018, at 2:08 AM, Thomas Stüfe wrote: > > Hi Severin, > > I get reproducable build errors with your fix on my machine (Ubuntu 16.4). > > When I build release (no special build options), I get: > > /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c: > In function ‘read_exec_segments’: > /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:798:7: > error: ignoring return value of ‘pread’, declared with attribute > warn_unused_result [-Werror=unused-result] > pread(ph->core->exec_fd, interp_name, exec_php->p_filesz, > exec_php->p_offset); > ^ > > When I remove your change (reset opt to NONE) error goes away. I have > no idea why optimization influences warning level though. Any ideas? > > (Of course, one could just fix the warning, but I wonder if I am the > only one with this problem) > > Best Regards, Thomas > > > > On Mon, Sep 17, 2018 at 6:25 AM, Sharath Ballal > wrote: >> Hi Severin, >> >> Looks good to me. >> >> >> Thanks, >> Sharath (not a Reviewer) >> >> >> -Original Message- >> From: Severin Gehwolf [mailto:sgehw...@redhat.com] >> Sent: Friday, September 14, 2018 7:04 PM >> To: build-dev; serviceability-dev >> Subject: RFR: 8210647: libsaproc is being compiled without optimization. >> >> Hi, >> >> Could I please get a review of this one-liner fix. It changes optimization >> of libsaproc from -O0 to -O3 (as per Magnus' suggestion). >> I've run servicability tests and haven't seen any new failures. >> Thoughts? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 >> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ >> >> Thanks, >> Severin >> >>
Re: RFR: 8210647: libsaproc is being compiled without optimization.
Hi Severin, On Tue, Sep 18, 2018 at 11:24 AM, Severin Gehwolf wrote: > Hi Thomas, > > On Tue, 2018-09-18 at 11:08 +0200, Thomas Stüfe wrote: >> Hi Severin, >> >> I get reproducable build errors with your fix on my machine (Ubuntu 16.4). >> >> When I build release (no special build options), I get: >> >> /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c: >> In function ‘read_exec_segments’: >> /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:798:7: >> error: ignoring return value of ‘pread’, declared with attribute >> warn_unused_result [-Werror=unused-result] >>pread(ph->core->exec_fd, interp_name, exec_php->p_filesz, >> exec_php->p_offset); >>^ >> >> When I remove your change (reset opt to NONE) error goes away. I have >> no idea why optimization influences warning level though. Any ideas? > > It's rather strange, yes. > >> (Of course, one could just fix the warning, but I wonder if I am the >> only one with this problem) > > It's this (you are not the only one): > https://bugs.openjdk.java.net/browse/JDK-8210836 > > Would --disable-warnings-as-errors work for you? > > We have to have this switched on for our distro builds, as there is > rarely a clean build unless you manage to have the blessed compiler > versions available, don't build with system libs, etc. > > Sorry about this! > No problem. I can wait until this is solved. Thanks, Thomas > Cheers, > Severin > >> Best Regards, Thomas >> >> >> >> On Mon, Sep 17, 2018 at 6:25 AM, Sharath Ballal >> wrote: >> > Hi Severin, >> > >> > Looks good to me. >> > >> > >> > Thanks, >> > Sharath (not a Reviewer) >> > >> > >> > -Original Message- >> > From: Severin Gehwolf [mailto:sgehw...@redhat.com] >> > Sent: Friday, September 14, 2018 7:04 PM >> > To: build-dev; serviceability-dev >> > Subject: RFR: 8210647: libsaproc is being compiled without optimization. >> > >> > Hi, >> > >> > Could I please get a review of this one-liner fix. It changes optimization >> > of libsaproc from -O0 to -O3 (as per Magnus' suggestion). >> > I've run servicability tests and haven't seen any new failures. >> > Thoughts? >> > >> > Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 >> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ >> > >> > Thanks, >> > Severin >> > >> > >
Re: RFR: 8210647: libsaproc is being compiled without optimization.
Hi Thomas, On Tue, 2018-09-18 at 11:08 +0200, Thomas Stüfe wrote: > Hi Severin, > > I get reproducable build errors with your fix on my machine (Ubuntu 16.4). > > When I build release (no special build options), I get: > > /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c: > In function ‘read_exec_segments’: > /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:798:7: > error: ignoring return value of ‘pread’, declared with attribute > warn_unused_result [-Werror=unused-result] >pread(ph->core->exec_fd, interp_name, exec_php->p_filesz, > exec_php->p_offset); >^ > > When I remove your change (reset opt to NONE) error goes away. I have > no idea why optimization influences warning level though. Any ideas? It's rather strange, yes. > (Of course, one could just fix the warning, but I wonder if I am the > only one with this problem) It's this (you are not the only one): https://bugs.openjdk.java.net/browse/JDK-8210836 Would --disable-warnings-as-errors work for you? We have to have this switched on for our distro builds, as there is rarely a clean build unless you manage to have the blessed compiler versions available, don't build with system libs, etc. Sorry about this! Cheers, Severin > Best Regards, Thomas > > > > On Mon, Sep 17, 2018 at 6:25 AM, Sharath Ballal > wrote: > > Hi Severin, > > > > Looks good to me. > > > > > > Thanks, > > Sharath (not a Reviewer) > > > > > > -Original Message- > > From: Severin Gehwolf [mailto:sgehw...@redhat.com] > > Sent: Friday, September 14, 2018 7:04 PM > > To: build-dev; serviceability-dev > > Subject: RFR: 8210647: libsaproc is being compiled without optimization. > > > > Hi, > > > > Could I please get a review of this one-liner fix. It changes optimization > > of libsaproc from -O0 to -O3 (as per Magnus' suggestion). > > I've run servicability tests and haven't seen any new failures. > > Thoughts? > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ > > > > Thanks, > > Severin > > > >
Re: RFR: 8210647: libsaproc is being compiled without optimization.
Hi Severin, I get reproducable build errors with your fix on my machine (Ubuntu 16.4). When I build release (no special build options), I get: /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c: In function ‘read_exec_segments’: /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:798:7: error: ignoring return value of ‘pread’, declared with attribute warn_unused_result [-Werror=unused-result] pread(ph->core->exec_fd, interp_name, exec_php->p_filesz, exec_php->p_offset); ^ When I remove your change (reset opt to NONE) error goes away. I have no idea why optimization influences warning level though. Any ideas? (Of course, one could just fix the warning, but I wonder if I am the only one with this problem) Best Regards, Thomas On Mon, Sep 17, 2018 at 6:25 AM, Sharath Ballal wrote: > Hi Severin, > > Looks good to me. > > > Thanks, > Sharath (not a Reviewer) > > > -Original Message- > From: Severin Gehwolf [mailto:sgehw...@redhat.com] > Sent: Friday, September 14, 2018 7:04 PM > To: build-dev; serviceability-dev > Subject: RFR: 8210647: libsaproc is being compiled without optimization. > > Hi, > > Could I please get a review of this one-liner fix. It changes optimization of > libsaproc from -O0 to -O3 (as per Magnus' suggestion). > I've run servicability tests and haven't seen any new failures. > Thoughts? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ > > Thanks, > Severin > >
Re: RFR: 8210647: libsaproc is being compiled without optimization.
Looks good to me. /Erik On 2018-09-14 06:33, Severin Gehwolf wrote: Hi, Could I please get a review of this one-liner fix. It changes optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion). I've run servicability tests and haven't seen any new failures. Thoughts? Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ Thanks, Severin
RFR: 8210647: libsaproc is being compiled without optimization.
Hi, Could I please get a review of this one-liner fix. It changes optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion). I've run servicability tests and haven't seen any new failures. Thoughts? Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/webrev.01/ Thanks, Severin
