D29542: Refactor canvas event handling

[Dag Andersen]

danders added a comment.


  This seems to work fine, I also tested with only pageapp changes.
  Imho I would prefer to separate the pageapp and KoMainWindow changes into 
separate commits,
  The pageapp changes should go into 3.2 branch followed by a swift release.
  I don't think the KoMainWindow changes should go into the branch as it only 
removes unused functionallity.
  I'm a bit in two minds if it should go in at all actually, so I'll leave it 
you or maybe somebody else has an opinion.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29542

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D29542: Refactor MainWindow view

[Dag Andersen]

danders added a comment.


  In D29542#668076 , @anthonyfieroni 
wrote:
  
  >   `d->rootPart->createView(doc, this);` Creates the view which parent is 
main window.
  
  
  Ahh, yes, but then...
  Why will it not crash if a new document is set so that d->rootView != 0 ?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29542

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D29542: Refactor MainWindow view

[Dag Andersen]

danders added a comment.


  Hmmm, it seems to me you are creating a leak in your lines 544, 545? (Have 
not tested, I might be wrong)
  
  Afaics the problem is that a focus event is issued that accesses the view 
after death.
  Possibly a deleteLater() would do it, but I tried with setting paret to 
nullptr:
  
while(!oldRootViews.isEmpty()) {
KoView *v = oldRootViews.takeFirst();
v->setParent(nullptr);
delete v;
}
  
  (Also in KoMainWindow dtor to be consistent.)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29542

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:240fb4f60810: Chart: Fix Bug 240520 - No axes lines when 
creating new chart (authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28820?vs=80089=80360

REVISION DETAIL
  https://phabricator.kde.org/D28820

AFFECTED FILES
  plugins/chartshape/Axis.cpp
  plugins/chartshape/Axis.h
  plugins/chartshape/PlotArea.cpp

To: danders
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

[Dag Andersen]

danders created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Turns out KChart needs a explicitly set pen to draw ruler lines.
  KChart 2.7.0 will have the option to set a pen int KChart::RulerAttributes
  
  BUG: 240520

REPOSITORY
  R8 Calligra

BRANCH
  no_rulerline

REVISION DETAIL
  https://phabricator.kde.org/D28820

AFFECTED FILES
  plugins/chartshape/Axis.cpp
  plugins/chartshape/Axis.h
  plugins/chartshape/PlotArea.cpp

To: danders
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Dag Andersen]

danders added a comment.


  I think where leinir has landed is more doable than a frameworks.
  Also if compiletime is a big hurdle, I see a couple of things that can be 
done:
  
  - Remove pigment, see T5738 .
  
  - Make more finegrained productsets. Pt the only thing you can control (if I 
haven't missed anything) is which apps to build.
  
  E.g. if you want to work on the innards of words for gemini, you select 
gemini and get words, sheets and stage. In addition you get almost all plugins 
and all relevant filters. Probably *some* plugins are necessary but you should 
be able to do without most plugins and no filters at all.
  
  Another problem is how new users find out how to use productsets. A front-end 
would have been nice, but a bit of documantation should go a long way.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: danders
Cc: danders, davidllewellynjones, ndavis, jtamate, rempt, anthonyfieroni, 
dcaliste, boemann, pino, rjvbb, ngraham, ognarb, Calligra-Devel-list, 
#calligra:_3.0, leinir, cochise, vandenoever

D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added)

[Dag Andersen]

danders abandoned this revision.
danders added a comment.
Herald added a subscriber: Calligra-Devel-list.


  Has been comitted

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D7228

To: danders, boemann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D11191: Remove Plan dependencies from CMakeLists.txt

[Dag Andersen]

danders closed this revision.
Herald added a subscriber: Calligra-Devel-list.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D11191

To: kavindap, #calligra:_3.0, staniek
Cc: Calligra-Devel-list, staniek, danders, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Dag Andersen]

danders added a comment.


  ping

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

[Dag Andersen]

danders added a comment.


  ping

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25034

To: denexter, pvuorela, mkruisselbrink
Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D26050: Fix build with poppler 82

[Dag Andersen]

danders added a reviewer: danders.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0, danders
Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, 
anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D22545: Add missing include QDate

[Dag Andersen]

danders closed this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D22545

To: usta, #calligra:_3.0, Calligra-Devel-list, boemann
Cc: dfaure, pino, boemann, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25714: [WIP]: Port away from deprecated KHtml

[Dag Andersen]

danders added a comment.


  Still wip, or...

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25008

To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste
Cc: danders, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D24852: Remove list style from headings

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Most seems to be positive, so go for it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D24852

To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders
Cc: danders, anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

[Dag Andersen]

danders added a comment.


  @tcanabrava please abondone this.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, 
anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

[Dag Andersen]

danders abandoned this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D2577

To: danders, #calligra:_3.0, staniek, Calligra-Devel-list
Cc: anthonyfieroni, staniek, davidllewellynjones, dcaliste, ognarb, barman, 
cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  There are unit tests that fail without this, so if somebody doas not come up 
with code that shows this is wrong, please commit.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

[Dag Andersen]

danders added a comment.


  Any comments, anyone?
  I have not tested and does not know if it is the right way to do it.
  If nobody have comments, I'm willing to trust the author and say go for it!

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26328

To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann
Cc: danders, davidllewellynjones, dcaliste, denexter, pvuorela, 
Calligra-Devel-list, #calligra:_3.0, ognarb, cochise, vandenoever

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

[Dag Andersen]

danders added a reviewer: boemann.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26328

To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann
Cc: davidllewellynjones, dcaliste, denexter, pvuorela, Calligra-Devel-list, 
#calligra:_3.0, ognarb, cochise, vandenoever

D25423: Fill table cells with color for ODS and XLSX files

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25423

To: mphilippov, denexter, pvuorela, davidllewellynjones, dcaliste
Cc: danders, dcaliste, davidllewellynjones, denexter, Calligra-Devel-list, 
#calligra:_3.0, ognarb, cochise, vandenoever

D25422: Handle custom-shapes to display text in ODP files

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25422

To: mphilippov, denexter, davidllewellynjones, pvuorela, dcaliste
Cc: danders, denexter, pvuorela, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

[Dag Andersen]

danders added a comment.


  Ooops, seems I fixed this (+ 0.83) in separate commits, so this can be closed.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, 
anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D26221: Use QQC2 Dialog

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26221

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:f8786b001b75: Remove flow, not needed since karbon can do 
it all (authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25254?vs=69579=76900

REVISION DETAIL
  https://phabricator.kde.org/D25254

AFFECTED FILES
  CMakeLists.txt
  CalligraProducts.cmake
  flow/AUTHORS
  flow/CMakeLists.txt
  flow/LICENSE
  flow/Mainpage.dox
  flow/Messages.sh
  flow/NOTES
  flow/flow_dock.desktop
  flow/part/CMakeLists.txt
  flow/part/FlowAboutData.h
  flow/part/FlowDocument.cpp
  flow/part/FlowDocument.h
  flow/part/FlowFactory.cpp
  flow/part/FlowFactory.h
  flow/part/FlowFactoryInit.cpp
  flow/part/FlowFactoryInit.h
  flow/part/FlowPart.cpp
  flow/part/FlowPart.h
  flow/part/FlowView.cpp
  flow/part/FlowView.h
  flow/part/flow.rc
  flow/part/flowpart.desktop
  flow/part/flowrc
  flow/part/main.cpp
  flow/part/org.kde.calligraflow.appdata.xml
  flow/part/org.kde.calligraflow.desktop
  flow/pics/1024-apps-calligraflow.png
  flow/pics/128-apps-calligraflow.png
  flow/pics/16-apps-calligraflow.png
  flow/pics/22-apps-calligraflow.png
  flow/pics/256-apps-calligraflow.png
  flow/pics/32-apps-calligraflow.png
  flow/pics/48-apps-calligraflow.png
  flow/pics/512-apps-calligraflow.png
  flow/pics/64-apps-calligraflow.png
  flow/pics/CMakeLists.txt
  flow/pics/sc-apps-calligraflow.svgz
  flow/templates/CMakeLists.txt
  flow/templates/basic/.directory
  flow/templates/basic/48-actions-template_basicflow.png
  flow/templates/basic/48-actions-template_empty_landscape.png
  flow/templates/basic/48-actions-template_empty_portrait.png
  flow/templates/basic/CMakeLists.txt
  flow/templates/basic/basicflow.desktop
  flow/templates/basic/empty-landscape.desktop
  flow/templates/basic/empty-landscape.otg
  flow/templates/basic/empty-portrait.desktop
  flow/templates/basic/empty-portrait.otg
  flow/templates/basic/sc-actions-template_basicworkflow.svgz
  flow/templates/basic/sc-actions-template_empty_landscape.svgz
  flow/templates/basic/sc-actions-template_empty_portrait.svgz

To: danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D27056: Stage: Add automatic slide transition

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:4f4141727401: Stage: Add automatic slide transition 
(authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27056?vs=74748=75033

REVISION DETAIL
  https://phabricator.kde.org/D27056

AFFECTED FILES
  stage/part/CMakeLists.txt
  stage/part/KPrAnimationDirector.cpp
  stage/part/KPrAnimationDirector.h
  stage/part/KPrPage.cpp
  stage/part/KPrPageApplicationData.cpp
  stage/part/KPrPageApplicationData.h
  stage/part/KPrPageTransition.cpp
  stage/part/KPrPageTransition.h
  stage/part/commands/KPrPageTransitionSetCommand.cpp
  stage/part/commands/KPrPageTransitionSetCommand.h
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp
  stage/part/tools/animationtool/KPrPageEffectDocker.h

To: danders, zachmann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D27056: Stage: Add automatic slide transition

[Dag Andersen]

danders created this revision.
danders added a reviewer: zachmann.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Introduces 2 modes for slide transitions:
  Manual: Slide transition and animations must be activated manually (any page 
effect is always run)
  Automatic: Slide transition included page effects and animations is activated 
automatically after a user selectable time.
  
  Known bug:
  The animation docker ui is not updated after undo but this is general bug
  and not introduced by this patch.
  See bug 416979.

REPOSITORY
  R8 Calligra

BRANCH
  pagetransition_danders

REVISION DETAIL
  https://phabricator.kde.org/D27056

AFFECTED FILES
  stage/part/CMakeLists.txt
  stage/part/KPrAnimationDirector.cpp
  stage/part/KPrAnimationDirector.h
  stage/part/KPrPage.cpp
  stage/part/KPrPageApplicationData.cpp
  stage/part/KPrPageApplicationData.h
  stage/part/KPrPageTransition.cpp
  stage/part/KPrPageTransition.h
  stage/part/commands/KPrPageTransitionSetCommand.cpp
  stage/part/commands/KPrPageTransitionSetCommand.h
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp
  stage/part/tools/animationtool/KPrPageEffectDocker.h

To: danders, zachmann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

[Dag Andersen]

danders added a comment.


  Afaik we still support qt5.3, I don't think qAsConst is availabel.
  Disregard if this has changed.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

danders added a comment.


  In D25254#561131 , @boemann wrote:
  
  > To be honest I kind of liked the idea of a dedicated flow drawing tool and 
a dedicated vector drawing tool, but since they have so little between them, 
and no one seem to be maintaining flow.
  
  
  Yes, I agree. 
  It is however, a problem having two apps using same native mimetype for realy 
different content.
  I would certainly think it was worth it if flow had really good support for 
flow charts,
  but it is really just the minimum needed to create a pageapp.
  All functionallity is in the plugins, so flow does not offer any advantage 
over karbon or words.
  
  I'll let this patch rest fttb, a decission can be made closer to next release.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25254

To: danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

danders added a comment.


  Yeah, well.
  If flow had some special functionallity that made it much easier to crate 
flow charts, I would also be reluctant to just remove it.
  As it stands flow has nothing special, it is only a few line of code 
actually, and as I see it, the karbon ui is very similar to flow.
  Granted, karbon can do a lot more, but I don't think it is disturibing the 
user as this is 'hidden' in separate menus.
  
  Also, on a technical note, having two apps that handle the same mimetype 
(they are using the odg file format both) confuses the filter system.
  E.g: You might try to open an svg file in karbon, but it might be opened in 
flow. In this case the only thing you can do as is to uninstall flow.
  
  If you look to LO, they just use their regular draw app for flow charts too.
  
  Now, if there was sombody that was interested in creating a fantastic flow 
app and maintaining it, maybe it should stay, but...
  
  In short, I don't see any good reason to keep it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25254

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Since karbon is multipage app and stencils docker can be used by all apps,
  there is no need for flow anymore.
  
  Removing flow also 'fixes' problem with filter system, as it does not
  know which app to open when two apps handle the same mimetype.

TEST PLAN
  Tested with visio files.

REPOSITORY
  R8 Calligra

BRANCH
  danders_remove_flow

REVISION DETAIL
  https://phabricator.kde.org/D25254

AFFECTED FILES
  CMakeLists.txt
  CalligraProducts.cmake
  flow/AUTHORS
  flow/CMakeLists.txt
  flow/LICENSE
  flow/Mainpage.dox
  flow/Messages.sh
  flow/NOTES
  flow/flow_dock.desktop
  flow/part/CMakeLists.txt
  flow/part/FlowAboutData.h
  flow/part/FlowDocument.cpp
  flow/part/FlowDocument.h
  flow/part/FlowFactory.cpp
  flow/part/FlowFactory.h
  flow/part/FlowFactoryInit.cpp
  flow/part/FlowFactoryInit.h
  flow/part/FlowPart.cpp
  flow/part/FlowPart.h
  flow/part/FlowView.cpp
  flow/part/FlowView.h
  flow/part/flow.rc
  flow/part/flowpart.desktop
  flow/part/flowrc
  flow/part/main.cpp
  flow/part/org.kde.calligraflow.appdata.xml
  flow/part/org.kde.calligraflow.desktop
  flow/pics/1024-apps-calligraflow.png
  flow/pics/128-apps-calligraflow.png
  flow/pics/16-apps-calligraflow.png
  flow/pics/22-apps-calligraflow.png
  flow/pics/256-apps-calligraflow.png
  flow/pics/32-apps-calligraflow.png
  flow/pics/48-apps-calligraflow.png
  flow/pics/512-apps-calligraflow.png
  flow/pics/64-apps-calligraflow.png
  flow/pics/CMakeLists.txt
  flow/pics/sc-apps-calligraflow.svgz
  flow/templates/CMakeLists.txt
  flow/templates/basic/.directory
  flow/templates/basic/48-actions-template_basicflow.png
  flow/templates/basic/48-actions-template_empty_landscape.png
  flow/templates/basic/48-actions-template_empty_portrait.png
  flow/templates/basic/CMakeLists.txt
  flow/templates/basic/basicflow.desktop
  flow/templates/basic/empty-landscape.desktop
  flow/templates/basic/empty-landscape.otg
  flow/templates/basic/empty-portrait.desktop
  flow/templates/basic/empty-portrait.otg
  flow/templates/basic/sc-actions-template_basicworkflow.svgz
  flow/templates/basic/sc-actions-template_empty_landscape.svgz
  flow/templates/basic/sc-actions-template_empty_portrait.svgz

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

[Dag Andersen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support 
(authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25214?vs=69566=69567

REVISION DETAIL
  https://phabricator.kde.org/D25214

AFFECTED FILES
  filters/karbon/image/ImageExport.cpp
  filters/karbon/image/ImageExportOptionsWidget.cpp
  filters/karbon/image/ImageExportOptionsWidget.h
  filters/karbon/image/ImageExportOptionsWidget.ui

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

[Dag Andersen]

danders updated this revision to Diff 69566.
danders added a comment.


  Remove unused include

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25214?vs=69438=69566

BRANCH
  multipage_image_danders

REVISION DETAIL
  https://phabricator.kde.org/D25214

AFFECTED FILES
  filters/karbon/image/ImageExport.cpp
  filters/karbon/image/ImageExportOptionsWidget.cpp
  filters/karbon/image/ImageExportOptionsWidget.h
  filters/karbon/image/ImageExportOptionsWidget.ui

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Adds ability to select page in the options dialog

TEST PLAN
  Export to png and jpeg from page > 1.

REPOSITORY
  R8 Calligra

BRANCH
  multipage_image_danders

REVISION DETAIL
  https://phabricator.kde.org/D25214

AFFECTED FILES
  filters/karbon/image/ImageExport.cpp
  filters/karbon/image/ImageExportOptionsWidget.cpp
  filters/karbon/image/ImageExportOptionsWidget.h
  filters/karbon/image/ImageExportOptionsWidget.ui

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25171: PDF Import: Add multipage support

[Dag Andersen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:c81c23998e09: PDF Import: Add multipage support (authored 
by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25171?vs=69423=69424

REVISION DETAIL
  https://phabricator.kde.org/D25171

AFFECTED FILES
  filters/karbon/pdf/CMakeLists.txt
  filters/karbon/pdf/Pdf2OdgImport.cpp
  filters/karbon/pdf/Pdf2OdgImport.h
  filters/karbon/pdf/PdfImportDebug.cpp
  filters/karbon/pdf/calligra_filter_pdf2odg.desktop

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25171: PDF Import: Add multipage support

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Imports multipage pdf files as svg using poppler to generate an svg file pr 
page.

REPOSITORY
  R8 Calligra

BRANCH
  multipagepdf

REVISION DETAIL
  https://phabricator.kde.org/D25171

AFFECTED FILES
  filters/karbon/pdf/CMakeLists.txt
  filters/karbon/pdf/Pdf2OdgImport.cpp
  filters/karbon/pdf/Pdf2OdgImport.h
  filters/karbon/pdf/PdfImportDebug.cpp
  filters/karbon/pdf/calligra_filter_pdf2odg.desktop

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:5a9a18f484a4: Karbon: Enable multi page capability 
(authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=69263=69300

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D20400#475477 , @anthonyfieroni 
wrote:
  
  > Now we have insert page, but we don't exports them :) If you think that's 
ok for now go for it.
  
  
  Just for the record: The pdf filter goes through the svg filter and as since 
svg does not know about pages, all but first page is lost.
  We need a new pdf->odg filter that can handle the pages.

REPOSITORY
  R8 Calligra

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 69263.
danders added a comment.


  KarbonView: Add slot to handle replaceActivePage

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=69262=69263

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 69262.
danders added a comment.


  SvgImport: Add the new layer to the page

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=69152=69262

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 69152.
danders added a comment.


  Handle removing pages from a pageapp properly

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=59256=69152

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D20400#475477 , @anthonyfieroni 
wrote:
  
  > Now we have insert page, but we don't exports them :) If you think that's 
ok for now go for it.
  
  
  If you mean export to svg here, afaics there are no page element in svg. Have 
I missed it?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 59256.
danders added a comment.


  Add dependence on LIB_KOPAGEAPP

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=55797=59256

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  I have been pondering why we disagreed so much on the background color, and I 
*think* I have an answer.
  My take is it's because we have not been talking about quite the same thing:
  I have looked at karbon as an *odg* editor, since it uses odg as its native 
file format.
  Since odg is wysiwyg nothing outside the doc should in any way affect the way 
it is presented, hence a background that is not saved to file doesn't make 
sence.
  
  OTOH, if one looks at karbon as an *svg* editor, the current background color 
implementation makes much more sence,
  since svg is meant to be embedded in an environment outside of the svg doc 
itself like screen, html, odg, etc.
  
  This leads me to two possible paths to take:
  
  1. Karbon as odg editor means this patch goes in.
  2. Karbon as svg editor means swicth to svg as native format and add odg 
export/import.
  
  (One could of course also keep karbon as svg editor and add a calligradraw 
app, but well, probably a bit of work...)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  Ooops, this didn't work as expected. This should have been a revision of 
D19327 .
  There is only small changes:
  
  1. Updated commit message.
  2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
  3. In karbon/data/karbon.rc: Removal of the "format" menu (not used) and 
adding the "format_pagelayout" action  to "settings" menu (where it was 
originally).
  
  This takes care of the page backround issue we have been discussing.
  The change is that the color is now saved to the odg document (as it should 
be, imo).
  Since the svg export filter does not save background color, there is no 
change here.
  
  (Sorry for the inconvinience, I've never been very friendly with arc/phab)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
danders added a project: Calligra: 3.0.
danders requested review of this revision.

REVISION SUMMARY
  Since odg spec supports multiple pages, I feel karbon also needs to support 
it.
  
  The main things that has changed:
  
  1. Since multiple pages is supported, adding/copying/deleting pages is now 
possible.
  2. The page background color is now set with a tool in the tool box. The 
entry for background color in the Settings dialog is superflous and has been 
removed.
  
  Ported to use pageapp classes.
  
  A lot of code was duplicated between pageapp and karbon
  and has been removed from karbon:
  
  - Save/load
  - Layers docker and all layer operations
  - Grid, guides, rulers and zoom
  - Event handlers
  - Printing
  - Show page margins has been moved to pageapp
  
  In general, import/export needs review to determine how to
  handle multiple pages when e.g. exporting to a format that
  does not support pages.
  
  Known bugs:
  
  - "Separate paths" command:
- Execute command, the shape disappears.
- Undo crashes. Note: Afaics this code is not touched so probably a libs 
bug.
  
  - Snap to grid does not work
  
  - Number of recent files does not work properly

TEST PLAN
  I am not an avid user of karbon, so would be nice if some that where could 
test.
  Also, do not have all types of different format docs for filter testing.
  Some that work are pdf, svg, jpg and karbon files.

REPOSITORY
  R8 Calligra

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

T10760: Calligra website unwanted blog content

[Dag Andersen]

danders added a comment.


  It seems I have not the privileges to fix this.
  Can someone else have a look?

TASK DETAIL
  https://phabricator.kde.org/T10760

To: danders
Cc: danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, 
sysadmin

D11971: Use same keyword separator for read and write

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read 
and write (authored by danders).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11971?vs=31423=54770#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11971?vs=31423=54770

REVISION DETAIL
  https://phabricator.kde.org/D11971

AFFECTED FILES
  libs/main/tests/documentstructuretest.cpp
  libs/odf/KoDocumentInfo.cpp
  libs/odf/KoDocumentInfo.h

To: michaelh, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D11971: Use same keyword separator for read and write

[Dag Andersen]

danders added a comment.


  Yes, looks sane, I'll deal with it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D11971

To: michaelh, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  I think this should be ok

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19884

To: pvuorela, danders
Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandenoever

D19973: MsooXmlCommonRead: protect member for double free

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19973

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19941: Avoid deprecated setSupportedDragActions

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19941

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19938: Avoid deprecated QRegion::subtract()

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19938

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

[Dag Andersen]

danders added a comment.


  In D19912#435067 , @pvuorela wrote:
  
  > In D19912#435058 , @danders 
wrote:
  >
  > > Strange indents, could you fix it?
  >
  >
  > That's what I commented on the summary. On some parts rtf-qt uses plain 
spaces for indentation and those parts look good. Then in the same file other 
methods might have a hard tab or a hard tab followed by spaces. If you really 
want, I can try to retain the old whitespace, but it's indentation-wise more or 
less broken already anyway :) Alternatively could run astyle for the 
subdirectory, though maybe best done as separate commit.
  
  
  Yes, sorry, as you say better done separatly.
  
  > The directory README also states "Temporary local copy of Brad Hards' 
rtf-qt library.", though as upstream hasn't had changes since 2011, it seems 
like a permanent one by now.
  
  Probably.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Strange indents, could you fix it?
  Otherwise ok.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19885: Implement logging category for excel plugins

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19885

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19759: Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets

[Dag Andersen]

danders added a reviewer: boemann.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19759

To: pvuorela, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19760: Support Qt <5.7 on KoShape flag usage

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19760

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19761: Remove obsolete syncX() workaround

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19761

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D19216#421689 , @rjvbb wrote:
  
  > >   That is actual a valid point, although in say Krita with transparent 
pixels a checkerboard is shown.
  >
  > Heh, I've had the opportunity to work closely with professional 
infographists so I picked up a thing or two about using applications like 
Illustrator and InDesign :)
  >
  > How to indicate a transparent area of an object is yet another subject, 
with a related but not identical purpose.
  >
  > >   That said it might make more sense for this "testing background" to be 
part of the document and not a general setting - if the use case is as you say 
then the testing background would also be different for different projects
  >
  > True. I was reacting to *re*moving a setting completely, not to moving it 
to a more appropriate context.
  
  
  Ok, after another rethink...
  It starts to make sence if karbon is used not as an odg editor but as an svg 
editor.
  Let's say you create an icon that should be shown on certain background 
color(s), it would be a help if you could check your design aginst those colors.
  In his case you are not concerned with wysiwyg or printing  as you would be 
with an odg document.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19327: Karbon: Enable multi page capability

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
danders added a project: Calligra: 3.0.
danders requested review of this revision.

REVISION SUMMARY
  Since odg spec supports multiple pages, I feel karbon also needs to support 
it.
  
  Ported to use pageapp classes.
  
  Karbon has config group "Interface" that is not precent in other apps.
  Some of the options have been disabled atm. Imho they should be
  harmonized with other apps and/or moved to View menu.
  
  A lot of code was duplicated between pageapp and karbon
  and has been removed from karbon:
  
  - Save/load
  - Layers docker and all layer operations
  - Grid, guides, rulers and zoom
  - Event handlers
  - Printing
  - Show page margins has been moved to pageapp
  
  In general, import/export needs review to determine how to
  handle multiple pages when e.g. exporting to a format that
  does not support pages.
  
  Known bugs:
  
  - "Separate paths" command:
- Execute command, the shape disappears.
- Undo crashes. Note: Afaics this code is not touched so probably a libs 
bug.
  
  - Snap to grid does not work
  
  - Number of recent files does not work properly

TEST PLAN
  I am not an avid user of karbon, so would be nice if some that where could 
test.
  Also, do not have all types of different format docs for filter testing.
  Some that work are pdf, svg, jpg and karbon files.

REPOSITORY
  R8 Calligra

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D19327

AFFECTED FILES
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Can we get a conclussion to this?
  @Camilla Have you come up with any more unit tests?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders marked an inline comment as done.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90
> We can remove "number of recent files" since other apps does not have it. but 
> for other 2 i don't see why we remove them, someone can found useful 
> (somehow). About me, i want them back, recent file complete remove not 
> commented.

I reconsiddered this, sheets actually also implements this so I'll leave it in.
(It does not work properly neither for karbon nor sheets, but that for 
different rainy day)

> danders wrote in KarbonConfigInterfacePage.cpp:73-90
> Recent file & docker font:
> Why does karbon need these, none of the other apps have it.
> Personally I would remove it, alternativly implent for all apps.
> Canvas color:
> I don't quite see what it is for. You can set a background color for the 
> canvas but it is only for the views, it is not printed.
> Also, if you have multiple views, it sets it in all views.

I also reconsidder docker font setting. It is useful and (partially) 
implemented in libs. You have to restart to get the new setting.
This should be impleneted for all apps, but that's for a different patch.

But, when it comes to canvas background, the more a look into it the more I 
dislike it.
Afaics it goes against both odf spec, wysiwyg and pageapp implementation.
Unfortunatly it was implemented so long ago that there is not mail archive any 
longer and
the git log doesn't give any reason.
Unless I get a *very* good reason to implement this I will not include it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D19216#417502 , @rjvbb wrote:
  
  > > Canvas color:
  > > I don't quite see what it is for. You can set a background color for the 
canvas but it is only for the views, it is not printed.
  >
  > A custom canvas colour feature doesn't strike me as odd, nor that it isn't 
printed (printing it WITHOUT setting a dedicated option would seem wrong to me).
  >
  > What about when you use an inversed theme, isn't a custom canvas colour 
required then if you want to see your black line art on a light (white) canvas?
  
  
  No, the canvas is part of the document and must never be themed. The canvas 
background is as much part of your drawing as any line you put on it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90
> I want to discuss comments in the review, i don't want to have in. why we 
> remove this?

Recent file & docker font:
Why does karbon need these, none of the other apps have it.
Personally I would remove it, alternativly implent for all apps.
Canvas color:
I don't quite see what it is for. You can set a background color for the canvas 
but it is only for the views, it is not printed.
Also, if you have multiple views, it sets it in all views.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D19216#417288 , @rjvbb wrote:
  
  > This would indeed be great to have; even a page selector when importing a 
multi-page document would be an improvement (the Adobe Illustrator version I've 
use had that; IIRC it would just leave all other pages of the document alone).
  >
  > You should also test with PDF documents; in my experience Karbon 3.1 works 
well enough with them.
  
  
  Yes, pdf docs work, it is almost 100% handled by poppler.
  
  > ...
  > 
  >> A lot of code was duplicated between pageapp and karbon
  >>  and has been removed from karbon:
  > 
  > Shouldn't that be a separate change - or does multi-page support come 
automatically with this change?
  
  Well, my initial thought, but there was going to be quite a few intermidiate 
solutions mainly because
  the KoPACanvas cannot be subclassed, so I decided to do everything in one go.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

[Dag Andersen]

danders added a comment.


  > Thanks for the review, I will work next on 
libs/{pigment,version,widgetutils}.
  
  Hmm, maybe wait with pigment, according to rempt, only krita actually used it.
  I haven't looked into it, but if that is the case probably we should dump it.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Ok, I can't say I have scrutinized every change, but...
  Could you give a heads up when you continue with other parts or else there 
may be merge problems.
  I'm working on karbon and pageapp atm, so please keep off :)

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

[Dag Andersen]

danders added a reviewer: leinir.
danders added a comment.


  Hmmm. wasn't it somethng with ms windows and for loops, leinir?
  Also, I think there may be detachment issues with them, clazy can tell.
  There is a qAsConst() solution but that is not supported in the qt version we 
need to support.
  If there are issues, maybe drop the for loops for now.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  Thanks, I'm checking it out now...
  Just a couple of things:
  Keywords needs to be on a separate line to have effect, see 
https://community.kde.org/Infrastructure/Git/Hooks
  Also FIXED-IN is nice to add.
  
  I've updated and closed the bug, so no problem.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

[Dag Andersen]

danders added a comment.


  Please remove trailing whitespace.

REPOSITORY
  R8 Calligra

BRANCH
  calligra/3.1

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, 
dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  In D18466#411248 , @boemann wrote:
  
  > Dan can you please reply - I'm fine with the account but I can't reply to 
Ben as I am not able to send email
  
  
  Yes, I have, and just answered again in case something went wrong first time.
  Let's see if something happens soon.

REPOSITORY
  R8 Calligra

BRANCH
  print-remote-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18866

To: heikobecker, danders
Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

[Dag Andersen]

danders added a comment.


  What about the other ​check_function_exists, should they also be changed?
  Also, do you know when ​check_symbol_exists was introduced?
  We still use cmake 2.8.12.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18866

To: heikobecker
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18843: Activate stencils docker in all apps

[Dag Andersen]

danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  The docker now loads in separate thread and is hidden by default,
  so does not have any performance impact and is non-intrusive.
  
  From a user perspective (me):
  Why words: My weapon of choice to create a flow chart is words,
  because of things like headers/footers and even TOC.
  
  Why sheets: Just for consistency.

TEST PLAN
  Open words, immediately start typing: words is responsive.

REPOSITORY
  R8 Calligra

BRANCH
  activate_stencils_danders

REVISION DETAIL
  https://phabricator.kde.org/D18843

AFFECTED FILES
  stage/part/KPrFactory.cpp
  words/part/KWFactory.cpp

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18841: StencilBoxDocker: Make the docker collapsed by default

[Dag Andersen]

danders abandoned this revision.
danders added a comment.


  mistake

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18841

To: danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18841: StencilBoxDocker: Make the docker collapsed by default

[Dag Andersen]

danders created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  WIP

REPOSITORY
  R8 Calligra

BRANCH
  activate_stencils_danders

REVISION DETAIL
  https://phabricator.kde.org/D18841

AFFECTED FILES
  plugins/stencilsdocker/StencilBoxDockerFactory.h
  stage/part/KPrFactory.cpp
  words/part/KWFactory.cpp

To: danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  Ok, it's accepted so please commit/push/land

REPOSITORY
  R8 Calligra

BRANCH
  print-remote-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Yes, close.
  When export to pdf, the mainwindow is not shown and since we don't exit, the 
app will hang.
  You need to invert the check in KoApplication line 460 so the window is shown.
  
  Also please fix the trailing spaces.
  
  And then: ok to land!

REPOSITORY
  R8 Calligra

BRANCH
  print-remote-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  Yeah, well there are some half done designs in here :(
  
  The benchmark just does not work with remote files. Don't know if it should 
or if it should be blocked. Let's leave it for now.
  
  If you do not specify a pdf filename, it will use the same name as in the 
loaded file just changing the extension to .pdf, so it is possible to export 
multiple files.
  I have sort of assumed that print and exportToPdf commands was meant to be 
hands free, to be able to print a number of files wo a lot of mouse work.
  Popping up dialogs (print dialog or error dialogs) defies that goal, so imho 
these things should be handled differently.
  I recognize that this fix has balooned and we are getting into difficult 
areas, so I propose:
  Let's do without exit atm, just remove the job connection in 
slotExportToPdf() and add a TODO to implement exit later.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  Regarding the completed slot, the doc says:
  --print  Only print and exit
  --export-pdf  Only export to PDF and exit
  
  To exit, you need to know when all jobs have finished, so if some failed you 
need to track that.
  Also, the connection to job in slotExportToPdf() is wrong (not your fault) as 
it will just quit while there may be other jobs running.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Well, unit tests has been added that fails without this patch and passes with 
this patch.
  If there are more test cases needed, please add them so that we can get this 
patch committed soon...

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  I think the problem is that slotFilePrint() is called (in 
KoApplication::start()) before the document is actually loaded.
  Probably we need to start printing in a slot connected to 
KoMainWindow::loadCompleted() instead.
  And to be safe, we also need to handle loadCanceled().
  And the same for exportToPdf, I think.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18448: Replaced "distraction free" with "fullscreen" - BUG:378527

[Dag Andersen]

danders added a reviewer: boemann.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18448

To: niccolove, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Ran this patch against new unit tests and it fixes all the expected ones, 
namely those where all cells in first row is merged with cells in second row.
  Test results without patch: 
https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.10/lastCompletedBuild/testReport/projectroot.libs.textlayout/tests/libs_kotextlayout_TestTableLayout
  See uploaded file for result with patch.F6552719: LastTest.log 


REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:666ae5b484cc: Add new table layout unit tests (authored by 
danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18095?vs=49141=49511

REVISION DETAIL
  https://phabricator.kde.org/D18095

AFFECTED FILES
  libs/textlayout/tests/MockRootAreaProvider.cpp
  libs/textlayout/tests/MockRootAreaProvider.h
  libs/textlayout/tests/TestDocumentLayout.cpp
  libs/textlayout/tests/TestTableLayout.cpp
  libs/textlayout/tests/TestTableLayout.h

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Dag Andersen]

danders added a comment.


  Even if they do not all pass, I think they should be commited if the 
tests/methods are ok and the reason for not passing are genuin bugs, no?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18095

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Dag Andersen]

danders updated this revision to Diff 49141.
danders added a comment.


  Add a test that trigger a loop in the table layout

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18095?vs=48957=49141

BRANCH
  table_unittest_danders

REVISION DETAIL
  https://phabricator.kde.org/D18095

AFFECTED FILES
  libs/textlayout/tests/MockRootAreaProvider.cpp
  libs/textlayout/tests/MockRootAreaProvider.h
  libs/textlayout/tests/TestDocumentLayout.cpp
  libs/textlayout/tests/TestTableLayout.cpp
  libs/textlayout/tests/TestTableLayout.h

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Dag Andersen]

danders added a comment.


  Not trivial (for me) to get data out of layout so it is hard to create robust 
tests.
  I don't think I have been able to create a test to simulate the loop excactly.
  Also, uncertain wether the MockRootAreaProvider is sufficient.
  Any ideas/comments wellcome.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18095

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Dag Andersen]

danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Adds multiple areas capabilities and tests with merged cells

REPOSITORY
  R8 Calligra

BRANCH
  table_unittest_danders

REVISION DETAIL
  https://phabricator.kde.org/D18095

AFFECTED FILES
  libs/textlayout/tests/MockRootAreaProvider.cpp
  libs/textlayout/tests/MockRootAreaProvider.h
  libs/textlayout/tests/TestDocumentLayout.cpp
  libs/textlayout/tests/TestTableLayout.cpp
  libs/textlayout/tests/TestTableLayout.h

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Fidled a little more with this, and found several problems when table with 
merged cells is split over pages,
  like unmerged cell painted on both pages (empty on first page), caret not 
shown in selected cell and sometimes shown in prev cell.
  
  Tried to recreate problem with words, which is easy, both with Anthonies 
(D15428 ) patch and with master:
  
  - Create a 2x1 table then merge the two rows:
  
  master: Table disappears (expected, as layout code is skipped)
  D15428 : Table is displayed as it should 
be.
  
  - Create a table larger than a page, then merge the first 2 rows:
  
  master: Loops
  D15428 : Table is displayed as it should.
  
  I encountered an assert in KoTextLayoutTableArea::selectionBoundingBox() line 
342,
  but this is not a new problem and unrelated to D15428 
.
  To recreate: Add a table, merge two rows, add a row below the merged rows -> 
assert.
  
  I also checked out how LO handles this. In imvvho they don't do a great job, 
but they don't freeze nor crash ;)
  As you aptly point out Camilla, we need to define in more detail what to do 
in different cases, but as always
  LO is probably the standard even when they are not good.
  
  Based on all this, I retract all my suggestions/proposals/patches.
  Imvvho Anthonies patch adresses two concrete problems (a loop and a crash) 
and afaics it does not introduce new problems,
  so I propose it is accepted.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  In D15428#378432 , @boemann wrote:
  
  > No you misunderstand. I wasn't talking about you diff - I want to know what 
it is we are trying to accomplish. in spoken words
  
  
  Ahhh. It's a guard against loop/crash in extreme cases.
  
  In real life this should (almost) never happen, maybe when changing page size 
or if we do not have the correct font.
  I think the only thing to do is to just layout the header rows over multiple 
pages (as we do with non-header rows).

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  In D15428#378422 , @boemann wrote:
  
  > Dan I like your diff better - I don't think it's completely there but it's 
a better starting point
  >
  > On a more conceptual level, what should happen if the design of table is 
such that headers can't fit on a virgin page? What should we do.? One one hand 
it should be there but on the other hand we will never get to show the real 
part of the table ever.
  >  What is the solution we should aim for?
  
  
  I thought I had covered that case by not setting totalMisFit  (but I'm not 
certain). I thought that rows then would be layed out regrdless, but I may have 
missed a trick.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  I ended up in the same spot as you:
  Since all columns in row 0 spans rows, totalMisFit will always be set to true 
and the whole table is layed out on next page, and next page again and again ...
  
  I'm not 100% certain just adding noCellsFitted to the condition covers all 
bases:
  We try to layout all headerrows plus 1, but afaics we have to considder 
spanned rows when first nonheaderrow spans rows.
  See attached path for a suggested solution.
  (Maybe also if last headerrow spans rows, but well, probably not a common 
case ;)
  
  Also, if this minimum does not fit on a virgin page, I think we should just 
lay it out and hope for the best.
  I added some code for this in the attached patch, but I'm not sure it is the 
right way, or complete.
  F6482937: y.diff 

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Ok, think I'm on to something.
  Testing with the 1.doc in bug 381341. It seems it fails on the table in 
approx page 222 (open in LO)
  with text in 0,0: Экономический субъект
  Stepping through the KoTextLayoutTableArea::layoutRow(), it seems *all* 
columns in row 0 (at least) spans rows and hence (I think) layouting does not 
work.
  
  I probably don't have more time to spend on this before next week, so please 
have a look :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Had a closer look at this. Afaics we get an infinit loop when a table is 
'totally misfit',
  Can't say I understand the table layout logic, but my assumption is that if a 
row is a total misfit it can't just be ignored,
  so breaking off the row layout loop in this case seems to work:
  
  F6473096: x.diff 

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Would it be possible to make a unit test?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16756: CalloutShape: Add a new shape to handle callouts

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:2e1aaae999f3: CalloutShape: Add a new shape to handle 
callouts (authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16756?vs=45112=45447

REVISION DETAIL
  https://phabricator.kde.org/D16756

AFFECTED FILES
  plugins/pathshapes/CMakeLists.txt
  plugins/pathshapes/PathShapesPlugin.cpp
  plugins/pathshapes/enhancedpath/CalloutShape.cpp
  plugins/pathshapes/enhancedpath/CalloutShape.h
  plugins/pathshapes/enhancedpath/CalloutShapeFactory.cpp
  plugins/pathshapes/enhancedpath/CalloutShapeFactory.h
  plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
  plugins/pathshapes/enhancedpath/EnhancedPathShape.h
  plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp
  plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.h

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16756: CalloutShape: Add a new shape to handle callouts

[Dag Andersen]

danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  This is the start of a dedicated callout shape.
  It uses draw:type to identify callouts, same as LO/OO.
  Unfortunatwly it abuses odf, but if we shall be compatible
  with LO/OO I see no other option.
  
  Roundtrips via LO works both ways and LO's ui also works with
  callout produced with stage.
  
  TODO:
  
  - Shearing and rotation
  - Needs new tool for resize/move of 'bubble' part
  
  Known problem:
  Rounding (?) problem when calculating position/size offsets,
  but this will be changed anyway when shearing/rotation is implemented.

REPOSITORY
  R8 Calligra

BRANCH
  callout_danders

REVISION DETAIL
  https://phabricator.kde.org/D16756

AFFECTED FILES
  plugins/pathshapes/CMakeLists.txt
  plugins/pathshapes/PathShapesPlugin.cpp
  plugins/pathshapes/enhancedpath/CalloutShape.cpp
  plugins/pathshapes/enhancedpath/CalloutShape.h
  plugins/pathshapes/enhancedpath/CalloutShapeFactory.cpp
  plugins/pathshapes/enhancedpath/CalloutShapeFactory.h
  plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
  plugins/pathshapes/enhancedpath/EnhancedPathShape.h
  plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp
  plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.h

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever