Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
Hi @erget, >From what you describe, should the dates _always_ be the date of minting a >release, rather than the date merging. That could clear things up? I think a >quick chat later would be good! I'd also like to add a _merger_ item for the data model: Merger checklist - [ ] - [ ] Data model has been considered in the related issue(s)? In most cases cases the data model is not impacted, but I think that it would be good to see a comment stating that it has been thought about in the related issue, rather than relying on a default assumption that "no mention = no impact". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-831834959__;Iw!!G2kpM7uM-TzIFchu!mnWZIKMqqiZub4bHEK_D-TAgz9CAcVyuSn2KTcQUN7swqo9O76EmllpiVG_gNWUhfNo9VXURBvA$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
Hi @davidhassell as secretary I consider you the oracle of minting releases, so I'm sure you're right. The thought that I had was, if we're merging continuously into master, and then only tagging at certain points on master, then we'd be updating the dates in the history superfluously, no? Which wouldn't be bad, but life is made of tiny problems to solve, so we could perhaps do without and do it as part of a tagging checklist. It might be easier to chat about it this afternoon when we meet at 2 anyway :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-831831259__;Iw!!G2kpM7uM-TzIFchu!jEebkIorsvLSBsv-vGBfmnvvPZHpMZC0wUyFsJ_m9nXBTpVpCGrpaFf7BMVbKjn6LxeIPcVisSo$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
Hi @erget, I don't know. I had thought that we would merge PRs into master at the time of their acceptance, so that future PRs for the same next release can build on the accepted changes. I may well have misunderstood things, apologies if so, but in any event, if we say "Set the date when merged into master for new history.adoc entries", are we covered? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-831829758__;Iw!!G2kpM7uM-TzIFchu!h9dEGowEoLwAiDSr4O9UOmzhZMhgwSMlZg4uiEvHyN7F7vV3RqFIc6tAT3qt8kJmtDLPThQscaY$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
@davidhassell the author checklist looks correct for me. From my side I have 1 more question about the merger checklist - does `history.adoc` get its date updated when merged, or when tagged? My understanding is that we might merge multiple PRs into a tag-ready branch, but then only tag it when we want to make a new release, meaning that the tag would pull in changes from multiple PRs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-831824728__;Iw!!G2kpM7uM-TzIFchu!l4VjRz26LUNmSb0tzTGElcystAuWxwdwiAtjROIQRVc4ldn7jFX5ihiTPcbvvb8N4u-Q8U6yQRg$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
Sounds good, thanks. How about: Author checklist - [ ] Authors updated in cf-conventions.adoc? - [ ] Conformance document up-to-date? - [ ] Related issues registered in history.adoc, with placeholders for the dates? Merger checklist - [ ] Set dates for new history.adoc entries? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-831821630__;Iw!!G2kpM7uM-TzIFchu!lw3PkgfJpQKbM4gUHlNjWBGa6zGAZzvD99I89BapvDv6FAWKJ6pnLjcN0Dy-uxA_TvfRsD2mKZU$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
Dear both I agree with David on making such a change, and with Daniel that we should ask the author to supply the information for their update in the history, even though they can't add the date and version. Thanks Jonathan -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-830060511__;Iw!!G2kpM7uM-TzIFchu!k0hjaRGhf9HzYhmJuvIAirHpzE0TX6FO_1DRF6k72dtog9wQTnRreQZUF-ufWCKYvfRXfTuRJvI$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
@davidhassell you have my support, since we're merging continually and minting releases periodically this makes sense to me. Rather than removing "history.adoc up to date?" we might consider using "history.adoc updated?" in order to ensure that we note the changes, and then when creating a new release we fill in the date as part of _that_ checklist. That would ensure that the Author at least proposes the new lines in history.adoc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325*issuecomment-830033002__;Iw!!G2kpM7uM-TzIFchu!g8Lw3Y61kpwp7MkYkM60NsHFGl24lx0bqWrZARAeLfMBVqzTZxTzNBt0gPLh1I7k-PZM_i4Ugyc$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
[CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)
Hello, I would like to suggest a couple of changes to the Pull Request template. The release checklist currently has: - [ ] Authors updated in cf-conventions.adoc? - [ ] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer. - [ ] history.adoc up to date? - [ ] Conformance document up-to-date? I propose removing two items, changing it to - [ ] Authors updated in cf-conventions.adoc? - [ ] Conformance document up-to-date? These changes reflect the fact that * The version may or may not have already been incremented, and in any case it is beyond the scope of the PR. * The history entry should include the date when the PR was merged, which is unknown to the proposer. The history should instead be updated by the merger, and in any event the history checked prior to a release. Perhaps we chould have two checklists - one for the Author and one for the Merger - that might look like: Author checklist - [ ] Authors updated in cf-conventions.adoc? - [ ] Conformance document up-to-date? Merger checklist - [ ] history.adoc up to date? Thoughts welcome! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/325__;!!G2kpM7uM-TzIFchu!mhMVz908DObfit-wHj2wkc-GoiTguuFDmW08ML2EIZi76wK89ZbKJGqWPRrelLO-T9h2HUGstsk$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
