Re: [CF-metadata] [cf-convention/cf-conventions] implement tickets 298 and 319 (#331)
@JonathanGregory pushed 1 commit. bd7498d3625a1ee464f375952bfd202f7fbc4371 remove redundant text about the standard calendar, clarify the deprecation of year and month units -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331/files/41b1a88f318a437a7701b15dca705ae7cf83c7d7..bd7498d3625a1ee464f375952bfd202f7fbc4371__;!!G2kpM7uM-TzIFchu!hLciP1XKYyIw24EeQDL5v_IBUMOfAYMJEpXNdYOTIhaoEP-ei71mJ3PKqeLZYXeaIhyXySLQDs8$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] implement tickets 298 and 319 (#331)
@zklaus commented on this pull request. > We recommend that the unit **`year`** be used with caution. The Udunits > package defines a **`year`** to be exactly 365.242198781 days (the interval > between 2 successive passages of the sun through vernal equinox). __It is not > a calendar year.__ Udunits includes the following definitions for years: a > **`common_year`** is 365 days, a **`leap_year`** is 366 days, a > **`Julian_year`** is 365.25 days, and a **`Gregorian_year`** is 365.2425 days. Perhaps this is a good opportunity to update the second `udunits.dat` link in the following line 217 as well. I also wonder if we should be explicit in whether CF follows udunits in the definitions of year and month. The way these two paragraphs are written, the reader might come away with the impression that we are only warning of potential misinterpretation by some other software, whereas my understanding so far is that we adopt the udunits definition, albeit begrudgingly. But perhaps my understand is wrong or you would prefer to address this in a separate issue? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331*pullrequestreview-698116628__;Iw!!G2kpM7uM-TzIFchu!mhPiWh-LwYmnmiQt5IEjICNGBndKP5wPsM8E2Xmrd21amAKc1zLZ3xxI2Kj_512peloWXhHqYV4$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
[CF-metadata] [cf-convention/cf-conventions] implement tickets 298 and 319 (#331)
See issue #298 and #319 for discussion of these changes. # Release checklist - [Y] Authors updated in `cf-conventions.adoc`? - [Y] Next version in `cf-conventions.adoc` up to date? Versioning inspired by [SemVer](https://urldefense.us/v3/__https://semver.org__;!!G2kpM7uM-TzIFchu!lEhHX7Dlzu_DokMmU3XI1HiF2bm-ZCpzGwYBXtBSdi9zNW-2Hrx8TOQCdXFoyCNSJoP_g0Y7trg$ ). - [Y] `history.adoc` up to date? - [Y] Conformance document up-to-date? # For maintainers After the merge remember to delete the source branch. Tags are set at the conclusion of the annual meeting; until then `master` always is a draft for the next version. You can view, comment on, or merge this pull request online at: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331__;!!G2kpM7uM-TzIFchu!lEhHX7Dlzu_DokMmU3XI1HiF2bm-ZCpzGwYBXtBSdi9zNW-2Hrx8TOQCdXFoyCNSJoP_PRtu7Zo$ -- Commit Summary -- * implement tickets 298 and 319 -- File Changes -- M cf-conventions.adoc (1) M ch04.adoc (38) M ch07.adoc (2) M conformance.adoc (17) M history.adoc (4) -- Patch Links -- https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331.patch__;!!G2kpM7uM-TzIFchu!lEhHX7Dlzu_DokMmU3XI1HiF2bm-ZCpzGwYBXtBSdi9zNW-2Hrx8TOQCdXFoyCNSJoP_EWcFqXQ$ https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331.diff__;!!G2kpM7uM-TzIFchu!lEhHX7Dlzu_DokMmU3XI1HiF2bm-ZCpzGwYBXtBSdi9zNW-2Hrx8TOQCdXFoyCNSJoP_-_sxsBY$ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331__;!!G2kpM7uM-TzIFchu!lEhHX7Dlzu_DokMmU3XI1HiF2bm-ZCpzGwYBXtBSdi9zNW-2Hrx8TOQCdXFoyCNSJoP_PRtu7Zo$ This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
