Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
Merged #232 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232#event-3057227956 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
@erget pushed 1 commit. 1f4eaef80eaa4b914170e9f554c78cff7d5e27d1 Merge branch 'master' into 230-fix-geostationary-projection -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232/files/47fef64258234d3a9ee6c55e19b6937248057a36..1f4eaef80eaa4b914170e9f554c78cff7d5e27d1 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
@erget pushed 1 commit. 47fef64258234d3a9ee6c55e19b6937248057a36 Update history.adoc -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232/files/c73544ef080c8ed7a3c91471322b6e97120f0d6a..47fef64258234d3a9ee6c55e19b6937248057a36 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
@erget pushed 1 commit. c73544ef080c8ed7a3c91471322b6e97120f0d6a Clarify deprecation of standard names -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232/files/e965f0eb506228268c0a932453e7abb9d5d47aeb..c73544ef080c8ed7a3c91471322b6e97120f0d6a This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
davidhassell commented on this pull request. > @@ -79,17 +79,30 @@ __Map parameters:__:: * **`sweep_angle_axis`** * **`fixed_angle_axis`** -__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_coordinate`** and **`projection_y_coordinate`** respectively. In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument, and their units are radians. +__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** or **`projection_x_coordinate`** (deprecated) and **`projection_y_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), respectively. That's much better! Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232#discussion_r369073023 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
JimBiardCics commented on this pull request. > @@ -79,17 +79,30 @@ __Map parameters:__:: * **`sweep_angle_axis`** * **`fixed_angle_axis`** -__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_coordinate`** and **`projection_y_coordinate`** respectively. In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument, and their units are radians. +__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** or **`projection_x_coordinate`** (deprecated) and **`projection_y_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), respectively. How about a more direct approach? I think it will be less confusing. __Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** and **`projection_y_angular_coordinate`** respectively. CF specified the standard names **`projection_x_coordinate`** and **`projection_y_coordinate`** for these coordinates prior to version 1.9, but that use is deprecated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232#discussion_r369032765 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
davidhassell commented on this pull request. > @@ -79,17 +79,30 @@ __Map parameters:__:: * **`sweep_angle_axis`** * **`fixed_angle_axis`** -__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_coordinate`** and **`projection_y_coordinate`** respectively. In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument, and their units are radians. +__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** or **`projection_x_coordinate`** (deprecated) and **`projection_y_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), respectively. This sentence has a lot of "or"s and "and"s. Perhaps an extra comma after the first "(deprecated)" might help parsing? __Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), **[[new comma here]]** and **`projection_y_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), respectively. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232#pullrequestreview-345717612 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
erget commented on this pull request. > @@ -79,17 +79,30 @@ __Map parameters:__:: * **`sweep_angle_axis`** * **`fixed_angle_axis`** -__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_coordinate`** and **`projection_y_coordinate`** respectively. In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument, and their units are radians. +__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** or **`projection_x_coordinate`** (deprecated) and **`projection_y_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), respectively. +In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument. I feel torn here because the units are actually up to the user, whereas they must be compatible with the canonical units. Those are connected to the `standard_name` used and in order to reduce redundancy I wouldn't call it up here. I think they were mentioned before because the paragraph was essentially overwriting the standard names table's values in this special case. Optimally, from 1.9 I'd like to completely remove the use of the old units rather than simply deprecating it but that's probably a bridge too far. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232#discussion_r368617304 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
lesserwhirls commented on this pull request. > @@ -79,17 +79,30 @@ __Map parameters:__:: * **`sweep_angle_axis`** * **`fixed_angle_axis`** -__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_coordinate`** and **`projection_y_coordinate`** respectively. In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument, and their units are radians. +__Map coordinates:__:: The x (abscissa) and y (ordinate) rectangular coordinates are identified by the **`standard_name`** attribute values **`projection_x_angular_coordinate`** or **`projection_x_coordinate`** (deprecated) and **`projection_y_angular_coordinate`** or **`projection_x_coordinate`** (deprecated), respectively. +In the case of this projection, the projection coordinates in this projection are directly related to the scanning angle of the satellite instrument. Perhaps the intent of the proposal is clouded by the removal of the explicit use of radians in this sentence, although it is still called out explicitly in line 104 as part of the explanation of the change in starting in 1.9? If so, would it help to put it back so it's right up front? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232#pullrequestreview-344925775 This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
Re: [CF-metadata] [cf-convention/cf-conventions] Fix geostationary projection (#232)
@erget pushed 1 commit. e965f0eb506228268c0a932453e7abb9d5d47aeb Defer deprecating old geostationary units to 1.9 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/cf-convention/cf-conventions/pull/232/files/e5b75d18eafb2dfe5da7a960d83c2a1817fa0d37..e965f0eb506228268c0a932453e7abb9d5d47aeb This list forwards relevant notifications from Github. It is distinct from cf-metad...@cgd.ucar.edu, although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to cf-metadata-unsubscribe-requ...@listserv.llnl.gov.
