[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia closed this revision.
Anastasia added a comment.

Committed in 
https://github.com/llvm/llvm-project/commit/5e1b36ced538cfc80f2400b27e346d2175b04092.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh accepted this revision.
svenvh added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!




Comment at: clang/docs/ReleaseNotes.rst:676
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang

Anastasia wrote:
> svenvh wrote:
> > Should we say anything about opaque pointers?  Something like:
> > 
> > ```
> >  - Although LLVM has switched to opaque pointers with this release, SPIR-V 
> > generation still relies on typed pointers in this release.
> > ```
> Sure, good point! I have added an item to clarify this. Does it look ok to 
> you?
generation -> generator I'd say, which you can address at commit time.  For the 
rest it looks good!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added inline comments.



Comment at: clang/docs/ReleaseNotes.rst:676
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang

svenvh wrote:
> Should we say anything about opaque pointers?  Something like:
> 
> ```
>  - Although LLVM has switched to opaque pointers with this release, SPIR-V 
> generation still relies on typed pointers in this release.
> ```
Sure, good point! I have added an item to clarify this. Does it look ok to you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia updated this revision to Diff 455139.
Anastasia added a comment.

- Added clarification about the opaque pointers in SPIR-V.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -566,10 +566,18 @@
 Objective-C Language Changes in Clang
 -
 
-OpenCL C Language Changes in Clang
---
-
-...
+OpenCL Kernel Language Changes in Clang
+---
+
+- Improved/fixed misc issues in the builtin function support and diagnostics.
+- Improved diagnostics for unknown extension pragma, subgroup functions and
+  implicit function prototype.
+- Added ``-cl-ext`` flag to the Clang driver to toggle extensions/features
+  compiled for.
+- Added ``cl_khr_subgroup_rotate`` extension.
+- Removed some ``printf`` and ``hostcall`` related diagnostics when compiling
+  for AMDGPU.
+- Fixed alignment of pointer types in kernel arguments.
 
 ABI Changes in Clang
 
@@ -660,6 +668,14 @@
   Operations found in the :ref:`Clang Language Extensions `
   document.
 
+SPIR-V Support in Clang
+---
+
+- Added flag ``-fintegrated-objemitter`` to enable use of experimental
+  integrated LLVM backend when generating SPIR-V binary.
+- The SPIR-V generation continues to produce typed pointers in this release
+  despite the general switch of LLVM to opaque pointers.
+
 Floating Point Support in Clang
 ---
 


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -566,10 +566,18 @@
 Objective-C Language Changes in Clang
 -
 
-OpenCL C Language Changes in Clang
---
-
-...
+OpenCL Kernel Language Changes in Clang
+---
+
+- Improved/fixed misc issues in the builtin function support and diagnostics.
+- Improved diagnostics for unknown extension pragma, subgroup functions and
+  implicit function prototype.
+- Added ``-cl-ext`` flag to the Clang driver to toggle extensions/features
+  compiled for.
+- Added ``cl_khr_subgroup_rotate`` extension.
+- Removed some ``printf`` and ``hostcall`` related diagnostics when compiling
+  for AMDGPU.
+- Fixed alignment of pointer types in kernel arguments.
 
 ABI Changes in Clang
 
@@ -660,6 +668,14 @@
   Operations found in the :ref:`Clang Language Extensions `
   document.
 
+SPIR-V Support in Clang
+---
+
+- Added flag ``-fintegrated-objemitter`` to enable use of experimental
+  integrated LLVM backend when generating SPIR-V binary.
+- The SPIR-V generation continues to produce typed pointers in this release
+  despite the general switch of LLVM to opaque pointers.
+
 Floating Point Support in Clang
 ---
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added a comment.

In D132473#3742688 , @Anastasia wrote:

> @svenvh as you made quite a lot of changes in the headers feel free to expand 
> the description if you feel we should document some of those in more detail.

I think you have captured it quite well already; they were mostly small fixes 
(although many).




Comment at: clang/docs/ReleaseNotes.rst:676
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang

Should we say anything about opaque pointers?  Something like:

```
 - Although LLVM has switched to opaque pointers with this release, SPIR-V 
generation still relies on typed pointers in this release.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia updated this revision to Diff 454838.
Anastasia added a comment.

Minor formatting changes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -566,10 +566,18 @@
 Objective-C Language Changes in Clang
 -
 
-OpenCL C Language Changes in Clang
---
-
-...
+OpenCL Kernel Language Changes in Clang
+---
+
+- Improved/fixed misc issues in the builtin function support and diagnostics.
+- Improved diagnostics for unknown extension pragma, subgroup functions and
+  implicit function prototype.
+- Added ``-cl-ext`` flag to the Clang driver to toggle extensions/features
+  compiled for.
+- Added ``cl_khr_subgroup_rotate`` extension.
+- Removed some ``printf`` and ``hostcall`` related diagnostics when compiling
+  for AMDGPU.
+- Fixed alignment of pointer types in kernel arguments.
 
 ABI Changes in Clang
 
@@ -660,6 +668,12 @@
   Operations found in the :ref:`Clang Language Extensions `
   document.
 
+SPIR-V Support in Clang
+---
+
+- Added flag ``-fintegrated-objemitter`` to enable use of experimental 
integrated
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang
 ---
 


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -566,10 +566,18 @@
 Objective-C Language Changes in Clang
 -
 
-OpenCL C Language Changes in Clang
---
-
-...
+OpenCL Kernel Language Changes in Clang
+---
+
+- Improved/fixed misc issues in the builtin function support and diagnostics.
+- Improved diagnostics for unknown extension pragma, subgroup functions and
+  implicit function prototype.
+- Added ``-cl-ext`` flag to the Clang driver to toggle extensions/features
+  compiled for.
+- Added ``cl_khr_subgroup_rotate`` extension.
+- Removed some ``printf`` and ``hostcall`` related diagnostics when compiling
+  for AMDGPU.
+- Fixed alignment of pointer types in kernel arguments.
 
 ABI Changes in Clang
 
@@ -660,6 +668,12 @@
   Operations found in the :ref:`Clang Language Extensions `
   document.
 
+SPIR-V Support in Clang
+---
+
+- Added flag ``-fintegrated-objemitter`` to enable use of experimental integrated
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang
 ---
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

@svenvh as you made quite a lot of changes in the headers feel free to expand 
the description if you feel we should document some of those in more detail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132473/new/

https://reviews.llvm.org/D132473

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia created this revision.
Anastasia added a reviewer: svenvh.
Herald added subscribers: ebevhan, yaxunl.
Herald added a project: All.
Anastasia requested review of this revision.

Added list of functional changes to release notes.


https://reviews.llvm.org/D132473

Files:
  clang/docs/ReleaseNotes.rst


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -566,10 +566,18 @@
 Objective-C Language Changes in Clang
 -
 
-OpenCL C Language Changes in Clang
---
-
-...
+OpenCL Kernel Language Changes in Clang
+---
+
+- Improved/fixed misc issues in the builtin function support and diagnostics.
+- Improved diagnostics for unknown extension pragma, subgroup functions and
+  implicit function prototype.
+- Added `-cl-ext` flag to the Clang driver to toggle extensions/features
+  compiled for.
+- Added `cl_khr_subgroup_rotate` extension.
+- Removed some `printf` and `hostcall` related diagnostics when compiling for
+  AMDGPU.
+- Fixed alignment of pointer types in kernel arguments.
 
 ABI Changes in Clang
 
@@ -660,6 +668,12 @@
   Operations found in the :ref:`Clang Language Extensions `
   document.
 
+SPIR-V Support in Clang
+---
+
+- Added flag `-fintegrated-objemitter` to enable use of experimental integrated
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang
 ---
 


Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -566,10 +566,18 @@
 Objective-C Language Changes in Clang
 -
 
-OpenCL C Language Changes in Clang
---
-
-...
+OpenCL Kernel Language Changes in Clang
+---
+
+- Improved/fixed misc issues in the builtin function support and diagnostics.
+- Improved diagnostics for unknown extension pragma, subgroup functions and
+  implicit function prototype.
+- Added `-cl-ext` flag to the Clang driver to toggle extensions/features
+  compiled for.
+- Added `cl_khr_subgroup_rotate` extension.
+- Removed some `printf` and `hostcall` related diagnostics when compiling for
+  AMDGPU.
+- Fixed alignment of pointer types in kernel arguments.
 
 ABI Changes in Clang
 
@@ -660,6 +668,12 @@
   Operations found in the :ref:`Clang Language Extensions `
   document.
 
+SPIR-V Support in Clang
+---
+
+- Added flag `-fintegrated-objemitter` to enable use of experimental integrated
+  LLVM backend when generating SPIR-V binary.
+
 Floating Point Support in Clang
 ---
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits