[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

`computeTargetTriple` has several users. You probably want to check all these 
code paths do not need `if (const Arg *A = 
Args.getLastArg(options::OPT_target))`.
For the uses in `BuildCompilation`, it seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145146/new/

https://reviews.llvm.org/D145146

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

[WangLian via Phabricator via cfe-commits]

Jimerlife added a comment.

ping...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145146/new/

https://reviews.llvm.org/D145146

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

[WangLian via Phabricator via cfe-commits]

Jimerlife created this revision.
Jimerlife added reviewers: phosek, kazu, abrachet.
Jimerlife added a project: LLVM.
Herald added a project: All.
Jimerlife requested review of this revision.
Herald added subscribers: cfe-commits, jacquesguan, MaskRay.
Herald added a project: clang.

`options::OPT_target` has been done in `Driver::BuildCompilation`, so I think 
this part of code is redundant.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145146

Files:
  clang/lib/Driver/Driver.cpp


Index: clang/lib/Driver/Driver.cpp
===
--- clang/lib/Driver/Driver.cpp
+++ clang/lib/Driver/Driver.cpp
@@ -527,10 +527,6 @@
 StringRef TargetTriple,
 const ArgList ,
 StringRef DarwinArchName = "") {
-  // FIXME: Already done in Compilation *Driver::BuildCompilation
-  if (const Arg *A = Args.getLastArg(options::OPT_target))
-TargetTriple = A->getValue();
-
   llvm::Triple Target(llvm::Triple::normalize(TargetTriple));
 
   // GNU/Hurd's triples should have been -hurd-gnu*, but were historically made


Index: clang/lib/Driver/Driver.cpp
===
--- clang/lib/Driver/Driver.cpp
+++ clang/lib/Driver/Driver.cpp
@@ -527,10 +527,6 @@
 StringRef TargetTriple,
 const ArgList ,
 StringRef DarwinArchName = "") {
-  // FIXME: Already done in Compilation *Driver::BuildCompilation
-  if (const Arg *A = Args.getLastArg(options::OPT_target))
-TargetTriple = A->getValue();
-
   llvm::Triple Target(llvm::Triple::normalize(TargetTriple));
 
   // GNU/Hurd's triples should have been -hurd-gnu*, but were historically made
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits