Re: r259507 - Make the remaining headers self-contained.
Out of curiosity, what technique were you using to find out if the headers were self-contained? Just "clang -c foo.h"? Cheers, Rafael On 2 February 2016 at 09:24, Benjamin Kramer via cfe-commitswrote: > Author: d0k > Date: Tue Feb 2 08:24:21 2016 > New Revision: 259507 > > URL: http://llvm.org/viewvc/llvm-project?rev=259507=rev > Log: > Make the remaining headers self-contained. > > Modified: > cfe/trunk/include/clang/AST/BaseSubobject.h > cfe/trunk/include/clang/AST/DeclOpenMP.h > cfe/trunk/include/clang/AST/Mangle.h > cfe/trunk/include/clang/AST/TemplateName.h > cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h > cfe/trunk/include/clang/Sema/ObjCMethodList.h > cfe/trunk/include/clang/Sema/Ownership.h > cfe/trunk/include/clang/Sema/Scope.h > cfe/trunk/include/clang/Sema/SemaLambda.h > cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h > cfe/trunk/lib/CodeGen/CodeGenTBAA.h > > Modified: cfe/trunk/include/clang/AST/BaseSubobject.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/BaseSubobject.h?rev=259507=259506=259507=diff > == > --- cfe/trunk/include/clang/AST/BaseSubobject.h (original) > +++ cfe/trunk/include/clang/AST/BaseSubobject.h Tue Feb 2 08:24:21 2016 > @@ -15,13 +15,12 @@ > #define LLVM_CLANG_AST_BASESUBOBJECT_H > > #include "clang/AST/CharUnits.h" > +#include "clang/AST/DeclCXX.h" > #include "llvm/ADT/DenseMap.h" > #include "llvm/Support/DataTypes.h" > #include "llvm/Support/type_traits.h" > > namespace clang { > - class CXXRecordDecl; > - > // BaseSubobject - Uniquely identifies a direct or indirect base class. > // Stores both the base class decl and the offset from the most derived > class to > // the base class. Used for vtable and VTT generation. > > Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclOpenMP.h?rev=259507=259506=259507=diff > == > --- cfe/trunk/include/clang/AST/DeclOpenMP.h (original) > +++ cfe/trunk/include/clang/AST/DeclOpenMP.h Tue Feb 2 08:24:21 2016 > @@ -17,6 +17,7 @@ > > #include "clang/AST/DeclBase.h" > #include "llvm/ADT/ArrayRef.h" > +#include "llvm/Support/TrailingObjects.h" > > namespace clang { > class Expr; > > Modified: cfe/trunk/include/clang/AST/Mangle.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Mangle.h?rev=259507=259506=259507=diff > == > --- cfe/trunk/include/clang/AST/Mangle.h (original) > +++ cfe/trunk/include/clang/AST/Mangle.h Tue Feb 2 08:24:21 2016 > @@ -14,6 +14,7 @@ > #ifndef LLVM_CLANG_AST_MANGLE_H > #define LLVM_CLANG_AST_MANGLE_H > > +#include "clang/AST/Decl.h" > #include "clang/AST/Type.h" > #include "clang/Basic/ABI.h" > #include "llvm/ADT/DenseMap.h" > > Modified: cfe/trunk/include/clang/AST/TemplateName.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateName.h?rev=259507=259506=259507=diff > == > --- cfe/trunk/include/clang/AST/TemplateName.h (original) > +++ cfe/trunk/include/clang/AST/TemplateName.h Tue Feb 2 08:24:21 2016 > @@ -14,6 +14,7 @@ > #ifndef LLVM_CLANG_AST_TEMPLATENAME_H > #define LLVM_CLANG_AST_TEMPLATENAME_H > > +#include "clang/AST/NestedNameSpecifier.h" > #include "clang/Basic/LLVM.h" > #include "llvm/ADT/FoldingSet.h" > #include "llvm/ADT/PointerUnion.h" > > Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=259507=259506=259507=diff > == > --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h (original) > +++ cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h Tue Feb 2 08:24:21 > 2016 > @@ -15,6 +15,7 @@ > > #include "clang-c/Index.h" > #include "clang/AST/CanonicalType.h" > +#include "clang/AST/DeclBase.h" > #include "clang/AST/Type.h" > #include "clang/Sema/CodeCompleteOptions.h" > #include "llvm/ADT/DenseMap.h" > > Modified: cfe/trunk/include/clang/Sema/ObjCMethodList.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ObjCMethodList.h?rev=259507=259506=259507=diff > == > --- cfe/trunk/include/clang/Sema/ObjCMethodList.h (original) > +++ cfe/trunk/include/clang/Sema/ObjCMethodList.h Tue Feb 2 08:24:21 2016 > @@ -14,6 +14,7 @@ > #ifndef LLVM_CLANG_SEMA_OBJCMETHODLIST_H > #define LLVM_CLANG_SEMA_OBJCMETHODLIST_H > > +#include "clang/AST/DeclObjC.h" > #include "llvm/ADT/PointerIntPair.h" > > namespace clang { > > Modified:
Re: r259507 - Make the remaining headers self-contained.
On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola < cfe-commits@lists.llvm.org> wrote: > Out of curiosity, what technique were you using to find out if the > headers were self-contained? Just "clang -c foo.h"? > Building LLVM & Clang with C++ modules enabled > > Cheers, > Rafael > > > On 2 February 2016 at 09:24, Benjamin Kramer via cfe-commits >wrote: > > Author: d0k > > Date: Tue Feb 2 08:24:21 2016 > > New Revision: 259507 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=259507=rev > > Log: > > Make the remaining headers self-contained. > > > > Modified: > > cfe/trunk/include/clang/AST/BaseSubobject.h > > cfe/trunk/include/clang/AST/DeclOpenMP.h > > cfe/trunk/include/clang/AST/Mangle.h > > cfe/trunk/include/clang/AST/TemplateName.h > > cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h > > cfe/trunk/include/clang/Sema/ObjCMethodList.h > > cfe/trunk/include/clang/Sema/Ownership.h > > cfe/trunk/include/clang/Sema/Scope.h > > cfe/trunk/include/clang/Sema/SemaLambda.h > > cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h > > cfe/trunk/lib/CodeGen/CodeGenTBAA.h > > > > Modified: cfe/trunk/include/clang/AST/BaseSubobject.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/BaseSubobject.h?rev=259507=259506=259507=diff > > > == > > --- cfe/trunk/include/clang/AST/BaseSubobject.h (original) > > +++ cfe/trunk/include/clang/AST/BaseSubobject.h Tue Feb 2 08:24:21 2016 > > @@ -15,13 +15,12 @@ > > #define LLVM_CLANG_AST_BASESUBOBJECT_H > > > > #include "clang/AST/CharUnits.h" > > +#include "clang/AST/DeclCXX.h" > > #include "llvm/ADT/DenseMap.h" > > #include "llvm/Support/DataTypes.h" > > #include "llvm/Support/type_traits.h" > > > > namespace clang { > > - class CXXRecordDecl; > > - > > // BaseSubobject - Uniquely identifies a direct or indirect base class. > > // Stores both the base class decl and the offset from the most derived > class to > > // the base class. Used for vtable and VTT generation. > > > > Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclOpenMP.h?rev=259507=259506=259507=diff > > > == > > --- cfe/trunk/include/clang/AST/DeclOpenMP.h (original) > > +++ cfe/trunk/include/clang/AST/DeclOpenMP.h Tue Feb 2 08:24:21 2016 > > @@ -17,6 +17,7 @@ > > > > #include "clang/AST/DeclBase.h" > > #include "llvm/ADT/ArrayRef.h" > > +#include "llvm/Support/TrailingObjects.h" > > > > namespace clang { > > class Expr; > > > > Modified: cfe/trunk/include/clang/AST/Mangle.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Mangle.h?rev=259507=259506=259507=diff > > > == > > --- cfe/trunk/include/clang/AST/Mangle.h (original) > > +++ cfe/trunk/include/clang/AST/Mangle.h Tue Feb 2 08:24:21 2016 > > @@ -14,6 +14,7 @@ > > #ifndef LLVM_CLANG_AST_MANGLE_H > > #define LLVM_CLANG_AST_MANGLE_H > > > > +#include "clang/AST/Decl.h" > > #include "clang/AST/Type.h" > > #include "clang/Basic/ABI.h" > > #include "llvm/ADT/DenseMap.h" > > > > Modified: cfe/trunk/include/clang/AST/TemplateName.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateName.h?rev=259507=259506=259507=diff > > > == > > --- cfe/trunk/include/clang/AST/TemplateName.h (original) > > +++ cfe/trunk/include/clang/AST/TemplateName.h Tue Feb 2 08:24:21 2016 > > @@ -14,6 +14,7 @@ > > #ifndef LLVM_CLANG_AST_TEMPLATENAME_H > > #define LLVM_CLANG_AST_TEMPLATENAME_H > > > > +#include "clang/AST/NestedNameSpecifier.h" > > #include "clang/Basic/LLVM.h" > > #include "llvm/ADT/FoldingSet.h" > > #include "llvm/ADT/PointerUnion.h" > > > > Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=259507=259506=259507=diff > > > == > > --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h (original) > > +++ cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h Tue Feb 2 > 08:24:21 2016 > > @@ -15,6 +15,7 @@ > > > > #include "clang-c/Index.h" > > #include "clang/AST/CanonicalType.h" > > +#include "clang/AST/DeclBase.h" > > #include "clang/AST/Type.h" > > #include "clang/Sema/CodeCompleteOptions.h" > > #include "llvm/ADT/DenseMap.h" > > > > Modified: cfe/trunk/include/clang/Sema/ObjCMethodList.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ObjCMethodList.h?rev=259507=259506=259507=diff > > > == > > ---
Re: r259507 - Make the remaining headers self-contained.
On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola < > cfe-commits@lists.llvm.org> wrote: > >> Out of curiosity, what technique were you using to find out if the >> headers were self-contained? Just "clang -c foo.h"? >> > > Building LLVM & Clang with C++ modules enabled > Takumi, is there a reason that your bot was not finding these issues? -- Sean Silva > > >> >> Cheers, >> Rafael >> >> >> On 2 February 2016 at 09:24, Benjamin Kramer via cfe-commits >>wrote: >> > Author: d0k >> > Date: Tue Feb 2 08:24:21 2016 >> > New Revision: 259507 >> > >> > URL: http://llvm.org/viewvc/llvm-project?rev=259507=rev >> > Log: >> > Make the remaining headers self-contained. >> > >> > Modified: >> > cfe/trunk/include/clang/AST/BaseSubobject.h >> > cfe/trunk/include/clang/AST/DeclOpenMP.h >> > cfe/trunk/include/clang/AST/Mangle.h >> > cfe/trunk/include/clang/AST/TemplateName.h >> > cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >> > cfe/trunk/include/clang/Sema/ObjCMethodList.h >> > cfe/trunk/include/clang/Sema/Ownership.h >> > cfe/trunk/include/clang/Sema/Scope.h >> > cfe/trunk/include/clang/Sema/SemaLambda.h >> > cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h >> > cfe/trunk/lib/CodeGen/CodeGenTBAA.h >> > >> > Modified: cfe/trunk/include/clang/AST/BaseSubobject.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/BaseSubobject.h?rev=259507=259506=259507=diff >> > >> == >> > --- cfe/trunk/include/clang/AST/BaseSubobject.h (original) >> > +++ cfe/trunk/include/clang/AST/BaseSubobject.h Tue Feb 2 08:24:21 2016 >> > @@ -15,13 +15,12 @@ >> > #define LLVM_CLANG_AST_BASESUBOBJECT_H >> > >> > #include "clang/AST/CharUnits.h" >> > +#include "clang/AST/DeclCXX.h" >> > #include "llvm/ADT/DenseMap.h" >> > #include "llvm/Support/DataTypes.h" >> > #include "llvm/Support/type_traits.h" >> > >> > namespace clang { >> > - class CXXRecordDecl; >> > - >> > // BaseSubobject - Uniquely identifies a direct or indirect base class. >> > // Stores both the base class decl and the offset from the most >> derived class to >> > // the base class. Used for vtable and VTT generation. >> > >> > Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclOpenMP.h?rev=259507=259506=259507=diff >> > >> == >> > --- cfe/trunk/include/clang/AST/DeclOpenMP.h (original) >> > +++ cfe/trunk/include/clang/AST/DeclOpenMP.h Tue Feb 2 08:24:21 2016 >> > @@ -17,6 +17,7 @@ >> > >> > #include "clang/AST/DeclBase.h" >> > #include "llvm/ADT/ArrayRef.h" >> > +#include "llvm/Support/TrailingObjects.h" >> > >> > namespace clang { >> > class Expr; >> > >> > Modified: cfe/trunk/include/clang/AST/Mangle.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Mangle.h?rev=259507=259506=259507=diff >> > >> == >> > --- cfe/trunk/include/clang/AST/Mangle.h (original) >> > +++ cfe/trunk/include/clang/AST/Mangle.h Tue Feb 2 08:24:21 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_AST_MANGLE_H >> > #define LLVM_CLANG_AST_MANGLE_H >> > >> > +#include "clang/AST/Decl.h" >> > #include "clang/AST/Type.h" >> > #include "clang/Basic/ABI.h" >> > #include "llvm/ADT/DenseMap.h" >> > >> > Modified: cfe/trunk/include/clang/AST/TemplateName.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateName.h?rev=259507=259506=259507=diff >> > >> == >> > --- cfe/trunk/include/clang/AST/TemplateName.h (original) >> > +++ cfe/trunk/include/clang/AST/TemplateName.h Tue Feb 2 08:24:21 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_AST_TEMPLATENAME_H >> > #define LLVM_CLANG_AST_TEMPLATENAME_H >> > >> > +#include "clang/AST/NestedNameSpecifier.h" >> > #include "clang/Basic/LLVM.h" >> > #include "llvm/ADT/FoldingSet.h" >> > #include "llvm/ADT/PointerUnion.h" >> > >> > Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=259507=259506=259507=diff >> > >> == >> > --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h (original) >> > +++ cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h Tue Feb 2 >> 08:24:21 2016 >> > @@ -15,6 +15,7 @@ >> > >> > #include "clang-c/Index.h" >> > #include "clang/AST/CanonicalType.h" >> > +#include "clang/AST/DeclBase.h" >> > #include "clang/AST/Type.h" >> > #include "clang/Sema/CodeCompleteOptions.h" >> > #include
Re: r259507 - Make the remaining headers self-contained.
I am not enabling modules builder(s) since my local branch has a few commits. I will create more builders after release_38 released. On Wed, Feb 3, 2016 at 3:56 PM Sean Silvawrote: > On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola < >> cfe-commits@lists.llvm.org> wrote: >> >>> Out of curiosity, what technique were you using to find out if the >>> headers were self-contained? Just "clang -c foo.h"? >>> >> >> Building LLVM & Clang with C++ modules enabled >> > > Takumi, is there a reason that your bot was not finding these issues? > > -- Sean Silva > > >> >> >>> >>> Cheers, >>> Rafael >>> >>> >>> On 2 February 2016 at 09:24, Benjamin Kramer via cfe-commits >>> wrote: >>> > Author: d0k >>> > Date: Tue Feb 2 08:24:21 2016 >>> > New Revision: 259507 >>> > >>> > URL: http://llvm.org/viewvc/llvm-project?rev=259507=rev >>> > Log: >>> > Make the remaining headers self-contained. >>> > >>> > Modified: >>> > cfe/trunk/include/clang/AST/BaseSubobject.h >>> > cfe/trunk/include/clang/AST/DeclOpenMP.h >>> > cfe/trunk/include/clang/AST/Mangle.h >>> > cfe/trunk/include/clang/AST/TemplateName.h >>> > cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >>> > cfe/trunk/include/clang/Sema/ObjCMethodList.h >>> > cfe/trunk/include/clang/Sema/Ownership.h >>> > cfe/trunk/include/clang/Sema/Scope.h >>> > cfe/trunk/include/clang/Sema/SemaLambda.h >>> > cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h >>> > cfe/trunk/lib/CodeGen/CodeGenTBAA.h >>> > >>> > Modified: cfe/trunk/include/clang/AST/BaseSubobject.h >>> > URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/BaseSubobject.h?rev=259507=259506=259507=diff >>> > >>> == >>> > --- cfe/trunk/include/clang/AST/BaseSubobject.h (original) >>> > +++ cfe/trunk/include/clang/AST/BaseSubobject.h Tue Feb 2 08:24:21 >>> 2016 >>> > @@ -15,13 +15,12 @@ >>> > #define LLVM_CLANG_AST_BASESUBOBJECT_H >>> > >>> > #include "clang/AST/CharUnits.h" >>> > +#include "clang/AST/DeclCXX.h" >>> > #include "llvm/ADT/DenseMap.h" >>> > #include "llvm/Support/DataTypes.h" >>> > #include "llvm/Support/type_traits.h" >>> > >>> > namespace clang { >>> > - class CXXRecordDecl; >>> > - >>> > // BaseSubobject - Uniquely identifies a direct or indirect base >>> class. >>> > // Stores both the base class decl and the offset from the most >>> derived class to >>> > // the base class. Used for vtable and VTT generation. >>> > >>> > Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h >>> > URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclOpenMP.h?rev=259507=259506=259507=diff >>> > >>> == >>> > --- cfe/trunk/include/clang/AST/DeclOpenMP.h (original) >>> > +++ cfe/trunk/include/clang/AST/DeclOpenMP.h Tue Feb 2 08:24:21 2016 >>> > @@ -17,6 +17,7 @@ >>> > >>> > #include "clang/AST/DeclBase.h" >>> > #include "llvm/ADT/ArrayRef.h" >>> > +#include "llvm/Support/TrailingObjects.h" >>> > >>> > namespace clang { >>> > class Expr; >>> > >>> > Modified: cfe/trunk/include/clang/AST/Mangle.h >>> > URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Mangle.h?rev=259507=259506=259507=diff >>> > >>> == >>> > --- cfe/trunk/include/clang/AST/Mangle.h (original) >>> > +++ cfe/trunk/include/clang/AST/Mangle.h Tue Feb 2 08:24:21 2016 >>> > @@ -14,6 +14,7 @@ >>> > #ifndef LLVM_CLANG_AST_MANGLE_H >>> > #define LLVM_CLANG_AST_MANGLE_H >>> > >>> > +#include "clang/AST/Decl.h" >>> > #include "clang/AST/Type.h" >>> > #include "clang/Basic/ABI.h" >>> > #include "llvm/ADT/DenseMap.h" >>> > >>> > Modified: cfe/trunk/include/clang/AST/TemplateName.h >>> > URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateName.h?rev=259507=259506=259507=diff >>> > >>> == >>> > --- cfe/trunk/include/clang/AST/TemplateName.h (original) >>> > +++ cfe/trunk/include/clang/AST/TemplateName.h Tue Feb 2 08:24:21 2016 >>> > @@ -14,6 +14,7 @@ >>> > #ifndef LLVM_CLANG_AST_TEMPLATENAME_H >>> > #define LLVM_CLANG_AST_TEMPLATENAME_H >>> > >>> > +#include "clang/AST/NestedNameSpecifier.h" >>> > #include "clang/Basic/LLVM.h" >>> > #include "llvm/ADT/FoldingSet.h" >>> > #include "llvm/ADT/PointerUnion.h" >>> > >>> > Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >>> > URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=259507=259506=259507=diff >>> > >>> == >>> > --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h