[chromium-dev] Re: webkit/port is moving into third_party/WebKit/WebCore

[Dimitri Glazkov]

As of Christmas Eve, we have:

webkit/port/bindings/{scripts,v8}
webkit/port/platform/image-decoders
webkit/port/platform/graphics/mac
webkit/port/DerivedSources.make

Merry Christmas and/or Festivus, everyone!

Oh, and I broke the build yesterday, and eroman fixed it. He da man.

:DG

On Tue, Dec 23, 2008 at 3:48 PM, Darin Fisher da...@chromium.org wrote:
 For now, just operate the same as you would had these files still resided in
 webkit/port.  Just don't forget to roll DEPS :)
 We'll eventually be updating the merge tracker
 (http://build.chromium.org/merge) to indicate the set of files and diffs
 that have yet to be upstreamed.
 -Darin

 On Tue, Dec 23, 2008 at 2:51 PM, Adam Barth aba...@chromium.org wrote:

 I see.  Can I make changes to them in third_party, or should I wait
 for them to appear upstream?

 Adam


 On Tue, Dec 23, 2008 at 1:35 PM, Dimitri Glazkov dglaz...@google.com
 wrote:
 
 
  http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/
 
  These haven't been yet upstreamed. We just started by moving them into
  our vendor branch.
 
  :DG
 
  On Tue, Dec 23, 2008 at 1:31 PM, Adam Barth aba...@chromium.org wrote:
 
  I'm confused.  I need to fix a bug in ImageSourceSkia.cpp, but I can't
  find it
 
 
  http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/platform/graphics/
 
  or
 
  http://trac.webkit.org/browser/trunk/WebCore/platform/graphics
 
  Where did it go?
 
  Adam
 
 
  On Mon, Dec 22, 2008 at 8:42 PM, Darin Fisher da...@chromium.org
  wrote:
  OK, much of webkit/port now lives in third_party/WebKit.
  All that remains is:
  webkit/port/bindings/{scripts,v8}
  webkit/port/bridge/chromium
  webkit/port/page/chromium
  webkit/port/page/inspector
  webkit/port/platform/image-decoders
  webkit/port/platform/mac
  webkit/port/platform/graphics/mac
  webkit/port/DerivedSources.make
  We should be able to finish moving most of the rest of these files
  tomorrow.
  -Darin
 
  On Mon, Dec 22, 2008 at 11:48 AM, Mohamed Mansour
  m0.interact...@gmail.com
  wrote:
 
  I guess I will stop till your done!
 
 
  On Mon, Dec 22, 2008 at 2:42 PM, Darin Fisher da...@chromium.org
  wrote:
 
  FYI
  Please expect conflicts if you are trying to make changes to
  webkit/port.
  -Darin
 
 
 
 
 
 
  
 
 
  
 
 
  
 




 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Adding MouseRelease Events for Buttons?

[Mohamed Mansour]

Hello,
I am trying to figure out how to add mouse listeners on a normal
view::Button, but I can't seem to figure it out. Within the ToolbarView,
there is buttons such as home, back, forward, I would like to be able to add
a middle mouse click functionality to those buttons, but the way it works
now is by executing the following:

 controller_-AddManagedButton(reload_, IDC_RELOAD);

That line of code is letting the CommandHandler manage key events and mouse
events. But I want to be able to manage the middle mouse click event, and
that event differs from left click. how would I do so?

Would have been nice if we could pass in data to the CommandHandler, so if
we have done a mouse click or a key release, the CommandHandler would have
had access to that.

Any help is appreciated!

- m0

Merry Christmas!

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---