[chromium-dev] Re: [chromium-checkins] Re: r8862 - in trunk/src/webkit: build/WebCore tools/test_shell
On Thu, Jan 29, 2009 at 7:44 AM, Dean McNamee de...@chromium.org wrote: The files seem quite different 1 file changed, 336 insertions(+), 835 deletions(-) Anyone interested in taking a look at this today? Hey Adam, I worked on the gtk2drawing unforking to see why it caused so many test failures. The first problem is that platform/chromium/gtkdrawing.h wasn't unforked as well, so that header was being used instead of the appropriate platform/gtk/gtkdrawing.h. This caused a problem because a new type was added to the GtkThemeWidgetType enum, so when MOZ_GTK_DROPDOWN was requested, we got MOZ_GTK_ENTRY_CARET drawn. Unforking gtkdrawin.h would fix that problem. That fixes about 40 layout tests. The remaining ~100 failures are because of differences in the way the two gtk2drawing.c's render certain widgets. I think chromium's gtk2drawing widgets look a lot better, but another solution is to rebaseline those tests. -- James Hawkins --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Stabilization Effort Daily Report
*Report for 2009-2-2* *Layout Tests* Our progress over the last few days has been flat. We need to get below that 300 bug line. [image: All+Tests=78.0][image: Want+To+Pass=95.4] http://spreadsheets.google.com/ccc?key=pMwul3Seofg4uTdanKb9iWw [image: History of passing tests %]http://spreadsheets.google.com/ccc?key=pMwul3Seofg4uTdanKb9iWwBe sure to sign up at http://spreadsheets.google.com/ccc?key=pMwul3Seofg448Q1VFJjsJAhl=en if you are going to work on a layout test. We don't want to step on each other's toes. All Tests is based on all available layout tests including those that we are currently not trying to pass. There are tests in this group which are known to be bad or relate to future technologies. Want to Pass is based on the tests that we need to be passing before we will ship a revision of the browser. Getting this number as high as possible is the goal of the stabilization effort. Some of these tests are failing due to subtle changes that require the test to be re-baselined. Crashers We have 9 remaining crashers. *Purify Bugs (Memory)* We have 19 remaining Purify issues. *Regressions* We 7 remaining regressions, although that number is likely to go up. *Other bugs* We have 38 other bugs to resolve. So our bug burndown chart looks like this: I reset the blue line after a bunch of Purify bugs from UI tests landed all at once. As long as we keep the red line below the blue line we are on track for the bugs. Keep in mind that this does not include the work on Layout Tests. You will find a lot more information about the Stabilization effort on the Wiki at http://code.google.com/p/chromium/wiki/StabilizeTrunk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] net unittests on Mac
FYI - I pushed two fixes for the net unittests on Mac, they should no longer be flaky (ie-failing 70% of the time). If folks see results indicating otherwise, please let me know. TVL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
