[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
On Fri, May 29, 2009 at 7:45 PM, Evan Stade est...@chromium.org wrote: Is anyone planning to do a UI review of linux and/or mac? We've had one in the past but it was more high level. My understanding was that more would follow in the future. We copy windows where we can (for padding and hard-coded sizes and whatnot), but there are tons of places where that's not possible. Also, padding numbers don't really translate 1 for 1 all the time. From your screenshots, I agree the Windows one is off-centered but the Linux one feels unbalanced to me in its padding. (The spacing between the lines of text is larger than the spacing around them; the button Y padding is larger than the button X padding.) The big problem, I believe, is that the normal system fonts used on Linux are bigger than Windows. We haven't yet really reached a good answer on what to do about that. In some places Tony hardcoded in font sizes but it looks pretty weird. I've been working on a patch to make things look more right at the cost of looking less like Windows. I discussed it with Ben a bit and I think we agreed that it would sorta naturally go along with themes support -- that is, we can have Match system as an option alongside Chrome on Windows blue and whatever other themes the user wants. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
Is anyone planning to do a UI review of linux and/or mac? We copy windows where we can (for padding and hard-coded sizes and whatnot), but there are tons of places where that's not possible. Also, padding numbers don't really translate 1 for 1 all the time. I've been choosing numbers based on my own aesthetic preferences, but sometimes it feels like I'm drawing them out of a hat. 4 pixels, 5 pixels, 6 pixels, what's the difference? I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) -- Evan Stade On Wed, May 27, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.org wrote: I want to stress this point. It's always best to discuss any change in Chrome code with others before you invest a lot of time on it. You will doubtless get helpful feedback and there's a high likelihood you'll save a lot of time. -Ben On Wed, May 27, 2009 at 2:23 PM, Glen Murphy g...@chromium.org wrote: It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers). On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) b...@chromium.org wrote: Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any platform yet as they creep in. -Ben On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) b...@chromium.org wrote: This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely that your change will be reverted :-) -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~--- attachment: droopy_warning_icon.jpgattachment: lnx_warning_icon.jpg
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
On Fri, May 29, 2009 at 7:45 PM, Evan Stade est...@chromium.org wrote: I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) The entire download bar UI has serious alignment issues depending on theme, fonts, etc. The fact that on my machines, the dropmarker in the right edge of a download's button isn't even close to vertically centered always saddens me. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
...these issues are filed as bugs so we can fix them, right? On Fri, May 29, 2009 at 22:23, Peter Kasting pkast...@chromium.org wrote: On Fri, May 29, 2009 at 7:45 PM, Evan Stade est...@chromium.org wrote: I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) The entire download bar UI has serious alignment issues depending on theme, fonts, etc. The fact that on my machines, the dropmarker in the right edge of a download's button isn't even close to vertically centered always saddens me. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any platform yet as they creep in. -Ben On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) b...@chromium.org wrote: This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely that your change will be reverted :-) -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) b...@chromium.orgwrote: Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any platform yet as they creep in. -Ben On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) b...@chromium.org wrote: This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely that your change will be reverted :-) -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers). On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) b...@chromium.org wrote: Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any platform yet as they creep in. -Ben On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) b...@chromium.org wrote: This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely that your change will be reverted :-) -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
I want to stress this point. It's always best to discuss any change in Chrome code with others before you invest a lot of time on it. You will doubtless get helpful feedback and there's a high likelihood you'll save a lot of time. -Ben On Wed, May 27, 2009 at 2:23 PM, Glen Murphy g...@chromium.org wrote: It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers). On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) b...@chromium.org wrote: Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any platform yet as they creep in. -Ben On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) b...@chromium.org wrote: This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely that your change will be reverted :-) -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
