date:20240226

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Andrew Randrianasulu via Cin

пн, 26 февр. 2024 г., 17:58 Igor BEGHETTO via Cin <
cin@lists.cinelerra-gg.org>:

> No, I would not change the code. I would left as it is. The reasons are
> multiple, for me:
> - if you open an old project, that project works right with A_KEY=1. An
> user could have written, "it doesn't work", at that time. The test case
> shows why it doesn't work.
> - Now, you can change A_KEY value from 0 to 1, if needed, using the
> "Keyframe parameters" window. If you change the code, that will no
> longer be possible.
>

Yea ...

So, for now probably documentation update is needed, and if we completely
figure it out may be gui checkbox will be re-enabled at some point.

IgorV also reported some strangeness with AgingTV gui params (they not as
interactive as they should?) but I have't looking at this problem yet.

Not even sure if it makes sense to do release this month? On the other hand
not even sure if we will able to fix more than one problem in next 30 days





> IgorBeg
>
>
> 26/02/2024 14:34, Andrew Randrianasulu wrote:
> > For now we can try and modify in plugins/blur/blur.C
> >
> > void BlurMain::save_data(KeyFrame *keyframe)
> > output.tag.set_property("A_KEY", config.a_key);
> > replace config.a_key with 0 here ?
> > so it will be always saved as 0
> > void BlurMain::read_data(KeyFrame *keyframe)
> > config.a_key = input.tag.get_property("A_KEY", config.a_key);
> > with config.a_key = 0;
> > so it will ignore saved 1 setting.
> > At least this is my theory/idea for now.
> > If we go with this plan we probably should left original lines
> > commented out with "//" and add line saying why reading/writing forced
> > to 0 for this param (due to disabled gui config in blurwindow.C)
> --
> Cin mailing list
> Cin@lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Andrea paz via Cin

I tried to update the text of Blur plugin in the manual. See if it is
okay (to be added at the end):


Problems may arise, with old projects or with
Cinelerra-CV/Cinelerra-HV projects, regarding the parameter
\textit{alpha determines radius}. However, to avoid problems, it was
hidden in the GUI's plugin. For compatibility reasons and for future
development it has been left in the code.
The parameter about \textit{alpha determines radius} is
\texttt{A\_KEY}. \texttt{A\_KEY} can be 0 or 1. When we press the
\texttt{Reset} button in the Blur plugin window the values are:
\texttt{Radius=5}; \texttt{Horizontal= Vertical= A= R= G= B= 1};
\texttt{A\_KEY= 0}.

Old projects may have saved that parameter (A\_KEY) to 1 so, in the
special cases, is needed some workarounds to put it to 0.

\begin{enumerate}
\item Open the file project (\texttt{.xml}) in a text editor and
change the A\_KEY value of the BLUR from 1 to 0. It can be useful to
change ALL these value using \textit{Find and replace...} tool.
\item In \CGG{} program, open the project. Click on the cog icon
(\textit{Preset edit}) of the Blur effect bar and the \textit{Keyframe
parameters} window is open. There, you can see the A\_KEY parameter
and change it: select the \texttt{A\_KEY} parameter and in the
\texttt{Edit value} change it from 1 to 0,... and press \texttt{OK}
button.
\end{enumerate}


> Not even sure if it makes sense to do release this month? On the other hand 
> not even sure if we will able to fix more than one problem in next 30 days ...
 I would bring out a new appimage because DeJay needed the appimage
with Color 3 Way working...
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Andrew Randrianasulu via Cin

вт, 27 февр. 2024 г., 00:02 Phyllis Smith via Cin <
cin@lists.cinelerra-gg.org>:

> Not even sure if it makes sense to do release this month? On the other
>>> hand not even sure if we will able to fix more than one problem in next 30
>>> days ...
>>>
>>  I would bring out a new appimage because DeJay needed the appimage with
>> Color 3 Way working...
>
> Yes, I was planning on making new appimages because Color 3 Way is used a
> lot and an error is not good.
>
>> I tried to update the text of Blur plugin in the manual. See if it is okay
>> (to be added at the end):
>>
> Seems reasonable and I edited it some by changing one option to just use
> Reset and re-save the project instead of editing the .xml.  Editing is open
> to mistakes -- I just made one and ended up with an empty .xml file which
> could be disastrous.
>
> No, I would not change the code. I would left as it is. The reasons are
>> multiple, for me:
>>
> Agreed. At least *about 10 years ago* it seems that the A_KEY code was
> commented out in HV (may have been longer but that is as far back as I
> could easily find).  There does not seem to be A_KEY code in cv blur plugin
> which is a lot different then the HV baseline.  This simply does not matter
> because HV code is the baseline for CinGG with some cv mods merged in and
> no serious attempt was ever made to specifically ensure CinGG was
> compatible for a cv project.
>
> some strangeness with AgingTV gui params (they not as interactive as they
>> should?) but I have't looking at this problem yet.
>>
> In looking at Aging plugin, I have seen no problem and am not going to
> waste any more time on it -- already wasted way too much time on Blur when
> for projects that are less than 10 years old, there was not even a problem.
> And the code matches that of HV-8 with the exception of the addition of the
> Reset button which is so valuable.
>

 ... I only wanted to note this somewhere so hopefully *I* will have some
added motivation to look at it! Well, at least in  very "shake a toy and
see if anything comes out" way ...



> --
> Cin mailing list
> Cin@lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Phyllis Smith via Cin

>
> some strangeness with AgingTV gui params (they not as interactive as they
>>> should?) but I have't looking at this problem yet.
>>>
>>
>>  ... I only wanted to note this somewhere so hopefully *I* will have some
> added motivation to look at it! Well, at least in  very "shake a toy and
> see if anything comes out" way ...
>
> It would be much appreciated if you have time to look at AgingTV.  HV does
not allow for modifying the parameter values nor do the other TV plugins --
DotTV, HolographicTV, and BurningTV.   It would also be great if the
parameters in these other 3 were made visible and modifiable.  You could
"shake a lot of toys" that way !!!.
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Phyllis Smith via Cin

>
> Not even sure if it makes sense to do release this month? On the other
>> hand not even sure if we will able to fix more than one problem in next 30
>> days ...
>>
>  I would bring out a new appimage because DeJay needed the appimage with
> Color 3 Way working...

Yes, I was planning on making new appimages because Color 3 Way is used a
lot and an error is not good.

> I tried to update the text of Blur plugin in the manual. See if it is okay
> (to be added at the end):
>
Seems reasonable and I edited it some by changing one option to just use
Reset and re-save the project instead of editing the .xml.  Editing is open
to mistakes -- I just made one and ended up with an empty .xml file which
could be disastrous.

No, I would not change the code. I would left as it is. The reasons are
> multiple, for me:
>
Agreed. At least *about 10 years ago* it seems that the A_KEY code was
commented out in HV (may have been longer but that is as far back as I
could easily find).  There does not seem to be A_KEY code in cv blur plugin
which is a lot different then the HV baseline.  This simply does not matter
because HV code is the baseline for CinGG with some cv mods merged in and
no serious attempt was ever made to specifically ensure CinGG was
compatible for a cv project.

some strangeness with AgingTV gui params (they not as interactive as they
> should?) but I have't looking at this problem yet.
>
In looking at Aging plugin, I have seen no problem and am not going to
waste any more time on it -- already wasted way too much time on Blur when
for projects that are less than 10 years old, there was not even a problem.
And the code matches that of HV-8 with the exception of the addition of the
Reset button which is so valuable.
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Igor BEGHETTO via Cin

But why?? well, this is question for me, I got some  clues  
(disabled in gui param "alpha determinated radius" we probably not 
initialize correctly)


Like pointed out by Andrew and Phyllis it concerns the "Alpha determines 
radius" checkbox option in the GUI: it was hidden, by the code, in 
December 2021. For compatibility reasons and for future development it 
has been left there.
The parameter about "Alpha determines radius" is A_KEY. A_KEY can be 0 
or 1. When we press the Reset button in the Blur plugin window the 
values are: Radius=5; Horizontal= Vertical= A= R= G= B= 1; A_KEY= 0.


Old projects may have saved that parameter (A_KEY) to 1 so, in the 
special cases, is needed some workarounds to put it to 0.
1. Open the file project (.xml) in a text editor and change the A_KEY 
value of the BLUR from 1 to 0. It can be useful to change ALL these 
value using "Find and replace..." tool.
2. In Cinelerra-GG program, open the project. Click on the cog icon 
(Preset edit) of the Blur effect bar and the "Keyframe parameters" 
window is open. There, you can see the A_KEY parameter and change it: 
select the A_KEY parameter and in the "Edit value" change it from 1 to 
0,... and press OK button.


If you open the "CGG-CHKEY-BLUR-BUG.xml" test file by Igor_V 
(Igor_ubuntu) in a text editor you can see the line number #87.
R=1 G=1 B=1 A=1 *A_KEY=1*>

Change the A_KEY from 1 to 0 and save as "CGG-CHKEY-BLUR-BUG_test2.xml".
Open that Project file in the Cinelerra-GG and we can see that the Blur 
is working right.

If you want to use the #2 point written above it is the same.

Thank you!

IgorBeg
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

[Cin] disable a_key in blur.C harder

2024-02-26 Thread Andrew Randrianasulu via Cin

At this point I am not sure if best course of action to disable it harder
or restore it ...

but I hope attached patch at least visually restores strange mess we see by
default now in test project.
From 7856a56b6e7fc6ea11e3daac03134d3ef2351584 Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu 
Date: Mon, 26 Feb 2024 16:40:31 +0300
Subject: [PATCH] TEST: disable blur alpha determinates radius harder

---
 cinelerra-5.1/plugins/blur/blur.C | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/cinelerra-5.1/plugins/blur/blur.C b/cinelerra-5.1/plugins/blur/blur.C
index 896cddbb..dfbf501c 100644
--- a/cinelerra-5.1/plugins/blur/blur.C
+++ b/cinelerra-5.1/plugins/blur/blur.C
@@ -331,7 +331,8 @@ void BlurMain::save_data(KeyFrame *keyframe)
 	output.tag.set_property("G", config.g);
 	output.tag.set_property("B", config.b);
 	output.tag.set_property("A", config.a);
-	output.tag.set_property("A_KEY", config.a_key);
+	//output.tag.set_property("A_KEY", config.a_key);
+	output.tag.set_property("A_KEY", 0); // disabled in gui in dec 2021
 	output.append_tag();
 	output.tag.set_title("/BLUR");
 	output.append_tag();
@@ -363,7 +364,8 @@ void BlurMain::read_data(KeyFrame *keyframe)
 config.g = input.tag.get_property("G", config.g);
 config.b = input.tag.get_property("B", config.b);
 config.a = input.tag.get_property("A", config.a);
-config.a_key = input.tag.get_property("A_KEY", config.a_key);
+config.a_key = 0; // disabled in gui at dec 2021
+//config.a_key = input.tag.get_property("A_KEY", config.a_key);
 			}
 		}
 	}
-- 
2.44.0

-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Andrew Randrianasulu via Cin

пн, 26 февр. 2024 г., 12:07 Igor BEGHETTO via Cin <
cin@lists.cinelerra-gg.org>:

> But why?? well, this is question for me, I got some  clues  (disabled
> in gui param "alpha determinated radius" we probably not initialize
> correctly)
>
>
> Like pointed out by Andrew and Phyllis it concerns the "Alpha determines
> radius" checkbox option in the GUI: it was hidden, by the code, in December
> 2021. For compatibility reasons and for future development it has been left
> there.
>

I think IgorV pointed out (to me)  that this checkbox only worked with
horizontal blur, not with both enabled?

For now we can try and modify in plugins/blur/blur.C


void BlurMain::save_data(KeyFrame *keyframe)

output.tag.set_property("A_KEY", config.a_key);

replace config.a_key with 0 here ?

so it will be always saved as 0

void BlurMain::read_data(KeyFrame *keyframe)

config.a_key = input.tag.get_property("A_KEY", config.a_key);

with config.a_key = 0;

so it will ignore saved 1 setting.

At least this is my theory/idea for now.

If we go with this plan we probably should left original lines commented
out with "//" and add line saying why reading/writing forced to 0 for this
param (due to disabled gui config in blurwindow.C)




The parameter about "Alpha determines radius" is A_KEY. A_KEY can be 0 or
> 1. When we press the Reset button in the Blur plugin window the values are:
> Radius=5; Horizontal= Vertical= A= R= G= B= 1; A_KEY= 0.
>
> Old projects may have saved that parameter (A_KEY) to 1 so, in the special
> cases, is needed some workarounds to put it to 0.
> 1. Open the file project (.xml) in a text editor and change the A_KEY
> value of the BLUR from 1 to 0. It can be useful to change ALL these value
> using "Find and replace..." tool.
> 2. In Cinelerra-GG program, open the project. Click on the cog icon
> (Preset edit) of the Blur effect bar and the "Keyframe parameters" window
> is open. There, you can see the A_KEY parameter and change it: select the
> A_KEY parameter and in the "Edit value" change it from 1 to 0,... and press
> OK button.
>
> If you open the "CGG-CHKEY-BLUR-BUG.xml" test file by Igor_V (Igor_ubuntu)
> in a text editor you can see the line number #87.
>  G=1 B=1 A=1 *A_KEY=1*>
> Change the A_KEY from 1 to 0 and save as "CGG-CHKEY-BLUR-BUG_test2.xml".
> Open that Project file in the Cinelerra-GG and we can see that the Blur is
> working right.
> If you want to use the #2 point written above it is the same.
>
> Thank you!
>
> IgorBeg
> --
> Cin mailing list
> Cin@lists.cinelerra-gg.org
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

2024-02-26 Thread Igor BEGHETTO via Cin

No, I would not change the code. I would left as it is. The reasons are 
multiple, for me:
- if you open an old project, that project works right with A_KEY=1. An 
user could have written, "it doesn't work", at that time. The test case 
shows why it doesn't work.
- Now, you can change A_KEY value from 0 to 1, if needed, using the 
"Keyframe parameters" window. If you change the code, that will no 
longer be possible.


IgorBeg


26/02/2024 14:34, Andrew Randrianasulu wrote:

For now we can try and modify in plugins/blur/blur.C

void BlurMain::save_data(KeyFrame *keyframe)
output.tag.set_property("A_KEY", config.a_key);
replace config.a_key with 0 here ?
so it will be always saved as 0
void BlurMain::read_data(KeyFrame *keyframe)
config.a_key = input.tag.get_property("A_KEY", config.a_key);
with config.a_key = 0;
so it will ignore saved 1 setting.
At least this is my theory/idea for now.
If we go with this plan we probably should left original lines 
commented out with "//" and add line saying why reading/writing forced 
to 0 for this param (due to disabled gui config in blurwindow.C)

--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

[Cin] disable a_key in blur.C harder

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

Re: [Cin] Fwd: Chromakey + blur testcase from IgorV

9 matches

Site Navigation

Mail list logo

Footer information