Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-06-02 Thread Peter Hull 
On Thursday, 1 June 2017 22:49:56 UTC+1, Andy Fingerhut wrote:
>
> I do not know whether you (Peter) are the same as the user pedro-w on 
> Github, 
>
Indeed I am the same. 
I've suggested something on the GH issue which is just a hack but may be 
helpful. I hope you'll appreciate that, coming to it fresh, the interaction 
of eastwood and leiningen and the target code takes a bit of pondering, so 
it will take me a while to get up to speed.

Pete

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-06-01 Thread Andy Fingerhut 
I do not know whether you (Peter) are the same as the user pedro-w on
Github, but pedro-w created this Eastwood issue and added a comment with
links to a related discussion on a tools.reader issue tracker:
https://github.com/jonase/eastwood/issues/222

If you can find a way, with just tools.reader alone, to call
clojure.tools.reader/read in such a way that it first reads and uses the
contents of a data_readers.clj file, and then can successfully read the
sample .clj file in that issue #222 that causes Eastwood to fail now, that
sequence of API calls would be useful to know, and might be all that
Eastwood needs to work for projects with a non-empty data_readers.clj
file.  Adding that working sequence of API calls to Eastwood issue #222
would be a good place to document that, if someone finds out how to do it.


Yes, Eastwood does have source code copies of tools.reader and several
other open source libraries inside of itself, renamed to different
namespaces.  Why do such a crazy thing, you might reasonably ask?  Because
then Eastwood can read, analyze, and load tools.reader itself, without
conflicting with the one that Eastwood uses for its own purposes.  If a
project you want to lint via Eastwood is using an older version of
tools.reader, missing some function or feature Eastwood relies on, and
Eastwood didn't use this technique, it would fail on such a project.

I started 'dolly' (https://github.com/jafingerhut/dolly) to assist with
bringing new versions of libraries Eastwood depends upon into Eastwood,
renaming the namespaces semi-automatically for you.  It isn't in a shape
that I would recommend others to use right now, and it might never be in
that kind of shape, but it can do some things.  Its README mentions
mranderson as another similar project that might be better suited for
others.

Andy


On Thu, Jun 1, 2017 at 8:19 AM, Peter Hull  wrote:

> I had a quick look at this. As I understand it, the clojure.core reader
> processes data_readers.clj, but Eastwood uses tools.reader (or a version of
> it, copied into the Eastwood project?) which does not.
>
> I thought that, for linting, we don't need to actually run the data reader
> functions, so it should be possible to use the *default-data-reader-fn*
> mechanism to swallow the tag + value, returning 'something' (doesn't matter
> what, I used (gensym) ).
>
> I tried editing leiningen.eastwood/eastwood, but unfortunately couldn't
> find a way to set *default-data-reader-fn* such that tools.reader could
> pick it up. I am now at the limits of my clojur e knowledge!
>
> Does this sound reasonable? Any ideas what I am doing wrong?
>
> Pete
>
>
>
> On Thursday, 1 June 2017 07:19:04 UTC+1, Peter Hull wrote:
>>
>> On Thursday, 1 June 2017 06:55:52 UTC+1, Andy Fingerhut wrote:
>>>
>>> Sounds like a limitation/bug in the current Eastwood implementation that
>>> it doesn't handle this.  You are welcome to file an issue on Github:
>>> https://github.com/jonase/eastwood/issues
>>>
>>> Thanks for getting back to me. I've filed #222 (
>> https://github.com/jonase/eastwood/issues/222)
>> Pete
>>
>>
> --
> You received this message because you are subscribed to the Google
> Groups "Clojure" group.
> To post to this group, send email to clojure@googlegroups.com
> Note that posts from new members are moderated - please be patient with
> your first post.
> To unsubscribe from this group, send email to
> clojure+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/clojure?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "Clojure" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojure+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-06-01 Thread Peter Hull 
I had a quick look at this. As I understand it, the clojure.core reader 
processes data_readers.clj, but Eastwood uses tools.reader (or a version of 
it, copied into the Eastwood project?) which does not. 

I thought that, for linting, we don't need to actually run the data reader 
functions, so it should be possible to use the *default-data-reader-fn* 
mechanism to swallow the tag + value, returning 'something' (doesn't matter 
what, I used (gensym) ).

I tried editing leiningen.eastwood/eastwood, but unfortunately couldn't 
find a way to set *default-data-reader-fn* such that tools.reader could 
pick it up. I am now at the limits of my clojur e knowledge!

Does this sound reasonable? Any ideas what I am doing wrong?

Pete


On Thursday, 1 June 2017 07:19:04 UTC+1, Peter Hull wrote:
>
> On Thursday, 1 June 2017 06:55:52 UTC+1, Andy Fingerhut wrote:
>>
>> Sounds like a limitation/bug in the current Eastwood implementation that 
>> it doesn't handle this.  You are welcome to file an issue on Github: 
>> https://github.com/jonase/eastwood/issues
>>
>> Thanks for getting back to me. I've filed #222 (
> https://github.com/jonase/eastwood/issues/222)
> Pete
>  
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-06-01 Thread Peter Hull 
On Thursday, 1 June 2017 06:55:52 UTC+1, Andy Fingerhut wrote:
>
> Sounds like a limitation/bug in the current Eastwood implementation that 
> it doesn't handle this.  You are welcome to file an issue on Github: 
> https://github.com/jonase/eastwood/issues
>
> Thanks for getting back to me. I've filed #222 
(https://github.com/jonase/eastwood/issues/222)
Pete
 

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-31 Thread Andy Fingerhut 
Sounds like a limitation/bug in the current Eastwood implementation that it
doesn't handle this.  You are welcome to file an issue on Github:
https://github.com/jonase/eastwood/issues

Sorry, no promises on when it might be addressed.

Andy

On Wed, May 31, 2017 at 5:39 AM, Peter Hull  wrote:

> On Monday, 22 May 2017 01:51:32 UTC+1, David Cook wrote:
>>
>> Eastwood, the Clojure lint tool, version 0.2.4 has been released.  See
>> install instructions and complete documentation at [1].
>>
> Hi David and others,
> I tried this for the first time on my code and it found some errors
> (hooray!) but also failed to parse some files using tagged literals. Is
> this expected?
>
> As a minimal example I have
>
> === src/ewe/core.clj ===
> (ns ewe.core
>   (:gen-class))
>
> (defn ereader [x] (str "Make my " x ))
>
> (defn -main
>   "I don't do a whole lot ... yet."
>   [& args]
>   (println #ewe/E "day"))
> ===
>
> === src/data_readers.clj
> {ewe/E ewe.core/ereader}
> ===
>
> which runs OK with 'lein run' but with 'lein eastwood' gives:
>
> == Linting ewe.core ==
> Linting failed:
> ExceptionInfo No reader function for tag E
> clojure.core/ex-info (core.clj:4617)
> ...
>
> I am using clojure 1.8.0, fedora 25 (also tried Macos, same result)
>
> Thanks,
> Pete
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Clojure" group.
> To post to this group, send email to clojure@googlegroups.com
> Note that posts from new members are moderated - please be patient with
> your first post.
> To unsubscribe from this group, send email to
> clojure+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/clojure?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "Clojure" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojure+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-31 Thread Travis Daudelin 
Awesome replies everyone, thanks for the advice! Will definitely check 
these plugins out

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-31 Thread Duncan McGreggor 
I use both all the time (part of the gating in the build process); they are
nicely complementary.

d

On 23 May 2017 at 11:16, Travis Daudelin  wrote:

>  Hi, thanks for posting this looks great!
>
> Is there any overlap in functionality between Eastwood and Kibit
> ? It's not clear to me which tool I
> should prefer nor when.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Clojure" group.
> To post to this group, send email to clojure@googlegroups.com
> Note that posts from new members are moderated - please be patient with
> your first post.
> To unsubscribe from this group, send email to
> clojure+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/clojure?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "Clojure" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojure+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-31 Thread Peter Hull 
On Monday, 22 May 2017 01:51:32 UTC+1, David Cook wrote:
>
> Eastwood, the Clojure lint tool, version 0.2.4 has been released.  See 
> install instructions and complete documentation at [1].
>
Hi David and others,
I tried this for the first time on my code and it found some errors 
(hooray!) but also failed to parse some files using tagged literals. Is 
this expected?

As a minimal example I have

=== src/ewe/core.clj ===
(ns ewe.core
  (:gen-class))

(defn ereader [x] (str "Make my " x ))

(defn -main
  "I don't do a whole lot ... yet."
  [& args]
  (println #ewe/E "day"))
===

=== src/data_readers.clj
{ewe/E ewe.core/ereader}
===

which runs OK with 'lein run' but with 'lein eastwood' gives:

== Linting ewe.core ==
Linting failed:
ExceptionInfo No reader function for tag E
clojure.core/ex-info (core.clj:4617)
...

I am using clojure 1.8.0, fedora 25 (also tried Macos, same result)

Thanks,
Pete
 

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-24 Thread LaurentJ 
Hi,

If you dont mind, just use them all  ;)
https://github.com/itang/lein-checkall


Le mardi 23 mai 2017 18:16:01 UTC+2, Travis Daudelin a écrit :
>
>  Hi, thanks for posting this looks great!
>
> Is there any overlap in functionality between Eastwood and Kibit 
> ? It's not clear to me which tool I 
> should prefer nor when.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-23 Thread Andy Fingerhut 
Eastwood analyzes your code to look for constructs that might be errors.

Kibit analyzes code to look for places where you could use Clojure macros
or functions that may make your code shorter, or more idiomatic.

Andy

On Tue, May 23, 2017 at 9:16 AM, Travis Daudelin 
wrote:

>  Hi, thanks for posting this looks great!
>
> Is there any overlap in functionality between Eastwood and Kibit
> ? It's not clear to me which tool I
> should prefer nor when.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Clojure" group.
> To post to this group, send email to clojure@googlegroups.com
> Note that posts from new members are moderated - please be patient with
> your first post.
> To unsubscribe from this group, send email to
> clojure+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/clojure?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "Clojure" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojure+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-23 Thread Travis Daudelin 
 Hi, thanks for posting this looks great!

Is there any overlap in functionality between Eastwood and Kibit 
? It's not clear to me which tool I should 
prefer nor when.

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-21 Thread Andy Fingerhut 
And I would hasten to add David Cook to the list of developers.  He has
done the coding, testing, and release steps except deploying to Clojars.
Thank you, David!

Andy

On Sun, May 21, 2017 at 5:46 PM, David Cook  wrote:

> Eastwood, the Clojure lint tool, version 0.2.4 has been released.  See
> install instructions and complete documentation at [1].
>
> Below are some of the changes since version 0.2.3.  A complete list is at
> [2].
>
> Go squash some bugs!
>
> Jonas Enlund, Nicola Mometto, and Andy Fingerhut
>
> [1] https://github.com/jonase/eastwood
> [2] https://github.com/jonase/eastwood/blob/master/changes.md#
> changes-from-version-023-to-024
>
>
> No new linters. Added initial support for .cljc files and reader
> conditionals.
>
>-
>
>Read .cljc files in addition to .clj files when scanning namespaces.
>-
>
>Handle reader conditionals by always parsing the :clj branch.
>-
>
>Allow ClojureScript-specific libspec entries, such as :include-macros
>true.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Clojure" group.
> To post to this group, send email to clojure@googlegroups.com
> Note that posts from new members are moderated - please be patient with
> your first post.
> To unsubscribe from this group, send email to
> clojure+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/clojure?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "Clojure" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojure+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[ANN] Eastwood, the Clojure lint tool, version 0.2.4 released

2017-05-21 Thread David Cook 
Eastwood, the Clojure lint tool, version 0.2.4 has been released.  See 
install instructions and complete documentation at [1].

Below are some of the changes since version 0.2.3.  A complete list is at 
[2].

Go squash some bugs!

Jonas Enlund, Nicola Mometto, and Andy Fingerhut

[1] https://github.com/jonase/eastwood
[2] 
https://github.com/jonase/eastwood/blob/master/changes.md#changes-from-version-023-to-024


No new linters. Added initial support for .cljc files and reader 
conditionals.

   - 
   
   Read .cljc files in addition to .clj files when scanning namespaces.
   - 
   
   Handle reader conditionals by always parsing the :clj branch.
   - 
   
   Allow ClojureScript-specific libspec entries, such as :include-macros 
   true.
   

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.