[cmake-developers] No next-master merge this week?
Hi guys, There was no next-master merge this week? Is there any issue? -- Erk Le gouvernement représentatif n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Two pull requests
On 2/29/2012 4:58 PM, Yury G. Kudryashov wrote: Brad King wrote: Our style checker limits .h and .cxx files to 79 columns. Some of the updated comments exceed this limit. Please reformat them. Where can I find the style checker sources? I'll run it to pre-commit hook then. The CMAKE_USE_KWSTYLE option enables it but you need to build the KWStyle tool. Our dashboard also runs it on the repository to catch post-commit failures. However, the *only* check it currently performs is the column limit AFAIK. Someday I may get around to adding the check in our pre-commit hook. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Two pull requests
On 2/29/2012 5:34 PM, Yury G. Kudryashov wrote: Our style checker limits .h and .cxx files to 79 columns. Some of the updated comments exceed this limit. Please Force-pushed. Thanks. It conflicts with the add-const-qualifiers topic in cmPropertyDefinition::IsChained. I merged that into this topic to resolve it. Then I merged to 'next' for testing. BTW, what is the policy for const MyClass* vs MyClass const*? I personally prefer the latter except for const char* because it is in such common use. We don't have a strict requirement. Which parts of STL are allowed in sources that are needed for bootstrap? There is no special restriction for bootstrap v. main build that I remember. Any of the basic containers are allowed. We tend to avoid the algorithms beyond any already in use because many older STL implementations where CMake builds are limited. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Nightly Binary not building on windows
The Linux nightly fails the same way: CMake Error at CMakeLists.txt:55 (message): ImageMagick_FOUND is set but no version number is defined Call Stack (most recent call first): CMakeLists.txt:65 (check_version_string) I have removed the requirement for ImageMagick version string since it also breaks e.g. on slicer.orl. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Two pull requests
2012/3/1 Brad King brad.k...@kitware.com: On 3/1/2012 10:47 AM, Eric Noulard wrote: Last time I tried to enable KWStyle hooks following this: http://www.cmake.org/Wiki/Git/Hooks#Setup That page is generic for many of Kitware's projects and is not specific to CMake. The same hooks are also used for ITK. For a while the kwstyle and uncrustify hooks were added and used by ITK. Later they were moved over to ITK proper and are now invoked through the generic hooks' chaining feature. They no longer exist in the generic hooks outright. I removed the discussion of them from the wiki page. I'm not a big fan of automatic code formatting and layout tools. There are almost always exceptions and special cases. I'd rather cover that during code review. Yes I agree with that but may be using them as pre-commit warning on changed files may be interesting. Nevertheless checking for no more than 79 column style certainly does not require such tool. -- Erk Le gouvernement représentatif n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0013008]: CFLAGs set in toolchain file are overwritten
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=13008
==
Reported By:David Coles
Assigned To:
==
Project:CMake
Issue ID: 13008
Category: CMake
Reproducibility:always
Severity: minor
Priority: normal
Status: new
==
Date Submitted: 2012-03-01 21:27 EST
Last Modified: 2012-03-01 21:27 EST
==
Summary:CFLAGs set in toolchain file are overwritten
Description:
It's possible to set common CMAKE variables in a toolchain file with the
assumption that they'll be used in external builds. This would be the ideal
location for toolchain specific compiler flags, but unfortunately these are
overwritten after the toolchain testing is complete.
A workaround[1] is to set the CFLAGS to the CMAKE Cache using something like
`SET(CMAKE_C_FLAGS -Wall CACHE STRING Toolchain)` but this breaks the use of
CFLAGS environment variable.
[1] http://www.mail-archive.com/cmake@cmake.org/msg40214.html
Steps to Reproduce:
# Toolchain.cmake
# ===
set(CMAKE_SYSTEM_NAME Linux)
set(CMAKE_SYSTEM_VERSION 1)
set( CLANG True )
# Set the cross compiler
set(CMAKE_C_COMPILER clang)
set(CMAKE_CXX_COMPILER clang++)
set(CMAKE_C_FLAGS -Wextra)
#set(CMAKE_C_FLAGS -Wextra CACHE STRING Toolchain)
set(MY_C_FLAGS -Wextra)
MESSAGE(STATUS Toolchain CMAKE_C_FLAGS: ${CMAKE_C_FLAGS})
MESSAGE(STATUS Toolchain MY_C_FLAGS: ${MY_C_FLAGS})
# CMakeLists.txt
# ==
PROJECT (Test)
CMAKE_MINIMUM_REQUIRED (VERSION 2.8)
# Expect that toolchain variables are still set
MESSAGE (STATUS CMAKE_C_FLAGS: ${CMAKE_C_FLAGS})
MESSAGE (STATUS MY_C_FLAGS: ${MY_C_FLAGS})
# Command Line
#
$ rm CMakeCache.txt; cmake -DCMAKE_TOOLCHAIN_FILE=Toolchain.cmake .
==
Issue History
Date ModifiedUsername FieldChange
==
2012-03-01 21:27 David ColesNew Issue
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
