Re: [cmake-developers] Clarify status of link_libraries
On 01/25/2015 05:03 PM, Christoph Grüninger wrote: we wanted to use the link_libraries command and we were scared off by its deprecation. Fortunately someone found Brad's statement [1] about the deprecated. Thanks. I never updated the docs after sending that message. Inspired by your patch I've revised the documentation: Help: Clarify status of link_libraries command http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c7310917 Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Introduction and volunteering for the Matlab package
On 01/23/2015 07:52 PM, Raffi Enficiaud wrote: This should be handled with a save/restore. Are you referring to the CMakePushCheckState? No, CMAKE_FIND_LIBRARY_PREFIXES should be saved/restored manually with code in the Find module around the find_library calls. You could also create a _Matlab_find_library function that sets CMAKE_FIND_LIBRARY_PREFIXES and calls find_library. The setting would go out of scope when the function returns. See the FindBoost module for a similar example. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Adding an option for relative compiler invocations
On 01/23/2015 05:44 PM, Michael Enßlin wrote: cd /home/mic/git/openage /usr/bin/g++ $(CXX_DEFINES) $(CXX_FLAGS) -o /home/mic/git/openage/.bin/gcc-release-O2/cpp/CMakeFiles/openage.dir/engine.cpp.o -c cpp/engine.cpp Invoking the compiler inside the source tree is not an option. Many compilers leave around extra files as side-effects and we cannot allow them to pollute the source tree in an out-of-source build. I don't think getting a relative __FILE__ is a realistic option with CMake. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Improving Vim support in CMake
On Sat, Jan 24, 2015 at 15:29:51 +, Alex Merry wrote: On Wednesday 21 January 2015 16:17:35 Ben Boeckel wrote: List of improvements to the syntax file: - drop support for 7.0 (which is 7.5 years old now); - add support for Lua-style comments; - update the list of system variables; - update the list of operators; - make only commands case-insensitive; - update the list of built-in commands (and deprecated ones); - highlight user-defined function and macro calls; and - tweak colors a bit. Much needed, especially updating the list of commands and operators, thanks! However, I'm missing having variables highlighted in a different colour, especially when they appear in strings. Odd; attached is an HTML dump from Vim for what I see (:TOhtml) where variable expansions are highlighted in strings just like outside of strings. Also, do you know if it's possible to make command and operator highlighting context-sensitive? For example, in add_command(COMMAND foo), COMMAND is highlighted because it is in the list of operators, and I've got a command that takes a LINK_LIBRARIES keyword argument, which is highlighted as a deprecated command. The problem is that they are keywords right now. I'll take a stab at making it a regex instead so it can be properly contained within other groupings. Thanks for testing :) . --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Improving Vim support in CMake
On Mon, Jan 26, 2015 at 11:00:05 -0500, Ben Boeckel wrote: Odd; attached is an HTML dump from Vim for what I see (:TOhtml) where variable expansions are highlighted in strings just like outside of strings. Probably help if I actually attached the file :/ . --Ben Title: ~/code/depot/group-tools/group-bld/cmake/src/CMakeLists.txt.html 1 #= 2 # CMake - Cross Platform Makefile Generator 3 # Copyright 2000-2012 Kitware, Inc., Insight Software Consortium 4 # 5 # Distributed under the OSI-approved BSD License (the License); 6 # see accompanying file Copyright.txt for details. 7 # 8 # This software is distributed WITHOUT ANY WARRANTY; without even the 9 # implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. 10 # See the License for more information. 11 #= 12 cmake_minimum_required(VERSION 2.8.4 FATAL_ERROR) 13 if(POLICY CMP0025) 14 cmake_policy(SET CMP0025 NEW) 15 endif() 16 project(CMake) 17 18 if(CMAKE_BOOTSTRAP) 19 # Running from bootstrap script. Set local variable and remove from cache. 20 set(CMAKE_BOOTSTRAP 1) 21 unset(CMAKE_BOOTSTRAP CACHE) 22 endif() 23 24 if(NOT CMake_TEST_EXTERNAL_CMAKE) 25 set(CMake_BIN_DIR ${CMake_BINARY_DIR}/bin) 26 endif() 27 28 if(${CMake_SOURCE_DIR} STREQUAL ${CMAKE_SOURCE_DIR}) 29 # Disallow architecture-specific try_run. It may not run on the host. 30 macro(TRY_RUN) 31 if(CMAKE_TRY_COMPILE_OSX_ARCHITECTURES) 32 message(FATAL_ERROR TRY_RUN not allowed with CMAKE_TRY_COMPILE_OSX_ARCHITECTURES=[${CMAKE_TRY_COMPILE_OSX_ARCHITECTURES}]) 33 else() 34 _TRY_RUN(${ARGV}) 35 endif() 36 endmacro() 37 endif() 38 39 # Use most-recent available language dialects with GNU and Clang 40 if(NOT DEFINED CMAKE_C_STANDARD) 41 set(CMAKE_C_STANDARD 11) 42 endif() 43 if(NOT DEFINED CMAKE_CXX_STANDARD) 44 set(CMAKE_CXX_STANDARD 14) 45 endif() 46 47 # option to set the internal encoding of CMake to UTF-8 48 option(CMAKE_ENCODING_UTF8 Use UTF-8 encoding internally. ON) 49 mark_as_advanced(CMAKE_ENCODING_UTF8) 50 if(CMAKE_ENCODING_UTF8) 51 set(KWSYS_ENCODING_DEFAULT_CODEPAGE CP_UTF8) 52 endif() 53 54 #--- 55 # a macro to deal with system libraries, implemented as a macro 56 # simply to improve readability of the main script 57 #--- 58 macro(CMAKE_HANDLE_SYSTEM_LIBRARIES) 59 # Options have dependencies. 60 include(CMakeDependentOption) 61 62 # Optionally use system xmlrpc. We no longer build or use it by default. 63 option(CTEST_USE_XMLRPC Enable xmlrpc submission method in CTest. OFF) 64 mark_as_advanced(CTEST_USE_XMLRPC) 65 66 # Allow the user to enable/disable all system utility library options by 67 # defining CMAKE_USE_SYSTEM_LIBRARIES or CMAKE_USE_SYSTEM_LIBRARY_${util}. 68 set(UTILITIES BZIP2 CURL EXPAT FORM JSONCPP LIBARCHIVE LIBLZMA ZLIB) 69 foreach(util ${UTILITIES}) 70 if(NOT DEFINED CMAKE_USE_SYSTEM_LIBRARY_${util} 71 AND DEFINED CMAKE_USE_SYSTEM_LIBRARIES) 72 set(CMAKE_USE_SYSTEM_LIBRARY_${util} ${CMAKE_USE_SYSTEM_LIBRARIES}) 73 endif() 74 if(DEFINED CMAKE_USE_SYSTEM_LIBRARY_${util}) 75 if(CMAKE_USE_SYSTEM_LIBRARY_${util}) 76 set(CMAKE_USE_SYSTEM_LIBRARY_${util} ON) 77 else() 78 set(CMAKE_USE_SYSTEM_LIBRARY_${util} OFF) 79 endif() 80 if(CMAKE_BOOTSTRAP) 81 unset(CMAKE_USE_SYSTEM_LIBRARY_${util} CACHE) 82 endif() 83 string(TOLOWER ${util} lutil) 84 set(CMAKE_USE_SYSTEM_${util} ${CMAKE_USE_SYSTEM_LIBRARY_${util}} 85 CACHE BOOL Use system-installed ${lutil} FORCE) 86 else() 87 set(CMAKE_USE_SYSTEM_LIBRARY_${util} OFF) 88 endif() 89 endforeach() 90 if(CMAKE_BOOTSTRAP) 91 unset(CMAKE_USE_SYSTEM_LIBRARIES CACHE) 92 endif() 93 94 # Optionally use system utility libraries. 95 option(CMAKE_USE_SYSTEM_LIBARCHIVE Use system-installed libarchive ${CMAKE_USE_SYSTEM_LIBRARY_LIBARCHIVE}) 96 CMAKE_DEPENDENT_OPTION(CMAKE_USE_SYSTEM_CURL Use system-installed curl 97 ${CMAKE_USE_SYSTEM_LIBRARY_CURL} NOT CTEST_USE_XMLRPC ON) 98 CMAKE_DEPENDENT_OPTION(CMAKE_USE_SYSTEM_EXPAT Use system-installed expat 99 ${CMAKE_USE_SYSTEM_LIBRARY_EXPAT} NOT CTEST_USE_XMLRPC ON) 100 CMAKE_DEPENDENT_OPTION(CMAKE_USE_SYSTEM_ZLIB Use system-installed zlib 101 ${CMAKE_USE_SYSTEM_LIBRARY_ZLIB} NOT CMAKE_USE_SYSTEM_LIBARCHIVE;NOT CMAKE_USE_SYSTEM_CURL ON) 102 CMAKE_DEPENDENT_OPTION(CMAKE_USE_SYSTEM_BZIP2 Use system-installed bzip2 103 ${CMAKE_USE_SYSTEM_LIBRARY_BZIP2} NOT CMAKE_USE_SYSTEM_LIBARCHIVE ON) 104 CMAKE_DEPENDENT_OPTION(CMAKE_USE_SYSTEM_LIBLZMA Use system-installed liblzma 105
Re: [cmake-developers] CMake 3.2 feature freeze on 2015-02-02
On 12/22/2014 10:22 AM, Brad King wrote: The feature freeze in 'master' for CMake 3.2 will be on Feb 2, 2015. I will announce a freeze in 'next' sometime in the preceding week so that we can get any remaining dashboard trouble cleaned up. Please schedule any planned topics accordingly. Any major or disruptive changes should be completed a few weeks prior to the freeze or delayed until after 'next' re-opens. In preparation for this freeze to 'master' next week, I'm now freezing 'next' to new features. We should work to get topics already in 'next' through to 'master' within the next week. Documentation and bug fix topics may still of course be added to 'next'. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Extracting target metadata, IDE integration
On 01/25/2015 08:26 AM, Tobias Hunger wrote: I just had a bit of time to play with cmake this weekend: Is this patch available somewhere by now? Aleix sent it in a message of this thread on 2015-01-09: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/10711/focus=12061 Some review comments elsewhere in this thread are still pending. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Patch for some GUI Mac fixes
These 3 patches fix the Install menu not showing for Qt5 builds, the Install buttons not behaving like the other (standard) buttons, and fixes the search field not being shown on OS X when the window is at minimum size. gui-mac.patch Description: Binary data Kevin -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 02:28 PM, Robert Goulet wrote: Here's a patch for adding additional compile flags to .hlsl files in Visual Studio. For this I simply added the new VS_SHADER_FLAGS source file property and basically did the same as other VS_SHADER_* properties. Okay. Please use spaces instead of tabs and match the surrounding indentation. Also please add/modify: Help/prop_sf/VS_SHADER_FLAGS.rst Help/manual/cmake-properties.7.rst to add the documentation, and add a release note as: Help/release/dev/vs-shader-flags.rst following the style of other release note files in that directory. Also please extend Tests/VSWinStorePhone/CMakeLists.txt with a test for this feature. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Extracting target metadata, IDE integration
I gave this patch a try with the cmake project data. I had hoped that this file would contain all the information an IDE might need, but there seems quite a bit missing for that. E.g. there is no information on which files are used to build a target. What am I missing? Best Regards, Tobias On Mon, Jan 26, 2015 at 4:23 PM, Brad King brad.k...@kitware.com wrote: On 01/25/2015 08:26 AM, Tobias Hunger wrote: I just had a bit of time to play with cmake this weekend: Is this patch available somewhere by now? Aleix sent it in a message of this thread on 2015-01-09: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/10711/focus=12061 Some review comments elsewhere in this thread are still pending. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Introduction and volunteering for the Matlab package
Dear Brad, I addressed your proposed solution and sent you a patch, that is pending approval since this afternoon because of a size exceeding 300KB. Best regards, Raffi Enficiaud On 26 Jan 2015, at 14:43, Brad King brad.k...@kitware.com wrote: On 01/23/2015 07:52 PM, Raffi Enficiaud wrote: This should be handled with a save/restore. Are you referring to the CMakePushCheckState? No, CMAKE_FIND_LIBRARY_PREFIXES should be saved/restored manually with code in the Find module around the find_library calls. You could also create a _Matlab_find_library function that sets CMAKE_FIND_LIBRARY_PREFIXES and calls find_library. The setting would go out of scope when the function returns. See the FindBoost module for a similar example. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
Here's a patch for adding additional compile flags to .hlsl files in Visual Studio. For this I simply added the new VS_SHADER_FLAGS source file property and basically did the same as other VS_SHADER_* properties. Tested in my project and it works. Please consider merging in master. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Monday, January 26, 2015 1:23 PM To: Robert Goulet Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files? On 01/26/2015 01:10 PM, Robert Goulet wrote: I might just go and add the COMPILE_FLAGS into the custom logic. Okay. Look at the OutputSourceSpecificFlags logic as a reference. -Brad add_vs_shader_flags_property.patch Description: add_vs_shader_flags_property.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Setting additional compile flags to .hlsl files?
Hi all, Any reasons why setting additional compile flags on .hlsl files would not work? I tried this: set_source_files_properties(${SHADER_FILE} PROPERTIES COMPILE_FLAGS /I${CMAKE_SOURCE_DIR}/src) ...and it didn't get written to the .vcxproj file at all. In this specific case, I want to add include directories when I build this .hlsl shader. Is it correct to assume that it should have passed the additional flag to this file? Or maybe there's another way to do this? Thanks. Robert Goulet Senior Software Developer Games Solutions Group Autodesk Media Entertainment MAIN +1 514 393 1616 DIRECT +1 514 954 3911 MOBILE +1 438 397 4075 Autodesk, Inc. 10 Rue Duke Montreal, QC, H3C 2L7 www.autodesk.comhttp://www.autodesk.com/ [Description: Email_Signature_Logobar] -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch for some GUI Mac fixes
On Monday, January 26, 2015 08:01:31 AM Kevin Wojniak wrote: These 3 patches fix the Install menu not showing for Qt5 builds, the Install buttons not behaving like the other (standard) buttons, and fixes the search field not being shown on OS X when the window is at minimum size. Thanks for the patches! They have been applied: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=8ced6375 http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b46a1519 http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=c19539c5 Clint -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
Do we really need to go down the road of making hlsl a 'first-class' language to add support for additional compile flags? -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Monday, January 26, 2015 12:43 PM To: Robert Goulet Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files? On 01/26/2015 12:20 PM, Robert Goulet wrote: set_source_files_properties(${SHADER_FILE} PROPERTIES COMPILE_FLAGS /I${CMAKE_SOURCE_DIR}/src) and it didn't get written to the .vcxproj file at all. Right now .hlsl files are written by cmVisualStudio10TargetGenerator::WriteExtraSource because they are (perhaps incorrectly) not classified as compiled sources. Look at use of GetObjectSources in cmVisualStudio10TargetGenerator::WriteAllSources for where compiled sources get handled. The OutputSourceSpecificFlags method handles source-specific COMPILE_FLAGS. The reason .hlsl files are not classified as compiled sources is because HLSL is not a first-class language in CMake that one enables via enable_language(). This also prevents them from being handled by non-VS generators. If you are interested in working on making HLSL a first-class language I can help you get started. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
Considering HLSL is DirectX only, I don't think we need (yet) to add it as a first-class language. And also because of time constraints, I might just go and add the COMPILE_FLAGS into the custom logic. I will send a patch when I can. Thanks! -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Monday, January 26, 2015 1:08 PM To: Robert Goulet Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files? On 01/26/2015 01:04 PM, Robert Goulet wrote: Do we really need to go down the road of making hlsl a 'first-class' language to add support for additional compile flags? Right now the Visual Studio generator has custom logic for .hlsl sources, so the rest of CMake knows nothing about them and treats them like .txt files. So, one could either add more custom logic to the VS .hlsl support to honor COMPILE_FLAGS, or add the needed infrastructure for enable_language(HLSL). The latter approach is much more general. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0015372]: CMAKE_Fortran_COMPILER_VERSION is never set but FindOpenMP.cmake depends on it
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15372 == Reported By:Kelly Thompson Assigned To: == Project:CMake Issue ID: 15372 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2015-01-26 13:10 EST Last Modified: 2015-01-26 13:10 EST == Summary:CMAKE_Fortran_COMPILER_VERSION is never set but FindOpenMP.cmake depends on it Description: I am trying to use FindOpenMP.cmake provided by cmake/3.1.1 but it is returning the wrong value for ${OpenMP_Fortran_FLAGS} because the value of CMAKE_Fortran_COMPILER_VERSION is never set by CMake. When using ifort 15, FindOpenMP returns the deprecated value for older versions of ifort (ver 15.0.0.20140528). Steps to Reproduce: The missing value for CMAKE_Fortran_COMPILER_VERSION does not appear to depend on the compiler chosen. Running cmake with the CMakeLists.txt provided below shows that the value is blank: cmake_minimum_required(VERSION 3.1) project(nofortranver CXX Fortran) find_package(OpenMP) message( CMAKE_Fortran_COMPILER_ID = ${CMAKE_Fortran_COMPILER_ID} CMAKE_Fortran_COMPILER_VERSION = ${CMAKE_Fortran_COMPILER_VERSION} ) == Issue History Date ModifiedUsername FieldChange == 2015-01-26 13:10 Kelly Thompson New Issue == -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 12:20 PM, Robert Goulet wrote: set_source_files_properties(${SHADER_FILE} PROPERTIES COMPILE_FLAGS /I${CMAKE_SOURCE_DIR}/src) and it didn't get written to the .vcxproj file at all. Right now .hlsl files are written by cmVisualStudio10TargetGenerator::WriteExtraSource because they are (perhaps incorrectly) not classified as compiled sources. Look at use of GetObjectSources in cmVisualStudio10TargetGenerator::WriteAllSources for where compiled sources get handled. The OutputSourceSpecificFlags method handles source-specific COMPILE_FLAGS. The reason .hlsl files are not classified as compiled sources is because HLSL is not a first-class language in CMake that one enables via enable_language(). This also prevents them from being handled by non-VS generators. If you are interested in working on making HLSL a first-class language I can help you get started. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 01:04 PM, Robert Goulet wrote: Do we really need to go down the road of making hlsl a 'first-class' language to add support for additional compile flags? Right now the Visual Studio generator has custom logic for .hlsl sources, so the rest of CMake knows nothing about them and treats them like .txt files. So, one could either add more custom logic to the VS .hlsl support to honor COMPILE_FLAGS, or add the needed infrastructure for enable_language(HLSL). The latter approach is much more general. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 01:10 PM, Robert Goulet wrote: I might just go and add the COMPILE_FLAGS into the custom logic. Okay. Look at the OutputSourceSpecificFlags logic as a reference. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0015371]: Different components for library and link using just one install command
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15371 == Reported By:Daniele E. Domenichelli Assigned To: == Project:CMake Issue ID: 15371 Category: CMake Reproducibility:N/A Severity: feature Priority: normal Status: new == Date Submitted: 2015-01-26 10:17 CET Last Modified: 2015-01-26 10:17 CET == Summary:Different components for library and link using just one install command Description: When a library with a SOVERSION is created, the only way to install the library and the links to the library with a different component is installing the target twice using NAMELINK_SKIP and NAMELINK_ONLY. For example add_library(foo ${foo_SRCS}) set_target_properties(foo PROPERTIES SOVERSION 1) install(TARGETS foo LIBRARY DESTINATION lib COMPONENT library NAMELINK_SKIP) install(TARGETS foo LIBRARY DESTINATION lib COMPONENT devel NAMELINK_ONLY) This is redundant and not intuitive, it would be useful to be able to do this in just one command, for example: install(TARGETS foo LIBRARY DESTINATION lib COMPONENT library NAMELINK_COMPONENT devel) Additional Information: Mailing list thread here: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/12023 == Issue History Date ModifiedUsername FieldChange == 2015-01-26 10:17 Daniele E. DomenichelliNew Issue == -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Improving Vim support in CMake
On Monday 26 January 2015 11:00:44 Ben Boeckel wrote: On Mon, Jan 26, 2015 at 11:00:05 -0500, Ben Boeckel wrote: Odd; attached is an HTML dump from Vim for what I see (:TOhtml) where variable expansions are highlighted in strings just like outside of strings. Probably help if I actually attached the file :/ . --Ben Maybe it's just my colour scheme - I'll have a play with the colour settings when I have some free time. Alex -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Improving Vim support in CMake
On Mon, Jan 26, 2015 at 22:39:00 +, Alex Merry wrote: Maybe it's just my colour scheme - I'll have a play with the colour settings when I have some free time. FWIW, I use neverland-darker, a 256-color scheme. Looking at it with an 8-color scheme does indeed have it all being the same. 'Label' seems to at least be different than 'String' in all the default color schemes whereas 'Constant' is the same as 'String' there. Unfortunately, there's no 'Variable' highlighting group and if we don't stick to the defaults available, none of the colorschemes will know what to do with it :/ . 'Tag' also seems like it might be viable. Maybe making cmakeArguments - Constant and cmakeVariableValue - Identifier would work better? Strings are the same as unquoted words there though :/ . --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers