Re: [cmake-developers] Introduction and volunteering for the Matlab package
Dear Brad,
Please find attached a patch addressing the issues mentioned in your email.
The tests were failing because of the following modification:
- matlab_get_version_from_matlab_run(${Matlab_MAIN_PROGRAM}
matlab_list_of_all_versions)
+ matlab_get_version_from_matlab_run(${Matlab_MAIN_PROGRAM}
matlab_list_of_all_versions)
Apparently the quotes here are interpreted as part of the binary name, which
prevents the proper call to matlab using the execute_process function.
I kept the symlink resolution, but I narrowed the case those should be
resolved. I added a variable pointing to the (symlink resolved) location of the
binary from which the version is retrieved. I compare paths symlink resolved
for that purpose. I hope this is in line with what you would like to have.
Note that I only tested on LinuxLTS14.04 locally, I will test further tomorrow
morning.
I also changed the build path of the Windows agent, the build should be clear
on Windows now.
Best regards,
Raffi Enficiaud
0001-Addressing-the-visibility-of-the-internal-variables-.patch
Description: Binary data
On 13 Feb 2015, at 16:36, Brad King brad.k...@kitware.com wrote:
On 02/13/2015 09:43 AM, Raffi Enficiaud wrote:
* Why is Matlab_VERSION_STRING cached? Shouldn't it be computed
every time from the matlab that was found?
In case the version is not found with an obvious method
(on OSX /Applications/MATLABVersion, on Win32, the version also is
given by the registry key), we have to find the version of matlab
by running matlab itself. I am caching the version once I have it
to prevent any further execution of matlab for retrieving this
information.
Okay. Currently the value is user-facing, but it shouldn't ever be
edited manually, right? Instead the detected version could be cached
in an INTERNAL cache entry. Also there should be a second internal
entry that records which matlab program was executed to compute the
version. If the latter does not match then the version should be
re-computed.
In case a symlink of the binary called matlab exists in /usr/local/bin
for instance, I need to retrieve the path of the libraries mex, mx etc,
that are relative to the real installation path of matlab.
In that case I think you should look for those pieces relative to
the original executable location first, and if not found then
resolve symlinks into a temporary variable name and then use that.
The resolved path should not be made user-facing so that any user
that sets Matlab_MAIN_PROGRAM explicitly will see that value
persist.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0015408]: FindJNI missing JAVA_AWT_LIBRARY on JDK9 as jdk/lib/arch is not included in JAVA_AWT_LIBRARY_DIRECTORIES
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15408 == Reported By:Tiago Stürmer Daitx Assigned To: == Project:CMake Issue ID: 15408 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2015-02-18 01:12 EST Last Modified: 2015-02-18 01:12 EST == Summary:FindJNI missing JAVA_AWT_LIBRARY on JDK9 as jdk/lib/arch is not included in JAVA_AWT_LIBRARY_DIRECTORIES Description: JDK9's directory structure changes and no jdk/jre exists. The right arch lib path is now jdk/lib/arch (instead of jdk/jre/lib/arch). CMake error when building hadoop-common: [exec] CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message): [exec] Could NOT find JNI (missing: JAVA_AWT_LIBRARY) [exec] Call Stack (most recent call first): [exec] /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:315 (_FPHSA_FA-- Detecting CXX compiler ABI info - done [exec] -- Configuring incomplete, errors occurred! [exec] See also /home/tdaitx/hadoop-2.6.0-src/hadoop-common-project/hadoop-common/target/native/CMakeFiles/CMakeOutput.log. [exec] ILURE_MESSAGE) [exec] /usr/share/cmake-2.8/Modules/FindJNI.cmake:252 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) [exec] CMakeLists.txt:103 (find_p [exec] ackage) Steps to Reproduce: 1. Build JDK9 2. Compile hadoop-common-project/hadoop-common Additional Information: hadoop-common has its own bug and might require a patch, see https://issues.apache.org/jira/browse/HADOOP-11610 == Issue History Date ModifiedUsername FieldChange == 2015-02-18 01:12 Tiago Stürmer DaitxNew Issue == -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support
I submitted a test report with all the tests passing.
https://open.cdash.org/buildSummary.php?buildid=3698090. This test report
includes the extra tests that I added.
It looks like things are running even though I haven't made any changes
specifically to fix those failing tests. One of the issues I had before was
that I used the auto generated CTestScript.cmake script that ran
CTEST_UPDATE(SOURCE ${CTEST_SOURCE_DIRECTORY}). In addition, I found it
unusual that the CMakeOnly.MajorVersionSelection-PythonInterp_2 test will
fail if there is a path to the python 3.3 executable. Also, the
CMake.GetPrerequisites will sometimes timeout on my machine.
You can use Windows Task Scheduler to run a .bat file that calls ctest with
the dashboard script.
I set up a nightly build on my machine.
I'm not sure how to handle cases where the user wants to run all the test and
expects all to pass, but does not have Green Hills installed.
Geoffrey Viola
SOFTWARE ENGINEER
asirobots.com
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Tuesday, February 03, 2015 1:05 PM
To: Geoffrey Viola
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE
Generator Support
On 01/28/2015 10:51 PM, Geoffrey Viola wrote:
I submitted some builds.
I'm not sure why 9 fail.
Okay, let's get your builds submitting cleanly with no local changes first.
That way we can identify whether any of your changes cause the failures.
There are basic instructions for setting up a nightly build here:
http://www.cmake.org/Wiki/CMake/Git/Dashboard
You can use Windows Task Scheduler to run a .bat file that calls ctest with the
dashboard script.
Once we get your submission to a clean state then we can continue looking at
the changes for the new generator and whether they cause any failures.
Thanks,
-Brad
This message contains confidential information and is intended only for the
recipient. If you are not the named addressee you should not disseminate,
distribute or copy this e-mail. Please notify the sender immediately if you
have received this e-mail by mistake and delete this e-mail from your system.
Finally, the recipient should check this email and any attachments for the
presence of viruses. The company accepts no liability for any damage caused by
any virus transmitted by this email.
0001-Added-some-support-for-a-Green-Hills-MULTI.patch
Description: 0001-Added-some-support-for-a-Green-Hills-MULTI.patch
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support
On 02/17/2015 10:47 AM, Geoffrey Viola wrote: I submitted a test report with all the tests passing. https://open.cdash.org/buildSummary.php?buildid=3698090. Great, thanks. However, we really need to have the cmake_common.cmake script used to drive it. What I was asking in my previous response was for you to get a normal nightly testing dashboard submission configured and working independent of your changes. For that using the common script with ctest_update is okay. I'm not sure how to handle cases where the user wants to run all the test and expects all to pass, but does not have Green Hills installed. Any tests depending on local system configuration need to have an option to explicitly enable them on such systems. See the existing CMake_TEST_FindJsonCpp option for example. Just put your new test(s) inside a condition on a CMake_TEST_GreenHillsMULTI variable. Then add to your dashboard script:: set(dashboard_cache CMake_TEST_GreenHillsMULTI:BOOL=ON ) before including cmake_common.cmake and the tests will be enabled once they are in the repo. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 0/6] XCTest Bundles v4
On 02/15/2015 03:52 PM, Gregor Jasny wrote:
this series contains the latest XCTest patches.
Thanks. The primary remaining work is to figure out how to get
these tests activated. IIRC in earlier discussion you said that
some local machine setup is required. For that we need some kind
of option/condition in Tests/CMakeLists.txt to activate these tests.
See existing options like CMake_TEST_FindJsonCpp for similar
examples of tests that require explicit local configuration on
the test machine.
Please also add a Help/release/dev/xcode-xctest.rst file with
release notes describing the features added by this patch series.
See other files in that directory for examples.
For the ${_CMAKE_OSX_SYSROOT_PATH}/../../Library/Frameworks path,
please look at using get_filename_component to strip components
instead of using ../ components in the path.
In Tests/XcodePlatformFrameworks for detecting the Xcode version
you can use XCODE_VERSION:
http://www.cmake.org/cmake/help/v3.2/variable/XCODE_VERSION.html
Also this test could move to Tests/RunCMake/XcodeProject. In
Tests/RunCMake/CMakeLists.txt one could pass XCODE_VERSION into
the test's RunCMakeTest.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Introduction and volunteering for the Matlab package
On 02/13/2015 10:57 AM, Brad King wrote: I had to add two commits to the topic to fix some continuous testing failures: Please rebase further work on commit 5e91eb43. I will squash all this together later before merging to 'master'. After a few more fixes for other nightly testing failures I squashed all the changes into: FindMatlab: Rewrite module and provide a usage API http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9d414ca2 On your nightly submissions all the tests are passing on Windows. However, all FindMatlab-related tests fail on the other platforms. I've reverted the whole topic from 'next' for now until you have time to address these failures. Please base further patches on commit 9d414ca2. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [ANNOUNCE] CMake 3.2.0-rc1 now ready for testing!
On 02/17/2015 02:41 AM, Stephen Kelly wrote: Orion Poplawski wrote: We're getting a fair number of test failures on Fedora Rawhide (with gcc 5 c++11): This is a bug in GCC. I filed a bug and committed a workaround: http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=aaad0bf3 Work around bug in pre-release GNU CXX 5.0. Thanks for tracking that down, Steve! -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Introduction and volunteering for the Matlab package
Dear Brad, Yes, thank you, you did well. And sorry for the delay, it takes more time than expected. Best regards, Raffi Enficiaud On 17 Feb 2015, at 16:16, Brad King brad.k...@kitware.com wrote: On 02/13/2015 10:57 AM, Brad King wrote: I had to add two commits to the topic to fix some continuous testing failures: Please rebase further work on commit 5e91eb43. I will squash all this together later before merging to 'master'. After a few more fixes for other nightly testing failures I squashed all the changes into: FindMatlab: Rewrite module and provide a usage API http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9d414ca2 On your nightly submissions all the tests are passing on Windows. However, all FindMatlab-related tests fail on the other platforms. I've reverted the whole topic from 'next' for now until you have time to address these failures. Please base further patches on commit 9d414ca2. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI
On Tue, Feb 17, 2015 at 12:08 PM, Brad King brad.k...@kitware.com wrote: On 02/17/2015 12:21 PM, Robert Dailey wrote: What would be the best way to handle detecting which generators support toolset? The confusing piece I had to figure out last night is that there is simply no generator base class from which everything derives, there are 2 types: extra generators and generators. The extra generators are not of concern here. They are only ever used in conjunction with real generators. The base class for the latter is cmGlobalGenerator. However, cmGlobalGeneratorFactory is also a candidate for this check since it exists before the actual generator is created. You'll have to pick whichever works more cleanly for this use case. Of course right now only Visual Studio and XCode support the toolset parameter (according to the docs). These both happen to be global generators. However, I was thinking of a case in the future where Eclipse CDT4 or Code Blocks may support toolsets. Would these be implemented through global generators anyway? Does it make sense for extra generators to support toolset? Some educational explanation here for my benefit would be appreciated. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI
On 02/17/2015 01:43 PM, Robert Dailey wrote: Of course right now only Visual Studio and XCode support the toolset parameter Correct. Furthermore it is supported only for VS = 10. I was thinking of a case in the future where Eclipse CDT4 or Code Blocks may support toolsets. Would these be implemented through global generators anyway? Does it make sense for extra generators to support toolset? No. Extra generators only ever work in conjunction with a normal generator like Unix Makefiles. The main generator determines the toolchain. The extra generators just write out information for an IDE to browse the sources of the targets. The only build operation these generators have is that the IDEs may offer a button to run make to drive the main generator's build rules. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI
On 02/17/2015 12:21 PM, Robert Dailey wrote: What would be the best way to handle detecting which generators support toolset? The confusing piece I had to figure out last night is that there is simply no generator base class from which everything derives, there are 2 types: extra generators and generators. The extra generators are not of concern here. They are only ever used in conjunction with real generators. The base class for the latter is cmGlobalGenerator. However, cmGlobalGeneratorFactory is also a candidate for this check since it exists before the actual generator is created. You'll have to pick whichever works more cleanly for this use case. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
