Re: [cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-22 Thread Richard Shaw 
On Fri, Aug 22, 2014 at 8:44 AM, Brad King brad.k...@kitware.com wrote:

 On 08/21/2014 03:25 PM, Richard Shaw wrote:
  So the string command should be something like:
 
  string(REPLACE ;   wxWidgets_CXX_FLAGS_str ${wxWidgets_CXX_FLAGS})
  set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS_str})

 Yes, and followed by unset(wxWidgets_CXX_FLAGS_str) to clear the
 variable to not present it to applications.

 Ok, hopefully this is better. I'm reading up on git but I still fubmble
around a bit...

http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=8e702cabfb149d1c67af725a3952af7034a2981d

Thanks,
Richard
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-22 Thread Brad King 
On 08/22/2014 10:02 AM, Richard Shaw wrote:
 Ok, hopefully this is better. I'm reading up on git but I still fubmble 
 around a bit...
 
 http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=8e702cabfb149d1c67af725a3952af7034a2981d

Good.  Please rebase/rewrite the topic and force-push it back to the
stage to get rid of the extra merges and make it one commit again.
Also please follow up with a change to drop the MSG debugging macro
that was left in there before.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-22 Thread Richard Shaw 
On Thu, Aug 21, 2014 at 2:21 PM, Brad King brad.k...@kitware.com wrote:

 On 08/21/2014 02:30 PM, Richard Shaw wrote:
 if   (wxWidgets_CXX_FLAGS)
  +# Flags are expected to be a string here, not a list.
  +string(REPLACE ;   wxWidgets_CXX_FLAGS ${wxWidgets_CXX_FLAGS})
   set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS})

 Thanks.  However, we shouldn't leak our local modification to the value
 of wxWidgets_CXX_FLAGS, so the substitution should be done with the
 result stored in a temporary local variable.

 Also, please start the commit message in UsewxWidgets: 

 Ok, all updates have been incorporated, so I'm looking for an ACK to know
if it appears ready to push into next.

http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e6fa6e60f6330ddf60294a0d9a6ed4cb3f27d4c4

Thanks,
Richard
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-22 Thread Brad King 
On 08/22/2014 12:27 PM, Richard Shaw wrote:
 Ok, all updates have been incorporated, so I'm looking for an ACK

Looks good, thanks.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-21 Thread Richard Shaw 
This is a dead simple change but it's also my first commit so I figured I
would request a review.

All this commit does is make sure if multiple cflags are received from the
wx-config utility that it be converted back into a string so gcc doesn't
choke on it.

Since it's short enough I guess it would be useful to post the commit here:

commit 873ad28a305b718e09b97d9a287c0c5c162766c0
Author: Richard M. Shaw hobbes1...@gmail.com
Date:   Thu Aug 21 12:45:42 2014 -0500

Make sure cflags in UsewxWidgets are a string, not a list.

diff --git a/Modules/UsewxWidgets.cmake b/Modules/UsewxWidgets.cmake
index f2f260d..7c1f925 100644
--- a/Modules/UsewxWidgets.cmake
+++ b/Modules/UsewxWidgets.cmake
@@ -88,6 +88,8 @@ if   (wxWidgets_FOUND)
   endif()

   if   (wxWidgets_CXX_FLAGS)
+# Flags are expected to be a string here, not a list.
+string(REPLACE ;   wxWidgets_CXX_FLAGS ${wxWidgets_CXX_FLAGS})
 set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS})
 MSG(wxWidgets_CXX_FLAGS=${wxWidgets_CXX_FLAGS})
   endif()
--- end ---

Thanks,
Richard
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-21 Thread Brad King 
On 08/21/2014 02:30 PM, Richard Shaw wrote:
if   (wxWidgets_CXX_FLAGS)
 +# Flags are expected to be a string here, not a list.
 +string(REPLACE ;   wxWidgets_CXX_FLAGS ${wxWidgets_CXX_FLAGS})
  set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS})

Thanks.  However, we shouldn't leak our local modification to the value
of wxWidgets_CXX_FLAGS, so the substitution should be done with the
result stored in a temporary local variable.

Also, please start the commit message in UsewxWidgets: 

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [Review Request] Topic wxWidgets-cflags

2014-08-21 Thread Richard Shaw 
On Thu, Aug 21, 2014 at 2:21 PM, Brad King brad.k...@kitware.com wrote:

 On 08/21/2014 02:30 PM, Richard Shaw wrote:
 if   (wxWidgets_CXX_FLAGS)
  +# Flags are expected to be a string here, not a list.
  +string(REPLACE ;   wxWidgets_CXX_FLAGS ${wxWidgets_CXX_FLAGS})
   set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS})

 Thanks.  However, we shouldn't leak our local modification to the value
 of wxWidgets_CXX_FLAGS, so the substitution should be done with the
 result stored in a temporary local variable.


So the string command should be something like:

string(REPLACE ;   wxWidgets_CXX_FLAGS_str ${wxWidgets_CXX_FLAGS})
set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS_str})


Also, please start the commit message in UsewxWidgets: 


Ahh, I see how that would be helpful!

Thanks,
Richard
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers