Re: [cmake-developers] Contributing to CMake Server

2017-06-26 Thread Brad King
On 06/25/2017 05:34 AM, Michael Scott wrote:
> I'm looking to do a bit more CMake development and the CMake server 
> project looks interesting. Does this area still need more contributors 
> and what's the best way to see what tasks there are?

Thanks for volunteering.  There are some open issue tracker entries
with the `area:cmake-server` label.  There are also some merge requests
that you could look at reviewing.

Otherwise, development is primarily driven by the needs of IDE clients.
If you get involved with any of those it may provide more guidance.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Bug with CMAKE_ASM_COMPILER and Android NDK

2017-06-26 Thread Brad King
On 06/23/2017 03:18 PM, Robert Dailey wrote:
> enable_language(ASM)
> 
> CMake appears to find clang.exe in the wrong place

Add a `Modules/Platform/Android-Determine-ASM.cmake` module
based on `Modules/Platform/Android-Determine-CXX.cmake`.

Also the modules

  Modules/Platform/Android/Determine-Compiler-NDK.cmake
  Modules/Platform/Android/Determine-Compiler-Standalone.cmake
  Modules/Platform/Android/Determine-Compiler.cmake

need to be updated to set `_ANDROID_TOOL_ASM_COMPILER` and similar
variables for ASM as is done for C and CXX.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-26 Thread Robert Dailey
Hi,

I tried setting CMAKE_ANDROID_NDK_DEPRECATED_HEADERS in a common CMake
script of mine (set during configuration but before any targets are
created). I also tried making it a cache variable, but in each case it
isn't working. I set like this:

set( CMAKE_ANDROID_NDK_DEPRECATED_HEADERS 1 )

And for r14b NDK, the unified headers were used, I expected them to
NOT be used. When I move the above line of code to my toolchain file,
it works as expected (the unified headers are NOT used).

Why does this only work in the toolchain file? I'd like to be able to
set it outside the toolchain file because I do quite a bit of logic to
determine if I want deprecated headers to be used or not; it's not
meant to be something specified by the user/toolchain in my case, but
rather something calculated.

Thanks in advance.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Bug with CMAKE_ASM_COMPILER and Android NDK

2017-06-26 Thread Robert Dailey
On Mon, Jun 26, 2017 at 10:25 AM, Brad King  wrote:
> On 06/23/2017 03:18 PM, Robert Dailey wrote:
>> enable_language(ASM)
>>
>> CMake appears to find clang.exe in the wrong place
>
> Add a `Modules/Platform/Android-Determine-ASM.cmake` module
> based on `Modules/Platform/Android-Determine-CXX.cmake`.
>
> Also the modules
>
>   Modules/Platform/Android/Determine-Compiler-NDK.cmake
>   Modules/Platform/Android/Determine-Compiler-Standalone.cmake
>   Modules/Platform/Android/Determine-Compiler.cmake
>
> need to be updated to set `_ANDROID_TOOL_ASM_COMPILER` and similar
> variables for ASM as is done for C and CXX.

Are you saying I should modify my local installation? Or are these
your personal notes so that these changes get adopted upstream? Not
sure I understand...
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] Bug with CMAKE_ASM_COMPILER and Android NDK

2017-06-26 Thread Brad King
On 06/26/2017 03:06 PM, Robert Dailey wrote:
> Are you saying I should modify my local installation? Or are these
> your personal notes so that these changes get adopted upstream?

These are notes for anyone that wants to fix this in CMake by doing
development.  I don't know if I'll find time myself.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-26 Thread Brad King
On 06/26/2017 11:58 AM, Robert Dailey wrote:
> Why does this only work in the toolchain file?

1. It needs to be set early.

2. It needs to propagate into try_compile projects.

The toolchain file is sufficient for both.  A cache entry is okay
for (1) but for (2) one would additionally need to set this:

  
https://cmake.org/cmake/help/v3.9/variable/CMAKE_TRY_COMPILE_PLATFORM_VARIABLES.html

...though that is really meant for toolchain files too.

Note that toolchain files are meant to be local to the machine, not
distributed with source trees and full of introspection logic.  The
(local) author of the toolchain file should know the NDK version and
choose whether to use `CMAKE_ANDROID_NDK_DEPRECATED_HEADERS`.

Your project code could check the NDK version and error out if
the `CMAKE_ANDROID_NDK_DEPRECATED_HEADERS` is not correct.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers