[GitHub] incubator-trafodion pull request: [TRAFODION-2017] Use a maximum H...

2016-05-26 Thread DaveBirdsall 
Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/505#discussion_r64837288
  
--- Diff: core/sql/ustat/hs_globals.cpp ---
@@ -546,10 +557,11 @@ NABoolean HSGlobalsClass::setHBaseCacheSize(double 
sampleRatio)
   Int64 workableCacheSize = (Int64)(sampleRatio * calibrationFactor);
   if (workableCacheSize < 1)
 workableCacheSize = 1;  // can't go below 1 unfortunately
+  else if (workableCacheSize > 50)
+workableCacheSize = 50; 
 
-  Int32 max = getDefaultAsLong(HBASE_NUM_CACHE_ROWS_MAX);
-  if ((workableCacheSize < 1) && // don't bother if 1 works
-  (max == 1))  // don't do it if user has already set this CQD
+  Int32 maxDefault = getDefaultAsLong(HBASE_NUM_CACHE_ROWS_MAX);
+  if (maxDefault == 1) // don't do it if user has already set this CQD
--- End diff --

Thanks for the suggestion for NADefaults::getProvenance(). I'll make this 
change.

In the case that the user sets the CQD him/herself, I wanted to give them 
complete freedom to experiment as they please. Higher values may make UPDATE 
STATS run faster (though experiements suggest not by much). The trade-off in 
using higher values is an increased risk of failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-2004] UPDATE STATS no...

2016-05-26 Thread zellerh 
Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/499#discussion_r64833315
  
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -6004,10 +6013,13 @@ enum DefaultConstants NADefaults::holdOrRestore 
(const char *attrName,
   char * value = NULL;
   if (holdOrRestoreCQD == 1) // hold cqd
 {
-  if (heldDefaults_[attrEnum])
-   {
- NADELETEBASIC(heldDefaults_[attrEnum], NADHEAP);
-   }
+  if (heldHeldDefaults_[attrEnum])
+{
+  // Gasp! We've done three successive HOLDs... it's off to
+  // the bit bucket for the deepest value
+  NADELETEBASIC(heldHeldDefaults_[attrEnum], NADHEAP);
--- End diff --

My preference as a user would be an assert instead of incorrect behavior. 
But this is probably a very little-used feature, so I doubt anyone will run 
into this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-2017] Use a maximum H...

2016-05-26 Thread zellerh 
Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/505#discussion_r64832927
  
--- Diff: core/sql/ustat/hs_globals.cpp ---
@@ -546,10 +557,11 @@ NABoolean HSGlobalsClass::setHBaseCacheSize(double 
sampleRatio)
   Int64 workableCacheSize = (Int64)(sampleRatio * calibrationFactor);
   if (workableCacheSize < 1)
 workableCacheSize = 1;  // can't go below 1 unfortunately
+  else if (workableCacheSize > 50)
+workableCacheSize = 50; 
 
-  Int32 max = getDefaultAsLong(HBASE_NUM_CACHE_ROWS_MAX);
-  if ((workableCacheSize < 1) && // don't bother if 1 works
-  (max == 1))  // don't do it if user has already set this CQD
+  Int32 maxDefault = getDefaultAsLong(HBASE_NUM_CACHE_ROWS_MAX);
+  if (maxDefault == 1) // don't do it if user has already set this CQD
--- End diff --

This is existing code, but wanted to comment anyway: The code will break if 
we ever update HBASE_NUM_CACHE_ROWS_MAX in nadefaults.cpp and fail to update 
this file to the same value.

There is another way to do this check: NADefaults::getProvenance() will 
return INIT_DEFAULT_DEFAULTS if a default hasn't been updated from the 
hard-coded defaults.

I'm also wondering whether a higher value chosen by a user would be right 
here, given that we may use very small sample ratios. This may be different 
than the other workloads a user runs? Wouldn't it be better to use 
MIN(maxDefault, workableCacheSize)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-2017] Use a maximum H...

2016-05-26 Thread DaveBirdsall 
GitHub user DaveBirdsall opened a pull request:

https://github.com/apache/incubator-trafodion/pull/505

[TRAFODION-2017] Use a maximum HBase row cache of 50 for USTAT sample…

… scans

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2017

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #505


commit d03526a2a508097dc8f23ac6fd63abb756a2a98e
Author: Dave Birdsall 
Date:   2016-05-26T22:03:10Z

[TRAFODION-2017] Use a maximum HBase row cache of 50 for USTAT sample scans




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFDOION-1664] Trafci install ...

2016-05-26 Thread hegdean 
GitHub user hegdean opened a pull request:

https://github.com/apache/incubator-trafodion/pull/504

[TRAFDOION-1664] Trafci install wizard legal disclaimer needs updating

[TRAFODION-1984] Installer packaging is not included in main package build 
target
[TRAFODION-1479] sqcheck should display the status of the rest server
 Additional fixes: 
  Resolved the partially installled Linux ODBC driver along with Trafodion 
server
  sqvers -u will not display the database edition for jar files
  Eliminated the redundant use of 'jps' in sqcheck and dcscheck scripts

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hegdean/incubator-trafodion wrkbrnch-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #504


commit 8ac0b9f360db9b65bee08af1a963527b79524685
Author: Anuradha Hegde 
Date:   2016-05-17T16:28:01Z

sqcheck now displays RESTServer status along with other components

commit 4ac9c9a84be1caaeaecf632ab4cdc3de7c0ab310
Author: Anuradha Hegde 
Date:   2016-05-17T18:23:29Z

Updated jar files to display the database edition so 'sqvers -u'
output is displayed correctly

commit 6c7cac6c1a6d99f4c09ffaaa0bbd773133792c24
Author: Anuradha Hegde 
Date:   2016-05-17T19:48:57Z

Modified servername in TRAFDSN to use localhost instead of dummy hostname

commit 908e2422c56f6fd1aba46dd53b00dcf265cf3af4
Author: Anuradha Hegde 
Date:   2016-05-19T23:55:19Z

Installing odbc linux driver along with server component

commit ccb6a7ef8a324e7efca2025cf2824adbd78af7c9
Author: Anuradha Hegde 
Date:   2016-05-20T05:09:03Z

Added copyright header

commit 92aaccd2e1fdc15f7e2d109ee2a152bfa834c3ca
Author: Anuradha Hegde 
Date:   2016-05-20T16:14:27Z

Fixed the clean target

commit 9623bf179cfee064deda6af60a17cb907b9ab4d4
Author: Anuradha Hegde 
Date:   2016-05-24T05:44:10Z

Linux odbc driver will now be installed along with Server component
Installer tar is packaged and distributed with 'make pacakge-all'
Fixed minor issues

commit 9fb1bdde5007b2e38198cc1139742798af78936b
Author: Anuradha Hegde 
Date:   2016-05-24T15:45:29Z

Merge branch 'master' into wrkbrnch-2.1

commit b8df0e25cf4b6d9ac29cb84c3798d09bb4b98aa9
Author: Anuradha Hegde 
Date:   2016-05-24T17:15:37Z

Changed installer tar file name

commit 0365574a3a6648f06ecfe043e0856d28b6e80376
Author: Anuradha Hegde 
Date:   2016-05-24T17:52:07Z

Updated the legal disclaimer in install wizard

commit 30093ab44c35df3cde2825162cde2c7c431b798a
Author: Anuradha Hegde 
Date:   2016-05-24T23:43:27Z

Fixed the dependency for installer package

commit a5b4b9631478acec7a1b6ea10752e5051db399e6
Author: Anuradha Hegde 
Date:   2016-05-25T23:34:48Z

eliminated the redundant jps command from the check scripts

commit a2bd4ac12834931d7bb2dfce662c47e2d99cd6a6
Author: Anuradha Hegde 
Date:   2016-05-26T18:50:24Z

Merge remote branch 'origin/master' into wrkbrnch-2.1

Conflicts:
licenses/Makefile




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---