date:20200105

[jira] [Created] (AIRFLOW-6482) task_instance will be in queued state forever

2020-01-05 Thread Kang Yu (Jira)

Kang Yu created AIRFLOW-6482:


 Summary: task_instance will be in queued state forever
 Key: AIRFLOW-6482
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6482
 Project: Apache Airflow
  Issue Type: Bug
  Components: scheduler
Affects Versions: 1.10.5
 Environment: aws EC2 spot instance
Reporter: Kang Yu


We built an airflow cluster on aws EC2 directly.

We are using Spot EC2 instances for workers, so sometimes work will be 
terminated.

This will cause airflow.job record missing, then the zombie detection won't 
work with this case I guess.


I investigated the code, there is a detection logic for zombie tasks:

[https://github.com/apache/airflow/blob/704e48dee368d193f742e064f42461205ef587e2/airflow/models/dagbag.py#L295-L306]

But this logic needs to join two tables: airflow.job and airflow.task_instance.

Because the record of airflow.job was inserted when the worker starts running a 
task_instance. It could be lost if EC2 instance dead.

 

I think here have to enhance the zombie detection logic by using a record of 
task_instance only:

detect the queued_dttm time with a threshold. *if (now - queued_dttm > 
THE_THRESHOLD and LJ.state != State.RUNNING) then mark it as failed directly.*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] codecov-io commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation

2020-01-05 Thread GitBox

codecov-io commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view 
and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=h1) 
Report
   > Merging 
[#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6900/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6900  +/-   ##
   ==
   - Coverage   85.01%   85.01%   -0.01% 
   ==
 Files 680  680  
 Lines   3874838746   -2 
   ==
   - Hits3294232939   -3 
   - Misses   5806 5807   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==)
 | `91.12% <ø> (ø)` | :arrow_up: |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.73% <100%> (+0.11%)` | :arrow_up: |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <0%> (-2.67%)` | :arrow_down: |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=footer). 
Last update 
[f4c7d17...2f857fd](https://codecov.io/gh/apache/airflow/pull/6900?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (AIRFLOW-6476) Docker creates some mounted files as directories if empty

2020-01-05 Thread Jarek Potiuk (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-6476.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> Docker creates some mounted files as directories if empty
> -
>
> Key: AIRFLOW-6476
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6476
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Priority: Major
> Fix For: 2.0.0
>
>
> Some of the files that are mounted to breeze might not be created when first 
> time run and then docker will turn them into directories.
> We should delete dirs/touch files in both breeze script and static check 
> scripts to get it fixed
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6476) Docker creates some mounted files as directories if empty

2020-01-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008588#comment-17008588
 ] 

ASF GitHub Bot commented on AIRFLOW-6476:
-

potiuk commented on pull request #7066: [AIRFLOW-6476] Fix directories created 
by docker
URL: https://github.com/apache/airflow/pull/7066
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Docker creates some mounted files as directories if empty
> -
>
> Key: AIRFLOW-6476
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6476
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Priority: Major
>
> Some of the files that are mounted to breeze might not be created when first 
> time run and then docker will turn them into directories.
> We should delete dirs/touch files in both breeze script and static check 
> scripts to get it fixed
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6476) Docker creates some mounted files as directories if empty

2020-01-05 Thread ASF subversion and git services (Jira)



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008589#comment-17008589
 ] 

ASF subversion and git services commented on AIRFLOW-6476:
--

Commit dbc829faa27b16fcfb21a522e271fe0ba1f3544e in airflow's branch 
refs/heads/master from Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=dbc829f ]

[AIRFLOW-6476] Fix directories created by docker (#7066)

Some of the files that are mounted to breeze might not be created when first
time run and then docker will turn them into directories.

We should delete dirs/touch files in both breeze script and static check
scripts to get it fixed

> Docker creates some mounted files as directories if empty
> -
>
> Key: AIRFLOW-6476
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6476
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Priority: Major
> Fix For: 2.0.0
>
>
> Some of the files that are mounted to breeze might not be created when first 
> time run and then docker will turn them into directories.
> We should delete dirs/touch files in both breeze script and static check 
> scripts to get it fixed
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] potiuk merged pull request #7066: [AIRFLOW-6476] Fix directories created by docker

2020-01-05 Thread GitBox

potiuk merged pull request #7066: [AIRFLOW-6476] Fix directories created by 
docker
URL: https://github.com/apache/airflow/pull/7066
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg

2020-01-05 Thread GitBox

potiuk commented on issue #6881: [AIRFLOW-6326] [WIP] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571033170
 
 
   BTW. I added WIP in the title - to indicate this is still in progress :). We 
have nice Bot now that will keep it from accidentally being merged :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

2020-01-05 Thread GitBox

potiuk commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571032638
 
 
   @zhongjiajie : I think it will be best if sort according to long option only 
(especially if we fix the short options to be one-letter). General idea behind 
long options is that people - when learning CLI tend to use longer options and 
they are preferred in automation/scripts. They are easier to memorize and they 
carry the meaning. Also when using autocomplete, it is much easier to learn as 
you start using longer option prefix and it gets auto-completed.
   
   The short (one letter) options are for "expert mode" only and they are 
pretty much just a shorthand if you get familiar with the CLI and want to use 
it quickly / have no autocomplete and you are very familiar with the tool 
itself.
   
   That's why i prefer to sort only on long options.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

potiuk merged pull request #6999: [AIRFLOW-] Clarify wait_for_downstream 
and execution_date
URL: https://github.com/apache/airflow/pull/6999
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > Merging 
[#6993](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6993  +/-   ##
   ==
   + Coverage84.7%   84.83%   +0.12% 
   ==
 Files 680  679   -1 
 Lines   3855639074 +518 
   ==
   + Hits3265933147 +488 
   - Misses   5897 5927  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `94.04% <ø> (ø)` | :arrow_up: |
   | 
[airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5)
 | `73.12% <100%> (+2.91%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5)
 | `86.3% <0%> (-5.17%)` | :arrow_down: |
   | 
[airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=)
 | `68.75% <0%> (-2.95%)` | :arrow_down: |
   | 
[airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5)
 | `91.43% <0%> (-1.22%)` | :arrow_down: |
   | ... and [86 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[7d97d16...019ad73](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   85.01%   84.72%   -0.29% 
   ==
 Files 680  680  
 Lines   3874838748  
   ==
   - Hits3294232830 -112 
   - Misses   5806 5918 +112
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <0%> (-2.67%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[f4c7d17...ee9ba23](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   85.01%   84.72%   -0.29% 
   ==
 Files 680  680  
 Lines   3874838748  
   ==
   - Hits3294232830 -112 
   - Misses   5806 5918 +112
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <0%> (-2.67%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[f4c7d17...ee9ba23](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   85.01%   84.72%   -0.29% 
   ==
 Files 680  680  
 Lines   3874838748  
   ==
   - Hits3294232830 -112 
   - Misses   5806 5918 +112
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <0%> (-2.67%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[f4c7d17...ee9ba23](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg

2020-01-05 Thread GitBox

zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571005760
 
 
   We still have discuss in 
https://github.com/apache/airflow/pull/6881#issuecomment-570850316, It's will 
be great if @potiuk @mik-laj to share your idea.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7038: [AIRFLOW-4495] allow externally 
triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#issuecomment-570935774
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=h1) 
Report
   > Merging 
[#7038](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fbb855c907fa5f5c34c97c45d29d502355756bd3?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7038/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7038  +/-   ##
   ==
   - Coverage   84.97%   84.69%   -0.29% 
   ==
 Files 679  679  
 Lines   3866438669   +5 
   ==
   - Hits3285532749 -106 
   - Misses   5809 5920 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `88.71% <0%> (-0.13%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/runnable\_exec\_date\_dep.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcnVubmFibGVfZXhlY19kYXRlX2RlcC5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.51% <75%> (-0.12%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.88% <0%> (+0.28%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=footer). 
Last update 
[fbb855c...71e63b2](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil opened a new pull request #7071: [AIRFLOW-XXXX] Add config to welcome first time contributors

2020-01-05 Thread GitBox

kaxil opened a new pull request #7071: [AIRFLOW-] Add config to welcome 
first time contributors
URL: https://github.com/apache/airflow/pull/7071
 
 
   I have added a feature to greet new contributors when they open new PR and 
when their first PR gets merged.
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-
   
   - [x] Description above provides context of the change
   - [x] Commit message starts with `[AIRFLOW-]`, where AIRFLOW- = JIRA 
ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message 
starts `[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yuqian90 commented on a change in pull request #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

yuqian90 commented on a change in pull request #7038: [AIRFLOW-4495] allow 
externally triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#discussion_r363145270
 
 

 ##
 File path: airflow/models/dag.py
 ##
 @@ -778,16 +778,26 @@ def set_dependency(self, upstream_task_id, 
downstream_task_id):
 def get_task_instances(
 self, start_date=None, end_date=None, state=None, session=None):
 if not start_date:
+# TODO why 30?
 start_date = (timezone.utcnow() - timedelta(30)).date()
 start_date = timezone.make_aware(
 datetime.combine(start_date, datetime.min.time()))
-end_date = end_date or timezone.utcnow()
-tis = session.query(TaskInstance).filter(
-TaskInstance.dag_id == self.dag_id,
-TaskInstance.execution_date >= start_date,
-TaskInstance.execution_date <= end_date,
-TaskInstance.task_id.in_([t.task_id for t in self.tasks]),
-)
+
 
 Review comment:
   Okay this does look necessary. And it's easy to fix. How about adding this 
property to `class DAG`?
   
   ```python
   class DAG:
   ...
   @property
   def allow_future_exec_dates(self):
   return conf.getboolean('scheduler', 'RUN_FUTURE_EXEC_DATES', 
fallback=False) and self.schedule_interval is None
   ```
   
   
   This line can become:
   ```python
   tis = session.query(TaskInstance).filter(TaskInstance.dag_id == 
self.dag_id,
TaskInstance.execution_date 
>= start_date,

TaskInstance.task_id.in_([t.task_id for t in self.tasks]))
   
   if end_date or not self.allow_future_exec_dates:
   end_date = end_date or timezone.utcnow()
   tis = tis.filter(TaskInstance.execution_date <= end_date)
   ```
   
   And you may want to use `dag.allow_future_exec_dates` in the two other 
places that you checked the same conditions too, i.e. scheduler_job.py and 
runnable_exec_date_dep.py


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-01-05 Thread Teddy Hartanto (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teddy Hartanto updated AIRFLOW-6481:

Description: 
I've searched through Airflow's issues and couldn't find any report regarding 
this. I wonder if I'm the only one who's facing this? 
{noformat}
Panda version: 0.24.2{noformat}
*Bug description*

I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
this exception:
{code:java}
AttributeError: ('Can only use .str accessor with string values, which use 
np.object_ dtype in pandas', ...)
{code}
This exception occurs here:
{code:java}
if fmt == "csv":
# there are also a ton of newline objects
# that mess up our ability to write to csv
# we remove these newlines so that the output is a valid CSV format
self.log.info("Cleaning data and writing to CSV")
possible_strings = df.columns[df.dtypes == "object"]
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\n", "")
)

# write the dataframe
df.to_csv(filename, index=False)
{code}
To fix it, we should just cast the object type to string as such: 
{code:java}
if fmt == "csv":
...
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\n", "")
)
{code}
I've tested this and it works for me. Could somebody help me verify that the 
type conversion is indeed needed? If yes, I'm keen to submit a PR to fix this 
with the unit test included.

  was:
I've searched through Airflow's issues and couldn't find any report regarding 
this. I wonder if I'm the only one who's facing this? 

 

*Bug description*

I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
this exception:
{code:java}
AttributeError: ('Can only use .str accessor with string values, which use 
np.object_ dtype in pandas', ...)
{code}
This exception occurs here:
{code:java}
if fmt == "csv":
# there are also a ton of newline objects
# that mess up our ability to write to csv
# we remove these newlines so that the output is a valid CSV format
self.log.info("Cleaning data and writing to CSV")
possible_strings = df.columns[df.dtypes == "object"]
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\n", "")
)

# write the dataframe
df.to_csv(filename, index=False)
{code}
To fix it, we should just cast the object type to string as such: 
{code:java}
if fmt == "csv":
...
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\n", "")
)
{code}
I've tested this and it works for me. Could somebody help me verify that the 
type conversion is indeed needed? If yes, I'm keen to submit a PR to fix this 
with the unit test included.


> SalesforceHook attempts to use .str accessor on object dtype
> 
>
> Key: AIRFLOW-6481
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6481
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.7
>Reporter: Teddy Hartanto
>Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I've searched through Airflow's issues and couldn't find any report regarding 
> this. I wonder if I'm the only one who's facing this? 
> {noformat}
> Panda version: 0.24.2{noformat}
> *Bug description*
> I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
> this exception:
> {code:java}
> AttributeError: ('Can only use .str accessor with string values, which use 
> np.object_ dtype in pandas', ...)
> {code}
> This exception occurs here:
> {code:java}
> if fmt == "csv":
> # there are also a ton of newline objects
> # that mess up our ability to write to csv
> # we remove these newlines so that the output is a valid CSV format
> self.log.info("Cleaning data and writing to CSV")
> possible_strings = df.columns[df.dtypes == "object"]
> df[possible_strings] = df[possible_strings].apply(
> lambda x: x.str.replace("\r\n", "")
> )
> df[possible_strings] = df[possible_strings].apply(
> lambda x: x.str.replace("\n", "")
> )
> # write the dataframe
> df.to_csv(filename, index=False)
> {code}
> To fix it, we should just cast the object type to string as such: 
> {code:java}
> if fmt == "csv":
> ...
>

[jira] [Updated] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-01-05 Thread Teddy Hartanto (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teddy Hartanto updated AIRFLOW-6481:

Summary: SalesforceHook attempts to use .str accessor on object dtype  
(was: SalesforceHook attempts to use .str accessor )

> SalesforceHook attempts to use .str accessor on object dtype
> 
>
> Key: AIRFLOW-6481
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6481
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.7
>Reporter: Teddy Hartanto
>Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I've searched through Airflow's issues and couldn't find any report regarding 
> this. I wonder if I'm the only one who's facing this?
>  
> *Bug description*
> I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
> this exception:
> {code:java}
> AttributeError: ('Can only use .str accessor with string values, which use 
> np.object_ dtype in pandas', ...)
> {code}
>  
> This exception occurs here:
>  
> {code:java}
> if fmt == "csv":
> # there are also a ton of newline objects
> # that mess up our ability to write to csv
> # we remove these newlines so that the output is a valid CSV format
> self.log.info("Cleaning data and writing to CSV")
> possible_strings = df.columns[df.dtypes == "object"]
> df[possible_strings] = df[possible_strings].apply(
> lambda x: x.str.replace("\r\n", "")
> )
> df[possible_strings] = df[possible_strings].apply(
> lambda x: x.str.replace("\n", "")
> )
> # write the dataframe
> df.to_csv(filename, index=False)
> {code}
> **To fix it, we should just cast the object type to string as such:
>  
> {code:java}
> if fmt == "csv":
> ...
> df[possible_strings] = df[possible_strings].astype(str).apply(
> lambda x: x.str.replace("\r\n", "")
> )
> df[possible_strings] = df[possible_strings].astype(str).apply(
> lambda x: x.str.replace("\n", "")
> )
> {code}
> I've tested this and it works for me. Could somebody help me verify that the 
> type conversion is indeed needed? If yes, I'm keen to submit a PR to fix this 
> with the unit test included.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor

2020-01-05 Thread Teddy Hartanto (Jira)

Teddy Hartanto created AIRFLOW-6481:
---

 Summary: SalesforceHook attempts to use .str accessor 
 Key: AIRFLOW-6481
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6481
 Project: Apache Airflow
  Issue Type: Bug
  Components: hooks
Affects Versions: 1.10.7
Reporter: Teddy Hartanto


I've searched through Airflow's issues and couldn't find any report regarding 
this. I wonder if I'm the only one who's facing this?

 

*Bug description*

I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
this exception:
{code:java}
AttributeError: ('Can only use .str accessor with string values, which use 
np.object_ dtype in pandas', ...)
{code}
 

This exception occurs here:

 
{code:java}
if fmt == "csv":
# there are also a ton of newline objects
# that mess up our ability to write to csv
# we remove these newlines so that the output is a valid CSV format
self.log.info("Cleaning data and writing to CSV")
possible_strings = df.columns[df.dtypes == "object"]
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\n", "")
)

# write the dataframe
df.to_csv(filename, index=False)
{code}
**To fix it, we should just cast the object type to string as such:

 
{code:java}
if fmt == "csv":
...
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\n", "")
)
{code}
I've tested this and it works for me. Could somebody help me verify that the 
type conversion is indeed needed? If yes, I'm keen to submit a PR to fix this 
with the unit test included.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (AIRFLOW-6481) SalesforceHook attempts to use .str accessor on object dtype

2020-01-05 Thread Teddy Hartanto (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teddy Hartanto updated AIRFLOW-6481:

Description: 
I've searched through Airflow's issues and couldn't find any report regarding 
this. I wonder if I'm the only one who's facing this? 

 

*Bug description*

I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
this exception:
{code:java}
AttributeError: ('Can only use .str accessor with string values, which use 
np.object_ dtype in pandas', ...)
{code}
This exception occurs here:
{code:java}
if fmt == "csv":
# there are also a ton of newline objects
# that mess up our ability to write to csv
# we remove these newlines so that the output is a valid CSV format
self.log.info("Cleaning data and writing to CSV")
possible_strings = df.columns[df.dtypes == "object"]
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\n", "")
)

# write the dataframe
df.to_csv(filename, index=False)
{code}
To fix it, we should just cast the object type to string as such: 
{code:java}
if fmt == "csv":
...
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\n", "")
)
{code}
I've tested this and it works for me. Could somebody help me verify that the 
type conversion is indeed needed? If yes, I'm keen to submit a PR to fix this 
with the unit test included.

  was:
I've searched through Airflow's issues and couldn't find any report regarding 
this. I wonder if I'm the only one who's facing this?

 

*Bug description*

I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
this exception:
{code:java}
AttributeError: ('Can only use .str accessor with string values, which use 
np.object_ dtype in pandas', ...)
{code}
 

This exception occurs here:

 
{code:java}
if fmt == "csv":
# there are also a ton of newline objects
# that mess up our ability to write to csv
# we remove these newlines so that the output is a valid CSV format
self.log.info("Cleaning data and writing to CSV")
possible_strings = df.columns[df.dtypes == "object"]
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].apply(
lambda x: x.str.replace("\n", "")
)

# write the dataframe
df.to_csv(filename, index=False)
{code}
**To fix it, we should just cast the object type to string as such:

 
{code:java}
if fmt == "csv":
...
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\r\n", "")
)
df[possible_strings] = df[possible_strings].astype(str).apply(
lambda x: x.str.replace("\n", "")
)
{code}
I've tested this and it works for me. Could somebody help me verify that the 
type conversion is indeed needed? If yes, I'm keen to submit a PR to fix this 
with the unit test included.


> SalesforceHook attempts to use .str accessor on object dtype
> 
>
> Key: AIRFLOW-6481
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6481
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.7
>Reporter: Teddy Hartanto
>Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I've searched through Airflow's issues and couldn't find any report regarding 
> this. I wonder if I'm the only one who's facing this? 
>  
> *Bug description*
> I'm using the SalesforceHook to fetch data from SalesForce and I encountered 
> this exception:
> {code:java}
> AttributeError: ('Can only use .str accessor with string values, which use 
> np.object_ dtype in pandas', ...)
> {code}
> This exception occurs here:
> {code:java}
> if fmt == "csv":
> # there are also a ton of newline objects
> # that mess up our ability to write to csv
> # we remove these newlines so that the output is a valid CSV format
> self.log.info("Cleaning data and writing to CSV")
> possible_strings = df.columns[df.dtypes == "object"]
> df[possible_strings] = df[possible_strings].apply(
> lambda x: x.str.replace("\r\n", "")
> )
> df[possible_strings] = df[possible_strings].apply(
> lambda x: x.str.replace("\n", "")
> )
> # write the dataframe
> df.to_csv(filename, index=False)
> {code}
> To fix it, we should just cast the object type to string as such: 
> {code:java}
> if fmt == "csv":
> ...
> df[possible_strings] = df[possible_strings].astype(str).apply(
>

[GitHub] [airflow] yuqian90 commented on a change in pull request #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

yuqian90 commented on a change in pull request #7038: [AIRFLOW-4495] allow 
externally triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#discussion_r363145270
 
 

 ##
 File path: airflow/models/dag.py
 ##
 @@ -778,16 +778,26 @@ def set_dependency(self, upstream_task_id, 
downstream_task_id):
 def get_task_instances(
 self, start_date=None, end_date=None, state=None, session=None):
 if not start_date:
+# TODO why 30?
 start_date = (timezone.utcnow() - timedelta(30)).date()
 start_date = timezone.make_aware(
 datetime.combine(start_date, datetime.min.time()))
-end_date = end_date or timezone.utcnow()
-tis = session.query(TaskInstance).filter(
-TaskInstance.dag_id == self.dag_id,
-TaskInstance.execution_date >= start_date,
-TaskInstance.execution_date <= end_date,
-TaskInstance.task_id.in_([t.task_id for t in self.tasks]),
-)
+
 
 Review comment:
   Okay this does look necessary. And it's easy to fix. How about adding this 
property to `class DAG`?
   
   ```python
   class DAG:
   ...
   @property
   def allow_future_exec_dates(self):
   return conf.getboolean('scheduler', 'RUN_FUTURE_EXEC_DATES', 
fallback=False) and self.schedule_interval is None
   ```
   
   
   This line can become:
   ```python
   filters = [TaskInstance.dag_id == self.dag_id,
  TaskInstance.execution_date >= start_date,
  TaskInstance.task_id.in_([t.task_id for t in self.tasks])]
   
   if end_date or not self.allow_future_exec_dates:
   end_date = end_date or timezone.utcnow()
   filters.append(TaskInstance.execution_date <= end_date)
   
   tis = session.query(TaskInstance).filter(*filters)
   ```
   
   And you may want to use `dag.allow_future_exec_dates` in the two other 
places that you checked the same conditions too, i.e. scheduler_job.py and 
runnable_exec_date_dep.py


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yuqian90 commented on issue #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

yuqian90 commented on issue #7038: [AIRFLOW-4495] allow externally triggered 
dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#issuecomment-570979008
 
 
   > I don't think we should allow this. This will create a problem for the 
following case:
   > 
   > DAG is scheduled to run every day at 5 PM
   > 
   > 1. Dag is triggered for a future date (ex: 10 Jan 2020 17:00:00) and 
succeeds
   > 2. 10 Jan arrives, Scheduler tries to run it but fails because it violates 
unique key constraint
   
   Hi, @kaxil. Thanks for pointing out. I agree with @tooptoop4 that his change 
is only meant for DAGs with `schedule_interval` equal to None, i.e. those that 
are triggered externally using the CLI or other means. The ones scheduled by 
Airflow should not be affected.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (AIRFLOW-6472) Some of the options we have are long options with single -

2020-01-05 Thread zhongjiajie (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

zhongjiajie reassigned AIRFLOW-6472:


Assignee: zhongjiajie

> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd 
> in the run task. This is against the idea of short and long options in Unix 
> (and argparse follows that). The main reason to have short options is that 
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly 
> ambiguous. We do not have -s yet but if we add few more options this might 
> become a problem.
> Also in the argparse documentation 
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short 
> options should be single character only.\
> This should be fixed.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] yuqian90 commented on a change in pull request #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

yuqian90 commented on a change in pull request #7038: [AIRFLOW-4495] allow 
externally triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#discussion_r363138205
 
 

 ##
 File path: airflow/models/dag.py
 ##
 @@ -778,16 +778,26 @@ def set_dependency(self, upstream_task_id, 
downstream_task_id):
 def get_task_instances(
 self, start_date=None, end_date=None, state=None, session=None):
 if not start_date:
+# TODO why 30?
 start_date = (timezone.utcnow() - timedelta(30)).date()
 start_date = timezone.make_aware(
 datetime.combine(start_date, datetime.min.time()))
-end_date = end_date or timezone.utcnow()
-tis = session.query(TaskInstance).filter(
-TaskInstance.dag_id == self.dag_id,
-TaskInstance.execution_date >= start_date,
-TaskInstance.execution_date <= end_date,
-TaskInstance.task_id.in_([t.task_id for t in self.tasks]),
-)
+
 
 Review comment:
   This change to `get_task_instances()` seems to be newly included from the 
previously closed PR? This is going to change the TI returned to include those 
considered in the "future".  Why is this change necessary?
   
   If it is indeed needed, you should probably consider doing the same as what 
you did in `scheduler_job.py`, i.e. only include "future" tasks if 
`RUN_FUTURE_EXEC_DATES` is True **and** `dag.schedule_interval` is None 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id

2020-01-05 Thread GitBox

zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort default connection by 
conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570977908
 
 
   Thanks Jarek and Kaxil for review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

kaxil edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if 
kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570976842
 
 
   I would say let's not do it, I don't see much benefits of it.
   
   The CLI command should be static and it might cause issues when building 
docs too and might cause issue for the CLI Autocomplete too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

kaxil commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if 
kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570976842
 
 
   I would say let's not do it, I don't see much benefits of it.
   
   The CLI command should be static and it might cause issues when building 
docs too .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr=desc)
 will **increase** coverage by `74.64%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7070   +/-   ##
   ===
   + Coverage   10.08%   84.72%   +74.64% 
   ===
 Files 679  680+1 
 Lines   3873538750   +15 
   ===
   + Hits 390632831+28925 
   + Misses  34829 5919-28910
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (+93.02%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==)
 | `84.61% <0%> (ø)` | |
   | 
[airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5)
 | `100% <0%> (+3.57%)` | :arrow_up: |
   | 
[airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=)
 | `90.38% <0%> (+3.84%)` | :arrow_up: |
   | 
[airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==)
 | `5.88% <0%> (+5.88%)` | :arrow_up: |
   | ... and [605 
more](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[f4c7d17...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7070: [AIRFLOW-6480] Hide kerberos 
command if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

codecov-io commented on issue #7070: [AIRFLOW-6480] Hide kerberos command if 
kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070#issuecomment-570974777
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=h1) 
Report
   > Merging 
[#7070](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2af066b6f33c0c65c073bcc638fe64e4c509b432?src=pr=desc)
 will **decrease** coverage by `0.25%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7070/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7070  +/-   ##
   ==
   - Coverage   84.97%   84.72%   -0.26% 
   ==
 Files 679  680   +1 
 Lines   3866438750  +86 
   ==
   - Hits3285632831  -25 
   - Misses   5808 5919 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `93.02% <50%> (-1.03%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_complex.py](https://codecov.io/gh/apache/airflow/pull/7070/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jb21wbGV4LnB5)
 | `100% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=footer). 
Last update 
[2af066b...e45430b](https://codecov.io/gh/apache/airflow/pull/7070?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6480) Hide kerberos command if kerberos is disabled

2020-01-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008469#comment-17008469
 ] 

ASF GitHub Bot commented on AIRFLOW-6480:
-

mik-laj commented on pull request #7070: [AIRFLOW-6480] Hide kerberos command 
if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070
 
 
   Similar to: https://github.com/apache/airflow/pull/6877
   
   Most users do not use Kerberos, so this command will not work.
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6480
   
   - [X] Description above provides context of the change
   - [X] Commit message starts with `[AIRFLOW-]`, where AIRFLOW- = JIRA 
ID*
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message 
starts `[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide kerberos command if kerberos is disabled
> -
>
> Key: AIRFLOW-6480
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6480
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.7
>Reporter: Kamil Bregula
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj opened a new pull request #7070: [AIRFLOW-6480] Hide kerberos command if kerberos is disabled

2020-01-05 Thread GitBox

mik-laj opened a new pull request #7070: [AIRFLOW-6480] Hide kerberos command 
if kerberos is disabled
URL: https://github.com/apache/airflow/pull/7070
 
 
   Similar to: https://github.com/apache/airflow/pull/6877
   
   Most users do not use Kerberos, so this command will not work.
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6480
   
   - [X] Description above provides context of the change
   - [X] Commit message starts with `[AIRFLOW-]`, where AIRFLOW- = JIRA 
ID*
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message 
starts `[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-6480) Hide kerberos command if kerberos is disabled

2020-01-05 Thread Kamil Bregula (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil Bregula updated AIRFLOW-6480:
---
Summary: Hide kerberos command if kerberos is disabled  (was: Hide kerberos 
command if kerberos is disableld)

> Hide kerberos command if kerberos is disabled
> -
>
> Key: AIRFLOW-6480
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6480
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.7
>Reporter: Kamil Bregula
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-6480) Hide kerberos command if kerberos is disableld

2020-01-05 Thread Kamil Bregula (Jira)

Kamil Bregula created AIRFLOW-6480:
--

 Summary: Hide kerberos command if kerberos is disableld
 Key: AIRFLOW-6480
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6480
 Project: Apache Airflow
  Issue Type: Improvement
  Components: core
Affects Versions: 1.10.7
Reporter: Kamil Bregula






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj closed pull request #7069: Remove dprecated conf method

2020-01-05 Thread GitBox

mik-laj closed pull request #7069: Remove dprecated conf method
URL: https://github.com/apache/airflow/pull/7069
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #7069: Remove dprecated conf method

2020-01-05 Thread GitBox

mik-laj opened a new pull request #7069: Remove dprecated conf method
URL: https://github.com/apache/airflow/pull/7069
 
 
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-
   
   - [ ] Description above provides context of the change
   - [ ] Commit message starts with `[AIRFLOW-]`, where AIRFLOW- = JIRA 
ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message 
starts `[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-05 Thread GitBox

mik-laj commented on a change in pull request #6993: [AIRFLOW-4502] new cli 
command - task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#discussion_r363127597
 
 

 ##
 File path: tests/cli/commands/test_task_command.py
 ##
 @@ -184,6 +184,10 @@ def test_task_state(self):
 'tasks', 'state', 'example_bash_operator', 'runme_0',
 DEFAULT_DATE.isoformat()]))
 
+def test_task_states_for_dag_run(self):
+task_command.task_states_for_dag_run(self.parser.parse_args([
 
 Review comment:
   Can you add some assertions?  I see that other tests do not have, but we are 
trying to improve the CLI now and I have already [made many 
changes](https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Aarea%3ACLI+is%3Aclosed+author%3Amik-laj)
 that do it.
   Here is sample of assertions in tests: 
https://github.com/apache/airflow/blob/master/tests/cli/commands/test_config_command.py#L38


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-05 Thread GitBox

mik-laj commented on a change in pull request #6993: [AIRFLOW-4502] new cli 
command - task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#discussion_r363127597
 
 

 ##
 File path: tests/cli/commands/test_task_command.py
 ##
 @@ -184,6 +184,10 @@ def test_task_state(self):
 'tasks', 'state', 'example_bash_operator', 'runme_0',
 DEFAULT_DATE.isoformat()]))
 
+def test_task_states_for_dag_run(self):
+task_command.task_states_for_dag_run(self.parser.parse_args([
 
 Review comment:
   Can you add some assertions?  I see that other tests do not have, but now we 
are trying to improve the CLI and I have already [made many 
changes](https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Aarea%3ACLI+is%3Aclosed+author%3Amik-laj)
 that do it.
   Here is sample of assertions in tests: 
https://github.com/apache/airflow/blob/master/tests/cli/commands/test_config_command.py#L38


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.73%   84.67%   -0.07% 
   ==
 Files 679  679  
 Lines   3859338593  
   ==
   - Hits3270232677  -25 
   - Misses   5891 5916  +25
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `83.33% <0%> (-1.29%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.73% <0%> (+0.82%)` | :arrow_up: |
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `68.78% <0%> (+0.97%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6999: [AIRFLOW-] Clarify 
wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=h1) 
Report
   > Merging 
[#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6999/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6999  +/-   ##
   ==
   - Coverage   84.81%   84.67%   -0.15% 
   ==
 Files 679  679  
 Lines   3849538593  +98 
   ==
   + Hits3264932677  +28 
   - Misses   5846 5916  +70
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `96.25% <ø> (+0.17%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5)
 | `81.69% <0%> (-1.06%)` | :arrow_down: |
   | 
[airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5)
 | `93.39% <0%> (-0.78%)` | :arrow_down: |
   | 
[airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==)
 | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | ... and [38 
more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=footer). 
Last update 
[4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6479) Update celery command calls

2020-01-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008454#comment-17008454
 ] 

ASF GitHub Bot commented on AIRFLOW-6479:
-

mik-laj commented on pull request #7068: [AIRFLOW-6479] Update celery command 
calls
URL: https://github.com/apache/airflow/pull/7068
 
 
   Follow up after merging: https://github.com/apache/airflow/pull/6877/files
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6479
   
   - [X] Description above provides context of the change
   - [X] Commit message starts with `[AIRFLOW-]`, where AIRFLOW- = JIRA 
ID*
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message 
starts `[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update celery command calls
> ---
>
> Key: AIRFLOW-6479
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6479
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core, documentation
>Affects Versions: 1.10.7
>Reporter: Kamil Bregula
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj opened a new pull request #7068: [AIRFLOW-6479] Update celery command calls

2020-01-05 Thread GitBox

mik-laj opened a new pull request #7068: [AIRFLOW-6479] Update celery command 
calls
URL: https://github.com/apache/airflow/pull/7068
 
 
   Follow up after merging: https://github.com/apache/airflow/pull/6877/files
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6479
   
   - [X] Description above provides context of the change
   - [X] Commit message starts with `[AIRFLOW-]`, where AIRFLOW- = JIRA 
ID*
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message 
starts `[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7038: [AIRFLOW-4495] allow externally 
triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#issuecomment-570935774
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@93324ff`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `79.16%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7038/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#7038   +/-   ##
   =
 Coverage  ?   84.69%   
   =
 Files ?  679   
 Lines ?38669   
 Branches  ?0   
   =
 Hits  ?32749   
 Misses? 5920   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.51% <60%> (ø)` | |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `88.71% <64.28%> (ø)` | |
   | 
[airflow/models/dagrun.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFncnVuLnB5)
 | `96.15% <75%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=footer). 
Last update 
[93324ff...71e63b2](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6479) Update celery command calls

2020-01-05 Thread Kamil Bregula (Jira)

Kamil Bregula created AIRFLOW-6479:
--

 Summary: Update celery command calls
 Key: AIRFLOW-6479
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6479
 Project: Apache Airflow
  Issue Type: Improvement
  Components: core, documentation
Affects Versions: 1.10.7
Reporter: Kamil Bregula






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] codecov-io edited a comment on issue #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #7038: [AIRFLOW-4495] allow externally 
triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#issuecomment-570935774
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=h1) 
Report
   > Merging 
[#7038](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fbb855c907fa5f5c34c97c45d29d502355756bd3?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `60%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7038/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7038  +/-   ##
   ==
   - Coverage   84.97%   84.69%   -0.29% 
   ==
 Files 679  679  
 Lines   3866438669   +5 
   ==
   - Hits3285532749 -106 
   - Misses   5809 5920 +111
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `88.71% <0%> (-0.13%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/runnable\_exec\_date\_dep.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcnVubmFibGVfZXhlY19kYXRlX2RlcC5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.51% <75%> (-0.12%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7038/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.88% <0%> (+0.28%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=footer). 
Last update 
[fbb855c...71e63b2](https://codecov.io/gh/apache/airflow/pull/7038?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-6467) Remove unnecessary local variable

2020-01-05 Thread Kamil Bregula (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil Bregula updated AIRFLOW-6467:
---
Fix Version/s: (was: 2.0.0)
   1.10.8

> Remove unnecessary local variable
> -
>
> Key: AIRFLOW-6467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6467
> Project: Apache Airflow
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Mustafa Gök
>Assignee: Mustafa Gök
>Priority: Trivial
> Fix For: 1.10.8
>
>
> In test_templated_sensor (tests/sensors/test_external_task_sensor.py) unit 
> test method, self.dag can be used instead of creating a local variable named 
> "dag" (line 98).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (AIRFLOW-6467) Remove unnecessary local variable

2020-01-05 Thread Kamil Bregula (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil Bregula resolved AIRFLOW-6467.

Fix Version/s: 2.0.0
   Resolution: Fixed

> Remove unnecessary local variable
> -
>
> Key: AIRFLOW-6467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6467
> Project: Apache Airflow
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Mustafa Gök
>Assignee: Mustafa Gök
>Priority: Trivial
> Fix For: 2.0.0
>
>
> In test_templated_sensor (tests/sensors/test_external_task_sensor.py) unit 
> test method, self.dag can be used instead of creating a local variable named 
> "dag" (line 98).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6467) Remove unnecessary local variable

2020-01-05 Thread ASF subversion and git services (Jira)



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008451#comment-17008451
 ] 

ASF subversion and git services commented on AIRFLOW-6467:
--

Commit f4c7d17902c87bff50bbd8c94028a539e4e1c3a3 in airflow's branch 
refs/heads/master from Mustafa Gök
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=f4c7d17 ]

[AIRFLOW-6467] Use self.dag i/o creating a new one (#7067)



> Remove unnecessary local variable
> -
>
> Key: AIRFLOW-6467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6467
> Project: Apache Airflow
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Mustafa Gök
>Assignee: Mustafa Gök
>Priority: Trivial
>
> In test_templated_sensor (tests/sensors/test_external_task_sensor.py) unit 
> test method, self.dag can be used instead of creating a local variable named 
> "dag" (line 98).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6467) Remove unnecessary local variable

2020-01-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008450#comment-17008450
 ] 

ASF GitHub Bot commented on AIRFLOW-6467:
-

mik-laj commented on pull request #7067: [AIRFLOW-6467] Use self.dag i/o 
creating a new one
URL: https://github.com/apache/airflow/pull/7067
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove unnecessary local variable
> -
>
> Key: AIRFLOW-6467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6467
> Project: Apache Airflow
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Mustafa Gök
>Assignee: Mustafa Gök
>Priority: Trivial
>
> In test_templated_sensor (tests/sensors/test_external_task_sensor.py) unit 
> test method, self.dag can be used instead of creating a local variable named 
> "dag" (line 98).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj merged pull request #7067: [AIRFLOW-6467] Use self.dag i/o creating a new one

2020-01-05 Thread GitBox

mik-laj merged pull request #7067: [AIRFLOW-6467] Use self.dag i/o creating a 
new one
URL: https://github.com/apache/airflow/pull/7067
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@066d889`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `80.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6604   +/-   ##
   =
 Coverage  ?   84.76%   
   =
 Files ?  681   
 Lines ?38615   
 Branches  ?0   
   =
 Hits  ?32732   
 Misses? 5883   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/utils/state.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zdGF0ZS5weQ==)
 | `96.29% <ø> (ø)` | |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.95% <ø> (ø)` | |
   | 
[airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5)
 | `100% <ø> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <ø> (ø)` | |
   | 
[airflow/utils/operator\_resources.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9vcGVyYXRvcl9yZXNvdXJjZXMucHk=)
 | `84.78% <ø> (ø)` | |
   | 
[airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==)
 | `0% <0%> (ø)` | |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `42.46% <0%> (ø)` | |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | ... and [19 
more](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[066d889...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@066d889`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `80.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6604   +/-   ##
   =
 Coverage  ?   84.76%   
   =
 Files ?  681   
 Lines ?38615   
 Branches  ?0   
   =
 Hits  ?32732   
 Misses? 5883   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/utils/state.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zdGF0ZS5weQ==)
 | `96.29% <ø> (ø)` | |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.95% <ø> (ø)` | |
   | 
[airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5)
 | `100% <ø> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <ø> (ø)` | |
   | 
[airflow/utils/operator\_resources.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9vcGVyYXRvcl9yZXNvdXJjZXMucHk=)
 | `84.78% <ø> (ø)` | |
   | 
[airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==)
 | `0% <0%> (ø)` | |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `42.46% <0%> (ø)` | |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | ... and [19 
more](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[066d889...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@066d889`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `80.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6604   +/-   ##
   =
 Coverage  ?   84.76%   
   =
 Files ?  681   
 Lines ?38615   
 Branches  ?0   
   =
 Hits  ?32732   
 Misses? 5883   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/utils/state.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zdGF0ZS5weQ==)
 | `96.29% <ø> (ø)` | |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.95% <ø> (ø)` | |
   | 
[airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5)
 | `100% <ø> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <ø> (ø)` | |
   | 
[airflow/utils/operator\_resources.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9vcGVyYXRvcl9yZXNvdXJjZXMucHk=)
 | `84.78% <ø> (ø)` | |
   | 
[airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==)
 | `0% <0%> (ø)` | |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `42.46% <0%> (ø)` | |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | ... and [19 
more](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[066d889...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@066d889`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `80.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6604   +/-   ##
   =
 Coverage  ?   84.76%   
   =
 Files ?  681   
 Lines ?38615   
 Branches  ?0   
   =
 Hits  ?32732   
 Misses? 5883   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/utils/state.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zdGF0ZS5weQ==)
 | `96.29% <ø> (ø)` | |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `90.95% <ø> (ø)` | |
   | 
[airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5)
 | `100% <ø> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <ø> (ø)` | |
   | 
[airflow/utils/operator\_resources.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9vcGVyYXRvcl9yZXNvdXJjZXMucHk=)
 | `84.78% <ø> (ø)` | |
   | 
[airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==)
 | `0% <0%> (ø)` | |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `42.46% <0%> (ø)` | |
   | 
[airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==)
 | `85.33% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | ... and [19 
more](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[066d889...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and hook

2020-01-05 Thread GitBox

codecov-io edited a comment on issue #6604: [AIRFLOW-5920] Neo4j operator and 
hook
URL: https://github.com/apache/airflow/pull/6604#issuecomment-558902885
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=h1) 
Report
   > Merging 
[#6604](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr=desc)
 will **decrease** coverage by `0.26%`.
   > The diff coverage is `95.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6604/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6604  +/-   ##
   ==
   - Coverage   85.03%   84.76%   -0.27% 
   ==
 Files 679  681   +2 
 Lines   3854538615  +70 
   ==
   - Hits3277532732  -43 
   - Misses   5770 5883 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/neo4j/hook.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovaG9vay5weQ==)
 | `100% <100%> (ø)` | |
   | 
[airflow/providers/neo4j/operators/neo4j.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbmVvNGovb3BlcmF0b3JzL25lbzRqLnB5)
 | `89.65% <89.65%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6604/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=footer). 
Last update 
[f391039...2a31a35](https://codecov.io/gh/apache/airflow/pull/6604?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6478) new cli command to set taskinstance state

2020-01-05 Thread t oo (Jira)

t oo created AIRFLOW-6478:
-

 Summary: new cli command to set taskinstance state
 Key: AIRFLOW-6478
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6478
 Project: Apache Airflow
  Issue Type: New Feature
  Components: cli
Affects Versions: 1.10.7
Reporter: t oo


UI already allows setting taskinstance states to:
failed, running, success, up_for_retry

this is about giving the cli the same functionality




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

1 2 3 4 >

1 - 100 of 378 matches

Mail list logo