date:20200108

boring-cyborg[bot] commented on issue #7102: [AIRFLOW-6510] - Fix Druid
operator rendering from file
URL: https://github.com/apache/airflow/pull/7102#issuecomment-572111740

Congratulations on your first Pull Request and welcome to the Apache Airflow
community!
If you have any issues or are unsure about any anything please check our
Contribution Guide
(https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type
annotations). Our [pre-commits](

https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.
- In case of a new feature add useful documentation (in docstrings or in
`docs/` directory).
Adding a new operator? Consider adding an example DAG that shows how users
should use it.
- Consider using [Breeze
environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for
testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot
of integrations.
- Be patient and persistent. It might take some time to get a review or get
the final approval from
Committers.

Apache Airflow is a community-driven project and together we are making it
better .

In case of doubts contact the developers at:
Mailing List: d...@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] [airflow] alexnu opened a new pull request #7102: [AIRFLOW-6510] - Fix Druid operator rendering from file

alexnu opened a new pull request #7102: [AIRFLOW-6510] - Fix Druid operator 
rendering from file
URL: https://github.com/apache/airflow/pull/7102
 
 
   Dear maintainers,
   
   Please accept my PR which fixes the way druid specification json is loaded 
by leveraging template fields as in most other operators, rather that manually 
parsing the file in the operator.
   
   I am also working on providing a valid unit test.
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Reopened] (AIRFLOW-5264) Fix all linting errors in .js files



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk reopened AIRFLOW-5264:
---

> Fix all linting errors in .js files
> ---
>
> Key: AIRFLOW-5264
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5264
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: webserver
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (AIRFLOW-5264) Fix all linting errors in .js files



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-5264.
---
Resolution: Later

> Fix all linting errors in .js files
> ---
>
> Key: AIRFLOW-5264
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5264
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: webserver
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-5264) Fix all linting errors in .js files



[ 
https://issues.apache.org/jira/browse/AIRFLOW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010753#comment-17010753
 ] 

ASF GitHub Bot commented on AIRFLOW-5264:
-

potiuk commented on pull request #5871:  [AIRFLOW-5264] Eslint + npmaudit
URL: https://github.com/apache/airflow/pull/5871
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix all linting errors in .js files
> ---
>
> Key: AIRFLOW-5264
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5264
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: webserver
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (AIRFLOW-5264) Fix all linting errors in .js files



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk closed AIRFLOW-5264.
-
Resolution: Fixed

> Fix all linting errors in .js files
> ---
>
> Key: AIRFLOW-5264
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5264
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: webserver
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] potiuk commented on issue #5871: [AIRFLOW-5264] Eslint + npmaudit

potiuk commented on issue #5871:  [AIRFLOW-5264] Eslint + npmaudit
URL: https://github.com/apache/airflow/pull/5871#issuecomment-572109336
 
 
   Fine. Closing it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk closed pull request #5871: [AIRFLOW-5264] Eslint + npmaudit

potiuk closed pull request #5871:  [AIRFLOW-5264] Eslint + npmaudit
URL: https://github.com/apache/airflow/pull/5871
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7101: [AIRFLOW-6509] Description for how to create an user is incorrect in some docs.

mik-laj merged pull request #7101: [AIRFLOW-6509] Description for how to create 
an user is incorrect in some docs.
URL: https://github.com/apache/airflow/pull/7101
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6509) Description for how to create an user is incorrect in some docs.



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010745#comment-17010745
 ] 

ASF GitHub Bot commented on AIRFLOW-6509:
-

mik-laj commented on pull request #7101: [AIRFLOW-6509] Description for how to 
create an user is incorrect in some docs.
URL: https://github.com/apache/airflow/pull/7101
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Description for how to create an user is incorrect in some docs.
> 
>
> Key: AIRFLOW-6509
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6509
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 1.10.8
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Major
>
> In start.rst and security.rst, description for how to create user is wrong.
> We can't do like
> {code}
> airflow users -c ...
> {code}
> Instead, we should do like
> {code}
> airflow users create ...
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj edited a comment on issue #5871: [AIRFLOW-5264] Eslint + npmaudit

mik-laj edited a comment on issue #5871:  [AIRFLOW-5264] Eslint + npmaudit
URL: https://github.com/apache/airflow/pull/5871#issuecomment-572092497
 
 
   @potiuk I think that we should introduce order in the current code first, 
and then we can introduce eslint.  We have too much JS code mixed with Jinja, 
which means that eslint does not work properly. I have already done experiments 
in this area in the past and were not satisfactory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6511) BATS Test Docker container is not removed after done

Jarek Potiuk created AIRFLOW-6511:
-

 Summary: BATS Test Docker container is not removed after done
 Key: AIRFLOW-6511
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6511
 Project: Apache Airflow
  Issue Type: Improvement
  Components: breeze, ci
Affects Versions: 2.0.0
Reporter: Jarek Potiuk


The BATS test docker container remains in docker cache and requires `docker 
system prune` to get removed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj edited a comment on issue #5871: [AIRFLOW-5264] Eslint + npmaudit

mik-laj edited a comment on issue #5871:  [AIRFLOW-5264] Eslint + npmaudit
URL: https://github.com/apache/airflow/pull/5871#issuecomment-572092497
 
 
   @potiuk I think that we should sort the current code first, and then we can 
introduce eslint.  We have too much JS code mixed with Jinja, which means that 
eslint does not work properly. I have already done experiments in this area in 
the past and were not satisfactory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6504) KubernetesExecutor: Allow specifying configmap for Airflow Local Setting



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010721#comment-17010721
 ] 

ASF GitHub Bot commented on AIRFLOW-6504:
-

kaxil commented on pull request #7097: [AIRFLOW-6504] Allow specifying 
configmap for Airflow Local Setting
URL: https://github.com/apache/airflow/pull/7097
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> KubernetesExecutor: Allow specifying configmap for Airflow Local Setting
> 
>
> Key: AIRFLOW-6504
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6504
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.7
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> Currently airflow.cfg file can be passed via ConfigMap to `airflow_configmap` 
> setting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj commented on issue #5871: [AIRFLOW-5264] Eslint + npmaudit

2020-01-08 Thread ASF subversion and git services (Jira)

mik-laj commented on issue #5871:  [AIRFLOW-5264] Eslint + npmaudit
URL: https://github.com/apache/airflow/pull/5871#issuecomment-572092497
 
 
   @potiuk I think that we should sort the current code first, and then we can 
introduce eslint.  We have too much JS code mixed with Jinja, which means that 
eslint does not work properly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (AIRFLOW-6504) KubernetesExecutor: Allow specifying configmap for Airflow Local Setting

2020-01-08 Thread Kaxil Naik (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik resolved AIRFLOW-6504.
-
Resolution: Fixed

> KubernetesExecutor: Allow specifying configmap for Airflow Local Setting
> 
>
> Key: AIRFLOW-6504
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6504
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.7
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> Currently airflow.cfg file can be passed via ConfigMap to `airflow_configmap` 
> setting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6504) KubernetesExecutor: Allow specifying configmap for Airflow Local Setting



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010723#comment-17010723
 ] 

ASF subversion and git services commented on AIRFLOW-6504:
--

Commit 4748a518ced4ebd30caec2ac290c782ef023b0d7 in airflow's branch 
refs/heads/master from Kaxil Naik
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4748a51 ]

[AIRFLOW-6504] Allow specifying configmap for Airflow Local Setting (#7097)



> KubernetesExecutor: Allow specifying configmap for Airflow Local Setting
> 
>
> Key: AIRFLOW-6504
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6504
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.7
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> Currently airflow.cfg file can be passed via ConfigMap to `airflow_configmap` 
> setting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] kaxil merged pull request #7097: [AIRFLOW-6504] Allow specifying configmap for Airflow Local Setting

kaxil merged pull request #7097: [AIRFLOW-6504] Allow specifying configmap for 
Airflow Local Setting
URL: https://github.com/apache/airflow/pull/7097
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6824: [AIRFLOW-6258] add CloudFormation operators to AWS providers

nuclearpinguin commented on a change in pull request #6824: [AIRFLOW-6258] add 
CloudFormation operators to AWS providers
URL: https://github.com/apache/airflow/pull/6824#discussion_r364262295
 
 

 ##
 File path: airflow/providers/amazon/aws/operators/cloud_formation.py
 ##
 @@ -0,0 +1,115 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+This module contains CloudFormation create/delete stack operators.
+"""
+from typing import List
+
+from airflow.models import BaseOperator
+from airflow.providers.amazon.aws.hooks.cloud_formation import 
AWSCloudFormationHook
+from airflow.utils.decorators import apply_defaults
+
+
+class BaseCloudFormationOperator(BaseOperator):
+"""
+Base operator for CloudFormation operations.
+
+:param params: parameters to be passed to CloudFormation.
+:type params: dict
+:param aws_conn_id: aws connection to uses
+:type aws_conn_id: str
+"""
+template_fields: List[str] = []
+template_ext = ()
+ui_color = '#1d472b'
+ui_fgcolor = '#FFF'
+
+@apply_defaults
+def __init__(
+self,
+params,
+aws_conn_id='aws_default',
+*args, **kwargs):
+super().__init__(*args, **kwargs)
+self.params = params
+self.aws_conn_id = aws_conn_id
+
+def execute(self, context):
+self.log.info('Parameters: %s', self.params)
+
+
self.cloudformation_op(AWSCloudFormationHook(aws_conn_id=self.aws_conn_id).get_conn())
+
+def cloudformation_op(self, cloudformation):
+"""
+This is the main method to run CloudFormation operation.
+"""
+raise NotImplementedError()
 
 Review comment:
   Would you mind refactor the operators the same way you did with sensors?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6510) DruidOperator templating not working as expected

2020-01-08 Thread Alexandros Nafas (Jira)

Alexandros Nafas created AIRFLOW-6510:
-

 Summary: DruidOperator templating not working as expected
 Key: AIRFLOW-6510
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6510
 Project: Apache Airflow
  Issue Type: Bug
  Components: contrib, operators
Affects Versions: 1.10.0
Reporter: Alexandros Nafas


When trying to load the druid specification from a file, I get the following 
error:
{code:java}
Broken DAG: [/etc/airflow/dags/central/central_hourly.py] [Errno 2] No such 
file or directory: 'central_hourly_spec.json'
{code}
even though file central_hourly_spec.json exists in the same folder as the DAG.

This is the task definition:
{code:java}
druid = DruidOperator(
task_id='central_druid',
json_index_file='central_hourly_spec.json',
druid_ingest_conn_id='druid_ingest',
dag=dag
)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364240075
 
 

 ##
 File path: tests/jobs/test_scheduler_job.py
 ##
 @@ -2034,7 +2034,7 @@ def test_dagrun_root_fail_unfinished(self):
 ti = dr.get_task_instance('test_dagrun_unfinished', 
session=session)
 ti.state = State.NONE
 session.commit()
-dr_state = dr.update_state()
+dr_state = dr.state
 
 Review comment:
   This looks suspect -- I would expect it to be
   ```suggestion
   dr.update_state()
   dr_state = dr.state
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364240875
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -346,7 +331,38 @@ def update_state(self, session=None):
 session.merge(self)
 session.commit()
 
-return self.state
+return ready_tis
+
+@provide_session
+def get_ready_tis(self, session, scheduleable_tasks, finished_tasks):
+ready_tis = []
+for st in scheduleable_tasks:
+if st.are_dependencies_met(
+dep_context=DepContext(
+flag_upstream_failed=True,
+finished_tasks=finished_tasks),
+session=session):
+ready_tis.append(st)
+return ready_tis
+
+@provide_session
+def are_runnable_tis(self, session, unfinished_tasks, finished_tasks):
+# this is an optimization to avoid running on tasks that are not ready 
twice
+not_ready_tis = []
+# there might be runnable tasks that are up for retry and from some 
reason(retry delay, etc) are
+# not ready yet so we set the flags to count them in
+for ut in unfinished_tasks:
+if ut.are_dependencies_met(
+dep_context=DepContext(
+flag_upstream_failed=True,
+ignore_in_retry_period=True,
+ignore_in_reschedule_period=True,
+finished_tasks=finished_tasks),
+session=session):
+return False, not_ready_tis
 
 Review comment:
   Do you think you'd be able to add a test to cover this case (that a single 
call to `dr.update_state` updates the state for all these TIs?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364239552
 
 

 ##
 File path: airflow/ti_deps/deps/trigger_rule_dep.py
 ##
 @@ -34,11 +34,30 @@ class TriggerRuleDep(BaseTIDep):
 IGNOREABLE = True
 IS_TASK_DEP = True
 
+@staticmethod
+@provide_session
+def _get_states_count_upstream_ti(ti, finished_tasks, session):
+"""
+This function returns the states of the upstream tis for a specific ti 
in order to determine
+whether this ti can run in this iteration
+
+:param ti: the ti that we want to calculate deps for
+:type ti: airflow.models.TaskInstance
+:param finished_tasks: all the finished tasks of the dag_run
+:type finished_tasks: list[airflow.models.TaskInstance]
+"""
+if not finished_tasks:
+# this is for the strange feature of running tasks without dag_run
+finished_tasks = [t for t in 
ti.task.dag.get_task_instances(start_date=ti.execution_date,
+
end_date=ti.execution_date)
 
 Review comment:
   And we should pass the same `session` down to 
`ti.task.dag.get_task_instances)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364240472
 
 

 ##
 File path: tests/models/test_dagrun.py
 ##
 @@ -229,7 +229,7 @@ def test_dagrun_deadlock(self):
start_date=now)
 
 ti_op1 = dr.get_task_instance(task_id=op1.task_id)
-ti_op1.set_state(state=State.SUCCESS, session=session)
+ti_op1.set_state(state=State.FAILED, session=session)
 
 Review comment:
   Why did you need to change this test? It doesn't look like it should need 
any changes


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364226856
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -263,48 +262,34 @@ def update_state(self, session=None):
 Determines the overall state of the DagRun based on the state
 of its TaskInstances.
 
+:param finished_tasks: The finished tasks of this run
 
 Review comment:
   This is not a param -- I think you meant `:return:` and `:rtype:`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364239180
 
 

 ##
 File path: airflow/ti_deps/deps/trigger_rule_dep.py
 ##
 @@ -34,11 +34,30 @@ class TriggerRuleDep(BaseTIDep):
 IGNOREABLE = True
 IS_TASK_DEP = True
 
+@staticmethod
+@provide_session
+def _get_states_count_upstream_ti(ti, finished_tasks, session):
+"""
+This function returns the states of the upstream tis for a specific ti 
in order to determine
+whether this ti can run in this iteration
+
+:param ti: the ti that we want to calculate deps for
+:type ti: airflow.models.TaskInstance
+:param finished_tasks: all the finished tasks of the dag_run
+:type finished_tasks: list[airflow.models.TaskInstance]
+"""
+if not finished_tasks:
+# this is for the strange feature of running tasks without dag_run
+finished_tasks = [t for t in 
ti.task.dag.get_task_instances(start_date=ti.execution_date,
+
end_date=ti.execution_date)
 
 Review comment:
   We could do the filtering in the DB here?
   
   ```suggestion
   
end_date=ti.execution_date,
   
state=(State.finished() + [State.UPSTREAM_FAILED])
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364228229
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -346,7 +331,38 @@ def update_state(self, session=None):
 session.merge(self)
 session.commit()
 
-return self.state
+return ready_tis
+
+@provide_session
+def get_ready_tis(self, session, scheduleable_tasks, finished_tasks):
 
 Review comment:
   This feels more like a private method, especially since it takes two list of 
tasks - I think we should make this "private" `_get_ready_tis` and remove the 
`@provide_session` decorator too so that we require to pass in and use the same 
DB session.
   
   For consistency with the rest of the code please also make session the last 
argument.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364232692
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -263,48 +262,34 @@ def update_state(self, session=None):
 Determines the overall state of the DagRun based on the state
 of its TaskInstances.
 
+:param finished_tasks: The finished tasks of this run
+:type finished_tasks: list[airflow.models.TaskInstance]
 :return: State
 """
 
 dag = self.get_dag()
-
-tis = self.get_task_instances(session=session)
-self.log.debug("Updating state for %s considering %s task(s)", self, 
len(tis))
+ready_tis = []
+tis = [ti for ti in self.get_task_instances(session=session) if 
ti.state != State.REMOVED]
 
 Review comment:
   ~What was your reason for filtering our removed TIs here?~ Oh we did this 
anyway in the next loop. Gotcha.
   
   I think it would be better if we filtered it by using the existing `state` 
parameter of `get_task_instances` rather than having to filter it like this.
   
   We could either do it by passing in a list of states and exclude REMOVED, or 
if we change `get_task_instances` to return a "Result" (i.e. don't do `return 
tis.all()` in there, but instead `return tis` -- this will behave almost the 
same when iterated over) we can then extend the filtering here. For example:
   
   ```suggestion
   tis = 
self.get_task_instances(session=session).fliter(TaskInstance.state != 
State.REMOVED).all()
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364238302
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -346,7 +331,38 @@ def update_state(self, session=None):
 session.merge(self)
 session.commit()
 
-return self.state
+return ready_tis
+
+@provide_session
+def get_ready_tis(self, session, scheduleable_tasks, finished_tasks):
+ready_tis = []
+for st in scheduleable_tasks:
+if st.are_dependencies_met(
+dep_context=DepContext(
+flag_upstream_failed=True,
+finished_tasks=finished_tasks),
+session=session):
+ready_tis.append(st)
+return ready_tis
+
+@provide_session
+def are_runnable_tis(self, session, unfinished_tasks, finished_tasks):
+# this is an optimization to avoid running on tasks that are not ready 
twice
+not_ready_tis = []
+# there might be runnable tasks that are up for retry and from some 
reason(retry delay, etc) are
+# not ready yet so we set the flags to count them in
+for ut in unfinished_tasks:
+if ut.are_dependencies_met(
+dep_context=DepContext(
+flag_upstream_failed=True,
+ignore_in_retry_period=True,
+ignore_in_reschedule_period=True,
+finished_tasks=finished_tasks),
+session=session):
+return False, not_ready_tis
 
 Review comment:
   This would abort the loop early when the first un-finished task is met, 
which I don't think we want to do for two reasons:
   
   1. If the DAG has more "paths" one path might not be ready but other tasks 
in the DAG could be.
   2. If a dag has a lot of "fan-out" (`base >> [ t1, t2, t3, t4]` etc) then 
only one of `tN` would get marked as upstream_fails per loop -- they should all 
be marked as failed at the same time really.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation operators to AWS providers

codecov-io edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation 
operators to AWS providers
URL: https://github.com/apache/airflow/pull/6824#issuecomment-571189190
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=h1) 
Report
   > Merging 
[#6824](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr=desc)
 will **increase** coverage by `0.1%`.
   > The diff coverage is `97.89%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6824/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6824 +/-   ##
   =
   + Coverage   84.85%   84.96%   +0.1% 
   =
 Files 679  685  +6 
 Lines   3853639077+541 
   =
   + Hits3269833200+502 
   - Misses   5838 5877 +39
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ow/providers/amazon/aws/sensors/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Nsb3VkX2Zvcm1hdGlvbi5weQ==)
 | `100% <100%> (ø)` | |
   | 
[...flow/providers/amazon/aws/hooks/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9jbG91ZF9mb3JtYXRpb24ucHk=)
 | `95.45% <95.45%> (ø)` | |
   | 
[.../providers/amazon/aws/operators/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvY2xvdWRfZm9ybWF0aW9uLnB5)
 | `97.43% <97.43%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/gcp\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfdHJhbnNmZXJfb3BlcmF0b3IucHk=)
 | `95.45% <0%> (-4.55%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | ... and [84 
more](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=footer). 
Last update 
[be812bd...2af82f2](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation operators to AWS providers

codecov-io edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation 
operators to AWS providers
URL: https://github.com/apache/airflow/pull/6824#issuecomment-571189190
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=h1) 
Report
   > Merging 
[#6824](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr=desc)
 will **increase** coverage by `0.1%`.
   > The diff coverage is `97.89%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6824/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6824 +/-   ##
   =
   + Coverage   84.85%   84.96%   +0.1% 
   =
 Files 679  685  +6 
 Lines   3853639077+541 
   =
   + Hits3269833200+502 
   - Misses   5838 5877 +39
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ow/providers/amazon/aws/sensors/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Nsb3VkX2Zvcm1hdGlvbi5weQ==)
 | `100% <100%> (ø)` | |
   | 
[...flow/providers/amazon/aws/hooks/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9jbG91ZF9mb3JtYXRpb24ucHk=)
 | `95.45% <95.45%> (ø)` | |
   | 
[.../providers/amazon/aws/operators/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvY2xvdWRfZm9ybWF0aW9uLnB5)
 | `97.43% <97.43%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/gcp\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfdHJhbnNmZXJfb3BlcmF0b3IucHk=)
 | `95.45% <0%> (-4.55%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | ... and [84 
more](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=footer). 
Last update 
[be812bd...2af82f2](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation operators to AWS providers

codecov-io edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation 
operators to AWS providers
URL: https://github.com/apache/airflow/pull/6824#issuecomment-571189190
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=h1) 
Report
   > Merging 
[#6824](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/8ad6160950724476fd29161b5451550b0b32e3ca?src=pr=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `97.89%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6824/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6824  +/-   ##
   ==
   - Coverage   85.19%   84.96%   -0.24% 
   ==
 Files 682  685   +3 
 Lines   3898239077  +95 
   ==
   - Hits3321233200  -12 
   - Misses   5770 5877 +107
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ow/providers/amazon/aws/sensors/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Nsb3VkX2Zvcm1hdGlvbi5weQ==)
 | `100% <100%> (ø)` | |
   | 
[...flow/providers/amazon/aws/hooks/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9jbG91ZF9mb3JtYXRpb24ucHk=)
 | `95.45% <95.45%> (ø)` | |
   | 
[.../providers/amazon/aws/operators/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvY2xvdWRfZm9ybWF0aW9uLnB5)
 | `97.43% <97.43%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/airflow/pull/6824/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=footer). 
Last update 
[8ad6160...2af82f2](https://codecov.io/gh/apache/airflow/pull/6824?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

ashb commented on issue #4751: [AIRFLOW-3607] collected trigger rule dep check 
per dag run
URL: https://github.com/apache/airflow/pull/4751#issuecomment-572043020
 
 
   Taking another look at this now. :eyes: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk edited a comment on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

potiuk edited a comment on issue #6576: [AIRFLOW-5922] Add option to specify 
the mysql client library used in MySqlHook
URL: https://github.com/apache/airflow/pull/6576#issuecomment-572036697
 
 
   a bit busy with figthing with CI now :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk edited a comment on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

potiuk edited a comment on issue #6576: [AIRFLOW-5922] Add option to specify 
the mysql client library used in MySqlHook
URL: https://github.com/apache/airflow/pull/6576#issuecomment-572036697
 
 
   a bit busy with fighting with CI now :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

potiuk commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql 
client library used in MySqlHook
URL: https://github.com/apache/airflow/pull/6576#issuecomment-572036697
 
 
   a bit busy with fithing with CI now :(.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (AIRFLOW-6508) Update the version of cattrs from 0.9 to 1.0



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-6508.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> Update the version of cattrs from 0.9 to 1.0
> 
>
> Key: AIRFLOW-6508
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6508
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 1.10.8
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Major
> Fix For: 2.0.0
>
>
> cattrs 0.9 with Python 3.8 causes following error.
> {code:java}
> $ airflow
> Traceback (most recent call last):
>   File "/Users/sarutak/airflow-env/bin/airflow", line 27, in 
>     from airflow.bin.cli import CLIFactory
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/__init__.py", 
> line 40, in 
>     from airflow.models.dag import DAG
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/__init__.py",
>  line 21, in 
>     from airflow.models.baseoperator import BaseOperator, BaseOperatorLink  # 
> noqa: F401
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/baseoperator.py",
>  line 41, in 
>     from airflow.lineage import apply_lineage, prepare_lineage
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/lineage/__init__.py",
>  line 28, in 
>     from cattr import structure, unstructure
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/__init__.py", 
> line 2, in 
>     from .converters import Converter, UnstructureStrategy
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/converters.py", 
> line 3, in 
>     from ._compat import (
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/_compat.py", 
> line 86, in 
>     from typing import _Union
> ImportError: cannot import name '_Union' from 'typing' 
> (/opt/python/3.8.0/lib/python3.8/typing.py) {code}
> This issue is resolved in cattrs 1.0.
> [https://github.com/Tinche/cattrs/pull/73]
> So let's update it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7100: [AIRFLOW-6508] Update the version of cattrs from 0.9 to 1.0

boring-cyborg[bot] commented on issue #7100: [AIRFLOW-6508] Update the version 
of cattrs from 0.9 to 1.0
URL: https://github.com/apache/airflow/pull/7100#issuecomment-572036306
 
 
   Awesome work, congrats on your first merged pull request!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6508) Update the version of cattrs from 0.9 to 1.0



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010664#comment-17010664
 ] 

ASF GitHub Bot commented on AIRFLOW-6508:
-

potiuk commented on pull request #7100: [AIRFLOW-6508] Update the version of 
cattrs from 0.9 to 1.0
URL: https://github.com/apache/airflow/pull/7100
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update the version of cattrs from 0.9 to 1.0
> 
>
> Key: AIRFLOW-6508
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6508
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 1.10.8
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Major
>
> cattrs 0.9 with Python 3.8 causes following error.
> {code:java}
> $ airflow
> Traceback (most recent call last):
>   File "/Users/sarutak/airflow-env/bin/airflow", line 27, in 
>     from airflow.bin.cli import CLIFactory
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/__init__.py", 
> line 40, in 
>     from airflow.models.dag import DAG
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/__init__.py",
>  line 21, in 
>     from airflow.models.baseoperator import BaseOperator, BaseOperatorLink  # 
> noqa: F401
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/baseoperator.py",
>  line 41, in 
>     from airflow.lineage import apply_lineage, prepare_lineage
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/lineage/__init__.py",
>  line 28, in 
>     from cattr import structure, unstructure
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/__init__.py", 
> line 2, in 
>     from .converters import Converter, UnstructureStrategy
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/converters.py", 
> line 3, in 
>     from ._compat import (
>   File 
> "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/_compat.py", 
> line 86, in 
>     from typing import _Union
> ImportError: cannot import name '_Union' from 'typing' 
> (/opt/python/3.8.0/lib/python3.8/typing.py) {code}
> This issue is resolved in cattrs 1.0.
> [https://github.com/Tinche/cattrs/pull/73]
> So let's update it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] potiuk merged pull request #7100: [AIRFLOW-6508] Update the version of cattrs from 0.9 to 1.0

potiuk merged pull request #7100: [AIRFLOW-6508] Update the version of cattrs 
from 0.9 to 1.0
URL: https://github.com/apache/airflow/pull/7100
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] sarutak commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

sarutak commented on a change in pull request #7099: [AIRFLOW-6507] Replace the 
use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364212215
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,7 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+m = importlib.machinery.SourceFileLoader(mod_name, 
filepath).load_module()
 
 Review comment:
   Thanks. I'll fix it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] aviemzur edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation operators to AWS providers

aviemzur edited a comment on issue #6824: [AIRFLOW-6258] add CloudFormation 
operators to AWS providers
URL: https://github.com/apache/airflow/pull/6824#issuecomment-571933340
 
 
   @nuclearpinguin made the changes you requested: [Changes after CR 
2](https://github.com/apache/airflow/pull/6824/commits/2af82f2c9c50a70b173ce17449ed0d4ad6f3ce6a)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6574: [AIRFLOW-5924] Automatically unify bucket name and key in S3Hook

feluelle commented on a change in pull request #6574: [AIRFLOW-5924] 
Automatically unify bucket name and key in S3Hook
URL: https://github.com/apache/airflow/pull/6574#discussion_r364207109
 
 

 ##
 File path: airflow/providers/amazon/aws/hooks/s3.py
 ##
 @@ -242,6 +267,7 @@ def list_keys(self, bucket_name=None, prefix='', 
delimiter='',
 return None
 
 @provide_bucket_name
+@unify_bucket_name_and_key
 
 Review comment:
   Hmm. But where? I can't think of a good place for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6509) Description for how to create an user is incorrect in some docs.



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010642#comment-17010642
 ] 

ASF GitHub Bot commented on AIRFLOW-6509:
-

sarutak commented on pull request #7101: [AIRFLOW-6509] Description for how to 
create an user is incorrect in some docs.
URL: https://github.com/apache/airflow/pull/7101
 
 
   In `start.rst` and `security.rst`, description for how to create user is 
wrong.
   We can't do like
   ```
   airflow users -c ...
   ```
   
   Instead, we should do like
   ``
   airflow users create ...
   ```
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Description for how to create an user is incorrect in some docs.
> 
>
> Key: AIRFLOW-6509
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6509
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 1.10.8
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Major
>
> In start.rst and security.rst, description for how to create user is wrong.
> We can't do like
> {code}
> airflow users -c ...
> {code}
> Instead, we should do like
> {code}
> airflow users create ...
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] sarutak opened a new pull request #7101: [AIRFLOW-6509] Description for how to create an user is incorrect in some docs.

sarutak opened a new pull request #7101: [AIRFLOW-6509] Description for how to 
create an user is incorrect in some docs.
URL: https://github.com/apache/airflow/pull/7101
 
 
   In `start.rst` and `security.rst`, description for how to create user is 
wrong.
   We can't do like
   ```
   airflow users -c ...
   ```
   
   Instead, we should do like
   ``
   airflow users create ...
   ```
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6509) Description for how to create an user is incorrect in some docs.

2020-01-08 Thread Kousuke Saruta (Jira)

Kousuke Saruta created AIRFLOW-6509:
---

 Summary: Description for how to create an user is incorrect in 
some docs.
 Key: AIRFLOW-6509
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6509
 Project: Apache Airflow
  Issue Type: Bug
  Components: documentation
Affects Versions: 1.10.8
Reporter: Kousuke Saruta
Assignee: Kousuke Saruta


In start.rst and security.rst, description for how to create user is wrong.
We can't do like
{code}
airflow users -c ...
{code}

Instead, we should do like
{code}
airflow users create ...
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] feluelle commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

feluelle commented on issue #6576: [AIRFLOW-5922] Add option to specify the 
mysql client library used in MySqlHook
URL: https://github.com/apache/airflow/pull/6576#issuecomment-572026221
 
 
   @potiuk or @ashb want to take a look again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

feluelle commented on a change in pull request #7099: [AIRFLOW-6507] Replace 
the use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364201480
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,7 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+m = importlib.machinery.SourceFileLoader(mod_name, 
filepath).load_module()
 
 Review comment:
   Actually you then also need to call 
https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.create_module
 first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

feluelle commented on a change in pull request #7099: [AIRFLOW-6507] Replace 
the use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364200648
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,7 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+m = importlib.machinery.SourceFileLoader(mod_name, 
filepath).load_module()
 
 Review comment:
   ```suggestion
   m = importlib.machinery.SourceFileLoader(mod_name, 
filepath).exec_module()
   ```
   
   
https://docs.python.org/3/library/importlib.html#importlib.machinery.SourceFileLoader.load_module


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

codecov-io commented on issue #7099: [AIRFLOW-6507] Replace the use of 
imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#issuecomment-572019856
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=h1) 
Report
   > Merging 
[#7099](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.22%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7099/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7099  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.23% 
   ==
 Files 680  682   +2 
 Lines   3882438981 +157 
   ==
   + Hits3306133106  +45 
   - Misses   5763 5875 +112
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `86.74% <100%> (-0.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/awsbatch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hd3NiYXRjaF9vcGVyYXRvci5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/gcp\_spanner\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Bfc3Bhbm5lcl9vcGVyYXRvci5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [3 
more](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=footer). 
Last update 
[fe20ef6...7dee296](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

codecov-io edited a comment on issue #7099: [AIRFLOW-6507] Replace the use of 
imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#issuecomment-572019856
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=h1) 
Report
   > Merging 
[#7099](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.22%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7099/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7099  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.23% 
   ==
 Files 680  682   +2 
 Lines   3882438981 +157 
   ==
   + Hits3306133106  +45 
   - Misses   5763 5875 +112
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `86.74% <100%> (-0.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/awsbatch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hd3NiYXRjaF9vcGVyYXRvci5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/gcp\_spanner\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Bfc3Bhbm5lcl9vcGVyYXRvci5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [3 
more](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=footer). 
Last update 
[fe20ef6...7dee296](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

codecov-io edited a comment on issue #7099: [AIRFLOW-6507] Replace the use of 
imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#issuecomment-572019856
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=h1) 
Report
   > Merging 
[#7099](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.22%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7099/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7099  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.23% 
   ==
 Files 680  682   +2 
 Lines   3882438981 +157 
   ==
   + Hits3306133106  +45 
   - Misses   5763 5875 +112
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `86.74% <100%> (-0.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/awsbatch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hd3NiYXRjaF9vcGVyYXRvci5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/gcp\_spanner\_operator.py](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Bfc3Bhbm5lcl9vcGVyYXRvci5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [3 
more](https://codecov.io/gh/apache/airflow/pull/7099/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=footer). 
Last update 
[fe20ef6...7dee296](https://codecov.io/gh/apache/airflow/pull/7099?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...129e606](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

codecov-io commented on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...129e606](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2020-01-08 Thread ASF subversion and git services (Jira)

codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   85.15%   85.2%   +0.05% 
   =
 Files 680 682   +2 
 Lines   38824   38984 +160 
   =
   + Hits33061   33217 +156 
   - Misses   57635767   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[fe20ef6...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6111) Rename spanner service



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010600#comment-17010600
 ] 

ASF subversion and git services commented on AIRFLOW-6111:
--

Commit 8ad6160950724476fd29161b5451550b0b32e3ca in airflow's branch 
refs/heads/master from Michał Słowikowski
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=8ad6160 ]

[AIRFLOW-6111] [AIP-21]  Rename GCP spanner operator and hook (#7004)



> Rename spanner service
> --
>
> Key: AIRFLOW-6111
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6111
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: gcp
>Affects Versions: 1.10.6
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
> Fix For: 2.0.0
>
>
> Added these classes:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (AIRFLOW-6111) Rename spanner service

2020-01-08 Thread Tomasz Urbaszek (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomasz Urbaszek resolved AIRFLOW-6111.
--
Fix Version/s: 2.0.0
   Resolution: Done

> Rename spanner service
> --
>
> Key: AIRFLOW-6111
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6111
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: gcp
>Affects Versions: 1.10.6
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
> Fix For: 2.0.0
>
>
> Added these classes:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6111) Rename spanner service



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010599#comment-17010599
 ] 

ASF GitHub Bot commented on AIRFLOW-6111:
-

nuclearpinguin commented on pull request #7004: [AIRFLOW-6111] [AIP-21]  Rename 
GCP spanner operator and hook
URL: https://github.com/apache/airflow/pull/7004
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rename spanner service
> --
>
> Key: AIRFLOW-6111
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6111
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: gcp
>Affects Versions: 1.10.6
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
> Added these classes:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] nuclearpinguin merged pull request #7004: [AIRFLOW-6111] [AIP-21] Rename GCP spanner operator and hook

nuclearpinguin merged pull request #7004: [AIRFLOW-6111] [AIP-21]  Rename GCP 
spanner operator and hook
URL: https://github.com/apache/airflow/pull/7004
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7100: [AIRFLOW-6508] Update the version of cattrs from 0.9 to 1.0

2020-01-08 Thread ASF subversion and git services (Jira)

codecov-io commented on issue #7100: [AIRFLOW-6508] Update the version of 
cattrs from 0.9 to 1.0
URL: https://github.com/apache/airflow/pull/7100#issuecomment-572004796
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=h1) 
Report
   > Merging 
[#7100](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7100/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7100  +/-   ##
   ==
   - Coverage   85.15%   84.87%   -0.29% 
   ==
 Files 680  680  
 Lines   3882438824  
   ==
   - Hits3306132952 -109 
   - Misses   5763 5872 +109
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7100/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7100/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7100/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7100/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7100/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7100/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=)
 | `84.61% <0%> (+1.28%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=footer). 
Last update 
[fe20ef6...ca05904](https://codecov.io/gh/apache/airflow/pull/7100?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-6507) Replace the use of imp.load_source with another solution.

2020-01-08 Thread Kousuke Saruta (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kousuke Saruta updated AIRFLOW-6507:

Summary: Replace the use of imp.load_source with another solution.  (was: 
Replace the use of impl.load_source with another solution.)

> Replace the use of imp.load_source with another solution.
> -
>
> Key: AIRFLOW-6507
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6507
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: models
>Affects Versions: 1.10.8
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Minor
>
> As of Python 3.4, impl module will be deprecated and recommended to use 
> importlib.
> [https://docs.python.org/3/library/imp.html]
> Almost all the part of code in Airflow uses importlib except for 
> impl.load_source in models/dagbag.py.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (AIRFLOW-6507) Replace the use of imp.load_source with another solution.

2020-01-08 Thread Kousuke Saruta (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kousuke Saruta updated AIRFLOW-6507:

Description: 
As of Python 3.4, imp module will be deprecated and recommended to use 
importlib.
[https://docs.python.org/3/library/imp.html]

Almost all the part of code in Airflow uses importlib except for 
imp.load_source in models/dagbag.py.

  was:
As of Python 3.4, impl module will be deprecated and recommended to use 
importlib.
[https://docs.python.org/3/library/imp.html]

Almost all the part of code in Airflow uses importlib except for 
impl.load_source in models/dagbag.py.


> Replace the use of imp.load_source with another solution.
> -
>
> Key: AIRFLOW-6507
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6507
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: models
>Affects Versions: 1.10.8
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Minor
>
> As of Python 3.4, imp module will be deprecated and recommended to use 
> importlib.
> [https://docs.python.org/3/library/imp.html]
> Almost all the part of code in Airflow uses importlib except for 
> imp.load_source in models/dagbag.py.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6118) Rename pubsub service



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010586#comment-17010586
 ] 

ASF subversion and git services commented on AIRFLOW-6118:
--

Commit 4f8592ae8f52ab7f42623d3b43eef0928c9aafb2 in airflow's branch 
refs/heads/master from Michał Słowikowski
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4f8592a ]

[AIRFLOW-6118] [AIP-21] Rename Pubsub operators and hook (#7046)

PR contains changes regarding AIP-21 (renaming GCP operators and hooks):

* renamed GCP modules
* adde deprecation warnings to the contrib modules
* fixed tests
* updated UPDATING.md

> Rename pubsub service
> -
>
> Key: AIRFLOW-6118
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6118
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: gcp
>Affects Versions: 1.10.6
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
> Fix For: 2.0.0
>
>
> Added these classes:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (AIRFLOW-6118) Rename pubsub service



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-6118.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> Rename pubsub service
> -
>
> Key: AIRFLOW-6118
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6118
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: gcp
>Affects Versions: 1.10.6
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
> Fix For: 2.0.0
>
>
> Added these classes:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6118) Rename pubsub service



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010585#comment-17010585
 ] 

ASF GitHub Bot commented on AIRFLOW-6118:
-

potiuk commented on pull request #7046: [AIRFLOW-6118] [AIP-21] Rename Google 
Pubsub operators and hook
URL: https://github.com/apache/airflow/pull/7046
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rename pubsub service
> -
>
> Key: AIRFLOW-6118
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6118
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: gcp
>Affects Versions: 1.10.6
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
> Added these classes:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] potiuk merged pull request #7046: [AIRFLOW-6118] [AIP-21] Rename Google Pubsub operators and hook

potiuk merged pull request #7046: [AIRFLOW-6118] [AIP-21] Rename Google Pubsub 
operators and hook
URL: https://github.com/apache/airflow/pull/7046
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on issue #6469: [AIRFLOW-5816] S3 to snowflake operator

feluelle commented on issue #6469: [AIRFLOW-5816] S3 to snowflake operator
URL: https://github.com/apache/airflow/pull/6469#issuecomment-57274
 
 
   You may also want to squash your commits from time to time. It will help 
your git history to become cleaner and easier to follow :) 
   
   
https://softwareengineering.stackexchange.com/questions/263164/why-squash-git-commits-for-pull-requests
   
https://blog.carbonfive.com/2017/08/28/always-squash-and-rebase-your-git-commits/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #6954: [AIRFLOW-4355] removed task should not lead to dagrun success

ashb commented on a change in pull request #6954: [AIRFLOW-4355] removed task 
should not lead to dagrun success
URL: https://github.com/apache/airflow/pull/6954#discussion_r364176253
 
 

 ##
 File path: airflow/config_templates/default_airflow.cfg
 ##
 @@ -565,6 +565,9 @@ dag_dir_list_interval = 300
 # How often should stats be printed to the logs
 print_stats_interval = 30
 
+# A DagRun can have a 'removed' task instance and still lead to DagRun 
'success' state when False
 
 Review comment:
   Reading this I don't know what this does.
   
   Can you explain (to me here) what this does, so we can come up with a better 
doc comment here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7004: [AIRFLOW-6111] [AIP-21] Rename GCP spanner operator and hook

codecov-io edited a comment on issue #7004: [AIRFLOW-6111] [AIP-21]  Rename GCP 
spanner operator and hook
URL: https://github.com/apache/airflow/pull/7004#issuecomment-570252727
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=h1) 
Report
   > Merging 
[#7004](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7004/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7004  +/-   ##
   ==
   - Coverage   85.15%   84.88%   -0.28% 
   ==
 Files 680  680  
 Lines   3882438848  +24 
   ==
   - Hits3306132975  -86 
   - Misses   5763 5873 +110
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/example\_dags/example\_spanner.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfc3Bhbm5lci5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/gcp\_spanner\_operator.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Bfc3Bhbm5lcl9vcGVyYXRvci5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/spanner.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL3NwYW5uZXIucHk=)
 | `98.75% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=footer). 
Last update 
[fe20ef6...033efd0](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7004: [AIRFLOW-6111] [AIP-21] Rename GCP spanner operator and hook

codecov-io edited a comment on issue #7004: [AIRFLOW-6111] [AIP-21]  Rename GCP 
spanner operator and hook
URL: https://github.com/apache/airflow/pull/7004#issuecomment-570252727
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=h1) 
Report
   > Merging 
[#7004](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7004/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7004  +/-   ##
   ==
   - Coverage   85.15%   84.88%   -0.28% 
   ==
 Files 680  680  
 Lines   3882438848  +24 
   ==
   - Hits3306132975  -86 
   - Misses   5763 5873 +110
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/example\_dags/example\_spanner.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfc3Bhbm5lci5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/gcp\_spanner\_operator.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Bfc3Bhbm5lcl9vcGVyYXRvci5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/spanner.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL3NwYW5uZXIucHk=)
 | `98.75% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=footer). 
Last update 
[fe20ef6...033efd0](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7004: [AIRFLOW-6111] [AIP-21] Rename GCP spanner operator and hook

codecov-io edited a comment on issue #7004: [AIRFLOW-6111] [AIP-21]  Rename GCP 
spanner operator and hook
URL: https://github.com/apache/airflow/pull/7004#issuecomment-570252727
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=h1) 
Report
   > Merging 
[#7004](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7004/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7004  +/-   ##
   ==
   - Coverage   85.15%   84.88%   -0.28% 
   ==
 Files 680  680  
 Lines   3882438848  +24 
   ==
   - Hits3306132975  -86 
   - Misses   5763 5873 +110
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/example\_dags/example\_spanner.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfc3Bhbm5lci5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/gcp\_spanner\_operator.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Bfc3Bhbm5lcl9vcGVyYXRvci5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/spanner.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL3NwYW5uZXIucHk=)
 | `98.75% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7004/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=footer). 
Last update 
[fe20ef6...033efd0](https://codecov.io/gh/apache/airflow/pull/7004?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6469: [AIRFLOW-5816] S3 to snowflake operator

2020-01-08 Thread ASF subversion and git services (Jira)

feluelle commented on a change in pull request #6469: [AIRFLOW-5816] S3 to 
snowflake operator
URL: https://github.com/apache/airflow/pull/6469#discussion_r364174151
 
 

 ##
 File path: scripts/ci/pylint_todo.txt
 ##
 @@ -198,34 +196,6 @@
 ./airflow/ti_deps/deps/task_concurrency_dep.py
 ./airflow/ti_deps/deps/trigger_rule_dep.py
 ./airflow/ti_deps/deps/valid_state_dep.py
-./airflow/utils/asciiart.py
-./airflow/utils/cli_action_loggers.py
-./airflow/utils/compression.py
-./airflow/utils/configuration.py
-./airflow/utils/dates.py
-./airflow/utils/db.py
-./airflow/utils/decorators.py
-./airflow/utils/email.py
-./airflow/utils/file.py
-./airflow/utils/helpers.py
-./airflow/utils/json.py
-./airflow/utils/log/es_task_handler.py
-./airflow/utils/log/file_processor_handler.py
-./airflow/utils/log/gcs_task_handler.py
-./airflow/utils/log/logging_mixin.py
-./airflow/utils/log/s3_task_handler.py
-./airflow/utils/log/wasb_task_handler.py
-./airflow/utils/module_loading.py
-./airflow/utils/net.py
-./airflow/utils/operator_helpers.py
-./airflow/utils/operator_resources.py
-./airflow/utils/sqlalchemy.py
-./airflow/utils/state.py
-./airflow/utils/tests.py
-./airflow/utils/timeout.py
-./airflow/utils/timezone.py
-./airflow/utils/trigger_rule.py
-./airflow/utils/weight_rule.py
 
 Review comment:
   These changes shouldn't be included in your PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (AIRFLOW-6245) Allow custom waiters for AWS batch jobs

2020-01-08 Thread Felix Uellendall (Jira)



 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Uellendall resolved AIRFLOW-6245.
---
Resolution: Fixed

> Allow custom waiters for AWS batch jobs
> ---
>
> Key: AIRFLOW-6245
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6245
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: aws
>Affects Versions: 1.10.6
>Reporter: Darren Weber
>Assignee: Darren Weber
>Priority: Minor
>  Labels: AWS, aws-batch
> Fix For: 2.0.0, 1.10.8
>
>
> The botocore waiter for AWS batch jobs has not been merged and released for 
> several years, i.e.
> - [https://github.com/boto/botocore/pull/1307]
> While working on this Airflow issue, I've also pushed up a PR on botocore to 
> use a default waiter with exponential backoff and add an option to use a 
> custom function for the delays between polling status, see
> - [https://github.com/boto/botocore/issues/1915]
> - [https://github.com/boto/botocore/pull/1921]
>  
> For Airflow, adopt something from botocore PR-1307 as an example to create a 
> default batch job waiter in Airflow.  As a guide to creating a custom waiter, 
> see
> - [https://www.2ndwatch.com/blog/use-waiters-boto3-write/]
> - 
> [https://boto3.amazonaws.com/v1/documentation/api/latest/guide/clients.html#waiters]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6245) Allow custom waiters for AWS batch jobs



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010571#comment-17010571
 ] 

ASF subversion and git services commented on AIRFLOW-6245:
--

Commit 78d8fe6944b689b9b0af99255286e34e06eedec3 in airflow's branch 
refs/heads/master from Darren Weber
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=78d8fe6 ]

[AIRFLOW-6245] Add custom waiters for AWS batch jobs (#6811)

- add AwsBatchWaiters
  - the waiters are based on botocore, but not yet
available for AWS batch services
- refactor AwsBatchOperator:
  - use an optional waiters object to wait for
batch job status indicators
  - split execute into submit_job and monitor_job
  - use job_id with an optional init-parameter;
discard jobId and jobName (already has job_name)
  - inherit from AwsBatchClient
  - add notes to UPDATING.md
- extract class for AwsBatchClient
  - move responsibility for batch API calls and
response parsing to this client
  - move responsibility for default wait and
polling to this client
- rename BatchProtocol to AwsBatchProtocol [AIP-21]
  - test backward compatibility
  - add PROTOCOLS to tests/test_core_to_contrib.py
  - add notes to UPDATING.md
- split up polling for job status into steps:
  - poll for a JobExists
  - poll for a JobRunning
  - poll for a JobComplete
- use random jitter for wait-polling delays for
  high concurrency job polling
- modify the exponential backoff delay for the
  existing polling functions
- revise and update unit tests

> Allow custom waiters for AWS batch jobs
> ---
>
> Key: AIRFLOW-6245
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6245
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: aws
>Affects Versions: 1.10.6
>Reporter: Darren Weber
>Assignee: Darren Weber
>Priority: Minor
>  Labels: AWS, aws-batch
> Fix For: 2.0.0, 1.10.8
>
>
> The botocore waiter for AWS batch jobs has not been merged and released for 
> several years, i.e.
> - [https://github.com/boto/botocore/pull/1307]
> While working on this Airflow issue, I've also pushed up a PR on botocore to 
> use a default waiter with exponential backoff and add an option to use a 
> custom function for the delays between polling status, see
> - [https://github.com/boto/botocore/issues/1915]
> - [https://github.com/boto/botocore/pull/1921]
>  
> For Airflow, adopt something from botocore PR-1307 as an example to create a 
> default batch job waiter in Airflow.  As a guide to creating a custom waiter, 
> see
> - [https://www.2ndwatch.com/blog/use-waiters-boto3-write/]
> - 
> [https://boto3.amazonaws.com/v1/documentation/api/latest/guide/clients.html#waiters]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6245) Allow custom waiters for AWS batch jobs



[ 
https://issues.apache.org/jira/browse/AIRFLOW-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010568#comment-17010568
 ] 

ASF GitHub Bot commented on AIRFLOW-6245:
-

feluelle commented on pull request #6811: [AIRFLOW-6245] Add custom waiters for 
AWS batch jobs
URL: https://github.com/apache/airflow/pull/6811
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow custom waiters for AWS batch jobs
> ---
>
> Key: AIRFLOW-6245
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6245
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: aws
>Affects Versions: 1.10.6
>Reporter: Darren Weber
>Assignee: Darren Weber
>Priority: Minor
>  Labels: AWS, aws-batch
> Fix For: 2.0.0, 1.10.8
>
>
> The botocore waiter for AWS batch jobs has not been merged and released for 
> several years, i.e.
> - [https://github.com/boto/botocore/pull/1307]
> While working on this Airflow issue, I've also pushed up a PR on botocore to 
> use a default waiter with exponential backoff and add an option to use a 
> custom function for the delays between polling status, see
> - [https://github.com/boto/botocore/issues/1915]
> - [https://github.com/boto/botocore/pull/1921]
>  
> For Airflow, adopt something from botocore PR-1307 as an example to create a 
> default batch job waiter in Airflow.  As a guide to creating a custom waiter, 
> see
> - [https://www.2ndwatch.com/blog/use-waiters-boto3-write/]
> - 
> [https://boto3.amazonaws.com/v1/documentation/api/latest/guide/clients.html#waiters]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] feluelle merged pull request #6811: [AIRFLOW-6245] Add custom waiters for AWS batch jobs

feluelle merged pull request #6811: [AIRFLOW-6245] Add custom waiters for AWS 
batch jobs
URL: https://github.com/apache/airflow/pull/6811
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364170363
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -263,48 +262,34 @@ def update_state(self, session=None):
 Determines the overall state of the DagRun based on the state
 of its TaskInstances.
 
+:param finished_tasks: The finished tasks of this run
+:type finished_tasks: list[airflow.models.TaskInstance]
 :return: State
 """
 
 dag = self.get_dag()
-
-tis = self.get_task_instances(session=session)
-self.log.debug("Updating state for %s considering %s task(s)", self, 
len(tis))
+ready_tis = []
+tis = [ti for ti in self.get_task_instances(session=session) if 
ti.state != State.REMOVED]
 
 Review comment:
   I didn't try larger dags but I believe that the impact will be huge


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364169818
 
 

 ##
 File path: airflow/models/dagrun.py
 ##
 @@ -263,48 +262,34 @@ def update_state(self, session=None):
 Determines the overall state of the DagRun based on the state
 of its TaskInstances.
 
+:param finished_tasks: The finished tasks of this run
+:type finished_tasks: list[airflow.models.TaskInstance]
 :return: State
 """
 
 dag = self.get_dag()
-
-tis = self.get_task_instances(session=session)
-self.log.debug("Updating state for %s considering %s task(s)", self, 
len(tis))
+ready_tis = []
+tis = [ti for ti in self.get_task_instances(session=session) if 
ti.state != State.REMOVED]
 
 Review comment:
   No I didn't notice that, do you think it has something to do with this 
changes?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] albertusk95 edited a comment on issue #7075: [AIRFLOW-6212] SparkSubmitHook resolve connection

albertusk95 edited a comment on issue #7075: [AIRFLOW-6212] SparkSubmitHook 
resolve connection
URL: https://github.com/apache/airflow/pull/7075#issuecomment-571989590
 
 
   > > > > @tooptoop4 if we don't remove the spark check on line 177, how to 
use this hook to track driver status deployed on yarn, mesos, or k8s? Since I 
think `spark://` is only for standalone mode.
   > > > > Or this hook is created only for standalone mode?
   > > > 
   > > > 
   > > > yes.there is no concept of async driver status poll for other modes , 
read https://spark.apache.org/docs/latest/running-on-yarn.html ! in other modes 
the submit to launch is synchronous . i think u can cancel this @albertusk95
   > > 
   > > 
   > > I couldn't find any info stating that there's no async driver polling 
for YARN anyway from the provided link.
   > 
   > There isn't async driver polling in YARN, I know Spark on YARN.
   
   How about using Livy to interact with the YARN cluster? I guess it supports 
sync & async results retrieval.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] albertusk95 commented on issue #7075: [AIRFLOW-6212] SparkSubmitHook resolve connection