[jira] [Commented] (BEAM-2735) testMergingCustomWindows tests are incorrect
[
https://issues.apache.org/jira/browse/BEAM-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121902#comment-16121902
]
ASF GitHub Bot commented on BEAM-2735:
--
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3698
> testMergingCustomWindows tests are incorrect
>
>
> Key: BEAM-2735
> URL: https://issues.apache.org/jira/browse/BEAM-2735
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Affects Versions: 2.2.0
>Reporter: Thomas Groh
>Assignee: Thomas Groh
>
> If the input is rewritten to use to use {{TestStream}}, and executes in the
> DirectRunner, the tests fail. My expectation is that this is due to a
> disagreement in what the tests expect to be merged (if all of the merging
> logic is run only once), as opposed to running the merging logic
> incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
> PCollection inputCollection =
> pipeline.apply(
> TestStream.create(StringUtf8Coder.of())
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(10L)))
> .addElements("big")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(20L)))
> .addElements("small1")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(39L)))
> .addElements("small2")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(250L)))
> .advanceWatermarkToInfinity());
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (BEAM-2735) testMergingCustomWindows tests are incorrect
[
https://issues.apache.org/jira/browse/BEAM-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117404#comment-16117404
]
ASF GitHub Bot commented on BEAM-2735:
--
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/3698
[BEAM-2735] Update Custom Window Merging Tests
Update the merge windows to be order-independent.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam custom_merging_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3698
> testMergingCustomWindows tests are incorrect
>
>
> Key: BEAM-2735
> URL: https://issues.apache.org/jira/browse/BEAM-2735
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Affects Versions: 2.2.0
>Reporter: Thomas Groh
>Assignee: Etienne Chauchot
>
> If the input is rewritten to use to use {{TestStream}}, and executes in the
> DirectRunner, the tests fail. My expectation is that this is due to a
> disagreement in what the tests expect to be merged (if all of the merging
> logic is run only once), as opposed to running the merging logic
> incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
> PCollection inputCollection =
> pipeline.apply(
> TestStream.create(StringUtf8Coder.of())
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(10L)))
> .addElements("big")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(20L)))
> .addElements("small1")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(39L)))
> .addElements("small2")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(250L)))
> .advanceWatermarkToInfinity());
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (BEAM-2735) testMergingCustomWindows tests are incorrect
[
https://issues.apache.org/jira/browse/BEAM-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116845#comment-16116845
]
Thomas Groh commented on BEAM-2735:
---
Hm; that's super strange - I can reliably get the test to fail in my IDE in the
direct runner module, but not in maven.
I'll take another look sometime today.
> testMergingCustomWindows tests are incorrect
>
>
> Key: BEAM-2735
> URL: https://issues.apache.org/jira/browse/BEAM-2735
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Affects Versions: 2.2.0
>Reporter: Thomas Groh
>Assignee: Etienne Chauchot
>
> If the input is rewritten to use to use {{TestStream}}, and executes in the
> DirectRunner, the tests fail. My expectation is that this is due to a
> disagreement in what the tests expect to be merged (if all of the merging
> logic is run only once), as opposed to running the merging logic
> incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
> PCollection inputCollection =
> pipeline.apply(
> TestStream.create(StringUtf8Coder.of())
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(10L)))
> .addElements("big")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(20L)))
> .addElements("small1")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(39L)))
> .addElements("small2")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(250L)))
> .advanceWatermarkToInfinity());
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (BEAM-2735) testMergingCustomWindows tests are incorrect
[
https://issues.apache.org/jira/browse/BEAM-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116566#comment-16116566
]
Etienne Chauchot commented on BEAM-2735:
I only re-coded the input collection creation by using {{TestStream}} in the
two testMergingCustomWindows* tests like you suggested. Please see
https://github.com/echauchot/beam/blob/BEAM-2735-fix-custom-window-test-in-streaming/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
But the tests pass using direct runner.
Did I miss something?
> testMergingCustomWindows tests are incorrect
>
>
> Key: BEAM-2735
> URL: https://issues.apache.org/jira/browse/BEAM-2735
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Affects Versions: 2.2.0
>Reporter: Thomas Groh
>Assignee: Etienne Chauchot
>
> If the input is rewritten to use to use {{TestStream}}, and executes in the
> DirectRunner, the tests fail. My expectation is that this is due to a
> disagreement in what the tests expect to be merged (if all of the merging
> logic is run only once), as opposed to running the merging logic
> incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
> PCollection inputCollection =
> pipeline.apply(
> TestStream.create(StringUtf8Coder.of())
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(10L)))
> .addElements("big")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(20L)))
> .addElements("small1")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(39L)))
> .addElements("small2")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(250L)))
> .advanceWatermarkToInfinity());
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (BEAM-2735) testMergingCustomWindows tests are incorrect
[
https://issues.apache.org/jira/browse/BEAM-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116344#comment-16116344
]
Etienne Chauchot commented on BEAM-2735:
Thanks Thomas for pointing! I'll fix it.
> testMergingCustomWindows tests are incorrect
>
>
> Key: BEAM-2735
> URL: https://issues.apache.org/jira/browse/BEAM-2735
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Affects Versions: 2.2.0
>Reporter: Thomas Groh
>Assignee: Etienne Chauchot
>
> If the input is rewritten to use to use {{TestStream}}, and executes in the
> DirectRunner, the tests fail. My expectation is that this is due to a
> disagreement in what the tests expect to be merged (if all of the merging
> logic is run only once), as opposed to running the merging logic
> incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
> PCollection inputCollection =
> pipeline.apply(
> TestStream.create(StringUtf8Coder.of())
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(10L)))
> .addElements("big")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(20L)))
> .addElements("small1")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(39L)))
> .addElements("small2")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(250L)))
> .advanceWatermarkToInfinity());
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
