[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=135169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135169 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 15/Aug/18 22:04 Start Date: 15/Aug/18 22:04 Worklog Time Spent: 10m Work Description: pabloem commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-413353099 Very nice. Merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135169) Time Spent: 4h 10m (was: 4h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[
https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=135170=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135170
]
ASF GitHub Bot logged work on BEAM-4809:
Author: ASF GitHub Bot
Created on: 15/Aug/18 22:04
Start Date: 15/Aug/18 22:04
Worklog Time Spent: 10m
Work Description: pabloem closed pull request #5970: [BEAM-4809] Build
javadoc on :javaPreCommit and :javaPostCommit
URL: https://github.com/apache/beam/pull/5970
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index dcfadbbc414..2eb93a3a5ff 100644
--- a/build.gradle
+++ b/build.gradle
@@ -184,6 +184,7 @@ task javaPreCommit() {
dependsOn ":beam-sdks-java-core:buildDependents"
dependsOn ":beam-examples-java:preCommit"
dependsOn ":beam-sdks-java-extensions-sql-jdbc:preCommit"
+ dependsOn ":beam-sdks-java-javadoc:allJavadoc"
}
task javaPostCommit() {
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 6916ab1e794..c778df9ac43 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -643,6 +643,9 @@ class BeamModulePlugin implements Plugin {
}
project.checkstyle { toolVersion = "8.7" }
+ // Ensure check runs javadoc
+ project.check.dependsOn project.javadoc
+
// Apply the eclipse and apt-eclipse plugins. This adds the "eclipse"
task and
// connects the apt-eclipse plugin to update the eclipse project files
// with the instructions needed to run apt within eclipse to handle the
AutoValue
diff --git a/sdks/java/javadoc/build.gradle b/sdks/java/javadoc/build.gradle
index 240aef4f21a..4f73e23ee13 100644
--- a/sdks/java/javadoc/build.gradle
+++ b/sdks/java/javadoc/build.gradle
@@ -78,6 +78,10 @@ for (String exportedJavadocProject :
exportedJavadocProjects) {
evaluationDependsOn(exportedJavadocProject)
}
+task allJavadoc() {
+ dependsOn exportedJavadocProjects.collect { "$it:javadoc" }
+}
+
task aggregateJavadoc(type: Javadoc) {
source exportedJavadocProjects.collect { project(it).sourceSets.main.allJava
}
classpath = files(exportedJavadocProjects.collect {
project(it).sourceSets.main.compileClasspath })
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 135170)
Time Spent: 4h 20m (was: 4h 10m)
> Java preCommit and postCommit should build javadoc to check it builds ok
>
>
> Key: BEAM-4809
> URL: https://issues.apache.org/jira/browse/BEAM-4809
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Affects Versions: 2.5.0
>Reporter: Alan Myrvold
>Assignee: Alan Myrvold
>Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Java preCommit and postCommit should build javadoc to check it builds ok
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=135165=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135165 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 15/Aug/18 21:48 Start Date: 15/Aug/18 21:48 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-413349106 @aaltay It is ready to be merged; precommits passed including the new javadoc check. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135165) Time Spent: 4h (was: 3h 50m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=135130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135130 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 15/Aug/18 19:56 Start Date: 15/Aug/18 19:56 Worklog Time Spent: 10m Work Description: aaltay commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-413316254 What is the state of this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135130) Time Spent: 3h 50m (was: 3h 40m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=131687=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131687 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 07/Aug/18 01:31 Start Date: 07/Aug/18 01:31 Worklog Time Spent: 10m Work Description: udim commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-410903602 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 131687) Time Spent: 3h 40m (was: 3.5h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=127005=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127005 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 25/Jul/18 02:10 Start Date: 25/Jul/18 02:10 Worklog Time Spent: 10m Work Description: alanmyrvold removed a comment on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-407544800 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 127005) Time Spent: 3h 20m (was: 3h 10m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=127003=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127003 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 25/Jul/18 02:10 Start Date: 25/Jul/18 02:10 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-407610100 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 127003) Time Spent: 3h (was: 2h 50m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=127006=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127006 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 25/Jul/18 02:10 Start Date: 25/Jul/18 02:10 Worklog Time Spent: 10m Work Description: alanmyrvold removed a comment on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-406656952 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 127006) Time Spent: 3.5h (was: 3h 20m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=127004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127004 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 25/Jul/18 02:10 Start Date: 25/Jul/18 02:10 Worklog Time Spent: 10m Work Description: alanmyrvold removed a comment on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-407544663 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 127004) Time Spent: 3h 10m (was: 3h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 3h 10m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=126867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126867 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 24/Jul/18 20:41 Start Date: 24/Jul/18 20:41 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-407544800 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 126867) Time Spent: 2h 50m (was: 2h 40m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=126865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126865 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 24/Jul/18 20:40 Start Date: 24/Jul/18 20:40 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-407544663 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 126865) Time Spent: 2h 40m (was: 2.5h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=125565=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125565 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 20/Jul/18 16:40 Start Date: 20/Jul/18 16:40 Worklog Time Spent: 10m Work Description: alanmyrvold removed a comment on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-406363084 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 125565) Time Spent: 2.5h (was: 2h 20m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=125564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125564 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 20/Jul/18 16:40 Start Date: 20/Jul/18 16:40 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-406656952 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 125564) Time Spent: 2h 20m (was: 2h 10m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=125156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125156 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 19/Jul/18 17:58 Start Date: 19/Jul/18 17:58 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-406363084 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 125156) Time Spent: 2h 10m (was: 2h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[
https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124629=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124629
]
ASF GitHub Bot logged work on BEAM-4809:
Author: ASF GitHub Bot
Created on: 18/Jul/18 21:31
Start Date: 18/Jul/18 21:31
Worklog Time Spent: 10m
Work Description: alanmyrvold commented on a change in pull request
#5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit
URL: https://github.com/apache/beam/pull/5970#discussion_r203536609
##
File path: build.gradle
##
@@ -151,6 +151,7 @@ rat {
excludes = exclusions
}
check.dependsOn rat
+check.dependsOn ":beam-sdks-java-javadoc:allJavadoc"
Review comment:
Done, moved to BeamModulePlugin.groovy
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 124629)
Time Spent: 2h (was: 1h 50m)
> Java preCommit and postCommit should build javadoc to check it builds ok
>
>
> Key: BEAM-4809
> URL: https://issues.apache.org/jira/browse/BEAM-4809
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Affects Versions: 2.5.0
>Reporter: Alan Myrvold
>Assignee: Alan Myrvold
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Java preCommit and postCommit should build javadoc to check it builds ok
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[
https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124610=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124610
]
ASF GitHub Bot logged work on BEAM-4809:
Author: ASF GitHub Bot
Created on: 18/Jul/18 20:57
Start Date: 18/Jul/18 20:57
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5970:
[BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit
URL: https://github.com/apache/beam/pull/5970#discussion_r203526779
##
File path: build.gradle
##
@@ -151,6 +151,7 @@ rat {
excludes = exclusions
}
check.dependsOn rat
+check.dependsOn ":beam-sdks-java-javadoc:allJavadoc"
Review comment:
This means that the root project will check that all javadocs are well
formed which is typically something that we don't want to impose when running
`check` within the root project.
I think you meant to edit BeamModulePlugin.groovy and add:
`project.check.dependsOn project.javadoc` within `applyJavaNature`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 124610)
Time Spent: 1h 50m (was: 1h 40m)
> Java preCommit and postCommit should build javadoc to check it builds ok
>
>
> Key: BEAM-4809
> URL: https://issues.apache.org/jira/browse/BEAM-4809
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Affects Versions: 2.5.0
>Reporter: Alan Myrvold
>Assignee: Alan Myrvold
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Java preCommit and postCommit should build javadoc to check it builds ok
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124571=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124571 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 19:46 Start Date: 18/Jul/18 19:46 Worklog Time Spent: 10m Work Description: boyuanzz commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-406051726 Hey Alan, do we have enabled java spotless tasks in precommit and postcommit? If not, do you think we can add them into at least one of the check job? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124571) Time Spent: 1h 40m (was: 1.5h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124520=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124520 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 17:40 Start Date: 18/Jul/18 17:40 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-406014941 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124520) Time Spent: 1.5h (was: 1h 20m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124461=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124461 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 15:56 Start Date: 18/Jul/18 15:56 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405982195 Do you think it would be better to ensure that the `check` task depends on `javadoc` in each project. This way during the course of a normal build a user would get javadoc failures instead of only getting the failure during the precommit run? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124461) Time Spent: 1h 20m (was: 1h 10m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124445 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 15:31 Start Date: 18/Jul/18 15:31 Worklog Time Spent: 10m Work Description: alanmyrvold edited a comment on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405972678 Javadoc should be fixed by https://github.com/apache/beam/pull/5972 thanks to @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124445) Time Spent: 1h 10m (was: 1h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=12=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-12 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 15:30 Start Date: 18/Jul/18 15:30 Worklog Time Spent: 10m Work Description: alanmyrvold removed a comment on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405973204 @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 12) Time Spent: 1h (was: 50m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124443=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124443 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 15:30 Start Date: 18/Jul/18 15:30 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405973204 @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124443) Time Spent: 50m (was: 40m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124441 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 15:29 Start Date: 18/Jul/18 15:29 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405972678 Javadoc should be fixed by https://github.com/apache/beam/pull/5972 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124441) Time Spent: 40m (was: 0.5h) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124440=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124440 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 18/Jul/18 15:28 Start Date: 18/Jul/18 15:28 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405972528 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124440) Time Spent: 0.5h (was: 20m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124247 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 17/Jul/18 23:11 Start Date: 17/Jul/18 23:11 Worklog Time Spent: 10m Work Description: alanmyrvold commented on issue #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970#issuecomment-405757039 +R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124247) Time Spent: 20m (was: 10m) > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >Assignee: Alan Myrvold >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Java preCommit and postCommit should build javadoc to check it builds ok -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4809) Java preCommit and postCommit should build javadoc to check it builds ok
[ https://issues.apache.org/jira/browse/BEAM-4809?focusedWorklogId=124246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124246 ] ASF GitHub Bot logged work on BEAM-4809: Author: ASF GitHub Bot Created on: 17/Jul/18 23:10 Start Date: 17/Jul/18 23:10 Worklog Time Spent: 10m Work Description: alanmyrvold opened a new pull request #5970: [BEAM-4809] Build javadoc on :javaPreCommit and :javaPostCommit URL: https://github.com/apache/beam/pull/5970 Build javadoc on :javaPreCommit and :javaPostCommit to check it builds ok **Please** add a meaningful description for your change here --- Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124246) Time Spent: 10m Remaining Estimate: 0h > Java preCommit and postCommit should build javadoc to check it builds ok > > > Key: BEAM-4809 > URL: https://issues.apache.org/jira/browse/BEAM-4809 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.5.0 >Reporter: Alan Myrvold >
