Re: [PR] [CALCITE-5825] Add URL_ENCODE and URL_DECODE function (enabled in Spark library) [calcite]
sonarcloud[bot] commented on PR #3318: URL: https://github.com/apache/calcite/pull/3318#issuecomment-1782325018 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3318) [](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3318=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3318=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3318=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3318=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3318=new_coverage=list) [90.2% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3318=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3318=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3318=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]
caicancai commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782194355 cc @zabetak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]
sonarcloud[bot] commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782193228 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3488) [](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3488=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3488=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3488=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3488=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3488=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3488=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]
caicancai closed pull request #3488: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails URL: https://github.com/apache/calcite/pull/3488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]
caicancai opened a new pull request, #3488: URL: https://github.com/apache/calcite/pull/3488 fix #6075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
libenchao commented on PR #3486: URL: https://github.com/apache/calcite/pull/3486#issuecomment-1782093532 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
sonarcloud[bot] commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781828354 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3481) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3481=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3481=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3481=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_coverage=list) [79.0% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[calcite-site] branch main updated: Website deployed from calcite@0f824ed0045f9594959d459776177bb5f46d7620
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new fff66144f Website deployed from calcite@0f824ed0045f9594959d459776177bb5f46d7620 fff66144f is described below commit fff66144f196bce591723203c7e5bbc7f08038b4 Author: mihaibudiu AuthorDate: Thu Oct 26 19:52:19 2023 + Website deployed from calcite@0f824ed0045f9594959d459776177bb5f46d7620 --- community/index.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/community/index.html b/community/index.html index 1999c430f..de148790b 100644 --- a/community/index.html +++ b/community/index.html @@ -515,6 +515,12 @@ Hortonworks Committer + + Mihai Budiu (https://people.apache.org/phonebook.html?uid=mbudiu;>mbudiu) + https://github.com/mihaibudiu;>https://github.com/mihaibudiu.png;> + Feldera.com + Committer +
[calcite] branch site updated: [MINOR] Add Mihai Budiu to contributors list
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new a0181e81f8 [MINOR] Add Mihai Budiu to contributors list a0181e81f8 is described below commit a0181e81f89f2e247e3a3d8769ebbae9c4de64ff Author: Mihai Budiu AuthorDate: Thu Oct 26 12:50:03 2023 -0700 [MINOR] Add Mihai Budiu to contributors list Signed-off-by: Mihai Budiu --- site/_data/contributors.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/site/_data/contributors.yml b/site/_data/contributors.yml index 5562dee8ca..36022ca105 100644 --- a/site/_data/contributors.yml +++ b/site/_data/contributors.yml @@ -376,4 +376,9 @@ githubId: kgyrtkirk org: Hortonworks role: Committer +- name: Mihai Budiu + apacheId: mbudiu + githubId: mihaibudiu + org: Feldera.com + role: Committer # End contributors.yml
[calcite] branch main updated: [MINOR] Add Mihai Budiu to contributors list
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 0f824ed004 [MINOR] Add Mihai Budiu to contributors list 0f824ed004 is described below commit 0f824ed0045f9594959d459776177bb5f46d7620 Author: Mihai Budiu AuthorDate: Thu Oct 26 12:50:03 2023 -0700 [MINOR] Add Mihai Budiu to contributors list Signed-off-by: Mihai Budiu --- site/_data/contributors.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/site/_data/contributors.yml b/site/_data/contributors.yml index 5562dee8ca..36022ca105 100644 --- a/site/_data/contributors.yml +++ b/site/_data/contributors.yml @@ -376,4 +376,9 @@ githubId: kgyrtkirk org: Hortonworks role: Committer +- name: Mihai Budiu + apacheId: mbudiu + githubId: mihaibudiu + org: Feldera.com + role: Committer # End contributors.yml
Re: [PR] [MINOR] Add Mihai Budiu to contributors list [calcite]
mihaibudiu merged PR #3487: URL: https://github.com/apache/calcite/pull/3487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MINOR] Add Mihai Budiu to contributors list [calcite]
mihaibudiu opened a new pull request, #3487: URL: https://github.com/apache/calcite/pull/3487 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
sonarcloud[bot] commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781787373 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3481) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3481=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3481=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3481=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3481=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_coverage=list) [79.0% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3481=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]
sonarcloud[bot] commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781758539 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3459) [](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3459=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3459=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3459=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3459=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3459=new_coverage=list) [98.5% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3459=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3459=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3459=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781732860 I pushed a second commit re-enabling a few more tests. Now the PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781706791 Actually, I think I can cover a few more cases. Give me a bit more time to see if I can handle the string literal casts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781689711 I believe that this PR is ready for 1.36. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781688426 I have re-enabled a few tests that now pass, but not all, though a new commit. I won't assign CALCITE-2539 to myself, since it covers many other operations besides casts. I will file another issue to track the remaining cast cases and assign that to myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]
chucheng92 commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781572743 thank you all for patient reviewing! all comments are resolved. ci passed. @tanclary could you help to merge it? so we can add it in up-coming 1.36. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781565813 That bug also covers casts from VARCHAR to various numeric types, which I also didn't address in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
mihaibudiu commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1781559926 In this PR I have handled casts to values that are represented as Number in Java, but not DECIMAL. It looks like there are some bugs remaining there, including Bug.CALCITE_2539. I will assign that to myself. But I may have solved some cases covered by that bug in this PR. I will re-enable those tests. Expect a new commit today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]
sonarcloud[bot] commented on PR #3439: URL: https://github.com/apache/calcite/pull/3439#issuecomment-1781518461 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3439) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3439=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3439=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3439=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]
chucheng92 commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781498518 @tanclary Thanks for the reminder. I checked sonar report and problems are roughly divided into three categories: 1. Assignment of index i in for-loop 2. The MAP of SqlFunctions does not specify a generic type 3. Reuse string constants I have modified 1, but 2 and 3 actually not applicable for us. 2: The methods of SqlFunctions are all used by reflection. It can be written as generics or not. However, the current collection types Map and List are expressed using raw, and they tend to be consistent with them. 3: is something like "CHAR(10) NOT NULL", there are multiple checkScalar, sonar wants us to define a variable and reuse it. In fact, it is not necessary. The current way of writing is more intuitive. If you agree with these, I will squash the commits. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]
LakeShen commented on code in PR #3439:
URL: https://github.com/apache/calcite/pull/3439#discussion_r1373433134
##
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##
@@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join
originalJoin,
originalJoin, RelBuilder.proto(projectFactory));
}
+ /**
+ * Builds a new RelNode with the pushed conditions and remaining conditions.
+ *
+ * The pushed conditions will be pushed to the input of oldNode, and
+ * the remaining conditions will be keeped above the oldNode.
+ *
+ * @param builder RelBuilder
+ * @param oldNode original RelNode
+ * @param pushedConditions the conditions which pushed to the input of
oldNode
+ * @param remainingConditions the conditions which keeped above the oldNode
+ */
+ public static RelNode buildRelNodeWithConditions(final RelBuilder builder,
final RelNode oldNode,
+ final List pushedConditions, final List
remainingConditions) {
+RelNode rel =
+builder.push(oldNode.getInput(0)).filter(pushedConditions).build();
+if (rel == oldNode.getInput(0)) {
+ return oldNode;
+}
+rel = oldNode.copy(oldNode.getTraitSet(), ImmutableList.of(rel));
+rel = builder.push(rel).filter(remainingConditions).build();
+return rel;
+ }
+
Review Comment:
Now I move the `buildRelNodeWithConditions` to
`FilterAggregateTransposeRule`,and in `FilterAggregateTransposeRule` and
`FilterWindowTransposeRule` would use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]
LakeShen commented on code in PR #3439:
URL: https://github.com/apache/calcite/pull/3439#discussion_r1373424946
##
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##
@@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join
originalJoin,
originalJoin, RelBuilder.proto(projectFactory));
}
+ /**
+ * Builds a new RelNode with the pushed conditions and remaining conditions.
+ *
+ * The pushed conditions will be pushed to the input of oldNode, and
+ * the remaining conditions will be keeped above the oldNode.
+ *
+ * @param builder RelBuilder
+ * @param oldNode original RelNode
+ * @param pushedConditions the conditions which pushed to the input of
oldNode
+ * @param remainingConditions the conditions which keeped above the oldNode
+ */
+ public static RelNode buildRelNodeWithConditions(final RelBuilder builder,
final RelNode oldNode,
+ final List pushedConditions, final List
remainingConditions) {
+RelNode rel =
+builder.push(oldNode.getInput(0)).filter(pushedConditions).build();
+if (rel == oldNode.getInput(0)) {
+ return oldNode;
+}
+rel = oldNode.copy(oldNode.getTraitSet(), ImmutableList.of(rel));
+rel = builder.push(rel).filter(remainingConditions).build();
+return rel;
+ }
+
Review Comment:
Get your point,I will follow your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-5826] Add FIND_IN_SET function (enabled in Hive and Spark library) [calcite]
sonarcloud[bot] commented on PR #3317: URL: https://github.com/apache/calcite/pull/3317#issuecomment-1781321965 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3317) [](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3317=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3317=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3317=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3317=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3317=new_coverage=list) [98.0% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3317=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3317=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3317=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5826] Add FIND_IN_SET function (enabled in Hive and Spark library) [calcite]
herunkang2018 commented on code in PR #3317: URL: https://github.com/apache/calcite/pull/3317#discussion_r1373281355 ## site/_docs/reference.md: ## @@ -2729,6 +2729,7 @@ BigQuery's type system uses confusingly different names for types and functions: | o | EXTRACT(xml, xpath, [, namespaces ]) | Returns the XML fragment of the element or elements matched by the XPath expression. The optional namespace value that specifies a default mapping or namespace mapping for prefixes, which is used when evaluating the XPath expression | o | EXISTSNODE(xml, xpath, [, namespaces ])| Determines whether traversal of a XML document using a specified xpath results in any nodes. Returns 0 if no nodes remain after applying the XPath traversal on the document fragment of the element or elements matched by the XPath expression. Returns 1 if any nodes remain. The optional namespace value that specifies a default mapping or namespace mapping for prefixes, which is used when evaluating the XPath expression. | m | EXTRACTVALUE(xml, xpathExpr)) | Returns the text of the first text node which is a child of the element or elements matched by the XPath expression. +| h s | FIND_IN_SET(string, stringArray) | Returns the index (1-based) of the given *string* in the comma-delimited *stringArray*. Returns 0, if the given *string* was not found or if *string* contains a comma Review Comment: Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5826] Add FIND_IN_SET function (enabled in Hive and Spark library) [calcite]
herunkang2018 commented on code in PR #3317:
URL: https://github.com/apache/calcite/pull/3317#discussion_r1372602405
##
site/_docs/reference.md:
##
@@ -2729,6 +2729,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| o | EXTRACT(xml, xpath, [, namespaces ]) | Returns the XML
fragment of the element or elements matched by the XPath expression. The
optional namespace value that specifies a default mapping or namespace mapping
for prefixes, which is used when evaluating the XPath expression
| o | EXISTSNODE(xml, xpath, [, namespaces ])| Determines whether
traversal of a XML document using a specified xpath results in any nodes.
Returns 0 if no nodes remain after applying the XPath traversal on the document
fragment of the element or elements matched by the XPath expression. Returns 1
if any nodes remain. The optional namespace value that specifies a default
mapping or namespace mapping for prefixes, which is used when evaluating the
XPath expression.
| m | EXTRACTVALUE(xml, xpathExpr)) | Returns the text of the
first text node which is a child of the element or elements matched by the
XPath expression.
+| h s | FIND_IN_SET(string, stringArray) | Returns the index
(1-based) of the given *string* in the comma-delimited *stringArray*. Returns
0, if the given *string* was not found or if *string* contains a comma
Review Comment:
I think we can add an example to clarify it, like `FIND_IN_SET('bc',
'a,bc,def')` returns 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]
zabetak commented on code in PR #3439:
URL: https://github.com/apache/calcite/pull/3439#discussion_r1373234881
##
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##
@@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join
originalJoin,
originalJoin, RelBuilder.proto(projectFactory));
}
+ /**
+ * Builds a new RelNode with the pushed conditions and remaining conditions.
+ *
+ * The pushed conditions will be pushed to the input of oldNode, and
+ * the remaining conditions will be keeped above the oldNode.
+ *
+ * @param builder RelBuilder
+ * @param oldNode original RelNode
+ * @param pushedConditions the conditions which pushed to the input of
oldNode
+ * @param remainingConditions the conditions which keeped above the oldNode
+ */
+ public static RelNode buildRelNodeWithConditions(final RelBuilder builder,
final RelNode oldNode,
+ final List pushedConditions, final List
remainingConditions) {
+RelNode rel =
+builder.push(oldNode.getInput(0)).filter(pushedConditions).build();
+if (rel == oldNode.getInput(0)) {
+ return oldNode;
+}
+rel = oldNode.copy(oldNode.getTraitSet(), ImmutableList.of(rel));
+rel = builder.push(rel).filter(remainingConditions).build();
+return rel;
+ }
+
Review Comment:
It's not easy to see why this is a useful utility method. Moreover, it is
hard to understand what the method does without looking at the implementation.
At the moment, I would suggest reverting these changes and putting the code
back inside the rule which has less exposure. Whatever we add in `RelOptUtil`
class becomes public API that we need to support and maintain in every version
and I am not yet sure we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
sonarcloud[bot] commented on PR #3486: URL: https://github.com/apache/calcite/pull/3486#issuecomment-1781088395 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3486) [](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3486=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3486=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3486=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_calcite=3486=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3486=new_coverage=list) [83.3% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3486=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3486=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3486=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
rubenada commented on PR #3486: URL: https://github.com/apache/calcite/pull/3486#issuecomment-1781047870 This PR supersedes https://github.com/apache/calcite/pull/3390 FYI @libenchao @arkanovicz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
rubenada opened a new pull request, #3486: URL: https://github.com/apache/calcite/pull/3486 [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[calcite-site] branch main updated: Website deployed from calcite@8821eaf94b08dd5c55074b900201da7c386c1635
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new aedd90777 Website deployed from calcite@8821eaf94b08dd5c55074b900201da7c386c1635 aedd90777 is described below commit aedd900b2443aae10d75c54d68cd567f352a Author: zabetak AuthorDate: Thu Oct 26 10:22:31 2023 + Website deployed from calcite@8821eaf94b08dd5c55074b900201da7c386c1635 --- develop/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/develop/index.html b/develop/index.html index 7a126c088..e6b4cc1ce 100644 --- a/develop/index.html +++ b/develop/index.html @@ -104,7 +104,7 @@ producing bytecode for type annotations (see https://bugs.openjdk.java. Create a local copy of the Git repository, cd to its root directory, then build using Gradle: -$ git clone git://github.com/apache/calcite.git +$ git clone https://github.com/apache/calcite.git $ cd calcite $ ./gradlew build
[calcite] branch site updated: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new 35104e0c1c [CALCITE-6075] Site: Cloning source code from GitHub using
git protocol fails
35104e0c1c is described below
commit 35104e0c1c4f8b10e22c92205f1b3f3e3cd8584e
Author: caicancai <77189278+caican...@users.noreply.github.com>
AuthorDate: Thu Oct 26 17:25:40 2023 +0800
[CALCITE-6075] Site: Cloning source code from GitHub using git protocol
fails
GitHub removed the unecrypted git protocoli a while ago:
https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/
Close apache/calcite#3485
---
site/develop/index.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/site/develop/index.md b/site/develop/index.md
index 4ed681157f..180048afa9 100644
--- a/site/develop/index.md
+++ b/site/develop/index.md
@@ -54,7 +54,7 @@ Create a local copy of the Git repository, `cd` to its root
directory,
then build using Gradle:
{% highlight bash %}
-$ git clone git://github.com/apache/calcite.git
+$ git clone https://github.com/apache/calcite.git
$ cd calcite
$ ./gradlew build
{% endhighlight %}
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
zabetak closed pull request #3485: [CALCITE-6075] The git link to download the source code is incorrect URL: https://github.com/apache/calcite/pull/3485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[calcite] branch main updated: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 8821eaf94b [CALCITE-6075] Site: Cloning source code from GitHub using
git protocol fails
8821eaf94b is described below
commit 8821eaf94b08dd5c55074b900201da7c386c1635
Author: caicancai <77189278+caican...@users.noreply.github.com>
AuthorDate: Thu Oct 26 17:25:40 2023 +0800
[CALCITE-6075] Site: Cloning source code from GitHub using git protocol
fails
GitHub removed the unecrypted git protocoli a while ago:
https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/
Close apache/calcite#3485
---
site/develop/index.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/site/develop/index.md b/site/develop/index.md
index 4ed681157f..180048afa9 100644
--- a/site/develop/index.md
+++ b/site/develop/index.md
@@ -54,7 +54,7 @@ Create a local copy of the Git repository, `cd` to its root
directory,
then build using Gradle:
{% highlight bash %}
-$ git clone git://github.com/apache/calcite.git
+$ git clone https://github.com/apache/calcite.git
$ cd calcite
$ ./gradlew build
{% endhighlight %}
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
chucheng92 commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780823571 > Actually the `git://` URL is not invalid it just points to the use of the git protocol and I believe this used to work in the past. Any idea on why it is not working at the moment? > > Why do we need to switch to https? i think we can change to "g...@github.com:apache/calcite.git", it works. rather than 'https' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]
zabetak commented on code in PR #3480:
URL: https://github.com/apache/calcite/pull/3480#discussion_r1372866281
##
site/_docs/algebra.md:
##
@@ -309,10 +309,6 @@ LogicalRepeatUnion(all=[true])
LogicalTableScan(table=[[aux]])
{% endhighlight %}
-Note that there is no support for recursive queries in the SQL layer yet
-([CALCITE-129](https://issues.apache.org/jira/browse/CALCITE-129));
-the `WITH RECURSIVE` query above is only for illustrative purposes.
-
Review Comment:
I think the https://calcite.apache.org/docs/reference.html part of the
documentation should be updated as well to reflect the new changes.
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -7487,6 +7487,21 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
.checkUnchanged();
}
+ @Test void testRecursiveQuery() {
+final String sql = "WITH RECURSIVE aux(i) AS (\n"
++ " VALUES (1)\n"
++ " UNION ALL\n"
++ " SELECT i+1 FROM aux WHERE i < 10\n"
++ ")\n"
++ "SELECT * FROM aux";
+
+sql(sql)
+.withLateDecorrelate(true)
+.withTrim(true)
+.withRule() // empty program
+.checkUnchanged();
+ }
+
Review Comment:
We are not testing any rules here so the test seems misplaced. Consider
removing it.
##
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##
@@ -3304,6 +3305,29 @@ public static RelNode createProject(RelNode child,
Mappings.TargetMapping mappin
return createProject(projectFactory, child,
Mappings.asListNonNull(mapping.inverse()));
}
+ /** Returns the relational table node for {@code tableName} if it occurs
within a
+ * relational expression {@code root} otherwise an empty option is returned.
*/
+ public static Optional findTable(RelNode root, final String
tableName) {
Review Comment:
I don't think we use `Optional` much in the project. I don't have a strong
opinion for using it here or not but it seems that all the other methods in
this class are simply returning null so for keeping things more consistent I
would not add the wrapper.
##
core/src/main/java/org/apache/calcite/sql/SqlWithItem.java:
##
@@ -30,13 +30,16 @@
public class SqlWithItem extends SqlCall {
public SqlIdentifier name;
public @Nullable SqlNodeList columnList; // may be null
+ public SqlLiteral recursive;
public SqlNode query;
public SqlWithItem(SqlParserPos pos, SqlIdentifier name,
- @Nullable SqlNodeList columnList, SqlNode query) {
+ @Nullable SqlNodeList columnList, SqlNode query,
+ SqlLiteral recursive) {
Review Comment:
Do we want to keep previous constructor for backward compatibility purposes?
Please check other SqlNode classes and check if we are using a deprecation
pattern.
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -7487,6 +7487,21 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
.checkUnchanged();
}
+ @Test void testRecursiveQuery() {
+final String sql = "WITH RECURSIVE aux(i) AS (\n"
++ " VALUES (1)\n"
++ " UNION ALL\n"
++ " SELECT i+1 FROM aux WHERE i < 10\n"
++ ")\n"
++ "SELECT * FROM aux";
+
+sql(sql)
+.withLateDecorrelate(true)
+.withTrim(true)
+.withRule() // empty program
+.checkUnchanged();
+ }
+
Review Comment:
This seems like a test that should be added in `SqlToRelConverterTest` class.
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionTest.java:
##
@@ -45,6 +45,17 @@
*/
class EnumerableRepeatUnionTest {
+ @Test void testGenerateNumbersUsingSql() {
Review Comment:
The new tests added here are basically testing recursive queries end-to-end.
For end-to-end tests it is better to use the .iq files so consider moving the
tests in `recursive_queries.iq` and remove them from here unless there is a
specific reason to have them here.
##
core/src/main/java/org/apache/calcite/sql/validate/WithItemRecursiveNameSpace.java:
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
caicancai commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780778964 @chucheng92 Hello, there seems to be some errors in the cli at present, but I have not changed the code in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
chucheng92 commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780754565 > cc @chucheng92 , I just changed it directly in the makerdown file on github, but it was difficult to change it to the commit name. I'm sorry for this. you can use 'git commit --amend' to modify the local commit name. But you have reopened a new PR, maybe you can try this next time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
caicancai commented on PR #3485: URL: https://github.com/apache/calcite/pull/3485#issuecomment-1780747465 cc @chucheng92 , I just changed it directly in the makerdown file on github, but it was difficult to change it to the commit name. I'm sorry for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
sonarcloud[bot] commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780737442 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3484) [](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3484=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3484=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3484=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3484=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3484=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3484=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
caicancai commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780710186 ok , let me try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
chucheng92 commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780705060 @caicancai no need to close this PR. just change your local commit name and re-push it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
caicancai commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780702036 > could you change the commit name ? ok, I’ll submit a PR again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
caicancai closed pull request #3484: [CALCITE-6075] The git link to download the source code is incorrect URL: https://github.com/apache/calcite/pull/3484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6075] The git link to download the source code is incorrect [calcite]
chucheng92 commented on PR #3484: URL: https://github.com/apache/calcite/pull/3484#issuecomment-1780696984 NIT: could you change the commit name ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]
rubenada commented on PR #3481:
URL: https://github.com/apache/calcite/pull/3481#issuecomment-1780586778
Thanks for moving this forward @mihaibudiu . PR looks already in a good
shape, I'm sure it will make it into 1.36.
I just realized, there's another ticket which might be potentially related
to broken (i.e. skipped) tests in `SqlOperatorTest`: CALCITE-2539.
Could you please check if any of the tests inside
`SqlOperatorTest#testCastExactNumericLimits` or `testCastInvalid` which are
currently skipped via `if (Bug.CALCITE_2539_FIXED) { ... }` are actually fixed
with the current patch (and could be re-enabled)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]
rubenada commented on code in PR #3480:
URL: https://github.com/apache/calcite/pull/3480#discussion_r1372704477
##
core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties:
##
@@ -63,6 +63,8 @@ IncompatibleValueType=Values passed to {0} operator must have
compatible types
IncompatibleTypesInList=Values in expression list must have compatible types
IncompatibleCharset=Cannot apply {0} to the two different charsets {1} and {2}
InvalidOrderByPos=ORDER BY is only allowed on top-level SELECT
+RecursiveWithMustHaveUnionSetOp=A recursive query only supports UNION [ALL]
operator
Review Comment:
Would it be possible to have unit tests forcing to have these two error
messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]
rubenada commented on code in PR #3480:
URL: https://github.com/apache/calcite/pull/3480#discussion_r1372703471
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -5232,6 +5232,39 @@ void testReturnsCorrectRowTypeOnCombinedJoin() {
+ "select * from emp2")
.type(EMP_RECORD_TYPE);
+// simplest with recursive fails
+sql("with RECURSIVE emp2 as (select * from ^emp2^)\n"
++ "select * from emp2")
+.fails("Object 'EMP2' not found");
+
+sql("with RECURSIVE emp2 as ("
++ "select * from emp "
++ " union select * from ^emp2^"
++ " union select * from emp2"
++ ")\n"
++ "select * from emp2")
+.fails("Object 'EMP2' not found");
+
+// simplest with RECURSIVE working case.
+sql("with RECURSIVE emp2 as (select * from emp union select * from emp2)\n"
++ "select * from emp2")
+.type(EMP_RECORD_TYPE);
+
+// union all with recursive working case.
+sql("with RECURSIVE emp2 as (select * from emp union all select * from
emp2)\n"
++ "select * from emp2")
+.type(EMP_RECORD_TYPE);
+
+// union all with recursive working case.
Review Comment:
minor: this comment seems wrong ("working case" but the test actually checks
for a failure)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
