chucheng92 commented on PR #3459: URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781498518
@tanclary Thanks for the reminder. I checked sonar report and problems are roughly divided into three categories: 1. Assignment of index i in for-loop 2. The MAP of SqlFunctions does not specify a generic type 3. Reuse string constants I have modified 1, but 2 and 3 actually not applicable for us. 2: The methods of SqlFunctions are all used by reflection. It can be written as generics or not. However, the current collection types Map and List are expressed using raw, and they tend to be consistent with them. 3: is something like "CHAR(10) NOT NULL", there are multiple checkScalar, sonar wants us to define a variable and reuse it. In fact, it is not necessary. The current way of writing is more intuitive. If you agree with these, I will squash the commits. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
