Re: [PR] [CALCITE-6338] RelMdCollation#project can return an incomplete list of collations in the presence of aliasing [calcite]
rubenada merged PR #3739: URL: https://github.com/apache/calcite/pull/3739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6338] RelMdCollation#project can return an incomplete list of collations in the presence of aliasing [calcite]
rubenada commented on PR #3739: URL: https://github.com/apache/calcite/pull/3739#issuecomment-2016813767 @snuyanzin could you please take another look at the PR? Do you have any other comment? I plan to squash & merge in the next 24-48h if no further remarks arrive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6338] RelMdCollation#project can return an incomplete list of collations in the presence of aliasing [calcite]
rubenada commented on PR #3739: URL: https://github.com/apache/calcite/pull/3739#issuecomment-2014606439 Thanks for the review @snuyanzin . I have made some minor changes, based on some feedback in Jira. > It seems it never returns null, In that case should we remove @Nullable or replace it with @NonNull? I tried both removing @Nullable and replacing it with @NonNull, but in both cases CheckFramework failed (due to the annotations used by the method(s) called by this one). So I think it is not clever enough to grasp the situation (or I'm not clever enough to make it understand it). Since this annotation is not really a part of the fix, I propose to keep the original state in this regard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6338] RelMdCollation#project can return an incomplete list of collations in the presence of aliasing [calcite]
sonarcloud[bot] commented on PR #3739: URL: https://github.com/apache/calcite/pull/3739#issuecomment-2013549240 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3739) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite=3739=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_calcite=3739=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3739=false=true)  [94.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3739=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3739=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3739) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
