Re: [PR] [CALCITE-6274] Two Elasticsearch index join return empty result [calcite]
rubenada commented on code in PR #3696:
URL: https://github.com/apache/calcite/pull/3696#discussion_r1502433644
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchRules.java:
##
@@ -113,8 +113,7 @@ static List elasticsearchFieldNames(final
RelDataType rowType) {
return SqlValidatorUtil.uniquify(
new AbstractList() {
@Override public String get(int index) {
-final String name = rowType.getFieldList().get(index).getName();
-return name.startsWith("$") ? "_" + name.substring(2) : name;
+return rowType.getFieldList().get(index).getName();
Review Comment:
Before tearing down this chesterton fence... do we know what was the logic
behind this piece of code that you propose to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6274] Two Elasticsearch index join return empty result [calcite]
sonarcloud[bot] commented on PR #3696: URL: https://github.com/apache/calcite/pull/3696#issuecomment-1959418897 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3696) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3696=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3696=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3696=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3696=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3696) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6274] Two Elasticsearch index join return empty result [calcite]
sonarcloud[bot] commented on PR #3696: URL: https://github.com/apache/calcite/pull/3696#issuecomment-1955862733 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3696) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3696=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3696=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3696=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3696=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3696) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6274] Two Elasticsearch index join return empty result [calcite]
mihaibudiu commented on PR #3696: URL: https://github.com/apache/calcite/pull/3696#issuecomment-1955739784 The tools don't like the way you formatted your code; you can run ./gradlew build to find out what's wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6274] Two Elasticsearch index join return empty result [calcite]
sonarcloud[bot] commented on PR #3696: URL: https://github.com/apache/calcite/pull/3696#issuecomment-1954899207 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3696) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3696=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3696=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3696=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3696=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3696) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
