Re: [PR] Pojo beans in camel-catalog [camel]
davsclaus commented on code in PR #13491:
URL: https://github.com/apache/camel/pull/13491#discussion_r1599692282
##
components/camel-spring-redis/src/main/java/org/apache/camel/component/redis/processor/idempotent/SpringRedisIdempotentRepository.java:
##
@@ -95,7 +107,12 @@ public boolean confirm(String key) {
@Override
protected void doStart() throws Exception {
-// noop
+if (redisConfiguration == null) {
Review Comment:
Thanks
https://issues.apache.org/jira/browse/CAMEL-20767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Pojo beans in camel-catalog [camel]
rolandaskozakas commented on code in PR #13491:
URL: https://github.com/apache/camel/pull/13491#discussion_r1599555046
##
components/camel-spring-redis/src/main/java/org/apache/camel/component/redis/processor/idempotent/SpringRedisIdempotentRepository.java:
##
@@ -95,7 +107,12 @@ public boolean confirm(String key) {
@Override
protected void doStart() throws Exception {
-// noop
+if (redisConfiguration == null) {
Review Comment:
hello @davsclaus ,
After updating 4.4-4.5 this part seems to be failing.
Could you help me understand how this redisConfiguration should be
initialized here?
Because in my case it is just null which basically initializes redisTemplate
to default values.
What i am doing is:
```
@Bean
public SpringRedisStringIdempotentRepository
idempotentRepository(RedisTemplate redisTemplate) {
SpringRedisStringIdempotentRepository idempotentRepository = new
SpringRedisStringIdempotentRepository(redisTemplate, IDEMPOTENT_REPOSITORY_KEY);
idempotentRepository.setExpiry(1L);
return idempotentRepository;
}
```
Feedback appreciated!
##
components/camel-spring-redis/src/main/java/org/apache/camel/component/redis/processor/idempotent/SpringRedisIdempotentRepository.java:
##
@@ -95,7 +107,12 @@ public boolean confirm(String key) {
@Override
protected void doStart() throws Exception {
-// noop
+if (redisConfiguration == null) {
Review Comment:
hello @davsclaus ,
After updating 4.4->4.5 this part seems to be failing.
Could you help me understand how this redisConfiguration should be
initialized here?
Because in my case it is just null which basically initializes redisTemplate
to default values.
What i am doing is:
```
@Bean
public SpringRedisStringIdempotentRepository
idempotentRepository(RedisTemplate redisTemplate) {
SpringRedisStringIdempotentRepository idempotentRepository = new
SpringRedisStringIdempotentRepository(redisTemplate, IDEMPOTENT_REPOSITORY_KEY);
idempotentRepository.setExpiry(1L);
return idempotentRepository;
}
```
Feedback appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Pojo beans in camel-catalog [camel]
rolandaskozakas commented on code in PR #13491:
URL: https://github.com/apache/camel/pull/13491#discussion_r1599555046
##
components/camel-spring-redis/src/main/java/org/apache/camel/component/redis/processor/idempotent/SpringRedisIdempotentRepository.java:
##
@@ -95,7 +107,12 @@ public boolean confirm(String key) {
@Override
protected void doStart() throws Exception {
-// noop
+if (redisConfiguration == null) {
Review Comment:
hello @davsclaus ,
could you help me understand how this redisConfiguration should be
initialized here?
Because in my case it is just null which basically initializes redisTemplate
to default values.
What i am doing is:
```
@Bean
public SpringRedisStringIdempotentRepository
idempotentRepository(RedisTemplate redisTemplate) {
SpringRedisStringIdempotentRepository idempotentRepository = new
SpringRedisStringIdempotentRepository(redisTemplate, IDEMPOTENT_REPOSITORY_KEY);
idempotentRepository.setExpiry(1L);
return idempotentRepository;
}
```
Feedback appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Pojo beans in camel-catalog [camel]
davsclaus merged PR #13491: URL: https://github.com/apache/camel/pull/13491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Pojo beans in camel-catalog [camel]
github-actions[bot] commented on PR #13491: URL: https://github.com/apache/camel/pull/13491#issuecomment-1998107683 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Pojo beans in camel-catalog [camel]
davsclaus opened a new pull request, #13491: URL: https://github.com/apache/camel/pull/13491 # Description # Target - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
