[jira] [Comment Edited] (CASSANDRA-4561) update column family fails
[
https://issues.apache.org/jira/browse/CASSANDRA-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439328#comment-13439328
]
Zenek Kraweznik edited comment on CASSANDRA-4561 at 8/22/12 7:25 PM:
-
Hmmm, it's possible. How did you rebuilt system keyspace?
was (Author: zenek_kraweznik0):
Hmmm, it's possible. How have you rebuilt system keyspace?
update column family fails
--
Key: CASSANDRA-4561
URL: https://issues.apache.org/jira/browse/CASSANDRA-4561
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4
Reporter: Zenek Kraweznik
Assignee: Pavel Yaskevich
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
[default@test] update column family Messages with min_compaction_threshold =
4 and max_compaction_threshold = 32;
a5b7544e-1ef5-3bfd-8770-c09594e37ec2
Waiting for schema agreement...
... schemas agree across the cluster
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4561) update column family fails
[
https://issues.apache.org/jira/browse/CASSANDRA-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439374#comment-13439374
]
Pavel Yaskevich commented on CASSANDRA-4561:
Zenek, what version are you using? It's possible if you are on version less
than 1.1.3 or if you have created your schema before 1.1.3 because of
CASSANDRA-4432...
update column family fails
--
Key: CASSANDRA-4561
URL: https://issues.apache.org/jira/browse/CASSANDRA-4561
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4
Reporter: Zenek Kraweznik
Assignee: Pavel Yaskevich
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
[default@test] update column family Messages with min_compaction_threshold =
4 and max_compaction_threshold = 32;
a5b7544e-1ef5-3bfd-8770-c09594e37ec2
Waiting for schema agreement...
... schemas agree across the cluster
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4563) Remove nodetool setcachecapcity
[ https://issues.apache.org/jira/browse/CASSANDRA-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Yaskevich updated CASSANDRA-4563: --- Attachment: CASSANDRA-4563.patch Made 'setcachecapacity' command to change global capacities. Remove nodetool setcachecapcity --- Key: CASSANDRA-4563 URL: https://issues.apache.org/jira/browse/CASSANDRA-4563 Project: Cassandra Issue Type: Task Components: Core Affects Versions: 1.1.0 Reporter: Jeremy Hanna Assignee: Pavel Yaskevich Priority: Minor Labels: nodetool Fix For: 1.1.5 Attachments: CASSANDRA-4563.patch nodetool setcachecapacity is now obsolete so it should be removed as it confuses users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4377) CQL3 column value validation bug
[
https://issues.apache.org/jira/browse/CASSANDRA-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pavel Yaskevich updated CASSANDRA-4377:
---
Attachment: CASSANDRA-4377.patch
CQL3 defined CFs won't be exposed to Thrift API anymore (with warning), I also
checked CassandraServer and ThriftValidation and figured that column name
validation already in place via ThriftValidation.validateColumnNames(...).
CQL3 column value validation bug
Key: CASSANDRA-4377
URL: https://issues.apache.org/jira/browse/CASSANDRA-4377
Project: Cassandra
Issue Type: Bug
Components: API
Affects Versions: 1.1.1
Reporter: Nick Bailey
Assignee: Pavel Yaskevich
Labels: cql3
Fix For: 1.2.0
Attachments: 4377.txt, CASSANDRA-4377.patch
{noformat}
cqlsh create keyspace test with strategy_class = 'SimpleStrategy' and
strategy_options:replication_factor = 1;
cqlsh use test;
cqlsh:test CREATE TABLE stats (
... gid blob,
... period int,
... tid blob,
... sumint,
... uniques blob,
... PRIMARY KEY(gid, period, tid)
... );
cqlsh:test describe columnfamily stats;
CREATE TABLE stats (
gid blob PRIMARY KEY
) WITH
comment='' AND
comparator='CompositeType(org.apache.cassandra.db.marshal.Int32Type,org.apache.cassandra.db.marshal.BytesType,org.apache.cassandra.db.marshal.UTF8Type)'
AND
read_repair_chance=0.10 AND
gc_grace_seconds=864000 AND
default_validation=text AND
min_compaction_threshold=4 AND
max_compaction_threshold=32 AND
replicate_on_write='true' AND
compaction_strategy_class='SizeTieredCompactionStrategy' AND
compression_parameters:sstable_compression='SnappyCompressor';
{noformat}
You can see in the above output that the stats cf is created with the column
validator set to text, but neither of the non primary key columns defined are
text. It should either be setting metadata for those columns or not setting a
default validator or some combination of the two.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4561) update column family fails
[
https://issues.apache.org/jira/browse/CASSANDRA-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439394#comment-13439394
]
Zenek Kraweznik commented on CASSANDRA-4561:
I'm using 1.1.4, but schema was created in 0.8.5
Could you help me solve my problem step by step?
update column family fails
--
Key: CASSANDRA-4561
URL: https://issues.apache.org/jira/browse/CASSANDRA-4561
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4
Reporter: Zenek Kraweznik
Assignee: Pavel Yaskevich
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
[default@test] update column family Messages with min_compaction_threshold =
4 and max_compaction_threshold = 32;
a5b7544e-1ef5-3bfd-8770-c09594e37ec2
Waiting for schema agreement...
... schemas agree across the cluster
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4561) update column family fails
[
https://issues.apache.org/jira/browse/CASSANDRA-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439599#comment-13439599
]
Pavel Yaskevich commented on CASSANDRA-4561:
aha, so check system.schema_* CFs column's timestamp values I bet they are from
the future. The simplest fix for you would be to delete system/schema_*
SSTables and re-create a schema after restart.
update column family fails
--
Key: CASSANDRA-4561
URL: https://issues.apache.org/jira/browse/CASSANDRA-4561
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4
Reporter: Zenek Kraweznik
Assignee: Pavel Yaskevich
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
[default@test] update column family Messages with min_compaction_threshold =
4 and max_compaction_threshold = 32;
a5b7544e-1ef5-3bfd-8770-c09594e37ec2
Waiting for schema agreement...
... schemas agree across the cluster
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4561) update column family fails
[
https://issues.apache.org/jira/browse/CASSANDRA-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439603#comment-13439603
]
Jonathan Ellis commented on CASSANDRA-4561:
---
bq. check system.schema_* CFs column's timestamp values I bet they are from the
future
Can we fix that on startup for other upgraders?
update column family fails
--
Key: CASSANDRA-4561
URL: https://issues.apache.org/jira/browse/CASSANDRA-4561
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4
Reporter: Zenek Kraweznik
Assignee: Pavel Yaskevich
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
[default@test] update column family Messages with min_compaction_threshold =
4 and max_compaction_threshold = 32;
a5b7544e-1ef5-3bfd-8770-c09594e37ec2
Waiting for schema agreement...
... schemas agree across the cluster
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4561) update column family fails
[
https://issues.apache.org/jira/browse/CASSANDRA-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439607#comment-13439607
]
Pavel Yaskevich commented on CASSANDRA-4561:
Yes, I was about too :)
update column family fails
--
Key: CASSANDRA-4561
URL: https://issues.apache.org/jira/browse/CASSANDRA-4561
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4
Reporter: Zenek Kraweznik
Assignee: Pavel Yaskevich
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
[default@test] update column family Messages with min_compaction_threshold =
4 and max_compaction_threshold = 32;
a5b7544e-1ef5-3bfd-8770-c09594e37ec2
Waiting for schema agreement...
... schemas agree across the cluster
[default@test] show schema;
create column family Messages
with column_type = 'Standard'
and comparator = 'AsciiType'
and default_validation_class = 'BytesType'
and key_validation_class = 'AsciiType'
and read_repair_chance = 0.1
and dclocal_read_repair_chance = 0.0
and gc_grace = 864000
and min_compaction_threshold = 2
and max_compaction_threshold = 4
and replicate_on_write = true
and compaction_strategy =
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'
and caching = 'KEYS_ONLY'
and compaction_strategy_options = {'sstable_size_in_mb' : '1024'}
and compression_options = {'chunk_length_kb' : '64', 'sstable_compression'
: 'org.apache.cassandra.io.compress.DeflateCompressor'};
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4282) Improve startup time by making row cache population multi threaded
[
https://issues.apache.org/jira/browse/CASSANDRA-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-4282:
--
Attachment: 4282-v2.txt
v2 takes the approach of modifying CacheSerializer.deserialize to return a
Future. The row values are read on the read Stage instead of creating a new
ExecutorService.
Improve startup time by making row cache population multi threaded
--
Key: CASSANDRA-4282
URL: https://issues.apache.org/jira/browse/CASSANDRA-4282
Project: Cassandra
Issue Type: Improvement
Reporter: Marcus Eriksson
Priority: Minor
Fix For: 1.2.0
Attachments:
0001-improve-startup-time-by-multi-threading-row-cache-re.patch, 4282-v2.txt
Attached patch multi threads the row cache population
my small tests show improvements atleast;
{code}
- 4 cores
- 11G stress-generated data
- page cache dropped between runs
single platter spinning disk:
single threaded:
INFO 10:18:21,365 completed loading (245562 ms; 311381 keys) row cache for
Keyspace1.Standard1
INFO 10:32:43,738 completed loading (255106 ms; 311381 keys) row cache for
Keyspace1.Standard1
multi threaded:
INFO 10:22:47,567 completed loading (213905 ms; 311381 keys) row cache for
Keyspace1.Standard1
INFO 10:27:26,873 completed loading (214514 ms; 311381 keys) row cache for
Keyspace1.Standard1
ssd;
single threaded:
INFO 10:40:49,079 completed loading (103883 ms; 311381 keys) row cache for
Keyspace1.Standard1
INFO 10:43:45,799 completed loading (106913 ms; 311381 keys) row cache for
Keyspace1.Standard1
multi threaded:
INFO 10:38:20,798 completed loading (57617 ms; 311381 keys) row cache for
Keyspace1.Standard1
INFO 10:47:20,339 completed loading (56682 ms; 311381 keys) row cache for
Keyspace1.Standard1
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3515) track tombstones skipped on read path
[
https://issues.apache.org/jira/browse/CASSANDRA-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-3515:
--
Attachment: 3515.txt
Logging attached, as noted this will be more useful soon with CASSANDRA-1123.
track tombstones skipped on read path
-
Key: CASSANDRA-3515
URL: https://issues.apache.org/jira/browse/CASSANDRA-3515
Project: Cassandra
Issue Type: Improvement
Reporter: Jackson Chung
Priority: Minor
Fix For: 1.2.0
Attachments: 3515.txt
i think summary says it all, but see further:
{noformat}
driftx x: I guess we could add a histogram of how many tombstones we
filtered on a read
driftx x: @action: go for it in that context
action jackson: thx!
mdennis x: +1 on histogram of filtered tombstones
driftx x: definitely useful for diagnosing the queue-like case
driftx x: the histogram I mea
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[2/4] git commit: bump java7 stack size to 180; see #4457
bump java7 stack size to 180; see #4457 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8173c6f6 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8173c6f6 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8173c6f6 Branch: refs/heads/cassandra-1.1 Commit: 8173c6f64a5e10b6369e2cf3b8fc9aaeec677c09 Parents: aa81f84 Author: Jonathan Ellis jbel...@apache.org Authored: Wed Aug 22 10:34:42 2012 -0500 Committer: Jonathan Ellis jbel...@apache.org Committed: Wed Aug 22 10:34:46 2012 -0500 -- CHANGES.txt |1 + conf/cassandra-env.sh |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/8173c6f6/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 2ea901f..3c7163a 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 1.1.5 + * increase stack size under Java7 to 180K * Log(info) schema changes (CASSANDRA-4547) http://git-wip-us.apache.org/repos/asf/cassandra/blob/8173c6f6/conf/cassandra-env.sh -- diff --git a/conf/cassandra-env.sh b/conf/cassandra-env.sh index 6ae28a0..ff3fc86 100644 --- a/conf/cassandra-env.sh +++ b/conf/cassandra-env.sh @@ -186,7 +186,7 @@ if [ `uname` = Linux ] ; then # supported. if startswith $JVM_VERSION '1.7.' then -JVM_OPTS=$JVM_OPTS -Xss160k +JVM_OPTS=$JVM_OPTS -Xss180k else JVM_OPTS=$JVM_OPTS -Xss128k fi
[4/4] git commit: change cache write progress check to cache type basis; patch by yukim, reviewed by jbellis for CASSANDRA-4533
change cache write progress check to cache type basis; patch by yukim,
reviewed by jbellis for CASSANDRA-4533
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/aa81f84c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/aa81f84c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/aa81f84c
Branch: refs/heads/trunk
Commit: aa81f84c38f2c1fcad08eae955bec031341f8f75
Parents: 5655d97
Author: Yuki Morishita yu...@apache.org
Authored: Wed Aug 22 08:55:46 2012 -0500
Committer: Yuki Morishita yu...@apache.org
Committed: Wed Aug 22 08:55:58 2012 -0500
--
.../apache/cassandra/cache/AutoSavingCache.java|8 +++-
.../cassandra/db/compaction/CompactionManager.java |4 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/aa81f84c/src/java/org/apache/cassandra/cache/AutoSavingCache.java
--
diff --git a/src/java/org/apache/cassandra/cache/AutoSavingCache.java
b/src/java/org/apache/cassandra/cache/AutoSavingCache.java
index 004e46e..b4e77be 100644
--- a/src/java/org/apache/cassandra/cache/AutoSavingCache.java
+++ b/src/java/org/apache/cassandra/cache/AutoSavingCache.java
@@ -27,6 +27,7 @@ import java.util.concurrent.Future;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
+import org.cliffc.high_scale_lib.NonBlockingHashSet;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -49,7 +50,7 @@ public class AutoSavingCacheK extends CacheKey, V extends
InstrumentingCacheK
private static final Logger logger =
LoggerFactory.getLogger(AutoSavingCache.class);
/** True if a cache flush is currently executing: only one may execute at
a time. */
-public static final AtomicBoolean flushInProgress = new
AtomicBoolean(false);
+public static final SetCacheService.CacheType flushInProgress = new
NonBlockingHashSetCacheService.CacheType();
protected volatile ScheduledFuture? saveTask;
protected final CacheService.CacheType cacheType;
@@ -200,6 +201,11 @@ public class AutoSavingCacheK extends CacheKey, V
extends InstrumentingCacheK
estimatedTotalBytes);
}
+public CacheService.CacheType cacheType()
+{
+return cacheType;
+}
+
public CompactionInfo getCompactionInfo()
{
long bytesWritten = this.bytesWritten;
http://git-wip-us.apache.org/repos/asf/cassandra/blob/aa81f84c/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
index 0f5be39..fcdf45b 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
@@ -773,7 +773,7 @@ public class CompactionManager implements
CompactionManagerMBean
{
public void runMayThrow() throws IOException
{
-if (!AutoSavingCache.flushInProgress.compareAndSet(false,
true))
+if (!AutoSavingCache.flushInProgress.add(writer.cacheType()))
{
logger.debug(Cache flushing was already in progress:
skipping {}, writer.getCompactionInfo());
return;
@@ -792,7 +792,7 @@ public class CompactionManager implements
CompactionManagerMBean
}
finally
{
-AutoSavingCache.flushInProgress.set(false);
+AutoSavingCache.flushInProgress.remove(writer.cacheType());
}
}
};
[1/4] git commit: Merge branch 'cassandra-1.1' into trunk
Updated Branches: refs/heads/cassandra-1.1 aa81f84c3 - 8173c6f64 refs/heads/trunk e1fef7248 - 66d52f9d2 Merge branch 'cassandra-1.1' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/66d52f9d Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/66d52f9d Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/66d52f9d Branch: refs/heads/trunk Commit: 66d52f9d2742877a31df3b05cf3a3fe8fe72377e Parents: e1fef72 8173c6f Author: Jonathan Ellis jbel...@apache.org Authored: Wed Aug 22 10:34:57 2012 -0500 Committer: Jonathan Ellis jbel...@apache.org Committed: Wed Aug 22 10:34:57 2012 -0500 -- CHANGES.txt|1 + conf/cassandra-env.sh |2 +- .../apache/cassandra/cache/AutoSavingCache.java|8 +++- .../cassandra/db/compaction/CompactionManager.java |4 ++-- 4 files changed, 11 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/66d52f9d/CHANGES.txt -- diff --cc CHANGES.txt index d9d67e4,3c7163a..7c0aa32 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,48 -1,5 +1,49 @@@ +1.2-dev + * Make compaction, flush JBOD-aware (CASSANDRA-4292) + * run local range scans on the read stage (CASSANDRA-3687) + * clean up ioexceptions (CASSANDRA-2116) + * Introduce new json format with row level deletion (CASSANDRA-4054) + * remove redundant name column from schema_keyspaces (CASSANDRA-4433) + * improve nodetool ring handling of multi-dc clusters (CASSANDRA-3047) + * update NTS calculateNaturalEndpoints to be O(N log N) (CASSANDRA-3881) + * add UseCondCardMark XX jvm settings on jdk 1.7 (CASSANDRA-4366) + * split up rpc timeout by operation type (CASSANDRA-2819) + * rewrite key cache save/load to use only sequential i/o (CASSANDRA-3762) + * update MS protocol with a version handshake + broadcast address id + (CASSANDRA-4311) + * multithreaded hint replay (CASSANDRA-4189) + * add inter-node message compression (CASSANDRA-3127) + * remove COPP (CASSANDRA-2479) + * Track tombstone expiration and compact when tombstone content is + higher than a configurable threshold, default 20% (CASSANDRA-3442, 4234) + * update MurmurHash to version 3 (CASSANDRA-2975) + * (CLI) track elapsed time for `delete' operation (CASSANDRA-4060) + * (CLI) jline version is bumped to 1.0 to properly support + 'delete' key function (CASSANDRA-4132) + * Save IndexSummary into new SSTable 'Summary' component (CASSANDRA-2392, 4289) + * Add support for range tombstones (CASSANDRA-3708) + * Improve MessagingService efficiency (CASSANDRA-3617) + * Avoid ID conflicts from concurrent schema changes (CASSANDRA-3794) + * Set thrift HSHA server thread limit to unlimited by default (CASSANDRA-4277) + * Avoids double serialization of CF id in RowMutation messages + (CASSANDRA-4293) + * stream compressed sstables directly with java nio (CASSANDRA-4297) + * Support multiple ranges in SliceQueryFilter (CASSANDRA-3885) + * Add column metadata to system column families (CASSANDRA-4018) + * (cql3) Always use composite types by default (CASSANDRA-4329) + * (cql3) Add support for set, map and list (CASSANDRA-3647) + * Validate date type correctly (CASSANDRA-4441) + * (cql3) Allow definitions with only a PK (CASSANDRA-4361) + * (cql3) Add support for row key composites (CASSANDRA-4179) + * improve DynamicEndpointSnitch by using reservoir sampling (CASSANDRA-4038) + * (cql3) Add support for 2ndary indexes (CASSANDRA-3680) + * (cql3) fix defining more than one PK to be invalid (CASSANDRA-4477) + * remove schema agreement checking from all external APIs (Thrift, CQL and CQL3) (CASSANDRA-4487) + * add Murmur3Partitioner and make it default for new installations (CASSANDRA-3772) + + 1.1.5 + * increase stack size under Java7 to 180K * Log(info) schema changes (CASSANDRA-4547) http://git-wip-us.apache.org/repos/asf/cassandra/blob/66d52f9d/src/java/org/apache/cassandra/cache/AutoSavingCache.java -- diff --cc src/java/org/apache/cassandra/cache/AutoSavingCache.java index ec054fb,b4e77be..7ce2beb --- a/src/java/org/apache/cassandra/cache/AutoSavingCache.java +++ b/src/java/org/apache/cassandra/cache/AutoSavingCache.java @@@ -201,17 -198,23 +202,22 @@@ public class AutoSavingCacheK extends info = new CompactionInfo(new CFMetaData(system, cacheType.toString(), null, null, null), type, 0, - estimatedTotalBytes); + keys.size(), +
[3/4] git commit: bump java7 stack size to 180; see #4457
bump java7 stack size to 180; see #4457 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8173c6f6 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8173c6f6 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8173c6f6 Branch: refs/heads/trunk Commit: 8173c6f64a5e10b6369e2cf3b8fc9aaeec677c09 Parents: aa81f84 Author: Jonathan Ellis jbel...@apache.org Authored: Wed Aug 22 10:34:42 2012 -0500 Committer: Jonathan Ellis jbel...@apache.org Committed: Wed Aug 22 10:34:46 2012 -0500 -- CHANGES.txt |1 + conf/cassandra-env.sh |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/8173c6f6/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 2ea901f..3c7163a 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 1.1.5 + * increase stack size under Java7 to 180K * Log(info) schema changes (CASSANDRA-4547) http://git-wip-us.apache.org/repos/asf/cassandra/blob/8173c6f6/conf/cassandra-env.sh -- diff --git a/conf/cassandra-env.sh b/conf/cassandra-env.sh index 6ae28a0..ff3fc86 100644 --- a/conf/cassandra-env.sh +++ b/conf/cassandra-env.sh @@ -186,7 +186,7 @@ if [ `uname` = Linux ] ; then # supported. if startswith $JVM_VERSION '1.7.' then -JVM_OPTS=$JVM_OPTS -Xss160k +JVM_OPTS=$JVM_OPTS -Xss180k else JVM_OPTS=$JVM_OPTS -Xss128k fi
[jira] [Commented] (CASSANDRA-4457) Find the cause for the need for a larger stack size with jdk 7
[ https://issues.apache.org/jira/browse/CASSANDRA-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439620#comment-13439620 ] Jonathan Ellis commented on CASSANDRA-4457: --- Bumped java7 stack size to 180 in 1.1.5 Find the cause for the need for a larger stack size with jdk 7 -- Key: CASSANDRA-4457 URL: https://issues.apache.org/jira/browse/CASSANDRA-4457 Project: Cassandra Issue Type: Bug Reporter: Jeremy Hanna Priority: Minor Based on discussions post CASSANDRA-4275, it appears that on jdk 7 that the minimum stack size needs to be set to something higher than 160k. That shouldn't be necessary. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3772) Evaluate Murmur3-based partitioner
[ https://issues.apache.org/jira/browse/CASSANDRA-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439624#comment-13439624 ] Jonathan Ellis commented on CASSANDRA-3772: --- Looks like it's worth prototyping, LongPartitioner should be very straightforward If there's no performance advantage though we can leave it out Evaluate Murmur3-based partitioner -- Key: CASSANDRA-3772 URL: https://issues.apache.org/jira/browse/CASSANDRA-3772 Project: Cassandra Issue Type: New Feature Components: Core Reporter: Jonathan Ellis Assignee: Pavel Yaskevich Fix For: 1.2.0 Attachments: 0001-CASSANDRA-3772.patch, 0001-CASSANDRA-3772-Test.patch, CASSANDRA-3772-v2.patch, CASSANDRA-3772-v3.patch, hashed_partitioner_3.diff, hashed_partitioner.diff, MumPartitionerTest.docx, try_murmur3_2.diff, try_murmur3.diff MD5 is a relatively heavyweight hash to use when we don't need cryptographic qualities, just a good output distribution. Let's see how much overhead we can save by using Murmur3 instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-4566) test-clientutil target is failing
Eric Evans created CASSANDRA-4566:
-
Summary: test-clientutil target is failing
Key: CASSANDRA-4566
URL: https://issues.apache.org/jira/browse/CASSANDRA-4566
Project: Cassandra
Issue Type: Bug
Components: Packaging, Tools
Affects Versions: 1.2.0
Reporter: Eric Evans
Priority: Blocker
The {{test-clientutil}} target is failing (on trunk at least):
{noformat}
[junit] java.lang.NoClassDefFoundError:
org/apache/cassandra/io/IVersionedSerializer
[junit] at java.lang.ClassLoader.defineClass1(Native Method)
[junit] at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
[junit] at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[junit] at org.apache.cassandra.utils.UUIDGen.clinit(UUIDGen.java:38)
[junit] at
org.apache.cassandra.cql.jdbc.ClientUtilsTest.test(ClientUtilsTest.java:59)
[junit] Caused by: java.lang.ClassNotFoundException:
org.apache.cassandra.io.IVersionedSerializer
[junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[junit] at java.security.AccessController.doPrivileged(Native Method)
[junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
{noformat}
This target is to ensure that the clientutil jar has no unsatisfied
dependencies. In this case it looks like static initialization is pulling in
{{o.a.c.io.IVersionedSerializer}}, (probably transitively).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3772) Evaluate Murmur3-based partitioner
[ https://issues.apache.org/jira/browse/CASSANDRA-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439630#comment-13439630 ] Jonathan Ellis commented on CASSANDRA-3772: --- Have a look at BigInteger source, it's about 3x as large as a Long. compareTo is also more complex. Evaluate Murmur3-based partitioner -- Key: CASSANDRA-3772 URL: https://issues.apache.org/jira/browse/CASSANDRA-3772 Project: Cassandra Issue Type: New Feature Components: Core Reporter: Jonathan Ellis Assignee: Pavel Yaskevich Fix For: 1.2.0 Attachments: 0001-CASSANDRA-3772.patch, 0001-CASSANDRA-3772-Test.patch, CASSANDRA-3772-v2.patch, CASSANDRA-3772-v3.patch, hashed_partitioner_3.diff, hashed_partitioner.diff, MumPartitionerTest.docx, try_murmur3_2.diff, try_murmur3.diff MD5 is a relatively heavyweight hash to use when we don't need cryptographic qualities, just a good output distribution. Let's see how much overhead we can save by using Murmur3 instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4563) Remove nodetool setcachecapcity
[ https://issues.apache.org/jira/browse/CASSANDRA-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439646#comment-13439646 ] Brandon Williams commented on CASSANDRA-4563: - +1 Remove nodetool setcachecapcity --- Key: CASSANDRA-4563 URL: https://issues.apache.org/jira/browse/CASSANDRA-4563 Project: Cassandra Issue Type: Task Components: Core Affects Versions: 1.1.0 Reporter: Jeremy Hanna Assignee: Pavel Yaskevich Priority: Minor Labels: nodetool Fix For: 1.1.5 Attachments: CASSANDRA-4563.patch nodetool setcachecapacity is now obsolete so it should be removed as it confuses users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-4567) Error in log related to Murmer3Partitioner
Tyler Patterson created CASSANDRA-4567:
--
Summary: Error in log related to Murmer3Partitioner
Key: CASSANDRA-4567
URL: https://issues.apache.org/jira/browse/CASSANDRA-4567
Project: Cassandra
Issue Type: Bug
Environment: Using ccm on ubuntu
Reporter: Tyler Patterson
Start a 2-node cluster on cassandra-1.1. Bring down one node, upgrade it to
trunk, start it back up. The following error shows up in the log:
{code}
...
INFO [main] 2012-08-22 10:44:40,012 CacheService.java (line 170) Scheduling
row cache save to each 0 seconds (going to save all keys).
INFO [SSTableBatchOpen:1] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
(148 bytes)
INFO [SSTableBatchOpen:2] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
(226 bytes)
INFO [SSTableBatchOpen:3] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
(89 bytes)
ERROR [SSTableBatchOpen:3] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:3,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
because partitioner does not match org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:2] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:2,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
because partitioner does not match org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:1] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:1,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
because partitioner does not match org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
INFO [main] 2012-08-22 10:44:40,486 DatabaseDescriptor.java (line 522)
Couldn't detect any schema definitions in local storage.
INFO [main] 2012-08-22 10:44:40,487 DatabaseDescriptor.java (line 525) Found
table data in data directories. Consider using the CLI to define your schema.
...
{code}
Note that the error does not happen when upgrading from cassandra-1.0 to
cassandra-1.1, or when upgrading from trunk to trunk.
This is the exact dtest I used:
{code}
from dtest import Tester, debug
FROM_VERSION = 'git:cassandra-1.1'
TO_VERSION =
[jira] [Commented] (CASSANDRA-4565) TTL columns with older then gcgrace do not need to flush
[ https://issues.apache.org/jira/browse/CASSANDRA-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439712#comment-13439712 ] Edward Capriolo commented on CASSANDRA-4565: Never mind means this does not need to be done. The method called earlier in the flush process. cf.maybeResetDeletionTimes(gcBefore); converts ExpiredColumns past their grace into DeletedColumns and then they do not get flushed. We could keep the test case if to be sure this functionality stays working. Also the condition: c.getLocalDeletionTime() gcBefore Makes no sense to me gcBefore is defined as Integer.MIN_VALUE so this condition looks like it can never be met. TTL columns with older then gcgrace do not need to flush Key: CASSANDRA-4565 URL: https://issues.apache.org/jira/browse/CASSANDRA-4565 Project: Cassandra Issue Type: Improvement Reporter: Edward Capriolo Assignee: Edward Capriolo Fix For: 1.3 Attachments: cassandra-4565.patch.1.txt With memcache many people are willing to sacrifice durability for performance. Cassandra has a TimeToLive feature that can be used in caching scenarios with low values for gc_grace_seconds. However from a code dive it seems that cassandra will always write TTL to disk, even those that are beyond gc_grace_seconds. If a use case very large memtables,small ttl, and small gc_grace it is possible that flushing these columns to disk can be skipped entirely in some scenarios. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4559) implement token relocation
[
https://issues.apache.org/jira/browse/CASSANDRA-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439719#comment-13439719
]
Brandon Williams edited comment on CASSANDRA-4559 at 8/23/12 5:01 AM:
--
Won't we want to be able to relocate more than one token at a time?
Also, it seems like we could re-use the moving status, or remove it if we want
to rename the functionality, since doing it in a mixed cluster will never be
supported.
was (Author: brandon.williams):
Won't we want to be able to relocate more than one token at a time?
Also, it seems like we re-use the moving status, or remove it if we want to
rename the functionality, since doing it in a mixed cluster will never be
supported.
implement token relocation
--
Key: CASSANDRA-4559
URL: https://issues.apache.org/jira/browse/CASSANDRA-4559
Project: Cassandra
Issue Type: Sub-task
Components: Core, Tools
Reporter: Eric Evans
Assignee: Eric Evans
Labels: vnodes
Whatever the specifics of a _shuffle_ (see CASSANDRA-4443), it will be
necessary to relocate a range from one node to another.
_Edit0: Linked in new patch containing tests._
h3. Patches
||Compare||Raw diff||Description||
|[010_refactor_range_move|https://github.com/acunu/cassandra/compare/top-bases/p/4443/010_refactor_range_move...p/4443/010_refactor_range_move]|[010_refactor_range_move.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/010_refactor_range_move...p/4443/010_refactor_range_move.diff]|No
Description|
|[020_calculate_pending|https://github.com/acunu/cassandra/compare/top-bases/p/4443/020_calculate_pending...p/4443/020_calculate_pending]|[020_calculate_pending.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/020_calculate_pending...p/4443/020_calculate_pending.diff]|No
Description|
|[030_relocate_token|https://github.com/acunu/cassandra/compare/top-bases/p/4443/030_relocate_token...p/4443/030_relocate_token]|[030_relocate_token.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/030_relocate_token...p/4443/030_relocate_token.diff]|No
Description|
|[040_tests|https://github.com/acunu/cassandra/compare/top-bases/p/4443/040_tests...p/4443/040_tests]|[040_tests.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/040_tests...p/4443/040_tests.diff]|No
Description|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4568) countPendingHints JMX operation is returning garbage for the key
[
https://issues.apache.org/jira/browse/CASSANDRA-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.B. Langston updated CASSANDRA-4568:
-
Description:
countPendingHints JMX operation should return a map from key: endpoint IP
address to value: number of pending hints. It is returning garbage for the key
(looks like binary data concerning the hint itself). The value looks correct.
Steps to reproduce:
1) Set up a two-node cluster.
2) Disable gossip on the second node.
`nodetool ring` output from node 1:
Address DC RackStatus State Load
Effective-Ownership Token
85070591730234615865843651857942052864
192.168.1.162 datacenter1 rack1 Up Normal 21.46 KB100.00%
0
192.168.1.130 datacenter1 rack1 Down Normal 6.67 KB 100.00%
85070591730234615865843651857942052864
3) While the second node is still down, create a keyspace with RF=2 and a CF
within this keyspace. Then insert two records into the CF:
Connected to Test Cluster at 192.168.1.162:9160.
[cqlsh 2.2.0 | Cassandra 1.1.2 | CQL spec 2.0.0 | Thrift protocol 19.32.0]
Use HELP for help.
cqlsh create KEYSPACE demo WITH strategy_class = 'SimpleStrategy' AND
strategy_options:replication_factor = 2;
cqlsh use demo;
cqlsh:demo create table users (username varchar primary key, password varchar);
cqlsh:demo insert into users (username, password) values (scott, tiger);
cqlsh:demo insert into users (username, password) values (root, password);
4) Use a JMX client to execute the countPendingHints operation:
jblangston:~ jblangston$ java -jar cmdline-jmxclient-0.10.3.jar -
localhost:7199 org.apache.cassandra.db:type=HintedHandoffManager
countPendingHints
08/22/2012 14:21:37 -0500 org.archive.jmx.Client countPendingHints: {@B^h ??
?[b??scottdemoscott?password?ߞHtigerdemoF
?P???[b??rootdemoroot?password?ߞ?Wpassworddemo=2}
5) Notice the output. The value (2) is correct but the key is garbage instead
of an endpoint IP address.
was:
countPendingHints JMX operation should return a map from key: endpoint IP
address to value: number of pending hints. It is returning garbage for the key
(looks like binary data concerning the hint itself). The value looks correct.
Steps to reproduce:
1) Set up a two-node cluster. Disable gossip on the second node.
`nodetool ring` output from node 1:
Address DC RackStatus State Load
Effective-Ownership Token
85070591730234615865843651857942052864
192.168.1.162 datacenter1 rack1 Up Normal 21.46 KB100.00%
0
192.168.1.130 datacenter1 rack1 Down Normal 6.67 KB 100.00%
85070591730234615865843651857942052864
2) While the second node is still down, create a keyspace with RF=2 and a CF
within this keyspace. Then insert two records into the CF:
Connected to Test Cluster at 192.168.1.162:9160.
[cqlsh 2.2.0 | Cassandra 1.1.2 | CQL spec 2.0.0 | Thrift protocol 19.32.0]
Use HELP for help.
cqlsh create KEYSPACE demo WITH strategy_class = 'SimpleStrategy' AND
strategy_options:replication_factor = 2;
cqlsh use demo;
cqlsh:demo create table users (username varchar primary key, password varchar);
cqlsh:demo insert into users (username, password) values (scott, tiger);
cqlsh:demo insert into users (username, password) values (root, password);
3) Use a JMX client to execute the countPendingHints operation:
jblangston:~ jblangston$ java -jar cmdline-jmxclient-0.10.3.jar -
localhost:7199 org.apache.cassandra.db:type=HintedHandoffManager
countPendingHints
08/22/2012 14:21:37 -0500 org.archive.jmx.Client countPendingHints: {@B^h ??
?[b??scottdemoscott?password?ߞHtigerdemoF
?P???[b??rootdemoroot?password?ߞ?Wpassworddemo=2}
4) Notice output. The value (2) is correct but the key is garbage instead of
an endpoint IP address.
countPendingHints JMX operation is returning garbage for the key
Key: CASSANDRA-4568
URL: https://issues.apache.org/jira/browse/CASSANDRA-4568
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.0.10, 1.1.2
Reporter: J.B. Langston
Priority: Minor
countPendingHints JMX operation should return a map from key: endpoint IP
address to value: number of pending hints. It is returning garbage for the
key (looks like binary data concerning the hint
[jira] [Created] (CASSANDRA-4568) countPendingHints JMX operation is returning garbage for the key
J.B. Langston created CASSANDRA-4568:
Summary: countPendingHints JMX operation is returning garbage for
the key
Key: CASSANDRA-4568
URL: https://issues.apache.org/jira/browse/CASSANDRA-4568
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.2, 1.0.10
Reporter: J.B. Langston
Priority: Minor
countPendingHints JMX operation should return a map from key: endpoint IP
address to value: number of pending hints. It is returning garbage for the key
(looks like binary data concerning the hint itself). The value looks correct.
Steps to reproduce:
1) Set up a two-node cluster. Disable gossip on the second node.
`nodetool ring` output from node 1:
Address DC RackStatus State Load
Effective-Ownership Token
85070591730234615865843651857942052864
192.168.1.162 datacenter1 rack1 Up Normal 21.46 KB100.00%
0
192.168.1.130 datacenter1 rack1 Down Normal 6.67 KB 100.00%
85070591730234615865843651857942052864
2) While the second node is still down, create a keyspace with RF=2 and a CF
within this keyspace. Then insert two records into the CF:
Connected to Test Cluster at 192.168.1.162:9160.
[cqlsh 2.2.0 | Cassandra 1.1.2 | CQL spec 2.0.0 | Thrift protocol 19.32.0]
Use HELP for help.
cqlsh create KEYSPACE demo WITH strategy_class = 'SimpleStrategy' AND
strategy_options:replication_factor = 2;
cqlsh use demo;
cqlsh:demo create table users (username varchar primary key, password varchar);
cqlsh:demo insert into users (username, password) values (scott, tiger);
cqlsh:demo insert into users (username, password) values (root, password);
3) Use a JMX client to execute the countPendingHints operation:
jblangston:~ jblangston$ java -jar cmdline-jmxclient-0.10.3.jar -
localhost:7199 org.apache.cassandra.db:type=HintedHandoffManager
countPendingHints
08/22/2012 14:21:37 -0500 org.archive.jmx.Client countPendingHints: {@B^h ??
?[b??scottdemoscott?password?ߞHtigerdemoF
?P???[b??rootdemoroot?password?ߞ?Wpassworddemo=2}
4) Notice output. The value (2) is correct but the key is garbage instead of
an endpoint IP address.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4383) Binary encoding of vnode tokens
[
https://issues.apache.org/jira/browse/CASSANDRA-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439816#comment-13439816
]
Eric Evans commented on CASSANDRA-4383:
---
In so much that I fully understand the implications, it looks OK to me. A few
things:
You're using the presence of a hostID as an implicit indication of the version,
and a determination of whether or not to try decoding more than just the legacy
token. Going back to a test of the MS version might read better, and wouldn't
mask a bug where MS = 1.2 but a host ID wasn't set.
In {{SS.bootstrap()}}, I think the TOKENS state should be set before the STATUS
normal. Also, since that's not the only place where the order of those 2
things matters, it might make sense to encapsulate that in a method, (or at the
very least, clearly comment them).
And, of course as you mention, there are the tests... :)
Binary encoding of vnode tokens
---
Key: CASSANDRA-4383
URL: https://issues.apache.org/jira/browse/CASSANDRA-4383
Project: Cassandra
Issue Type: Sub-task
Reporter: Brandon Williams
Assignee: Brandon Williams
Fix For: 1.2.0
Attachments:
0001-Add-HOST_ID-and-TOKENS-app-states-binary-serialization.txt, 4383-v1.txt
Since after CASSANDRA-4317 we can know which version a remote node is using
(that is, whether it is vnode-aware or not) this a good opportunity to change
the token encoding to binary, since with a default of 256 tokens per node
even a fixed-length 16 byte encoding per token provides a great deal of
savings in gossip traffic over a text representation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4559) implement token relocation
[
https://issues.apache.org/jira/browse/CASSANDRA-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439831#comment-13439831
]
Eric Evans commented on CASSANDRA-4559:
---
bq. Won't we want to be able to relocate more than one token at a time?
Sure, and you could do that by invoking the operation once per token. Though
now that you mention it, I had planned to make it non-blocking for that reason.
It doesn't make a huge difference to me either way; I can make the operation
support multiple ranges in a call if you prefer.
bq. Also, it seems like we could re-use the moving status, or remove it if we
want to rename the functionality, since doing it in a mixed cluster will never
be supported.
Don't we need to continue supporting the old-style move for users that want to
continue running with 1 token per node?
implement token relocation
--
Key: CASSANDRA-4559
URL: https://issues.apache.org/jira/browse/CASSANDRA-4559
Project: Cassandra
Issue Type: Sub-task
Components: Core, Tools
Reporter: Eric Evans
Assignee: Eric Evans
Labels: vnodes
Whatever the specifics of a _shuffle_ (see CASSANDRA-4443), it will be
necessary to relocate a range from one node to another.
_Edit0: Linked in new patch containing tests._
h3. Patches
||Compare||Raw diff||Description||
|[010_refactor_range_move|https://github.com/acunu/cassandra/compare/top-bases/p/4443/010_refactor_range_move...p/4443/010_refactor_range_move]|[010_refactor_range_move.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/010_refactor_range_move...p/4443/010_refactor_range_move.diff]|No
Description|
|[020_calculate_pending|https://github.com/acunu/cassandra/compare/top-bases/p/4443/020_calculate_pending...p/4443/020_calculate_pending]|[020_calculate_pending.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/020_calculate_pending...p/4443/020_calculate_pending.diff]|No
Description|
|[030_relocate_token|https://github.com/acunu/cassandra/compare/top-bases/p/4443/030_relocate_token...p/4443/030_relocate_token]|[030_relocate_token.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/030_relocate_token...p/4443/030_relocate_token.diff]|No
Description|
|[040_tests|https://github.com/acunu/cassandra/compare/top-bases/p/4443/040_tests...p/4443/040_tests]|[040_tests.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/040_tests...p/4443/040_tests.diff]|No
Description|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4559) implement token relocation
[
https://issues.apache.org/jira/browse/CASSANDRA-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439841#comment-13439841
]
Brandon Williams commented on CASSANDRA-4559:
-
bq. It doesn't make a huge difference to me either way; I can make the
operation support multiple ranges in a call if you prefer.
It seems like that would be handy, though now you need to be able to
communicate multiple tokens in the status... which almost brings us back around
to the status-appending game we want to avoid in CASSANDRA-4383 :(
bq. Don't we need to continue supporting the old-style move for users that want
to continue running with 1 token per node?
You're right, there's a difference between I'm moving to that token (move)
and I'm taking this token from this other node (relocate)
implement token relocation
--
Key: CASSANDRA-4559
URL: https://issues.apache.org/jira/browse/CASSANDRA-4559
Project: Cassandra
Issue Type: Sub-task
Components: Core, Tools
Reporter: Eric Evans
Assignee: Eric Evans
Labels: vnodes
Whatever the specifics of a _shuffle_ (see CASSANDRA-4443), it will be
necessary to relocate a range from one node to another.
_Edit0: Linked in new patch containing tests._
h3. Patches
||Compare||Raw diff||Description||
|[010_refactor_range_move|https://github.com/acunu/cassandra/compare/top-bases/p/4443/010_refactor_range_move...p/4443/010_refactor_range_move]|[010_refactor_range_move.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/010_refactor_range_move...p/4443/010_refactor_range_move.diff]|No
Description|
|[020_calculate_pending|https://github.com/acunu/cassandra/compare/top-bases/p/4443/020_calculate_pending...p/4443/020_calculate_pending]|[020_calculate_pending.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/020_calculate_pending...p/4443/020_calculate_pending.diff]|No
Description|
|[030_relocate_token|https://github.com/acunu/cassandra/compare/top-bases/p/4443/030_relocate_token...p/4443/030_relocate_token]|[030_relocate_token.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/030_relocate_token...p/4443/030_relocate_token.diff]|No
Description|
|[040_tests|https://github.com/acunu/cassandra/compare/top-bases/p/4443/040_tests...p/4443/040_tests]|[040_tests.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4443/040_tests...p/4443/040_tests.diff]|No
Description|
_Note: These are branches managed with TopGit. If you are applying the patch
output manually, you will either need to filter the TopGit metadata files
(i.e. {{wget -O - url | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Change nodetool setcachecapcity to manipulate global caches patch by Pavel Yaskevich; reviewed by Brandon Williams for CASSANDRA-4563
Updated Branches:
refs/heads/cassandra-1.1 8173c6f64 - dbf99d674
Change nodetool setcachecapcity to manipulate global caches
patch by Pavel Yaskevich; reviewed by Brandon Williams for CASSANDRA-4563
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dbf99d67
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dbf99d67
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dbf99d67
Branch: refs/heads/cassandra-1.1
Commit: dbf99d6740917cdecc342d84e1e3bec03613d8ba
Parents: 8173c6f
Author: Pavel Yaskevich xe...@apache.org
Authored: Wed Aug 22 12:28:24 2012 +0300
Committer: Pavel Yaskevich xe...@apache.org
Committed: Thu Aug 23 00:58:03 2012 +0300
--
CHANGES.txt|1 +
src/java/org/apache/cassandra/tools/NodeCmd.java |6 +++---
src/java/org/apache/cassandra/tools/NodeProbe.java |2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/dbf99d67/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 3c7163a..b5ee914 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
1.1.5
* increase stack size under Java7 to 180K
* Log(info) schema changes (CASSANDRA-4547)
+ * Change nodetool setcachecapcity to manipulate global caches (CASSANDRA-4563)
1.1.4
http://git-wip-us.apache.org/repos/asf/cassandra/blob/dbf99d67/src/java/org/apache/cassandra/tools/NodeCmd.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeCmd.java
b/src/java/org/apache/cassandra/tools/NodeCmd.java
index b73e96a..d0ec068 100644
--- a/src/java/org/apache/cassandra/tools/NodeCmd.java
+++ b/src/java/org/apache/cassandra/tools/NodeCmd.java
@@ -182,13 +182,13 @@ public class NodeCmd
addCmdHelp(header, cfhistograms keyspace cfname, Print
statistic histograms for a given column family);
addCmdHelp(header, refresh keyspace cf-name, Load newly placed
SSTables to the system without restart.);
addCmdHelp(header, rebuild_index keyspace cf-name idx1,idx1,
a full rebuilds of native secondry index for a given column family.
IndexNameExample: Standard3.IdxName,Standard3.IdxName1);
+addCmdHelp(header, setcachecapacity key-cache-capacity
row-cache-capacity, Set global key and row cache capacities (in MB
units).);
// Three args
addCmdHelp(header, getendpoints keyspace cf key, Print the
end points that owns the key);
addCmdHelp(header, getsstables keyspace cf key, Print the
sstable filenames that own the key);
// Four args
-addCmdHelp(header, setcachecapacity keyspace cfname
keycachecapacity rowcachecapacity, Set the key and row cache capacities
of a given column family);
addCmdHelp(header, setcompactionthreshold keyspace cfname
minthreshold maxthreshold, Set the min and max compaction thresholds for
a given column family);
addCmdHelp(header, stop compaction_type, Supported types are
COMPACTION, VALIDATION, CLEANUP, SCRUB, INDEX_BUILD);
@@ -821,8 +821,8 @@ public class NodeCmd
break;
case SETCACHECAPACITY :
-if (arguments.length != 4) { badUse(setcachecapacity
requires ks, cf, keycachecap, and rowcachecap args.); }
-probe.setCacheCapacities(arguments[0], arguments[1],
Integer.parseInt(arguments[2]), Integer.parseInt(arguments[3]));
+if (arguments.length != 2) { badUse(setcachecapacity
requires key-cache-capacity, and row-cache-capacity args.); }
+probe.setCacheCapacities(Integer.parseInt(arguments[0]),
Integer.parseInt(arguments[1]));
break;
case SETCOMPACTIONTHRESHOLD :
http://git-wip-us.apache.org/repos/asf/cassandra/blob/dbf99d67/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index 5488d75..c40891c 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -443,7 +443,7 @@ public class NodeProbe
cfsProxy.setCompactionThresholds(minimumCompactionThreshold,
maximumCompactionThreshold);
}
-public void setCacheCapacities(String tableName, String cfName, int
keyCacheCapacity, int rowCacheCapacity)
+public void setCacheCapacities(int keyCacheCapacity, int rowCacheCapacity)
{
try
{
[1/2] git commit: merge from 1.1
Updated Branches: refs/heads/trunk 66d52f9d2 - 39e5a080d merge from 1.1 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/39e5a080 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/39e5a080 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/39e5a080 Branch: refs/heads/trunk Commit: 39e5a080d350a669b775063e2707deaade77b5ba Parents: 66d52f9 dbf99d6 Author: Pavel Yaskevich xe...@apache.org Authored: Thu Aug 23 00:59:29 2012 +0300 Committer: Pavel Yaskevich xe...@apache.org Committed: Thu Aug 23 00:59:29 2012 +0300 -- CHANGES.txt|1 + src/java/org/apache/cassandra/tools/NodeCmd.java |6 +++--- src/java/org/apache/cassandra/tools/NodeProbe.java |2 +- 3 files changed, 5 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/39e5a080/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/39e5a080/src/java/org/apache/cassandra/tools/NodeCmd.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/39e5a080/src/java/org/apache/cassandra/tools/NodeProbe.java --
[2/2] git commit: Change nodetool setcachecapcity to manipulate global caches patch by Pavel Yaskevich; reviewed by Brandon Williams for CASSANDRA-4563
Change nodetool setcachecapcity to manipulate global caches
patch by Pavel Yaskevich; reviewed by Brandon Williams for CASSANDRA-4563
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dbf99d67
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dbf99d67
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dbf99d67
Branch: refs/heads/trunk
Commit: dbf99d6740917cdecc342d84e1e3bec03613d8ba
Parents: 8173c6f
Author: Pavel Yaskevich xe...@apache.org
Authored: Wed Aug 22 12:28:24 2012 +0300
Committer: Pavel Yaskevich xe...@apache.org
Committed: Thu Aug 23 00:58:03 2012 +0300
--
CHANGES.txt|1 +
src/java/org/apache/cassandra/tools/NodeCmd.java |6 +++---
src/java/org/apache/cassandra/tools/NodeProbe.java |2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/dbf99d67/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 3c7163a..b5ee914 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
1.1.5
* increase stack size under Java7 to 180K
* Log(info) schema changes (CASSANDRA-4547)
+ * Change nodetool setcachecapcity to manipulate global caches (CASSANDRA-4563)
1.1.4
http://git-wip-us.apache.org/repos/asf/cassandra/blob/dbf99d67/src/java/org/apache/cassandra/tools/NodeCmd.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeCmd.java
b/src/java/org/apache/cassandra/tools/NodeCmd.java
index b73e96a..d0ec068 100644
--- a/src/java/org/apache/cassandra/tools/NodeCmd.java
+++ b/src/java/org/apache/cassandra/tools/NodeCmd.java
@@ -182,13 +182,13 @@ public class NodeCmd
addCmdHelp(header, cfhistograms keyspace cfname, Print
statistic histograms for a given column family);
addCmdHelp(header, refresh keyspace cf-name, Load newly placed
SSTables to the system without restart.);
addCmdHelp(header, rebuild_index keyspace cf-name idx1,idx1,
a full rebuilds of native secondry index for a given column family.
IndexNameExample: Standard3.IdxName,Standard3.IdxName1);
+addCmdHelp(header, setcachecapacity key-cache-capacity
row-cache-capacity, Set global key and row cache capacities (in MB
units).);
// Three args
addCmdHelp(header, getendpoints keyspace cf key, Print the
end points that owns the key);
addCmdHelp(header, getsstables keyspace cf key, Print the
sstable filenames that own the key);
// Four args
-addCmdHelp(header, setcachecapacity keyspace cfname
keycachecapacity rowcachecapacity, Set the key and row cache capacities
of a given column family);
addCmdHelp(header, setcompactionthreshold keyspace cfname
minthreshold maxthreshold, Set the min and max compaction thresholds for
a given column family);
addCmdHelp(header, stop compaction_type, Supported types are
COMPACTION, VALIDATION, CLEANUP, SCRUB, INDEX_BUILD);
@@ -821,8 +821,8 @@ public class NodeCmd
break;
case SETCACHECAPACITY :
-if (arguments.length != 4) { badUse(setcachecapacity
requires ks, cf, keycachecap, and rowcachecap args.); }
-probe.setCacheCapacities(arguments[0], arguments[1],
Integer.parseInt(arguments[2]), Integer.parseInt(arguments[3]));
+if (arguments.length != 2) { badUse(setcachecapacity
requires key-cache-capacity, and row-cache-capacity args.); }
+probe.setCacheCapacities(Integer.parseInt(arguments[0]),
Integer.parseInt(arguments[1]));
break;
case SETCOMPACTIONTHRESHOLD :
http://git-wip-us.apache.org/repos/asf/cassandra/blob/dbf99d67/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index 5488d75..c40891c 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -443,7 +443,7 @@ public class NodeProbe
cfsProxy.setCompactionThresholds(minimumCompactionThreshold,
maximumCompactionThreshold);
}
-public void setCacheCapacities(String tableName, String cfName, int
keyCacheCapacity, int rowCacheCapacity)
+public void setCacheCapacities(int keyCacheCapacity, int rowCacheCapacity)
{
try
{
[jira] [Commented] (CASSANDRA-4567) Error in log related to Murmer3Partitioner
[
https://issues.apache.org/jira/browse/CASSANDRA-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439919#comment-13439919
]
Vijay commented on CASSANDRA-4567:
--
CASSANDRA-3772 modified the default Paritioner to M3P (was RandomP). Users who
upgrade the existing clusters need to change the yaml settings.
May be updating NEWS.txt will help?
Error in log related to Murmer3Partitioner
--
Key: CASSANDRA-4567
URL: https://issues.apache.org/jira/browse/CASSANDRA-4567
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.0
Environment: Using ccm on ubuntu
Reporter: Tyler Patterson
Assignee: Pavel Yaskevich
Fix For: 1.2.0
Start a 2-node cluster on cassandra-1.1. Bring down one node, upgrade it to
trunk, start it back up. The following error shows up in the log:
{code}
...
INFO [main] 2012-08-22 10:44:40,012 CacheService.java (line 170) Scheduling
row cache save to each 0 seconds (going to save all keys).
INFO [SSTableBatchOpen:1] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
(148 bytes)
INFO [SSTableBatchOpen:2] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
(226 bytes)
INFO [SSTableBatchOpen:3] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
(89 bytes)
ERROR [SSTableBatchOpen:3] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:3,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:2] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:2,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:1] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:1,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at
[jira] [Commented] (CASSANDRA-4567) Error in log related to Murmer3Partitioner
[
https://issues.apache.org/jira/browse/CASSANDRA-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439930#comment-13439930
]
Pavel Yaskevich commented on CASSANDRA-4567:
Agreed, I will update the NEWS as part of CASSANDRA-3772 when finished, I don't
really see any user-friendly way to change default partitioner, users who use
packages shouldn't be affected as configuration is separate but automated tools
probably would have to add a check to reset partitioner when testing 1.1 - 1.2
migration...
Error in log related to Murmer3Partitioner
--
Key: CASSANDRA-4567
URL: https://issues.apache.org/jira/browse/CASSANDRA-4567
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.0
Environment: Using ccm on ubuntu
Reporter: Tyler Patterson
Assignee: Pavel Yaskevich
Fix For: 1.2.0
Start a 2-node cluster on cassandra-1.1. Bring down one node, upgrade it to
trunk, start it back up. The following error shows up in the log:
{code}
...
INFO [main] 2012-08-22 10:44:40,012 CacheService.java (line 170) Scheduling
row cache save to each 0 seconds (going to save all keys).
INFO [SSTableBatchOpen:1] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
(148 bytes)
INFO [SSTableBatchOpen:2] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
(226 bytes)
INFO [SSTableBatchOpen:3] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
(89 bytes)
ERROR [SSTableBatchOpen:3] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:3,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:2] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:2,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:1] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:1,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
[jira] [Resolved] (CASSANDRA-4567) Error in log related to Murmer3Partitioner
[
https://issues.apache.org/jira/browse/CASSANDRA-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis resolved CASSANDRA-4567.
---
Resolution: Not A Problem
Error in log related to Murmer3Partitioner
--
Key: CASSANDRA-4567
URL: https://issues.apache.org/jira/browse/CASSANDRA-4567
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.0
Environment: Using ccm on ubuntu
Reporter: Tyler Patterson
Assignee: Pavel Yaskevich
Fix For: 1.2.0
Start a 2-node cluster on cassandra-1.1. Bring down one node, upgrade it to
trunk, start it back up. The following error shows up in the log:
{code}
...
INFO [main] 2012-08-22 10:44:40,012 CacheService.java (line 170) Scheduling
row cache save to each 0 seconds (going to save all keys).
INFO [SSTableBatchOpen:1] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
(148 bytes)
INFO [SSTableBatchOpen:2] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
(226 bytes)
INFO [SSTableBatchOpen:3] 2012-08-22 10:44:40,106 SSTableReader.java (line
164) Opening
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
(89 bytes)
ERROR [SSTableBatchOpen:3] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:3,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-3
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:2] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:2,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-1
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
ERROR [SSTableBatchOpen:1] 2012-08-22 10:44:40,114 CassandraDaemon.java (line
131) Exception in thread Thread[SSTableBatchOpen:1,5,main]
java.lang.RuntimeException: Cannot open
/tmp/dtest-IYHWfV/test/node1/data/system/LocationInfo/system-LocationInfo-he-2
because partitioner does not match
org.apache.cassandra.dht.Murmur3Partitioner
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:175)
at
org.apache.cassandra.io.sstable.SSTableReader.open(SSTableReader.java:149)
at
org.apache.cassandra.io.sstable.SSTableReader$1.run(SSTableReader.java:236)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
INFO [main] 2012-08-22 10:44:40,486 DatabaseDescriptor.java (line 522)
Couldn't detect any schema definitions in local storage.
INFO [main] 2012-08-22
[jira] [Created] (CASSANDRA-4569) Cassandra configuration should support a TokenProvider (like SeedProvider)
Cody A. Ray created CASSANDRA-4569: -- Summary: Cassandra configuration should support a TokenProvider (like SeedProvider) Key: CASSANDRA-4569 URL: https://issues.apache.org/jira/browse/CASSANDRA-4569 Project: Cassandra Issue Type: New Feature Components: Core Reporter: Cody A. Ray Priority: Minor For added flexibility (and to allow more external management options without simply rewriting the configuration file), it would be great if Cassandra supported a TokenProvider interface like it does with the SeedProvider. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-4570) Minor logging additions
Joaquin Casares created CASSANDRA-4570: -- Summary: Minor logging additions Key: CASSANDRA-4570 URL: https://issues.apache.org/jira/browse/CASSANDRA-4570 Project: Cassandra Issue Type: Improvement Affects Versions: 1.1.4 Reporter: Joaquin Casares Assignee: Joaquin Casares Priority: Trivial Attachments: check_tables.txt, info_paths.txt Four patches to clear up/add information to logging. 1. check_tables Moves a portion of the code that checks for data files to right before the system tables are created. 2. info_paths Adds path printing statements for the cassandra.yaml, data_dir, and commit_log locations. 3. jvm_warnings Warn the user if they are on OpenJDK. Warn the user if they are using a minor version 29. Error if they are using a minor version 25. 4. mt_compaction Log that the user is performing compactions with multi-threaded compactions enabled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4570) Minor logging additions
[ https://issues.apache.org/jira/browse/CASSANDRA-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joaquin Casares updated CASSANDRA-4570: --- Attachment: check_tables.txt Minor logging additions --- Key: CASSANDRA-4570 URL: https://issues.apache.org/jira/browse/CASSANDRA-4570 Project: Cassandra Issue Type: Improvement Affects Versions: 1.1.4 Reporter: Joaquin Casares Assignee: Joaquin Casares Priority: Trivial Attachments: check_tables.txt, info_paths.txt Four patches to clear up/add information to logging. 1. check_tables Moves a portion of the code that checks for data files to right before the system tables are created. 2. info_paths Adds path printing statements for the cassandra.yaml, data_dir, and commit_log locations. 3. jvm_warnings Warn the user if they are on OpenJDK. Warn the user if they are using a minor version 29. Error if they are using a minor version 25. 4. mt_compaction Log that the user is performing compactions with multi-threaded compactions enabled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4570) Minor logging additions
[ https://issues.apache.org/jira/browse/CASSANDRA-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joaquin Casares updated CASSANDRA-4570: --- Attachment: info_paths.txt Minor logging additions --- Key: CASSANDRA-4570 URL: https://issues.apache.org/jira/browse/CASSANDRA-4570 Project: Cassandra Issue Type: Improvement Affects Versions: 1.1.4 Reporter: Joaquin Casares Assignee: Joaquin Casares Priority: Trivial Attachments: check_tables.txt, info_paths.txt Four patches to clear up/add information to logging. 1. check_tables Moves a portion of the code that checks for data files to right before the system tables are created. 2. info_paths Adds path printing statements for the cassandra.yaml, data_dir, and commit_log locations. 3. jvm_warnings Warn the user if they are on OpenJDK. Warn the user if they are using a minor version 29. Error if they are using a minor version 25. 4. mt_compaction Log that the user is performing compactions with multi-threaded compactions enabled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4570) Minor logging additions
[ https://issues.apache.org/jira/browse/CASSANDRA-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joaquin Casares updated CASSANDRA-4570: --- Attachment: jvm_warnings.txt Minor logging additions --- Key: CASSANDRA-4570 URL: https://issues.apache.org/jira/browse/CASSANDRA-4570 Project: Cassandra Issue Type: Improvement Affects Versions: 1.1.4 Reporter: Joaquin Casares Assignee: Joaquin Casares Priority: Trivial Attachments: check_tables.txt, info_paths.txt, jvm_warnings.txt, mt_compaction.txt Four patches to clear up/add information to logging. 1. check_tables Moves a portion of the code that checks for data files to right before the system tables are created. 2. info_paths Adds path printing statements for the cassandra.yaml, data_dir, and commit_log locations. 3. jvm_warnings Warn the user if they are on OpenJDK. Warn the user if they are using a minor version 29. Error if they are using a minor version 25. 4. mt_compaction Log that the user is performing compactions with multi-threaded compactions enabled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4570) Minor logging additions
[ https://issues.apache.org/jira/browse/CASSANDRA-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joaquin Casares updated CASSANDRA-4570: --- Attachment: mt_compaction.txt Minor logging additions --- Key: CASSANDRA-4570 URL: https://issues.apache.org/jira/browse/CASSANDRA-4570 Project: Cassandra Issue Type: Improvement Affects Versions: 1.1.4 Reporter: Joaquin Casares Assignee: Joaquin Casares Priority: Trivial Attachments: check_tables.txt, info_paths.txt, jvm_warnings.txt, mt_compaction.txt Four patches to clear up/add information to logging. 1. check_tables Moves a portion of the code that checks for data files to right before the system tables are created. 2. info_paths Adds path printing statements for the cassandra.yaml, data_dir, and commit_log locations. 3. jvm_warnings Warn the user if they are on OpenJDK. Warn the user if they are using a minor version 29. Error if they are using a minor version 25. 4. mt_compaction Log that the user is performing compactions with multi-threaded compactions enabled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: remove dead assignments
Updated Branches:
refs/heads/trunk 39e5a080d - 8bd1c1f86
remove dead assignments
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8bd1c1f8
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8bd1c1f8
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8bd1c1f8
Branch: refs/heads/trunk
Commit: 8bd1c1f86e875a34cf717c95706a29955fd6d2bd
Parents: 39e5a08
Author: Dave Brosius dbros...@apache.org
Authored: Wed Aug 22 23:16:16 2012 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Wed Aug 22 23:16:16 2012 -0400
--
.../cassandra/hadoop/ColumnFamilyRecordReader.java |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8bd1c1f8/src/java/org/apache/cassandra/hadoop/ColumnFamilyRecordReader.java
--
diff --git a/src/java/org/apache/cassandra/hadoop/ColumnFamilyRecordReader.java
b/src/java/org/apache/cassandra/hadoop/ColumnFamilyRecordReader.java
index 7c86774..c23f290 100644
--- a/src/java/org/apache/cassandra/hadoop/ColumnFamilyRecordReader.java
+++ b/src/java/org/apache/cassandra/hadoop/ColumnFamilyRecordReader.java
@@ -122,7 +122,7 @@ public class ColumnFamilyRecordReader extends
RecordReaderByteBuffer, SortedMap
byte[] start = predicate.getSlice_range().getStart();
if ((start != null) (start.length 0))
return false;
-
+
byte[] finish = predicate.getSlice_range().getFinish();
if ((finish != null) (finish.length 0))
return false;
@@ -359,11 +359,6 @@ public class ColumnFamilyRecordReader extends
RecordReaderByteBuffer, SortedMap
return;
}
-// prepare for the next slice to be read
-KeySlice lastRow = rows.get(rows.size() - 1);
-ByteBuffer rowkey = lastRow.key;
-startToken =
partitioner.getTokenFactory().toString(partitioner.getToken(rowkey));
-
// remove ghosts when fetching all columns
if (isEmptyPredicate)
{
@@ -426,7 +421,6 @@ public class ColumnFamilyRecordReader extends
RecordReaderByteBuffer, SortedMap
return;
KeyRange keyRange;
-ByteBuffer startColumn;
if (totalRead == 0)
{
String startToken = split.getStartToken();
[jira] [Resolved] (CASSANDRA-4569) Cassandra configuration should support a TokenProvider (like SeedProvider)
[ https://issues.apache.org/jira/browse/CASSANDRA-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis resolved CASSANDRA-4569. --- Resolution: Not A Problem The partitioner is already pluggable; it sounds like that is what you are looking for. Cassandra configuration should support a TokenProvider (like SeedProvider) -- Key: CASSANDRA-4569 URL: https://issues.apache.org/jira/browse/CASSANDRA-4569 Project: Cassandra Issue Type: New Feature Components: Core Reporter: Cody A. Ray Priority: Minor For added flexibility (and to allow more external management options without simply rewriting the configuration file), it would be great if Cassandra supported a TokenProvider interface like it does with the SeedProvider. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4569) Cassandra configuration should support a TokenProvider (like SeedProvider)
[ https://issues.apache.org/jira/browse/CASSANDRA-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440058#comment-13440058 ] Cody A. Ray commented on CASSANDRA-4569: Nope. I'm looking for the initial_token value to be pluggable so that I can manage/generate the initial tokens using an external service. Right now, I either have to rewrite the cassandra.yaml with the correct initial_token value, or have to set the system property cassandra.initial_token. Ideally, it'd be more directly pluggable using a TokenProvider interface though, like the SeedProvider is. Cassandra configuration should support a TokenProvider (like SeedProvider) -- Key: CASSANDRA-4569 URL: https://issues.apache.org/jira/browse/CASSANDRA-4569 Project: Cassandra Issue Type: New Feature Components: Core Reporter: Cody A. Ray Priority: Minor For added flexibility (and to allow more external management options without simply rewriting the configuration file), it would be great if Cassandra supported a TokenProvider interface like it does with the SeedProvider. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
