[jira] [Commented] (CASSANDRA-11990) Address rows rather than partitions in SASI
[ https://issues.apache.org/jira/browse/CASSANDRA-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403369#comment-15403369 ] Alex Petrov commented on CASSANDRA-11990: - During this patch, on-disk format of token tree was changed. So we need to support reading from the old format along with the new one until sstables are upgraded. -- Alex Petrov > Address rows rather than partitions in SASI > --- > > Key: CASSANDRA-11990 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11990 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: Alex Petrov >Assignee: Alex Petrov > Attachments: perf.pdf, size_comparison.png > > > Currently, the lookup in SASI index would return the key position of the > partition. After the partition lookup, the rows are iterated and the > operators are applied in order to filter out ones that do not match. > bq. TokenTree which accepts variable size keys (such would enable different > partitioners, collections support, primary key indexing etc.), -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CASSANDRA-12359) BlacklistingCompactionsTest.testBlacklistingWithSizeTieredCompactionStrategy is flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania reassigned CASSANDRA-12359: Assignee: Stefania > BlacklistingCompactionsTest.testBlacklistingWithSizeTieredCompactionStrategy > is flaky > - > > Key: CASSANDRA-12359 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12359 > Project: Cassandra > Issue Type: Bug >Reporter: Joel Knighton >Assignee: Stefania > > example failure: > > [http://cassci.datastax.com/job/cassandra-3.9_testall/50/testReport/junit/org.apache.cassandra.db.compaction/BlacklistingCompactionsTest/testBlacklistingWithSizeTieredCompactionStrategy/] > Google suggests that this test is somewhat flaky historically, but we don't > have logs from any of the older failures any more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12181) Include table name in "Cannot get comparator" exception
[ https://issues.apache.org/jira/browse/CASSANDRA-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sankalp kohli updated CASSANDRA-12181: -- Fix Version/s: 3.9 3.0.9 > Include table name in "Cannot get comparator" exception > --- > > Key: CASSANDRA-12181 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12181 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: sankalp kohli >Priority: Trivial > Fix For: 3.0.9, 3.9 > > Attachments: CASSANDRA-12181-3.0_v2.txt, CASSANDRA-12181_3.0-v3.txt, > CASSANDRA-12181_3.0.txt > > > Having table name will help in debugging the following exception. > ERROR [MutationStage:xx] CassandraDaemon.java (line 199) Exception in thread > Thread[MutationStage:3788,5,main] > clusterName=itms8shared20 > java.lang.RuntimeException: Cannot get comparator 2 in > org.apache.cassandra.db.marshal.CompositeType(org.apache.cassandra.db.marshal.UTF8Type,org.apache.cassandra.db.marshal.UTF8Type). > > This might be due to a mismatch between the schema and the data read -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12353) CustomIndexTest can still fail due to async cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12353: - Status: Ready to Commit (was: Patch Available) > CustomIndexTest can still fail due to async cleanup > --- > > Key: CASSANDRA-12353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12353 > Project: Cassandra > Issue Type: Test >Reporter: Sam Tunnicliffe >Assignee: Sam Tunnicliffe >Priority: Minor > > CASSANDRA-11453 didn't quite go far enough in ensuring that indexes in > {{CustomIndexTest}} are uniquely named. A couple of duplicates were missed > which has lead to at least one failure (on trunk): > > http://cassci.datastax.com/job/trunk_utest/1613/testReport/org.apache.cassandra.index/CustomIndexTest/customIndexRejectsExpressionSyntax/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12353) CustomIndexTest can still fail due to async cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403280#comment-15403280 ] Stefania commented on CASSANDRA-12353: -- There is possibly one "custom_index" still left at this [line|https://github.com/beobal/cassandra/commit/9ec9a061f6849b57f33e91b9d236ec3b2f92b016#diff-13cb97758bcb11cce8fc6f4cb1990dd6R374]. Otherwise +1. > CustomIndexTest can still fail due to async cleanup > --- > > Key: CASSANDRA-12353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12353 > Project: Cassandra > Issue Type: Test >Reporter: Sam Tunnicliffe >Assignee: Sam Tunnicliffe >Priority: Minor > > CASSANDRA-11453 didn't quite go far enough in ensuring that indexes in > {{CustomIndexTest}} are uniquely named. A couple of duplicates were missed > which has lead to at least one failure (on trunk): > > http://cassci.datastax.com/job/trunk_utest/1613/testReport/org.apache.cassandra.index/CustomIndexTest/customIndexRejectsExpressionSyntax/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12353) CustomIndexTest can still fail due to async cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12353: - Reviewer: Stefania > CustomIndexTest can still fail due to async cleanup > --- > > Key: CASSANDRA-12353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12353 > Project: Cassandra > Issue Type: Test >Reporter: Sam Tunnicliffe >Assignee: Sam Tunnicliffe >Priority: Minor > > CASSANDRA-11453 didn't quite go far enough in ensuring that indexes in > {{CustomIndexTest}} are uniquely named. A couple of duplicates were missed > which has lead to at least one failure (on trunk): > > http://cassci.datastax.com/job/trunk_utest/1613/testReport/org.apache.cassandra.index/CustomIndexTest/customIndexRejectsExpressionSyntax/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12212) system.compactions_in_progress needs to be used on first upgrade to 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403252#comment-15403252 ] Stefania commented on CASSANDRA-12212: -- I understood that local shards can remain in the system potentially forever. My point was that if they do get overridden, then it would be with a global shard, and therefore in a potential interrupted compaction we'd have one local shard in one sstable and one global shard in another sstable, resolved to the global shard in the compacted sstable. If we restarted in 3.0 with these 3 sstables still around, the global shard would prevail in a read operation and so no harm in having both old and new sstables. The only potential scenario is two local shards, for the same counter, present into two different sstables, which were never compacted and hence unlikely to be present in an interrupted compaction just before the upgrade to 3.0. To implement this, it is mostly a copy and paste exercise, the trickiest part is to design a test for it. However, I think the benefits are limited, given that it is a rare scenario, and besides a nodetool drain will stop compactions, and the time interval between the deletion of the compactions_in_progress entry and the deletion of old sstable files is still not covered by the compactions_in_progress entry. So my inclination is to close this as won't fix, but if people think we should still read compactions_in_progress when upgrading to 3.0, then we can do so. > system.compactions_in_progress needs to be used on first upgrade to 3.0 > --- > > Key: CASSANDRA-12212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12212 > Project: Cassandra > Issue Type: Bug > Components: Compaction >Reporter: Jeremiah Jordan >Assignee: Stefania > Fix For: 3.0.x, 3.x > > > CASSANDRA-7066 removed the system.compactions_in_progress table and replaced > it with the new transaction system. But system.compactions_in_progress needs > to be consulted for the first startup after upgrading from 2.1 to 3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11914) Provide option for cassandra-stress to dump all settings
[ https://issues.apache.org/jira/browse/CASSANDRA-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403249#comment-15403249 ] Ben Slater commented on CASSANDRA-11914: Turns out the "create schema" problem is not so much that it doesn't create the schema but rather that trying to do the calcs to display the "Generating batches with x partitions and x rows ..." message results in a call to maybeLoadSchemaInfo() which fails if the schema doesn't exist (creating the schema still works if you don't do print-settings). So, I think the alternatives to fix are either (a) create the schema (if necessary) at the time printSettings() is called, (b) put the "Generating batches ..." message back where is was in getInsert() at the start of the run or (c) move printSettings() until after the run is complete. I think my preference is (b) as creating a schema sounds like a very unexpected side effect of printSettings() and you probably want to be able to print settings without completing a full run (ruling out (c)). However, let me know if you can see a different solution or prefer a different option. Cheers Ben > Provide option for cassandra-stress to dump all settings > > > Key: CASSANDRA-11914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11914 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Ben Slater >Assignee: Ben Slater >Priority: Minor > Fix For: 3.x > > > cassandra-stress has quite a lot of default settings and settings that are > derived as side effects of explicit options. For people learning the tool and > saving a clear record of what was run, I think it would be useful if there > was an option to have the tool print all its settings at the start of a run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12348: - Resolution: Fixed Fix Version/s: (was: 3.x) 3.9 Status: Resolved (was: Ready to Commit) > Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest > - > > Key: CASSANDRA-12348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12348 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.9 > > > Example failures: > http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/ > http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > All failures look like the test is finding more files than expected after a > rewrite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403229#comment-15403229 ] Stefania commented on CASSANDRA-12348: -- Thanks for the review. I've added a comment to {{validateCFS}} and then committed the fix to 3.9 as e89028d34c699916b8c94b52f4cb3e086d8b81c1 and merged into trunk. I did not add a {{LifecycleTransaction.waitForDeletions()}} after {{CompactionManager.instance.submitMaximal}} because we would have also had to wait on the future first. I think a better approach would be not to submit the maximal compaction task but to just check that there exists at least one. I think this was the intention of the test. We can reopen this ticket or create a new one if we want to change this test further. > Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest > - > > Key: CASSANDRA-12348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12348 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.9 > > > Example failures: > http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/ > http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > All failures look like the test is finding more files than expected after a > rewrite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[3/3] cassandra git commit: Merge branch 'cassandra-3.9' into trunk
Merge branch 'cassandra-3.9' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c320f22a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c320f22a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c320f22a Branch: refs/heads/trunk Commit: c320f22a9260fc61e3547b89213e571284109233 Parents: f59a78b e89028d Author: Stefania AlborghettiAuthored: Tue Aug 2 10:07:46 2016 +0800 Committer: Stefania Alborghetti Committed: Tue Aug 2 10:07:46 2016 +0800 -- CHANGES.txt | 1 + .../io/sstable/SSTableRewriterTest.java | 12 ++-- .../io/sstable/SSTableWriterTestBase.java | 20 3 files changed, 27 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/c320f22a/CHANGES.txt -- diff --cc CHANGES.txt index f9ff43d,0f6bc50..1f5ad3a --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,31 -1,5 +1,32 @@@ +3.10 + * Add version command to cassandra-stress (CASSANDRA-12258) + * Create compaction-stress tool (CASSANDRA-11844) + * Garbage-collecting compaction operation and schema option (CASSANDRA-7019) + * Add schema to snapshot manifest, add USING TIMESTAMP clause to ALTER TABLE statements (CASSANDRA-7190) + * Add beta protocol flag for v5 native protocol (CASSANDRA-12142) + * Support filtering on non-PRIMARY KEY columns in the CREATE + MATERIALIZED VIEW statement's WHERE clause (CASSANDRA-10368) + * Unify STDOUT and SYSTEMLOG logback format (CASSANDRA-12004) + * COPY FROM should raise error for non-existing input files (CASSANDRA-12174) + * Faster write path (CASSANDRA-12269) + * Option to leave omitted columns in INSERT JSON unset (CASSANDRA-11424) + * Support json/yaml output in nodetool tpstats (CASSANDRA-12035) + * Expose metrics for successful/failed authentication attempts (CASSANDRA-10635) + * Prepend snapshot name with "truncated" or "dropped" when a snapshot + is taken before truncating or dropping a table (CASSANDRA-12178) + * Optimize RestrictionSet (CASSANDRA-12153) + * cqlsh does not automatically downgrade CQL version (CASSANDRA-12150) + * Omit (de)serialization of state variable in UDAs (CASSANDRA-9613) + * Create a system table to expose prepared statements (CASSANDRA-8831) + * Reuse DataOutputBuffer from ColumnIndex (CASSANDRA-11970) + * Remove DatabaseDescriptor dependency from SegmentedFile (CASSANDRA-11580) + * Add supplied username to authentication error messages (CASSANDRA-12076) + * Remove pre-startup check for open JMX port (CASSANDRA-12074) + * Remove compaction Severity from DynamicEndpointSnitch (CASSANDRA-11738) + + 3.9 + * Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348) * cqlsh: Fix handling of $$-escaped strings (CASSANDRA-12189) * Fix SSL JMX requiring truststore containing server cert (CASSANDRA-12109) Merged from 3.0: http://git-wip-us.apache.org/repos/asf/cassandra/blob/c320f22a/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java --
[2/3] cassandra git commit: Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348)
Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348) patch by Stefania Alborghetti; reviewed by Paulo Motta for CASSANDRA-12348 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e89028d3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e89028d3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e89028d3 Branch: refs/heads/trunk Commit: e89028d34c699916b8c94b52f4cb3e086d8b81c1 Parents: b447ffc Author: Stefania AlborghettiAuthored: Mon Aug 1 14:45:29 2016 +0800 Committer: Stefania Alborghetti Committed: Tue Aug 2 10:07:37 2016 +0800 -- CHANGES.txt | 1 + .../io/sstable/SSTableRewriterTest.java | 12 ++-- .../io/sstable/SSTableWriterTestBase.java | 20 3 files changed, 27 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/e89028d3/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index e7d9066..0f6bc50 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.9 + * Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348) * cqlsh: Fix handling of $$-escaped strings (CASSANDRA-12189) * Fix SSL JMX requiring truststore containing server cert (CASSANDRA-12109) Merged from 3.0: http://git-wip-us.apache.org/repos/asf/cassandra/blob/e89028d3/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java -- diff --git a/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java b/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java index 9c6da77..246a7f0 100644 --- a/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java +++ b/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java @@ -99,9 +99,9 @@ public class SSTableRewriterTest extends SSTableWriterTestBase writer.finish(); } LifecycleTransaction.waitForDeletions(); +assertEquals(1, assertFileCounts(sstables.iterator().next().descriptor.directory.list())); + validateCFS(cfs); -int filecounts = assertFileCounts(sstables.iterator().next().descriptor.directory.list()); -assertEquals(1, filecounts); truncate(cfs); } @Test @@ -131,9 +131,9 @@ public class SSTableRewriterTest extends SSTableWriterTestBase writer.finish(); } LifecycleTransaction.waitForDeletions(); +assertEquals(1, assertFileCounts(sstables.iterator().next().descriptor.directory.list())); + validateCFS(cfs); -int filecounts = assertFileCounts(sstables.iterator().next().descriptor.directory.list()); -assertEquals(1, filecounts); } @Test @@ -186,9 +186,9 @@ public class SSTableRewriterTest extends SSTableWriterTestBase writer.finish(); } LifecycleTransaction.waitForDeletions(); +assertEquals(1, assertFileCounts(sstables.iterator().next().descriptor.directory.list())); + validateCFS(cfs); -int filecounts = assertFileCounts(sstables.iterator().next().descriptor.directory.list()); -assertEquals(1, filecounts); truncate(cfs); } http://git-wip-us.apache.org/repos/asf/cassandra/blob/e89028d3/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java -- diff --git a/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java b/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java index 9c3bb19..c04fd35 100644 --- a/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java +++ b/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java @@ -111,6 +111,25 @@ public class SSTableWriterTestBase extends SchemaLoader validateCFS(cfs); } +/** + * Validate the column family store by checking that all live + * sstables are referenced only once and are not marked as + * compacting. It also checks that the generation of the data + * files on disk is the same as that of the live sstables, + * to ensure that the data files on disk belong to the live + * sstables. Finally, it checks that the metrics contain the + * correct disk space used, live and total. + * + * Note that this method will submit a maximal compaction task + * if there are live sstables, in order to check that there is at least + * a maximal task when there are live sstables. + * + * This method has therefore side
[1/3] cassandra git commit: Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348)
Repository: cassandra Updated Branches: refs/heads/cassandra-3.9 b447ffc42 -> e89028d34 refs/heads/trunk f59a78b76 -> c320f22a9 Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348) patch by Stefania Alborghetti; reviewed by Paulo Motta for CASSANDRA-12348 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e89028d3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e89028d3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e89028d3 Branch: refs/heads/cassandra-3.9 Commit: e89028d34c699916b8c94b52f4cb3e086d8b81c1 Parents: b447ffc Author: Stefania AlborghettiAuthored: Mon Aug 1 14:45:29 2016 +0800 Committer: Stefania Alborghetti Committed: Tue Aug 2 10:07:37 2016 +0800 -- CHANGES.txt | 1 + .../io/sstable/SSTableRewriterTest.java | 12 ++-- .../io/sstable/SSTableWriterTestBase.java | 20 3 files changed, 27 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/e89028d3/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index e7d9066..0f6bc50 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.9 + * Fixed flacky SSTableRewriterTest: check file counts before calling validateCFS (CASSANDRA-12348) * cqlsh: Fix handling of $$-escaped strings (CASSANDRA-12189) * Fix SSL JMX requiring truststore containing server cert (CASSANDRA-12109) Merged from 3.0: http://git-wip-us.apache.org/repos/asf/cassandra/blob/e89028d3/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java -- diff --git a/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java b/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java index 9c6da77..246a7f0 100644 --- a/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java +++ b/test/unit/org/apache/cassandra/io/sstable/SSTableRewriterTest.java @@ -99,9 +99,9 @@ public class SSTableRewriterTest extends SSTableWriterTestBase writer.finish(); } LifecycleTransaction.waitForDeletions(); +assertEquals(1, assertFileCounts(sstables.iterator().next().descriptor.directory.list())); + validateCFS(cfs); -int filecounts = assertFileCounts(sstables.iterator().next().descriptor.directory.list()); -assertEquals(1, filecounts); truncate(cfs); } @Test @@ -131,9 +131,9 @@ public class SSTableRewriterTest extends SSTableWriterTestBase writer.finish(); } LifecycleTransaction.waitForDeletions(); +assertEquals(1, assertFileCounts(sstables.iterator().next().descriptor.directory.list())); + validateCFS(cfs); -int filecounts = assertFileCounts(sstables.iterator().next().descriptor.directory.list()); -assertEquals(1, filecounts); } @Test @@ -186,9 +186,9 @@ public class SSTableRewriterTest extends SSTableWriterTestBase writer.finish(); } LifecycleTransaction.waitForDeletions(); +assertEquals(1, assertFileCounts(sstables.iterator().next().descriptor.directory.list())); + validateCFS(cfs); -int filecounts = assertFileCounts(sstables.iterator().next().descriptor.directory.list()); -assertEquals(1, filecounts); truncate(cfs); } http://git-wip-us.apache.org/repos/asf/cassandra/blob/e89028d3/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java -- diff --git a/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java b/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java index 9c3bb19..c04fd35 100644 --- a/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java +++ b/test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java @@ -111,6 +111,25 @@ public class SSTableWriterTestBase extends SchemaLoader validateCFS(cfs); } +/** + * Validate the column family store by checking that all live + * sstables are referenced only once and are not marked as + * compacting. It also checks that the generation of the data + * files on disk is the same as that of the live sstables, + * to ensure that the data files on disk belong to the live + * sstables. Finally, it checks that the metrics contain the + * correct disk space used, live and total. + * + * Note that this method will submit a maximal compaction task + * if there are live sstables, in
[jira] [Comment Edited] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg edited comment on CASSANDRA-12228 at 8/2/16 1:45 AM: |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| I set the default back to the calculation that existed before and updated the documentation. I would like to remove memtable_cleanup_threshold scoped as part of this ticket. I can't see why you would set that to anything other than the default calculation and removing it would help offset the additional lines of doc for memtable_flush_writers. Somewhat orthogonal regarding my earlier comments about too much memory utilization. I created CASSANDRA-12358 for that. was (Author: aweisberg): |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403197#comment-15403197 ] Ariel Weisberg commented on CASSANDRA-12228: |[3.9|https://github.com/apache/cassandra/compare/cassandra-3.9...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-3.9-dtest/1/]| |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12228-3.9?expand=1]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-testall/1/]|[utest|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12228-trunk-dtest/1/]| > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg reassigned CASSANDRA-12228: -- Assignee: Ariel Weisberg (was: Marcus Eriksson) > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Ariel Weisberg >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12359) BlacklistingCompactionsTest.testBlacklistingWithSizeTieredCompactionStrategy is flaky
Joel Knighton created CASSANDRA-12359: - Summary: BlacklistingCompactionsTest.testBlacklistingWithSizeTieredCompactionStrategy is flaky Key: CASSANDRA-12359 URL: https://issues.apache.org/jira/browse/CASSANDRA-12359 Project: Cassandra Issue Type: Bug Reporter: Joel Knighton example failure: [http://cassci.datastax.com/job/cassandra-3.9_testall/50/testReport/junit/org.apache.cassandra.db.compaction/BlacklistingCompactionsTest/testBlacklistingWithSizeTieredCompactionStrategy/] Google suggests that this test is somewhat flaky historically, but we don't have logs from any of the older failures any more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12358) Slow PostFlush execution due to 2i flushing can cause near OOM to OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403128#comment-15403128 ] Ariel Weisberg commented on CASSANDRA-12358: |[trunk|https://github.com/apache/cassandra/compare/trunk...aweisberg:CASSANDRA-12358-trunk?expand=1]|[utests|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12358-trunk-testall/1/]|[dtests|https://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-12358-trunk-dtest/1/]| > Slow PostFlush execution due to 2i flushing can cause near OOM to OOM > - > > Key: CASSANDRA-12358 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12358 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg > Fix For: 3.10 > > > 2i can be slow to flush for a variety of reasons. Potentially slower than the > rate at which Memtables can ingest and flush data. If this occurs the heap > fills up with Memtables that are waiting for PostFlush to run. > This occurs because reclaiming the memory is done before PostFlush runs. > I will post a branch that has the reclaim memory task run after PostFlush has > completed. As far as I can tell this is safe and correct since the memory is > committed up until that point. > It's not clear to me if PostFlush has to bind the Memtables or not. I suspect > it does, but I'm not sure if that is a route I should go down. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-12357) dtest failure in materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Knighton resolved CASSANDRA-12357. --- Resolution: Duplicate > dtest failure in > materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test > -- > > Key: CASSANDRA-12357 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12357 > Project: Cassandra > Issue Type: Test >Reporter: Craig Kodman >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log, > node4.log, node4_debug.log, node4_gc.log, node5.log, node5_debug.log, > node5_gc.log > > > example failure: > http://cassci.datastax.com/job/cassandra-3.9_novnode_dtest/24/testReport/materialized_views_test/TestMaterializedViews/add_dc_after_mv_simple_replication_test -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12267) dtest failure in materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403127#comment-15403127 ] Joel Knighton commented on CASSANDRA-12267: --- Another recent failure [http://cassci.datastax.com/job/cassandra-3.9_novnode_dtest/24/testReport/materialized_views_test/TestMaterializedViews/add_dc_after_mv_simple_replication_test]. > dtest failure in > materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test > -- > > Key: CASSANDRA-12267 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12267 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log, > node4.log, node4_debug.log, node4_gc.log, node5.log, node5_debug.log, > node5_gc.log > > > example failure: > http://cassci.datastax.com/job/trunk_novnode_dtest/432/testReport/materialized_views_test/TestMaterializedViews/add_dc_after_mv_simple_replication_test > {code} > Standard Output > Unexpected error in node4 log, error: > ERROR [main] 2016-07-21 01:57:17,951 MigrationManager.java:164 - Migration > task failed to complete > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12358) Slow PostFlush execution due to 2i flushing can cause near OOM to OOM
Ariel Weisberg created CASSANDRA-12358: -- Summary: Slow PostFlush execution due to 2i flushing can cause near OOM to OOM Key: CASSANDRA-12358 URL: https://issues.apache.org/jira/browse/CASSANDRA-12358 Project: Cassandra Issue Type: Bug Components: Core Reporter: Ariel Weisberg Assignee: Ariel Weisberg Fix For: 3.10 2i can be slow to flush for a variety of reasons. Potentially slower than the rate at which Memtables can ingest and flush data. If this occurs the heap fills up with Memtables that are waiting for PostFlush to run. This occurs because reclaiming the memory is done before PostFlush runs. I will post a branch that has the reclaim memory task run after PostFlush has completed. As far as I can tell this is safe and correct since the memory is committed up until that point. It's not clear to me if PostFlush has to bind the Memtables or not. I suspect it does, but I'm not sure if that is a route I should go down. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403091#comment-15403091 ] sankalp kohli commented on CASSANDRA-9507: -- This is not a critical fix so its fine to leave it out for 2.1 and 2.2...we are fine doing this in 3.0 > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, > CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403043#comment-15403043 ] Russ Hatch commented on CASSANDRA-12352: [~craig.kodman] could you clarify what the Decription above means? Are those all failures for this issue? > dtest failure in > upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test > > > Key: CASSANDRA-12352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12352 > Project: Cassandra > Issue Type: Test >Reporter: Craig Kodman >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node2.log, node2_debug.log > > > example failure: > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ >
cassandra git commit: use StringBuilder correctly
Repository: cassandra Updated Branches: refs/heads/trunk eaf4b91ae -> f59a78b76 use StringBuilder correctly Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f59a78b7 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f59a78b7 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f59a78b7 Branch: refs/heads/trunk Commit: f59a78b7625f7679794c3db1a185344af1353ebd Parents: eaf4b91 Author: Dave BrosiusAuthored: Mon Aug 1 19:35:51 2016 -0400 Committer: Dave Brosius Committed: Mon Aug 1 19:35:51 2016 -0400 -- src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java | 2 +- src/java/org/apache/cassandra/gms/FailureDetector.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f59a78b7/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java -- diff --git a/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java b/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java index f040575..91c04a8 100644 --- a/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java +++ b/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java @@ -330,7 +330,7 @@ public class ColumnFamilyStoreCQLHelper { builder.append(singleQuote(entry.getKey())); builder.append(": "); -builder.append("0x" + ByteBufferUtil.bytesToHex(entry.getValue())); + builder.append("0x").append(ByteBufferUtil.bytesToHex(entry.getValue())); } builder.append(" }"); return builder.toString(); http://git-wip-us.apache.org/repos/asf/cassandra/blob/f59a78b7/src/java/org/apache/cassandra/gms/FailureDetector.java -- diff --git a/src/java/org/apache/cassandra/gms/FailureDetector.java b/src/java/org/apache/cassandra/gms/FailureDetector.java index 7d8b88b..c73cc07 100644 --- a/src/java/org/apache/cassandra/gms/FailureDetector.java +++ b/src/java/org/apache/cassandra/gms/FailureDetector.java @@ -351,7 +351,7 @@ public class FailureDetector implements IFailureDetector, FailureDetectorMBean for (InetAddress ep : eps) { ArrivalWindow hWnd = arrivalSamples.get(ep); -sb.append(ep + " : "); +sb.append(ep).append(" : "); sb.append(hWnd); sb.append(System.getProperty("line.separator")); }
[jira] [Commented] (CASSANDRA-12341) dtest failure in hintedhandoff_test.TestHintedHandoffConfig.hintedhandoff_enabled_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403040#comment-15403040 ] Russ Hatch commented on CASSANDRA-12341: Single Ci failure, multiplexing x100 here: http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/206/ > dtest failure in > hintedhandoff_test.TestHintedHandoffConfig.hintedhandoff_enabled_test > -- > > Key: CASSANDRA-12341 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12341 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log > > > example failure: > http://cassci.datastax.com/job/trunk_novnode_dtest/440/testReport/hintedhandoff_test/TestHintedHandoffConfig/hintedhandoff_enabled_test > {code} > Error Message > 29 Jul 2016 00:56:17 [node1] Missing: ['Finished hinted']: > INFO [HANDSHAKE-/127.0.0.2] 2016-07-29 00:54:14,4. > See system.log for remainder > {code} > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/hintedhandoff_test.py", line 125, in > hintedhandoff_enabled_test > self._do_hinted_handoff(node1, node2, True) > File "/home/automaton/cassandra-dtest/hintedhandoff_test.py", line 61, in > _do_hinted_handoff > node1.watch_log_for(["Finished hinted"], from_mark=log_mark, timeout=120) > File "/home/automaton/ccm/ccmlib/node.py", line 449, in watch_log_for > raise TimeoutError(time.strftime("%d %b %Y %H:%M:%S", time.gmtime()) + " > [" + self.name + "] Missing: " + str([e.pattern for e in tofind]) + ":\n" + > reads[:50] + ".\nSee {} for remainder".format(filename)) > "29 Jul 2016 00:56:17 [node1] Missing: ['Finished hinted']:\nINFO > [HANDSHAKE-/127.0.0.2] 2016-07-29 00:54:14,4.\nSee system.log for > remainder > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12347) Gossip 2.0 - broadcast tree for data dissemination
[ https://issues.apache.org/jira/browse/CASSANDRA-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403031#comment-15403031 ] Jason Brown commented on CASSANDRA-12347: - A first pass implementation can be found here: https://github.com/jasobrown/cassandra/tree/broadcast_thicket The functionality is 97% complete - I discovered a missing functionality this morning while reviewing, and I also need to update the simulator (as I finally discovered {{IMessageSink}}) as well as adding more documentation. That being said, I wanted to get this out for review in conjunction with CASSANDRA-12346 (which this ticket depends on; current thicket implementation is based upon hyparview branch's git sha e132ef289d14a0522a5f0c44bc81d65a67894e9e). > Gossip 2.0 - broadcast tree for data dissemination > -- > > Key: CASSANDRA-12347 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12347 > Project: Cassandra > Issue Type: Improvement >Reporter: Jason Brown > > Description: A broadcast tree (spanning tree) allows an originating node to > efficiently send out updates to all of the peers in the cluster by > constructing a balanced, self-healing tree based upon the view it gets from > the peer sampling service (CASSANDRA-12346). > I propose we use an algorithm based on the [Thicket > paper|http://www.gsd.inesc-id.pt/%7Ejleitao/pdf/srds10-mario.pdf], which > describes a dynamic, self-healing broadcast tree. When a given node needs to > send out a message, it dynamically builds a tree for each node in the > cluster; thus giving us a unique tree for every node in the cluster (a tree > rooted at every cluster node). The trees, of course, would be reusable until > the cluster configurations changes or failures are detected (by the mechanism > described in the paper). Additionally, Thicket includes a mechanism for > load-balancing the trees such that nodes spread out the work amongst > themselves. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12316) dtest failure in cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_round_trip_random
[ https://issues.apache.org/jira/browse/CASSANDRA-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402980#comment-15402980 ] Russ Hatch commented on CASSANDRA-12316: This looks like possibly just an ephemeral env problem {noformat}('Unable to connect to any servers', {'127.0.0.1': error(111, "Tried connecting to [('127.0.0.1', 9042)]. Last error: Connection refused")}){noformat} But multiplexing the test here to be sure: http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/205/ > dtest failure in > cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_round_trip_random > -- > > Key: CASSANDRA-12316 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12316 > Project: Cassandra > Issue Type: Test >Reporter: Craig Kodman >Assignee: DS Test Eng > Labels: dtest > > example failure: > http://cassci.datastax.com/job/cassandra-3.9_novnode_dtest/16/testReport/cqlsh_tests.cqlsh_copy_tests/CqlshCopyTest/test_round_trip_random -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11687) dtest failure in rebuild_test.TestRebuild.simple_rebuild_test
[ https://issues.apache.org/jira/browse/CASSANDRA-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402950#comment-15402950 ] Yuki Morishita commented on CASSANDRA-11687: New PR here: https://github.com/riptano/cassandra-dtest/pull/1158 > dtest failure in rebuild_test.TestRebuild.simple_rebuild_test > - > > Key: CASSANDRA-11687 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11687 > Project: Cassandra > Issue Type: Bug >Reporter: Russ Hatch >Assignee: Yuki Morishita > Labels: dtest > > single failure on most recent run (3.0 no-vnode) > {noformat} > concurrent rebuild should not be allowed, but one rebuild command should have > succeeded. > {noformat} > http://cassci.datastax.com/job/cassandra-3.0_novnode_dtest/217/testReport/rebuild_test/TestRebuild/simple_rebuild_test > Failed on CassCI build cassandra-3.0_novnode_dtest #217 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11687) dtest failure in rebuild_test.TestRebuild.simple_rebuild_test
[ https://issues.apache.org/jira/browse/CASSANDRA-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuki Morishita updated CASSANDRA-11687: --- Status: Patch Available (was: Open) > dtest failure in rebuild_test.TestRebuild.simple_rebuild_test > - > > Key: CASSANDRA-11687 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11687 > Project: Cassandra > Issue Type: Bug >Reporter: Russ Hatch >Assignee: Yuki Morishita > Labels: dtest > > single failure on most recent run (3.0 no-vnode) > {noformat} > concurrent rebuild should not be allowed, but one rebuild command should have > succeeded. > {noformat} > http://cassci.datastax.com/job/cassandra-3.0_novnode_dtest/217/testReport/rebuild_test/TestRebuild/simple_rebuild_test > Failed on CassCI build cassandra-3.0_novnode_dtest #217 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12267) dtest failure in materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402949#comment-15402949 ] Russ Hatch commented on CASSANDRA-12267: one flap in recent history, multiplexing x100 here: http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/204/ > dtest failure in > materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test > -- > > Key: CASSANDRA-12267 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12267 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log, > node4.log, node4_debug.log, node4_gc.log, node5.log, node5_debug.log, > node5_gc.log > > > example failure: > http://cassci.datastax.com/job/trunk_novnode_dtest/432/testReport/materialized_views_test/TestMaterializedViews/add_dc_after_mv_simple_replication_test > {code} > Standard Output > Unexpected error in node4 log, error: > ERROR [main] 2016-07-21 01:57:17,951 MigrationManager.java:164 - Migration > task failed to complete > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CASSANDRA-12234) dtest failure in sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_uppercase_keyspace_name_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russ Hatch reassigned CASSANDRA-12234: -- Assignee: Russ Hatch (was: DS Test Eng) > dtest failure in > sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_uppercase_keyspace_name_test > --- > > Key: CASSANDRA-12234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12234 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Russ Hatch > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log > > > example failure: > http://cassci.datastax.com/job/trunk_novnode_dtest/430/testReport/sstable_generation_loading_test/TestSSTableGenerationAndLoading/sstableloader_uppercase_keyspace_name_test > Failed on CassCI build trunk_novnode_dtest #430 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/sstable_generation_loading_test.py", > line 229, in sstableloader_uppercase_keyspace_name_test > self.load_sstable_with_configuration(ks='"Keyspace1"') > File "/home/automaton/cassandra-dtest/sstable_generation_loading_test.py", > line 187, in load_sstable_with_configuration > "sstableloader exited with a non-zero status: {}".format(exit_status)) > File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual > assertion_func(first, second, msg=msg) > File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual > raise self.failureException(msg) > "sstableloader exited with a non-zero status: 1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12234) dtest failure in sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_uppercase_keyspace_name_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402866#comment-15402866 ] Russ Hatch commented on CASSANDRA-12234: looks like only a single recent failure. multiplexing x100 here: http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/202/ > dtest failure in > sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_uppercase_keyspace_name_test > --- > > Key: CASSANDRA-12234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12234 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log > > > example failure: > http://cassci.datastax.com/job/trunk_novnode_dtest/430/testReport/sstable_generation_loading_test/TestSSTableGenerationAndLoading/sstableloader_uppercase_keyspace_name_test > Failed on CassCI build trunk_novnode_dtest #430 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/sstable_generation_loading_test.py", > line 229, in sstableloader_uppercase_keyspace_name_test > self.load_sstable_with_configuration(ks='"Keyspace1"') > File "/home/automaton/cassandra-dtest/sstable_generation_loading_test.py", > line 187, in load_sstable_with_configuration > "sstableloader exited with a non-zero status: {}".format(exit_status)) > File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual > assertion_func(first, second, msg=msg) > File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual > raise self.failureException(msg) > "sstableloader exited with a non-zero status: 1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-12116) dtest failure in snapshot_test.TestSnapshot.test_basic_snapshot_and_restore
[ https://issues.apache.org/jira/browse/CASSANDRA-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russ Hatch resolved CASSANDRA-12116. Resolution: Cannot Reproduce 200 iterations without a repro. Closing. > dtest failure in snapshot_test.TestSnapshot.test_basic_snapshot_and_restore > --- > > Key: CASSANDRA-12116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12116 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_novnode_dtest/260/testReport/snapshot_test/TestSnapshot/test_basic_snapshot_and_restore > Failed on CassCI build cassandra-2.1_novnode_dtest #260 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/snapshot_test.py", line 96, in > test_basic_snapshot_and_restore > self.restore_snapshot(snapshot_dir, node1, 'ks', 'cf') > File "/home/automaton/cassandra-dtest/snapshot_test.py", line 68, in > restore_snapshot > (" ".join(args), exit_status, stdout, stderr)) > 'sstableloader command \'/home/automaton/cassandra/bin/sstableloader -d > 127.0.0.1 /tmp/tmpGgR_dT/0/ks/cf\' failed; exit status: 1\' > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12196) dtest failure in upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_2_1_x_To_indev_3_x.bootstrap_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402800#comment-15402800 ] Russ Hatch commented on CASSANDRA-12196: We should re-check this failure against the dtest large job, now that the upgrade tests have moved over there. Job here: http://cassci.datastax.com/view/trunk/job/trunk_large_dtest/ > dtest failure in > upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_2_1_x_To_indev_3_x.bootstrap_test > -- > > Key: CASSANDRA-12196 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12196 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log, > node4.log, node4_debug.log, node4_gc.log > > > example failure: > http://cassci.datastax.com/job/upgrade_tests-all/59/testReport/upgrade_tests.upgrade_through_versions_test/TestUpgrade_current_2_1_x_To_indev_3_x/bootstrap_test > Failed on CassCI build upgrade_tests-all #59 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 707, in bootstrap_test > self.upgrade_scenario(after_upgrade_call=(self._bootstrap_new_node,)) > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 383, in upgrade_scenario > call() > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 688, in _bootstrap_new_node > nnode.start(use_jna=True, wait_other_notice=True, > wait_for_binary_proto=True) > File "/home/automaton/ccm/ccmlib/node.py", line 634, in start > node.watch_log_for_alive(self, from_mark=mark) > File "/home/automaton/ccm/ccmlib/node.py", line 481, in watch_log_for_alive > self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout, > filename=filename) > File "/home/automaton/ccm/ccmlib/node.py", line 449, in watch_log_for > raise TimeoutError(time.strftime("%d %b %Y %H:%M:%S", time.gmtime()) + " > [" + self.name + "] Missing: " + str([e.pattern for e in tofind]) + ":\n" + > reads[:50] + ".\nSee {} for remainder".format(filename)) > "13 Jul 2016 02:23:05 [node2] Missing: ['127.0.0.4.* now UP']:\nINFO > [HANDSHAKE-/127.0.0.4] 2016-07-13 02:21:00,2.\nSee system.log for > remainder > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12228) Write performance regression in 3.x vs 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402770#comment-15402770 ] Ariel Weisberg commented on CASSANDRA-12228: I was incorrect. JMXEnabledThreadPoolExecutor automatically sets core pool threads to max if you only specify core pool threads. So I am running into some other pain point around memory accounting unrelated to flushing performance. > Write performance regression in 3.x vs 3.0 > -- > > Key: CASSANDRA-12228 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12228 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 3.9 > > > I've been tracking down a performance issue in trunk vs cassandra-3.0 branch. > I think I've found it. CASSANDRA-6696 changed the default memtable flush > default to 1 vs the min of 2 in cassandra-3.0. > I don't see any technical reason for this and we should add back the min of 2 > sstable flushers per disk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402754#comment-15402754 ] Nachiket Patil commented on CASSANDRA-9507: --- Hi [~ifesdjeen], I had uploaded patches but didn't check if the status of the JIRA changed to Patch Available. The patches you are looking at are correct. The Latency is added in the RangeCommandIterator::close() method which is for reading complete range. Not sure we should be measuring individual read. I agree this is not a critical patch. We are not patching only 2.1 branch with non-critical fixes right? We can still get this patch in 2.2, 3.0 - trunk. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, > CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11990) Address rows rather than partitions in SASI
[ https://issues.apache.org/jira/browse/CASSANDRA-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402741#comment-15402741 ] DOAN DuyHai commented on CASSANDRA-11990: - bq. backward-compatibility support Can you clarify about this backward-compatibility ? Between what and what ? > Address rows rather than partitions in SASI > --- > > Key: CASSANDRA-11990 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11990 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: Alex Petrov >Assignee: Alex Petrov > Attachments: perf.pdf, size_comparison.png > > > Currently, the lookup in SASI index would return the key position of the > partition. After the partition lookup, the rows are iterated and the > operators are applied in order to filter out ones that do not match. > bq. TokenTree which accepts variable size keys (such would enable different > partitioners, collections support, primary key indexing etc.), -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12357) dtest failure in materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test
Craig Kodman created CASSANDRA-12357: Summary: dtest failure in materialized_views_test.TestMaterializedViews.add_dc_after_mv_simple_replication_test Key: CASSANDRA-12357 URL: https://issues.apache.org/jira/browse/CASSANDRA-12357 Project: Cassandra Issue Type: Test Reporter: Craig Kodman Assignee: DS Test Eng Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log, node4.log, node4_debug.log, node4_gc.log, node5.log, node5_debug.log, node5_gc.log example failure: http://cassci.datastax.com/job/cassandra-3.9_novnode_dtest/24/testReport/materialized_views_test/TestMaterializedViews/add_dc_after_mv_simple_replication_test -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-12195) dtest failure in upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_2_2_x_To_indev_3_0_x.rolling_upgrade_with_internode_ssl_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russ Hatch resolved CASSANDRA-12195. Resolution: Not A Problem > dtest failure in > upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_2_2_x_To_indev_3_0_x.rolling_upgrade_with_internode_ssl_test > - > > Key: CASSANDRA-12195 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12195 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_gc.log, node3.log, node3_debug.log, node3_gc.log > > > example failure: > http://cassci.datastax.com/job/upgrade_tests-all/59/testReport/upgrade_tests.upgrade_through_versions_test/TestUpgrade_current_2_2_x_To_indev_3_0_x/rolling_upgrade_with_internode_ssl_test > Failed on CassCI build upgrade_tests-all #59 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 295, in rolling_upgrade_with_internode_ssl_test > self.upgrade_scenario(rolling=True, internode_ssl=True) > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 352, in upgrade_scenario > self._check_on_subprocs(self.subprocs) > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 409, in _check_on_subprocs > raise RuntimeError(message) > "A subprocess has terminated early. Subprocess statuses: Process-13 > (is_alive: False), Process-14 (is_alive: True), Process-15 (is_alive: True), > Process-16 (is_alive: True), attempting to terminate remaining subprocesses > now. > {code} > node2_debug.log is too large to attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12195) dtest failure in upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_2_2_x_To_indev_3_0_x.rolling_upgrade_with_internode_ssl_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402690#comment-15402690 ] Russ Hatch commented on CASSANDRA-12195: With this (or similar) test moved now to the dtest large job, I don't see any recent failure. In any case, if it recurs I think we'll get better debug output. I think this is safe to resolve for now and can be reopened later if it happens again. > dtest failure in > upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_2_2_x_To_indev_3_0_x.rolling_upgrade_with_internode_ssl_test > - > > Key: CASSANDRA-12195 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12195 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_gc.log, node3.log, node3_debug.log, node3_gc.log > > > example failure: > http://cassci.datastax.com/job/upgrade_tests-all/59/testReport/upgrade_tests.upgrade_through_versions_test/TestUpgrade_current_2_2_x_To_indev_3_0_x/rolling_upgrade_with_internode_ssl_test > Failed on CassCI build upgrade_tests-all #59 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 295, in rolling_upgrade_with_internode_ssl_test > self.upgrade_scenario(rolling=True, internode_ssl=True) > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 352, in upgrade_scenario > self._check_on_subprocs(self.subprocs) > File > "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_through_versions_test.py", > line 409, in _check_on_subprocs > raise RuntimeError(message) > "A subprocess has terminated early. Subprocess statuses: Process-13 > (is_alive: False), Process-14 (is_alive: True), Process-15 (is_alive: True), > Process-16 (is_alive: True), attempting to terminate remaining subprocesses > now. > {code} > node2_debug.log is too large to attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12160) dtest failure in counter_tests.TestCounters.upgrade_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402683#comment-15402683 ] Russ Hatch commented on CASSANDRA-12160: There was a single failure in the multiplex job above, but it appears to have another cause (judging from the exception likely a routine failure). Resolving this ticket. > dtest failure in counter_tests.TestCounters.upgrade_test > > > Key: CASSANDRA-12160 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12160 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Russ Hatch > Labels: dtest > Attachments: node1.log, node2.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest/493/testReport/counter_tests/TestCounters/upgrade_test > Failed on CassCI build cassandra-2.1_dtest #493 > {code} > Error Message > 07 Jul 2016 21:07:28 [node1] Missing: ['127.0.0.2.* now UP']: > . > See system.log for remainder > {code} > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/counter_tests.py", line 101, in > upgrade_test > rolling_restart() > File "/home/automaton/cassandra-dtest/counter_tests.py", line 96, in > rolling_restart > nodes[i].start(wait_other_notice=True, wait_for_binary_proto=True) > File "/home/automaton/ccm/ccmlib/node.py", line 634, in start > node.watch_log_for_alive(self, from_mark=mark) > File "/home/automaton/ccm/ccmlib/node.py", line 481, in watch_log_for_alive > self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout, > filename=filename) > File "/home/automaton/ccm/ccmlib/node.py", line 449, in watch_log_for > raise TimeoutError(time.strftime("%d %b %Y %H:%M:%S", time.gmtime()) + " > [" + self.name + "] Missing: " + str([e.pattern for e in tofind]) + ":\n" + > reads[:50] + ".\nSee {} for remainder".format(filename)) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-12160) dtest failure in counter_tests.TestCounters.upgrade_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russ Hatch resolved CASSANDRA-12160. Resolution: Cannot Reproduce > dtest failure in counter_tests.TestCounters.upgrade_test > > > Key: CASSANDRA-12160 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12160 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Russ Hatch > Labels: dtest > Attachments: node1.log, node2.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest/493/testReport/counter_tests/TestCounters/upgrade_test > Failed on CassCI build cassandra-2.1_dtest #493 > {code} > Error Message > 07 Jul 2016 21:07:28 [node1] Missing: ['127.0.0.2.* now UP']: > . > See system.log for remainder > {code} > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/counter_tests.py", line 101, in > upgrade_test > rolling_restart() > File "/home/automaton/cassandra-dtest/counter_tests.py", line 96, in > rolling_restart > nodes[i].start(wait_other_notice=True, wait_for_binary_proto=True) > File "/home/automaton/ccm/ccmlib/node.py", line 634, in start > node.watch_log_for_alive(self, from_mark=mark) > File "/home/automaton/ccm/ccmlib/node.py", line 481, in watch_log_for_alive > self.watch_log_for(tofind, from_mark=from_mark, timeout=timeout, > filename=filename) > File "/home/automaton/ccm/ccmlib/node.py", line 449, in watch_log_for > raise TimeoutError(time.strftime("%d %b %Y %H:%M:%S", time.gmtime()) + " > [" + self.name + "] Missing: " + str([e.pattern for e in tofind]) + ":\n" + > reads[:50] + ".\nSee {} for remainder".format(filename)) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12116) dtest failure in snapshot_test.TestSnapshot.test_basic_snapshot_and_restore
[ https://issues.apache.org/jira/browse/CASSANDRA-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402677#comment-15402677 ] Russ Hatch commented on CASSANDRA-12116: Looks like no failure since build #260. Multiplexing here: http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/201/ > dtest failure in snapshot_test.TestSnapshot.test_basic_snapshot_and_restore > --- > > Key: CASSANDRA-12116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12116 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_novnode_dtest/260/testReport/snapshot_test/TestSnapshot/test_basic_snapshot_and_restore > Failed on CassCI build cassandra-2.1_novnode_dtest #260 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/snapshot_test.py", line 96, in > test_basic_snapshot_and_restore > self.restore_snapshot(snapshot_dir, node1, 'ks', 'cf') > File "/home/automaton/cassandra-dtest/snapshot_test.py", line 68, in > restore_snapshot > (" ".join(args), exit_status, stdout, stderr)) > 'sstableloader command \'/home/automaton/cassandra/bin/sstableloader -d > 127.0.0.1 /tmp/tmpGgR_dT/0/ks/cf\' failed; exit status: 1\' > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Kodman updated CASSANDRA-12352: - Description: example failure: http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/test_data_change_impacting_later_page/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/expanded_list_item_conditional_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/no_range_ghost_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_compact_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/counters_test/
[jira] [Created] (CASSANDRA-12356) dtest failure in upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_2_2_x.bug_10652_test
Craig Kodman created CASSANDRA-12356: Summary: dtest failure in upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_2_2_x.bug_10652_test Key: CASSANDRA-12356 URL: https://issues.apache.org/jira/browse/CASSANDRA-12356 Project: Cassandra Issue Type: Test Reporter: Craig Kodman Assignee: DS Test Eng Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, node3.log example failure: http://cassci.datastax.com/job/cassandra-2.2_dtest_upgrade/7/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_2_2_x/bug_10652_test -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Kodman updated CASSANDRA-12352: - Description: example failure: http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/test_data_change_impacting_later_page/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/expanded_list_item_conditional_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/no_range_ghost_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_compact_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/counters_test/
[jira] [Updated] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Kodman updated CASSANDRA-12352: - Description: example failure: http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/test_data_change_impacting_later_page/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/expanded_list_item_conditional_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/no_range_ghost_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_compact_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/counters_test/
[jira] [Updated] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Kodman updated CASSANDRA-12352: - Description: example failure: http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/test_data_change_impacting_later_page/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/expanded_list_item_conditional_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/no_range_ghost_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_compact_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/counters_test/
[jira] [Commented] (CASSANDRA-12064) dtest failure in auth_test.TestAuth.login_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402619#comment-15402619 ] Russ Hatch commented on CASSANDRA-12064: Looks like that last one was 100% pass -- can we close this? > dtest failure in auth_test.TestAuth.login_test > -- > > Key: CASSANDRA-12064 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12064 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: DS Test Eng > Labels: dtest > Fix For: 3.9 > > Attachments: node1.log, node1_debug.log, node1_gc.log > > > example failure: > http://cassci.datastax.com/job/trunk_dtest/1284/testReport/auth_test/TestAuth/login_test > Failed on CassCI build trunk_dtest #1284 > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/auth_test.py", line 82, in login_test > assert isinstance(e.errors.values()[0], AuthenticationFailed) > {code} > Logs are attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12355) Install Errored: 'apt-get update' failed exit status: 100
VIJAY KUMAR VELPULA created CASSANDRA-12355: --- Summary: Install Errored: 'apt-get update' failed exit status: 100 Key: CASSANDRA-12355 URL: https://issues.apache.org/jira/browse/CASSANDRA-12355 Project: Cassandra Issue Type: Bug Components: Configuration Environment: DSE v4.8 OPSCenter v5.2.4 ubuntu 14.04 Reporter: VIJAY KUMAR VELPULA Attachments: apt-get update.txt while building new cluster from Opscenter 5.2.4 we are facing error "Install Errored: 'apt-get update' failed exit status: 100 ". Attaching stdout & stderr: logs. Thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11909) dtest failure in cql_tests.AbortedQueriesTester.remote_query_test
[ https://issues.apache.org/jira/browse/CASSANDRA-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402613#comment-15402613 ] Russ Hatch commented on CASSANDRA-11909: looks like there's been a large number of passes on this tests since the last failure, might not be a problem anymore? > dtest failure in cql_tests.AbortedQueriesTester.remote_query_test > - > > Key: CASSANDRA-11909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11909 > Project: Cassandra > Issue Type: Test >Reporter: Craig Kodman >Assignee: DS Test Eng > Labels: dtest > Fix For: 3.9 > > > example failure: > http://cassci.datastax.com/job/trunk_dtest/1243/testReport/cql_tests/AbortedQueriesTester/remote_query_test > Failed on CassCI build trunk_dtest #1243 > {code} > ERROR [SharedPool-Worker-1] 2016-05-27 10:08:49,471 Keyspace.java:504 - > Attempting to mutate non-existant table 01855840-23f3-11e6-912e-c5dc3b68cc6d > (ks.test2) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11990) Address rows rather than partitions in SASI
[ https://issues.apache.org/jira/browse/CASSANDRA-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402577#comment-15402577 ] Alex Petrov commented on CASSANDRA-11990: - We've tried out the idea of using the column offset for the query optimisation. I've showed results to [~xedin] and [~beobal] and for now we concluded that we can leave this optimisation out for now (as it'd be a significant change). It might come very handy if / when we have an ability to compare clusterings (by some sort of order-preserving hash function) rather than just offsets. Only big thing that's left is to bring back the backward-compatibility support, which I was leaving for the end as code got restructured several times. I'll get to it and hope to present a preliminary result shortly. > Address rows rather than partitions in SASI > --- > > Key: CASSANDRA-11990 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11990 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: Alex Petrov >Assignee: Alex Petrov > Attachments: perf.pdf, size_comparison.png > > > Currently, the lookup in SASI index would return the key position of the > partition. After the partition lookup, the rows are iterated and the > operators are applied in order to filter out ones that do not match. > bq. TokenTree which accepts variable size keys (such would enable different > partitioners, collections support, primary key indexing etc.), -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12354) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_2_x_To_indev_2_2_x.bug_5732_test
Craig Kodman created CASSANDRA-12354: Summary: dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_2_x_To_indev_2_2_x.bug_5732_test Key: CASSANDRA-12354 URL: https://issues.apache.org/jira/browse/CASSANDRA-12354 Project: Cassandra Issue Type: Test Reporter: Craig Kodman Assignee: DS Test Eng example failure: http://cassci.datastax.com/job/cassandra-2.2_dtest_upgrade/7/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_2_x_To_indev_2_2_x/bug_5732_test -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-11990) Address rows rather than partitions in SASI
[ https://issues.apache.org/jira/browse/CASSANDRA-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399120#comment-15399120 ] Alex Petrov edited comment on CASSANDRA-11990 at 8/1/16 6:24 PM: - During several discussions with [~xedin] we came up with an idea to evaluate the support for different partitioners, since it'd help with wider SASI adoption and remove current limitation of Long tokens. I've evaluated the support, and can conclude that supporting the constant-size tokens can be included into the patch without large overhead. Patch was adjusted accordingly. There are still several failing tests, although they'll be fixed shortly. Support for variable-size tokens (for partitioners such as {{ByteOrderedPartitioner}} requires much larger time investment. My personal suggestion is to encode them with the size and avoid on-disk format changes. This will result into more complex iteration process for variable-size tokens, since we'll have to skip tokens depending on the size and won't be able to use simple multiplication for offset calculation. I've made a small patch / proof of concept for variable size tokens by adding `serializedSize` method into the token tree nodes, currently (for sakes of POC and in order to save some time), it was done by reusing the `serialize` function and passing a throwaway byte buffer, and calculating offsets by iterating and reading integers with token size. It worked just fine for simple cases. I'll mention that SASI code is written very well and offset calculation methods are very well isolated. Having that said, I'd suggest to leave the "algorithmic" heavy-lifting (variable token offset calculation) for the separate ticket to reduce the scope of current ticket. Since it's not going to require the on-disk format changes, we can safely postpone this work. Another thing that's been mentioned was is to include the column offset into clustering offset long. I'll be evaluating this proposal in terms of performance today. It seems that we can avoid increasing the size of {{long[]}} array that hold offsets and this change can help to avoid post-filtering alltogether. Additional optimisation (which, once again, could be left for the follow-up patch) is to avoid the second seek within the data file for cases when we are only querying columns that are indexed. This can be a significant performance improvement, although it'd be good to discuss whether such queries are widely used. cc [~slebresne] [~iamaleksey] [~jbellis] [~beobal] was (Author: ifesdjeen): During several discussions it's been proposed to evaluate the support for different partitioners, since it'd help with wider SASI adoption and remove current limitation of Long tokens. I've evaluated the support, and can conclude that supporting the constant-size tokens can be included into the patch without large overhead. Patch was adjusted accordingly. There are still several failing tests, although they'll be fixed shortly. Support for variable-size tokens (for partitioners such as {{ByteOrderedPartitioner}} requires much larger time investment. My personal suggestion is to encode them with the size and avoid on-disk format changes. This will result into more complex iteration process for variable-size tokens, since we'll have to skip tokens depending on the size and won't be able to use simple multiplication for offset calculation. I've made a small patch / proof of concept for variable size tokens by adding `serializedSize` method into the token tree nodes, currently (for sakes of POC and in order to save some time), it was done by reusing the `serialize` function and passing a throwaway byte buffer, and calculating offsets by iterating and reading integers with token size. It worked just fine for simple cases. I'll mention that SASI code is written very well and offset calculation methods are very well isolated. Having that said, I'd suggest to leave the "algorithmic" heavy-lifting (variable token offset calculation) for the separate ticket to reduce the scope of current ticket. Since it's not going to require the on-disk format changes, we can safely postpone this work. Another thing that's been mentioned was is to include the column offset into clustering offset long. I'll be evaluating this proposal in terms of performance today. It seems that we can avoid increasing the size of {{long[]}} array that hold offsets and this change can help to avoid post-filtering alltogether. Additional optimisation (which, once again, could be left for the follow-up patch) is to avoid the second seek within the data file for cases when we are only querying columns that are indexed. This can be a significant performance improvement, although it'd be good to discuss whether such queries are widely used. cc [~slebresne] [~iamaleksey] [~jbellis] [~beobal] > Address rows
[jira] [Commented] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402543#comment-15402543 ] Craig Kodman commented on CASSANDRA-12352: -- This might be an environmental issue. It might be best to look into that first to eliminate that as a cause. > dtest failure in > upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test > > > Key: CASSANDRA-12352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12352 > Project: Cassandra > Issue Type: Test >Reporter: Craig Kodman >Assignee: DS Test Eng > Labels: dtest > Attachments: node1.log, node1_debug.log, node2.log, node2_debug.log > > > example failure: > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ > http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ >
[jira] [Updated] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Kodman updated CASSANDRA-12352: - Description: example failure: http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/test_data_change_impacting_later_page/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/expanded_list_item_conditional_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/no_range_ghost_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_compact_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/counters_test/
[jira] [Commented] (CASSANDRA-12008) Make decommission operations resumable
[ https://issues.apache.org/jira/browse/CASSANDRA-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402469#comment-15402469 ] Yuki Morishita commented on CASSANDRA-12008: Isn't the name {{streamed_ranges}} already indicate outgoing only? The source of {{streamed_ranges}} is {{transferredRangesPerKeyspace}} and it should be only appear when there is outgoing stream. > Make decommission operations resumable > -- > > Key: CASSANDRA-12008 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12008 > Project: Cassandra > Issue Type: Improvement > Components: Streaming and Messaging >Reporter: Tom van der Woerdt >Assignee: Kaide Mu >Priority: Minor > > We're dealing with large data sets (multiple terabytes per node) and > sometimes we need to add or remove nodes. These operations are very dependent > on the entire cluster being up, so while we're joining a new node (which > sometimes takes 6 hours or longer) a lot can go wrong and in a lot of cases > something does. > It would be great if the ability to retry streams was implemented. > Example to illustrate the problem : > {code} > 03:18 PM ~ $ nodetool decommission > error: Stream failed > -- StackTrace -- > org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:85) > at com.google.common.util.concurrent.Futures$6.run(Futures.java:1310) > at > com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457) > at > com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156) > at > com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:202) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:210) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:186) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:430) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:622) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:486) > at > org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:274) > at java.lang.Thread.run(Thread.java:745) > 08:04 PM ~ $ nodetool decommission > nodetool: Unsupported operation: Node in LEAVING state; wait for status to > become normal or restart > See 'nodetool help' or 'nodetool help '. > {code} > Streaming failed, probably due to load : > {code} > ERROR [STREAM-IN-/] 2016-06-14 18:05:47,275 StreamSession.java:520 - > [Stream #] Streaming error occurred > java.net.SocketTimeoutException: null > at > sun.nio.ch.SocketAdaptor$SocketInputStream.read(SocketAdaptor.java:211) > ~[na:1.8.0_77] > at sun.nio.ch.ChannelInputStream.read(ChannelInputStream.java:103) > ~[na:1.8.0_77] > at > java.nio.channels.Channels$ReadableByteChannelImpl.read(Channels.java:385) > ~[na:1.8.0_77] > at > org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:54) > ~[apache-cassandra-3.0.6.jar:3.0.6] > at > org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:268) > ~[apache-cassandra-3.0.6.jar:3.0.6] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_77] > {code} > If implementing retries is not possible, can we have a 'nodetool decommission > resume'? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12340) dtest failure in upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402444#comment-15402444 ] Joel Knighton edited comment on CASSANDRA-12340 at 8/1/16 5:17 PM: --- The correct answer to that is probably committers/broadly the PMC, but I'm happy to step up and say in this case that the answer would almost certainly be no. This shouldn't cause correctness issues or stop the cluster from functioning correctly, so I don't think it meets the bar for a critical fix at the risk of introducing regressions. The C* problem should definitely be fixed in 2.2+ (and I will do the fix in [CASSANDRA-12313] or [CASSANDRA-12260]). was (Author: jkni): The correct answer to that is probably committers/broadly the PMC, but I'm happy to set up and say in this case that the answer would almost certainly be no. This shouldn't cause correctness issues or stop the cluster from functioning correctly, so I don't think it meets the bar for a critical fix at the risk of introducing regressions. The C* problem should definitely be fixed in 2.2+ (and I will do the fix in [CASSANDRA-12313] or [CASSANDRA-12260]). > dtest failure in > upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test > --- > > Key: CASSANDRA-12340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12340 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Jim Witschey > Labels: dtest > Attachments: node1.log, node2.log, node3.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest_jdk8/249/testReport/upgrade_supercolumns_test/TestSCUpgrade/upgrade_with_counters_test > {code} > Standard Output > Unexpected error in node3 log, error: > ERROR [CompactionExecutor:1] 2016-07-28 15:34:19,533 CassandraDaemon.java > (line 191) Exception in thread Thread[CompactionExecutor:1,1,main] > java.util.concurrent.RejectedExecutionException: Task > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@5fb8b2bf > rejected from > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor@1ae851ad[Terminated, > pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 8] > at > java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) > at > java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) > at > java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326) > at > java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533) > at > java.util.concurrent.ScheduledThreadPoolExecutor.submit(ScheduledThreadPoolExecutor.java:632) > at > org.apache.cassandra.io.sstable.SSTableDeletingTask.schedule(SSTableDeletingTask.java:65) > at > org.apache.cassandra.io.sstable.SSTableReader.releaseReference(SSTableReader.java:976) > at > org.apache.cassandra.db.DataTracker.removeOldSSTablesSize(DataTracker.java:383) > at org.apache.cassandra.db.DataTracker.postReplace(DataTracker.java:348) > at org.apache.cassandra.db.DataTracker.replace(DataTracker.java:342) > at > org.apache.cassandra.db.DataTracker.replaceCompactedSSTables(DataTracker.java:245) > at > org.apache.cassandra.db.ColumnFamilyStore.replaceCompactedSSTables(ColumnFamilyStore.java:995) > at > org.apache.cassandra.db.compaction.CompactionTask.replaceCompactedSSTables(CompactionTask.java:270) > at > org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:230) > at > org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48) > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:58) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60) > at > org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:208) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12340) dtest failure in upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402444#comment-15402444 ] Joel Knighton commented on CASSANDRA-12340: --- The correct answer to that is probably committers/broadly the PMC, but I'm happy to set up and say in this case that the answer would almost certainly be no. This shouldn't cause correctness issues or stop the cluster from functioning correctly, so I don't think it meets the bar for a critical fix at the risk of introducing regressions. The C* problem should definitely be fixed in 2.2+ (and I will do the fix in [CASSANDRA-12313] or [CASSANDRA-12260]). > dtest failure in > upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test > --- > > Key: CASSANDRA-12340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12340 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Jim Witschey > Labels: dtest > Attachments: node1.log, node2.log, node3.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest_jdk8/249/testReport/upgrade_supercolumns_test/TestSCUpgrade/upgrade_with_counters_test > {code} > Standard Output > Unexpected error in node3 log, error: > ERROR [CompactionExecutor:1] 2016-07-28 15:34:19,533 CassandraDaemon.java > (line 191) Exception in thread Thread[CompactionExecutor:1,1,main] > java.util.concurrent.RejectedExecutionException: Task > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@5fb8b2bf > rejected from > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor@1ae851ad[Terminated, > pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 8] > at > java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) > at > java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) > at > java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326) > at > java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533) > at > java.util.concurrent.ScheduledThreadPoolExecutor.submit(ScheduledThreadPoolExecutor.java:632) > at > org.apache.cassandra.io.sstable.SSTableDeletingTask.schedule(SSTableDeletingTask.java:65) > at > org.apache.cassandra.io.sstable.SSTableReader.releaseReference(SSTableReader.java:976) > at > org.apache.cassandra.db.DataTracker.removeOldSSTablesSize(DataTracker.java:383) > at org.apache.cassandra.db.DataTracker.postReplace(DataTracker.java:348) > at org.apache.cassandra.db.DataTracker.replace(DataTracker.java:342) > at > org.apache.cassandra.db.DataTracker.replaceCompactedSSTables(DataTracker.java:245) > at > org.apache.cassandra.db.ColumnFamilyStore.replaceCompactedSSTables(ColumnFamilyStore.java:995) > at > org.apache.cassandra.db.compaction.CompactionTask.replaceCompactedSSTables(CompactionTask.java:270) > at > org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:230) > at > org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48) > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:58) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60) > at > org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:208) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12340) dtest failure in upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402433#comment-15402433 ] Jim Witschey commented on CASSANDRA-12340: -- I can make a PR for dtest. Who makes decisions about whether this is sufficiently critical for a C* 2.1 fix? > dtest failure in > upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test > --- > > Key: CASSANDRA-12340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12340 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Jim Witschey > Labels: dtest > Attachments: node1.log, node2.log, node3.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest_jdk8/249/testReport/upgrade_supercolumns_test/TestSCUpgrade/upgrade_with_counters_test > {code} > Standard Output > Unexpected error in node3 log, error: > ERROR [CompactionExecutor:1] 2016-07-28 15:34:19,533 CassandraDaemon.java > (line 191) Exception in thread Thread[CompactionExecutor:1,1,main] > java.util.concurrent.RejectedExecutionException: Task > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@5fb8b2bf > rejected from > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor@1ae851ad[Terminated, > pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 8] > at > java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) > at > java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) > at > java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326) > at > java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533) > at > java.util.concurrent.ScheduledThreadPoolExecutor.submit(ScheduledThreadPoolExecutor.java:632) > at > org.apache.cassandra.io.sstable.SSTableDeletingTask.schedule(SSTableDeletingTask.java:65) > at > org.apache.cassandra.io.sstable.SSTableReader.releaseReference(SSTableReader.java:976) > at > org.apache.cassandra.db.DataTracker.removeOldSSTablesSize(DataTracker.java:383) > at org.apache.cassandra.db.DataTracker.postReplace(DataTracker.java:348) > at org.apache.cassandra.db.DataTracker.replace(DataTracker.java:342) > at > org.apache.cassandra.db.DataTracker.replaceCompactedSSTables(DataTracker.java:245) > at > org.apache.cassandra.db.ColumnFamilyStore.replaceCompactedSSTables(ColumnFamilyStore.java:995) > at > org.apache.cassandra.db.compaction.CompactionTask.replaceCompactedSSTables(CompactionTask.java:270) > at > org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:230) > at > org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48) > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:58) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60) > at > org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:208) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12353) CustomIndexTest can still fail due to async cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-12353: Status: Patch Available (was: Open) I've pushed a 3.0 branch, but won't waste electricity running 3.x CI. ||branch||testall|| |[12353-3.0|https://github.com/beobal/cassandra/tree/12353-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12353-3.0-testall]| > CustomIndexTest can still fail due to async cleanup > --- > > Key: CASSANDRA-12353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12353 > Project: Cassandra > Issue Type: Test >Reporter: Sam Tunnicliffe >Assignee: Sam Tunnicliffe >Priority: Minor > > CASSANDRA-11453 didn't quite go far enough in ensuring that indexes in > {{CustomIndexTest}} are uniquely named. A couple of duplicates were missed > which has lead to at least one failure (on trunk): > > http://cassci.datastax.com/job/trunk_utest/1613/testReport/org.apache.cassandra.index/CustomIndexTest/customIndexRejectsExpressionSyntax/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12353) CustomIndexTest can still fail due to async cleanup
Sam Tunnicliffe created CASSANDRA-12353: --- Summary: CustomIndexTest can still fail due to async cleanup Key: CASSANDRA-12353 URL: https://issues.apache.org/jira/browse/CASSANDRA-12353 Project: Cassandra Issue Type: Test Reporter: Sam Tunnicliffe Assignee: Sam Tunnicliffe Priority: Minor CASSANDRA-11453 didn't quite go far enough in ensuring that indexes in {{CustomIndexTest}} are uniquely named. A couple of duplicates were missed which has lead to at least one failure (on trunk): http://cassci.datastax.com/job/trunk_utest/1613/testReport/org.apache.cassandra.index/CustomIndexTest/customIndexRejectsExpressionSyntax/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12008) Make decommission operations resumable
[ https://issues.apache.org/jira/browse/CASSANDRA-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402388#comment-15402388 ] Paulo Motta commented on CASSANDRA-12008: - Thanks for the update. This is looking better and we're nearly done, see follow up below: * Code ** Fix indentation of {{logger.debug("DECOMMISSIONING")}} ** The {{isDecommissioning.get()}} should use a {{compareAndSet}} to avoid starting simultaneous decommision sessions. See the {{isRebuilding}} check. Also, add a test to verify it's not possible to start multiple decommission simultaneously based on the solution on CASSANDRA-11687 to avoid test flakiness. ** on {{SessionCompleteEvent}} use {{Collections.unmodifiableMap}} when copying the {{transferredRangesPerKeyspace}} map to avoid modifications to the ma ** In order to avoid allocating a {{HashSet}} when it's not necessary, change this {noformat} SettoBeUpdated = new HashSet<>(); if (transferredRangesPerKeyspace.containsKey(keyspace)) { toBeUpdated = transferredRangesPerKeyspace.get(keyspace); } {noformat} with this: {noformat} Set toBeUpdated = transferredRangesPerKeyspace.get(keyspace) if (toBeUpdated == null) { toBeUpdated = new HashSet<>(); } {noformat} ** {{Error while decommissioning node}} is never printed because the {{ExecutionException}} is being wrapped in a {{RuntimeException}} on {{unbootstrap}}, so perhaps you can modify {{unbootstrap}} to throw {{ExecutionException | InterruptedException}} and catch that on {{decomission}} to wrap in {{RuntimeException}}. * dtests ** Simply running {{stress read}} will not fail if the keys are not there, you need to either compare the retrieved keys or check that there was no failure on the stress process (see {{bootstrap_test}} for examples). ** When verifying if the retrieved data is correct on {{resumable_decommission_test}}, you need to stop either node1 or node3 when querying the other otherwise the data may be in only one of these nodes (while it must be in both nodes, since RF=2 and N=2). ** Perhaps reduce the number of keys to 10k so the test will be faster. ** On {{resumable_decommission_test}} set {{stream_throughput_outbound_megabits_per_sec}} to {{1}} to the streaming will be slower and allow more time for interrupting. ** Perhaps it's better for {{InterruptDecommission}} to watch on {{rebuild from dc}} since this is print before {{"Executing streaming plan for Unbootstrap"}} ** Instead of counting for {{decommission_error}} you can add a {{self.fail("second rebuild should fail")}} after {{node2.nodetool('decommission')}} and on the {{except}} part perhaps check that the following message is being print on logs {{Error while decommissioning node}} - see new version of {{simple_rebuild_test}} from CASSANDRA-11687. ** bq. I found that streamed range skipping behaviour log check-up is not working *** This is probably because the {{Range (-2556370087840976503,-2548250017122308073] already in /127.0.0.3, skipping}} message is only being print on {{debug.log}} so you should pass a {{filename='debug.log'}} to {{watch_log_for}}. When you modify {{StreamStateStore}} to {{updateStreamedRanges}} for requested ranges (ie. bootstrap), there could be a collision between received and transferred ranges for the same peer. While this collision will not show up in decommission, bootstrap and rebuild, since we only transfer in one direction, this may be confusing and source of problems in the future, so in order to avoid creating another table to support that in the future, I think we can modify {{streamed_ranges}} to include an {{outgoing}} boolean primary key field indicating if it's an incoming or outgoing transfer. WDYT [~yukim] [~kdmu]? > Make decommission operations resumable > -- > > Key: CASSANDRA-12008 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12008 > Project: Cassandra > Issue Type: Improvement > Components: Streaming and Messaging >Reporter: Tom van der Woerdt >Assignee: Kaide Mu >Priority: Minor > > We're dealing with large data sets (multiple terabytes per node) and > sometimes we need to add or remove nodes. These operations are very dependent > on the entire cluster being up, so while we're joining a new node (which > sometimes takes 6 hours or longer) a lot can go wrong and in a lot of cases > something does. > It would be great if the ability to retry streams was implemented. > Example to illustrate the problem : > {code} > 03:18 PM ~ $ nodetool decommission > error: Stream failed > -- StackTrace -- > org.apache.cassandra.streaming.StreamException: Stream failed > at >
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[ https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402358#comment-15402358 ] T Jake Luciani commented on CASSANDRA-12312: Looks great, would you mind adding the new metrics to the [docs|https://github.com/apache/cassandra/blob/trunk/doc/source/operating/metrics.rst]? > Restore JVM metric export for metric reporters > -- > > Key: CASSANDRA-12312 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12312 > Project: Cassandra > Issue Type: Bug >Reporter: Stefan Podkowinski >Assignee: Stefan Podkowinski > Labels: lhf > Fix For: 2.2.x, 3.0.x, 3.x > > Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch, > metrics-jvm-3.1.0.jar.asc > > > JVM instrumentation as part of dropwizard metrics has been moved to a > separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no > jvm related metrics will be exported to any reporter configured via > {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore. > As memory and GC stats are essential for monitoring Cassandra, this turns out > to be a blocker for us for upgrading to 2.2. > I've included a patch that would add the now separate {{metrics-jvm}} package > and enables some of the provided metrics on startup in case a metrics > reporter is used ({{-Dcassandra.metricsReporterConfigFile}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12133) Failed to load Java8 implementation ohc-core-j8
[ https://issues.apache.org/jira/browse/CASSANDRA-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402351#comment-15402351 ] T Jake Luciani commented on CASSANDRA-12133: +1 > Failed to load Java8 implementation ohc-core-j8 > --- > > Key: CASSANDRA-12133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12133 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Ubuntu 14.04, Java 1.8.0_91 >Reporter: Mike >Assignee: Robert Stupp >Priority: Trivial > Fix For: 3.0.x > > > After enabling row cache in cassandra.yaml by setting row_cache_size_in_mb, I > receive this warning in system.log during startup: > {noformat} > WARN [main] 2016-07-05 13:36:14,671 Uns.java:169 - Failed to load Java8 > implementation ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12133) Failed to load Java8 implementation ohc-core-j8
[ https://issues.apache.org/jira/browse/CASSANDRA-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-12133: --- Status: Ready to Commit (was: Patch Available) > Failed to load Java8 implementation ohc-core-j8 > --- > > Key: CASSANDRA-12133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12133 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Ubuntu 14.04, Java 1.8.0_91 >Reporter: Mike >Assignee: Robert Stupp >Priority: Trivial > Fix For: 3.0.x > > > After enabling row cache in cassandra.yaml by setting row_cache_size_in_mb, I > receive this warning in system.log during startup: > {noformat} > WARN [main] 2016-07-05 13:36:14,671 Uns.java:169 - Failed to load Java8 > implementation ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12258) Casandra stress version option
[ https://issues.apache.org/jira/browse/CASSANDRA-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-12258: --- Resolution: Fixed Fix Version/s: (was: 3.x) 3.10 Status: Resolved (was: Patch Available) +1 committed {{eaf4b91ae33cf623eed2fc0a934ce658a7ec49bb}} > Casandra stress version option > -- > > Key: CASSANDRA-12258 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12258 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Christopher Batey >Assignee: Christopher Batey >Priority: Minor > Fix For: 3.10 > > > I install cassandra stress to multiple machines in different environments and > would like an easy way (with out looking at jar files etc) to see the version > of stress running. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
cassandra git commit: Add version command to cassandra stress
Repository: cassandra Updated Branches: refs/heads/trunk 7eb9531a4 -> eaf4b91ae Add version command to cassandra stress Patch by Chris Batey; reviewed by tjake for CASSANDRA-12258 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/eaf4b91a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/eaf4b91a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/eaf4b91a Branch: refs/heads/trunk Commit: eaf4b91ae33cf623eed2fc0a934ce658a7ec49bb Parents: 7eb9531 Author: Chris BateyAuthored: Thu Jul 21 11:35:24 2016 +0100 Committer: T Jake Luciani Committed: Mon Aug 1 12:25:23 2016 -0400 -- CHANGES.txt | 1 + .../cassandra/stress/settings/Command.java | 3 +- .../cassandra/stress/settings/SettingsMisc.java | 65 .../stress/settings/SettingsMiscTest.java | 55 + 4 files changed, 110 insertions(+), 14 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/eaf4b91a/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index f759b7e..f9ff43d 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.10 + * Add version command to cassandra-stress (CASSANDRA-12258) * Create compaction-stress tool (CASSANDRA-11844) * Garbage-collecting compaction operation and schema option (CASSANDRA-7019) * Add schema to snapshot manifest, add USING TIMESTAMP clause to ALTER TABLE statements (CASSANDRA-7190) http://git-wip-us.apache.org/repos/asf/cassandra/blob/eaf4b91a/tools/stress/src/org/apache/cassandra/stress/settings/Command.java -- diff --git a/tools/stress/src/org/apache/cassandra/stress/settings/Command.java b/tools/stress/src/org/apache/cassandra/stress/settings/Command.java index c47c5d2..d8ac5d1 100644 --- a/tools/stress/src/org/apache/cassandra/stress/settings/Command.java +++ b/tools/stress/src/org/apache/cassandra/stress/settings/Command.java @@ -61,7 +61,8 @@ public enum Command HELP(false, null, "-?", "Print help for a command or option", null), PRINT(false, null, "Inspect the output of a distribution definition", null), -LEGACY(false, null, "Legacy support mode", null) +LEGACY(false, null, "Legacy support mode", null), +VERSION(false, null, "Print the version of cassandra stress", null) ; private static final Map LOOKUP; http://git-wip-us.apache.org/repos/asf/cassandra/blob/eaf4b91a/tools/stress/src/org/apache/cassandra/stress/settings/SettingsMisc.java -- diff --git a/tools/stress/src/org/apache/cassandra/stress/settings/SettingsMisc.java b/tools/stress/src/org/apache/cassandra/stress/settings/SettingsMisc.java index 5735f9d..7f2335f 100644 --- a/tools/stress/src/org/apache/cassandra/stress/settings/SettingsMisc.java +++ b/tools/stress/src/org/apache/cassandra/stress/settings/SettingsMisc.java @@ -21,15 +21,22 @@ package org.apache.cassandra.stress.settings; */ +import java.io.IOException; import java.io.PrintStream; import java.io.Serializable; +import java.net.URL; import java.util.Arrays; import java.util.List; import java.util.Map; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import com.google.common.base.Charsets; +import com.google.common.io.Resources; import org.apache.cassandra.stress.generate.Distribution; -public class SettingsMisc implements Serializable +class SettingsMisc implements Serializable { static boolean maybeDoSpecial(Map clArgs) @@ -38,10 +45,12 @@ public class SettingsMisc implements Serializable return true; if (maybePrintDistribution(clArgs)) return true; +if (maybePrintVersion(clArgs)) +return true; return false; } -static final class PrintDistribution extends GroupedOptions +private static final class PrintDistribution extends GroupedOptions { final OptionDistribution dist = new OptionDistribution("dist=", null, "A mathematical distribution"); @@ -52,7 +61,8 @@ public class SettingsMisc implements Serializable } } -static boolean maybePrintDistribution(Map clArgs) + +private static boolean maybePrintDistribution(Map clArgs) { final String[] args = clArgs.get("print"); if (args == null) @@ -68,17 +78,17 @@ public class SettingsMisc implements Serializable return true; } -static void printDistribution(Distribution dist) +private static void printDistribution(Distribution dist) {
[jira] [Assigned] (CASSANDRA-12340) dtest failure in upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Witschey reassigned CASSANDRA-12340: Assignee: Jim Witschey (was: DS Test Eng) > dtest failure in > upgrade_supercolumns_test.TestSCUpgrade.upgrade_with_counters_test > --- > > Key: CASSANDRA-12340 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12340 > Project: Cassandra > Issue Type: Test >Reporter: Sean McCarthy >Assignee: Jim Witschey > Labels: dtest > Attachments: node1.log, node2.log, node3.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest_jdk8/249/testReport/upgrade_supercolumns_test/TestSCUpgrade/upgrade_with_counters_test > {code} > Standard Output > Unexpected error in node3 log, error: > ERROR [CompactionExecutor:1] 2016-07-28 15:34:19,533 CassandraDaemon.java > (line 191) Exception in thread Thread[CompactionExecutor:1,1,main] > java.util.concurrent.RejectedExecutionException: Task > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@5fb8b2bf > rejected from > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor@1ae851ad[Terminated, > pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 8] > at > java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) > at > java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) > at > java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326) > at > java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533) > at > java.util.concurrent.ScheduledThreadPoolExecutor.submit(ScheduledThreadPoolExecutor.java:632) > at > org.apache.cassandra.io.sstable.SSTableDeletingTask.schedule(SSTableDeletingTask.java:65) > at > org.apache.cassandra.io.sstable.SSTableReader.releaseReference(SSTableReader.java:976) > at > org.apache.cassandra.db.DataTracker.removeOldSSTablesSize(DataTracker.java:383) > at org.apache.cassandra.db.DataTracker.postReplace(DataTracker.java:348) > at org.apache.cassandra.db.DataTracker.replace(DataTracker.java:342) > at > org.apache.cassandra.db.DataTracker.replaceCompactedSSTables(DataTracker.java:245) > at > org.apache.cassandra.db.ColumnFamilyStore.replaceCompactedSSTables(ColumnFamilyStore.java:995) > at > org.apache.cassandra.db.compaction.CompactionTask.replaceCompactedSSTables(CompactionTask.java:270) > at > org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:230) > at > org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48) > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:58) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60) > at > org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:208) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12352) dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test
Craig Kodman created CASSANDRA-12352: Summary: dtest failure in upgrade_tests.storage_engine_upgrade_test.TestLoadLaCompactSStables.sstableloader_compression_snappy_to_snappy_test Key: CASSANDRA-12352 URL: https://issues.apache.org/jira/browse/CASSANDRA-12352 Project: Cassandra Issue Type: Test Reporter: Craig Kodman Assignee: DS Test Eng Attachments: node1.log, node1_debug.log, node2.log, node2_debug.log example failure: http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaCompactSStables/sstableloader_compression_snappy_to_snappy_test http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestLoadLaSStables/sstableloader_compression_deflate_to_deflate_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_paging_across_multi_wide_rows/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingSizeNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_undefined_page_size_default/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_cell_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/test_row_TTL_expiry_during_paging/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.storage_engine_upgrade_test/TestBootstrapAfterUpgrade/upgrade_with_unclustered_CQL_table_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/bug_5732_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/collection_flush_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/large_count_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/conditional_delete_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_3_0_x/range_tombstones_compaction_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_2_2_x_To_indev_3_0_x/test_failure_threshold_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingWithDeletionsNodes2RF1_Upgrade_current_3_0_x_To_indev_3_0_x/test_ttl_deletions/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_0_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_0_x/limit_multiget_test/ http://cassci.datastax.com/job/cassandra-3.0_dtest_upgrade/10/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_2_2_x_To_indev_3_0_x/test_data_change_impacting_later_page/
[jira] [Updated] (CASSANDRA-11914) Provide option for cassandra-stress to dump all settings
[ https://issues.apache.org/jira/browse/CASSANDRA-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-11914: --- Fix Version/s: 3.x > Provide option for cassandra-stress to dump all settings > > > Key: CASSANDRA-11914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11914 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Ben Slater >Assignee: Ben Slater >Priority: Minor > Fix For: 3.x > > > cassandra-stress has quite a lot of default settings and settings that are > derived as side effects of explicit options. For people learning the tool and > saving a clear record of what was run, I think it would be useful if there > was an option to have the tool print all its settings at the start of a run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11914) Provide option for cassandra-stress to dump all settings
[ https://issues.apache.org/jira/browse/CASSANDRA-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-11914: --- Assignee: Ben Slater > Provide option for cassandra-stress to dump all settings > > > Key: CASSANDRA-11914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11914 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Ben Slater >Assignee: Ben Slater >Priority: Minor > Fix For: 3.x > > > cassandra-stress has quite a lot of default settings and settings that are > derived as side effects of explicit options. For people learning the tool and > saving a clear record of what was run, I think it would be useful if there > was an option to have the tool print all its settings at the start of a run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11914) Provide option for cassandra-stress to dump all settings
[ https://issues.apache.org/jira/browse/CASSANDRA-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-11914: --- Status: Open (was: Patch Available) > Provide option for cassandra-stress to dump all settings > > > Key: CASSANDRA-11914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11914 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Ben Slater >Assignee: Ben Slater >Priority: Minor > Fix For: 3.x > > > cassandra-stress has quite a lot of default settings and settings that are > derived as side effects of explicit options. For people learning the tool and > saving a clear record of what was run, I think it would be useful if there > was an option to have the tool print all its settings at the start of a run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11914) Provide option for cassandra-stress to dump all settings
[ https://issues.apache.org/jira/browse/CASSANDRA-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-11914: --- Status: Awaiting Feedback (was: Open) > Provide option for cassandra-stress to dump all settings > > > Key: CASSANDRA-11914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11914 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Ben Slater >Assignee: Ben Slater >Priority: Minor > Fix For: 3.x > > > cassandra-stress has quite a lot of default settings and settings that are > derived as side effects of explicit options. For people learning the tool and > saving a clear record of what was run, I think it would be useful if there > was an option to have the tool print all its settings at the start of a run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11914) Provide option for cassandra-stress to dump all settings
[ https://issues.apache.org/jira/browse/CASSANDRA-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402242#comment-15402242 ] T Jake Luciani commented on CASSANDRA-11914: Stress seems to no longer create the schema when you specify a user profile. Can you take a look? Also Nit: some of the open brackets in your patch aren't on a newline > Provide option for cassandra-stress to dump all settings > > > Key: CASSANDRA-11914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11914 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Ben Slater >Priority: Minor > > cassandra-stress has quite a lot of default settings and settings that are > derived as side effects of explicit options. For people learning the tool and > saving a clear record of what was run, I think it would be useful if there > was an option to have the tool print all its settings at the start of a run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
cassandra git commit: Add theme for inclusion of the documentation on the website
Repository: cassandra Updated Branches: refs/heads/trunk 47d3b7e7a -> 7eb9531a4 Add theme for inclusion of the documentation on the website Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7eb9531a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7eb9531a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7eb9531a Branch: refs/heads/trunk Commit: 7eb9531a4dc6286d9697dc8ebd75e09feec1795d Parents: 47d3b7e Author: Sylvain LebresneAuthored: Wed Jul 13 15:50:36 2016 +0200 Committer: Sylvain Lebresne Committed: Mon Aug 1 17:19:50 2016 +0200 -- build.xml | 4 + doc/Makefile| 12 +++ doc/source/_templates/indexcontent.html | 74 ++- doc/source/_theme/cassandra_theme/defindex.html | 25 ++ doc/source/_theme/cassandra_theme/layout.html | 95 doc/source/_theme/cassandra_theme/search.html | 53 +++ doc/source/_theme/cassandra_theme/theme.conf| 3 + doc/source/conf.py | 14 +-- doc/source/getting_started/installing.rst | 2 + doc/source/operating/metrics.rst| 64 ++--- 10 files changed, 285 insertions(+), 61 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/7eb9531a/build.xml -- diff --git a/build.xml b/build.xml index b8b470c..20998f2 100644 --- a/build.xml +++ b/build.xml @@ -724,6 +724,10 @@ + + + + +{{ toc }} +{% endif %} +{% endblock %} + + + + + + + + {% block body %}{% endblock %} + + {% if next or prev %} + +{% if next %} +Next +{% endif %} +{% if prev %} + Previous +{% endif %} + + {% endif %} + + + + + + + http://git-wip-us.apache.org/repos/asf/cassandra/blob/7eb9531a/doc/source/_theme/cassandra_theme/search.html -- diff --git a/doc/source/_theme/cassandra_theme/search.html b/doc/source/_theme/cassandra_theme/search.html new file mode 100644 index 000..d5e26a9 --- /dev/null +++ b/doc/source/_theme/cassandra_theme/search.html @@ -0,0 +1,53 @@ +{%- extends "layout.html" %} +{% block title %} +title: "{{_('Search')}}" +{% endblock %} +{% block extrafooter %} +extra-footer: ' + +var DOCUMENTATION_OPTIONS = { + URL_ROOT:"{{ url_root }}", + VERSION: "{{ release|e }}", + COLLAPSE_INDEX: false, + FILE_SUFFIX: "{{ "" if no_search_suffix else file_suffix }}", + HAS_SOURCE: false, + SOURCELINK_SUFFIX: "{{ sourcelink_suffix }}" +}; + + +jQuery(function() { Search.loadIndex("{{ pathto('searchindex.js', 1) }}"); }); + + {# this is used when loading the search index using $.ajax fails, + such as on Chrome for documents on localhost #} + +' +{% endblock %} +{% block body %} + + + + {% trans %}Please activate JavaScript to enable the search + functionality.{% endtrans %} + + + + + {% if search_performed %} +{{ _('Search Results') }} +{% if not search_results %} + {{ _('Your search did not match any documents. Please make sure that all words are spelled correctly.') }} +{% endif %} + {% endif %} + + {% if search_results %} + +{% for href, caption, context in search_results %} + +{{ caption }} +{{ context|e }} + +{% endfor %} + + {% endif %} + +{% endblock %} http://git-wip-us.apache.org/repos/asf/cassandra/blob/7eb9531a/doc/source/_theme/cassandra_theme/theme.conf -- diff --git a/doc/source/_theme/cassandra_theme/theme.conf b/doc/source/_theme/cassandra_theme/theme.conf new file mode 100644 index 000..42c0704 --- /dev/null +++ b/doc/source/_theme/cassandra_theme/theme.conf @@ -0,0 +1,3 @@ +[theme] +inherit = basic +stylesheet = none http://git-wip-us.apache.org/repos/asf/cassandra/blob/7eb9531a/doc/source/conf.py -- diff --git a/doc/source/conf.py b/doc/source/conf.py index 63697aa..7143b23 100644 --- a/doc/source/conf.py +++ b/doc/source/conf.py @@ -37,6 +37,8 @@ def setup(sphinx): from cql import CQLLexer sphinx.add_lexer("cql", CQLLexer()) +# Ugly way to find out if we're building for the website (the Makefile creates an empty file for us) +build_for_website = os.path.isfile('.build_for_website') # --
[jira] [Commented] (CASSANDRA-11687) dtest failure in rebuild_test.TestRebuild.simple_rebuild_test
[ https://issues.apache.org/jira/browse/CASSANDRA-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402235#comment-15402235 ] Yuki Morishita commented on CASSANDRA-11687: bq. the second rebuild is completing before the first, so the first rebuild fails while the second succeeds Right, but increasing keys will also increase amount of time for test to complete by large. I will experiment with some numbers. > dtest failure in rebuild_test.TestRebuild.simple_rebuild_test > - > > Key: CASSANDRA-11687 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11687 > Project: Cassandra > Issue Type: Bug >Reporter: Russ Hatch >Assignee: Yuki Morishita > Labels: dtest > > single failure on most recent run (3.0 no-vnode) > {noformat} > concurrent rebuild should not be allowed, but one rebuild command should have > succeeded. > {noformat} > http://cassci.datastax.com/job/cassandra-3.0_novnode_dtest/217/testReport/rebuild_test/TestRebuild/simple_rebuild_test > Failed on CassCI build cassandra-3.0_novnode_dtest #217 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-8700) replace the wiki with docs in the git repo
[ https://issues.apache.org/jira/browse/CASSANDRA-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne resolved CASSANDRA-8700. - Resolution: Fixed As the (first version of the) documentation is not both committed and online (http://cassandra.apache.org/doc/latest/), I'm closing this issue. We can deal with further updates to said doc as any other normal contribution. > replace the wiki with docs in the git repo > -- > > Key: CASSANDRA-8700 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8700 > Project: Cassandra > Issue Type: Improvement > Components: Documentation and Website >Reporter: Jon Haddad >Assignee: Sylvain Lebresne >Priority: Blocker > Fix For: 3.8 > > Attachments: TombstonesAndGcGrace.md, bloom_filters.md, > compression.md, contributing.zip, getting_started.zip, hardware.md > > > The wiki as it stands is pretty terrible. It takes several minutes to apply > a single update, and as a result, it's almost never updated. The information > there has very little context as to what version it applies to. Most people > I've talked to that try to use the information they find there find it is > more confusing than helpful. > I'd like to propose that instead of using the wiki, the doc directory in the > cassandra repo be used for docs (already used for CQL3 spec) in a format that > can be built to a variety of output formats like HTML / epub / etc. I won't > start the bikeshedding on which markup format is preferable - but there are > several options that can work perfectly fine. I've personally use sphinx w/ > restructured text, and markdown. Both can build easily and as an added bonus > be pushed to readthedocs (or something similar) automatically. For an > example, see cqlengine's documentation, which I think is already > significantly better than the wiki: > http://cqlengine.readthedocs.org/en/latest/ > In addition to being overall easier to maintain, putting the documentation in > the git repo adds context, since it evolves with the versions of Cassandra. > If the wiki were kept even remotely up to date, I wouldn't bother with this, > but not having at least some basic documentation in the repo, or anywhere > associated with the project, is frustrating. > For reference, the last 3 updates were: > 1/15/15 - updating committers list > 1/08/15 - updating contributers and how to contribute > 12/16/14 - added a link to CQL docs from wiki frontpage (by me) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11844) Create compaction-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-11844: --- Resolution: Fixed Fix Version/s: (was: 3.x) 3.10 Status: Resolved (was: Ready to Commit) Committed {{47d3b7e7a013b485a2906fc7f0f2fc90e1143966}} > Create compaction-stress > > > Key: CASSANDRA-11844 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11844 > Project: Cassandra > Issue Type: Sub-task > Components: Compaction, Tools >Reporter: T Jake Luciani >Assignee: T Jake Luciani > Fix For: 3.10 > > > A tool like cassandra-stress that works with stress yaml but: > * writes directly to a specified dir using CQLSSTableWriter. > * lets you run just compaction on that directory and generates a report on > compaction throughput. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/2] cassandra git commit: compaction stress tool
Repository: cassandra Updated Branches: refs/heads/trunk d40ac784d -> 47d3b7e7a http://git-wip-us.apache.org/repos/asf/cassandra/blob/47d3b7e7/tools/stress/src/org/apache/cassandra/stress/StressProfile.java -- diff --git a/tools/stress/src/org/apache/cassandra/stress/StressProfile.java b/tools/stress/src/org/apache/cassandra/stress/StressProfile.java index 8b59bda..1964c27 100644 --- a/tools/stress/src/org/apache/cassandra/stress/StressProfile.java +++ b/tools/stress/src/org/apache/cassandra/stress/StressProfile.java @@ -29,15 +29,19 @@ import java.net.URI; import java.util.*; import java.util.concurrent.TimeUnit; import java.util.regex.Pattern; +import java.util.stream.Collectors; import com.google.common.base.Function; +import com.google.common.collect.Iterables; import com.google.common.util.concurrent.Uninterruptibles; import com.datastax.driver.core.*; import com.datastax.driver.core.exceptions.AlreadyExistsException; import org.apache.cassandra.config.CFMetaData; +import org.apache.cassandra.config.ColumnDefinition; import org.apache.cassandra.cql3.QueryProcessor; import org.apache.cassandra.cql3.statements.CreateKeyspaceStatement; +import org.apache.cassandra.cql3.statements.CreateTableStatement; import org.apache.cassandra.exceptions.RequestValidationException; import org.apache.cassandra.exceptions.SyntaxException; import org.apache.cassandra.stress.generate.*; @@ -57,12 +61,14 @@ import org.yaml.snakeyaml.Yaml; import org.yaml.snakeyaml.constructor.Constructor; import org.yaml.snakeyaml.error.YAMLException; +import static org.apache.cassandra.io.sstable.CQLSSTableWriter.parseStatement; + public class StressProfile implements Serializable { private String keyspaceCql; private String tableCql; private List extraSchemaDefinitions; -private String seedStr; +public final String seedStr = "seed for stress"; public String keyspaceName; public String tableName; @@ -96,7 +102,6 @@ public class StressProfile implements Serializable keyspaceCql = yaml.keyspace_definition; tableName = yaml.table; tableCql = yaml.table_definition; -seedStr = "seed for stress"; queries = yaml.queries; tokenRangeQueries = yaml.token_range_queries; insert = yaml.insert; @@ -360,6 +365,87 @@ public class StressProfile implements Serializable return new TokenRangeQuery(timer, settings, tableMetaData, tokenRangeIterator, def, isWarmup); } + +public PartitionGenerator getOfflineGenerator() +{ +CFMetaData cfMetaData = CFMetaData.compile(tableCql, keyspaceName); + +//Add missing column configs +Iterator it = cfMetaData.allColumnsInSelectOrder(); +while (it.hasNext()) +{ +ColumnDefinition c = it.next(); +if (!columnConfigs.containsKey(c.name.toString())) +columnConfigs.put(c.name.toString(), new GeneratorConfig(seedStr + c.name.toString(), null, null, null)); +} + +List partitionColumns = cfMetaData.partitionKeyColumns().stream() + .map(c -> new ColumnInfo(c.name.toString(), c.type.asCQL3Type().toString(), "", columnConfigs.get(c.name.toString( + .map(c -> c.getGenerator()) + .collect(Collectors.toList()); + +List clusteringColumns = cfMetaData.clusteringColumns().stream() + .map(c -> new ColumnInfo(c.name.toString(), c.type.asCQL3Type().toString(), "", columnConfigs.get(c.name.toString( + .map(c -> c.getGenerator()) + .collect(Collectors.toList()); + +List regularColumns = com.google.common.collect.Lists.newArrayList(cfMetaData.partitionColumns().selectOrderIterator()).stream() + .map(c -> new ColumnInfo(c.name.toString(), c.type.asCQL3Type().toString(), "", columnConfigs.get(c.name.toString( + .map(c -> c.getGenerator()) + .collect(Collectors.toList()); + +return new PartitionGenerator(partitionColumns, clusteringColumns, regularColumns, PartitionGenerator.Order.ARBITRARY); +} + +public CreateTableStatement.RawStatement getCreateStatement() +{ +CreateTableStatement.RawStatement createStatement = parseStatement(tableCql, CreateTableStatement.RawStatement.class, "CREATE TABLE"); +
[2/2] cassandra git commit: compaction stress tool
compaction stress tool patch by tjake; reviewed by Marcus Eriksson for CASSANDRA-11844 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/47d3b7e7 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/47d3b7e7 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/47d3b7e7 Branch: refs/heads/trunk Commit: 47d3b7e7a013b485a2906fc7f0f2fc90e1143966 Parents: d40ac78 Author: T Jake LucianiAuthored: Fri May 20 11:23:49 2016 -0400 Committer: T Jake Luciani Committed: Mon Aug 1 11:06:52 2016 -0400 -- CHANGES.txt | 1 + NEWS.txt| 2 + .../apache/cassandra/db/ColumnFamilyStore.java | 53 +-- .../org/apache/cassandra/db/Directories.java| 19 + src/java/org/apache/cassandra/db/Keyspace.java | 24 ++ .../compaction/AbstractCompactionStrategy.java | 2 +- .../db/lifecycle/LifecycleTransaction.java | 10 +- .../cassandra/dht/ByteOrderedPartitioner.java | 9 +- .../org/apache/cassandra/dht/IPartitioner.java | 8 + .../apache/cassandra/dht/LocalPartitioner.java | 6 + .../dht/OrderPreservingPartitioner.java | 15 +- .../apache/cassandra/dht/RandomPartitioner.java | 8 + .../hadoop/cql3/CqlBulkRecordWriter.java| 4 +- .../io/sstable/AbstractSSTableSimpleWriter.java | 40 +- .../cassandra/io/sstable/CQLSSTableWriter.java | 147 ++-- .../cassandra/io/sstable/SSTableLoader.java | 16 +- .../io/sstable/SSTableSimpleUnsortedWriter.java | 12 +- .../io/sstable/SSTableSimpleWriter.java | 8 +- .../cassandra/io/sstable/SSTableTxnWriter.java | 22 ++ .../tools/nodetool/CompactionStats.java | 8 +- .../apache/cassandra/utils/GuidGenerator.java | 9 +- .../cassandra/streaming/LongStreamingTest.java | 6 +- test/unit/org/apache/cassandra/MockSchema.java | 2 +- .../db/lifecycle/RealTransactionsTest.java | 4 +- .../apache/cassandra/dht/LengthPartitioner.java | 8 +- .../io/sstable/CQLSSTableWriterClientTest.java | 15 +- .../io/sstable/CQLSSTableWriterTest.java| 34 +- .../cassandra/io/sstable/SSTableLoaderTest.java | 38 +- tools/bin/compaction-stress | 57 +++ .../cassandra/stress/CompactionStress.java | 365 +++ .../apache/cassandra/stress/StressProfile.java | 162 ++-- .../stress/generate/PartitionGenerator.java | 13 +- .../operations/userdefined/SchemaInsert.java| 77 +++- .../operations/userdefined/SchemaQuery.java | 4 +- .../operations/userdefined/SchemaStatement.java | 16 +- 35 files changed, 1026 insertions(+), 198 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/47d3b7e7/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 760cc58..f759b7e 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.10 + * Create compaction-stress tool (CASSANDRA-11844) * Garbage-collecting compaction operation and schema option (CASSANDRA-7019) * Add schema to snapshot manifest, add USING TIMESTAMP clause to ALTER TABLE statements (CASSANDRA-7190) * Add beta protocol flag for v5 native protocol (CASSANDRA-12142) http://git-wip-us.apache.org/repos/asf/cassandra/blob/47d3b7e7/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 85f2767..069c93b 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -19,6 +19,8 @@ using the provided 'sstableupgrade' tool. New features + - A new compaction-stress tool has been added to test the throughput of compaction + for any cassandra-stress user schema. see compaction-stress help for how to use. - Compaction can now take into account overlapping tables that don't take part in the compaction to look for deleted or overwritten data in the compacted tables. Then such data is found, it can be safely discarded, which in turn should enable http://git-wip-us.apache.org/repos/asf/cassandra/blob/47d3b7e7/src/java/org/apache/cassandra/db/ColumnFamilyStore.java -- diff --git a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java index 20dac1e..53f5305 100644 --- a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java +++ b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java @@ -381,17 +381,6 @@ public class ColumnFamilyStore implements ColumnFamilyStoreMBean } } -private ColumnFamilyStore(Keyspace keyspace, - String columnFamilyName, - int generation, - CFMetaData
[jira] [Commented] (CASSANDRA-12251) dtest failure in upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_current_3_x_To_indev_3_x.whole_list_conditional_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402186#comment-15402186 ] Joel Knighton commented on CASSANDRA-12251: --- [~ifesdjeen] - I actually need to make a superset of these changes for [CASSANDRA-12260] and [CASSANDRA-12313]. It might make sense to just centralize review there and link this one as a duplicate of [CASSANDRA-12260]. > dtest failure in > upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_current_3_x_To_indev_3_x.whole_list_conditional_test > -- > > Key: CASSANDRA-12251 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12251 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Alex Petrov > Labels: dtest > Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, > node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log > > > example failure: > http://cassci.datastax.com/job/cassandra-3.8_dtest_upgrade/1/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_x_To_indev_3_x/whole_list_conditional_test > Failed on CassCI build cassandra-3.8_dtest_upgrade #1 > Relevant error in logs is > {code} > Unexpected error in node1 log, error: > ERROR [InternalResponseStage:2] 2016-07-20 04:58:45,876 > CassandraDaemon.java:217 - Exception in thread > Thread[InternalResponseStage:2,5,main] > java.util.concurrent.RejectedExecutionException: ThreadPoolExecutor has shut > down > at > org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor$1.rejectedExecution(DebuggableThreadPoolExecutor.java:61) > ~[apache-cassandra-3.7.jar:3.7] > at > java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) > ~[na:1.8.0_51] > at > java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369) > ~[na:1.8.0_51] > at > org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor.execute(DebuggableThreadPoolExecutor.java:165) > ~[apache-cassandra-3.7.jar:3.7] > at > java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112) > ~[na:1.8.0_51] > at > org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:842) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:822) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.db.ColumnFamilyStore.forceFlush(ColumnFamilyStore.java:891) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.schema.SchemaKeyspace.lambda$flush$1(SchemaKeyspace.java:279) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.schema.SchemaKeyspace$$Lambda$200/1129213153.accept(Unknown > Source) ~[na:na] > at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_51] > at > org.apache.cassandra.schema.SchemaKeyspace.flush(SchemaKeyspace.java:279) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchema(SchemaKeyspace.java:1271) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchemaAndAnnounceVersion(SchemaKeyspace.java:1253) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.service.MigrationTask$1.response(MigrationTask.java:92) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:53) > ~[apache-cassandra-3.7.jar:3.7] > at > org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:64) > ~[apache-cassandra-3.7.jar:3.7] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_51] > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > ~[na:1.8.0_51] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > ~[na:1.8.0_51] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > [na:1.8.0_51] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_51] > {code} > This is on a mixed 3.0.8, 3.8-tentative cluster -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402170#comment-15402170 ] Paulo Motta commented on CASSANDRA-12348: - and/or maybe add a {{LifecycleTransaction.waitForDeletions()}} after {{CompactionManager.instance.submitMaximal}} so if someone puts an assertion after {{validateCFS}} it will at least fail consistently.. > Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest > - > > Key: CASSANDRA-12348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12348 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.x > > > Example failures: > http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/ > http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > All failures look like the test is finding more files than expected after a > rewrite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-12348: Status: Ready to Commit (was: Patch Available) > Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest > - > > Key: CASSANDRA-12348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12348 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.x > > > Example failures: > http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/ > http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > All failures look like the test is finding more files than expected after a > rewrite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402162#comment-15402162 ] Paulo Motta commented on CASSANDRA-12348: - +1, but {{validateCFS}} having side-effects is pretty counter-intuitive, so before committing can you maybe add a comment on this method warning that it should be typically called after the last test assertion? > Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest > - > > Key: CASSANDRA-12348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12348 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.x > > > Example failures: > http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/ > http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > All failures look like the test is finding more files than expected after a > rewrite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
[ https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-12348: Reviewer: Paulo Motta > Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest > - > > Key: CASSANDRA-12348 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12348 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.x > > > Example failures: > http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/ > http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/ > All failures look like the test is finding more files than expected after a > rewrite. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9318) Bound the number of in-flight requests at the coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402137#comment-15402137 ] Sergio Bossa commented on CASSANDRA-9318: - Patch rebased to trunk, new links: | [trunk patch|https://github.com/apache/cassandra/compare/trunk...sbtourist:CASSANDRA-9318-trunk?expand=1] | [testall|https://cassci.datastax.com/view/Dev/view/sbtourist/job/sbtourist-CASSANDRA-9318-trunk-testall/] | [dtest|https://cassci.datastax.com/view/Dev/view/sbtourist/job/sbtourist-CASSANDRA-9318-trunk-dtest/] | [dtest (back-pressure enabled)|https://cassci.datastax.com/view/Dev/view/sbtourist/job/sbtourist-CASSANDRA-9318-bp-true-trunk-dtest/] | [~Stefania], feel free to have another quick look at the new patch (no relevant changes by the way). [~eduard.tudenhoefner], in terms of testing, I've already done some on my own as reported in one of my earlier comments, but I am sure you'll have more to add; the objective of our testing should be: 1) Verify there's no performance impact *at all* when back-pressure is disabled. 2) Verify there's no relevant performance impact when back-pressure is enabled and the cluster is well-behaving. 3) Verify back-pressure works correctly when the cluster is overloaded, and dropped mutations are reduced (how much reduced, it depends on the actual back-pressure configuration, and I hope the {{cassandra.yaml}} comments will help with that, otherwise let me know what's unclear and I'll improve them). All tests should be run with at least 4 nodes and RF=3, the attached ByteMan rule can be used to simulate "slow replica" scenarios and kick-in back-pressure. > Bound the number of in-flight requests at the coordinator > - > > Key: CASSANDRA-9318 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9318 > Project: Cassandra > Issue Type: Improvement > Components: Local Write-Read Paths, Streaming and Messaging >Reporter: Ariel Weisberg >Assignee: Sergio Bossa > Attachments: 9318-3.0-nits-trailing-spaces.patch, backpressure.png, > limit.btm, no_backpressure.png > > > It's possible to somewhat bound the amount of load accepted into the cluster > by bounding the number of in-flight requests and request bytes. > An implementation might do something like track the number of outstanding > bytes and requests and if it reaches a high watermark disable read on client > connections until it goes back below some low watermark. > Need to make sure that disabling read on the client connection won't > introduce other issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11687) dtest failure in rebuild_test.TestRebuild.simple_rebuild_test
[ https://issues.apache.org/jira/browse/CASSANDRA-11687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-11687: Status: Open (was: Patch Available) What is probably happening here is that the second rebuild is completing before the first, so the first rebuild fails while the second succeeds, but we expect the second rebuild to fail. I think we should modify the test to insert more data (10k or 100k keys) with stress and set {{streaming_throughput_mb_per_sec=1}} similar to bootstrap and replace_address tests, trigger the first rebuild and {{watch_log_for("rebuilding from")}}, and then trigger the second rebuild and expect it to fail to make this more deterministic. > dtest failure in rebuild_test.TestRebuild.simple_rebuild_test > - > > Key: CASSANDRA-11687 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11687 > Project: Cassandra > Issue Type: Bug >Reporter: Russ Hatch >Assignee: Yuki Morishita > Labels: dtest > > single failure on most recent run (3.0 no-vnode) > {noformat} > concurrent rebuild should not be allowed, but one rebuild command should have > succeeded. > {noformat} > http://cassci.datastax.com/job/cassandra-3.0_novnode_dtest/217/testReport/rebuild_test/TestRebuild/simple_rebuild_test > Failed on CassCI build cassandra-3.0_novnode_dtest #217 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12212) system.compactions_in_progress needs to be used on first upgrade to 3.0
[ https://issues.apache.org/jira/browse/CASSANDRA-12212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402014#comment-15402014 ] Aleksey Yeschenko commented on CASSANDRA-12212: --- Mostly correct. "only for a very short period of time" is not true. Pre-2.1 counter cells can remain in the system potentially forever, as there is no guarantee old counter values would ever be overridden. > system.compactions_in_progress needs to be used on first upgrade to 3.0 > --- > > Key: CASSANDRA-12212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12212 > Project: Cassandra > Issue Type: Bug > Components: Compaction >Reporter: Jeremiah Jordan >Assignee: Stefania > Fix For: 3.0.x, 3.x > > > CASSANDRA-7066 removed the system.compactions_in_progress table and replaced > it with the new transaction system. But system.compactions_in_progress needs > to be consulted for the first startup after upgrading from 2.1 to 3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-7019) Improve tombstone compactions
[ https://issues.apache.org/jira/browse/CASSANDRA-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-7019: --- Resolution: Fixed Fix Version/s: (was: 3.x) 3.10 Status: Resolved (was: Ready to Commit) and committed! > Improve tombstone compactions > - > > Key: CASSANDRA-7019 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7019 > Project: Cassandra > Issue Type: Improvement > Components: Compaction >Reporter: Marcus Eriksson >Assignee: Branimir Lambov > Labels: compaction, fallout, lcs > Fix For: 3.10 > > Attachments: 7019-2-system.log, 7019-debug.log, cell.tar.gz, > control.tar.gz, none.tar.gz, row.tar.gz, temp-plot.html > > > When there are no other compactions to do, we trigger a single-sstable > compaction if there is more than X% droppable tombstones in the sstable. > In this ticket we should try to include overlapping sstables in those > compactions to be able to actually drop the tombstones. Might only be doable > with LCS (with STCS we would probably end up including all sstables) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/2] cassandra git commit: Garbage-collecting compaction operation and schema option.
Repository: cassandra Updated Branches: refs/heads/trunk 293908060 -> d40ac784d http://git-wip-us.apache.org/repos/asf/cassandra/blob/d40ac784/test/long/org/apache/cassandra/cql3/GcCompactionBench.java -- diff --git a/test/long/org/apache/cassandra/cql3/GcCompactionBench.java b/test/long/org/apache/cassandra/cql3/GcCompactionBench.java new file mode 100644 index 000..ca39b55 --- /dev/null +++ b/test/long/org/apache/cassandra/cql3/GcCompactionBench.java @@ -0,0 +1,374 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Random; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Predicate; + +import com.google.common.collect.Iterables; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import junit.framework.Assert; +import org.apache.cassandra.config.Config.CommitLogSync; +import org.apache.cassandra.config.DatabaseDescriptor; +import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.compaction.CompactionManager; +import org.apache.cassandra.db.rows.Row; +import org.apache.cassandra.db.rows.Unfiltered; +import org.apache.cassandra.db.rows.UnfilteredRowIterator; +import org.apache.cassandra.io.sstable.ISSTableScanner; +import org.apache.cassandra.io.sstable.format.SSTableReader; +import org.apache.cassandra.schema.CompactionParams.TombstoneOption; +import org.apache.cassandra.utils.FBUtilities; + +public class GcCompactionBench extends CQLTester +{ +private static final String SIZE_TIERED_STRATEGY = "SizeTieredCompactionStrategy', 'min_sstable_size' : '0"; +private static final String LEVELED_STRATEGY = "LeveledCompactionStrategy', 'sstable_size_in_mb' : '16"; + +private static final int DEL_SECTIONS = 1000; +private static final int FLUSH_FREQ = 1; +private static final int RANGE_FREQUENCY_INV = 16; +static final int COUNT = 9; +static final int ITERS = 9; + +static final int KEY_RANGE = 10; +static final int CLUSTERING_RANGE = 21; + +static final int EXTRA_SIZE = 1025; + +// The name of this method is important! +// CommitLog settings must be applied before CQLTester sets up; by using the same name as its @BeforeClass method we +// are effectively overriding it. +@BeforeClass +public static void setUpClass() // overrides CQLTester.setUpClass() +{ +DatabaseDescriptor.setCommitLogSync(CommitLogSync.periodic); +DatabaseDescriptor.setCommitLogSyncPeriod(100); +CQLTester.setUpClass(); +} + +String hashQuery; + +@Before +public void before() throws Throwable +{ +createTable("CREATE TABLE %s(" + +" key int," + +" column int," + +" data int," + +" extra text," + +" PRIMARY KEY(key, column)" + +")" + ); + +String hashIFunc = parseFunctionName(createFunction(KEYSPACE, "int, int", +" CREATE FUNCTION %s (state int, val int)" + +" CALLED ON NULL INPUT" + +" RETURNS int" + +" LANGUAGE java" + +" AS 'return val != null ? state * 17 + val : state;'")).name; +String hashTFunc = parseFunctionName(createFunction(KEYSPACE, "int, text", +" CREATE FUNCTION %s (state int, val text)" + +" CALLED ON NULL INPUT" + +" RETURNS int" + +" LANGUAGE java" + +" AS 'return val != null ? state * 17 + val.hashCode() : state;'")).name; + +String hashInt = createAggregate(KEYSPACE, "int", +" CREATE AGGREGATE %s (int)" + +" SFUNC " + hashIFunc + +" STYPE int" + +" INITCOND 1"); +String hashText = createAggregate(KEYSPACE, "text", +"
[2/2] cassandra git commit: Garbage-collecting compaction operation and schema option.
Garbage-collecting compaction operation and schema option. patch by Branimir Lambov; reviewed by Marcus Eriksson for CASSANDRA-7019 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d40ac784 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d40ac784 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d40ac784 Branch: refs/heads/trunk Commit: d40ac784d3a8ddaf71a2df8b21745827392294cc Parents: 2939080 Author: Branimir LambovAuthored: Wed Dec 23 12:50:58 2015 +0200 Committer: Marcus Eriksson Committed: Mon Aug 1 14:20:50 2016 +0200 -- CHANGES.txt | 1 + NEWS.txt| 22 ++ .../apache/cassandra/db/ColumnFamilyStore.java | 6 + .../compaction/AbstractCompactionStrategy.java | 2 + .../db/compaction/CompactionController.java | 68 +++- .../db/compaction/CompactionIterator.java | 243 +++- .../db/compaction/CompactionManager.java| 39 +- .../DateTieredCompactionStrategy.java | 2 +- .../compaction/LeveledCompactionStrategy.java | 12 +- .../cassandra/db/compaction/OperationType.java | 3 +- .../cassandra/db/compaction/Scrubber.java | 46 ++- .../SizeTieredCompactionStrategy.java | 3 +- .../TimeWindowCompactionStrategy.java | 4 +- .../cassandra/db/compaction/Verifier.java | 2 +- .../org/apache/cassandra/db/rows/Cells.java | 80 src/java/org/apache/cassandra/db/rows/Rows.java | 77 .../cassandra/db/rows/UnfilteredSerializer.java | 54 +++ .../cassandra/index/sasi/SASIIndexBuilder.java | 2 +- .../io/sstable/SSTableIdentityIterator.java | 81 +++- .../io/sstable/SSTableSimpleIterator.java | 75 .../io/sstable/format/SSTableReader.java| 18 +- .../io/sstable/format/big/BigTableReader.java | 13 +- .../io/sstable/format/big/BigTableScanner.java | 2 +- .../cassandra/schema/CompactionParams.java | 27 +- .../cassandra/service/StorageService.java | 14 + .../cassandra/service/StorageServiceMBean.java | 6 + .../org/apache/cassandra/tools/NodeProbe.java | 17 +- .../org/apache/cassandra/tools/NodeTool.java| 1 + .../tools/nodetool/GarbageCollect.java | 64 .../cassandra/cql3/GcCompactionBench.java | 374 ++ .../apache/cassandra/cql3/GcCompactionTest.java | 364 ++ .../selection/SelectionColumnMappingTest.java | 2 +- .../db/compaction/CompactionIteratorTest.java | 377 +++ .../rows/UnfilteredRowIteratorsMergeTest.java | 55 +-- .../db/rows/UnfilteredRowsGenerator.java| 340 + 35 files changed, 2399 insertions(+), 97 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/d40ac784/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 36a21e6..760cc58 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.10 + * Garbage-collecting compaction operation and schema option (CASSANDRA-7019) * Add schema to snapshot manifest, add USING TIMESTAMP clause to ALTER TABLE statements (CASSANDRA-7190) * Add beta protocol flag for v5 native protocol (CASSANDRA-12142) * Support filtering on non-PRIMARY KEY columns in the CREATE http://git-wip-us.apache.org/repos/asf/cassandra/blob/d40ac784/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 8580c7c..85f2767 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -19,6 +19,28 @@ using the provided 'sstableupgrade' tool. New features + - Compaction can now take into account overlapping tables that don't take part + in the compaction to look for deleted or overwritten data in the compacted tables. + Then such data is found, it can be safely discarded, which in turn should enable + the removal of tombstones over that data. + + The behavior can be engaged in two ways: + - as a "nodetool garbagecollect -g CELL/ROW" operation, which applies + single-table compaction on all sstables to discard deleted data in one step. + - as a "provide_overlapping_tombstones:CELL/ROW/NONE" compaction strategy flag, + which uses overlapping tables as a source of deletions/overwrites during all + compactions. + The argument specifies the granularity at which deleted data is to be found: + - If ROW is specified, only whole deleted rows (or sets of rows) will be + discarded. + - If CELL is specified, any columns whose value is overwritten or deleted + will also be discarded. + - NONE (default) specifies the old behavior,
[jira] [Commented] (CASSANDRA-12151) Audit logging for database activity
[ https://issues.apache.org/jira/browse/CASSANDRA-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401929#comment-15401929 ] stefan setyadi commented on CASSANDRA-12151: After some discussion with my team, we were thinking of the idea of being able to configure the log to each keyspace or table. And so I propose: # Cassandra will still log meta-changes of the server # We can configure it to log every query (update/read) which targets a specific keyspace or table. For our use case, we need to log it even knowing that there will be some performance penalty. all in all, the ability to configure which query will be logged will be helpful in cases where * the table is important, such as employee data, financial information, etc * or where we know the table won't be accessed as much > Audit logging for database activity > --- > > Key: CASSANDRA-12151 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12151 > Project: Cassandra > Issue Type: New Feature >Reporter: stefan setyadi > Fix For: 3.x > > Attachments: 12151.txt > > > we would like a way to enable cassandra to log database activity being done > on our server. > It should show username, remote address, timestamp, action type, keyspace, > column family, and the query statement. > it should also be able to log connection attempt and changes to the > user/roles. > I was thinking of making a new keyspace and insert an entry for every > activity that occurs. > Then It would be possible to query for specific activity or a query targeting > a specific keyspace and column family. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7019) Improve tombstone compactions
[ https://issues.apache.org/jira/browse/CASSANDRA-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401924#comment-15401924 ] Branimir Lambov commented on CASSANDRA-7019: Rebased, squashed and added CHANGES.txt and NEWS.txt entries. Pushed here: |[code|https://github.com/blambov/cassandra/tree/7019-reviewed]|[new dtest|https://github.com/riptano/cassandra-dtest/pull/1121]|[utests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-7019-reviewed-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-7019-reviewed-dtest/]| > Improve tombstone compactions > - > > Key: CASSANDRA-7019 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7019 > Project: Cassandra > Issue Type: Improvement > Components: Compaction >Reporter: Marcus Eriksson >Assignee: Branimir Lambov > Labels: compaction, fallout, lcs > Fix For: 3.x > > Attachments: 7019-2-system.log, 7019-debug.log, cell.tar.gz, > control.tar.gz, none.tar.gz, row.tar.gz, temp-plot.html > > > When there are no other compactions to do, we trigger a single-sstable > compaction if there is more than X% droppable tombstones in the sstable. > In this ticket we should try to include overlapping sstables in those > compactions to be able to actually drop the tombstones. Might only be doable > with LCS (with STCS we would probably end up including all sstables) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12008) Make decommission operations resumable
[ https://issues.apache.org/jira/browse/CASSANDRA-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401923#comment-15401923 ] Kaide Mu commented on CASSANDRA-12008: -- Decommission dtests is available: https://github.com/kdmu/cassandra-dtest/commit/fd5c95f1b582155f969d4d6e52fc4a4bf46046b1 Both tests are working properly, but I found that streamed range skipping behaviour log check-up is not working due log capacity (?), i.e. part of log is overwritten. I tried to test it by running another thread checking skipping behaviour alongside the main thread and it can find correctly the keyword, but it doesn't work if I do a watch_log_for as [L61|https://github.com/kdmu/cassandra-dtest/commit/fd5c95f1b582155f969d4d6e52fc4a4bf46046b1#diff-e726e64e1cbe236026689bfb926669cfR61] > Make decommission operations resumable > -- > > Key: CASSANDRA-12008 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12008 > Project: Cassandra > Issue Type: Improvement > Components: Streaming and Messaging >Reporter: Tom van der Woerdt >Assignee: Kaide Mu >Priority: Minor > > We're dealing with large data sets (multiple terabytes per node) and > sometimes we need to add or remove nodes. These operations are very dependent > on the entire cluster being up, so while we're joining a new node (which > sometimes takes 6 hours or longer) a lot can go wrong and in a lot of cases > something does. > It would be great if the ability to retry streams was implemented. > Example to illustrate the problem : > {code} > 03:18 PM ~ $ nodetool decommission > error: Stream failed > -- StackTrace -- > org.apache.cassandra.streaming.StreamException: Stream failed > at > org.apache.cassandra.streaming.management.StreamEventJMXNotifier.onFailure(StreamEventJMXNotifier.java:85) > at com.google.common.util.concurrent.Futures$6.run(Futures.java:1310) > at > com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457) > at > com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156) > at > com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145) > at > com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:202) > at > org.apache.cassandra.streaming.StreamResultFuture.maybeComplete(StreamResultFuture.java:210) > at > org.apache.cassandra.streaming.StreamResultFuture.handleSessionComplete(StreamResultFuture.java:186) > at > org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:430) > at > org.apache.cassandra.streaming.StreamSession.complete(StreamSession.java:622) > at > org.apache.cassandra.streaming.StreamSession.messageReceived(StreamSession.java:486) > at > org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:274) > at java.lang.Thread.run(Thread.java:745) > 08:04 PM ~ $ nodetool decommission > nodetool: Unsupported operation: Node in LEAVING state; wait for status to > become normal or restart > See 'nodetool help' or 'nodetool help '. > {code} > Streaming failed, probably due to load : > {code} > ERROR [STREAM-IN-/] 2016-06-14 18:05:47,275 StreamSession.java:520 - > [Stream #] Streaming error occurred > java.net.SocketTimeoutException: null > at > sun.nio.ch.SocketAdaptor$SocketInputStream.read(SocketAdaptor.java:211) > ~[na:1.8.0_77] > at sun.nio.ch.ChannelInputStream.read(ChannelInputStream.java:103) > ~[na:1.8.0_77] > at > java.nio.channels.Channels$ReadableByteChannelImpl.read(Channels.java:385) > ~[na:1.8.0_77] > at > org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:54) > ~[apache-cassandra-3.0.6.jar:3.0.6] > at > org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:268) > ~[apache-cassandra-3.0.6.jar:3.0.6] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_77] > {code} > If implementing retries is not possible, can we have a 'nodetool decommission > resume'? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12218) IndexSummaryManagerTest.testCancelIndex is flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-12218: Resolution: Fixed Fix Version/s: 3.9 Status: Resolved (was: Ready to Commit) Thanks, committed to 3.9 in {{b447ffc4242c1514dd33e4ace96b719d892ff4a2}} > IndexSummaryManagerTest.testCancelIndex is flaky > > > Key: CASSANDRA-12218 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12218 > Project: Cassandra > Issue Type: Test >Reporter: Joshua McKenzie >Assignee: Sam Tunnicliffe > Labels: unittest > Fix For: 3.9 > > > Test appears to be flaky given the history: > [History|http://cassci.datastax.com/job/cassandra-3.9_testall/25/testReport/org.apache.cassandra.io.sstable/IndexSummaryManagerTest/testCancelIndex/history/] > {noformat} > Error Message > Expected compaction interrupted exception > Stacktrace > junit.framework.AssertionFailedError: Expected compaction interrupted > exception > at > org.apache.cassandra.io.sstable.IndexSummaryManagerTest.testCancelIndex(IndexSummaryManagerTest.java:655) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/3] cassandra git commit: Fix flaky test in IndexSummaryManagerTest
Repository: cassandra Updated Branches: refs/heads/cassandra-3.9 a98552e65 -> b447ffc42 refs/heads/trunk a6430c8ba -> 293908060 Fix flaky test in IndexSummaryManagerTest Patch by Sam Tunnicliffe; reviewed by Marcus Eriksson for CASSANDRA-12218 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b447ffc4 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b447ffc4 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b447ffc4 Branch: refs/heads/cassandra-3.9 Commit: b447ffc4242c1514dd33e4ace96b719d892ff4a2 Parents: a98552e Author: Sam TunnicliffeAuthored: Tue Jul 19 16:22:22 2016 +0100 Committer: Sam Tunnicliffe Committed: Mon Aug 1 12:32:38 2016 +0100 -- .../io/sstable/IndexSummaryManager.java | 14 +-- .../io/sstable/IndexSummaryManagerTest.java | 95 ++-- 2 files changed, 74 insertions(+), 35 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b447ffc4/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java -- diff --git a/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java b/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java index ddda430..95ade16 100644 --- a/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java +++ b/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java @@ -225,7 +225,9 @@ public class IndexSummaryManager implements IndexSummaryManagerMBean Pair > compactingAndNonCompacting = getCompactingAndNonCompactingSSTables(); try { -redistributeSummaries(compactingAndNonCompacting.left, compactingAndNonCompacting.right, this.memoryPoolBytes); +redistributeSummaries(new IndexSummaryRedistribution(compactingAndNonCompacting.left, + compactingAndNonCompacting.right, + this.memoryPoolBytes)); } finally { @@ -237,14 +239,14 @@ public class IndexSummaryManager implements IndexSummaryManagerMBean /** * Attempts to fairly distribute a fixed pool of memory for index summaries across a set of SSTables based on * their recent read rates. - * @param transactions containing the sstables we are to redistribute the memory pool across - * @param memoryPoolBytes a size (in bytes) that the total index summary space usage should stay close to or - *under, if possible + * @param redistribution encapsulating the transactions containing the sstables we are to redistribute the + * memory pool across and a size (in bytes) that the total index summary space usage + * should stay close to or under, if possible * @return a list of new SSTableReader instances */ @VisibleForTesting -public static List redistributeSummaries(List compacting, Map
transactions, long memoryPoolBytes) throws IOException +public static List redistributeSummaries(IndexSummaryRedistribution redistribution) throws IOException { -return CompactionManager.instance.runIndexSummaryRedistribution(new IndexSummaryRedistribution(compacting, transactions, memoryPoolBytes)); +return CompactionManager.instance.runIndexSummaryRedistribution(redistribution); } } http://git-wip-us.apache.org/repos/asf/cassandra/blob/b447ffc4/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java -- diff --git a/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java b/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java index 0498c68..c0445d5 100644 --- a/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java +++ b/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java @@ -19,16 +19,8 @@ package org.apache.cassandra.io.sstable; import java.io.IOException; import java.nio.ByteBuffer; -import java.util.ArrayList; -import java.util.Collections; -import java.util.Comparator; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Set; -import java.util.concurrent.ExecutionException; -import java.util.concurrent.Future; -import java.util.concurrent.TimeUnit; +import java.util.*; +import java.util.concurrent.*; import java.util.concurrent.atomic.AtomicReference; import com.google.common.base.Joiner; @@ -147,7 +139,7 @@ public class IndexSummaryManagerTest try (LifecycleTransaction txn =
[3/3] cassandra git commit: Merge branch 'cassandra-3.9' into trunk
Merge branch 'cassandra-3.9' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/29390806 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/29390806 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/29390806 Branch: refs/heads/trunk Commit: 293908060bd8f8a94e5b6ec87dfd7aab457b4e61 Parents: a6430c8 b447ffc Author: Sam TunnicliffeAuthored: Mon Aug 1 12:47:43 2016 +0100 Committer: Sam Tunnicliffe Committed: Mon Aug 1 12:47:43 2016 +0100 -- .../io/sstable/IndexSummaryManager.java | 14 +-- .../io/sstable/IndexSummaryManagerTest.java | 95 ++-- 2 files changed, 74 insertions(+), 35 deletions(-) --
[2/3] cassandra git commit: Fix flaky test in IndexSummaryManagerTest
Fix flaky test in IndexSummaryManagerTest Patch by Sam Tunnicliffe; reviewed by Marcus Eriksson for CASSANDRA-12218 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b447ffc4 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b447ffc4 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b447ffc4 Branch: refs/heads/trunk Commit: b447ffc4242c1514dd33e4ace96b719d892ff4a2 Parents: a98552e Author: Sam TunnicliffeAuthored: Tue Jul 19 16:22:22 2016 +0100 Committer: Sam Tunnicliffe Committed: Mon Aug 1 12:32:38 2016 +0100 -- .../io/sstable/IndexSummaryManager.java | 14 +-- .../io/sstable/IndexSummaryManagerTest.java | 95 ++-- 2 files changed, 74 insertions(+), 35 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b447ffc4/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java -- diff --git a/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java b/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java index ddda430..95ade16 100644 --- a/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java +++ b/src/java/org/apache/cassandra/io/sstable/IndexSummaryManager.java @@ -225,7 +225,9 @@ public class IndexSummaryManager implements IndexSummaryManagerMBean Pair > compactingAndNonCompacting = getCompactingAndNonCompactingSSTables(); try { -redistributeSummaries(compactingAndNonCompacting.left, compactingAndNonCompacting.right, this.memoryPoolBytes); +redistributeSummaries(new IndexSummaryRedistribution(compactingAndNonCompacting.left, + compactingAndNonCompacting.right, + this.memoryPoolBytes)); } finally { @@ -237,14 +239,14 @@ public class IndexSummaryManager implements IndexSummaryManagerMBean /** * Attempts to fairly distribute a fixed pool of memory for index summaries across a set of SSTables based on * their recent read rates. - * @param transactions containing the sstables we are to redistribute the memory pool across - * @param memoryPoolBytes a size (in bytes) that the total index summary space usage should stay close to or - *under, if possible + * @param redistribution encapsulating the transactions containing the sstables we are to redistribute the + * memory pool across and a size (in bytes) that the total index summary space usage + * should stay close to or under, if possible * @return a list of new SSTableReader instances */ @VisibleForTesting -public static List redistributeSummaries(List compacting, Map
transactions, long memoryPoolBytes) throws IOException +public static List redistributeSummaries(IndexSummaryRedistribution redistribution) throws IOException { -return CompactionManager.instance.runIndexSummaryRedistribution(new IndexSummaryRedistribution(compacting, transactions, memoryPoolBytes)); +return CompactionManager.instance.runIndexSummaryRedistribution(redistribution); } } http://git-wip-us.apache.org/repos/asf/cassandra/blob/b447ffc4/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java -- diff --git a/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java b/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java index 0498c68..c0445d5 100644 --- a/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java +++ b/test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java @@ -19,16 +19,8 @@ package org.apache.cassandra.io.sstable; import java.io.IOException; import java.nio.ByteBuffer; -import java.util.ArrayList; -import java.util.Collections; -import java.util.Comparator; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Set; -import java.util.concurrent.ExecutionException; -import java.util.concurrent.Future; -import java.util.concurrent.TimeUnit; +import java.util.*; +import java.util.concurrent.*; import java.util.concurrent.atomic.AtomicReference; import com.google.common.base.Joiner; @@ -147,7 +139,7 @@ public class IndexSummaryManagerTest try (LifecycleTransaction txn = cfs.getTracker().tryModify(sstables, OperationType.UNKNOWN)) { -sstables = redistributeSummaries(Collections.EMPTY_LIST,
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401901#comment-15401901 ] Alex Petrov commented on CASSANDRA-9507: Hi [~nachiket_patil], you mentioned that new patches attached, although unfortunately I can still only see patches from 5 of July. I might be missing something. Since I could only look at those patches, I have one more comment in addition to what Benjamin has mentioned: do we want to report time as we do with other metircs with {{addNano}} and time diff? As a sidenote, as far as I can say this issue does not qualify for "critical", and according to the [discussion|https://mail-archives.apache.org/mod_mbox/cassandra-dev/201607.mbox/%3CCALdd-zjg%2Ba73VncPkU2rw_UpFPVsw0yNwO-yBqUQfK8H8FpiKw%40mail.gmail.com%3E] we probably should leave it out. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, > CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)