[jira] [Commented] (CASSANDRA-16513) Add tool to display or export the contents of a virtual table
[
https://issues.apache.org/jira/browse/CASSANDRA-16513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331118#comment-17331118
]
Kadir Selçuk commented on CASSANDRA-16513:
--
Alfa 4
> Add tool to display or export the contents of a virtual table
> -
>
> Key: CASSANDRA-16513
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16513
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics, Tool/nodetool
>Reporter: Paulo Motta
>Priority: Normal
> Labels: gsoc2021, mentor
>
> Several virtual tables were recently added, but they're currently only
> accessible via cqlsh or programmatically. While this is valuable for many use
> cases, operators are accustomed with the convenience of querying system
> metrics with a simple nodetool command.
> In addition to that, a relatively common request is to provide nodetool
> output in different formats (JSON, YAML and even XML) (CASSANDRA-5977,
> CASSANDRA-12035, CASSANDRA-12486, CASSANDRA-12698, CASSANDRA-12503). However
> this requires lots of manual labor as each nodetool subcommand needs to be
> adapted to support new output formats.
> I propose adding a new CLI tool that will consistently print to the standard
> output the contents of a virtual table. By default the command will print the
> output in a tabular format similar to cqlsh, but a "--format" parameter can
> be specified to modify the output to some other format like JSON or YAML.
> It should be possible to add a limit to the amount of rows displayed and
> filter to display only rows from with specific keys (ie. keyspace or table).
> The command should be flexible and provide simple hooks for registration and
> customization of new virtual tables.
> My vision is that this is a path towards deprecating JMX and toward CQL for
> management, as we move information currently available through JMX to virtual
> tables (as CASSANDRA-14457 did with compactionstats) and easily expose them
> in this new tool as more virtual tables are added. Eventually we can also add
> setters when we start supporting writeable virtual tables.
> I propose calling this tool admintool (naming bikeshedding welcome), for
> example:
> {noformat}
> admintool help
> admintool
> Available subcommands and entities are:
> subcommands:
> - show
> - set (future)
> entities:
> - caches
> - internode_inbound
> - internode_outbound
> - settings
> - sstable_tasks
> - system_properties
> - thread_pools
> nodetool show clients --format yaml
> ...
> nodetool show internode_outboud --format json
> ...
> nodetool show sstabletasks --filter keyspace=my_ks --filter table=my_table
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16465) Increased Read Latency With Cassandra >= 3.11.7
[ https://issues.apache.org/jira/browse/CASSANDRA-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331078#comment-17331078 ] Jai Bheemsen Rao Dhanwada commented on CASSANDRA-16465: --- [~nvest] I am planning to upgrade the Cassandra version from 3.11.6 to 3.11.9 and I don't have any tables with TWCS. have you noticed this performance drop with all the Compaction Strategies or just TWCS? > Increased Read Latency With Cassandra >= 3.11.7 > --- > > Key: CASSANDRA-16465 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16465 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ahmed ELJAMI >Priority: Normal > Fix For: 3.11.11 > > > After upgrading Cassandra from 3.11.3 to 3.11.9, Cassandra read latency 99% > increased significantly. Getting back to 3.11.3 immediately fixed the issue. > I have observed "SStable reads" increases after upgrading to 3.11.9. > The same behavior was observed by some other users: > [https://www.mail-archive.com/user@cassandra.apache.org/msg61247.html] > According to Paulo Motta's comment, this behavior may be caused by > https://issues.apache.org/jira/browse/CASSANDRA-15690 which was introduced on > 3.11.7 and removed an optimization that may cause a correctness issue when > there are partition deletions. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 3bcab600edcd8428f19b89f10d48a09f447e6715 Merge: 2c11dfc 9e1b8c0 Author: Brandon Williams AuthorDate: Fri Apr 23 15:08:53 2021 -0500 Merge branch 'cassandra-3.11' into trunk src/java/org/apache/cassandra/service/StorageService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
[
https://issues.apache.org/jira/browse/CASSANDRA-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16628:
-
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/8fd046f2557e4d50e80986b813bc904dce625e6a
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Thanks! Fixed in 8fd046f2557e4d50e80986b813bc904dce625e6a
> Logging bug during the node replacement and token assignment
>
>
> Key: CASSANDRA-16628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Jai Bheemsen Rao Dhanwada
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.25, 3.11.11, 4.0-rc2
>
>
> Hello Team,
>
> I noticed a minor logging issue when a Cassandra node is trying to boot-up
> with a new IP address but the existing data directory. The IP address and
> Token fields are inter-changed.
>
> *Sample Log:*
> {{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
> updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
> it's mine}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1124147225848710462}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1239985462983206335}}
> *Steps to Reproduce:*
> Replace a Cassandra node with the a new IP address with the same data
> directory and the logs should show the messages.
> *Cassandra Version*: 3.11.6
>
> Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
[
https://issues.apache.org/jira/browse/CASSANDRA-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16628:
-
Status: Ready to Commit (was: Review In Progress)
> Logging bug during the node replacement and token assignment
>
>
> Key: CASSANDRA-16628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Jai Bheemsen Rao Dhanwada
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.25, 3.11.11, 4.0-rc2
>
>
> Hello Team,
>
> I noticed a minor logging issue when a Cassandra node is trying to boot-up
> with a new IP address but the existing data directory. The IP address and
> Token fields are inter-changed.
>
> *Sample Log:*
> {{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
> updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
> it's mine}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1124147225848710462}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1239985462983206335}}
> *Steps to Reproduce:*
> Replace a Cassandra node with the a new IP address with the same data
> directory and the logs should show the messages.
> *Cassandra Version*: 3.11.6
>
> Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
[
https://issues.apache.org/jira/browse/CASSANDRA-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16628:
-
Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams)
Brandon Williams, Brandon Williams
Status: Review In Progress (was: Patch Available)
> Logging bug during the node replacement and token assignment
>
>
> Key: CASSANDRA-16628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Jai Bheemsen Rao Dhanwada
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.25, 3.11.11, 4.0-rc2
>
>
> Hello Team,
>
> I noticed a minor logging issue when a Cassandra node is trying to boot-up
> with a new IP address but the existing data directory. The IP address and
> Token fields are inter-changed.
>
> *Sample Log:*
> {{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
> updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
> it's mine}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1124147225848710462}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1239985462983206335}}
> *Steps to Reproduce:*
> Replace a Cassandra node with the a new IP address with the same data
> directory and the logs should show the messages.
> *Cassandra Version*: 3.11.6
>
> Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
[
https://issues.apache.org/jira/browse/CASSANDRA-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16628:
-
Test and Documentation Plan: not needed
Status: Patch Available (was: Open)
> Logging bug during the node replacement and token assignment
>
>
> Key: CASSANDRA-16628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Jai Bheemsen Rao Dhanwada
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.25, 3.11.11, 4.0-rc2
>
>
> Hello Team,
>
> I noticed a minor logging issue when a Cassandra node is trying to boot-up
> with a new IP address but the existing data directory. The IP address and
> Token fields are inter-changed.
>
> *Sample Log:*
> {{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
> updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
> it's mine}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1124147225848710462}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1239985462983206335}}
> *Steps to Reproduce:*
> Replace a Cassandra node with the a new IP address with the same data
> directory and the logs should show the messages.
> *Cassandra Version*: 3.11.6
>
> Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
[
https://issues.apache.org/jira/browse/CASSANDRA-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16628:
-
Bug Category: Parent values: Correctness(12982)
Complexity: Low Hanging Fruit
Component/s: Local/Other
Discovered By: User Report
Fix Version/s: 4.0-rc2
3.11.11
3.0.25
Severity: Low
Status: Open (was: Triage Needed)
> Logging bug during the node replacement and token assignment
>
>
> Key: CASSANDRA-16628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Normal
> Fix For: 3.0.25, 3.11.11, 4.0-rc2
>
>
> Hello Team,
>
> I noticed a minor logging issue when a Cassandra node is trying to boot-up
> with a new IP address but the existing data directory. The IP address and
> Token fields are inter-changed.
>
> *Sample Log:*
> {{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
> updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
> it's mine}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1124147225848710462}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1239985462983206335}}
> *Steps to Reproduce:*
> Replace a Cassandra node with the a new IP address with the same data
> directory and the logs should show the messages.
> *Cassandra Version*: 3.11.6
>
> Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
[
https://issues.apache.org/jira/browse/CASSANDRA-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-16628:
Assignee: Brandon Williams
> Logging bug during the node replacement and token assignment
>
>
> Key: CASSANDRA-16628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Jai Bheemsen Rao Dhanwada
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.25, 3.11.11, 4.0-rc2
>
>
> Hello Team,
>
> I noticed a minor logging issue when a Cassandra node is trying to boot-up
> with a new IP address but the existing data directory. The IP address and
> Token fields are inter-changed.
>
> *Sample Log:*
> {{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
> updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
> it's mine}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1124147225848710462}}
> {{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 -
> Nodes () and /10.24.3.9 have the same token /10.24.3.10. Ignoring
> -1239985462983206335}}
> *Steps to Reproduce:*
> Replace a Cassandra node with the a new IP address with the same data
> directory and the logs should show the messages.
> *Cassandra Version*: 3.11.6
>
> Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (d9cdf2d -> 9e1b8c0)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from d9cdf2d Merge branch 'cassandra-3.0' into cassandra-3.11 new 8fd046f Ninja fix typo in logging for CASSANDRA-16628 new 9e1b8c0 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/java/org/apache/cassandra/service/StorageService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (2c11dfc -> 3bcab60)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 2c11dfc Merge branch 'cassandra-3.11' into trunk new 8fd046f Ninja fix typo in logging for CASSANDRA-16628 new 9e1b8c0 Merge branch 'cassandra-3.0' into cassandra-3.11 new 3bcab60 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/java/org/apache/cassandra/service/StorageService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 9e1b8c051da60c26afe3ff6707f8c884d331c25b Merge: d9cdf2d 8fd046f Author: Brandon Williams AuthorDate: Fri Apr 23 15:08:28 2021 -0500 Merge branch 'cassandra-3.0' into cassandra-3.11 src/java/org/apache/cassandra/service/StorageService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Ninja fix typo in logging for CASSANDRA-16628
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 8fd046f Ninja fix typo in logging for CASSANDRA-16628
8fd046f is described below
commit 8fd046f2557e4d50e80986b813bc904dce625e6a
Author: Brandon Williams
AuthorDate: Fri Apr 23 15:07:43 2021 -0500
Ninja fix typo in logging for CASSANDRA-16628
---
src/java/org/apache/cassandra/service/StorageService.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/java/org/apache/cassandra/service/StorageService.java
b/src/java/org/apache/cassandra/service/StorageService.java
index 5d1f83e..3f54a3a 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -2207,7 +2207,7 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
}
else
{
-logger.info("Nodes () and {} have the same token {}. Ignoring
{}", endpoint, currentOwner, token, endpoint);
+logger.info("Nodes {} and {} have the same token {}. Ignoring
{}", endpoint, currentOwner, token, endpoint);
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16567) Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16567:
--
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/ca40e770a5bbdeed69700ae498866f940782864b
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
> --
>
> Key: CASSANDRA-16567
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16567
> Project: Cassandra
> Issue Type: Bug
> Components: CI, Test/unit
>Reporter: David Capwell
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/874/workflows/0b0a1e36-107a-43c7-815f-bf8e61d3028d/jobs/5227/tests
> {code}
> junit.framework.AssertionFailedError: Got more rows than expected. Expected 0
> but got 1.
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1185)
> at
> org.apache.cassandra.cql3.ViewTest.testCompoundPartitionKey(ViewTest.java:817)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16567) Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330991#comment-17330991
]
Andres de la Peña commented on CASSANDRA-16567:
---
I also think that those are not related. It seems that the CI builds for 3.0
and 3.11 have been failing lately, we'll have to look into that.
Committed to 3.0 as
[ca40e770a5bbdeed69700ae498866f940782864b|https://github.com/apache/cassandra/commit/ca40e770a5bbdeed69700ae498866f940782864b]
and merged up to
[3.11|https://github.com/apache/cassandra/commit/d9cdf2d6d95d0f19b12af68d21f7beee22b43264]
and
[trunk|https://github.com/apache/cassandra/commit/2c11dfcb5bc2dc25390a4b312911b8401d4a46e6].
Thanks for the review.
> Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
> --
>
> Key: CASSANDRA-16567
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16567
> Project: Cassandra
> Issue Type: Bug
> Components: CI, Test/unit
>Reporter: David Capwell
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/874/workflows/0b0a1e36-107a-43c7-815f-bf8e61d3028d/jobs/5227/tests
> {code}
> junit.framework.AssertionFailedError: Got more rows than expected. Expected 0
> but got 1.
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1185)
> at
> org.apache.cassandra.cql3.ViewTest.testCompoundPartitionKey(ViewTest.java:817)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16628) Logging bug during the node replacement and token assignment
Jai Bheemsen Rao Dhanwada created CASSANDRA-16628:
-
Summary: Logging bug during the node replacement and token
assignment
Key: CASSANDRA-16628
URL: https://issues.apache.org/jira/browse/CASSANDRA-16628
Project: Cassandra
Issue Type: Bug
Reporter: Jai Bheemsen Rao Dhanwada
Hello Team,
I noticed a minor logging issue when a Cassandra node is trying to boot-up with
a new IP address but the existing data directory. The IP address and Token
fields are inter-changed.
*Sample Log:*
{{WARN [GossipStage:1] 2021-04-23 18:24:06,348 StorageService.java:2425 - Not
updating host ID 27031833-5141-46e0-b032-bef67137ae49 for /10.24.3.9 because
it's mine}}
{{INFO [GossipStage:1] 2021-04-23 18:24:06,349 StorageService.java:2356 - Nodes
() and /10.24.3.9 have the same token /10.24.3.10. Ignoring
-1124147225848710462}}
{{INFO [GossipStage:1] 2021-04-23 18:24:06,350 StorageService.java:2356 - Nodes
() and /10.24.3.9 have the same token /10.24.3.10. Ignoring
-1239985462983206335}}
*Steps to Reproduce:*
Replace a Cassandra node with the a new IP address with the same data directory
and the logs should show the messages.
*Cassandra Version*: 3.11.6
Please let me know if you need more details
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 2c11dfcb5bc2dc25390a4b312911b8401d4a46e6 Merge: 3b1d7c3 d9cdf2d Author: Andrés de la Peña AuthorDate: Fri Apr 23 19:39:14 2021 +0100 Merge branch 'cassandra-3.11' into trunk CHANGES.txt| 2 + .../org/apache/cassandra/db/ColumnFamilyStore.java | 5 + .../org/apache/cassandra/db/view/TableViews.java | 11 +- src/java/org/apache/cassandra/db/view/View.java| 2 +- test/unit/org/apache/cassandra/cql3/ViewTest.java | 321 - 5 files changed, 209 insertions(+), 132 deletions(-) diff --cc CHANGES.txt index d660200,899cb79..f5331f8 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,74 -1,12 +1,76 @@@ -3.11.11 +4.0-rc2 + * Test org.apache.cassandra.net.AsyncPromiseTest FAILED (CASSANDRA-16596) +Merged from 3.11: * Ignore stale acks received in the shadow round (CASSANDRA-16588) ++Merged from 3.0: ++ * Fix materialized view builders inserting truncated data (CASSANDRA-16567) + +4.0-rc1 + * Allow for setting buffer max capacity to increase it dynamically as needed (CASSANDRA-16524) + * Harden internode message resource limit accounting against serialization failures (CASSANDRA-16616) + * Add back the source release of python driver in tree to avoid fetching from GitHub APIs (CASSANDRA-16599) + * Fix false unavailable for queries due to cluster topology changes (CASSANDRA-16545) + * Fixed a race condition issue in nodetool repair where we poll for the error before seeing the error notification, leading to a less meaningful message (CASSANDRA-16585) + * Fix mixed cluster GROUP BY queries (CASSANDRA-16582) + * Upgrade jflex to 1.8.2 (CASSANDRA-16576) + * Binary releases no longer bundle the apidocs (javadoc) (CASSANDRA-15561) + * Fix Streaming Repair metrics (CASSANDRA-16190) + * Scheduled (delayed) schema pull tasks should not run after MIGRATION stage shutdown during decommission (CASSANDRA-16495) + * When behind a firewall trunk is not buildable, need to allow overriding URLs (CASSANDRA-16563) + * Make sure sstables with moved starts are removed correctly in LeveledGenerations (CASSANDRA-16552) + * Fix race between secondary index building and active compactions tracking (CASSANDRA-16554) + * Migrate dependency handling from maven-ant-tasks to resolver-ant-tasks, removing lib/ directory from version control (CASSANDRA-16391) + * Fix 4.0 node sending a repair prepare message to a 3.x node breaking the connection (CASSANDRA-16542) + * Removed synchronized modifier from StreamSession#onChannelClose to prevent deadlocking on flush (CASSANDRA-15892) + * Throw IOE in AbstractType.writeValue if value has wrong fixed length (CASSANDRA-16500) + * Execute background refreshing of auth caches on a dedicated executor (CASSANDRA-15177) + * Update bundled java and python drivers to 3.11.0 and 3.25.0 respectively (CASSANDRA-13951) + * Add io.netty.tryReflectionSetAccessible=true to j11 server options in order to enable netty to use Unsafe direct byte buffer construction (CASSANDRA-16493) + * Make cassandra-stress -node support host:port notation (CASSANDRA-16529) + * Better handle legacy gossip application states during (and after) upgrades (CASSANDRA-16525) + * Mark StreamingMetrics.ActiveOutboundStreams as deprecated (CASSANDRA-11174) + * Increase the cqlsh version number (CASSANDRA-16509) + * Fix the CQL generated for the views.where_clause column when some identifiers require quoting (CASSANDRA-16479) + * Send FAILED_SESSION_MSG on shutdown and on in-progress repairs during startup (CASSANDRA-16425) + * Reinstate removed ApplicationState padding (CASSANDRA-16484) + * Expose data dirs to ColumnFamilyStoreMBean (CASSANDRA-16335) + * Add possibility to copy SSTables in SSTableImporter instead of moving them (CASSANDRA-16407) + * Fix DESCRIBE statement for CUSTOM indices with options (CASSANDRA-16482) + * Fix cassandra-stress JMX connection (CASSANDRA-16473) + * Avoid processing redundant application states on endpoint changes (CASSANDRA-16381) + * Prevent parent repair sessions leak (CASSANDRA-16446) + * Fix timestamp issue in SinglePartitionSliceCommandTest testPartitionD…eletionRowDeletionTie (CASSANDRA-16443) + * Promote protocol V5 out of beta (CASSANDRA-14973) + * Fix incorrect encoding for strings can be UTF8 (CASSANDRA-16429) + * Fix node unable to join when RF > N in multi-DC with added warning (CASSANDRA-16296) + * Add an option to nodetool tablestats to check sstable location correctness (CASSANDRA-16344) + * Unable to ALTER KEYSPACE while decommissioned/assassinated nodes are in gossip (CASSANDRA-16422) + * Metrics backward compatibility restored after CASSANDRA-15066 (CASSANDRA-16083) + * Reduce new reserved keywords introduced since 3.0 (CASSANDRA-16439) + * Improve system tables
[cassandra] branch cassandra-3.11 updated (618b48d -> d9cdf2d)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 618b48d Merge branch 'cassandra-3.0' into cassandra-3.11 new ca40e77 Fix materialized view builders inserting truncated data new d9cdf2d Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/db/ColumnFamilyStore.java | 5 ++ .../org/apache/cassandra/db/view/TableViews.java | 10 +++ src/java/org/apache/cassandra/db/view/View.java| 19 +++-- .../org/apache/cassandra/db/view/ViewBuilder.java | 22 -- test/unit/org/apache/cassandra/cql3/ViewTest.java | 82 -- 6 files changed, 121 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (3b1d7c3 -> 2c11dfc)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 3b1d7c3 Test org.apache.cassandra.net.AsyncPromiseTest FAILED new ca40e77 Fix materialized view builders inserting truncated data new d9cdf2d Merge branch 'cassandra-3.0' into cassandra-3.11 new 2c11dfc Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 2 + .../org/apache/cassandra/db/ColumnFamilyStore.java | 5 + .../org/apache/cassandra/db/view/TableViews.java | 11 +- src/java/org/apache/cassandra/db/view/View.java| 2 +- test/unit/org/apache/cassandra/cql3/ViewTest.java | 321 - 5 files changed, 209 insertions(+), 132 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit d9cdf2d6d95d0f19b12af68d21f7beee22b43264
Merge: 618b48d ca40e77
Author: Andrés de la Peña
AuthorDate: Fri Apr 23 19:19:52 2021 +0100
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt| 1 +
.../org/apache/cassandra/db/ColumnFamilyStore.java | 5 ++
.../org/apache/cassandra/db/view/TableViews.java | 10 +++
src/java/org/apache/cassandra/db/view/View.java| 19 +++--
.../org/apache/cassandra/db/view/ViewBuilder.java | 22 --
test/unit/org/apache/cassandra/cql3/ViewTest.java | 82 --
6 files changed, 121 insertions(+), 18 deletions(-)
diff --cc CHANGES.txt
index 443c2bf,4cba62d..899cb79
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,9 -1,5 +1,10 @@@
-3.0.25:
+3.11.11
+ * Ignore stale acks received in the shadow round (CASSANDRA-16588)
+ * Add autocomplete and error messages for provide_overlapping_tombstones
(CASSANDRA-16350)
+ * Add StorageServiceMBean.getKeyspaceReplicationInfo(keyspaceName)
(CASSANDRA-16447)
+ * Upgrade jackson-databind to 2.9.10.8 (CASSANDRA-16462)
+Merged from 3.0:
+ * Fix materialized view builders inserting truncated data (CASSANDRA-16567)
* Don't wait for schema migrations from removed nodes (CASSANDRA-16577)
* Scheduled (delayed) schema pull tasks should not run after MIGRATION stage
shutdown during decommission (CASSANDRA-16495)
* Ignore trailing zeros in hint files (CASSANDRA-16523)
diff --cc src/java/org/apache/cassandra/db/ColumnFamilyStore.java
index f4e3c1c,405aec7..30cb400
--- a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
+++ b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
@@@ -2233,10 -2052,12 +2233,12 @@@ public class ColumnFamilyStore implemen
// beginning if we restart before they [the CL segments] are
discarded for
// normal reasons post-truncate. To prevent this, we store truncation
// position in the System keyspace.
-logger.trace("truncating {}", name);
+logger.info("Truncating {}.{}", keyspace.getName(), name);
+ viewManager.stopBuild();
+
final long truncatedAt;
-final ReplayPosition replayAfter;
+final CommitLogPosition replayAfter;
if (keyspace.getMetadata().params.durableWrites ||
DatabaseDescriptor.isAutoSnapshot())
{
@@@ -2282,7 -2103,10 +2284,10 @@@
};
runWithCompactionsDisabled(Executors.callable(truncateRunnable),
true, true);
+
+ viewManager.build();
+
-logger.trace("truncate complete");
+logger.info("Truncate of {}.{} is complete", keyspace.getName(),
name);
}
/**
diff --cc src/java/org/apache/cassandra/db/view/ViewBuilder.java
index c4314f2,ca60da3..6da2441
--- a/src/java/org/apache/cassandra/db/view/ViewBuilder.java
+++ b/src/java/org/apache/cassandra/db/view/ViewBuilder.java
@@@ -110,11 -104,9 +107,13 @@@ public class ViewBuilder extends Compac
if (SystemKeyspace.isViewBuilt(ksname, viewName))
{
logger.debug("View already marked built for {}.{}",
baseCfs.metadata.ksName, view.name);
+if (!SystemKeyspace.isViewStatusReplicated(ksname, viewName))
+updateDistributed(ksname, viewName, localHostId);
++
+ completed.countDown();
return;
}
+
Iterable> ranges =
StorageService.instance.getLocalRanges(baseCfs.metadata.ksName);
final Pair buildStatus =
SystemKeyspace.getViewBuildStatus(ksname, viewName);
@@@ -189,24 -180,9 +188,25 @@@
TimeUnit.MINUTES);
logger.warn("Materialized View failed to complete, sleeping 5
minutes before restarting", e);
}
+ completed.countDown();
}
+private void updateDistributed(String ksname, String viewName, UUID
localHostId)
+{
+try
+{
+SystemDistributedKeyspace.successfulViewBuild(ksname, viewName,
localHostId);
+SystemKeyspace.setViewBuiltReplicated(ksname, viewName);
+}
+catch (Exception e)
+{
+ScheduledExecutors.nonPeriodicTasks.schedule(() ->
CompactionManager.instance.submitViewBuilder(this),
+ 5,
+ TimeUnit.MINUTES);
+logger.warn("Failed to updated the distributed status of view,
sleeping 5 minutes before retrying", e);
+}
+}
+
public CompactionInfo getCompactionInfo()
{
long rangesCompleted = 0, rangesTotal = 0;
diff --cc test/unit/org/apache/cassandra/cql3/ViewTest.java
index 9978f1d,877218e..38b1a35
---
[cassandra] branch cassandra-3.0 updated: Fix materialized view builders inserting truncated data
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new ca40e77 Fix materialized view builders inserting truncated data
ca40e77 is described below
commit ca40e770a5bbdeed69700ae498866f940782864b
Author: Andrés de la Peña
AuthorDate: Fri Apr 23 19:10:12 2021 +0100
Fix materialized view builders inserting truncated data
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for
CASSANDRA-16567
---
CHANGES.txt| 1 +
.../org/apache/cassandra/db/ColumnFamilyStore.java | 5 ++
.../org/apache/cassandra/db/view/TableViews.java | 10 +++
src/java/org/apache/cassandra/db/view/View.java| 19 +++--
.../org/apache/cassandra/db/view/ViewBuilder.java | 23 --
test/unit/org/apache/cassandra/cql3/ViewTest.java | 84 +++---
6 files changed, 119 insertions(+), 23 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 12fd27a..4cba62d 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.25:
+ * Fix materialized view builders inserting truncated data (CASSANDRA-16567)
* Don't wait for schema migrations from removed nodes (CASSANDRA-16577)
* Scheduled (delayed) schema pull tasks should not run after MIGRATION stage
shutdown during decommission (CASSANDRA-16495)
* Ignore trailing zeros in hint files (CASSANDRA-16523)
diff --git a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
index 47623e8..405aec7 100644
--- a/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
+++ b/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
@@ -2054,6 +2054,8 @@ public class ColumnFamilyStore implements
ColumnFamilyStoreMBean
// position in the System keyspace.
logger.trace("truncating {}", name);
+viewManager.stopBuild();
+
final long truncatedAt;
final ReplayPosition replayAfter;
@@ -2101,6 +2103,9 @@ public class ColumnFamilyStore implements
ColumnFamilyStoreMBean
};
runWithCompactionsDisabled(Executors.callable(truncateRunnable), true,
true);
+
+viewManager.build();
+
logger.trace("truncate complete");
}
diff --git a/src/java/org/apache/cassandra/db/view/TableViews.java
b/src/java/org/apache/cassandra/db/view/TableViews.java
index d2d4a45..34d112f 100644
--- a/src/java/org/apache/cassandra/db/view/TableViews.java
+++ b/src/java/org/apache/cassandra/db/view/TableViews.java
@@ -83,6 +83,16 @@ public class TableViews extends AbstractCollection
return Iterables.transform(views, view ->
keyspace.getColumnFamilyStore(view.getDefinition().viewName));
}
+public void build()
+{
+views.forEach(View::build);
+}
+
+public void stopBuild()
+{
+views.forEach(View::stopBuild);
+}
+
public void forceBlockingFlush()
{
for (ColumnFamilyStore viewCfs : allViewsCfs())
diff --git a/src/java/org/apache/cassandra/db/view/View.java
b/src/java/org/apache/cassandra/db/view/View.java
index 9716dc4..b5cd387 100644
--- a/src/java/org/apache/cassandra/db/view/View.java
+++ b/src/java/org/apache/cassandra/db/view/View.java
@@ -206,15 +206,20 @@ public class View
public synchronized void build()
{
-if (this.builder != null)
+stopBuild();
+builder = new ViewBuilder(baseCfs, this);
+CompactionManager.instance.submitViewBuilder(builder);
+}
+
+synchronized void stopBuild()
+{
+if (builder != null)
{
-logger.debug("Stopping current view builder due to schema change");
-this.builder.stop();
-this.builder = null;
+logger.debug("Stopping current view builder due to schema change
or truncate");
+builder.stop();
+builder.waitForCompletion();
+builder = null;
}
-
-this.builder = new ViewBuilder(baseCfs, this);
-CompactionManager.instance.submitViewBuilder(builder);
}
@Nullable
diff --git a/src/java/org/apache/cassandra/db/view/ViewBuilder.java
b/src/java/org/apache/cassandra/db/view/ViewBuilder.java
index 57bba29..ca60da3 100644
--- a/src/java/org/apache/cassandra/db/view/ViewBuilder.java
+++ b/src/java/org/apache/cassandra/db/view/ViewBuilder.java
@@ -22,15 +22,11 @@ import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
import java.util.UUID;
+import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
-import java.util.stream.Collectors;
-
-import javax.annotation.Nullable;
import com.google.common.base.Function;
-import com.google.common.collect.Iterables;
import
[jira] [Commented] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330977#comment-17330977
]
Michael Semb Wever commented on CASSANDRA-16575:
and
https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-compression/422/
> "compression" configuration in unit tests is incorrect
> --
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default
> Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>value="${build.test.dir}/cassandra.compressed.yaml"/>
>
>
>
>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two
> files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16596) Test org.apache.cassandra.net.AsyncPromiseTest FAILED
[
https://issues.apache.org/jira/browse/CASSANDRA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-16596:
--
Fix Version/s: (was: 4.0-rc)
4.0-rc2
Since Version: 4.0-alpha1
Source Control Link:
https://github.com/apache/cassandra/commit/3b1d7c36d18ce4b314b007ef439f860dd2ef7460
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Thanks!
> Test org.apache.cassandra.net.AsyncPromiseTest FAILED
> -
>
> Key: CASSANDRA-16596
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16596
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-rc2, 4.0
>
>
> Not seen in Jenkins but reported a few times from CircleCI so it seems legit
> problem:
> [Test org.apache.cassandra.net.AsyncPromiseTest
> FAILED|https://jenkins-cm4.apache.org/job/Cassandra-trunk/434/testReport/org.apache.cassandra.net/AsyncPromiseTest/]
> CircleCI
> [failiure|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/743/workflows/35cea1fd-6f38-4f09-9d7f-4673c34a9851/jobs/4104/parallel-runs/17]
> {noformat}
> Testcase: testFailure(org.apache.cassandra.net.AsyncPromiseTest): FAILED
> 8
> junit.framework.AssertionFailedError: 8
> at
> org.apache.cassandra.net.TestAbstractPromise$Async.verify(TestAbstractPromise.java:53)
> at
> org.apache.cassandra.net.TestAbstractAsyncPromise.testOneFailure(TestAbstractAsyncPromise.java:178)
> at
> org.apache.cassandra.net.AsyncPromiseTest.testFailure(AsyncPromiseTest.java:54)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.util.concurrent.TimeoutException
> at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
> at
> org.apache.cassandra.net.TestAbstractPromise$Async.verify(TestAbstractPromise.java:49)
> Test org.apache.cassandra.net.AsyncPromiseTest FAILED
> {noformat}
> Also Caleb mentioned he is seeing it in another CI infra too
> CC [~maedhroz]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Test org.apache.cassandra.net.AsyncPromiseTest FAILED
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3b1d7c3 Test org.apache.cassandra.net.AsyncPromiseTest FAILED
3b1d7c3 is described below
commit 3b1d7c36d18ce4b314b007ef439f860dd2ef7460
Author: Adam Holmberg
AuthorDate: Thu Apr 22 16:04:57 2021 -0700
Test org.apache.cassandra.net.AsyncPromiseTest FAILED
patch by Adam Holmberg; reviewed by Caleb Rackliffe, David Capwell for
CASSANDRA-16596
---
CHANGES.txt | 2 ++
test/unit/org/apache/cassandra/net/TestAbstractPromise.java | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 49c1ce4..d660200 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,8 @@
4.0-rc2
+ * Test org.apache.cassandra.net.AsyncPromiseTest FAILED (CASSANDRA-16596)
Merged from 3.11:
* Ignore stale acks received in the shadow round (CASSANDRA-16588)
+
4.0-rc1
* Allow for setting buffer max capacity to increase it dynamically as needed
(CASSANDRA-16524)
* Harden internode message resource limit accounting against serialization
failures (CASSANDRA-16616)
diff --git a/test/unit/org/apache/cassandra/net/TestAbstractPromise.java
b/test/unit/org/apache/cassandra/net/TestAbstractPromise.java
index 963c61f..32d11c3 100644
--- a/test/unit/org/apache/cassandra/net/TestAbstractPromise.java
+++ b/test/unit/org/apache/cassandra/net/TestAbstractPromise.java
@@ -46,7 +46,7 @@ abstract class TestAbstractPromise
{
try
{
-waitingOn.get(i).accept(100L, TimeUnit.MILLISECONDS);
+waitingOn.get(i).accept(1L, TimeUnit.SECONDS);
}
catch (Throwable t)
{
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16262) 4.0 Quality: Coordination & Replication Fuzz Testing
[ https://issues.apache.org/jira/browse/CASSANDRA-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330852#comment-17330852 ] Alex Petrov commented on CASSANDRA-16262: - [~adelapena] I'd like to merge as soon as it is possible of course, but at the same time I'd like it to be useful, so I'll take time and will avoid blocking RC. If I manage it in time for RC - even better. That said, it's largely done, just need to wrap up the runner DSL. > 4.0 Quality: Coordination & Replication Fuzz Testing > > > Key: CASSANDRA-16262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16262 > Project: Cassandra > Issue Type: Task > Components: Test/fuzz >Reporter: Caleb Rackliffe >Assignee: Alex Petrov >Priority: Normal > Fix For: 4.0-rc > > > CASSANDRA-16180, CASSANDRA-16181, and CASSANDRA-15977 have largely focused on > auditing the existing tests around coordination, replication, and > read-repair, respectively. We've expanded existing test cases, added coverage > around components that we've refactored along the way, and added in-JVM dtest > upgrade tests where possible. > What remains is verifying the distributed read and write paths in the face of > common operational events, namely node restarts, bootstrapping, decommission, > and cleanup. If we can find a way to simulate these events, > [Harry|https://github.com/apache/cassandra-harry] seems like a good candidate > to host the verification logic itself. > To keep things simple initially, I would propose that we start by testing > simple read-only and write-only workloads (the former without read repair). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16539) cqlsh encoding error with unicode in multi-line statement
[
https://issues.apache.org/jira/browse/CASSANDRA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16539:
--
Fix Version/s: (was: 4.0.x)
4.0
> cqlsh encoding error with unicode in multi-line statement
> -
>
> Key: CASSANDRA-16539
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16539
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0
>
>
> {noformat}
> CREATE TABLE test.users (
> user_id int PRIMARY KEY,
> name text,
> state text
> )
> {noformat}
> Multiline cql with unicode characters will fail with an encoding error:
> {noformat}
> cqlsh> insert into test.users ( user_id, name, state ) values (
>... 6,
>... 'Bonne',
>... 'Année');
> 'ascii' codec can't encode character u'\xe9' in position 74: ordinal not in
> range(128)
> {noformat}
> This is only when running Python 2.7 and when python3 is not present in the
> environment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16400) cqlsh cannot DESC TYPE with non-ascii character in the identifier
[
https://issues.apache.org/jira/browse/CASSANDRA-16400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16400:
--
Fix Version/s: (was: 4.0.x)
4.0
> cqlsh cannot DESC TYPE with non-ascii character in the identifier
> -
>
> Key: CASSANDRA-16400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16400
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0
>
>
> cqlsh fails to describe types with non-ascii characters. This is specific to
> Python 2 and does not occur in Python 3 (only tested on trunk so far).
> {code}
> CREATE TYPE ks."ࠑ " (
> v int
> );
> {code}
> {noformat}
> aholmberg-rmbp16:cassandra adamholmberg$ pyenv shell 2.7.17
> aholmberg-rmbp16:cassandra adamholmberg$ bin/cqlsh
> Connected to Test Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta4-SNAPSHOT | CQL spec 3.4.5 | Native
> protocol v4]
> Use HELP for help.
> cqlsh> desc types;
> Traceback (most recent call last):
> File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1391, in
> do_describe
> self.describe_list(result)
> File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1438, in
> describe_list
> names.append(str(row['name']))
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u0811' in
> position 1: ordinal not in range(128)
> {noformat}
> 3.11 appears to handle everything properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16539) cqlsh encoding error with unicode in multi-line statement
[
https://issues.apache.org/jira/browse/CASSANDRA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16539:
--
Description:
{noformat}
CREATE TABLE test.users (
user_id int PRIMARY KEY,
name text,
state text
)
{noformat}
Multiline cql with unicode characters will fail with an encoding error:
{noformat}
cqlsh> insert into test.users ( user_id, name, state ) values (
... 6,
... 'Bonne',
... 'Année');
'ascii' codec can't encode character u'\xe9' in position 74: ordinal not in
range(128)
{noformat}
This is only when running Python 2.7 and when python3 is not present in the
environment.
was:
{noformat}
CREATE TABLE test.users (
user_id int PRIMARY KEY,
name text,
state text
)
{noformat}
Multiline cql with unicode characters will fail with an encoding error:
{noformat}
cqlsh> insert into test.users ( user_id, name, state ) values (
... 6,
... 'Bonne',
... 'Année');
'ascii' codec can't encode character u'\xe9' in position 74: ordinal not in
range(128)
{noformat}
This is only when running Python 2.7 (deprecated in 4.0) and when python3 is
not present in the environment.
> cqlsh encoding error with unicode in multi-line statement
> -
>
> Key: CASSANDRA-16539
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16539
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0.x
>
>
> {noformat}
> CREATE TABLE test.users (
> user_id int PRIMARY KEY,
> name text,
> state text
> )
> {noformat}
> Multiline cql with unicode characters will fail with an encoding error:
> {noformat}
> cqlsh> insert into test.users ( user_id, name, state ) values (
>... 6,
>... 'Bonne',
>... 'Année');
> 'ascii' codec can't encode character u'\xe9' in position 74: ordinal not in
> range(128)
> {noformat}
> This is only when running Python 2.7 and when python3 is not present in the
> environment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16400) cqlsh cannot DESC TYPE with non-ascii character in the identifier
[
https://issues.apache.org/jira/browse/CASSANDRA-16400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16400:
--
Description:
cqlsh fails to describe types with non-ascii characters. This is specific to
Python 2 and does not occur in Python 3 (only tested on trunk so far).
{code}
CREATE TYPE ks."ࠑ " (
v int
);
{code}
{noformat}
aholmberg-rmbp16:cassandra adamholmberg$ pyenv shell 2.7.17
aholmberg-rmbp16:cassandra adamholmberg$ bin/cqlsh
Connected to Test Cluster at 127.0.0.1:9042.
[cqlsh 5.0.1 | Cassandra 4.0-beta4-SNAPSHOT | CQL spec 3.4.5 | Native protocol
v4]
Use HELP for help.
cqlsh> desc types;
Traceback (most recent call last):
File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1391, in
do_describe
self.describe_list(result)
File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1438, in
describe_list
names.append(str(row['name']))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0811' in position
1: ordinal not in range(128)
{noformat}
3.11 appears to handle everything properly.
was:
cqlsh fails to describe types with non-ascii characters. This is specific to
Python 2 and does not occur in Python 3 (only tested on trunk so far).
{code}
CREATE TYPE ks."ࠑ " (
v int
);
{code}
{noformat}
aholmberg-rmbp16:cassandra adamholmberg$ pyenv shell 2.7.17
aholmberg-rmbp16:cassandra adamholmberg$ bin/cqlsh
Connected to Test Cluster at 127.0.0.1:9042.
[cqlsh 5.0.1 | Cassandra 4.0-beta4-SNAPSHOT | CQL spec 3.4.5 | Native protocol
v4]
Use HELP for help.
cqlsh> desc types;
Traceback (most recent call last):
File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1391, in
do_describe
self.describe_list(result)
File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1438, in
describe_list
names.append(str(row['name']))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0811' in position
1: ordinal not in range(128)
{noformat}
3.0.x is broken in a different way, regardless of what characters are in the
name:
{noformat}
cqlsh> create type ks.x ( v int );
cqlsh> desc types;
Keyspace system_schema
--
Keyspace system_auth
Keyspace system
---
Keyspace ks
---
list[i] not a string for i in 0
{noformat}
3.11 appears to handle everything properly.
> cqlsh cannot DESC TYPE with non-ascii character in the identifier
> -
>
> Key: CASSANDRA-16400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16400
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 3.0.x, 4.0.x
>
>
> cqlsh fails to describe types with non-ascii characters. This is specific to
> Python 2 and does not occur in Python 3 (only tested on trunk so far).
> {code}
> CREATE TYPE ks."ࠑ " (
> v int
> );
> {code}
> {noformat}
> aholmberg-rmbp16:cassandra adamholmberg$ pyenv shell 2.7.17
> aholmberg-rmbp16:cassandra adamholmberg$ bin/cqlsh
> Connected to Test Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta4-SNAPSHOT | CQL spec 3.4.5 | Native
> protocol v4]
> Use HELP for help.
> cqlsh> desc types;
> Traceback (most recent call last):
> File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1391, in
> do_describe
> self.describe_list(result)
> File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1438, in
> describe_list
> names.append(str(row['name']))
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u0811' in
> position 1: ordinal not in range(128)
> {noformat}
> 3.11 appears to handle everything properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16400) cqlsh cannot DESC TYPE with non-ascii character in the identifier
[
https://issues.apache.org/jira/browse/CASSANDRA-16400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16400:
--
Fix Version/s: (was: 3.0.x)
> cqlsh cannot DESC TYPE with non-ascii character in the identifier
> -
>
> Key: CASSANDRA-16400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16400
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0.x
>
>
> cqlsh fails to describe types with non-ascii characters. This is specific to
> Python 2 and does not occur in Python 3 (only tested on trunk so far).
> {code}
> CREATE TYPE ks."ࠑ " (
> v int
> );
> {code}
> {noformat}
> aholmberg-rmbp16:cassandra adamholmberg$ pyenv shell 2.7.17
> aholmberg-rmbp16:cassandra adamholmberg$ bin/cqlsh
> Connected to Test Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta4-SNAPSHOT | CQL spec 3.4.5 | Native
> protocol v4]
> Use HELP for help.
> cqlsh> desc types;
> Traceback (most recent call last):
> File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1391, in
> do_describe
> self.describe_list(result)
> File "/Users/adamholmberg/code/cassandra/bin/cqlsh.py", line 1438, in
> describe_list
> names.append(str(row['name']))
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u0811' in
> position 1: ordinal not in range(128)
> {noformat}
> 3.11 appears to handle everything properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16596) Test org.apache.cassandra.net.AsyncPromiseTest FAILED
[
https://issues.apache.org/jira/browse/CASSANDRA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330843#comment-17330843
]
Adam Holmberg commented on CASSANDRA-16596:
---
Thanks.
bq. MemtableSizeTest doesn't look like it has anything to do with your patch,
although it is new
I'll look into it later today.
> Test org.apache.cassandra.net.AsyncPromiseTest FAILED
> -
>
> Key: CASSANDRA-16596
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16596
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0, 4.0-rc
>
>
> Not seen in Jenkins but reported a few times from CircleCI so it seems legit
> problem:
> [Test org.apache.cassandra.net.AsyncPromiseTest
> FAILED|https://jenkins-cm4.apache.org/job/Cassandra-trunk/434/testReport/org.apache.cassandra.net/AsyncPromiseTest/]
> CircleCI
> [failiure|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/743/workflows/35cea1fd-6f38-4f09-9d7f-4673c34a9851/jobs/4104/parallel-runs/17]
> {noformat}
> Testcase: testFailure(org.apache.cassandra.net.AsyncPromiseTest): FAILED
> 8
> junit.framework.AssertionFailedError: 8
> at
> org.apache.cassandra.net.TestAbstractPromise$Async.verify(TestAbstractPromise.java:53)
> at
> org.apache.cassandra.net.TestAbstractAsyncPromise.testOneFailure(TestAbstractAsyncPromise.java:178)
> at
> org.apache.cassandra.net.AsyncPromiseTest.testFailure(AsyncPromiseTest.java:54)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.util.concurrent.TimeoutException
> at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
> at
> org.apache.cassandra.net.TestAbstractPromise$Async.verify(TestAbstractPromise.java:49)
> Test org.apache.cassandra.net.AsyncPromiseTest FAILED
> {noformat}
> Also Caleb mentioned he is seeing it in another CI infra too
> CC [~maedhroz]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16567) Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330829#comment-17330829
]
Ekaterina Dimitrova commented on CASSANDRA-16567:
-
+1
The failing tests don't seem related.
I am curious why the dtests jars are failing again on 3.0 and 3.11 as they were
fixed and your branches seem rebased but that is topic for another
conversation, not related to this patch.
> Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
> --
>
> Key: CASSANDRA-16567
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16567
> Project: Cassandra
> Issue Type: Bug
> Components: CI, Test/unit
>Reporter: David Capwell
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/874/workflows/0b0a1e36-107a-43c7-815f-bf8e61d3028d/jobs/5227/tests
> {code}
> junit.framework.AssertionFailedError: Got more rows than expected. Expected 0
> but got 1.
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1185)
> at
> org.apache.cassandra.cql3.ViewTest.testCompoundPartitionKey(ViewTest.java:817)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16465) Increased Read Latency With Cassandra >= 3.11.7
[ https://issues.apache.org/jira/browse/CASSANDRA-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330788#comment-17330788 ] Nicolai Vest commented on CASSANDRA-16465: -- I was just curious and did run the comparison already. The branch version provided does not show the performance regression and performs just like 3.11.6. > Increased Read Latency With Cassandra >= 3.11.7 > --- > > Key: CASSANDRA-16465 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16465 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ahmed ELJAMI >Priority: Normal > Fix For: 3.11.11 > > > After upgrading Cassandra from 3.11.3 to 3.11.9, Cassandra read latency 99% > increased significantly. Getting back to 3.11.3 immediately fixed the issue. > I have observed "SStable reads" increases after upgrading to 3.11.9. > The same behavior was observed by some other users: > [https://www.mail-archive.com/user@cassandra.apache.org/msg61247.html] > According to Paulo Motta's comment, this behavior may be caused by > https://issues.apache.org/jira/browse/CASSANDRA-15690 which was introduced on > 3.11.7 and removed an optimization that may cause a correctness issue when > there are partition deletions. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16620) Improve failure message for rat plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16620: --- Fix Version/s: (was: 4.0.x) (was: 3.11.x) (was: 3.0.x) (was: 2.2.x) 4.0 4.0-rc2 3.11.11 3.0.25 2.2.20 Source Control Link: https://github.com/apache/cassandra/commit/ad16aa17637b144d114ffc8022aa24b4e98d6a21 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Improve failure message for rat plugin > -- > > Key: CASSANDRA-16620 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16620 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.20, 3.0.25, 3.11.11, 4.0-rc2, 4.0 > > > The RAT plugins failure message isn't informative, only referring to the file > (build/rat.txt) where the offending files can be found. > In CI systems, without access to that file, it is cumbersome to figure out > what those offending files are. > Add to the failure message a grep of the first few offending files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16620) Improve failure message for rat plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330459#comment-17330459 ] Michael Semb Wever commented on CASSANDRA-16620: Committed as [ad16aa17637b144d114ffc8022aa24b4e98d6a21|https://github.com/apache/cassandra/commit/ad16aa17637b144d114ffc8022aa24b4e98d6a21]. > Improve failure message for rat plugin > -- > > Key: CASSANDRA-16620 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16620 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.20, 3.0.25, 3.11.11, 4.0-rc2, 4.0 > > > The RAT plugins failure message isn't informative, only referring to the file > (build/rat.txt) where the offending files can be found. > In CI systems, without access to that file, it is cumbersome to figure out > what those offending files are. > Add to the failure message a grep of the first few offending files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 1ca245f5c8aaee456ee4248743e0cc29e9bd20d5 Merge: 26bf078 618b48d Author: Mick Semb Wever AuthorDate: Fri Apr 23 15:22:59 2021 +0200 Merge branch 'cassandra-3.11' into trunk .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --cc .gitignore index cd668ae,3bf7478..a634687 --- a/.gitignore +++ b/.gitignore @@@ -9,8 -9,7 +9,9 @@@ data conf/hotspot_compiler doc/cql3/CQL.html doc/build/ +lib/ + pylib/src/ +!lib/cassandra-driver-internal-only-*.zip # C* debs build-stamp - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: Provide a better failure message when the rat check fails
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-2.2 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-2.2 by this push: new ad16aa1 Provide a better failure message when the rat check fails ad16aa1 is described below commit ad16aa17637b144d114ffc8022aa24b4e98d6a21 Author: Mick Semb Wever AuthorDate: Fri Apr 23 14:56:00 2021 +0200 Provide a better failure message when the rat check fails patch by Mick Semb Wever; reviewed by David Capwell, Ekaterina Dimitrova for CASSANDRA-16620 --- .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.build/build-rat.xml b/.build/build-rat.xml index fde28be..468c671 100644 --- a/.build/build-rat.xml +++ b/.build/build-rat.xml @@ -67,7 +67,10 @@ - + + + + diff --git a/.gitignore b/.gitignore index cc25cbc..715f971 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ logs/ data/ conf/hotspot_compiler doc/cql3/CQL.html +pylib/src/ # C* debs build-stamp @@ -26,7 +27,7 @@ debian/files # IntelliJ .idea/ *.eml -*.iml +**/*.iml *.ipr *.iws - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit f804657ef0e3d5938021768a95214aa68bd764c8 Merge: 34267c2 ad16aa1 Author: Mick Semb Wever AuthorDate: Fri Apr 23 14:58:23 2021 +0200 Merge branch 'cassandra-2.2' into cassandra-3.0 .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (26bf078 -> 1ca245f)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 26bf078 Fix broken IntelliJ configuration Authored by Jacek Lewandowski; reviewed by Ekaterina Dimitrova and Michael Semb Wever for CASSANDRA-16618 new ad16aa1 Provide a better failure message when the rat check fails new f804657 Merge branch 'cassandra-2.2' into cassandra-3.0 new 618b48d Merge branch 'cassandra-3.0' into cassandra-3.11 new 1ca245f Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 618b48db4199bfa18b4a8b242abf35016bbf5084 Merge: d1eb6d0 f804657 Author: Mick Semb Wever AuthorDate: Fri Apr 23 15:02:59 2021 +0200 Merge branch 'cassandra-3.0' into cassandra-3.11 .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --cc .gitignore index 4353d4f,715f971..3bf7478 --- a/.gitignore +++ b/.gitignore @@@ -8,7 -8,7 +8,8 @@@ logs data/ conf/hotspot_compiler doc/cql3/CQL.html +doc/build/ + pylib/src/ # C* debs build-stamp - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (34267c2 -> f804657)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 34267c2 Update links in CONTRIBUTING.md new ad16aa1 Provide a better failure message when the rat check fails new f804657 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (d1eb6d0 -> 618b48d)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from d1eb6d0 Merge branch 'cassandra-3.0' into cassandra-3.11 new ad16aa1 Provide a better failure message when the rat check fails new f804657 Merge branch 'cassandra-2.2' into cassandra-3.0 new 618b48d Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/build-rat.xml | 5 - .gitignore | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16620) Improve failure message for rat plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330448#comment-17330448 ] Ekaterina Dimitrova commented on CASSANDRA-16620: - And to confirm, I also tested it both locally and in a Jenkins CI > Improve failure message for rat plugin > -- > > Key: CASSANDRA-16620 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16620 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x > > > The RAT plugins failure message isn't informative, only referring to the file > (build/rat.txt) where the offending files can be found. > In CI systems, without access to that file, it is cumbersome to figure out > what those offending files are. > Add to the failure message a grep of the first few offending files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16620) Improve failure message for rat plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330447#comment-17330447 ] Ekaterina Dimitrova commented on CASSANDRA-16620: - I am also +1 and see the benefits of it already. Thanks! > Improve failure message for rat plugin > -- > > Key: CASSANDRA-16620 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16620 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x > > > The RAT plugins failure message isn't informative, only referring to the file > (build/rat.txt) where the offending files can be found. > In CI systems, without access to that file, it is cumbersome to figure out > what those offending files are. > Add to the failure message a grep of the first few offending files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16626) Improve how-to commit docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330446#comment-17330446 ] Ekaterina Dimitrova commented on CASSANDRA-16626: - Yes, the git commands and template sounds good. I would probably put fake names and emails :) > Improve how-to commit docs > -- > > Key: CASSANDRA-16626 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16626 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc > > > The how to commit page looks outdated where 3.3 is being merged into trunk > whereas it should be 3.11 instead. Also adding a comment on folding patches > to the forward merge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16625) Add a CircleCI job to run some tests repeatedly
[ https://issues.apache.org/jira/browse/CASSANDRA-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña reassigned CASSANDRA-16625: - Assignee: Andres de la Peña > Add a CircleCI job to run some tests repeatedly > --- > > Key: CASSANDRA-16625 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16625 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > > I think it could be useful to have an optional CircleCI job to run some > specific tests n times. That way, tickets could attach CircleCI runs showing > that the changes don't make a certain ticket flaky or, conversely, that they > fix a flaky test. Doing this systematically should mitigate the risk of > introducing new flaky tests, and I guess it would be more convenient and easy > to share than running the tests locally or on a private CI system. > It would also be nice to have something similar in Jenkins, but I'm focusing > this ticket on CircleCI because it's available also for non-committers, so > assignees can run their tests before setting the tickets as ready for review. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16620) Improve failure message for rat plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16620: --- Reviewers: David Capwell, Ekaterina Dimitrova (was: David Capwell) > Improve failure message for rat plugin > -- > > Key: CASSANDRA-16620 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16620 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x > > > The RAT plugins failure message isn't informative, only referring to the file > (build/rat.txt) where the offending files can be found. > In CI systems, without access to that file, it is cumbersome to figure out > what those offending files are. > Add to the failure message a grep of the first few offending files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16620) Improve failure message for rat plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16620: --- Status: Ready to Commit (was: Review In Progress) > Improve failure message for rat plugin > -- > > Key: CASSANDRA-16620 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16620 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x > > > The RAT plugins failure message isn't informative, only referring to the file > (build/rat.txt) where the offending files can be found. > In CI systems, without access to that file, it is cumbersome to figure out > what those offending files are. > Add to the failure message a grep of the first few offending files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16465) Increased Read Latency With Cassandra >= 3.11.7
[ https://issues.apache.org/jira/browse/CASSANDRA-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330400#comment-17330400 ] Nicolai Vest commented on CASSANDRA-16465: -- Great, I'll give it a try during the next week. > Increased Read Latency With Cassandra >= 3.11.7 > --- > > Key: CASSANDRA-16465 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16465 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Ahmed ELJAMI >Priority: Normal > Fix For: 3.11.11 > > > After upgrading Cassandra from 3.11.3 to 3.11.9, Cassandra read latency 99% > increased significantly. Getting back to 3.11.3 immediately fixed the issue. > I have observed "SStable reads" increases after upgrading to 3.11.9. > The same behavior was observed by some other users: > [https://www.mail-archive.com/user@cassandra.apache.org/msg61247.html] > According to Paulo Motta's comment, this behavior may be caused by > https://issues.apache.org/jira/browse/CASSANDRA-15690 which was introduced on > 3.11.7 and removed an optimization that may cause a correctness issue when > there are partition deletions. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16626) Improve how-to commit docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330399#comment-17330399 ] Michael Semb Wever edited comment on CASSANDRA-16626 at 4/23/21, 11:38 AM: --- bq. Are you referring to this specifi syntax +1 (this tribal knowledge does trip folk up, and is not spoken about much but very much present) was (Author: michaelsembwever): bq. Are you referring to this specifi syntax +1 > Improve how-to commit docs > -- > > Key: CASSANDRA-16626 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16626 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc > > > The how to commit page looks outdated where 3.3 is being merged into trunk > whereas it should be 3.11 instead. Also adding a comment on folding patches > to the forward merge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16626) Improve how-to commit docs
[ https://issues.apache.org/jira/browse/CASSANDRA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330399#comment-17330399 ] Michael Semb Wever commented on CASSANDRA-16626: bq. Are you referring to this specifi syntax +1 > Improve how-to commit docs > -- > > Key: CASSANDRA-16626 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16626 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc > > > The how to commit page looks outdated where 3.3 is being merged into trunk > whereas it should be 3.11 instead. Also adding a comment on folding patches > to the forward merge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16614) Flaky test_pending_range
[
https://issues.apache.org/jira/browse/CASSANDRA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330397#comment-17330397
]
Andres de la Peña commented on CASSANDRA-16614:
---
bq. Also ins the spirit of CASSANDRA-16625 and just bc it is super useful would
you be ok we add dtest-repeat to requirements.txt?
Very good idea, I'm +100 on anything encouraging to run tests repeatedly and
indeed {{pytest-repeat}} is very useful. I have also added a brief note in
README.md about how to repeatedly run specific tests.
I'm running CI for dtests, if it looks good and you agree to the changes I
think we'll be ready to commit.
*
[3.0|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/625/]
*
[3.11|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/626/]
*
[trunk|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/627/]
> Flaky test_pending_range
>
>
> Key: CASSANDRA-16614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16614
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Flaky
> [test_pending_range|https://ci-cassandra.apache.org/job/Cassandra-trunk/445/testReport/junit/dtest-large-novnode.pending_range_test/TestPendingRangeMovements/test_pending_range/]
> {noformat}
> Error Message
> AssertionError: assert None is not None + where None = 0x7f29dfa83b80>('127\\.0\\.0\\.1.*?Down.*?Moving', '\nDatacenter:
> datacenter1\n==\nAddress RackStatus State Load
> Owns ... rack1 Up Normal 90.86 KiB
> 40.00% 5534023222112865484 \n\n\n ') +
>where = re.search
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330339#comment-17330339
]
Michael Semb Wever edited comment on CASSANDRA-16575 at 4/23/21, 11:20 AM:
---
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/706/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/706/pipeline/]
was (Author: michaelsembwever):
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/700/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/700/pipeline/]
> "compression" configuration in unit tests is incorrect
> --
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default
> Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>value="${build.test.dir}/cassandra.compressed.yaml"/>
>
>
>
>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two
> files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16627) Flaky DirectoriesTest.testSecondaryIndexDirectories
[
https://issues.apache.org/jira/browse/CASSANDRA-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330357#comment-17330357
]
Berenguer Blasi commented on CASSANDRA-16627:
-
Didn't manage to repro either introducing sleeps or on a slow env. The test
plays with a single parent folder so the timestamps should match. I can only
think sthg is modifying the folder in the background but there are no
background tasks either. I don't see any applicable JDK bugs to this scenario.
> Flaky DirectoriesTest.testSecondaryIndexDirectories
> ---
>
> Key: CASSANDRA-16627
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16627
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
>
> See failure
> [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/462/testReport/junit/org.apache.cassandra.db/DirectoriesTest/testSecondaryIndexDirectories_cdc/]
> {noformat}
> Error Message
> expected:<1619094213489> but was:<1619094213485>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<1619094213489> but
> was:<1619094213485>
> at
> org.apache.cassandra.db.DirectoriesTest.testSecondaryIndexDirectories(DirectoriesTest.java:216)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16627) Flaky DirectoriesTest.testSecondaryIndexDirectories
[
https://issues.apache.org/jira/browse/CASSANDRA-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16627:
Change Category: Quality Assurance
Complexity: Normal
Fix Version/s: 4.0-rc
Status: Open (was: Triage Needed)
> Flaky DirectoriesTest.testSecondaryIndexDirectories
> ---
>
> Key: CASSANDRA-16627
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16627
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
>
> See failure
> [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/462/testReport/junit/org.apache.cassandra.db/DirectoriesTest/testSecondaryIndexDirectories_cdc/]
> {noformat}
> Error Message
> expected:<1619094213489> but was:<1619094213485>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<1619094213489> but
> was:<1619094213485>
> at
> org.apache.cassandra.db.DirectoriesTest.testSecondaryIndexDirectories(DirectoriesTest.java:216)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16627) Flaky DirectoriesTest.testSecondaryIndexDirectories
Berenguer Blasi created CASSANDRA-16627:
---
Summary: Flaky DirectoriesTest.testSecondaryIndexDirectories
Key: CASSANDRA-16627
URL: https://issues.apache.org/jira/browse/CASSANDRA-16627
Project: Cassandra
Issue Type: Task
Components: Test/unit
Reporter: Berenguer Blasi
See failure
[here|https://ci-cassandra.apache.org/job/Cassandra-trunk/462/testReport/junit/org.apache.cassandra.db/DirectoriesTest/testSecondaryIndexDirectories_cdc/]
{noformat}
Error Message
expected:<1619094213489> but was:<1619094213485>
Stacktrace
junit.framework.AssertionFailedError: expected:<1619094213489> but
was:<1619094213485>
at
org.apache.cassandra.db.DirectoriesTest.testSecondaryIndexDirectories(DirectoriesTest.java:216)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16627) Flaky DirectoriesTest.testSecondaryIndexDirectories
[
https://issues.apache.org/jira/browse/CASSANDRA-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi reassigned CASSANDRA-16627:
---
Assignee: Berenguer Blasi
> Flaky DirectoriesTest.testSecondaryIndexDirectories
> ---
>
> Key: CASSANDRA-16627
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16627
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
>
> See failure
> [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/462/testReport/junit/org.apache.cassandra.db/DirectoriesTest/testSecondaryIndexDirectories_cdc/]
> {noformat}
> Error Message
> expected:<1619094213489> but was:<1619094213485>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<1619094213489> but
> was:<1619094213485>
> at
> org.apache.cassandra.db.DirectoriesTest.testSecondaryIndexDirectories(DirectoriesTest.java:216)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16567) Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329333#comment-17329333
]
Andres de la Peña edited comment on CASSANDRA-16567 at 4/23/21, 9:55 AM:
-
CI for the three branches:
3.0
*
[CircleCI|https://app.circleci.com/pipelines/github/adelapena/cassandra/284/workflows/ab3142b3-e135-4561-bca6-a3b4c52aa58c]
*
[ci-cassandra|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/698/pipeline]
3.11
*
[CircleCI|https://app.circleci.com/pipelines/github/adelapena/cassandra/283/workflows/8f6ee0f9-8f0f-456b-a522-c48b5d191808]
*
[ci-cassandra|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/696/pipeline]
trunk
* [CircleCI
j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/285/workflows/ca47738e-cffb-4fe6-998c-d9759452d7dd]
* [CircleCI
j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/285/workflows/81c42289-2620-4f2a-b5e5-227dd11c5c7d]
*
[ci-cassandra|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/697/pipeline]
The most notable differences between 3.0/3.11 and trunk are that only trunk has
the parallelized MV builder introduced by CASSANDRA-12245, and that 3.0/3.11
don't wait for the finalization of the builders when stopping them. The latter
is necessary when truncating a table, so I have added a small mechanism to
allow waiting for it.
was (Author: adelapena):
CI for the three branches:
3.0
*
[CircleCI|https://app.circleci.com/pipelines/github/adelapena/cassandra/284/workflows/ab3142b3-e135-4561-bca6-a3b4c52aa58c]
*
[ci-cassandra|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/695/pipeline]
3.11
*
[CircleCI|https://app.circleci.com/pipelines/github/adelapena/cassandra/283/workflows/8f6ee0f9-8f0f-456b-a522-c48b5d191808]
*
[ci-cassandra|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/696/pipeline]
trunk
* [CircleCI
j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/285/workflows/ca47738e-cffb-4fe6-998c-d9759452d7dd]
* [CircleCI
j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/285/workflows/81c42289-2620-4f2a-b5e5-227dd11c5c7d]
*
[ci-cassandra|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/697/pipeline]
The most notable differences between 3.0/3.11 and trunk are that only trunk has
the parallelized MV builder introduced by CASSANDRA-12245, and that 3.0/3.11
don't wait for the finalization of the builders when stopping them. The latter
is necessary when truncating a table, so I have added a small mechanism to
allow waiting for it.
> Fix test testCompoundPartitionKey - org.apache.cassandra.cql3.ViewTest
> --
>
> Key: CASSANDRA-16567
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16567
> Project: Cassandra
> Issue Type: Bug
> Components: CI, Test/unit
>Reporter: David Capwell
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/874/workflows/0b0a1e36-107a-43c7-815f-bf8e61d3028d/jobs/5227/tests
> {code}
> junit.framework.AssertionFailedError: Got more rows than expected. Expected 0
> but got 1.
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1185)
> at
> org.apache.cassandra.cql3.ViewTest.testCompoundPartitionKey(ViewTest.java:817)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16619) Loss of commit log data possible after sstable ingest
[ https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16619: --- Reviewers: Benjamin Lerer, Branimir Lambov, Benjamin Lerer (was: Benjamin Lerer, Branimir Lambov) Benjamin Lerer, Branimir Lambov, Benjamin Lerer (was: Benjamin Lerer, Branimir Lambov) Status: Review In Progress (was: Patch Available) > Loss of commit log data possible after sstable ingest > - > > Key: CASSANDRA-16619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16619 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.0, 3.0.x, 3.11.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > SSTable metadata contains commit log positions of the sstable. These > positions are used to filter out mutations from the commit log on restart and > only make sense for the node on which the data was flushed. > If an SSTable is moved between nodes they may cover regions that the > receiving node has not yet flushed, and result in valid data being lost > should these sections of the commit log need to be replayed. > Solution: > The chosen solution introduces a new sstable metadata (StatsMetadata) - > originatingHostId (UUID), which is the local host id of the node on which the > sstable was created, or null if not known. Commit log intervals from an > sstable are taken into account during Commit Log replay only when the > originatingHostId of the sstable matches the local node's hostId. > For new sstables the originatingHostId is set according to StorageService's > local hostId. > For compacted sstables the originatingHostId set according to > StorageService's local hostId, and only commit log intervals from local > sstables is preserved in the resulting sstable. > discovered by [~jakubzytka] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16619) Loss of commit log data possible after sstable ingest
[ https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330342#comment-17330342 ] Jacek Lewandowski commented on CASSANDRA-16619: --- I've started CI builds: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/703/ https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/704/ https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/705/ > Loss of commit log data possible after sstable ingest > - > > Key: CASSANDRA-16619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16619 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.0, 3.0.x, 3.11.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > SSTable metadata contains commit log positions of the sstable. These > positions are used to filter out mutations from the commit log on restart and > only make sense for the node on which the data was flushed. > If an SSTable is moved between nodes they may cover regions that the > receiving node has not yet flushed, and result in valid data being lost > should these sections of the commit log need to be replayed. > Solution: > The chosen solution introduces a new sstable metadata (StatsMetadata) - > originatingHostId (UUID), which is the local host id of the node on which the > sstable was created, or null if not known. Commit log intervals from an > sstable are taken into account during Commit Log replay only when the > originatingHostId of the sstable matches the local node's hostId. > For new sstables the originatingHostId is set according to StorageService's > local hostId. > For compacted sstables the originatingHostId set according to > StorageService's local hostId, and only commit log intervals from local > sstables is preserved in the resulting sstable. > discovered by [~jakubzytka] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16619) Loss of commit log data possible after sstable ingest
[ https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16619: --- Status: Patch Available (was: Ready to Commit) > Loss of commit log data possible after sstable ingest > - > > Key: CASSANDRA-16619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16619 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.0, 3.0.x, 3.11.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > SSTable metadata contains commit log positions of the sstable. These > positions are used to filter out mutations from the commit log on restart and > only make sense for the node on which the data was flushed. > If an SSTable is moved between nodes they may cover regions that the > receiving node has not yet flushed, and result in valid data being lost > should these sections of the commit log need to be replayed. > Solution: > The chosen solution introduces a new sstable metadata (StatsMetadata) - > originatingHostId (UUID), which is the local host id of the node on which the > sstable was created, or null if not known. Commit log intervals from an > sstable are taken into account during Commit Log replay only when the > originatingHostId of the sstable matches the local node's hostId. > For new sstables the originatingHostId is set according to StorageService's > local hostId. > For compacted sstables the originatingHostId set according to > StorageService's local hostId, and only commit log intervals from local > sstables is preserved in the resulting sstable. > discovered by [~jakubzytka] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16619) Loss of commit log data possible after sstable ingest
[ https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16619: --- Reviewers: Benjamin Lerer, Branimir Lambov (was: Branimir Lambov) > Loss of commit log data possible after sstable ingest > - > > Key: CASSANDRA-16619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16619 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.0, 3.0.x, 3.11.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > SSTable metadata contains commit log positions of the sstable. These > positions are used to filter out mutations from the commit log on restart and > only make sense for the node on which the data was flushed. > If an SSTable is moved between nodes they may cover regions that the > receiving node has not yet flushed, and result in valid data being lost > should these sections of the commit log need to be replayed. > Solution: > The chosen solution introduces a new sstable metadata (StatsMetadata) - > originatingHostId (UUID), which is the local host id of the node on which the > sstable was created, or null if not known. Commit log intervals from an > sstable are taken into account during Commit Log replay only when the > originatingHostId of the sstable matches the local node's hostId. > For new sstables the originatingHostId is set according to StorageService's > local hostId. > For compacted sstables the originatingHostId set according to > StorageService's local hostId, and only commit log intervals from local > sstables is preserved in the resulting sstable. > discovered by [~jakubzytka] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330339#comment-17330339
]
Michael Semb Wever commented on CASSANDRA-16575:
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/700/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/700/pipeline/]
> "compression" configuration in unit tests is incorrect
> --
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default
> Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>value="${build.test.dir}/cassandra.compressed.yaml"/>
>
>
>
>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two
> files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-16575:
---
Reviewers: Michael Semb Wever, Michael Semb Wever (was: Michael Semb Wever)
Michael Semb Wever, Michael Semb Wever (was: Michael Semb Wever)
Status: Review In Progress (was: Patch Available)
> "compression" configuration in unit tests is incorrect
> --
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default
> Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>value="${build.test.dir}/cassandra.compressed.yaml"/>
>
>
>
>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two
> files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-16575:
---
Test and Documentation Plan: CI
Status: Patch Available (was: Open)
> "compression" configuration in unit tests is incorrect
> --
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default
> Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>value="${build.test.dir}/cassandra.compressed.yaml"/>
>
>
>
>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two
> files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-16575:
---
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Low Hanging Fruit
Discovered By: User Report
Fix Version/s: 4.0.x
Severity: Normal
Status: Open (was: Triage Needed)
> "compression" configuration in unit tests is incorrect
> --
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Jacek Lewandowski
>Priority: Normal
> Fix For: 4.0.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default
> Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>value="${build.test.dir}/cassandra.compressed.yaml"/>
>
>
>
>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two
> files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16619) Loss of commit log data possible after sstable ingest
[ https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-16619: Status: Ready to Commit (was: Review In Progress) > Loss of commit log data possible after sstable ingest > - > > Key: CASSANDRA-16619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16619 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.0, 3.0.x, 3.11.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > SSTable metadata contains commit log positions of the sstable. These > positions are used to filter out mutations from the commit log on restart and > only make sense for the node on which the data was flushed. > If an SSTable is moved between nodes they may cover regions that the > receiving node has not yet flushed, and result in valid data being lost > should these sections of the commit log need to be replayed. > Solution: > The chosen solution introduces a new sstable metadata (StatsMetadata) - > originatingHostId (UUID), which is the local host id of the node on which the > sstable was created, or null if not known. Commit log intervals from an > sstable are taken into account during Commit Log replay only when the > originatingHostId of the sstable matches the local node's hostId. > For new sstables the originatingHostId is set according to StorageService's > local hostId. > For compacted sstables the originatingHostId set according to > StorageService's local hostId, and only commit log intervals from local > sstables is preserved in the resulting sstable. > discovered by [~jakubzytka] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16619) Loss of commit log data possible after sstable ingest
[ https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-16619: Reviewers: Branimir Lambov, Branimir Lambov (was: Branimir Lambov) Branimir Lambov, Branimir Lambov (was: Jakub Zytka) Status: Review In Progress (was: Patch Available) > Loss of commit log data possible after sstable ingest > - > > Key: CASSANDRA-16619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16619 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.0, 3.0.x, 3.11.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > SSTable metadata contains commit log positions of the sstable. These > positions are used to filter out mutations from the commit log on restart and > only make sense for the node on which the data was flushed. > If an SSTable is moved between nodes they may cover regions that the > receiving node has not yet flushed, and result in valid data being lost > should these sections of the commit log need to be replayed. > Solution: > The chosen solution introduces a new sstable metadata (StatsMetadata) - > originatingHostId (UUID), which is the local host id of the node on which the > sstable was created, or null if not known. Commit log intervals from an > sstable are taken into account during Commit Log replay only when the > originatingHostId of the sstable matches the local node's hostId. > For new sstables the originatingHostId is set according to StorageService's > local hostId. > For compacted sstables the originatingHostId set according to > StorageService's local hostId, and only commit log intervals from local > sstables is preserved in the resulting sstable. > discovered by [~jakubzytka] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16626) Improve how-to commit docs
[
https://issues.apache.org/jira/browse/CASSANDRA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329989#comment-17329989
]
Berenguer Blasi edited comment on CASSANDRA-16626 at 4/23/21, 7:42 AM:
---
Sgtm. Adding a template in there for the commit message makes total sense. Are
you referring to this specifi syntax i.e.?
{noformat}
Fix mixed cluster GROUP BY queries
patch by Benjamin Lerer and Adam Holmberg; reviewed by brandonwilliams for
CASSANDRA-16582
Co-authored-by: Benjamin Lerer
Co-authored-by: Adam Holmberg
{noformat}
was (Author: bereng):
Sgtm. Adding a template in there for the commit message makes total sense. Are
you referring to this specifi syntax i.e.?
{noformat}
Fix mixed cluster GROUP BY queries
Patch by Benjamin Lerer and Adam Holmberg; reviewed by brandonwilliams for
CASSANDRA-16582
Co-authored-by: Benjamin Lerer
Co-authored-by: Adam Holmberg
{noformat}
> Improve how-to commit docs
> --
>
> Key: CASSANDRA-16626
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16626
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Website
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
>
> The how to commit page looks outdated where 3.3 is being merged into trunk
> whereas it should be 3.11 instead. Also adding a comment on folding patches
> to the forward merge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16626) Improve how-to commit docs
[
https://issues.apache.org/jira/browse/CASSANDRA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329989#comment-17329989
]
Berenguer Blasi edited comment on CASSANDRA-16626 at 4/23/21, 7:41 AM:
---
Sgtm. Adding a template in there for the commit message makes total sense. Are
you referring to this specifi syntax i.e.?
{noformat}
Fix mixed cluster GROUP BY queries
Patch by Benjamin Lerer and Adam Holmberg; reviewed by brandonwilliams for
CASSANDRA-16582
Co-authored-by: Benjamin Lerer
Co-authored-by: Adam Holmberg
{noformat}
was (Author: bereng):
Sgtm. Adding a template in there for the commit message makes total sense. Are
you referring to this specifi syntax i.e.?
{noformat}
Fix mixed cluster GROUP BY queries
Patch by Benjamin Lerer and Adam Holmberg; reviewed by brandonwilliams for
CASSANDRA-16582
Co-authored-by: Benjamin Lerer
Co-authored-by: Adam Holmberg
{noformat}
> Improve how-to commit docs
> --
>
> Key: CASSANDRA-16626
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16626
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Website
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
>
> The how to commit page looks outdated where 3.3 is being merged into trunk
> whereas it should be 3.11 instead. Also adding a comment on folding patches
> to the forward merge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16626) Improve how-to commit docs
[
https://issues.apache.org/jira/browse/CASSANDRA-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329989#comment-17329989
]
Berenguer Blasi edited comment on CASSANDRA-16626 at 4/23/21, 7:40 AM:
---
Sgtm. Adding a template in there for the commit message makes total sense. Are
you referring to this specifi syntax i.e.?
{noformat}
Fix mixed cluster GROUP BY queries
Patch by Benjamin Lerer and Adam Holmberg; reviewed by brandonwilliams for
CASSANDRA-16582
Co-authored-by: Benjamin Lerer
Co-authored-by: Adam Holmberg
{noformat}
was (Author: bereng):
Sgtm. Adding a template in there for the commit message makes total sense. Are
you referring to this specifi syntax i.e.?
{noformat}
Fix mixed cluster GROUP BY queries
Patch by Benjamin Lerer and Adam Holmberg, reviewed by brandonwilliams
for CASSANDRA-16582
Co-authored-by: Benjamin Lerer
Co-authored-by: Adam Holmberg
{noformat}
> Improve how-to commit docs
> --
>
> Key: CASSANDRA-16626
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16626
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Website
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
>
> The how to commit page looks outdated where 3.3 is being merged into trunk
> whereas it should be 3.11 instead. Also adding a comment on folding patches
> to the forward merge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16614) Flaky test_pending_range
[
https://issues.apache.org/jira/browse/CASSANDRA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330019#comment-17330019
]
Berenguer Blasi commented on CASSANDRA-16614:
-
[~adelapena] excellent analysis. My patch would be testing sometimes while in
MOVING state and sometimes when the node had already moved back to NORMAL,
which is what I had seen perusing the logs. That is not correct and your patch
is the right choice. I think you should take this ticket as you pinned it down.
I multiplexed it locally a bit to make sure and LGTM so I am +1 on your patch
{noformat}
pytest --count 30 -rP --cassandra-dir=~/work/repos/bdpWS/16614
pending_range_test.py::TestPendingRangeMovements::test_pending_range
30 passed in 1558.32 seconds
{noformat}
Also ins the spirit of CASSANDRA-16625 and just bc it is super useful would you
be ok we add dtest-repeat to requirements.txt? It is what I used to multiplex
locally your dtest commit. Feel free to decline ofc
{noformat}
diff --git a/requirements.txt b/requirements.txt
index 8e7ac0a9..cf618d50 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -14,6 +14,7 @@ flaky
mock
pytest==3.6.4
pytest-timeout
+pytest-repeat
parse
pycodestyle
psutil
{noformat}
> Flaky test_pending_range
>
>
> Key: CASSANDRA-16614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16614
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Flaky
> [test_pending_range|https://ci-cassandra.apache.org/job/Cassandra-trunk/445/testReport/junit/dtest-large-novnode.pending_range_test/TestPendingRangeMovements/test_pending_range/]
> {noformat}
> Error Message
> AssertionError: assert None is not None + where None = 0x7f29dfa83b80>('127\\.0\\.0\\.1.*?Down.*?Moving', '\nDatacenter:
> datacenter1\n==\nAddress RackStatus State Load
> Owns ... rack1 Up Normal 90.86 KiB
> 40.00% 5534023222112865484 \n\n\n ') +
>where = re.search
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
