[jira] [Commented] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
[ https://issues.apache.org/jira/browse/CASSANDRA-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357079#comment-17357079 ] Berenguer Blasi commented on CASSANDRA-16711: - [~edimitrova] up for review the latest test split. Now they are 1m and 2m respectively and it should get them under the 4m timeout. There's no way to get 50% split as a single test case takes 1m alone... > Split ViewComplexTest to avoid timeouts after being moved away from 'long' > junits > - > > Key: CASSANDRA-16711 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit > section to the std one. This required splitting them to avoid timing out but > ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
[ https://issues.apache.org/jira/browse/CASSANDRA-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16711: Test and Documentation Plan: See PR Status: Patch Available (was: In Progress) > Split ViewComplexTest to avoid timeouts after being moved away from 'long' > junits > - > > Key: CASSANDRA-16711 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit > section to the std one. This required splitting them to avoid timing out but > ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
[ https://issues.apache.org/jira/browse/CASSANDRA-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16711: Fix Version/s: 4.x 4.0 4.0-rc2 > Split ViewComplexTest to avoid timeouts after being moved away from 'long' > junits > - > > Key: CASSANDRA-16711 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit > section to the std one. This required splitting them to avoid timing out but > ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
[ https://issues.apache.org/jira/browse/CASSANDRA-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16711: Bug Category: Parent values: Correctness(12982) Complexity: Normal Discovered By: Unit Test Severity: Normal Status: Open (was: Triage Needed) > Split ViewComplexTest to avoid timeouts after being moved away from 'long' > junits > - > > Key: CASSANDRA-16711 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > > Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit > section to the std one. This required splitting them to avoid timing out but > ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16711) Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits
Berenguer Blasi created CASSANDRA-16711: --- Summary: Split ViewComplexTest to avoid timeouts after being moved away from 'long' junits Key: CASSANDRA-16711 URL: https://issues.apache.org/jira/browse/CASSANDRA-16711 Project: Cassandra Issue Type: Bug Components: Test/unit Reporter: Berenguer Blasi Assignee: Berenguer Blasi Under CASSANDRA-16670 we decided to move some tickets from the 'long' junit section to the std one. This required splitting them to avoid timing out but ViewComplexTest needs further splitting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357059#comment-17357059 ] Berenguer Blasi commented on CASSANDRA-16670: - Not a big fan of reopening, I prefer a 'linear' hsitory. I'll open a new quick ticket thx. > Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest > > > Key: CASSANDRA-16670 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16670 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > *ViewComplexTest* > Flaky > [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/] > and move back away from 'long' section. > *InsertUpdateIfConditionTest* (CASSANDRA-16676) > Fails > [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/] > with a timeout. We can see in the history it takes quite a while in > [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/] > _but_ it takes just 1m locally. Probably due to constrained resources. > Looking at the > [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/] > test cases, for compression i.e., we can see 378 at an average of 1s each it > can easily go over the timeout of 240s. Recommendation is to either move to > 'long' section of to raise the timeout for the class for CI. > *ViewFilteringTest* > Move back from 'long' section -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16670: Resolution: Fixed Status: Resolved (was: Open) > Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest > > > Key: CASSANDRA-16670 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16670 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > *ViewComplexTest* > Flaky > [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/] > and move back away from 'long' section. > *InsertUpdateIfConditionTest* (CASSANDRA-16676) > Fails > [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/] > with a timeout. We can see in the history it takes quite a while in > [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/] > _but_ it takes just 1m locally. Probably due to constrained resources. > Looking at the > [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/] > test cases, for compression i.e., we can see 378 at an average of 1s each it > can easily go over the timeout of 240s. Recommendation is to either move to > 'long' section of to raise the timeout for the class for CI. > *ViewFilteringTest* > Move back from 'long' section -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357057#comment-17357057 ] Berenguer Blasi commented on CASSANDRA-16705: - Yep but I didn't want to merge without a quic+1 thx :-) > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16708: Since Version: 4.0-rc1 Source Control Link: https://github.com/apache/cassandra/commit/31c1bbe87f8e376f353df2a16881124122045936 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356989#comment-17356989 ] Ekaterina Dimitrova edited comment on CASSANDRA-16670 at 6/4/21, 1:07 AM: -- Thank you. I reopened the ticket so we can fix those. I can also look at this if you don't have the time was (Author: e.dimitrova): Thank you. I reopened the ticket so we can fix those. > Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest > > > Key: CASSANDRA-16670 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16670 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > *ViewComplexTest* > Flaky > [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/] > and move back away from 'long' section. > *InsertUpdateIfConditionTest* (CASSANDRA-16676) > Fails > [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/] > with a timeout. We can see in the history it takes quite a while in > [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/] > _but_ it takes just 1m locally. Probably due to constrained resources. > Looking at the > [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/] > test cases, for compression i.e., we can see 378 at an average of 1s each it > can easily go over the timeout of 240s. Recommendation is to either move to > 'long' section of to raise the timeout for the class for CI. > *ViewFilteringTest* > Move back from 'long' section -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16670: Resolution: (was: Fixed) Status: Open (was: Resolved) > Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest > > > Key: CASSANDRA-16670 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16670 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > *ViewComplexTest* > Flaky > [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/] > and move back away from 'long' section. > *InsertUpdateIfConditionTest* (CASSANDRA-16676) > Fails > [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/] > with a timeout. We can see in the history it takes quite a while in > [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/] > _but_ it takes just 1m locally. Probably due to constrained resources. > Looking at the > [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/] > test cases, for compression i.e., we can see 378 at an average of 1s each it > can easily go over the timeout of 240s. Recommendation is to either move to > 'long' section of to raise the timeout for the class for CI. > *ViewFilteringTest* > Move back from 'long' section -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356989#comment-17356989 ] Ekaterina Dimitrova commented on CASSANDRA-16670: - Thank you. I reopened the ticket so we can fix those. > Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest > > > Key: CASSANDRA-16670 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16670 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > *ViewComplexTest* > Flaky > [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/] > and move back away from 'long' section. > *InsertUpdateIfConditionTest* (CASSANDRA-16676) > Fails > [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/] > with a timeout. We can see in the history it takes quite a while in > [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/] > _but_ it takes just 1m locally. Probably due to constrained resources. > Looking at the > [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/] > test cases, for compression i.e., we can see 378 at an average of 1s each it > can easily go over the timeout of 240s. Recommendation is to either move to > 'long' section of to raise the timeout for the class for CI. > *ViewFilteringTest* > Move back from 'long' section -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356988#comment-17356988 ] Ekaterina Dimitrova commented on CASSANDRA-16708: - Pushed to all three branches where we have those tests, thank you: e6946e7ddb..f74ce55dab cassandra-4.0 -> cassandra-4.0 3875fd26ea..31c1bbe87f cassandra-4.0.0 -> cassandra-4.0.0 2227057ac3..51c6669676 trunk -> trunk > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 updated (3875fd2 -> 31c1bbe)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 3875fd2 Mark MemtableSizeTest as flaky patch by Ekaterina Dimitrova, reviewed by Branimir Lambov for CASSANDRA-16684 add 31c1bbe Fix StatusTest patch by Ekaterina Dimitrova, reviewed by Brandon Williams for CASSANDRA-16708 No new revisions were added by this update. Summary of changes: .../org/apache/cassandra/tools/nodetool/StatusTest.java | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository.
edimitrova pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 51c6669676c1ce825930145115e542032ed447a5
Merge: 2227057 f74ce55
Author: Ekaterina Dimitrova
AuthorDate: Thu Jun 3 20:51:47 2021 -0400
Merge branch 'cassandra-4.0' into trunk
.../org/apache/cassandra/tools/nodetool/StatusTest.java | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --cc test/unit/org/apache/cassandra/tools/nodetool/StatusTest.java
index 494d365,e3be5d9..18b716e
--- a/test/unit/org/apache/cassandra/tools/nodetool/StatusTest.java
+++ b/test/unit/org/apache/cassandra/tools/nodetool/StatusTest.java
@@@ -77,28 -81,26 +79,27 @@@ public class StatusTest extends CQLTest
schemaChange("DROP KEYSPACE " + CQLTester.KEYSPACE);
schemaChange("DROP KEYSPACE " + CQLTester.KEYSPACE_PER_TEST);
-ToolRunner.ToolResult nodetool = ToolRunner.invokeNodetool("status");
-nodetool.assertOnCleanExit();
-String[] lines = PATTERN.split(nodetool.getStdout());
+ToolRunner.ToolResult tool = ToolRunner.invokeNodetool("status");
+tool.assertOnCleanExit();
- String[] lines = tool.getStdout().split("\\R");
++String[] lines = PATTERN.split(tool.getStdout());
String hostStatus = lines[lines.length-3].trim();
-assertThat(hostStatus, startsWith("UN"));
-assertThat(hostStatus,
containsString(FBUtilities.getJustLocalAddress().getHostAddress()));
-assertThat(hostStatus, matchesPattern(".*\\d+\\.?\\d+ KiB.*"));
-assertThat(hostStatus, containsString(localHostId));
-assertThat(hostStatus, containsString(token));
-assertThat(hostStatus, endsWith(SimpleSnitch.RACK_NAME));
+assertThat(hostStatus).startsWith("UN");
+
assertThat(hostStatus).contains(FBUtilities.getJustLocalAddress().getHostAddress());
- assertThat(hostStatus).containsPattern("\\d+\\.\\d+ KiB");
++assertThat(hostStatus).containsPattern("\\d+\\.?\\d+ KiB");
+assertThat(hostStatus).contains(localHostId);
+assertThat(hostStatus).contains(token);
+assertThat(hostStatus).endsWith(SimpleSnitch.RACK_NAME);
String bootstrappingWarn = lines[lines.length-1].trim();
-assertThat(bootstrappingWarn, containsString("probably still
bootstrapping. Effective ownership information is meaningless."));
+assertThat(bootstrappingWarn)
+.contains("probably still bootstrapping. Effective ownership
information is meaningless.");
}
- @SuppressWarnings("DynamicRegexReplaceableByCompiledPattern")
private void validateStatusOutput(String hostForm, String... args)
{
-ToolRunner.ToolResult nodetool = ToolRunner.invokeNodetool(args);
-nodetool.assertOnCleanExit();
+ToolRunner.ToolResult tool = ToolRunner.invokeNodetool(args);
+tool.assertOnCleanExit();
/*
Datacenter: datacenter1
===
@@@ -107,16 -109,16 +108,16 @@@
-- AddressLoad Owns (effective) Host ID
TokenRack
UN localhost 45.71 KiB 100.0%
0b1b5e91-ad3b-444e-9c24-50578486978a 1849950853373272258 rack1
*/
- String[] lines = tool.getStdout().split("\\R");
-String[] lines = PATTERN.split(nodetool.getStdout());
-assertThat(lines[0].trim(), endsWith(SimpleSnitch.DATA_CENTER_NAME));
++String[] lines = PATTERN.split(tool.getStdout());
+assertThat(lines[0].trim()).endsWith(SimpleSnitch.DATA_CENTER_NAME);
String hostStatus = lines[lines.length-1].trim();
-assertThat(hostStatus, startsWith("UN"));
-assertThat(hostStatus, containsString(hostForm));
-assertThat(hostStatus, matchesPattern(".*\\d+\\.?\\d+ KiB.*"));
-assertThat(hostStatus, matchesPattern(".*\\d+\\.\\d+%.*"));
-assertThat(hostStatus, containsString(localHostId));
-assertThat(hostStatus, containsString(token));
-assertThat(hostStatus, endsWith(SimpleSnitch.RACK_NAME));
-assertThat(hostStatus, not(containsString("?")));
+assertThat(hostStatus).startsWith("UN");
+assertThat(hostStatus).contains(hostForm);
- assertThat(hostStatus).containsPattern("\\d+\\.\\d+ KiB");
++assertThat(hostStatus).containsPattern("\\d+\\.?\\d+ KiB");
+assertThat(hostStatus).containsPattern("\\d+\\.\\d+%");
+assertThat(hostStatus).contains(localHostId);
+assertThat(hostStatus).contains(token);
+assertThat(hostStatus).endsWith(SimpleSnitch.RACK_NAME);
+assertThat(hostStatus).doesNotContain("?");
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
[cassandra] branch trunk updated (2227057 -> 51c6669)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 2227057 Merge branch 'cassandra-4.0' into trunk add 31c1bbe Fix StatusTest patch by Ekaterina Dimitrova, reviewed by Brandon Williams for CASSANDRA-16708 add f74ce55 Merge branch 'cassandra-4.0.0' into cassandra-4.0 new 51c6669 Merge branch 'cassandra-4.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/tools/nodetool/StatusTest.java | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (e6946e7 -> f74ce55)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from e6946e7 Make JmxHistogram#getRecentValues() thread-safe add 31c1bbe Fix StatusTest patch by Ekaterina Dimitrova, reviewed by Brandon Williams for CASSANDRA-16708 add f74ce55 Merge branch 'cassandra-4.0.0' into cassandra-4.0 No new revisions were added by this update. Summary of changes: .../org/apache/cassandra/tools/nodetool/StatusTest.java | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16710) Read repairs can break row isolation
Samuel Klock created CASSANDRA-16710:
Summary: Read repairs can break row isolation
Key: CASSANDRA-16710
URL: https://issues.apache.org/jira/browse/CASSANDRA-16710
Project: Cassandra
Issue Type: Bug
Reporter: Samuel Klock
This issue essentially revives CASSANDRA-8287, was resolved "Later" in 2015.
While it was possible in principle at that time for read repair to break row
isolation, that couldn't happen in practice because Cassandra always pulled all
of the columns for each row in response to regular reads, so read repairs would
never partially resolve a row. CASSANDRA-10657 modified Cassandra to only pull
the requested columns for reads, which enabled read repair to break row
isolation in practice.
Note also that this is distinct from CASSANDRA-14593 (for read repair breaking
partition-level isolation): that issue (as we understand it) captures isolation
being broken across multiple rows within an update to a partition, while this
issue covers broken isolation across multiple columns within an update to a
single row.
This behavior is easy to reproduce under affected versions using {{ccm}}:
{code:bash}
ccm create -n 3 -v $VERSION rrtest
ccm updateconf -y 'hinted_handoff_enabled: false
max_hint_window_in_ms: 0'
ccm start
(cat
[jira] [Updated] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16708: Status: Ready to Commit (was: Review In Progress) > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16708: Reviewers: Brandon Williams, Ekaterina Dimitrova Status: Review In Progress (was: Patch Available) > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356747#comment-17356747 ] Brandon Williams commented on CASSANDRA-16708: -- +1, good catch. > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356742#comment-17356742 ] Ekaterina Dimitrova commented on CASSANDRA-16708: - [~brandon.williams], do you mind to review this one, please? > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356740#comment-17356740 ] Ekaterina Dimitrova commented on CASSANDRA-16708: - It seems that _FileUtils#stringifyFileSize_ returns an Integer if we provide a Double number like #.00. For example _FileUtils#stringifyFileSize(4.00)_ or _FileUtils#stringifyFileSize(4.0)_ will turn into "4". That is how the java format() method used by _FileUtils#stringifyFileSize_ works. I fixed the tests in org.apache.cassandra.tools.nodetool.StatusTest to look for both Integer and Double in this [patch|https://github.com/ekaterinadimitrova2/cassandra/pull/134/commits/faf03246dd568188a7c3c5eeb7b0727cb15b2070]. Thousand successful runs can be found here: [Java 8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/921/workflows/e5e6b3d3-b080-4e4e-a87c-161fc52c2c63/jobs/5489] [Java 11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/921/workflows/2c51455d-6ebd-4627-b764-f59f71c23585/jobs/5484] [build Java 8, run Java 11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/921/workflows/e5e6b3d3-b080-4e4e-a87c-161fc52c2c63/jobs/5485] > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16708: Test and Documentation Plan: https://issues.apache.org/jira/browse/CASSANDRA-16708?focusedCommentId=17356740=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17356740 Status: Patch Available (was: In Progress) > Fix > org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping > --- > > Key: CASSANDRA-16708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16708 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0.x > > > [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-16669:
--
Fix Version/s: 4.0.x
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Fix For: 4.0.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356687#comment-17356687 ] Ekaterina Dimitrova commented on CASSANDRA-16709: - Agreed, thank you! > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site
[ https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16706: Test and Documentation Plan: https://issues.apache.org/jira/browse/CASSANDRA-16706?focusedCommentId=17356682=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17356682 (was: https://issues.apache.org/jira/browse/CASSANDRA-16706?filter=-1# Only staging is prepared at the moment, as soon as it is approved and looks fine, the asf-site will also be committed) Status: Patch Available (was: In Progress) > Bring the latest in-tree docs updates to the web site > - > > Key: CASSANDRA-16706 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16706 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0-rc > > > Below two doc changes have to be published on the web site: > * > [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7] > * CASSANDRA-16682 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site
[ https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356682#comment-17356682 ] Ekaterina Dimitrova commented on CASSANDRA-16706: - In the background [~mck] fixed the conflicts between the branches. Pushing a new [commit|https://github.com/ekaterinadimitrova2/cassandra-website/commit/114b2525ea2582708e4f254475e8dcb1bd2a092a] for asf-staging review. Thank you > Bring the latest in-tree docs updates to the web site > - > > Key: CASSANDRA-16706 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16706 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0-rc > > > Below two doc changes have to be published on the web site: > * > [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7] > * CASSANDRA-16682 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14582) Add a system property to set the cassandra hostId if not yet initialized
[ https://issues.apache.org/jira/browse/CASSANDRA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-14582: -- Status: Ready to Commit (was: Changes Suggested) > Add a system property to set the cassandra hostId if not yet initialized > > > Key: CASSANDRA-14582 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14582 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: vincent royer >Assignee: Abuli Palagashvili >Priority: Low > Labels: lhf > Fix For: 4.1 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Add a system property *cassandra.host_id* to set the cassandra hostId if not > yet initialized. > This allow to push the cassandra host ID when provisioning new cassandra > nodes rather than to retreive it after the first start. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1735#comment-1735 ] Michael Semb Wever commented on CASSANDRA-16704: A second patch would be good. And I agree with your analysis of TestRateLimiter.java, something seems off there, though maybe it's how byteman (mutation_limiter.btm) needs its classpaths setup…? > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: test-with-runtime-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (92198fd -> 5ed8e48)
This is an automated email from the ASF dual-hosted git repository.
mck pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git.
discard 92198fd hack in plausible tracking with
add 83ba244 hack in plausible tracking with
add 1e3b00f Fix world-party link and page. Fix plausible tracking on new
design pages.
add 493bdee Fix 3.11.10 and 3.0.24 download names, links and dates.
add 4465915 CASSANDRA-16665 May 2021 updates to static pages
add d9a4143 Fix broken image on front page
new 5ed8e48 switch hacked plausible tracking from cassandra.apache.org to
cassandra.staged.apache.org with `find content -name "*.html" -exec sed -i ''
's;data-domain="cassandra.apache.org;data-domain="cassandra.staged.apache.org;'
{} \;`
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (92198fd)
\
N -- N -- N refs/heads/asf-staging (5ed8e48)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../Apache-Cassandra-Changelog-1-October-2020.html | 2 +-
...Apache-Cassandra-Changelog-2-December-2020.html | 2 +-
.../Apache-Cassandra-Changelog-3-January-2021.html | 2 +-
...Apache-Cassandra-Changelog-4-February-2021.html | 2 +-
.../Apache-Cassandra-Changelog-5-March-2021.html | 2 +-
.../Apache-Cassandra-Changelog-6-April-2021.html | 2 +-
.../blog/Apache-Cassandra-Usage-Report-2020.html | 2 +-
.../blog/Audit-Logging-in-Apache-Cassandra-4.html | 2 +-
...andra-and-Kubernetes-SIG-Update-and-Survey.html | 2 +-
...ty-with-5x-Faster-Streaming-in-Cassandra-4.html | 2 +-
...ra's-Internals-with-Property-based-Testing.html | 2 +-
...-Zero-Copy-Streaming-in-Apache-Cassandra-4.html | 2 +-
...che-Cassandras-Front-Door-and-Backpressure.html | 2 +-
...assandra-4-Beta-Battle-Tested-From-Day-One.html | 2 +-
.../blog/Introducing-Transient-Replication.html| 2 +-
...SoC-2021.html => Join-Cassandra-GSoC-2021.html} | 2 +-
content/blog/Join-Casssandra-GSoC-2021.html| 2 +-
...ced-for-April-28-Cassandra-4.0-World-Party.html | 2 +-
content/blog/Testing-Apache-Cassandra-4.html | 2 +-
content/blog/World-Party.html | 2 +-
content/blog/index.html| 2 +-
content/blog/template.html | 2 +-
content/case-studies/index.html| 2 +-
content/cassandra-basics/index.html| 2 +-
content/community/index.html | 2 +-
content/doc/old/CQL-2.1.html | 2 +-
content/doc/old/CQL-2.2.html | 2 +-
content/doc/old/CQL-3.0.html | 2 +-
content/download/index.html| 10 +-
content/ecosystem/index.html | 5 +++--
content/index.html | 10 +-
content/quickstart/index.html | 2 +-
content/resources/index.html | 2 +-
content/world-party/index.html | 22 ++
34 files changed, 45 insertions(+), 62 deletions(-)
copy content/blog/{Join-Casssandra-GSoC-2021.html =>
Join-Cassandra-GSoC-2021.html} (98%)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16709: - Resolution: Fixed Status: Resolved (was: Open) I don't think blocking on CASSANDRA-16449 makes sense here since this branch won't be long lived, so closing this ticket since it is done. > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16709: - Status: Open (was: Patch Available) > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16709: - Test and Documentation Plan: not needed Status: Patch Available (was: In Progress) > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Since Version: 4.0-rc2
Source Control Link:
https://github.com/apache/cassandra/commit/e6946e7ddb76bd72109995664289e988b0e9818c
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as
https://github.com/apache/cassandra/commit/e6946e7ddb76bd72109995664289e988b0e9818c
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 2227057ac3dacba9bebd82d7cc3319c98d62cff4 Merge: 4acfd3b e6946e7 Author: Caleb Rackliffe AuthorDate: Thu Jun 3 13:30:44 2021 -0500 Merge branch 'cassandra-4.0' into trunk CHANGES.txt | 1 + .../cassandra/metrics/CassandraMetricsRegistry.java | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --cc CHANGES.txt index c1d1669,d562f54..185ec72 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,6 -1,5 +1,7 @@@ -4.0-rc2 +4.1 + * GossiperTest.testHasVersion3Nodes didn't take into account trunk version changes, fixed to rely on latest version (CASSANDRA-16651) +Merged from 4.0: + * Make JmxHistogram#getRecentValues() and JmxTimer#getRecentValues() thread-safe (CASSANDRA-16707) * Keep python driver in artifacts (CASSANDRA-16700) * Improve AuditLogging documentation and logback.xml(CASSANDRA-16682) * Spin up SEPWorker threads whenever we grow the number of work permits(CASSANDRA-16668) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (4acfd3b -> 2227057)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 4acfd3b Merge branch 'cassandra-4.0' into trunk new e6946e7 Make JmxHistogram#getRecentValues() thread-safe new 2227057 Merge branch 'cassandra-4.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + .../cassandra/metrics/CassandraMetricsRegistry.java | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Make JmxHistogram#getRecentValues() thread-safe
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new e6946e7 Make JmxHistogram#getRecentValues() thread-safe
e6946e7 is described below
commit e6946e7ddb76bd72109995664289e988b0e9818c
Author: Caleb Rackliffe
AuthorDate: Wed Jun 2 14:56:41 2021 -0500
Make JmxHistogram#getRecentValues() thread-safe
patch by Caleb Rackliffe; reviewed by Brandon Williams and Yifan Cai for
CASSANDRA-16707
---
CHANGES.txt | 1 +
.../cassandra/metrics/CassandraMetricsRegistry.java | 20 ++--
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index dc92a5b..d562f54 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-rc2
+ * Make JmxHistogram#getRecentValues() and JmxTimer#getRecentValues()
thread-safe (CASSANDRA-16707)
* Keep python driver in artifacts (CASSANDRA-16700)
* Improve AuditLogging documentation and logback.xml(CASSANDRA-16682)
* Spin up SEPWorker threads whenever we grow the number of work
permits(CASSANDRA-16668)
diff --git
a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 0b5bac5..1ae2455 100644
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@ -388,8 +388,16 @@ public class CassandraMetricsRegistry extends
MetricRegistry
return metric.getSnapshot().getValues();
}
+/**
+ * Returns a histogram describing the values recorded since the last
time this method was called.
+ *
+ * ex. If the counts are [0, 1, 2, 1] at the time the first caller
arrives, but change to [1, 2, 3, 2] by the
+ * time a second caller arrives, the second caller will receive [1, 1,
1, 1].
+ *
+ * @return a histogram whose bucket offsets are assumed to be in
nanoseconds
+ */
@Override
-public long[] getRecentValues()
+public synchronized long[] getRecentValues()
{
long[] now = metric.getSnapshot().getValues();
long[] delta = delta(now, last);
@@ -605,8 +613,16 @@ public class CassandraMetricsRegistry extends
MetricRegistry
return metric.getSnapshot().getValues();
}
+/**
+ * Returns a histogram describing the values recorded since the last
time this method was called.
+ *
+ * ex. If the counts are [0, 1, 2, 1] at the time the first caller
arrives, but change to [1, 2, 3, 2] by the
+ * time a second caller arrives, the second caller will receive [1, 1,
1, 1].
+ *
+ * @return a histogram whose bucket offsets are assumed to be in
nanoseconds
+ */
@Override
-public long[] getRecentValues()
+public synchronized long[] getRecentValues()
{
long[] now = metric.getSnapshot().getValues();
long[] delta = delta(now, last);
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356648#comment-17356648 ] Ekaterina Dimitrova commented on CASSANDRA-16709: - I saw https://jenkins-cm4.apache.org/job/Cassandra-4.0.0/1/console kicked in > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16709: Fix Version/s: 4.0-rc2 > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356645#comment-17356645 ] Ekaterina Dimitrova commented on CASSANDRA-16709: - I was right, the jobs just kicked in. Seems like the dtest-jars build in the current setup. I think there is nothing to be done for circle now. NOTE: I didn't update with the dtest repo so if someone is checking the runs, yes, the dtests are not updated > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356637#comment-17356637
]
Angelo Polo commented on CASSANDRA-16704:
-
I would think so. I can check and create a second patch for those.
A side comment:
{quote}Maybe there are jar files here that should be removed, i.e. should not
even be part the provided scope?
{quote}
Byteman in particular seems to be in 'provided' because of the single class
src/java/org/apache/cassandra/utils/TestRateLimiter.java, which appears to be
only used for testing. Without knowing the details of how byteman works, since
this class doesn't seem to make any reference to other Cassandra classes, the
package name would be the only relevant thing here (if even that) and it could
be moved to test/. The byteman deps could then all be 'test' scoped only. Or is
this class in src/ simply because it could be used by test/unit/,
test/distributed/, etc., whose trees shouldn't depend on each other? (That
would seem a weak reason to include a class with ordinarily unresolvable
imports in the end product, but so long as no one uses it no harm done, and I'm
not up to speed on the organization of tests categories anyhow.)
> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16681) org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky
[
https://issues.apache.org/jira/browse/CASSANDRA-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356635#comment-17356635
]
Adam Holmberg commented on CASSANDRA-16681:
---
I think I've found a race. I know [~gianluca] also said he's working on a
patch, so I'm just going to post my findings here so we can compare notes.
What I think is happening:
LocalPool.addChunk
[evicts|https://lists.apache.org/thread.html/r75b09da8df530aa382605887a63dfa57b9c8d647b10f9064dd2b027a%40%3Cdev.cassandra.apache.org%3E]
a non-empty chunk in thread A. {{evict.release()}} finds a "not free" chunk
and does not recycle. Meanwhile, thread B does {{LocalPooll.put}}, freeing the
last buffer from the chunk. {{free}} returns -1, but the [status
CaS|https://github.com/apache/cassandra/blob/4acfd3bdf1acdb6b28059a49dd39823d7ea0689d/src/java/org/apache/cassandra/utils/memory/BufferPool.java#L808]
fails because thread A has not yet {{setEvicted}}. We therefore leave the
function with the chunk totally freed, but not recycled.
I have a patch with some synchronization around the release+status update that
removes this flakiness. Currently wondering how big an issue it actually is,
and if we care. Also pondering if this should be moved out of 4.0 for a number
of reasons:
1.) 4.0 is close and I don't have much appetite for touching such integral code
2.) I think this issue is low-impact since the chunk would just be GC'd instead
of being recycled
3.) The test is fairly pathological and this is perhaps even less likely to
happen in the running server (pure speculation)
Curious to get input on this and hear what Gianluca has found.
> org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky
> --
>
> Key: CASSANDRA-16681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16681
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0, 4.0-rc
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Jenkins history:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.utils.memory/LongBufferPoolTest/testPoolAllocateWithRecyclePartially/history/]
> Fails being run in a loop in CircleCI:
> https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/844/workflows/945011f4-00ac-4678-89f6-5c0db0a40169/jobs/5008
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356634#comment-17356634 ] Ekaterina Dimitrova commented on CASSANDRA-16709: - >From what I see in CASSANDRA-16642 I think in general the only update in >CircleCI config should be to add all branches >[here|https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L3785]. Currently cassandra-4.0 is missing there due to CASSANDRA-16649. I think we shouldn't also add anything for cassandra-4.0.0 until that patch is committed. I pushed a CI run but it is on hold, I think it is a circle issue that the build doesn't start at all, the job is queued and from my experience, I guess it will start just later today: [Java 8| https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/919/workflows/b0ae6f1a-bffa-47b4-becb-2dd276049e01] | [Java 11 |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/919/workflows/cc6b1f74-bb03-4283-9af1-a9f159b725a1] I will keep an eye on the jobs > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356616#comment-17356616 ] Ekaterina Dimitrova commented on CASSANDRA-16709: - +1 on not updating now how_to_commit. Also the new web site is in transition, let's not complicate it > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356599#comment-17356599 ] Brandon Williams commented on CASSANDRA-16709: -- Extra builds changes [here|https://github.com/apache/cassandra-builds/commit/be0e96356b095165049183048a0d9e67b1dfae7f]. Given that this should be relatively short lived, maybe updating how_to_commit just to remove it later isn't worth the trouble. > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: more 4.0.0 additions for jdk version/dtest upgrades
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/trunk by this push:
new be0e963 more 4.0.0 additions for jdk version/dtest upgrades
be0e963 is described below
commit be0e96356b095165049183048a0d9e67b1dfae7f
Author: Brandon Williams
AuthorDate: Thu Jun 3 12:12:54 2021 -0500
more 4.0.0 additions for jdk version/dtest upgrades
---
jenkins-dsl/cassandra_job_dsl_seed.groovy | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index 2b249c2..f1dde4d 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -380,7 +380,7 @@ cassandraBranches.each {
disabled(false)
using('Cassandra-template-artifacts')
axes {
-if (branchName == 'trunk' || branchName == 'cassandra-4.0') {
+if (branchName == 'trunk' || branchName == 'cassandra-4.0.0' ||
branchName == 'cassandra-4.0') {
jdk('jdk_1.8_latest','jdk_11_latest')
} else {
jdk('jdk_1.8_latest')
@@ -454,7 +454,7 @@ cassandraBranches.each {
_testSplits = "/${testSplits}"
}
// jvm-dtest-upgrade would require mixed JDK compilations
to support JDK11+
-if ((branchName == 'trunk' || branchName ==
'cassandra-4.0') && targetName != 'jvm-dtest-upgrade') {
+if ((branchName == 'trunk' || branchName ==
'cassandra-4.0.0' || branchName == 'cassandra-4.0') && targetName !=
'jvm-dtest-upgrade') {
jdk(jdkLabel,'jdk_11_latest')
} else {
jdk(jdkLabel)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356586#comment-17356586 ] Michael Semb Wever commented on CASSANDRA-16704: bq. Though in terms of classpath, we're effectively back where we started since instead of joining the compile and provided scopes from build/lib/ with the test scope in build/test/lib/ we'd be joining the compile scope in lib/ with the test and provided scopes in build/test/lib/. Yeah, we have three separate concerns: - compiling, requires compile and provided scopes, - packaging, requires compile scope, - testing, requires compile and test scopes, and sometimes provided/optional scope. I'm open to suggestions on how to tackle this, but not sure the current patch to build.xml really puts us in a significantly better situation. The rest of the patch LGTM! bq. there's no need to duplicate dependencies across provided and test. Shouldn't we be able to remove the test scoped duplicated lines then? > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: test-with-runtime-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356583#comment-17356583 ] Ekaterina Dimitrova commented on CASSANDRA-16709: - Thanks [~brandon.williams], I will take a look in an hour > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356579#comment-17356579 ] Brandon Williams commented on CASSANDRA-16709: -- I've created the 4.0.0 branch and done the dtest changes [here|https://github.com/apache/cassandra-dtest/commit/aea34450e650527452940f81ee5ef06160310ee7] and builds changes [here|https://github.com/apache/cassandra-builds/commit/a07c2ae4305672f5f56c34ee39f6ceb1b7d09ecd] but am leaving circle for [~e.dimitrova]. > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356498#comment-17356498
]
Ekaterina Dimitrova edited comment on CASSANDRA-16684 at 6/3/21, 4:48 PM:
--
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
[https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java|https://github.com/ekaterinadimitrova2/cassandra/commit/f635755025ebf27bf3868b40e033d04ae1133689]
was (Author: e.dimitrova):
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644a]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
[https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java|https://github.com/ekaterinadimitrova2/cassandra/commit/f635755025ebf27bf3868b40e033d04ae1133689]
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356498#comment-17356498
]
Ekaterina Dimitrova edited comment on CASSANDRA-16684 at 6/3/21, 4:48 PM:
--
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567/3c26e90b1a1a13204195b89b1644]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
[https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java|https://github.com/ekaterinadimitrova2/cassandra/commit/f635755025ebf27bf3868b40e033d04ae1133689]
was (Author: e.dimitrova):
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
[https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java|https://github.com/ekaterinadimitrova2/cassandra/commit/f635755025ebf27bf3868b40e033d04ae1133689]
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: Add 4.0.0 branch
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/trunk by this push:
new a07c2ae Add 4.0.0 branch
a07c2ae is described below
commit a07c2ae4305672f5f56c34ee39f6ceb1b7d09ecd
Author: Brandon Williams
AuthorDate: Thu Jun 3 11:42:04 2021 -0500
Add 4.0.0 branch
---
build-scripts/cassandra-test.sh | 2 +-
jenkins-dsl/cassandra_job_dsl_seed.groovy | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/build-scripts/cassandra-test.sh b/build-scripts/cassandra-test.sh
index 7756ecd..0df3292 100755
--- a/build-scripts/cassandra-test.sh
+++ b/build-scripts/cassandra-test.sh
@@ -34,7 +34,7 @@ _build_all_dtest_jars() {
cd $TMP_DIR
until git clone --quiet --depth 1 --no-single-branch
https://github.com/apache/cassandra.git cassandra-dtest-jars ; do echo "git
clone failed… trying again… " ; done
cd cassandra-dtest-jars
-for branch in cassandra-2.2 cassandra-3.0 cassandra-3.11 cassandra-4.0
trunk; do
+for branch in cassandra-2.2 cassandra-3.0 cassandra-3.11 cassandra-4.0
cassandra-4.0.0 trunk; do
git checkout $branch
ant realclean
ant jar dtest-jar
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index e46c9f5..2b249c2 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -55,7 +55,7 @@ if(binding.hasVariable("CASSANDRA_DTEST_GIT_URL")) {
}
def buildDescStr = 'REF = ${GIT_BRANCH} COMMIT = ${GIT_COMMIT}'
// Cassandra active branches
-def cassandraBranches = ['cassandra-2.2', 'cassandra-3.0', 'cassandra-3.11',
'cassandra-4.0', 'trunk']
+def cassandraBranches = ['cassandra-2.2', 'cassandra-3.0', 'cassandra-3.11',
'cassandra-4.0', 'cassandra-4.0.0', 'trunk']
if(binding.hasVariable("CASSANDRA_BRANCHES")) {
cassandraBranches = "${CASSANDRA_BRANCHES}".split(",")
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Add 4.0.0 branch
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new aea3445 Add 4.0.0 branch
aea3445 is described below
commit aea34450e650527452940f81ee5ef06160310ee7
Author: Brandon Williams
AuthorDate: Thu Jun 3 11:46:39 2021 -0500
Add 4.0.0 branch
---
upgrade_tests/upgrade_manifest.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/upgrade_tests/upgrade_manifest.py
b/upgrade_tests/upgrade_manifest.py
index 7cf4910..ce57c40 100644
--- a/upgrade_tests/upgrade_manifest.py
+++ b/upgrade_tests/upgrade_manifest.py
@@ -26,6 +26,7 @@ CASSANDRA_2_2 = '2.2'
CASSANDRA_3_0 = '3.0'
CASSANDRA_3_11 = '3.11'
CASSANDRA_4_0 = '4.0'
+CASSANDRA_4_0_0 = '4.0.0'
CASSANDRA_4_1 = '4.1'
TRUNK = CASSANDRA_4_1
@@ -96,6 +97,8 @@ def set_version_family():
version_family = CASSANDRA_3_0
elif current_version.vstring.startswith('3.11'):
version_family = CASSANDRA_3_11
+elif current_version.vstring.startswith('4.0.0'):
+version_family = CASSANDRA_4_0_0
elif current_version.vstring.startswith('4.0'):
version_family = CASSANDRA_4_0
elif current_version.vstring.startswith('4.1'):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0.0 created (now 3875fd2)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. at 3875fd2 Mark MemtableSizeTest as flaky patch by Ekaterina Dimitrova, reviewed by Branimir Lambov for CASSANDRA-16684 No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356571#comment-17356571 ] Angelo Polo edited comment on CASSANDRA-16704 at 6/3/21, 4:43 PM: -- If the 'provided' scope is intentionally part of the test dependencies (and not just the 'test' scope), then does it make sense to remove the exclusion of 'provided' from [test jars resolution|https://github.com/apache/cassandra/blob/3282f5ecf187ecbb56b8d73ab9a9110c010898b0/.build/build-resolver.xml#L178]? Unless there's some other detail with the transitive dependencies, looks like this is what provided is for: "A dependency with this scope is added to the classpath used for compilation and test, but not the runtime classpath." (http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope). Then as a bonus, there's no need to duplicate dependencies across provided and test. For example: ./build.xml:733: ./build.xml:734: ./build.xml:735: ./build.xml:736: ./build.xml:830: ./build.xml:831: ./build.xml:832: ./build.xml:833: Though in terms of classpath, we're effectively back where we started since instead of joining the compile and provided scopes from build/lib/ with the test scope in build/test/lib/ we'd be joining the compile scope in lib/ with the test and provided scopes in build/test/lib/. So let me know if you me to remove the modification to build.xml from the patch. At a minimum, I think the two changes to src/ are required for runtime correctness. was (Author: polo-language): If the 'provided' scope is intentionally part of the test dependencies (and not just the 'test' scope), then does it make sense to remove the exclusion of 'provided' from [test jars resolution|https://github.com/apache/cassandra/blob/3282f5ecf187ecbb56b8d73ab9a9110c010898b0/.build/build-resolver.xml#L178]? Unless there's some other detail with the transitive dependencies, looks like this is what provided is for: "A dependency with this scope is added to the classpath used for compilation and test, but not the runtime classpath." ([http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope).] Then as a bonus, there's no need to duplicate dependencies across provided and test. For example: ./build.xml:733: ./build.xml:734: ./build.xml:735: ./build.xml:736: ./build.xml:830: ./build.xml:831: ./build.xml:832: ./build.xml:833: Though in terms of classpath, we're effectively back where we started since instead of joining the compile and provided scopes from build/lib/ with the test scope in build/test/lib/ we'd be joining the compile scope in lib/ with the test and provided scopes in build/test/lib/. So let me know if you me to remove the modification to build.xml from the patch. At a minimum, I think the two changes to src/ are required for runtime correctness. > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: test-with-runtime-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356571#comment-17356571 ] Angelo Polo commented on CASSANDRA-16704: - If the 'provided' scope is intentionally part of the test dependencies (and not just the 'test' scope), then does it make sense to remove the exclusion of 'provided' from [test jars resolution|https://github.com/apache/cassandra/blob/3282f5ecf187ecbb56b8d73ab9a9110c010898b0/.build/build-resolver.xml#L178]? Unless there's some other detail with the transitive dependencies, looks like this is what provided is for: "A dependency with this scope is added to the classpath used for compilation and test, but not the runtime classpath." ([http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope).] Then as a bonus, there's no need to duplicate dependencies across provided and test. For example: ./build.xml:733: ./build.xml:734: ./build.xml:735: ./build.xml:736: ./build.xml:830: ./build.xml:831: ./build.xml:832: ./build.xml:833: Though in terms of classpath, we're effectively back where we started since instead of joining the compile and provided scopes from build/lib/ with the test scope in build/test/lib/ we'd be joining the compile scope in lib/ with the test and provided scopes in build/test/lib/. So let me know if you me to remove the modification to build.xml from the patch. At a minimum, I think the two changes to src/ are required for runtime correctness. > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: test-with-runtime-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356558#comment-17356558 ] Brandon Williams edited comment on CASSANDRA-16709 at 6/3/21, 4:33 PM: --- >From CASSANDRA-16642, it looks likes after creating the branch we'll need to >cover steps 3, 5, and 6: * Add pipeline to ci-cassandra ** [https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L58|https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51] * Add dtest version and upgrade paths ** [https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py] ** [https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374] ** [https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L37|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L31] * Update how_to_commit documentation ** [https://github.com/apache/cassandra/blob/trunk/doc/source/development/how_to_commit.rst] was (Author: brandon.williams): >From CASSANDRA-16642, it looks likes after creating the branch we'll need to >cover steps 3, 5, and 6: * Add pipeline to ci-cassandra ** https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 * Add dtest version and upgrade paths ** https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py ** https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 ** https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L31 * Update how_to_commit documentation ** https://github.com/apache/cassandra/blob/trunk/doc/source/development/how_to_commit.rst > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356558#comment-17356558 ] Brandon Williams commented on CASSANDRA-16709: -- >From CASSANDRA-16642, it looks likes after creating the branch we'll need to >cover steps 3, 5, and 6: * Add pipeline to ci-cassandra ** https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51 * Add dtest version and upgrade paths ** https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py ** https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374 ** https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L31 * Update how_to_commit documentation ** https://github.com/apache/cassandra/blob/trunk/doc/source/development/how_to_commit.rst > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16684:
Since Version: 4.0-beta4
Source Control Link:
https://github.com/apache/cassandra/commit/3875fd26ea3c16e57bf08454d570e3359d2ce5fc
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (aef535c -> 3875fd2)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from aef535c Temporarily remove overlap check in tests add 3875fd2 Mark MemtableSizeTest as flaky patch by Ekaterina Dimitrova, reviewed by Branimir Lambov for CASSANDRA-16684 No new revisions were added by this update. Summary of changes: .../apache/cassandra/cql3/MemtableSizeTest.java| 133 +++-- 1 file changed, 73 insertions(+), 60 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (bedf6ca -> 4acfd3b)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from bedf6ca Merge branch 'cassandra-4.0' into trunk add 3875fd2 Mark MemtableSizeTest as flaky patch by Ekaterina Dimitrova, reviewed by Branimir Lambov for CASSANDRA-16684 new 4acfd3b Merge branch 'cassandra-4.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cassandra/cql3/MemtableSizeTest.java| 133 +++-- 1 file changed, 73 insertions(+), 60 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4acfd3bdf1acdb6b28059a49dd39823d7ea0689d Merge: bedf6ca 3875fd2 Author: Ekaterina Dimitrova AuthorDate: Thu Jun 3 12:16:27 2021 -0400 Merge branch 'cassandra-4.0' into trunk .../apache/cassandra/cql3/MemtableSizeTest.java| 133 +++-- 1 file changed, 73 insertions(+), 60 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356554#comment-17356554
]
Ekaterina Dimitrova commented on CASSANDRA-16684:
-
Thank you for the quick review!
Committed:
aef535cae1..3875fd26ea cassandra-4.0 -> cassandra-4.0
bedf6ca998..4acfd3bdf1 trunk -> trunk
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16709) Create 4.0.0 branch
[ https://issues.apache.org/jira/browse/CASSANDRA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16709: - Change Category: Semantic Complexity: Normal Component/s: Build Fix Version/s: 4.0-rc 4.0 Assignee: Brandon Williams Status: Open (was: Triage Needed) > Create 4.0.0 branch > --- > > Key: CASSANDRA-16709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0, 4.0-rc > > > This ticket is to track tasks that need to be completed for this branch, in > the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16709) Create 4.0.0 branch
Brandon Williams created CASSANDRA-16709: Summary: Create 4.0.0 branch Key: CASSANDRA-16709 URL: https://issues.apache.org/jira/browse/CASSANDRA-16709 Project: Cassandra Issue Type: Task Reporter: Brandon Williams This ticket is to track tasks that need to be completed for this branch, in the same vein as CASSANDRA-16642 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16686) Queries returning static content when the partition has no rows might fail to return some rows
[
https://issues.apache.org/jira/browse/CASSANDRA-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356548#comment-17356548
]
Benjamin Lerer commented on CASSANDRA-16686:
[~adelapena], [~jlewandowski] Thanks for the fast review. I incorporated your
suggestions updated the PR and re-run CI. The 3 failing test seems unrelated.
> Queries returning static content when the partition has no rows might fail to
> return some rows
> --
>
> Key: CASSANDRA-16686
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16686
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The problem can be reproduced with the following test:
> {code}
> @Test
> public void testStaticColumnDeletionWithMultipleStaticColumns() throws
> Throwable
> {
> createTable("CREATE TABLE %s (pk int, ck int, s1 int static, s2 int
> static, v int, PRIMARY KEY(pk, ck))");
> execute("INSERT INTO %s (pk, s1, s2) VALUES (1, 1, 1) USING TIMESTAMP
> 1000");
> flush();
> execute("INSERT INTO %s (pk, s1) VALUES (1, 2) USING TIMESTAMP 2000");
> flush();
> execute("DELETE s1 FROM %s USING TIMESTAMP 3000 WHERE pk = 1");
> flush();
> assertRows(execute("SELECT * FROM %s WHERE pk=1"), row(1, null, null,
> 1, null));
> assertRows(execute("SELECT s1, s2 FROM %s WHERE pk=1"), row((Integer)
> null, 1));
> assertRows(execute("SELECT s1 FROM %s WHERE pk=1"), row((Integer)
> null)); // <-FAIL
> }
> {code}
> This problem is a regression in 4.0 and trunk
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16686) Queries returning static content when the partition has no rows might fail to return some rows
[
https://issues.apache.org/jira/browse/CASSANDRA-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354943#comment-17354943
]
Benjamin Lerer edited comment on CASSANDRA-16686 at 6/3/21, 4:13 PM:
-
| [PR|https://github.com/apache/cassandra/pull/1031] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/129/workflows/519bc951-fac9-4950-87fc-7e3b0725414f]
|
[j11|https://app.circleci.com/pipelines/github/blerer/cassandra/129/workflows/906c3374-d8b5-4164-a42e-3981b801bbc3]
|
The patch fix the issue by adding all the static columns to the fetched columns
when the query is at the partition level (without clustering or regular column
restrictions). I took the opportunity to simplify the {{ColumnFilter}} logic
that was starting to become really confusing.
As 4.0-rc1 has been released we need to ensure backward compatibility with it
in a mixed cluster environment. To ensure that some extra changes were required
in {{ColumnFilter}} and in {{Gossiper}}.
was (Author: blerer):
| [PR|https://github.com/apache/cassandra/pull/1031] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/126/workflows/1921f1e1-f7e6-45e1-8e20-7ea231180bdb]
|
[j11|https://app.circleci.com/pipelines/github/blerer/cassandra/126/workflows/8f975dea-638d-476b-baee-780274fb60c3]
|
The patch fix the issue by adding all the static columns to the fetched columns
when the query is at the partition level (without clustering or regular column
restrictions). I took the opportunity to simplify the {{ColumnFilter}} logic
that was starting to become really confusing.
As 4.0-rc1 has been released we need to ensure backward compatibility with it
in a mixed cluster environment. To ensure that some extra changes were required
in {{ColumnFilter}} and in {{Gossiper}}.
> Queries returning static content when the partition has no rows might fail to
> return some rows
> --
>
> Key: CASSANDRA-16686
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16686
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The problem can be reproduced with the following test:
> {code}
> @Test
> public void testStaticColumnDeletionWithMultipleStaticColumns() throws
> Throwable
> {
> createTable("CREATE TABLE %s (pk int, ck int, s1 int static, s2 int
> static, v int, PRIMARY KEY(pk, ck))");
> execute("INSERT INTO %s (pk, s1, s2) VALUES (1, 1, 1) USING TIMESTAMP
> 1000");
> flush();
> execute("INSERT INTO %s (pk, s1) VALUES (1, 2) USING TIMESTAMP 2000");
> flush();
> execute("DELETE s1 FROM %s USING TIMESTAMP 3000 WHERE pk = 1");
> flush();
> assertRows(execute("SELECT * FROM %s WHERE pk=1"), row(1, null, null,
> 1, null));
> assertRows(execute("SELECT s1, s2 FROM %s WHERE pk=1"), row((Integer)
> null, 1));
> assertRows(execute("SELECT s1 FROM %s WHERE pk=1"), row((Integer)
> null)); // <-FAIL
> }
> {code}
> This problem is a regression in 4.0 and trunk
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16684:
Status: Ready to Commit (was: Review In Progress)
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site
[ https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16706: Status: In Progress (was: Changes Suggested) > Bring the latest in-tree docs updates to the web site > - > > Key: CASSANDRA-16706 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16706 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0-rc > > > Below two doc changes have to be published on the web site: > * > [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7] > * CASSANDRA-16682 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356526#comment-17356526
]
Branimir Lambov commented on CASSANDRA-16684:
-
New version LGTM.
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356498#comment-17356498
]
Ekaterina Dimitrova edited comment on CASSANDRA-16684 at 6/3/21, 3:39 PM:
--
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644a]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
[https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java|https://github.com/ekaterinadimitrova2/cassandra/commit/f635755025ebf27bf3868b40e033d04ae1133689]
was (Author: e.dimitrova):
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644a]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356498#comment-17356498
]
Ekaterina Dimitrova edited comment on CASSANDRA-16684 at 6/3/21, 3:39 PM:
--
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. -The suggestion is to mark
it as flaky which I have done-
[-here-|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644a]
[~blerer] -or- [~blambov]-, do you mind to review, please?-
[~blambov] already did a pass.
New version:
https://github.com/ekaterinadimitrova2/cassandra/blob/f635755025ebf27bf3868b40e033d04ae1133689/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java
was (Author: e.dimitrova):
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. The suggestion is to mark
it as flaky which I have done
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644a]
[~blerer] or [~blambov], do you mind to review, please?
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16684:
Reviewers: Branimir Lambov, Ekaterina Dimitrova
Status: Review In Progress (was: Patch Available)
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site
[ https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16706: Status: Changes Suggested (was: Review In Progress) > Bring the latest in-tree docs updates to the web site > - > > Key: CASSANDRA-16706 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16706 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0-rc > > > Below two doc changes have to be published on the web site: > * > [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7] > * CASSANDRA-16682 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-16684:
Test and Documentation Plan:
https://issues.apache.org/jira/browse/CASSANDRA-16684?focusedCommentId=17356498=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17356498
Status: Patch Available (was: In Progress)
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356498#comment-17356498
]
Ekaterina Dimitrova commented on CASSANDRA-16684:
-
I had an offline discussion and it seems this test can flake sometimes based on
the CI infrastructure and not due to product defect. The suggestion is to mark
it as flaky which I have done
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/dd0f55567ac3c26e90b1a1a13204195b89b1644a]
[~blerer] or [~blambov], do you mind to review, please?
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356475#comment-17356475
]
Stefan Miklosovic commented on CASSANDRA-16669:
---
Thanks [~sumanth.pasupuleti]
after initial scan, this looks way better. I will review closely again very
soon.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site
[ https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16706: Reviewers: Michael Semb Wever Status: Review In Progress (was: Patch Available) > Bring the latest in-tree docs updates to the web site > - > > Key: CASSANDRA-16706 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16706 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc2, 4.0-rc > > > Below two doc changes have to be published on the web site: > * > [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7] > * CASSANDRA-16682 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16695) cqlsh should prefer newer TLS version by default
[
https://issues.apache.org/jira/browse/CASSANDRA-16695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356470#comment-17356470
]
Ekaterina Dimitrova commented on CASSANDRA-16695:
-
The CI was looking good. Another person is working to add additional tests in
the background. Update is coming soon
> cqlsh should prefer newer TLS version by default
>
>
> Key: CASSANDRA-16695
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16695
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/cqlsh
>Reporter: Justin Chu
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 2.2.x, 3.0.x, 3.11.x, 4.0-rc, 4.x
>
>
> Some new JDK releases started to disable TLSv1.0 and TLSv1.1.
> [https://www.oracle.com/java/technologies/javase/8u291-relnotes.html]
>
> However, the code in:
> [https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/sslhandling.py#L56-L65]
> is defaulting to those rather old versions,
> which could lead to the following problem:
> {code:java}
> ('Unable to connect to any servers', {'10.101.34.89:9042': error(1, u"Tried
> connecting to [('10.101.34.89', 9042)]. Last error: [SSL:
> WRONG_VERSION_NUMBER] wrong version number (_ssl.c:618)")}) {code}
>
> Python2 default TLS protocol
> [https://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_TLS]
> Python3 default TLS protocol
> [https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14582) Add a system property to set the cassandra hostId if not yet initialized
[ https://issues.apache.org/jira/browse/CASSANDRA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356427#comment-17356427 ] Stefan Miklosovic commented on CASSANDRA-14582: --- I am building these branches of Abi's work: [https://github.com/smiklosovic/cassandra/commit/09a801fc5fdeb1a7cf52b950ee468c406f4062fa] [https://github.com/smiklosovic/cassandra-dtest/commit/0a3fd51e760ae4bc91231ae14e3420a03de1d8ee] build: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/840/ > Add a system property to set the cassandra hostId if not yet initialized > > > Key: CASSANDRA-14582 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14582 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: vincent royer >Assignee: Abuli Palagashvili >Priority: Low > Labels: lhf > Fix For: 4.1 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Add a system property *cassandra.host_id* to set the cassandra hostId if not > yet initialized. > This allow to push the cassandra host ID when provisioning new cassandra > nodes rather than to retreive it after the first start. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14582) Add a system property to set the cassandra hostId if not yet initialized
[ https://issues.apache.org/jira/browse/CASSANDRA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-14582: -- Fix Version/s: 4.1 > Add a system property to set the cassandra hostId if not yet initialized > > > Key: CASSANDRA-14582 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14582 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: vincent royer >Assignee: Abuli Palagashvili >Priority: Low > Labels: lhf > Fix For: 4.1 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Add a system property *cassandra.host_id* to set the cassandra hostId if not > yet initialized. > This allow to push the cassandra host ID when provisioning new cassandra > nodes rather than to retreive it after the first start. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16705: Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina Dimitrova) Ekaterina Dimitrova, Ekaterina Dimitrova Status: Review In Progress (was: Patch Available) > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356413#comment-17356413 ] Ekaterina Dimitrova commented on CASSANDRA-16705: - Technically already approved in CASSANDRA-16644, still LGTM :) > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16705: Status: Ready to Commit (was: Review In Progress) > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356373#comment-17356373
]
Michael Semb Wever commented on CASSANDRA-16704:
bq. My thinking is that such dependencies should then become explicit test
dependencies…
They are in places, see all those marked as "provided" or "optional"
[here|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/build.xml#L491-L657]
and
[here|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/build.xml#L749-L833].
Note, these do also include those dependencies needed solely for the sake of
compiling.
bq. …rather than allowing transitive dependencies (which may disappear or
change version when any other dependency is updated) to creep into the tests.
The {{lib/}} folder also contains transitive dependencies, just of the more
restricted scope.
> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356350#comment-17356350
]
Angelo Polo commented on CASSANDRA-16704:
-
{quote}Tests can run against those optional dependencies that we don't bundle.
I don't think that is currently the case for any tests, but it can be.
{quote}
My thinking is that such dependencies should then become explicit test
dependencies, rather than allowing transitive dependencies (which may disappear
or change version when any other dependency is updated) to creep into the
tests. Though I don't know what 'provided' means here so hopefully I haven't
misunderstood something.
{quote}I'm not quite understanding this statement, if build/lib/jars/ doesn't
exist then neither does lib/.
{quote}
Oops, this was supposed to be build/dist/lib/.
My patch doesn't touch the IDE classpaths. Should just be a matter of removing
this
[fileset|https://github.com/apache/cassandra/blob/3282f5ecf187ecbb56b8d73ab9a9110c010898b0/build.xml#L2005].
> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356333#comment-17356333
]
Michael Semb Wever edited comment on CASSANDRA-16704 at 6/3/21, 10:54 AM:
--
(To rehash, mostly for my own sake…)
The differences between {{build/lib/jars/}} and {{lib/}} are the following.
Only {{lib/}} contains:
- cassandra-driver-internal-only-3.25.0.zip
- futures-2.1.6-py2.py3-none-any.zip
- geomet-0.1.0.zip
- sigar-bin/
- six-1.12.0-py2.py3-none-any.zip
This is just the additional binary and python dependencies.
Only {{build/lib/jars/}} contains:
- antlr-3.5.2.jar
- assertj-core-3.15.0.jar
- byteman-4.0.6.jar
- byteman-bmunit-4.0.6.jar
- byteman-install-4.0.6.jar
- byteman-submit-4.0.6.jar
- commons-beanutils-1.7.0.jar
- commons-beanutils-core-1.8.0.jar
- commons-collections-3.2.1.jar
- commons-configuration-1.6.jar
- commons-digester-1.8.jar
- commons-el-1.0.jar
- commons-httpclient-3.0.1.jar
- commons-lang-2.4.jar
- commons-math-2.1.jar
- commons-net-1.4.1.jar
- compile-command-annotations-1.2.0.jar
- compress-lzf-0.8.4.jar
- ftplet-api-1.0.0.jar
- ftpserver-core-1.0.0.jar
- ftpserver-deprecated-1.0.0-M2.jar
- hadoop-core-1.0.3.jar
- hadoop-minicluster-1.0.3.jar
- hadoop-test-1.0.3.jar
- hsqldb-1.8.0.10.jar
- jackson-core-asl-1.0.1.jar
- jackson-mapper-asl-1.0.1.jar
- jacocoagent.jar
- jasper-compiler-5.5.12.jar
- jasper-runtime-5.5.12.jar
- jersey-core-1.0.jar
- jersey-server-1.0.jar
- jets3t-0.7.1.jar
- jetty-6.1.26.jar
- jetty-util-6.1.26.jar
- jsp-2.1-6.1.14.jar
- jsp-api-2.1-6.1.14.jar
- jsr305-2.0.2.jar
- jsr311-api-1.0.jar
- kfs-0.3.jar
- mina-core-2.0.0-M5.jar
- netty-bom-4.1.58.Final.pom
- oro-2.0.8.jar
- servlet-api-2.5-6.1.14.jar
- xmlenc-0.52.jar
This should be only the additional "provided" scope.
Maybe there are jar files here that should be removed, i.e. should not even be
part the provided scope?
bq. Tests are currently run with a classpath containing all downloaded jars.
To be accurate {{build/lib/jars/}} is intended to be the [compile+provided
scoped|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/.build/build-resolver.xml#L174]
dependency tree, while {{lib/}} is only the
[compile|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/.build/build-resolver.xml#L196]
scoped dependency tree.
bq. The tests would be more reflective of the behavior of a runtime environment
if the test classpath only contained jars that are bundled with the binary
release, together with explicit test dependencies.
Tests can run against those optional dependencies that we don't bundle. I don't
think that is currently the case for any tests, but it can be.
bq. Ideally we'd use the build/lib/ jars for the classpath since that's what
gets packaged, but since these aren't available at test compile time and should
be identical to lib/ anyway, I've used the later.
I'm not quite understanding this statement, if {{build/lib/jars/}} doesn't
exist then neither does {{lib/}}.
The {{lib/}} contents are put together later in the build cycle (under the
{{resolver-dist-lib}} target) than the {{build/lib/jars/}} contents (which are
done under the {{resolver-retrieve-build}} target). There is a valid question
here as to whether we want tests to now depend upon the {{resolver-dist-lib}}
target.
was (Author: michaelsembwever):
(To rehash, mostly for my own sake…)
The differences between {{build/lib/jars/}} and {{lib/}} are the following.
Only {{lib/}} contains:
- cassandra-driver-internal-only-3.25.0.zip
- futures-2.1.6-py2.py3-none-any.zip
- geomet-0.1.0.zip
- sigar-bin/
- six-1.12.0-py2.py3-none-any.zip
This is just the additional binary and python dependencies.
Only {{build/lib/jars/}} contains:
- antlr-3.5.2.jar
- assertj-core-3.15.0.jar
- byteman-4.0.6.jar
- byteman-bmunit-4.0.6.jar
- byteman-install-4.0.6.jar
- byteman-submit-4.0.6.jar
- commons-beanutils-1.7.0.jar
- commons-beanutils-core-1.8.0.jar
- commons-collections-3.2.1.jar
- commons-configuration-1.6.jar
- commons-digester-1.8.jar
- commons-el-1.0.jar
- commons-httpclient-3.0.1.jar
- commons-lang-2.4.jar
- commons-math-2.1.jar
- commons-net-1.4.1.jar
- compile-command-annotations-1.2.0.jar
- compress-lzf-0.8.4.jar
- ftplet-api-1.0.0.jar
- ftpserver-core-1.0.0.jar
- ftpserver-deprecated-1.0.0-M2.jar
- hadoop-core-1.0.3.jar
- hadoop-minicluster-1.0.3.jar
- hadoop-test-1.0.3.jar
- hsqldb-1.8.0.10.jar
- jackson-core-asl-1.0.1.jar
- jackson-mapper-asl-1.0.1.jar
- jacocoagent.jar
- jasper-compiler-5.5.12.jar
- jasper-runtime-5.5.12.jar
- jersey-core-1.0.jar
- jersey-server-1.0.jar
- jets3t-0.7.1.jar
- jetty-6.1.26.jar
- jetty-util-6.1.26.jar
- jsp-2.1-6.1.14.jar
- jsp-api-2.1-6.1.14.jar
- jsr305-2.0.2.jar
- jsr311-api-1.0.jar
- kfs-0.3.jar
- mina-core-2.0.0-M5.jar
- netty-bom-4.1.58.Final.pom
- oro-2.0.8.jar
- servlet-api-2.5-6.1.14.jar
- xmlenc-0.52.jar
This should be the
[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356333#comment-17356333
]
Michael Semb Wever commented on CASSANDRA-16704:
(To rehash, mostly for my own sake…)
The differences between {{build/lib/jars/}} and {{lib/}} are the following.
Only {{lib/}} contains:
- cassandra-driver-internal-only-3.25.0.zip
- futures-2.1.6-py2.py3-none-any.zip
- geomet-0.1.0.zip
- sigar-bin/
- six-1.12.0-py2.py3-none-any.zip
This is just the additional binary and python dependencies.
Only {{build/lib/jars/}} contains:
- antlr-3.5.2.jar
- assertj-core-3.15.0.jar
- byteman-4.0.6.jar
- byteman-bmunit-4.0.6.jar
- byteman-install-4.0.6.jar
- byteman-submit-4.0.6.jar
- commons-beanutils-1.7.0.jar
- commons-beanutils-core-1.8.0.jar
- commons-collections-3.2.1.jar
- commons-configuration-1.6.jar
- commons-digester-1.8.jar
- commons-el-1.0.jar
- commons-httpclient-3.0.1.jar
- commons-lang-2.4.jar
- commons-math-2.1.jar
- commons-net-1.4.1.jar
- compile-command-annotations-1.2.0.jar
- compress-lzf-0.8.4.jar
- ftplet-api-1.0.0.jar
- ftpserver-core-1.0.0.jar
- ftpserver-deprecated-1.0.0-M2.jar
- hadoop-core-1.0.3.jar
- hadoop-minicluster-1.0.3.jar
- hadoop-test-1.0.3.jar
- hsqldb-1.8.0.10.jar
- jackson-core-asl-1.0.1.jar
- jackson-mapper-asl-1.0.1.jar
- jacocoagent.jar
- jasper-compiler-5.5.12.jar
- jasper-runtime-5.5.12.jar
- jersey-core-1.0.jar
- jersey-server-1.0.jar
- jets3t-0.7.1.jar
- jetty-6.1.26.jar
- jetty-util-6.1.26.jar
- jsp-2.1-6.1.14.jar
- jsp-api-2.1-6.1.14.jar
- jsr305-2.0.2.jar
- jsr311-api-1.0.jar
- kfs-0.3.jar
- mina-core-2.0.0-M5.jar
- netty-bom-4.1.58.Final.pom
- oro-2.0.8.jar
- servlet-api-2.5-6.1.14.jar
- xmlenc-0.52.jar
This should be the difference between full build scope and just "compile" scope
(which excludes system, runtime, and provided scopes).
Maybe there are jar files here that should be removed, i.e. should not even be
part the provided scope?
bq. Tests are currently run with a classpath containing all downloaded jars.
To be accurate {{build/lib/jars/}} is intended to be the [compile+provided
scoped|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/.build/build-resolver.xml#L174]
dependency tree, while {{lib/}} is only the
[compile|https://github.com/apache/cassandra/blob/cassandra-4.0-rc1/.build/build-resolver.xml#L196]
scoped dependency tree.
bq. The tests would be more reflective of the behavior of a runtime environment
if the test classpath only contained jars that are bundled with the binary
release, together with explicit test dependencies.
Tests can run against those optional dependencies that we don't bundle. I don't
think that is currently the case for any tests, but it can be.
bq. Ideally we'd use the build/lib/ jars for the classpath since that's what
gets packaged, but since these aren't available at test compile time and should
be identical to lib/ anyway, I've used the later.
I'm not quite understanding this statement, if {{build/lib/jars/}} doesn't
exist then neither does {{lib/}}.
The {{lib/}} contents are put together later in the build cycle (under the
{{resolver-dist-lib}} target) than the {{build/lib/jars/}} contents (which are
done under the {{resolver-retrieve-build}} target). There is a valid question
here as to whether we want tests to now depend upon the {{resolver-dist-lib}}
target.
> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies
[ https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16704: --- Fix Version/s: 4.x > Fix imports; run tests with packaged dependencies > - > > Key: CASSANDRA-16704 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16704 > Project: Cassandra > Issue Type: Bug > Components: Build, Test/burn, Test/unit >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Normal > Fix For: 4.0.x, 4.x > > Attachments: test-with-runtime-deps.patch > > > Tests are currently run with a classpath containing _all_ downloaded jars. > The tests would be more reflective of the behavior of a runtime environment > if the test classpath only contained jars that are bundled with the binary > release, together with explicit test dependencies. Ideally we'd use the > build/lib/ jars for the classpath since that's what gets packaged, but since > these aren't available at test compile time and should be identical to lib/ > anyway, I've used the later. > Doing so exposed a couple of references in src/java to > "org.apache.commons.lang", which is not available at runtime (should be > "org.apache.commons.lang*3*"). > Attached patch modifies the test classpath, fixes various imports in both > test/ and src/ classes, and makes some simple substitutions in the tests such > as using AbstractMap.SimpleEntry in place of > org.apache.commons.collections.keyvalue.AbstractMapEntry. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356249#comment-17356249 ] Berenguer Blasi edited comment on CASSANDRA-16705 at 6/3/21, 7:34 AM: -- [CI|https://ci-cassandra.apache.org/job/Cassandra-devbranch/839/] unrelated failures. [~edimitrova] this sould be a quick review for you. After all the time and many CI changes I did run CI to be on the safe side. was (Author: bereng): [CI|https://ci-cassandra.apache.org/job/Cassandra-devbranch/839/] unrelated failures. [~edimitrova] this sould be a quick review for you > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16705: Test and Documentation Plan: https://issues.apache.org/jira/browse/CASSANDRA-16705?focusedCommentId=17356249=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17356249 Status: Patch Available (was: In Progress) > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-16705: Bug Category: Parent values: Correctness(12982) Complexity: Normal Discovered By: Unit Test Fix Version/s: 4.x 4.0 4.0-rc2 Severity: Normal Status: Open (was: Triage Needed) > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356249#comment-17356249 ] Berenguer Blasi edited comment on CASSANDRA-16705 at 6/3/21, 7:33 AM: -- [CI|https://ci-cassandra.apache.org/job/Cassandra-devbranch/839/] unrelated failures. [~edimitrova] this sould be a quick review for you was (Author: bereng): [CI|https://ci-cassandra.apache.org/job/Cassandra-devbranch/839/] unrelated failures > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.0, 4.x > > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16705) CCM extra logging
[ https://issues.apache.org/jira/browse/CASSANDRA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356249#comment-17356249 ] Berenguer Blasi commented on CASSANDRA-16705: - [CI|https://ci-cassandra.apache.org/job/Cassandra-devbranch/839/] unrelated failures > CCM extra logging > - > > Key: CASSANDRA-16705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16705 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > > During CASSANDRA-16644 it was detected extra logging in CCM would come by > very useful so we're adding it here -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356230#comment-17356230
]
Sumanth Pasupuleti edited comment on CASSANDRA-16669 at 6/3/21, 6:43 AM:
-
Thanks [~stefan.miklosovic] and [~vinaykumarcse] for the feedback.
I've incorporated following updates and the
[PR|https://github.com/apache/cassandra/pull/1028] reflects the changes.
1. I changed obfuscation logic to just replace the password with ** and
retain rest of the operation string.
2. Having thought about it again, I agree we may not need a toggle to turn off
password obfuscation for audit logging. I've now removed the configurable, and
we now always obfuscate password for DCL statements
3. Extracted obfuscation logic into its own (singleton) class that implements
an interface.
4. Added test cases specific to password obfuscation logic.
5. Audit logging documentation has been updated to reflect this change about
obfuscating passwords
With regards to "Why did you choose to obfuscate passwords in AuditLogging vs
QueryEvents? What is your stance on password being visible in FQL or other
subscribers of QueryEvents?",
1. Given that QueryEvents is a centralized common emitter of events to all
registered listeners, choosing to obfuscate password in QueryEvents would force
the obfuscation behavior to all the registered listeners vs leaving that
decision to individual listeners. This is the reason why I chose to keep this
obfuscation change localized to AuditLogging.
2. My stance on password visibility in FQL is that, given FQL is meant to
replay traffic to achieve identical results, I would vote for password staying
visible in FQL.
Please let me know if you have further feedback on the updated PR.
was (Author: sumanth.pasupuleti):
Thanks [~stefan.miklosovic] and [~vinaykumarcse] for the feedback.
I've incorporated following updates and the
[PR|https://github.com/apache/cassandra/pull/1028] reflects the changes.
1. I changed obfuscation logic to just replace the password with ** and
retain rest of the operation string.
2. Having thought about it again, I agree we may not need a toggle to turn off
password obfuscation for audit logging. I've now removed the configurable, and
we now always obfuscate password for DCL statements
3. Extracted obfuscation logic into its own (singleton) class that implements
an interface.
4. Added test cases specific to password obfuscation logic.
5. Audit logging documentation has been updated to reflect this change about
obfuscating passwords
With regards to "Why did you choose to obfuscate passwords in AuditLogging vs
QueryEvents? What is your stance on password being visible in FQL or other
subscribers of QueryEvents?",
1. Given that QueryEvents is a centralized common emitter of events to all
registered listeners, choosing to obfuscate password in QueryEvents would force
the obfuscation behavior to all the registered listeners vs leaving that
decision to individual listeners. This is the reason why I chose to keep this
obfuscation change localized to AuditLogging.
2. My stance on password visibility in FQL is that, given FQL is meant to
replay traffic to achieve identical results, I would vote for password staying
visible in FQL.
Please let me know if you have further feedback on the PR.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
>
[jira] [Comment Edited] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356230#comment-17356230
]
Sumanth Pasupuleti edited comment on CASSANDRA-16669 at 6/3/21, 6:43 AM:
-
Thanks [~stefan.miklosovic] and [~vinaykumarcse] for the feedback.
I've incorporated following updates and the
[PR|https://github.com/apache/cassandra/pull/1028] reflects the changes.
1. I changed obfuscation logic to just replace the password with ** and
retain rest of the operation string.
2. Having thought about it again, I agree we may not need a toggle to turn off
password obfuscation for audit logging. I've now removed the configurable, and
we now always obfuscate password for DCL statements
3. Extracted obfuscation logic into its own (singleton) class that implements
an interface.
4. Added test cases specific to password obfuscation logic.
5. Audit logging documentation has been updated to reflect this change about
obfuscating passwords
With regards to "Why did you choose to obfuscate passwords in AuditLogging vs
QueryEvents? What is your stance on password being visible in FQL or other
subscribers of QueryEvents?",
1. Given that QueryEvents is a centralized common emitter of events to all
registered listeners, choosing to obfuscate password in QueryEvents would force
the obfuscation behavior to all the registered listeners vs leaving that
decision to individual listeners. This is the reason why I chose to keep this
obfuscation change localized to AuditLogging.
2. My stance on password visibility in FQL is that, given FQL is meant to
replay traffic to achieve identical results, I would vote for password staying
visible in FQL.
Please let me know if you have further feedback on the PR.
was (Author: sumanth.pasupuleti):
Thanks [~stefan.miklosovic] and [~vinaykumarcse] for the feedback.
I've incorporated following updates and the
[PR|https://github.com/apache/cassandra/pull/1028] reflects the changes.
1. I changed obfuscation logic to just replace the password with ** and
retain rest of the operation string.
2. Having thought about it again, I agree we may not need a toggle to turn off
password obfuscation for audit logging. I've now removed the configurable, and
we now always obfuscate password for DCL statements
3. Extracted obfuscation logic into its own (singleton) class that implements
an interface.
4. Added test cases specific to password obfuscation logic.
5. Audit logging documentation has been updated to reflect this change about
obfuscating passwords
With regards to "Why did you choose to obfuscate passwords in AuditLogging vs
QueryEvents? What is your stance on password being visible in FQL or other
subscribers of QueryEvents?",
1. Given that QueryEvents is a centralized common emitter of events to all
registered listeners, choosing to obfuscate password in QueryEvents would force
the obfuscation behavior to all the registered listeners vs leaving that
decision to individual listeners. This is the reason why I chose to keep this
obfuscation change localized to AuditLogging.
2. My stance on password visibility in FQL is that, given FQL is meant to
replay traffic to achieve identical results, I would vote for password staying
visible in FQL.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
>
[jira] [Commented] (CASSANDRA-16669) Password obfuscation for DCL audit log statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356230#comment-17356230
]
Sumanth Pasupuleti commented on CASSANDRA-16669:
Thanks [~stefan.miklosovic] and [~vinaykumarcse] for the feedback.
I've incorporated following updates and the
[PR|https://github.com/apache/cassandra/pull/1028] reflects the changes.
1. I changed obfuscation logic to just replace the password with ** and
retain rest of the operation string.
2. Having thought about it again, I agree we may not need a toggle to turn off
password obfuscation for audit logging. I've now removed the configurable, and
we now always obfuscate password for DCL statements
3. Extracted obfuscation logic into its own (singleton) class that implements
an interface.
4. Added test cases specific to password obfuscation logic.
5. Audit logging documentation has been updated to reflect this change about
obfuscating passwords
With regards to "Why did you choose to obfuscate passwords in AuditLogging vs
QueryEvents? What is your stance on password being visible in FQL or other
subscribers of QueryEvents?",
1. Given that QueryEvents is a centralized common emitter of events to all
registered listeners, choosing to obfuscate password in QueryEvents would force
the obfuscation behavior to all the registered listeners vs leaving that
decision to individual listeners. This is the reason why I chose to keep this
obfuscation change localized to AuditLogging.
2. My stance on password visibility in FQL is that, given FQL is meant to
replay traffic to achieve identical results, I would vote for password staying
visible in FQL.
> Password obfuscation for DCL audit log statements
> -
>
> Key: CASSANDRA-16669
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16669
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/auditlogging
>Reporter: Vinay Chella
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Labels: audit, security
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The goal of this JIRA is to obfuscate passwords or any sensitive information
> from DCL audit log statements.
> Currently, (Cassandra version 4.0-rc1) logs query statements for any DCL
> ([ROLE|https://cassandra.apache.org/doc/latest/cql/security.html#database-roles]
> and [USER|https://cassandra.apache.org/doc/latest/cql/security.html#users] )
> queries with passwords in plaintext format in audit log files.
> The current workaround to avoid plain text passwords from being logged in
> audit log files is either by
> [excluding|https://cassandra.apache.org/doc/latest/operating/audit_logging.html#options]
> DCL statements from auditing or by excluding the user who is creating these
> roles from auditing.
> It would be ideal for Cassandra to provide an option or default to obfuscate
> passwords or any sensitive information from DCL audit log statements.
> Sample audit logs with DCL queries
> {code:sh}
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190499676|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE new_role;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190505313|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE alice WITH PASSWORD = 'password_a' AND LOGIN = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190519521|type:REQUEST_FAILURE|category:ERROR|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;; bob doesn't
> exist
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190525376|type:CREATE_ROLE|category:DCL|operation:CREATE
> ROLE bob WITH PASSWORD = 'password_b' AND LOGIN = true AND SUPERUSER = true;
> Type: audit
> LogMessage:
> user:cassandra|host:localhost/127.0.0.1:7000|source:/127.0.0.1|port:51908|timestamp:1620190532462|type:ALTER_ROLE|category:DCL|operation:ALTER
> ROLE bob WITH PASSWORD = 'PASSWORD_B' AND SUPERUSER = false;
> {code}
> It is also ideal to document this workaround or assumption in Cassandra audit
> log documentation until we close this JIRA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
