[jira] [Commented] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833797#comment-17833797
]
ASF subversion and git services commented on CASSANDRASC-116:
-
Commit 20795db4d708b9287e0a2281695923bfb6fa9138 in cassandra-sidecar's branch
refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=20795db4 ]
CASSANDRASC-116: Allow for JmxClient to be extensible
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-116
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-sidecar) branch trunk updated: CASSANDRASC-116: Allow for JmxClient to be extensible
This is an automated email from the ASF dual-hosted git repository.
frankgh pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git
The following commit(s) were added to refs/heads/trunk by this push:
new 20795db4 CASSANDRASC-116: Allow for JmxClient to be extensible
20795db4 is described below
commit 20795db4d708b9287e0a2281695923bfb6fa9138
Author: Francisco Guerrero
AuthorDate: Wed Apr 3 15:16:57 2024 -0700
CASSANDRASC-116: Allow for JmxClient to be extensible
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-116
---
CHANGES.txt| 1 +
.../apache/cassandra/sidecar/common/JmxClient.java | 8 ++--
.../cassandra/sidecar/common/JmxClientTest.java| 45 ++
3 files changed, 50 insertions(+), 4 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 3e79c80f..7a882552 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,5 +1,6 @@
1.0.0
-
+ * Allow for JmxClient to be extensible (CASSANDRASC-116)
* Improve observability in Sidecar (CASSANDRASC-111)
* Improve logging for slice restore task (CASSANDRASC-107)
* Add restore task watcher to report long running tasks (CASSANDRASC-106)
diff --git
a/common/src/main/java/org/apache/cassandra/sidecar/common/JmxClient.java
b/common/src/main/java/org/apache/cassandra/sidecar/common/JmxClient.java
index 44ab18cc..d9b03256 100644
--- a/common/src/main/java/org/apache/cassandra/sidecar/common/JmxClient.java
+++ b/common/src/main/java/org/apache/cassandra/sidecar/common/JmxClient.java
@@ -77,7 +77,7 @@ public class JmxClient implements NotificationListener,
Closeable
*
* @param builder the builder options
*/
-private JmxClient(Builder builder)
+protected JmxClient(Builder builder)
{
if (builder.jmxServiceURL != null)
{
@@ -151,7 +151,7 @@ public class JmxClient implements NotificationListener,
Closeable
: RMISocketFactory.getDefaultSocketFactory();
}
-private synchronized void checkConnection()
+protected synchronized void checkConnection()
{
if (!this.connected)
{
@@ -159,7 +159,7 @@ public class JmxClient implements NotificationListener,
Closeable
}
}
-private void connect()
+protected void connect()
{
int attempts = 1;
int maxAttempts = connectionMaxRetries;
@@ -204,7 +204,7 @@ public class JmxClient implements NotificationListener,
Closeable
throw new RuntimeException(error, lastThrown);
}
-private void connectInternal(int currentAttempt) throws IOException
+protected void connectInternal(int currentAttempt) throws IOException
{
jmxConnector = JMXConnectorFactory.connect(jmxServiceURL,
buildJmxEnv());
jmxConnector.addConnectionNotificationListener(this, null, null);
diff --git
a/common/src/test/java/org/apache/cassandra/sidecar/common/JmxClientTest.java
b/common/src/test/java/org/apache/cassandra/sidecar/common/JmxClientTest.java
index a3cfe86e..6c531907 100644
---
a/common/src/test/java/org/apache/cassandra/sidecar/common/JmxClientTest.java
+++
b/common/src/test/java/org/apache/cassandra/sidecar/common/JmxClientTest.java
@@ -336,6 +336,51 @@ class JmxClientTest
}
}
+@Test
+void testExtendingJmxClient() throws IOException
+{
+try (JmxClientExtended extended = new
JmxClientExtended(JmxClient.builder()
+
.host("127.0.0.1")
+
.port(port)
+
.roleSupplier(() -> "controlRole")
+
.passwordSupplier(() -> "password")))
+{
+assertThat(extended.proxyInterceptionCount.get()).isEqualTo(0);
+List result = extended.proxy(Import.class, objectName)
+
.importNewSSTables(Sets.newHashSet("foo", "bar"), true,
+ true, true, true,
true,
+ true);
+assertThat(result.size()).isEqualTo(0);
+assertThat(extended.proxyInterceptionCount.get()).isEqualTo(1);
+
+extended.proxy(Import.class, objectName)
+.importNewSSTables(Sets.newHashSet("foo", "bar"), true,
+ true, true, true, true,
+ true);
+assertThat(extended.proxyInterceptionCount.get()).isEqualTo(2);
+}
+}
+
+/**
+ * Extends from JmxClient and keeps tracks of the number of proxy calls
+ */
+static class JmxClientExtended extends JmxClient
+{
+AtomicInteger proxyInterceptionCount = new
[jira] [Updated] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-116:
---
Fix Version/s: 1.0
Source Control Link:
https://github.com/apache/cassandra-sidecar/commit/20795db4d708b9287e0a2281695923bfb6fa9138
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
> Fix For: 1.0
>
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-116:
---
Status: Ready to Commit (was: Review In Progress)
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-116:
---
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19448) CommitlogArchiver only has granularity to seconds for restore_point_in_time
[ https://issues.apache.org/jira/browse/CASSANDRA-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833784#comment-17833784 ] Tiago L. Alves commented on CASSANDRA-19448: Hi [~maxwellguo], I've seen your last update - looks great. I've made a few minor suggestions in the PR in case you are willing to consider them. Thank you - it was fun participating on this issue :) > CommitlogArchiver only has granularity to seconds for restore_point_in_time > --- > > Key: CASSANDRA-19448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19448 > Project: Cassandra > Issue Type: Bug > Components: Local/Commit Log >Reporter: Jeremy Hanna >Assignee: Maxwell Guo >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Commitlog archiver allows users to backup commitlog files for the purpose of > doing point in time restores. The [configuration > file|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties] > gives an example of down to the seconds granularity but then asks what > whether the timestamps are microseconds or milliseconds - defaulting to > microseconds. Because the [CommitLogArchiver uses a second based date > format|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogArchiver.java#L52], > if a user specifies to restore at something at a lower granularity like > milliseconds or microseconds, that means that the it will truncate everything > after the second and restore to that second. So say you specify a > restore_point_in_time like this: > restore_point_in_time=2024:01:18 17:01:01.623392 > it will silently truncate everything after the 01 seconds. So effectively to > the user, it is missing updates between 01 and 01.623392. > This appears to be a bug in the intent. We should allow users to specify > down to the millisecond or even microsecond level. If we allow them to > specify down to microseconds for the restore point in time, then it may > internally need to change from a long. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833782#comment-17833782
]
Brandon Williams commented on CASSANDRA-19508:
--
Looks good to me. We probably don't need CI for this but I already got caught
once, so:
||Branch||CI||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19508-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1563/workflows/3200ba88-f38d-41ad-99c2-65e6240fb9ee],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1563/workflows/99832cc7-a831-4074-aae5-2bd70783a408]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-19508-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1562/workflows/8029ecf4-e1a6-421f-8387-6c82b2ca58e0],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1562/workflows/ee01ef79-8541-4600-9764-1d43d8165d91]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19508-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1564/workflows/0ae12b67-291f-4da8-936b-0c4bdd5d5f45],
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1564/workflows/89ee38ea-6b17-42fa-92e6-51f472407088]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-19508-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1565/workflows/1979282a-89d0-44a5-a37f-7d237046eea0],
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1565/workflows/d9f97053-1541-4505-8ab3-2a0b50070ba3]|
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands,
[jira] [Commented] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833781#comment-17833781
]
Mohammad Aburadeh commented on CASSANDRA-19508:
---
||Branch||
|[4.0\|https://github.com/apache/cassandra/pull/3219/]|
|[4.1\|https://github.com/apache/cassandra/pull/3216/]|
|[5.0\|https://github.com/apache/cassandra/pull/3217/]|
|[trunk\|https://github.com/apache/cassandra/pull/3218/]|
[~brandon.williams] Would you please review the patch and let me know ?
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832929#comment-17832929
]
Mohammad Aburadeh edited comment on CASSANDRA-19508 at 4/3/24 11:50 PM:
I submitted PR for this issue. I tested it on our clusters, it worked well.
My fix is simple, it just disabled checking peer certificates if
require_client_auth is disabled. The other option is logging the msg in TRACE
not DEBUG.
||Branch||
|[4.0|https://github.com/apache/cassandra/pull/3219]|
|[4.1\|\|[https://github.com/apache/cassandra/pull/3216] ]|
|[5.0\|[https://github.com/apache/cassandra/pull/321|https://github.com/apache/cassandra/pull/3216]7]|
|[Trunk\|[https://github.com/apache/cassandra/pull/3218|https://github.com/apache/cassandra/pull/3216]]|
| |
Please review and let me know.
was (Author: JIRAUSER287854):
I submitted PR for this issue. I tested it on our clusters, it worked well.
My fix is simple, it just disabled checking peer certificates if
require_client_auth is disabled. The other option is logging the msg in TRACE
not DEBUG.
||Branch||
|[4.0|https://github.com/apache/cassandra/pull/3219]|
|[4.1\|\|[https://github.com/apache/cassandra/pull/3216] ]|
|[5.0\|[https://github.com/apache/cassandra/pull/3216]7 ]|
|[Trunk\|[https://github.com/apache/cassandra/pull/3218
|https://github.com/apache/cassandra/pull/3216]]|
| |
Please review and let me know.
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832929#comment-17832929
]
Mohammad Aburadeh edited comment on CASSANDRA-19508 at 4/3/24 11:50 PM:
I submitted PR for this issue. I tested it on our clusters, it worked well.
My fix is simple, it just disabled checking peer certificates if
require_client_auth is disabled. The other option is logging the msg in TRACE
not DEBUG.
||Branch||
|[4.0|https://github.com/apache/cassandra/pull/3219]|
|[4.1\|\|[https://github.com/apache/cassandra/pull/3216] ]|
|[5.0\|[https://github.com/apache/cassandra/pull/3216]7 ]|
|[Trunk\|[https://github.com/apache/cassandra/pull/3218
|https://github.com/apache/cassandra/pull/3216]]|
| |
Please review and let me know.
was (Author: JIRAUSER287854):
I submitted PR for this issue. I tested it on our clusters, it worked well.
My fix is simple, it just disabled checking peer certificates if
require_client_auth is disabled. The other option is logging the msg in TRACE
not DEBUG.
||Branch||
|[4.0|https://github.com/apache/cassandra/pull/3219]|
|[4.1\|\|[https://github.com/apache/cassandra/pull/3216]]|
|[5.0\|[https://github.com/apache/cassandra/pull/3216]7]|
|[Trunk\|[https://github.com/apache/cassandra/pull/3218|https://github.com/apache/cassandra/pull/3216]]|
| |
Please review and let me know.
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833776#comment-17833776
]
Mohammad Aburadeh commented on CASSANDRA-19508:
---
Thanks [~jonmeredith] .
I'll disable DEBUG logging for ServerConnection in the short term. I'll update
my PR to log the msg as TRACE instead of DEBUG.
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833771#comment-17833771
]
Jon Meredith commented on CASSANDRA-19508:
--
That's a lot of logs to deal with. Have you tried adding something like this to
your {{logback.xml}} file to improve things in the short term?
{code:xml}
{code}
I don't think we should merge the patch as it stands because it disables
retrieving the certificate if not required and it may be used by
{{IAuthenticator}} implementions. We could drop the log level to {{TRACE}} --
although logging per socket connection event at {{DEBUG}} level doesn't seem
unreasonable and it seems like other log events at that level could be added in
the future.
something like this instead? It should be a simpler patch and not involve the
config subsystem.
{code}
diff --git a/src/java/org/apache/cassandra/transport/ServerConnection.java
b/src/java/org/apache/cassandra/transport/ServerConnection.java
index 21f2e0b0e6..b47d0d9c66 100644
--- a/src/java/org/apache/cassandra/transport/ServerConnection.java
+++ b/src/java/org/apache/cassandra/transport/ServerConnection.java
@@ -137,7 +137,8 @@ public class ServerConnection extends Connection
}
catch (SSLPeerUnverifiedException e)
{
-logger.debug("Failed to get peer certificates for peer {}",
channel().remoteAddress(), e);
+if (logger.isTraceEnabled())
+logger.trace("Failed to get peer certificates for peer
{}", channel().remoteAddress(), e);
}
}
return certificates;
{code}
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833770#comment-17833770 ] Ekaterina Dimitrova commented on CASSANDRA-19428: - Tickets opened and linked here: !https://issues.apache.org/jira/secure/viewavatar?size=xsmall=21133=issuetype|width=16,height=16! CASSANDRA-19522 Test Failure: test_simple_decommission !https://issues.apache.org/jira/secure/viewavatar?size=xsmall=21133=issuetype|width=16,height=16! CASSANDRA-19523 Test Failure: testMixedVersionBlockDecom !https://issues.apache.org/jira/secure/viewavatar?size=xsmall=21133=issuetype|width=16,height=16! CASSANDRA-19524 Test Failure: testIncompleteState > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-beta2, 5.1-alpha, 5.1 > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19524) Test Failure: testIncompleteState
[
https://issues.apache.org/jira/browse/CASSANDRA-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19524:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: CI
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Test Failure: testIncompleteState
> -
>
> Key: CASSANDRA-19524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19524
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58956/tests#failed-test-0]
> {code:java}
> junit.framework.AssertionFailedError at
> org.apache.cassandra.gms.NewGossiperTest.testIncompleteState(NewGossiperTest.java:141)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19524) Test Failure: testIncompleteState
[
https://issues.apache.org/jira/browse/CASSANDRA-19524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19524:
Fix Version/s: 5.x
> Test Failure: testIncompleteState
> -
>
> Key: CASSANDRA-19524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19524
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58956/tests#failed-test-0]
> {code:java}
> junit.framework.AssertionFailedError at
> org.apache.cassandra.gms.NewGossiperTest.testIncompleteState(NewGossiperTest.java:141)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19524) Test Failure: testIncompleteState
Ekaterina Dimitrova created CASSANDRA-19524:
---
Summary: Test Failure: testIncompleteState
Key: CASSANDRA-19524
URL: https://issues.apache.org/jira/browse/CASSANDRA-19524
Project: Cassandra
Issue Type: Bug
Reporter: Ekaterina Dimitrova
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58956/tests#failed-test-0]
{code:java}
junit.framework.AssertionFailedError at
org.apache.cassandra.gms.NewGossiperTest.testIncompleteState(NewGossiperTest.java:141)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19523) Test Failure: testMixedVersionBlockDecom
[
https://issues.apache.org/jira/browse/CASSANDRA-19523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19523:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: CI
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Test Failure: testMixedVersionBlockDecom
>
>
> Key: CASSANDRA-19523
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19523
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58954/tests#failed-test-0]
> {code:java}
> java.lang.RuntimeException: java.util.concurrent.TimeoutException at
> org.apache.cassandra.utils.Throwables.maybeFail(Throwables.java:79) at
> org.apache.cassandra.utils.FBUtilities.waitOnFutures(FBUtilities.java:546) at
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1098)
> at
> org.apache.cassandra.distributed.test.ring.DecommissionTest.testMixedVersionBlockDecom(DecommissionTest.java:173)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.util.concurrent.TimeoutException at
> org.apache.cassandra.utils.concurrent.AbstractFuture.get(AbstractFuture.java:253)
> at
> org.apache.cassandra.utils.FBUtilities.waitOnFutures(FBUtilities.java:538){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19523) Test Failure: testMixedVersionBlockDecom
[
https://issues.apache.org/jira/browse/CASSANDRA-19523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19523:
Fix Version/s: 5.x
> Test Failure: testMixedVersionBlockDecom
>
>
> Key: CASSANDRA-19523
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19523
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58954/tests#failed-test-0]
> {code:java}
> java.lang.RuntimeException: java.util.concurrent.TimeoutException at
> org.apache.cassandra.utils.Throwables.maybeFail(Throwables.java:79) at
> org.apache.cassandra.utils.FBUtilities.waitOnFutures(FBUtilities.java:546) at
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1098)
> at
> org.apache.cassandra.distributed.test.ring.DecommissionTest.testMixedVersionBlockDecom(DecommissionTest.java:173)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: java.util.concurrent.TimeoutException at
> org.apache.cassandra.utils.concurrent.AbstractFuture.get(AbstractFuture.java:253)
> at
> org.apache.cassandra.utils.FBUtilities.waitOnFutures(FBUtilities.java:538){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19523) Test Failure: testMixedVersionBlockDecom
Ekaterina Dimitrova created CASSANDRA-19523:
---
Summary: Test Failure: testMixedVersionBlockDecom
Key: CASSANDRA-19523
URL: https://issues.apache.org/jira/browse/CASSANDRA-19523
Project: Cassandra
Issue Type: Bug
Reporter: Ekaterina Dimitrova
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58954/tests#failed-test-0]
{code:java}
java.lang.RuntimeException: java.util.concurrent.TimeoutException at
org.apache.cassandra.utils.Throwables.maybeFail(Throwables.java:79) at
org.apache.cassandra.utils.FBUtilities.waitOnFutures(FBUtilities.java:546) at
org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1098)
at
org.apache.cassandra.distributed.test.ring.DecommissionTest.testMixedVersionBlockDecom(DecommissionTest.java:173)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.util.concurrent.TimeoutException at
org.apache.cassandra.utils.concurrent.AbstractFuture.get(AbstractFuture.java:253)
at
org.apache.cassandra.utils.FBUtilities.waitOnFutures(FBUtilities.java:538){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19522) Test Failure: test_simple_decommission
[
https://issues.apache.org/jira/browse/CASSANDRA-19522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19522:
Fix Version/s: 5.x
> Test Failure: test_simple_decommission
> --
>
> Key: CASSANDRA-19522
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19522
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> Locally it fails for me:
> test_simple_decommission failed; it passed 0 out of the required 1 times.
>
> Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission']
> exited with non-zero status; exit status: 1;
> stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
> nodes to maintain replication factor after decommission.).
> See 'nodetool help' or 'nodetool help '.
> It failed in CircleCI in a different way once and I cannot reproduce it
> anymore in CircleCI. It passed many times there:
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58929/tests#failed-test-5]
> {code:java}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03
> 19:44:52,473 MessagingService.java:501 - Cannot send the message
> (from:/127.0.0.2:7000, type:GOSSIP verb:GOSSIP_DIGEST_SYN) to
> /127.0.0.1:7000, as messaging service is shutting down']" Unexpected error
> found in node logs (see stdout for full details). Errors: [[node2] 'ERROR
> [GossipTasks:1] 2024-04-03 19:44:52,473 MessagingService.java:501 - Cannot
> send the message (from:/127.0.0.2:7000, type:GOSSIP verb:GOSSIP_DIGEST_SYN)
> to /127.0.0.1:7000, as messaging service is shutting down']{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19522) Test Failure: test_simple_decommission
[
https://issues.apache.org/jira/browse/CASSANDRA-19522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19522:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: CI
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Test Failure: test_simple_decommission
> --
>
> Key: CASSANDRA-19522
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19522
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> Locally it fails for me:
> test_simple_decommission failed; it passed 0 out of the required 1 times.
>
> Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission']
> exited with non-zero status; exit status: 1;
> stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
> nodes to maintain replication factor after decommission.).
> See 'nodetool help' or 'nodetool help '.
> It failed in CircleCI in a different way once and I cannot reproduce it
> anymore in CircleCI. It passed many times there:
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58929/tests#failed-test-5]
> {code:java}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03
> 19:44:52,473 MessagingService.java:501 - Cannot send the message
> (from:/127.0.0.2:7000, type:GOSSIP verb:GOSSIP_DIGEST_SYN) to
> /127.0.0.1:7000, as messaging service is shutting down']" Unexpected error
> found in node logs (see stdout for full details). Errors: [[node2] 'ERROR
> [GossipTasks:1] 2024-04-03 19:44:52,473 MessagingService.java:501 - Cannot
> send the message (from:/127.0.0.2:7000, type:GOSSIP verb:GOSSIP_DIGEST_SYN)
> to /127.0.0.1:7000, as messaging service is shutting down']{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19522) Test Failure: test_simple_decommission
Ekaterina Dimitrova created CASSANDRA-19522:
---
Summary: Test Failure: test_simple_decommission
Key: CASSANDRA-19522
URL: https://issues.apache.org/jira/browse/CASSANDRA-19522
Project: Cassandra
Issue Type: Bug
Reporter: Ekaterina Dimitrova
Locally it fails for me:
test_simple_decommission failed; it passed 0 out of the required 1 times.
Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission']
exited with non-zero status; exit status: 1;
stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
nodes to maintain replication factor after decommission.).
See 'nodetool help' or 'nodetool help '.
It failed in CircleCI in a different way once and I cannot reproduce it anymore
in CircleCI. It passed many times there:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58929/tests#failed-test-5]
{code:java}
failed on teardown with "Unexpected error found in node logs (see stdout for
full details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03 19:44:52,473
MessagingService.java:501 - Cannot send the message (from:/127.0.0.2:7000,
type:GOSSIP verb:GOSSIP_DIGEST_SYN) to /127.0.0.1:7000, as messaging service is
shutting down']" Unexpected error found in node logs (see stdout for full
details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03 19:44:52,473
MessagingService.java:501 - Cannot send the message (from:/127.0.0.2:7000,
type:GOSSIP verb:GOSSIP_DIGEST_SYN) to /127.0.0.1:7000, as messaging service is
shutting down']{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19522) Test Failure: test_simple_decommission
[
https://issues.apache.org/jira/browse/CASSANDRA-19522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19522:
Description:
Locally it fails for me:
{code:java}
test_simple_decommission failed; it passed 0 out of the required 1 times.
Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission'] exited
with non-zero status; exit status: 1;
stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
nodes to maintain replication factor after decommission.).
See 'nodetool help' or 'nodetool help '.{code}
It failed in CircleCI in a different way once and I cannot reproduce it anymore
in CircleCI. It passed many times there:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58929/tests#failed-test-5]
{code:java}
failed on teardown with "Unexpected error found in node logs (see stdout for
full details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03 19:44:52,473
MessagingService.java:501 - Cannot send the message (from:/127.0.0.2:7000,
type:GOSSIP verb:GOSSIP_DIGEST_SYN) to /127.0.0.1:7000, as messaging service is
shutting down']" Unexpected error found in node logs (see stdout for full
details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03 19:44:52,473
MessagingService.java:501 - Cannot send the message (from:/127.0.0.2:7000,
type:GOSSIP verb:GOSSIP_DIGEST_SYN) to /127.0.0.1:7000, as messaging service is
shutting down']{code}
was:
Locally it fails for me:
test_simple_decommission failed; it passed 0 out of the required 1 times.
Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission']
exited with non-zero status; exit status: 1;
stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
nodes to maintain replication factor after decommission.).
See 'nodetool help' or 'nodetool help '.
It failed in CircleCI in a different way once and I cannot reproduce it anymore
in CircleCI. It passed many times there:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58929/tests#failed-test-5]
{code:java}
failed on teardown with "Unexpected error found in node logs (see stdout for
full details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03 19:44:52,473
MessagingService.java:501 - Cannot send the message (from:/127.0.0.2:7000,
type:GOSSIP verb:GOSSIP_DIGEST_SYN) to /127.0.0.1:7000, as messaging service is
shutting down']" Unexpected error found in node logs (see stdout for full
details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03 19:44:52,473
MessagingService.java:501 - Cannot send the message (from:/127.0.0.2:7000,
type:GOSSIP verb:GOSSIP_DIGEST_SYN) to /127.0.0.1:7000, as messaging service is
shutting down']{code}
> Test Failure: test_simple_decommission
> --
>
> Key: CASSANDRA-19522
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19522
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> Locally it fails for me:
> {code:java}
> test_simple_decommission failed; it passed 0 out of the required 1 times.
>
> Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission']
> exited with non-zero status; exit status: 1;
> stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
> nodes to maintain replication factor after decommission.).
> See 'nodetool help' or 'nodetool help '.{code}
> It failed in CircleCI in a different way once and I cannot reproduce it
> anymore in CircleCI. It passed many times there:
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2680/workflows/8b1c0d0a-7458-4b43-9bba-ac96b9bfe64f/jobs/58929/tests#failed-test-5]
> {code:java}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node2] 'ERROR [GossipTasks:1] 2024-04-03
> 19:44:52,473 MessagingService.java:501 - Cannot send the message
> (from:/127.0.0.2:7000, type:GOSSIP verb:GOSSIP_DIGEST_SYN) to
> /127.0.0.1:7000, as messaging service is shutting down']" Unexpected error
> found in node logs (see stdout for full details). Errors: [[node2] 'ERROR
> [GossipTasks:1] 2024-04-03 19:44:52,473 MessagingService.java:501 - Cannot
> send the message (from:/127.0.0.2:7000, type:GOSSIP verb:GOSSIP_DIGEST_SYN)
> to /127.0.0.1:7000, as messaging service is shutting down']{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-19428: Source Control Link: https://github.com/apache/cassandra/commit/b0150e86fbf5863fd831cfca8118f1a8bd254a43. https://github.com/apache/cassandra/commit/a1b0a310eded202d86d6fd0f746a5176ff8cabbe (was: https://github.com/apache/cassandra/commit/b0150e86fbf5863fd831cfca8118f1a8bd254a43) > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-beta2, 5.1-alpha, 5.1 > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-19428: Fix Version/s: 5.0-beta2 5.1-alpha 5.1 (was: 5.x) (was: 5.0-rc) > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-beta2, 5.1-alpha, 5.1 > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-19428: Source Control Link: https://github.com/apache/cassandra/commit/b0150e86fbf5863fd831cfca8118f1a8bd254a43 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[
https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833767#comment-17833767
]
Ekaterina Dimitrova commented on CASSANDRA-19428:
-
I cannot reproduce the failures with or without the patch. Those tests are
added to trunk with TCM, so I am not worried we could have broken them with
this SAI patch.
I will commit the current patch and open follow-up tickets for
test_simple_decommission, testMixedVersionBlockDecom, testIncompleteState.
Test_simple_decommission actually fails in a different way locally, both with
trunk and the current patch:
{code:java}
test_simple_decommission failed; it passed 0 out of the required 1 times.
Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission']
exited with non-zero status; exit status: 1;
stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live
nodes to maintain replication factor after decommission.).
See 'nodetool help' or 'nodetool help '.
{code}
Committed:
To https://github.com/apache/cassandra.git
973aad7b68..b0150e86fb cassandra-5.0 -> cassandra-5.0
2944d77aac..a1b0a310ed trunk -> trunk
> Clean up KeyRangeIterator classes
> -
>
> Key: CASSANDRA-19428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19428
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/2i Index
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Remove KeyRangeIterator.current and simplify
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated (973aad7b68 -> b0150e86fb)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 973aad7b68 Merge branch 'cassandra-4.1' into cassandra-5.0 add b0150e86fb Clean up KeyRangeIterator classes * replace KeyRangeConcatIterator's PriorityQeueu with List * remove KeyRangeIterator.current and simplify * remove injected exception and tests - not relevant to the current implementation * expand randomized testing * inline getCurrent() -> peek(); rename getCount to getMaxKeys * redefine skipTo contract to not return a value (which saves unnecessary work when skipTo is called multiple times in a row) * calling hasNext in skipTo is a [...] No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../index/sai/disk/IndexSearchResultIterator.java | 39 ++ .../disk/v1/postings/PostingListRangeIterator.java | 2 +- .../sai/iterators/KeyRangeConcatIterator.java | 105 -- .../iterators/KeyRangeIntersectionIterator.java| 132 -- .../index/sai/iterators/KeyRangeIterator.java | 99 -- .../sai/iterators/KeyRangeOrderingIterator.java| 2 +- .../index/sai/iterators/KeyRangeUnionIterator.java | 84 +++- .../index/sai/memory/InMemoryKeyRangeIterator.java | 4 +- .../cassandra/index/sai/plan/QueryController.java | 33 +++-- .../cassandra/utils/AbstractGuavaIterator.java | 5 +- .../index/sai/disk/SingleNodeQueryFailureTest.java | 100 ++ .../sai/disk/v1/BalancedTreeIndexSearcherTest.java | 2 - .../sai/disk/v1/InvertedIndexSearcherTest.java | 2 - .../iterators/AbstractKeyRangeIteratorTester.java | 119 .../sai/iterators/KeyRangeConcatIteratorTest.java | 83 +-- .../KeyRangeIntersectionIteratorTest.java | 127 ++--- .../sai/iterators/KeyRangeUnionIteratorTest.java | 151 - .../index/sai/iterators/LongIterator.java | 21 +-- .../index/sai/utils/SAIRandomizedTester.java | 10 ++ 20 files changed, 600 insertions(+), 521 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a1b0a310eded202d86d6fd0f746a5176ff8cabbe Merge: 2944d77aac b0150e86fb Author: Ekaterina Dimitrova AuthorDate: Wed Apr 3 18:29:55 2024 -0400 Merge branch 'cassandra-5.0' into trunk CHANGES.txt| 1 + .../index/sai/disk/IndexSearchResultIterator.java | 39 ++ .../disk/v1/postings/PostingListRangeIterator.java | 2 +- .../sai/iterators/KeyRangeConcatIterator.java | 105 -- .../iterators/KeyRangeIntersectionIterator.java| 132 -- .../index/sai/iterators/KeyRangeIterator.java | 99 -- .../sai/iterators/KeyRangeOrderingIterator.java| 2 +- .../index/sai/iterators/KeyRangeUnionIterator.java | 84 +++- .../index/sai/memory/InMemoryKeyRangeIterator.java | 4 +- .../cassandra/index/sai/plan/QueryController.java | 33 +++-- .../cassandra/utils/AbstractGuavaIterator.java | 5 +- .../index/sai/disk/SingleNodeQueryFailureTest.java | 100 ++ .../sai/disk/v1/BalancedTreeIndexSearcherTest.java | 2 - .../sai/disk/v1/InvertedIndexSearcherTest.java | 2 - .../iterators/AbstractKeyRangeIteratorTester.java | 119 .../sai/iterators/KeyRangeConcatIteratorTest.java | 83 +-- .../KeyRangeIntersectionIteratorTest.java | 127 ++--- .../sai/iterators/KeyRangeUnionIteratorTest.java | 151 - .../index/sai/iterators/LongIterator.java | 21 +-- .../index/sai/utils/SAIRandomizedTester.java | 10 ++ 20 files changed, 600 insertions(+), 521 deletions(-) diff --cc CHANGES.txt index c8ce4d9fae,6d6b3ea50c..c770ef1b7c --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,33 -1,5 +1,34 @@@ -5.0-beta2 +5.1 + * Expose all dropwizard metrics in virtual tables (CASSANDRA-14572) + * Ensured that PropertyFileSnitchTest do not overwrite cassandra-toploogy.properties (CASSANDRA-19502) + * Add option for MutualTlsAuthenticator to restrict the certificate validity period (CASSANDRA-18951) + * Fix StorageService::constructRangeToEndpointMap for non-distributed keyspaces (CASSANDRA-19255) + * Group nodetool cms commands into single command group (CASSANDRA-19393) + * Register the measurements of the bootstrap process as Dropwizard metrics (CASSANDRA-19447) + * Add LIST SUPERUSERS CQL statement (CASSANDRA-19417) + * Modernize CQLSH datetime conversions (CASSANDRA-18879) + * Harry model and in-JVM tests for partition-restricted 2i queries (CASSANDRA-18275) + * Refactor cqlshmain global constants (CASSANDRA-19201) + * Remove native_transport_port_ssl (CASSANDRA-19397) + * Make nodetool reconfigurecms sync by default and add --cancel to be able to cancel ongoing reconfigurations (CASSANDRA-19216) + * Expose auth mode in system_views.clients, nodetool clientstats, metrics (CASSANDRA-19366) + * Remove sealed_periods and last_sealed_period tables (CASSANDRA-19189) + * Improve setup and initialisation of LocalLog/LogSpec (CASSANDRA-19271) + * Refactor structure of caching metrics and expose auth cache metrics via JMX (CASSANDRA-17062) + * Allow CQL client certificate authentication to work without sending an AUTHENTICATE request (CASSANDRA-18857) + * Extend nodetool tpstats and system_views.thread_pools with detailed pool parameters (CASSANDRA-19289) + * Remove dependency on Sigar in favor of OSHI (CASSANDRA-16565) + * Simplify the bind marker and Term logic (CASSANDRA-18813) + * Limit cassandra startup to supported JDKs, allow higher JDKs by setting CASSANDRA_JDK_UNSUPPORTED (CASSANDRA-18688) + * Standardize nodetool tablestats formatting of data units (CASSANDRA-19104) + * Make nodetool tablestats use number of significant digits for time and average values consistently (CASSANDRA-19015) + * Upgrade jackson to 2.15.3 and snakeyaml to 2.1 (CASSANDRA-18875) + * Transactional Cluster Metadata [CEP-21] (CASSANDRA-18330) + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Clean up KeyRangeIterator classes (CASSANDRA-19428) * Warn clients about possible consistency violations for filtering queries against multiple mutable columns (CASSANDRA-19489) * Align buffer with commitlog segment size (CASSANDRA-19471) * Ensure SAI indexes empty byte buffers for types that allow them as a valid input (CASSANDRA-19461) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated (2944d77aac -> a1b0a310ed)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 2944d77aac Merge branch 'cassandra-5.0' into trunk add b0150e86fb Clean up KeyRangeIterator classes * replace KeyRangeConcatIterator's PriorityQeueu with List * remove KeyRangeIterator.current and simplify * remove injected exception and tests - not relevant to the current implementation * expand randomized testing * inline getCurrent() -> peek(); rename getCount to getMaxKeys * redefine skipTo contract to not return a value (which saves unnecessary work when skipTo is called multiple times in a row) * calling hasNext in skipTo is a [...] new a1b0a310ed Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../index/sai/disk/IndexSearchResultIterator.java | 39 ++ .../disk/v1/postings/PostingListRangeIterator.java | 2 +- .../sai/iterators/KeyRangeConcatIterator.java | 105 -- .../iterators/KeyRangeIntersectionIterator.java| 132 -- .../index/sai/iterators/KeyRangeIterator.java | 99 -- .../sai/iterators/KeyRangeOrderingIterator.java| 2 +- .../index/sai/iterators/KeyRangeUnionIterator.java | 84 +++- .../index/sai/memory/InMemoryKeyRangeIterator.java | 4 +- .../cassandra/index/sai/plan/QueryController.java | 33 +++-- .../cassandra/utils/AbstractGuavaIterator.java | 5 +- .../index/sai/disk/SingleNodeQueryFailureTest.java | 100 ++ .../sai/disk/v1/BalancedTreeIndexSearcherTest.java | 2 - .../sai/disk/v1/InvertedIndexSearcherTest.java | 2 - .../iterators/AbstractKeyRangeIteratorTester.java | 119 .../sai/iterators/KeyRangeConcatIteratorTest.java | 83 +-- .../KeyRangeIntersectionIteratorTest.java | 127 ++--- .../sai/iterators/KeyRangeUnionIteratorTest.java | 151 - .../index/sai/iterators/LongIterator.java | 21 +-- .../index/sai/utils/SAIRandomizedTester.java | 10 ++ 20 files changed, 600 insertions(+), 521 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19110) apt-key deprecation, replace with gpg --dearmor in the docs.
[
https://issues.apache.org/jira/browse/CASSANDRA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19110:
-
Fix Version/s: 3.0.30
3.11.17
4.0.13
4.1.5
5.0-beta2
(was: 3.0.x)
(was: 3.11.x)
(was: 5.x)
(was: 4.0.x)
(was: 4.1.x)
(was: 5.0.x)
Source Control Link:
https://github.com/apache/cassandra-website/commit/443c2f3568e047fc33f363b7a719b2c151388995
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> apt-key deprecation, replace with gpg --dearmor in the docs.
>
>
> Key: CASSANDRA-19110
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19110
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Simon K
>Assignee: Tibor Repasi
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.30, 3.11.17, 4.0.13, 4.1.5, 5.0-beta2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the command `apt-key` is deprecated and soon to be removed, especially on
> Ubuntu.
> the directory `/usr/share/keyrings` for shared keys are also being removed.
> I suggest to convert the docs from
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - {code}
> to a simpler command:
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo gpg --dearmor -o
> /etc/apt/keyrings/cassandra-archive-keyring.gpg {code}
> The path `/etc/apt/keyrings` doesn't exists by default on Ubuntu 20.04 but it
> does on 22.04.
> I also suggest to add the source.list.d text from
> {code:java}
> $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb https://debian.cassandra.apache.org 42x main{code}
> to
> {code:java}
> $ echo "deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main {code}
> I have made a [PR|https://github.com/apache/cassandra/pull/2936]
> I have tested the gpg --dearmor on a VM with Ubuntu 22.04 myself recently and
> it works just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19110) apt-key deprecation, replace with gpg --dearmor in the docs.
[
https://issues.apache.org/jira/browse/CASSANDRA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19110:
-
Status: Needs Committer (was: Patch Available)
> apt-key deprecation, replace with gpg --dearmor in the docs.
>
>
> Key: CASSANDRA-19110
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19110
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Simon K
>Assignee: Tibor Repasi
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the command `apt-key` is deprecated and soon to be removed, especially on
> Ubuntu.
> the directory `/usr/share/keyrings` for shared keys are also being removed.
> I suggest to convert the docs from
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - {code}
> to a simpler command:
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo gpg --dearmor -o
> /etc/apt/keyrings/cassandra-archive-keyring.gpg {code}
> The path `/etc/apt/keyrings` doesn't exists by default on Ubuntu 20.04 but it
> does on 22.04.
> I also suggest to add the source.list.d text from
> {code:java}
> $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb https://debian.cassandra.apache.org 42x main{code}
> to
> {code:java}
> $ echo "deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main {code}
> I have made a [PR|https://github.com/apache/cassandra/pull/2936]
> I have tested the gpg --dearmor on a VM with Ubuntu 22.04 myself recently and
> it works just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19110) apt-key deprecation, replace with gpg --dearmor in the docs.
[
https://issues.apache.org/jira/browse/CASSANDRA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19110:
-
Status: Ready to Commit (was: Review In Progress)
> apt-key deprecation, replace with gpg --dearmor in the docs.
>
>
> Key: CASSANDRA-19110
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19110
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Simon K
>Assignee: Tibor Repasi
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the command `apt-key` is deprecated and soon to be removed, especially on
> Ubuntu.
> the directory `/usr/share/keyrings` for shared keys are also being removed.
> I suggest to convert the docs from
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - {code}
> to a simpler command:
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo gpg --dearmor -o
> /etc/apt/keyrings/cassandra-archive-keyring.gpg {code}
> The path `/etc/apt/keyrings` doesn't exists by default on Ubuntu 20.04 but it
> does on 22.04.
> I also suggest to add the source.list.d text from
> {code:java}
> $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb https://debian.cassandra.apache.org 42x main{code}
> to
> {code:java}
> $ echo "deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main {code}
> I have made a [PR|https://github.com/apache/cassandra/pull/2936]
> I have tested the gpg --dearmor on a VM with Ubuntu 22.04 myself recently and
> it works just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19110) apt-key deprecation, replace with gpg --dearmor in the docs.
[
https://issues.apache.org/jira/browse/CASSANDRA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19110:
-
Status: Review In Progress (was: Needs Committer)
> apt-key deprecation, replace with gpg --dearmor in the docs.
>
>
> Key: CASSANDRA-19110
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19110
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Simon K
>Assignee: Tibor Repasi
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the command `apt-key` is deprecated and soon to be removed, especially on
> Ubuntu.
> the directory `/usr/share/keyrings` for shared keys are also being removed.
> I suggest to convert the docs from
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - {code}
> to a simpler command:
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo gpg --dearmor -o
> /etc/apt/keyrings/cassandra-archive-keyring.gpg {code}
> The path `/etc/apt/keyrings` doesn't exists by default on Ubuntu 20.04 but it
> does on 22.04.
> I also suggest to add the source.list.d text from
> {code:java}
> $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb https://debian.cassandra.apache.org 42x main{code}
> to
> {code:java}
> $ echo "deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main {code}
> I have made a [PR|https://github.com/apache/cassandra/pull/2936]
> I have tested the gpg --dearmor on a VM with Ubuntu 22.04 myself recently and
> it works just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-19110) apt-key deprecation, replace with gpg --dearmor in the docs.
[
https://issues.apache.org/jira/browse/CASSANDRA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-19110:
Authors: (was: Simon K)
Reviewers: Brandon Williams
Assignee: Tibor Repasi (was: Simon K)
> apt-key deprecation, replace with gpg --dearmor in the docs.
>
>
> Key: CASSANDRA-19110
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19110
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Simon K
>Assignee: Tibor Repasi
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the command `apt-key` is deprecated and soon to be removed, especially on
> Ubuntu.
> the directory `/usr/share/keyrings` for shared keys are also being removed.
> I suggest to convert the docs from
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - {code}
> to a simpler command:
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo gpg --dearmor -o
> /etc/apt/keyrings/cassandra-archive-keyring.gpg {code}
> The path `/etc/apt/keyrings` doesn't exists by default on Ubuntu 20.04 but it
> does on 22.04.
> I also suggest to add the source.list.d text from
> {code:java}
> $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb https://debian.cassandra.apache.org 42x main{code}
> to
> {code:java}
> $ echo "deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main {code}
> I have made a [PR|https://github.com/apache/cassandra/pull/2936]
> I have tested the gpg --dearmor on a VM with Ubuntu 22.04 myself recently and
> it works just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19110) apt-key deprecation, replace with gpg --dearmor in the docs.
[
https://issues.apache.org/jira/browse/CASSANDRA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833765#comment-17833765
]
Brandon Williams commented on CASSANDRA-19110:
--
The
[original|https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/examples/BASH/get_deb_package.sh#L1]
contained 4.2, no worries.
I committed the website changes and other doc changes for each branch and
redeployed the site so everything should be live now. Thanks all!
> apt-key deprecation, replace with gpg --dearmor in the docs.
>
>
> Key: CASSANDRA-19110
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19110
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Simon K
>Assignee: Simon K
>Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the command `apt-key` is deprecated and soon to be removed, especially on
> Ubuntu.
> the directory `/usr/share/keyrings` for shared keys are also being removed.
> I suggest to convert the docs from
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - {code}
> to a simpler command:
> {code:java}
> curl https://downloads.apache.org/cassandra/KEYS | sudo gpg --dearmor -o
> /etc/apt/keyrings/cassandra-archive-keyring.gpg {code}
> The path `/etc/apt/keyrings` doesn't exists by default on Ubuntu 20.04 but it
> does on 22.04.
> I also suggest to add the source.list.d text from
> {code:java}
> $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb https://debian.cassandra.apache.org 42x main{code}
> to
> {code:java}
> $ echo "deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main" | sudo tee -a
> /etc/apt/sources.list.d/cassandra.sources.list
> deb [signed-by=/etc/apt/keyrings/cassandra-archive-keyring.gpg]
> https://debian.cassandra.apache.org 42x main {code}
> I have made a [PR|https://github.com/apache/cassandra/pull/2936]
> I have tested the gpg --dearmor on a VM with Ubuntu 22.04 myself recently and
> it works just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-site updated (882f7cb19 -> e4640794e)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 882f7cb19 generate docs for fd550e9c add 85c413711 Update keyserver used on downloads page from pool.sks-keyservers.net to keyserver.ubuntu.com add 443c2f356 deprecate the usage of apt-key add e4640794e generate docs for 443c2f35 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (882f7cb19) \ N -- N -- N refs/heads/asf-site (e4640794e) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: content/_/download.html| 31 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../3.11/cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 62 +- .../4.0/cassandra/getting_started/installing.html | 62 +- .../cassandra/getting_started/installing.html | 56 +- .../cassandra/getting_started/installing.html | 56 +- .../cassandra/getting_started/installing.html | 56 +- .../cassandra/getting_started/installing.html | 56 +- .../4.1/cassandra/getting_started/installing.html | 56 +- .../doc/5.0/cassandra/installing/installing.html | 32 +- .../managing/configuration/cass_yaml_file.html | 51 +- .../managing/tools/nodetool/statusgossip.html |3 +- .../doc/5.1/cassandra/developing/cql/security.html | 16 + .../doc/5.1/cassandra/installing/installing.html | 32 +- .../managing/configuration/cass_yaml_file.html | 71 +- .../5.1/cassandra/managing/operating/metrics.html | 27 +- .../managing/operating/virtualtables.html | 65 +- .../cassandra/managing/tools/nodetool/cms.html}| 62 +- .../managing/tools/nodetool/describecms.html | 1112 --- .../cassandra/managing/tools/nodetool/import.html |6 +- .../managing/tools/nodetool/nodetool.html | 12 +- .../managing/tools/nodetool/reconfigurecms.html| 1132 .../reference/cql-commands/commands-toc.html |4 + .../latest/cassandra/installing/installing.html| 32 +- .../managing/configuration/cass_yaml_file.html | 51 +- .../managing/tools/nodetool/statusgossip.html |3 +- .../cassandra/getting_started/installing.html | 56 +- .../trunk/cassandra/developing/cql/security.html | 16 + .../doc/trunk/cassandra/installing/installing.html | 32 +- .../managing/configuration/cass_yaml_file.html | 71 +- .../cassandra/managing/operating/metrics.html | 27 +- .../managing/operating/virtualtables.html | 65 +- .../cassandra/managing/tools/nodetool/cms.html}| 62 +- .../managing/tools/nodetool/describecms.html | 1112 --- .../cassandra/managing/tools/nodetool/import.html |6 +- .../managing/tools/nodetool/nodetool.html | 12 +- .../managing/tools/nodetool/reconfigurecms.html| 1132 .../reference/cql-commands/commands-toc.html |4 + content/search-index.js|2 +- .../source/modules/ROOT/pages/download.adoc| 23 +- site-ui/build/ui-bundle.zip| Bin 4883646 -> 4883646 bytes 58 files changed, 1875 insertions(+), 5007 deletions(-) rename
[jira] [Updated] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRASC-116:
---
Labels: pull-request-available (was: )
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-staging updated (d73486f66 -> e4640794e)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d73486f66 generate docs for 443c2f35 new e4640794e generate docs for 443c2f35 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d73486f66) \ N -- N -- N refs/heads/asf-staging (e4640794e) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../3.11/cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 62 + .../4.0/cassandra/getting_started/installing.html | 62 + .../cassandra/getting_started/installing.html | 56 +++ .../cassandra/getting_started/installing.html | 56 +++ .../cassandra/getting_started/installing.html | 56 +++ .../cassandra/getting_started/installing.html | 56 +++ .../4.1/cassandra/getting_started/installing.html | 56 +++ .../doc/5.0/cassandra/installing/installing.html | 32 +-- .../doc/5.1/cassandra/installing/installing.html | 32 +-- .../latest/cassandra/installing/installing.html| 32 +-- .../cassandra/getting_started/installing.html | 56 +++ .../doc/trunk/cassandra/installing/installing.html | 32 +-- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4883646 -> 4883646 bytes 32 files changed, 1317 insertions(+), 389 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-116:
---
Authors: Francisco Guerrero
Test and Documentation Plan: Added unit tests for the change
Status: Patch Available (was: In Progress)
PR: https://github.pie.apple.com/aci-cassandra/cassandra-sidecar/pull/89
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-116) Allow for JmxClient to be extensible
Francisco Guerrero created CASSANDRASC-116:
--
Summary: Allow for JmxClient to be extensible
Key: CASSANDRASC-116
URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
Project: Sidecar for Apache Cassandra
Issue Type: Improvement
Reporter: Francisco Guerrero
Assignee: Francisco Guerrero
We need to allow {{JmxClient}} to be extensible for better testing flexibility.
Currently, the {{JmxClient}} constructor is private and does not allow
extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-116) Allow for JmxClient to be extensible
[
https://issues.apache.org/jira/browse/CASSANDRASC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-116:
---
Change Category: Semantic
Complexity: Low Hanging Fruit
Component/s: Configuration
Status: Open (was: Triage Needed)
> Allow for JmxClient to be extensible
>
>
> Key: CASSANDRASC-116
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-116
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> We need to allow {{JmxClient}} to be extensible for better testing
> flexibility. Currently, the {{JmxClient}} constructor is private and does not
> allow extending it and providing any flexibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated (be507c6e99 -> 973aad7b68)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from be507c6e99 Warn clients about possible consistency violations for filtering queries against multiple mutable columns new 338e4ed618 Docs: deprecate the usage of apt-key and adopt distribution name new f0aa6744d2 Merge branch 'cassandra-3.11' into cassandra-4.0 new 7cbf59e9a1 Merge branch 'cassandra-4.0' into cassandra-4.1 new 973aad7b68 Merge branch 'cassandra-4.1' into cassandra-5.0 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +- doc/modules/cassandra/examples/BASH/get_deb_package.sh | 4 ++-- doc/modules/cassandra/partials/package_versions.adoc | 11 +-- 3 files changed, 8 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-3.11 updated: Docs: deprecate the usage of apt-key and adopt distribution name
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.11 by this push:
new 338e4ed618 Docs: deprecate the usage of apt-key and adopt distribution
name
338e4ed618 is described below
commit 338e4ed61845e4f47dac7625db73a89ddfc7da21
Author: Tibor Répási
AuthorDate: Tue Apr 2 20:44:40 2024 +0200
Docs: deprecate the usage of apt-key and adopt distribution name
Patch by Tibor Répási; reviewed by brandonwilliams for CASSANDRA-19110
---
doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +-
doc/modules/cassandra/examples/BASH/get_deb_package.sh | 2 +-
doc/modules/cassandra/partials/package_versions.adoc | 13 +
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/doc/modules/cassandra/examples/BASH/add_repo_keys.sh
b/doc/modules/cassandra/examples/BASH/add_repo_keys.sh
index 4c1d5f1777..b09d9d42cb 100644
--- a/doc/modules/cassandra/examples/BASH/add_repo_keys.sh
+++ b/doc/modules/cassandra/examples/BASH/add_repo_keys.sh
@@ -1 +1 @@
-$ curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add -
+$ curl -o /etc/apt/keyrings/apache-cassandra.asc
https://downloads.apache.org/cassandra/KEYS
diff --git a/doc/modules/cassandra/examples/BASH/get_deb_package.sh
b/doc/modules/cassandra/examples/BASH/get_deb_package.sh
index 0b866a8310..ab34c32a98 100644
--- a/doc/modules/cassandra/examples/BASH/get_deb_package.sh
+++ b/doc/modules/cassandra/examples/BASH/get_deb_package.sh
@@ -1,2 +1,2 @@
-$ echo "deb https://debian.cassandra.apache.org 311x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
+$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 311x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
deb https://debian.cassandra.apache.org 311x main
diff --git a/doc/modules/cassandra/partials/package_versions.adoc
b/doc/modules/cassandra/partials/package_versions.adoc
index f5c89689ee..406ae9cc59 100644
--- a/doc/modules/cassandra/partials/package_versions.adoc
+++ b/doc/modules/cassandra/partials/package_versions.adoc
@@ -1,5 +1,10 @@
-The latest major version is {311_version} and the
-corresponding distribution name is `311x` (with an "x" as the suffix).
-For older releases use `30x` for {30_version}, `22x` for {22_version} and
-`21x` for {21_version}.
+The latest major version is {311_version} and the corresponding distribution
name is `311x` (with an "x" as the suffix).
+For older releases use:
+
+* `311x` for C* {311_version} series
+* `30x` for C* {30_version} series
+* `22x` for C* {22_version} series
+* `21x` for C* {21_version} series
+* `20x` for C* {20_version} series
+
For example, to add the repository for version {311_version} (`311x`):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-4.0 updated (c73683c1a8 -> f0aa6744d2)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from c73683c1a8 Merge branch 'cassandra-3.11' into cassandra-4.0 new 338e4ed618 Docs: deprecate the usage of apt-key and adopt distribution name new f0aa6744d2 Merge branch 'cassandra-3.11' into cassandra-4.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +- doc/modules/cassandra/examples/BASH/get_deb_package.sh | 2 +- doc/modules/cassandra/partials/package_versions.adoc | 15 ++- 3 files changed, 12 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-4.1' into cassandra-5.0
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 973aad7b68f92e5c936052144357ae1592c9b3a3
Merge: be507c6e99 7cbf59e9a1
Author: Brandon Williams
AuthorDate: Wed Apr 3 17:01:21 2024 -0500
Merge branch 'cassandra-4.1' into cassandra-5.0
doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +-
doc/modules/cassandra/examples/BASH/get_deb_package.sh | 4 ++--
doc/modules/cassandra/partials/package_versions.adoc | 11 +--
3 files changed, 8 insertions(+), 9 deletions(-)
diff --cc doc/modules/cassandra/examples/BASH/get_deb_package.sh
index 8c1b07bb1e,62ed5d4ff7..a1d64eaf0a
--- a/doc/modules/cassandra/examples/BASH/get_deb_package.sh
+++ b/doc/modules/cassandra/examples/BASH/get_deb_package.sh
@@@ -1,2 -1,2 +1,2 @@@
- $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
- deb https://debian.cassandra.apache.org 42x main
-$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 41x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
-deb https://debian.cassandra.apache.org 41x main
++$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 50x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
++deb https://debian.cassandra.apache.org 50x main
diff --cc doc/modules/cassandra/partials/package_versions.adoc
index 17ca41dce3,b968ebb9ff..4457d7ae19
--- a/doc/modules/cassandra/partials/package_versions.adoc
+++ b/doc/modules/cassandra/partials/package_versions.adoc
@@@ -1,9 -1,9 +1,8 @@@
- The latest major version is {40_version} and the corresponding distribution
name is `40x` (with an "x" as the suffix).
-The latest major version is {41_version} and the corresponding distribution
name is `41x` (with an "x" as the suffix).
++The latest major version is {50_version} and the corresponding distribution
name is `50x` (with an "x" as the suffix).
For older releases use:
- * `311x` for C* {3x_version} series
- * `30x` for {30_version}
- * `22x` for {22_version}
- * `21x` for {21_version}
++* `50x` for C* {50_version} series
+ * `41x` for C* {41_version} series
+ * `40x` for C* {40_version} series
-* `311x` for C* {311_version} series
-* `30x` for C* {30_version} series
- For example, to add the repository for version {40_version} (`40x`):
-For example, to add the repository for version {41_version} (`41x`):
++For example, to add the repository for version {50_version} (`50x`):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 7cbf59e9a1c17593c7924f096e30fedb2ef742f9
Merge: 59789544bd f0aa6744d2
Author: Brandon Williams
AuthorDate: Wed Apr 3 16:49:47 2024 -0500
Merge branch 'cassandra-4.0' into cassandra-4.1
doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +-
doc/modules/cassandra/examples/BASH/get_deb_package.sh | 2 +-
doc/modules/cassandra/partials/package_versions.adoc | 14 +-
3 files changed, 11 insertions(+), 7 deletions(-)
diff --cc doc/modules/cassandra/examples/BASH/get_deb_package.sh
index 69648e8928,3512c37c61..62ed5d4ff7
--- a/doc/modules/cassandra/examples/BASH/get_deb_package.sh
+++ b/doc/modules/cassandra/examples/BASH/get_deb_package.sh
@@@ -1,2 -1,2 +1,2 @@@
- $ echo "deb https://debian.cassandra.apache.org 41x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
-$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 40x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
-deb https://debian.cassandra.apache.org 40x main
++$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 41x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
+deb https://debian.cassandra.apache.org 41x main
diff --cc doc/modules/cassandra/partials/package_versions.adoc
index 12eab03eb5,a5c7bfe67c..b968ebb9ff
--- a/doc/modules/cassandra/partials/package_versions.adoc
+++ b/doc/modules/cassandra/partials/package_versions.adoc
@@@ -1,5 -1,10 +1,9 @@@
- The latest major version is {40_version} and the
- corresponding distribution name is `40x` (with an "x" as the suffix).
- For older releases use `311x` for C* {3x_version} series, `30x` for
{30_version}, `22x`
- for {22_version} and `21x` for {21_version}. For example, to add the
repository for
- version {40_version} (`40x`):
-The latest major version is {40_version} and the corresponding distribution
name is `40x` (with an "x" as the suffix).
++The latest major version is {41_version} and the corresponding distribution
name is `41x` (with an "x" as the suffix).
+ For older releases use:
+
++* `41x` for C* {41_version} series
+ * `40x` for C* {40_version} series
+ * `311x` for C* {311_version} series
+ * `30x` for C* {30_version} series
-* `22x` for C* {22_version} series
-* `21x` for C* {21_version} series
+
-For example, to add the repository for version {40_version} (`40x`):
++For example, to add the repository for version {41_version} (`41x`):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 2944d77aac0e75cdc424641dbd3b7364ca72fae3
Merge: b37f47b3ee 973aad7b68
Author: Brandon Williams
AuthorDate: Wed Apr 3 17:01:48 2024 -0500
Merge branch 'cassandra-5.0' into trunk
doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +-
doc/modules/cassandra/examples/BASH/get_deb_package.sh | 4 ++--
doc/modules/cassandra/partials/package_versions.adoc | 11 +--
3 files changed, 8 insertions(+), 9 deletions(-)
diff --cc doc/modules/cassandra/examples/BASH/get_deb_package.sh
index 8c1b07bb1e,a1d64eaf0a..96ebb44ae5
--- a/doc/modules/cassandra/examples/BASH/get_deb_package.sh
+++ b/doc/modules/cassandra/examples/BASH/get_deb_package.sh
@@@ -1,2 -1,2 +1,2 @@@
- $ echo "deb https://debian.cassandra.apache.org 42x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
- deb https://debian.cassandra.apache.org 42x main
-$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 50x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
-deb https://debian.cassandra.apache.org 50x main
++$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 51x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
++deb https://debian.cassandra.apache.org 51x main
diff --cc doc/modules/cassandra/partials/package_versions.adoc
index 17ca41dce3,4457d7ae19..44233bc992
--- a/doc/modules/cassandra/partials/package_versions.adoc
+++ b/doc/modules/cassandra/partials/package_versions.adoc
@@@ -1,9 -1,8 +1,8 @@@
- The latest major version is {40_version} and the corresponding distribution
name is `40x` (with an "x" as the suffix).
-The latest major version is {50_version} and the corresponding distribution
name is `50x` (with an "x" as the suffix).
++The latest major version is {51_version} and the corresponding distribution
name is `51x` (with an "x" as the suffix).
For older releases use:
- * `311x` for C* {3x_version} series
- * `30x` for {30_version}
- * `22x` for {22_version}
- * `21x` for {21_version}
++* `51x` for C* {51_version} series
+ * `50x` for C* {50_version} series
+ * `41x` for C* {41_version} series
-* `40x` for C* {40_version} series
- For example, to add the repository for version {40_version} (`40x`):
-For example, to add the repository for version {50_version} (`50x`):
++For example, to add the repository for version {51_version} (`51x`):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f0aa6744d2390535476a928d666f01482b3b7796
Merge: c73683c1a8 338e4ed618
Author: Brandon Williams
AuthorDate: Wed Apr 3 16:48:49 2024 -0500
Merge branch 'cassandra-3.11' into cassandra-4.0
doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +-
doc/modules/cassandra/examples/BASH/get_deb_package.sh | 2 +-
doc/modules/cassandra/partials/package_versions.adoc | 15 ++-
3 files changed, 12 insertions(+), 7 deletions(-)
diff --cc doc/modules/cassandra/examples/BASH/get_deb_package.sh
index 544512280a,ab34c32a98..3512c37c61
--- a/doc/modules/cassandra/examples/BASH/get_deb_package.sh
+++ b/doc/modules/cassandra/examples/BASH/get_deb_package.sh
@@@ -1,2 -1,2 +1,2 @@@
- $ echo "deb https://debian.cassandra.apache.org 40x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
-$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 311x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
-deb https://debian.cassandra.apache.org 311x main
++$ echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc]
https://debian.cassandra.apache.org 40x main" | sudo tee -a
/etc/apt/sources.list.d/cassandra.sources.list
+deb https://debian.cassandra.apache.org 40x main
diff --cc doc/modules/cassandra/partials/package_versions.adoc
index 12eab03eb5,406ae9cc59..a5c7bfe67c
--- a/doc/modules/cassandra/partials/package_versions.adoc
+++ b/doc/modules/cassandra/partials/package_versions.adoc
@@@ -1,5 -1,10 +1,10 @@@
- The latest major version is {40_version} and the
- corresponding distribution name is `40x` (with an "x" as the suffix).
- For older releases use `311x` for C* {3x_version} series, `30x` for
{30_version}, `22x`
- for {22_version} and `21x` for {21_version}. For example, to add the
repository for
- version {40_version} (`40x`):
-The latest major version is {311_version} and the corresponding distribution
name is `311x` (with an "x" as the suffix).
++The latest major version is {40_version} and the corresponding distribution
name is `40x` (with an "x" as the suffix).
+ For older releases use:
+
++* `40x` for C* {40_version} series
+ * `311x` for C* {311_version} series
+ * `30x` for C* {30_version} series
+ * `22x` for C* {22_version} series
+ * `21x` for C* {21_version} series
-* `20x` for C* {20_version} series
+
-For example, to add the repository for version {311_version} (`311x`):
++For example, to add the repository for version {40_version} (`40x`):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-4.1 updated (59789544bd -> 7cbf59e9a1)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 59789544bd Merge branch 'cassandra-4.0' into cassandra-4.1 new 338e4ed618 Docs: deprecate the usage of apt-key and adopt distribution name new f0aa6744d2 Merge branch 'cassandra-3.11' into cassandra-4.0 new 7cbf59e9a1 Merge branch 'cassandra-4.0' into cassandra-4.1 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +- doc/modules/cassandra/examples/BASH/get_deb_package.sh | 2 +- doc/modules/cassandra/partials/package_versions.adoc | 14 +- 3 files changed, 11 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated (b37f47b3ee -> 2944d77aac)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from b37f47b3ee Merge branch 'cassandra-5.0' into trunk new 338e4ed618 Docs: deprecate the usage of apt-key and adopt distribution name new f0aa6744d2 Merge branch 'cassandra-3.11' into cassandra-4.0 new 7cbf59e9a1 Merge branch 'cassandra-4.0' into cassandra-4.1 new 973aad7b68 Merge branch 'cassandra-4.1' into cassandra-5.0 new 2944d77aac Merge branch 'cassandra-5.0' into trunk The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/modules/cassandra/examples/BASH/add_repo_keys.sh | 2 +- doc/modules/cassandra/examples/BASH/get_deb_package.sh | 4 ++-- doc/modules/cassandra/partials/package_versions.adoc | 11 +-- 3 files changed, 8 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833748#comment-17833748 ] Ekaterina Dimitrova edited comment on CASSANDRA-19428 at 4/3/24 9:57 PM: - Update: CASSANDRA-14572 was committed just after I rebased. This means the cassandra patch was not presented during the CI run, but the cassandra-dtest was presented. This leads to test_default_keyspaces_exist failing. After rebase (with no conflicts) the test does not fail for me locally anymore. Most of the failures here are also presented in the final CASSANDRA-14572 CI run: test_assassinate_valid_node - CASSANDRA-18753 test_bootstrap_with_reset_bootstrap_state - (?) test_sstablelevelreset - (?) test_sstableofflinerelevel - (?) test_resumable_decommission - (?) testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a ticket (?) simulationTest - (?) testSplitBrainStartup-_jdk17 - (?) discoveryTest - failed also with 14572 CI run, attributed to network glitch ([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)] - ticket (?) [~mmuzaf] , are those marked with (?) in my list ticketed? I did not find a trace in Jira, except they were presented in your CI run from CASSANDRA-14572. Failures not presented on that run, trying to reproduce them now, but they do not seem related in any way to what we do here. Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk. test_simple_decommission - testMixedVersionBlockDecom-_jdk17 - testIncompleteState-oa_jdk17 - I will update soon about these last 3 was (Author: e.dimitrova): Update: CASSANDRA-14572 was committed just after I rebased. This means the cassandra patch was not presented during the CI run, but the cassandra-dtest was presented. This lead to test_default_keyspaces_exist failing. After rebase (with no conflicts) the test does not fail for me locally anymore. The rest of the failures here are also presented in the final CASSANDRA-14572 CI run: test_assassinate_valid_node - CASSANDRA-18753 test_bootstrap_with_reset_bootstrap_state - (?) test_sstablelevelreset - (?) test_sstableofflinerelevel - (?) test_resumable_decommission - (?) testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a ticket (?) simulationTest - (?) testSplitBrainStartup-_jdk17 - (?) discoveryTest - failed also with 14572 CI run, attributed to network glitch ([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)] - ticket (?) [~mmuzaf] , are those marked with (?) in my list ticketed? I did not find a trace in Jira, except they were presented in your CI run from CASSANDRA-14572. Failures not presented on that run, trying to reproduce them now, but they do not seem related in any way to what we do here. Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk. test_simple_decommission - testMixedVersionBlockDecom-_jdk17 - testIncompleteState-oa_jdk17 - I will update soon about these last 3 > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19489) Guardrail to warn clients about possible transient incorrect responses for filtering queries against multiple mutable columns
[ https://issues.apache.org/jira/browse/CASSANDRA-19489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-19489: Source Control Link: https://github.com/apache/cassandra/commit/be507c6e996078011c08e36b09d9f34faa454973#diff-41cce7fa5999d0a5fec7205180d9795d936d687200e269574b8bb95aa7937796 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as https://github.com/apache/cassandra/commit/be507c6e996078011c08e36b09d9f34faa454973#diff-41cce7fa5999d0a5fec7205180d9795d936d687200e269574b8bb95aa7937796 > Guardrail to warn clients about possible transient incorrect responses for > filtering queries against multiple mutable columns > - > > Key: CASSANDRA-19489 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19489 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination, CQL/Semantics, Messaging/Client >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0.x, 5.1 > > Attachments: ci_summary-1.html, ci_summary.html > > Time Spent: 1.5h > Remaining Estimate: 0h > > Given we may not have time to fully resolve CASSANDRA-19007 before we release > 5.0, it would still be helpful to have, at the very minimum, a client warning > for cases where a user filters on two or more mutable (static or regular) > columns at consistency levels that require coordinator reconciliation. We may > also want the option to fail these queries outright, although that need not > be the default. > The only art involved in this is deciding what we want to say in the > warning/error message. It's probably reasonable to mention there that this > only happens when we have unrepaired data. It's also worth noting that SAI > queries are no longer vulnerable to this after the resolution of > CASSANDRA-19018. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated (2e7def7626 -> b37f47b3ee)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 2e7def7626 Expose all dropwizard metrics in virtual tables new be507c6e99 Warn clients about possible consistency violations for filtering queries against multiple mutable columns new b37f47b3ee Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/config/Config.java | 2 + .../apache/cassandra/config/GuardrailsOptions.java | 29 + .../org/apache/cassandra/cql3/QueryProcessor.java | 2 +- .../apache/cassandra/cql3/UntypedResultSet.java| 4 +- .../cql3/restrictions/StatementRestrictions.java | 3 +- .../cassandra/cql3/statements/SelectStatement.java | 45 .../org/apache/cassandra/db/filter/RowFilter.java | 10 +- .../apache/cassandra/db/guardrails/Guardrails.java | 39 +++ .../cassandra/db/guardrails/GuardrailsConfig.java | 16 +++ .../cassandra/db/guardrails/GuardrailsMBean.java | 16 +++ .../GuardrailNonPartitionRestrictedQueryTest.java | 37 ++- .../test/guardrails/GuardrailTester.java | 41 ++- .../guardrails/IntersectFilteringQueryTest.java| 120 + 14 files changed, 311 insertions(+), 54 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/guardrails/IntersectFilteringQueryTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit b37f47b3ee8c291e8cbbd95f91b3fe04df50cfa4 Merge: 2e7def7626 be507c6e99 Author: Caleb Rackliffe AuthorDate: Wed Apr 3 16:37:43 2024 -0500 Merge branch 'cassandra-5.0' into trunk * cassandra-5.0: Warn clients about possible consistency violations for filtering queries against multiple mutable columns CHANGES.txt| 1 + src/java/org/apache/cassandra/config/Config.java | 2 + .../apache/cassandra/config/GuardrailsOptions.java | 29 + .../org/apache/cassandra/cql3/QueryProcessor.java | 2 +- .../apache/cassandra/cql3/UntypedResultSet.java| 4 +- .../cql3/restrictions/StatementRestrictions.java | 3 +- .../cassandra/cql3/statements/SelectStatement.java | 45 .../org/apache/cassandra/db/filter/RowFilter.java | 10 +- .../apache/cassandra/db/guardrails/Guardrails.java | 39 +++ .../cassandra/db/guardrails/GuardrailsConfig.java | 16 +++ .../cassandra/db/guardrails/GuardrailsMBean.java | 16 +++ .../GuardrailNonPartitionRestrictedQueryTest.java | 37 ++- .../test/guardrails/GuardrailTester.java | 41 ++- .../guardrails/IntersectFilteringQueryTest.java| 120 + 14 files changed, 311 insertions(+), 54 deletions(-) diff --cc CHANGES.txt index 3703a0bf04,cb3e2676cb..c8ce4d9fae --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,33 -1,5 +1,34 @@@ -5.0-beta2 +5.1 + * Expose all dropwizard metrics in virtual tables (CASSANDRA-14572) + * Ensured that PropertyFileSnitchTest do not overwrite cassandra-toploogy.properties (CASSANDRA-19502) + * Add option for MutualTlsAuthenticator to restrict the certificate validity period (CASSANDRA-18951) + * Fix StorageService::constructRangeToEndpointMap for non-distributed keyspaces (CASSANDRA-19255) + * Group nodetool cms commands into single command group (CASSANDRA-19393) + * Register the measurements of the bootstrap process as Dropwizard metrics (CASSANDRA-19447) + * Add LIST SUPERUSERS CQL statement (CASSANDRA-19417) + * Modernize CQLSH datetime conversions (CASSANDRA-18879) + * Harry model and in-JVM tests for partition-restricted 2i queries (CASSANDRA-18275) + * Refactor cqlshmain global constants (CASSANDRA-19201) + * Remove native_transport_port_ssl (CASSANDRA-19397) + * Make nodetool reconfigurecms sync by default and add --cancel to be able to cancel ongoing reconfigurations (CASSANDRA-19216) + * Expose auth mode in system_views.clients, nodetool clientstats, metrics (CASSANDRA-19366) + * Remove sealed_periods and last_sealed_period tables (CASSANDRA-19189) + * Improve setup and initialisation of LocalLog/LogSpec (CASSANDRA-19271) + * Refactor structure of caching metrics and expose auth cache metrics via JMX (CASSANDRA-17062) + * Allow CQL client certificate authentication to work without sending an AUTHENTICATE request (CASSANDRA-18857) + * Extend nodetool tpstats and system_views.thread_pools with detailed pool parameters (CASSANDRA-19289) + * Remove dependency on Sigar in favor of OSHI (CASSANDRA-16565) + * Simplify the bind marker and Term logic (CASSANDRA-18813) + * Limit cassandra startup to supported JDKs, allow higher JDKs by setting CASSANDRA_JDK_UNSUPPORTED (CASSANDRA-18688) + * Standardize nodetool tablestats formatting of data units (CASSANDRA-19104) + * Make nodetool tablestats use number of significant digits for time and average values consistently (CASSANDRA-19015) + * Upgrade jackson to 2.15.3 and snakeyaml to 2.1 (CASSANDRA-18875) + * Transactional Cluster Metadata [CEP-21] (CASSANDRA-18330) + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Warn clients about possible consistency violations for filtering queries against multiple mutable columns (CASSANDRA-19489) * Align buffer with commitlog segment size (CASSANDRA-19471) * Ensure SAI indexes empty byte buffers for types that allow them as a valid input (CASSANDRA-19461) * Deprecate Python 3.7 and earlier, but allow cqlsh to run with Python 3.6-3.11 (CASSANDRA-19467) diff --cc src/java/org/apache/cassandra/cql3/restrictions/StatementRestrictions.java index 9e145a2208,4f6b829191..587cc41638 --- a/src/java/org/apache/cassandra/cql3/restrictions/StatementRestrictions.java +++ b/src/java/org/apache/cassandra/cql3/restrictions/StatementRestrictions.java @@@ -781,7 -780,8 +781,8 @@@ public final class StatementRestriction return RowFilter.none(); // If there is only one replica, we don't need reconciliation at any consistency level. - boolean needsReconciliation = options.getConsistency().needsReconciliation()
(cassandra) branch cassandra-5.0 updated: Warn clients about possible consistency violations for filtering queries against multiple mutable columns
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-5.0 by this push:
new be507c6e99 Warn clients about possible consistency violations for
filtering queries against multiple mutable columns
be507c6e99 is described below
commit be507c6e996078011c08e36b09d9f34faa454973
Author: Caleb Rackliffe
AuthorDate: Mon Apr 1 14:18:05 2024 -0500
Warn clients about possible consistency violations for filtering queries
against multiple mutable columns
patch by Caleb Rackliffe; reviewed by David Capwell and Berenguer Blasi for
CASSANDRA-19489
---
CHANGES.txt| 1 +
src/java/org/apache/cassandra/config/Config.java | 2 +
.../apache/cassandra/config/GuardrailsOptions.java | 29 +
.../org/apache/cassandra/cql3/QueryProcessor.java | 2 +-
.../apache/cassandra/cql3/UntypedResultSet.java| 4 +-
.../cql3/restrictions/StatementRestrictions.java | 3 +-
.../cassandra/cql3/statements/SelectStatement.java | 45
.../org/apache/cassandra/db/filter/RowFilter.java | 10 +-
.../apache/cassandra/db/guardrails/Guardrails.java | 39 +++
.../cassandra/db/guardrails/GuardrailsConfig.java | 16 +++
.../cassandra/db/guardrails/GuardrailsMBean.java | 16 +++
.../GuardrailNonPartitionRestrictedQueryTest.java | 37 ++-
.../test/guardrails/GuardrailTester.java | 41 ++-
.../guardrails/IntersectFilteringQueryTest.java| 120 +
14 files changed, 311 insertions(+), 54 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index e879141be7..cb3e2676cb 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.0-beta2
+ * Warn clients about possible consistency violations for filtering queries
against multiple mutable columns (CASSANDRA-19489)
* Align buffer with commitlog segment size (CASSANDRA-19471)
* Ensure SAI indexes empty byte buffers for types that allow them as a valid
input (CASSANDRA-19461)
* Deprecate Python 3.7 and earlier, but allow cqlsh to run with Python
3.6-3.11 (CASSANDRA-19467)
diff --git a/src/java/org/apache/cassandra/config/Config.java
b/src/java/org/apache/cassandra/config/Config.java
index d97f35d759..aa0f3ee476 100644
--- a/src/java/org/apache/cassandra/config/Config.java
+++ b/src/java/org/apache/cassandra/config/Config.java
@@ -905,6 +905,8 @@ public class Config
public volatile boolean non_partition_restricted_index_query_enabled =
true;
public volatile int sai_sstable_indexes_per_query_warn_threshold = 32;
public volatile int sai_sstable_indexes_per_query_fail_threshold = -1;
+public volatile boolean intersect_filtering_query_warned = true;
+public volatile boolean intersect_filtering_query_enabled = true;
public volatile DurationSpec.LongNanosecondsBound streaming_state_expires
= new DurationSpec.LongNanosecondsBound("3d");
public volatile DataStorageSpec.LongBytesBound streaming_state_size = new
DataStorageSpec.LongBytesBound("40MiB");
diff --git a/src/java/org/apache/cassandra/config/GuardrailsOptions.java
b/src/java/org/apache/cassandra/config/GuardrailsOptions.java
index 2c36a2a03d..8d7bd52197 100644
--- a/src/java/org/apache/cassandra/config/GuardrailsOptions.java
+++ b/src/java/org/apache/cassandra/config/GuardrailsOptions.java
@@ -846,6 +846,35 @@ public class GuardrailsOptions implements GuardrailsConfig
x -> config.zero_ttl_on_twcs_enabled = x);
}
+@Override
+public boolean getIntersectFilteringQueryWarned()
+{
+return config.intersect_filtering_query_warned;
+}
+
+@Override
+public void setIntersectFilteringQueryWarned(boolean value)
+{
+updatePropertyWithLogging("intersect_filtering_query_warned",
+ value,
+ () ->
config.intersect_filtering_query_warned,
+ x -> config.intersect_filtering_query_warned
= x);
+}
+
+@Override
+public boolean getIntersectFilteringQueryEnabled()
+{
+return config.intersect_filtering_query_enabled;
+}
+
+public void setIntersectFilteringQueryEnabled(boolean value)
+{
+updatePropertyWithLogging("intersect_filtering_query_enabled",
+ value,
+ () ->
config.intersect_filtering_query_enabled,
+ x ->
config.intersect_filtering_query_enabled = x);
+}
+
@Override
public DurationSpec.LongMicrosecondsBound
getMaximumTimestampWarnThreshold()
{
diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
index fba424d7d9..15cfaa6c0f 100644
---
(cassandra-website) branch asf-staging updated (801686eca -> d73486f66)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 801686eca generate docs for 85c41371 add 443c2f356 deprecate the usage of apt-key new d73486f66 generate docs for 443c2f35 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (801686eca) \ N -- N -- N refs/heads/asf-staging (d73486f66) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/_/download.html| 31 ++ .../5.1/cassandra/managing/operating/metrics.html | 27 - .../managing/operating/virtualtables.html | 65 - .../cassandra/managing/operating/metrics.html | 27 - .../managing/operating/virtualtables.html | 65 - .../source/modules/ROOT/pages/download.adoc| 23 ++-- site-ui/build/ui-bundle.zip| Bin 4883646 -> 4883646 bytes 7 files changed, 186 insertions(+), 52 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833748#comment-17833748 ] Ekaterina Dimitrova edited comment on CASSANDRA-19428 at 4/3/24 9:33 PM: - Update: CASSANDRA-14572 was committed just after I rebased. This means the cassandra patch was not presented during the CI run, but the cassandra-dtest was presented. This lead to test_default_keyspaces_exist failing. After rebase (with no conflicts) the test does not fail for me locally anymore. The rest of the failures here are also presented in the final CASSANDRA-14572 CI run: test_assassinate_valid_node - CASSANDRA-18753 test_bootstrap_with_reset_bootstrap_state - (?) test_sstablelevelreset - (?) test_sstableofflinerelevel - (?) test_resumable_decommission - (?) testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a ticket (?) simulationTest - (?) testSplitBrainStartup-_jdk17 - (?) discoveryTest - failed also with 14572 CI run, attributed to network glitch ([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)] - ticket (?) [~mmuzaf] , are those marked with (?) in my list ticketed? I did not find a trace in Jira, except they were presented in your CI run from CASSANDRA-14572. Failures not presented on that run, trying to reproduce them now, but they do not seem related in any way to what we do here. Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk. test_simple_decommission - testMixedVersionBlockDecom-_jdk17 - testIncompleteState-oa_jdk17 - I will update soon about these last 3 was (Author: e.dimitrova): Update: CASSANDRA-14572 was committed just after I rebased. This means the cassandra patch was not presented during the CI run, but the cassandra-dtest was presented. This lead to test_default_keyspaces_exist failing. After rebase (with no conflicts) the test does not fail for me locally anymore. The rest of the failures here are also presented in the final CASSANDRA-14572 CI run: test_assassinate_valid_node - CASSANDRA-18753 test_bootstrap_with_reset_bootstrap_state - (?) test_sstablelevelreset - (?) test_sstableofflinerelevel - (?) test_resumable_decommission - (?) testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a ticket (?) simulationTest - (?) testSplitBrainStartup-_jdk17 - (?) discoveryTest - failed also with 14572 CI run, attributed to network glitch ([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)] - ticket (?) [~mmuzaf] , are those marked with ? in my list ticketed? I did not find a trace in Jira, except they were presented in your CI run from CASSANDRA-14572. Failures not presented on that run, trying to reproduce them now, but they do not seem related in any way to what we do here. Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk. test_simple_decommission - testMixedVersionBlockDecom-_jdk17 - testIncompleteState-oa_jdk17 - I will update soon about these last 3 > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833748#comment-17833748 ] Ekaterina Dimitrova commented on CASSANDRA-19428: - Update: CASSANDRA-14572 was committed just after I rebased. This means the cassandra patch was not presented during the CI run, but the cassandra-dtest was presented. This lead to test_default_keyspaces_exist failing. After rebase (with no conflicts) the test does not fail for me locally anymore. The rest of the failures here are also presented in the final CASSANDRA-14572 CI run: test_assassinate_valid_node - CASSANDRA-18753 test_bootstrap_with_reset_bootstrap_state - (?) test_sstablelevelreset - (?) test_sstableofflinerelevel - (?) test_resumable_decommission - (?) testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a ticket (?) simulationTest - (?) testSplitBrainStartup-_jdk17 - (?) discoveryTest - failed also with 14572 CI run, attributed to network glitch ([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)] - ticket (?) [~mmuzaf] , are those marked with ? in my list ticketed? I did not find a trace in Jira, except they were presented in your CI run from CASSANDRA-14572. Failures not presented on that run, trying to reproduce them now, but they do not seem related in any way to what we do here. Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk. test_simple_decommission - testMixedVersionBlockDecom-_jdk17 - testIncompleteState-oa_jdk17 - I will update soon about these last 3 > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19515) unhandled exception handling in jvm dtest may see errors from other clusters
[ https://issues.apache.org/jira/browse/CASSANDRA-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833746#comment-17833746 ] David Capwell commented on CASSANDRA-19515: --- Holding off merge due to test issues with this change. Need to spend a bit more time to avoid flakey tests > unhandled exception handling in jvm dtest may see errors from other clusters > > > Key: CASSANDRA-19515 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19515 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > From time to time we see tests failing with unexpected errors during close, > but this shouldn’t be possible because we ignore errors for instances that > are shutting down…. In debugging it turns out that the errors are from > different clusters, so we add to the unexpected error list even though it’s > not from this cluster! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch trunk updated: deprecate the usage of apt-key
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-website.git The following commit(s) were added to refs/heads/trunk by this push: new 443c2f356 deprecate the usage of apt-key 443c2f356 is described below commit 443c2f3568e047fc33f363b7a719b2c151388995 Author: Tibor Répási AuthorDate: Tue Apr 2 15:49:56 2024 +0200 deprecate the usage of apt-key Patch by Tibor Répási; reviewed by brandonwilliams for CASSANDRA-19110 --- .../source/modules/ROOT/pages/download.adoc| 23 -- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/site-content/source/modules/ROOT/pages/download.adoc b/site-content/source/modules/ROOT/pages/download.adoc index 1010e9096..8d1267a0f 100644 --- a/site-content/source/modules/ROOT/pages/download.adoc +++ b/site-content/source/modules/ROOT/pages/download.adoc @@ -156,18 +156,18 @@ Debian's `sources.list` and RedHat's `cassandra.repo` files must be updated to p * For the `` specify the major version number, without dot, and with an appended x. * The latest `` is `41x`. * For older releases, the `` can be one of `40x`, `311`, `30x`, or `22x`. -* Add the Apache repository of Cassandra to `/etc/apt/sources.list.d/cassandra.sources.list`, for example for the latest 4.0 +* Add the Apache Cassandra repository keys: [source] -- -echo "deb https://debian.cassandra.apache.org 41x main" | sudo tee -a /etc/apt/sources.list.d/cassandra.sources.list +curl -o /etc/apt/keyrings/apache-cassandra.asc https://downloads.apache.org/cassandra/KEYS -- -* Add the Apache Cassandra repository keys: +* Add the Apache repository of Cassandra to `/etc/apt/sources.list.d/cassandra.sources.list`, for example for the latest 4.1 [source] -- -curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - +echo "deb [signed-by=/etc/apt/keyrings/apache-cassandra.asc] https://debian.cassandra.apache.org 41x main" | sudo tee -a /etc/apt/sources.list.d/cassandra.sources.list -- * Update the repositories: @@ -177,21 +177,6 @@ curl https://downloads.apache.org/cassandra/KEYS | sudo apt-key add - sudo apt-get update -- -* If you encounter this error: - -[source] --- - GPG error: http://www.apache.org 311x InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY A278B781FE4B2BDA --- - -Then add the public key A278B781FE4B2BDA as follows: - -[source] --- -sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-key A278B781FE4B2BDA --- -and repeat `sudo apt-get update`. The actual key may be different, you get it from the error message itself. For a full list of Apache contributors public keys, you can refer to https://downloads.apache.org/cassandra/KEYS[Cassandra KEYS]. - * Install Cassandra: [source] - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Updating README JIRA link to ASF JIRA [cassandra-java-driver]
absurdfarce commented on PR #1921: URL: https://github.com/apache/cassandra-java-driver/pull/1921#issuecomment-2035587124 Given the last round of changes I'm a +1 to merging this; the sooner we can get these instructions out to our users the better! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Updating README JIRA link to ASF JIRA [cassandra-java-driver]
absurdfarce commented on code in PR #1921: URL: https://github.com/apache/cassandra-java-driver/pull/1921#discussion_r1550492894 ## README.md: ## @@ -80,7 +80,7 @@ See the [Cassandra error handling done right blog](https://www.datastax.com/blog * [FAQ] [API docs]: https://docs.datastax.com/en/drivers/java/4.17 -[JIRA]: https://datastax-oss.atlassian.net/browse/JAVA +[JIRA]: https://issues.apache.org/jira/projects/CASSANDRA/issues/ Review Comment: Ah, that's an excellent idea @michaelsembwever ! I'll also add some quick text here to make it clear that "Client/java-driver" is selected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19521) Website fails to pull docker image
[
https://issues.apache.org/jira/browse/CASSANDRA-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833743#comment-17833743
]
Brandon Williams commented on CASSANDRA-19521:
--
Note that I am logged in to docker.
> Website fails to pull docker image
> --
>
> Key: CASSANDRA-19521
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19521
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Documentation and Website
>Reporter: Brandon Williams
>Priority: Normal
>
> When executing "run.sh build website":
> {noformat}
> Step 14/48 : RUN npm i -g @antora/cli@2.3 @antora/site-generator-default@2.3
> @djencks/asciidoctor-openblock
> ---> Running in 4fa9fc4d4357
> /usr/local/bin/node: 1: ELF@���@8: not found
> /usr/local/bin/node: 5: Syntax error: "(" unexpected
> The command '/bin/sh -c npm i -g @antora/cli@2.3
> @antora/site-generator-default@2.3 @djencks/asciidoctor-openblock' returned a
> non-zero code: 2
> Error: No such object: apache/cassandra-website:latest
> Executing docker command:
> docker run --rm --name website_content -v
> /home/drift/cassandra/cassandra-website:/cassandra-website -v
> /home/drift/cassandra/cassandra-website/site-ui/build/ui-bundle.zip:/ui-bundle.zip
> -e ANTORA_CONTENT_SOURCES_CASSANDRA_WEBSITE_URL=/cassandra-website -e
> ANTORA_UI_BUNDLE_URL=/ui-bundle.zip apache/cassandra-website:latest
> build-site
> Unable to find image 'apache/cassandra-website:latest' locally
> docker: Error response from daemon: pull access denied for
> apache/cassandra-website, repository does not exist or may require 'docker
> login': denied: requested access to the resource is denied.
> See 'docker run --help'.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19521) Website fails to pull docker image
Brandon Williams created CASSANDRA-19521:
Summary: Website fails to pull docker image
Key: CASSANDRA-19521
URL: https://issues.apache.org/jira/browse/CASSANDRA-19521
Project: Cassandra
Issue Type: Bug
Reporter: Brandon Williams
When executing "run.sh build website":
{noformat}
Step 14/48 : RUN npm i -g @antora/cli@2.3 @antora/site-generator-default@2.3
@djencks/asciidoctor-openblock
---> Running in 4fa9fc4d4357
/usr/local/bin/node: 1: ELF@���@8: not found
/usr/local/bin/node: 5: Syntax error: "(" unexpected
The command '/bin/sh -c npm i -g @antora/cli@2.3
@antora/site-generator-default@2.3 @djencks/asciidoctor-openblock' returned a
non-zero code: 2
Error: No such object: apache/cassandra-website:latest
Executing docker command:
docker run --rm --name website_content -v
/home/drift/cassandra/cassandra-website:/cassandra-website -v
/home/drift/cassandra/cassandra-website/site-ui/build/ui-bundle.zip:/ui-bundle.zip
-e ANTORA_CONTENT_SOURCES_CASSANDRA_WEBSITE_URL=/cassandra-website -e
ANTORA_UI_BUNDLE_URL=/ui-bundle.zip apache/cassandra-website:latest build-site
Unable to find image 'apache/cassandra-website:latest' locally
docker: Error response from daemon: pull access denied for
apache/cassandra-website, repository does not exist or may require 'docker
login': denied: requested access to the resource is denied.
See 'docker run --help'.
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19521) Website fails to pull docker image
[
https://issues.apache.org/jira/browse/CASSANDRA-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19521:
-
Bug Category: Parent values: Availability(12983)
Complexity: Normal
Component/s: Legacy/Documentation and Website
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Website fails to pull docker image
> --
>
> Key: CASSANDRA-19521
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19521
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Documentation and Website
>Reporter: Brandon Williams
>Priority: Normal
>
> When executing "run.sh build website":
> {noformat}
> Step 14/48 : RUN npm i -g @antora/cli@2.3 @antora/site-generator-default@2.3
> @djencks/asciidoctor-openblock
> ---> Running in 4fa9fc4d4357
> /usr/local/bin/node: 1: ELF@���@8: not found
> /usr/local/bin/node: 5: Syntax error: "(" unexpected
> The command '/bin/sh -c npm i -g @antora/cli@2.3
> @antora/site-generator-default@2.3 @djencks/asciidoctor-openblock' returned a
> non-zero code: 2
> Error: No such object: apache/cassandra-website:latest
> Executing docker command:
> docker run --rm --name website_content -v
> /home/drift/cassandra/cassandra-website:/cassandra-website -v
> /home/drift/cassandra/cassandra-website/site-ui/build/ui-bundle.zip:/ui-bundle.zip
> -e ANTORA_CONTENT_SOURCES_CASSANDRA_WEBSITE_URL=/cassandra-website -e
> ANTORA_UI_BUNDLE_URL=/ui-bundle.zip apache/cassandra-website:latest
> build-site
> Unable to find image 'apache/cassandra-website:latest' locally
> docker: Error response from daemon: pull access denied for
> apache/cassandra-website, repository does not exist or may require 'docker
> login': denied: requested access to the resource is denied.
> See 'docker run --help'.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19520) upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing counter checks
[
https://issues.apache.org/jira/browse/CASSANDRA-19520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19520:
Since Version: 5.1
I've only seen this on trunk/5.1 so far...
> upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc
> failing counter checks
> --
>
> Key: CASSANDRA-19520
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19520
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission,
> Feature/Counters, Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Attachments: TESTS-TestSuites.xml, ci_summary.html
>
>
> This appears to be a new failure in {{{}test_bootstrap_multidc{}}}, around
> {{upgrade_scenario}} verifying counter updates. I can't reproduce locally, so
> perhaps there is a counter race condition lurking somewhere...
> {noformat}
> assert 249 == 248 +249 -248
> self =
> object at 0x7fbae9b96550>
> def test_bootstrap_multidc(self):
> # try and add a new node
> # multi dc, 2 nodes in each dc
> self.prepare()
> cluster = self.cluster
> if cluster.version() >= '5.0':
> cluster.set_configuration_options({'user_defined_functions_threads_enabled':
> 'true',
> 'scripted_user_defined_functions_enabled': 'false'})
> elif cluster.version() >= '3.0':
> cluster.set_configuration_options({'enable_user_defined_functions': 'true',
> 'enable_scripted_user_defined_functions': 'true'})
> elif cluster.version() >= '2.2':
> cluster.set_configuration_options({'enable_user_defined_functions': 'true'})
> cluster.populate([2, 2])
> [node.start(use_jna=True, wait_for_binary_proto=True) for node in
> self.cluster.nodelist()]
> self._multidc_schema_create()
> > self.upgrade_scenario(populate=False, create_schema=False,
> > after_upgrade_call=(self._bootstrap_new_node_multidc,))
> upgrade_tests/upgrade_through_versions_test.py:865:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:506: in upgrade_scenario
> call()
> upgrade_tests/upgrade_through_versions_test.py:841: in
> _bootstrap_new_node_multidc
> self._check_counters()
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7fbae9b96550>
> def _check_counters(self):
> logger.debug("Checking counter values...")
> session = self.patient_cql_connection(self.node2,
> protocol_version=self.protocol_version)
> session.execute("use upgrade;")
> for key1 in list(self.expected_counts.keys()):
> for key2 in list(self.expected_counts[key1].keys()):
> expected_value = self.expected_counts[key1][key2]
> query = SimpleStatement("SELECT c from countertable where k1='{key1}' and
> k2={key2};".format(key1=key1, key2=key2),
> consistency_level=ConsistencyLevel.ONE)
> results = session.execute(query)
> if results is not None:
> actual_value = results[0][0]
> else:
> # counter wasn't found
> actual_value = None
> > assert actual_value == expected_value
> E assert 249 == 248
> E +249
> E -248
> upgrade_tests/upgrade_through_versions_test.py:789: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19489) Guardrail to warn clients about possible transient incorrect responses for filtering queries against multiple mutable columns
[ https://issues.apache.org/jira/browse/CASSANDRA-19489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833742#comment-17833742 ] Caleb Rackliffe commented on CASSANDRA-19489: - Created CASSANDRA-19520 to track the upgrade test failure. > Guardrail to warn clients about possible transient incorrect responses for > filtering queries against multiple mutable columns > - > > Key: CASSANDRA-19489 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19489 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination, CQL/Semantics, Messaging/Client >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0.x, 5.1 > > Attachments: ci_summary-1.html, ci_summary.html > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Given we may not have time to fully resolve CASSANDRA-19007 before we release > 5.0, it would still be helpful to have, at the very minimum, a client warning > for cases where a user filters on two or more mutable (static or regular) > columns at consistency levels that require coordinator reconciliation. We may > also want the option to fail these queries outright, although that need not > be the default. > The only art involved in this is deciding what we want to say in the > warning/error message. It's probably reasonable to mention there that this > only happens when we have unrepaired data. It's also worth noting that SAI > queries are no longer vulnerable to this after the resolution of > CASSANDRA-19018. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19520) upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing counter checks
[
https://issues.apache.org/jira/browse/CASSANDRA-19520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19520:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Challenging
Discovered By: DTest
Severity: Normal
Status: Open (was: Triage Needed)
> upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc
> failing counter checks
> --
>
> Key: CASSANDRA-19520
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19520
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission,
> Feature/Counters, Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Attachments: TESTS-TestSuites.xml, ci_summary.html
>
>
> This appears to be a new failure in {{{}test_bootstrap_multidc{}}}, around
> {{upgrade_scenario}} verifying counter updates. I can't reproduce locally, so
> perhaps there is a counter race condition lurking somewhere...
> {noformat}
> assert 249 == 248 +249 -248
> self =
> object at 0x7fbae9b96550>
> def test_bootstrap_multidc(self):
> # try and add a new node
> # multi dc, 2 nodes in each dc
> self.prepare()
> cluster = self.cluster
> if cluster.version() >= '5.0':
> cluster.set_configuration_options({'user_defined_functions_threads_enabled':
> 'true',
> 'scripted_user_defined_functions_enabled': 'false'})
> elif cluster.version() >= '3.0':
> cluster.set_configuration_options({'enable_user_defined_functions': 'true',
> 'enable_scripted_user_defined_functions': 'true'})
> elif cluster.version() >= '2.2':
> cluster.set_configuration_options({'enable_user_defined_functions': 'true'})
> cluster.populate([2, 2])
> [node.start(use_jna=True, wait_for_binary_proto=True) for node in
> self.cluster.nodelist()]
> self._multidc_schema_create()
> > self.upgrade_scenario(populate=False, create_schema=False,
> > after_upgrade_call=(self._bootstrap_new_node_multidc,))
> upgrade_tests/upgrade_through_versions_test.py:865:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:506: in upgrade_scenario
> call()
> upgrade_tests/upgrade_through_versions_test.py:841: in
> _bootstrap_new_node_multidc
> self._check_counters()
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7fbae9b96550>
> def _check_counters(self):
> logger.debug("Checking counter values...")
> session = self.patient_cql_connection(self.node2,
> protocol_version=self.protocol_version)
> session.execute("use upgrade;")
> for key1 in list(self.expected_counts.keys()):
> for key2 in list(self.expected_counts[key1].keys()):
> expected_value = self.expected_counts[key1][key2]
> query = SimpleStatement("SELECT c from countertable where k1='{key1}' and
> k2={key2};".format(key1=key1, key2=key2),
> consistency_level=ConsistencyLevel.ONE)
> results = session.execute(query)
> if results is not None:
> actual_value = results[0][0]
> else:
> # counter wasn't found
> actual_value = None
> > assert actual_value == expected_value
> E assert 249 == 248
> E +249
> E -248
> upgrade_tests/upgrade_through_versions_test.py:789: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19520) Test failure: upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing counter checks
[
https://issues.apache.org/jira/browse/CASSANDRA-19520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19520:
-
Summary: Test failure:
upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing
counter checks (was:
upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing
counter checks)
> Test failure:
> upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc
> failing counter checks
>
>
> Key: CASSANDRA-19520
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19520
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission,
> Feature/Counters, Test/dtest/python
>Reporter: Caleb Rackliffe
>Priority: Normal
> Attachments: TESTS-TestSuites.xml, ci_summary.html
>
>
> This appears to be a new failure in {{{}test_bootstrap_multidc{}}}, around
> {{upgrade_scenario}} verifying counter updates. I can't reproduce locally, so
> perhaps there is a counter race condition lurking somewhere...
> {noformat}
> assert 249 == 248 +249 -248
> self =
> object at 0x7fbae9b96550>
> def test_bootstrap_multidc(self):
> # try and add a new node
> # multi dc, 2 nodes in each dc
> self.prepare()
> cluster = self.cluster
> if cluster.version() >= '5.0':
> cluster.set_configuration_options({'user_defined_functions_threads_enabled':
> 'true',
> 'scripted_user_defined_functions_enabled': 'false'})
> elif cluster.version() >= '3.0':
> cluster.set_configuration_options({'enable_user_defined_functions': 'true',
> 'enable_scripted_user_defined_functions': 'true'})
> elif cluster.version() >= '2.2':
> cluster.set_configuration_options({'enable_user_defined_functions': 'true'})
> cluster.populate([2, 2])
> [node.start(use_jna=True, wait_for_binary_proto=True) for node in
> self.cluster.nodelist()]
> self._multidc_schema_create()
> > self.upgrade_scenario(populate=False, create_schema=False,
> > after_upgrade_call=(self._bootstrap_new_node_multidc,))
> upgrade_tests/upgrade_through_versions_test.py:865:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:506: in upgrade_scenario
> call()
> upgrade_tests/upgrade_through_versions_test.py:841: in
> _bootstrap_new_node_multidc
> self._check_counters()
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7fbae9b96550>
> def _check_counters(self):
> logger.debug("Checking counter values...")
> session = self.patient_cql_connection(self.node2,
> protocol_version=self.protocol_version)
> session.execute("use upgrade;")
> for key1 in list(self.expected_counts.keys()):
> for key2 in list(self.expected_counts[key1].keys()):
> expected_value = self.expected_counts[key1][key2]
> query = SimpleStatement("SELECT c from countertable where k1='{key1}' and
> k2={key2};".format(key1=key1, key2=key2),
> consistency_level=ConsistencyLevel.ONE)
> results = session.execute(query)
> if results is not None:
> actual_value = results[0][0]
> else:
> # counter wasn't found
> actual_value = None
> > assert actual_value == expected_value
> E assert 249 == 248
> E +249
> E -248
> upgrade_tests/upgrade_through_versions_test.py:789: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19520) upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing counter checks
Caleb Rackliffe created CASSANDRA-19520:
---
Summary:
upgrade_tests.py::upgrade_through_versions_test::test_bootstrap_multidc failing
counter checks
Key: CASSANDRA-19520
URL: https://issues.apache.org/jira/browse/CASSANDRA-19520
Project: Cassandra
Issue Type: Bug
Components: Consistency/Bootstrap and Decommission, Feature/Counters,
Test/dtest/python
Reporter: Caleb Rackliffe
Attachments: TESTS-TestSuites.xml, ci_summary.html
This appears to be a new failure in {{{}test_bootstrap_multidc{}}}, around
{{upgrade_scenario}} verifying counter updates. I can't reproduce locally, so
perhaps there is a counter race condition lurking somewhere...
{noformat}
assert 249 == 248 +249 -248
self =
def test_bootstrap_multidc(self):
# try and add a new node
# multi dc, 2 nodes in each dc
self.prepare()
cluster = self.cluster
if cluster.version() >= '5.0':
cluster.set_configuration_options({'user_defined_functions_threads_enabled':
'true',
'scripted_user_defined_functions_enabled': 'false'})
elif cluster.version() >= '3.0':
cluster.set_configuration_options({'enable_user_defined_functions': 'true',
'enable_scripted_user_defined_functions': 'true'})
elif cluster.version() >= '2.2':
cluster.set_configuration_options({'enable_user_defined_functions': 'true'})
cluster.populate([2, 2])
[node.start(use_jna=True, wait_for_binary_proto=True) for node in
self.cluster.nodelist()]
self._multidc_schema_create()
> self.upgrade_scenario(populate=False, create_schema=False,
> after_upgrade_call=(self._bootstrap_new_node_multidc,))
upgrade_tests/upgrade_through_versions_test.py:865:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
upgrade_tests/upgrade_through_versions_test.py:506: in upgrade_scenario
call()
upgrade_tests/upgrade_through_versions_test.py:841: in
_bootstrap_new_node_multidc
self._check_counters()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
def _check_counters(self):
logger.debug("Checking counter values...")
session = self.patient_cql_connection(self.node2,
protocol_version=self.protocol_version)
session.execute("use upgrade;")
for key1 in list(self.expected_counts.keys()):
for key2 in list(self.expected_counts[key1].keys()):
expected_value = self.expected_counts[key1][key2]
query = SimpleStatement("SELECT c from countertable where k1='{key1}' and
k2={key2};".format(key1=key1, key2=key2),
consistency_level=ConsistencyLevel.ONE)
results = session.execute(query)
if results is not None:
actual_value = results[0][0]
else:
# counter wasn't found
actual_value = None
> assert actual_value == expected_value
E assert 249 == 248
E +249
E -248
upgrade_tests/upgrade_through_versions_test.py:789: AssertionError
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19182) IR may leak SSTables with pending repair when coming from streaming
[ https://issues.apache.org/jira/browse/CASSANDRA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833739#comment-17833739 ] Brandon Williams commented on CASSANDRA-19182: -- I am told because the severity is marked criticial, this should block releases. I am keen to release 4.x but we are currently blocked on another ticket, when that resolves I will commit. > IR may leak SSTables with pending repair when coming from streaming > --- > > Key: CASSANDRA-19182 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19182 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: > ci_summary-trunk-a1010f4101bf259de3f31077540e4f987d5df9c5.html > > Time Spent: 1h 40m > Remaining Estimate: 0h > > There is a race condition where SSTables from streaming may race with pending > repair cleanup in compaction causing us to cleanup the pending repair state > in compaction while the SSTables are being added to it; this leads to IR > failing in the future when those files get selected for repair. > This problem was hard to track down as the in-memory state was wiped, so we > don’t have any details. To better aid these types of investigation we should > make sure the repair vtables get updated when IR session failures are > submitted -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19497) ResultRetriever should batch clusterings/rows during SAI post-filtering reads
[
https://issues.apache.org/jira/browse/CASSANDRA-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833323#comment-17833323
]
Caleb Rackliffe edited comment on CASSANDRA-19497 at 4/3/24 8:31 PM:
-
I've attached a flamegraph taken during a recent profiling session where we can
see how prominent {{SinglePartitionReadCommand}} is for partition-restricted
queries. Also interesting is how much time we spend in
{{IndexTermType#isInetAddress()}} on the write side.
was (Author: maedhroz):
I've attached a couple flamegraphs taken during a recent profiling session
where we can see how prominent {{SinglePartitionReadCommand}} is. I'll try to
collect a few more, though, as this read workload was not partition-restricted.
> ResultRetriever should batch clusterings/rows during SAI post-filtering reads
> -
>
> Key: CASSANDRA-19497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19497
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: wall-no-parked-threads.html
>
>
> SAI currently creates and executes a {{SinglePartitionReadCommand}} for every
> {{PrimaryKey}} the index produces to read the corresponding row for
> post-filtering. Informed by the limits present in the read command itself, it
> should be possible to batch those reads w/ a {{ClusteringIndexNamesFilter}}
> in many fewer {{SinglePartitionReadCommands}}. When we have a handful of
> matches in a large partition, this seems like would involve many fewer seeks,
> less unnecessary object creation, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19497) ResultRetriever should batch clusterings/rows during SAI post-filtering reads
[
https://issues.apache.org/jira/browse/CASSANDRA-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19497:
Attachment: wall-no-parked-threads.html
> ResultRetriever should batch clusterings/rows during SAI post-filtering reads
> -
>
> Key: CASSANDRA-19497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19497
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: wall-no-parked-threads.html
>
>
> SAI currently creates and executes a {{SinglePartitionReadCommand}} for every
> {{PrimaryKey}} the index produces to read the corresponding row for
> post-filtering. Informed by the limits present in the read command itself, it
> should be possible to batch those reads w/ a {{ClusteringIndexNamesFilter}}
> in many fewer {{SinglePartitionReadCommands}}. When we have a handful of
> matches in a large partition, this seems like would involve many fewer seeks,
> less unnecessary object creation, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19497) ResultRetriever should batch clusterings/rows during SAI post-filtering reads
[
https://issues.apache.org/jira/browse/CASSANDRA-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19497:
Attachment: (was: flame-cassandra0-2024-03-27_19-12-35.html)
> ResultRetriever should batch clusterings/rows during SAI post-filtering reads
> -
>
> Key: CASSANDRA-19497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19497
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: wall-no-parked-threads.html
>
>
> SAI currently creates and executes a {{SinglePartitionReadCommand}} for every
> {{PrimaryKey}} the index produces to read the corresponding row for
> post-filtering. Informed by the limits present in the read command itself, it
> should be possible to batch those reads w/ a {{ClusteringIndexNamesFilter}}
> in many fewer {{SinglePartitionReadCommands}}. When we have a handful of
> matches in a large partition, this seems like would involve many fewer seeks,
> less unnecessary object creation, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19497) ResultRetriever should batch clusterings/rows during SAI post-filtering reads
[
https://issues.apache.org/jira/browse/CASSANDRA-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19497:
Attachment: (was: heap-flamegraph.html)
> ResultRetriever should batch clusterings/rows during SAI post-filtering reads
> -
>
> Key: CASSANDRA-19497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19497
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: wall-no-parked-threads.html
>
>
> SAI currently creates and executes a {{SinglePartitionReadCommand}} for every
> {{PrimaryKey}} the index produces to read the corresponding row for
> post-filtering. Informed by the limits present in the read command itself, it
> should be possible to batch those reads w/ a {{ClusteringIndexNamesFilter}}
> in many fewer {{SinglePartitionReadCommands}}. When we have a handful of
> matches in a large partition, this seems like would involve many fewer seeks,
> less unnecessary object creation, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19292 Enable Jenkins to test against Cassandra 4.1.x [cassandra-java-driver]
absurdfarce commented on code in PR #1924:
URL:
https://github.com/apache/cassandra-java-driver/pull/1924#discussion_r1550413753
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/CcmBridge.java:
##
@@ -463,6 +484,40 @@ private Optional
overrideJvmVersionForDseWorkloads() {
return Optional.empty();
}
+ private static String IN_MS_STR = "_in_ms";
+ private static int IN_MS_STR_LENGTH = IN_MS_STR.length();
+ private static String ENABLE_STR = "enable_";
+ private static int ENABLE_STR_LENGTH = ENABLE_STR.length();
+ private static String IN_KB_STR = "_in_kb";
+ private static int IN_KB_STR_LENGTH = IN_KB_STR.length();
+
+ @SuppressWarnings("unused")
+ private String getConfigKey(String originalKey, Object originalValue,
Version cassandraVersion) {
+
+// At least for now we won't support substitutions on nested keys. This
requires an extra
+// traversal of the string
+// but we'll live with that for now
+if (originalKey.contains(".")) return originalKey;
+if (cassandraVersion.compareTo(Version.V4_1_0) < 0) return originalKey;
+if (originalKey.endsWith(IN_MS_STR))
+ return originalKey.substring(0, originalKey.length() - IN_MS_STR_LENGTH);
+if (originalKey.startsWith(ENABLE_STR))
+ return originalKey.substring(ENABLE_STR_LENGTH) + "_enabled";
+if (originalKey.endsWith(IN_KB_STR))
+ return originalKey.substring(0, originalKey.length() - IN_KB_STR_LENGTH);
+return originalKey;
+ }
+
+ private String getConfigValue(
+ String originalKey, Object originalValue, Version cassandraVersion) {
+
+String originalValueStr = originalValue.toString();
+if (cassandraVersion.compareTo(Version.V4_1_0) < 0) return
originalValueStr;
+if (originalKey.endsWith(IN_MS_STR)) return originalValueStr + "ms";
+if (originalKey.endsWith(IN_KB_STR)) return originalValueStr + "KiB";
+return originalValueStr;
+ }
Review Comment:
Not intended to be an exhaustive set of changes required to support
CASSANDRA-15234. For now I'm just worried about the set of props necessary to
support the current collection of ITs; we can always update this as necessary
if new configs need to be added for future test customization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19292 Enable Jenkins to test against Cassandra 4.1.x [cassandra-java-driver]
absurdfarce commented on code in PR #1924:
URL:
https://github.com/apache/cassandra-java-driver/pull/1924#discussion_r1550411887
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/CcmBridge.java:
##
@@ -236,12 +236,33 @@ public void create() {
Arrays.stream(nodes).mapToObj(n -> "" +
n).collect(Collectors.joining(":")),
Review Comment:
All changes in this file aim to address configuration changes in Cassandra
4.1 brought in by CASSANDRA-15234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19292 Enable Jenkins to test against Cassandra 4.1.x [cassandra-java-driver]
absurdfarce commented on code in PR #1924:
URL:
https://github.com/apache/cassandra-java-driver/pull/1924#discussion_r1550409635
##
integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/SchemaIT.java:
##
@@ -265,6 +265,19 @@ public void should_get_virtual_metadata() {
+ "total bigint,\n"
+ "unit text,\n"
+ "PRIMARY KEY (keyspace_name, table_name, task_id)\n"
+ + "); */",
+ // Cassandra 4.1
+ "/* VIRTUAL TABLE system_views.sstable_tasks (\n"
+ + "keyspace_name text,\n"
+ + "table_name text,\n"
+ + "task_id timeuuid,\n"
+ + "completion_ratio double,\n"
+ + "kind text,\n"
+ + "progress bigint,\n"
+ + "sstables int,\n"
+ + "total bigint,\n"
+ + "unit text,\n"
+ + "PRIMARY KEY (keyspace_name, table_name, task_id)\n"
Review Comment:
Table changed slightly with 4.1.x:
* task_id became a timeuuid
* sstables field was introduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-19292 Enable Jenkins to test against Cassandra 4.1.x [cassandra-java-driver]
absurdfarce opened a new pull request, #1924: URL: https://github.com/apache/cassandra-java-driver/pull/1924 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19182) IR may leak SSTables with pending repair when coming from streaming
[ https://issues.apache.org/jira/browse/CASSANDRA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833728#comment-17833728 ] David Capwell commented on CASSANDRA-19182: --- Ariel unblocked our CI logic, but going to be gone for 2 weeks... when I come back ill try to get this merged... If others wish to merge for me feel free =) > IR may leak SSTables with pending repair when coming from streaming > --- > > Key: CASSANDRA-19182 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19182 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: > ci_summary-trunk-a1010f4101bf259de3f31077540e4f987d5df9c5.html > > Time Spent: 1h 40m > Remaining Estimate: 0h > > There is a race condition where SSTables from streaming may race with pending > repair cleanup in compaction causing us to cleanup the pending repair state > in compaction while the SSTables are being added to it; this leads to IR > failing in the future when those files get selected for repair. > This problem was hard to track down as the in-memory state was wiped, so we > don’t have any details. To better aid these types of investigation we should > make sure the repair vtables get updated when IR session failures are > submitted -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19508) Getting tons of msgs "Failed to get peer certificates for peer /x.x.x.x:45796" when require_client_auth is set to false
[
https://issues.apache.org/jira/browse/CASSANDRA-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833720#comment-17833720
]
Mohammad Aburadeh commented on CASSANDRA-19508:
---
Hi [~jonmeredith] ,
We have been enabling DEBUG logging for several years, it's helpful for us to
investigate in case of any issue.
After, we upgraded to Cassandra 4., we started seeing tons of strange messages
and this is causing two problems:
1- log files are getting full very fast, we usually keep the last 10 log files
( for around 1 week) but now, the log files are rotated many times per day.
This is because our connection to Cassandra are for a short time ( less than 2
seconds).
2- Performance impact due to printing many many messages to the log file.
If you think that it might be needed for migrations, then I would suggest
printing these msgs in TRACE, not DEBUG.
Please let me know what you think.
> Getting tons of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796" when require_client_auth is set to false
> ---
>
> Key: CASSANDRA-19508
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19508
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Encryption
>Reporter: Mohammad Aburadeh
>Assignee: Mohammad Aburadeh
>Priority: Urgent
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We recently upgraded our production clusters from 3.11.15 to 4.1.4. We
> started seeing thousands of msgs "Failed to get peer certificates for peer
> /x.x.x.x:45796". SSL is enabled but require_client_auth is disabled. This is
> causing a huge problem for us because cassandra log files are growing very
> fast as our connections are short live connections, we open more than 1K
> connections per second and they stay live for 1-2 seconds.
> {code:java}
> DEBUG [Native-Transport-Requests-2] 2024-03-31 21:26:38,026
> ServerConnection.java:140 - Failed to get peer certificates for peer
> /172.31.2.23:45796
> javax.net.ssl.SSLPeerUnverifiedException: peer not verified
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine$DefaultOpenSslSession.getPeerCertificateChain(ReferenceCountedOpenSslEngine.java:2414)
> at
> io.netty.handler.ssl.ExtendedOpenSslSession.getPeerCertificateChain(ExtendedOpenSslSession.java:140)
> at
> org.apache.cassandra.transport.ServerConnection.certificates(ServerConnection.java:136)
> at
> org.apache.cassandra.transport.ServerConnection.getSaslNegotiator(ServerConnection.java:120)
> at
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:76)
> at
> org.apache.cassandra.transport.Message$Request.execute(Message.java:255)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:166)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:185)
> at
> org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:212)
> at
> org.apache.cassandra.transport.Dispatcher$RequestProcessor.run(Dispatcher.java:109)
> at
> org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:142)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {code}
> *Our SSL config:*
> {code:java}
> client_encryption_options:
> enabled: true
> keystore: /path/to/keystore
> keystore_password: x
> optional: false
> require_client_auth: false {code}
>
> We should stop throwing this msg when require_client_auth is set to false. Or
> at least it should be logged in TRACE not DEBUG.
> I'm working on preparing a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19428) Clean up KeyRangeIterator classes
[ https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833718#comment-17833718 ] Ekaterina Dimitrova commented on CASSANDRA-19428: - 5.0, fully green: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=C19428-5.0-final trunk, still in progress: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=C19428-trunk-final > Clean up KeyRangeIterator classes > - > > Key: CASSANDRA-19428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19428 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0-rc, 5.x > > Attachments: > Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Remove KeyRangeIterator.current and simplify -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14572) Expose all table metrics in virtual table
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-14572:
Fix Version/s: 5.1
(was: 5.x)
Source Control Link:
https://github.com/apache/cassandra/commit/2e7def7626fe299318e0cf4c2bf8138a6c31e149
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
In addition, all the tests have been verified locally.
I ran the single-node cluster locally and checked all the added virtual tables.
The changes have been merged into the trunk branch.
Thank you everyone for all the reviews and comments.
> Expose all table metrics in virtual table
> -
>
> Key: CASSANDRA-14572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability, Observability/Metrics
>Reporter: Chris Lohfink
>Assignee: Maxim Muzafarov
>Priority: Low
> Labels: virtual-tables
> Fix For: 5.1
>
> Attachments: flight_recording_1270017199_13.jfr, keyspayces_group
> responses times.png, keyspayces_group summary.png, select keyspaces_group by
> string prefix.png, select keyspaces_group compare with wo.png, select
> keyspaces_group without value.png, systemv_views.metrics_dropped_message.png,
> thread_pools benchmark.png
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> While we want a number of virtual tables to display data in a way thats great
> and intuitive like in nodetool. There is also much for being able to expose
> the metrics we have for tooling via CQL instead of JMX. This is more for the
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a
> column for each metric value. Could also use a Map or UDT instead of the
> column based that can be a bit more specific to each metric type. To that end
> there can be a {{metric_type}} column and then a UDT for each metric type
> filled in, or a single value with more of a Map style. I am
> purposing the column type though as with {{ALLOW FILTERING}} it does allow
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see:
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate
> through metrics query on read of virtual table)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-19519:
---
Source Control Link:
https://github.com/apache/cassandra-analytics/commit/cbbf33d001b6f953be5654f00d7dfb54011a7619
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-19519:
---
Status: Ready to Commit (was: Review In Progress)
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-analytics) branch trunk updated: CASSANDRA-19519: Migrate remaining integration tests to the single dtest cluster per class model (#49)
This is an automated email from the ASF dual-hosted git repository.
frankgh pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-analytics.git
The following commit(s) were added to refs/heads/trunk by this push:
new cbbf33d CASSANDRA-19519: Migrate remaining integration tests to the
single dtest cluster per class model (#49)
cbbf33d is described below
commit cbbf33d001b6f953be5654f00d7dfb54011a7619
Author: Francisco Guerrero
AuthorDate: Wed Apr 3 11:08:32 2024 -0700
CASSANDRA-19519: Migrate remaining integration tests to the single dtest
cluster per class model (#49)
Additionally, we remove the usused test framework code after migrating the
tests
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRA-19519
---
.../java/org/apache/cassandra/clients/Sidecar.java | 2 +-
.../distributed/impl/AbstractClusterUtils.java | 41 --
.../testing/CassandraSidecarTestContext.java | 298 ---
.../sidecar/testing/IntegrationTestBase.java | 423 -
.../sidecar/testing/IntegrationTestModule.java | 114 --
.../sidecar/testing/LocalhostResolver.java | 107 ++
.../testing/SharedClusterIntegrationTestBase.java | 15 +-
.../testing/AbstractCassandraTestContext.java | 92 -
.../testing/CassandraIntegrationTest.java | 135 ---
.../cassandra/testing/CassandraTestContext.java| 46 ---
.../cassandra/testing/CassandraTestTemplate.java | 345 -
.../testing/ConfigurableCassandraTestContext.java | 78
.../cassandra/testing/SimpleCassandraVersion.java | 169
.../sidecar/testing/LocalhostResolverTest.java | 4 +-
.../cassandra/analytics/BulkWriteTtlTest.java | 4 +-
.../cassandra/analytics/BulkWriteUdtTest.java | 4 +-
.../cassandra/analytics/IntegrationTestJob.java| 4 +-
.../cassandra/analytics/ResiliencyTestBase.java| 29 +-
.../analytics/SparkBulkWriterSimpleTest.java | 101 +++--
.../analytics/SparkIntegrationTestBase.java| 103 -
.../analytics/SparkJobFailedException.java | 68
.../analytics/TimestampIntegrationTest.java| 104 +++--
22 files changed, 294 insertions(+), 1992 deletions(-)
diff --git
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
index 34835aa..53f092e 100644
---
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
+++
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
@@ -32,9 +32,9 @@ import java.util.stream.Collectors;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import o.a.c.sidecar.client.shaded.common.NodeSettings;
import o.a.c.sidecar.client.shaded.io.vertx.core.Vertx;
import o.a.c.sidecar.client.shaded.io.vertx.core.VertxOptions;
-import o.a.c.sidecar.client.shaded.common.NodeSettings;
import org.apache.cassandra.secrets.SecretsProvider;
import org.apache.cassandra.sidecar.client.HttpClientConfig;
import org.apache.cassandra.sidecar.client.SidecarClient;
diff --git
a/cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/distributed/impl/AbstractClusterUtils.java
b/cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/distributed/impl/AbstractClusterUtils.java
deleted file mode 100644
index 05dd7e2..000
---
a/cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/distributed/impl/AbstractClusterUtils.java
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.cassandra.distributed.impl;
-
-/**
- * Utility class to interact with protected methods in AbstractCluster
- */
-public class AbstractClusterUtils
-{
-private AbstractClusterUtils()
-{
-throw new UnsupportedOperationException("Utility class should not be
instantiated");
-}
-
-/**
- * Creates the instance configuration object for the specified node
- * @param cluster the cluster to which this instance will belong
- * @param nodeNumber the number of
Re: [PR] CASSANDRA-19519: Migrate remaining integration tests to the single dt… [cassandra-analytics]
frankgh merged PR #49: URL: https://github.com/apache/cassandra-analytics/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-19519:
---
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833698#comment-17833698
]
Yifan Cai commented on CASSANDRA-19519:
---
+1
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-dtest) branch trunk updated: Add system_metrics keyspace to default keyspaces list
This is an automated email from the ASF dual-hosted git repository.
mmuzaf pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3b66dcc8 Add system_metrics keyspace to default keyspaces list
3b66dcc8 is described below
commit 3b66dcc870e8d929d81055c95124caf2d36f0ac4
Author: Maxim Muzafarov
AuthorDate: Mon Mar 25 19:02:06 2024 +0100
Add system_metrics keyspace to default keyspaces list
patch by Maxim Muzafarov; reviewed by Chris Lohfink, Stefan Miklosovic for
CASSANDRA-14572
---
cqlsh_tests/test_cqlsh.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/cqlsh_tests/test_cqlsh.py b/cqlsh_tests/test_cqlsh.py
index 012f3442..8a1b03d5 100644
--- a/cqlsh_tests/test_cqlsh.py
+++ b/cqlsh_tests/test_cqlsh.py
@@ -1051,6 +1051,8 @@ CREATE OR REPLACE AGGREGATE test.average(int)
'system_auth', 'system_distributed',
'system_virtual_schema']
if self.cluster.version() >= LooseVersion('5.1'):
expected_keyspaces.append('system_cluster_metadata')
+expected_keyspaces.append('system_metrics')
+
node1, = self.cluster.nodelist()
output, err = self.run_cqlsh(node1, "DESCRIBE KEYSPACES")
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19515) unhandled exception handling in jvm dtest may see errors from other clusters
[ https://issues.apache.org/jira/browse/CASSANDRA-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833697#comment-17833697 ] David Capwell commented on CASSANDRA-19515: --- going to avoid back porting to 4.0 as "ShutdownExecutor shutdownExecutor" is missing > unhandled exception handling in jvm dtest may see errors from other clusters > > > Key: CASSANDRA-19515 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19515 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > From time to time we see tests failing with unexpected errors during close, > but this shouldn’t be possible because we ignore errors for instances that > are shutting down…. In debugging it turns out that the errors are from > different clusters, so we add to the unexpected error list even though it’s > not from this cluster! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19515) unhandled exception handling in jvm dtest may see errors from other clusters
[ https://issues.apache.org/jira/browse/CASSANDRA-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-19515: -- Reviewers: Blake Eggleston (was: Blake Eggleston, David Capwell) > unhandled exception handling in jvm dtest may see errors from other clusters > > > Key: CASSANDRA-19515 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19515 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > From time to time we see tests failing with unexpected errors during close, > but this shouldn’t be possible because we ignore errors for instances that > are shutting down…. In debugging it turns out that the errors are from > different clusters, so we add to the unexpected error list even though it’s > not from this cluster! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19515) unhandled exception handling in jvm dtest may see errors from other clusters
[ https://issues.apache.org/jira/browse/CASSANDRA-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-19515: -- Status: Ready to Commit (was: Review In Progress) +1 in GH > unhandled exception handling in jvm dtest may see errors from other clusters > > > Key: CASSANDRA-19515 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19515 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > From time to time we see tests failing with unexpected errors during close, > but this shouldn’t be possible because we ignore errors for instances that > are shutting down…. In debugging it turns out that the errors are from > different clusters, so we add to the unexpected error list even though it’s > not from this cluster! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19515) unhandled exception handling in jvm dtest may see errors from other clusters
[ https://issues.apache.org/jira/browse/CASSANDRA-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-19515: -- Reviewers: Blake Eggleston, David Capwell Status: Review In Progress (was: Patch Available) > unhandled exception handling in jvm dtest may see errors from other clusters > > > Key: CASSANDRA-19515 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19515 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: NA > > Time Spent: 20m > Remaining Estimate: 0h > > From time to time we see tests failing with unexpected errors during close, > but this shouldn’t be possible because we ignore errors for instances that > are shutting down…. In debugging it turns out that the errors are from > different clusters, so we add to the unexpected error list even though it’s > not from this cluster! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833695#comment-17833695
]
Francisco Guerrero commented on CASSANDRA-19519:
Green CI:
https://app.circleci.com/pipelines/github/frankgh/cassandra-analytics/162/workflows/5cab9129-f5f9-4a0c-b5dc-ff6a38fe8cb0
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-19519:
---
Test and Documentation Plan: Migrated existed tests to the single cluster
per test model
Status: Patch Available (was: In Progress)
PR: https://github.com/apache/cassandra-analytics/pull/49
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-19519: Migrate remaining integration tests to the single dt… [cassandra-analytics]
frankgh opened a new pull request, #49: URL: https://github.com/apache/cassandra-analytics/pull/49 …est cluster per class model Additionally, we remove the usused test framework code after migrating the tests Patch by Francisco Guerrero; Reviewed by TBD for CASSANDRA-19519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-19519:
---
Change Category: Semantic
Complexity: Normal
Fix Version/s: NA
Status: Open (was: Triage Needed)
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
> Fix For: NA
>
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19519) [Analytics] Migrate remaining integration tests to the single dtest cluster per class model
[
https://issues.apache.org/jira/browse/CASSANDRA-19519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-19519:
---
Labels: test-framework (was: )
> [Analytics] Migrate remaining integration tests to the single dtest cluster
> per class model
> ---
>
> Key: CASSANDRA-19519
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19519
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: test-framework
>
> In https://issues.apache.org/jira/browse/CASSANDRA-19251, the majority of the
> tests were moved to the single in-jvm dtest cluster per class. There are a
> few remaining tests that are still using the {{CassandraIntegrationTest}}
> annotation. However, we'd like to consolidate in a single approach for
> testing for the following reasons:
> # Consolidate testing code in a single place to reduce maintenance burden
> whenever we are touching the testing framework code
> # Have a unique and consistent developer experience for integration tests
> As part of this effort, we can remove the unused code left from the refactor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
