[jira] [Commented] (CASSANDRA-11720) Changing `max_hint_window_in_ms` at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002485#comment-16002485 ] Hiroyuki Nishi commented on CASSANDRA-11720: [~michaelsembwever] Looks good. I appreciate your response to update the patch and add the dtest! > Changing `max_hint_window_in_ms` at runtime > --- > > Key: CASSANDRA-11720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11720 > Project: Cassandra > Issue Type: Wish > Components: Coordination >Reporter: Jens Rantil >Assignee: Hiroyuki Nishi >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-11720-trunk.patch > > > Scenario: A larger node (in terms of data it holds) goes down. You realize > that it will take slightly more than `max_hint_window_in_ms` to fix it. You > have a the disk space to store some additional hints. > Proposal: Support changing `max_hint_window_in_ms` at runtime. The change > doesn't have to be persisted somewhere. I'm thinking similar to changing the > `compactionthroughput` etc. using `nodetool`. > Workaround: Change the value in the configuration file and do a rolling > restart of all the nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11720) Changing `max_hint_window_in_ms` at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994151#comment-15994151 ] Hiroyuki Nishi commented on CASSANDRA-11720: [~michaelsembwever] I'm sorry that you are confused in my English. Thank you for updating the patch. I would like to modify the description of setmaxhintwindow additionally as follows. https://github.com/yhnishi/cassandra/commit/437c659f13ad430c3cff260aa94ea3f706e464f5 Please let me know what you think. > Changing `max_hint_window_in_ms` at runtime > --- > > Key: CASSANDRA-11720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11720 > Project: Cassandra > Issue Type: Wish > Components: Coordination >Reporter: Jens Rantil >Assignee: Hiroyuki Nishi >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-11720-trunk.patch > > > Scenario: A larger node (in terms of data it holds) goes down. You realize > that it will take slightly more than `max_hint_window_in_ms` to fix it. You > have a the disk space to store some additional hints. > Proposal: Support changing `max_hint_window_in_ms` at runtime. The change > doesn't have to be persisted somewhere. I'm thinking similar to changing the > `compactionthroughput` etc. using `nodetool`. > Workaround: Change the value in the configuration file and do a rolling > restart of all the nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11720) Changing `max_hint_window_in_ms` at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992558#comment-15992558 ] Hiroyuki Nishi commented on CASSANDRA-11720: [~michaelsembwever] I am very sorry for the late reply... I think that i will implement the above correspondence, how is it? > Changing `max_hint_window_in_ms` at runtime > --- > > Key: CASSANDRA-11720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11720 > Project: Cassandra > Issue Type: Wish > Components: Coordination >Reporter: Jens Rantil >Assignee: Hiroyuki Nishi >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-11720-trunk.patch > > > Scenario: A larger node (in terms of data it holds) goes down. You realize > that it will take slightly more than `max_hint_window_in_ms` to fix it. You > have a the disk space to store some additional hints. > Proposal: Support changing `max_hint_window_in_ms` at runtime. The change > doesn't have to be persisted somewhere. I'm thinking similar to changing the > `compactionthroughput` etc. using `nodetool`. > Workaround: Change the value in the configuration file and do a rolling > restart of all the nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11720) Changing `max_hint_window_in_ms` at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-11720: --- Status: Patch Available (was: Open) > Changing `max_hint_window_in_ms` at runtime > --- > > Key: CASSANDRA-11720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11720 > Project: Cassandra > Issue Type: Wish > Components: Coordination >Reporter: Jens Rantil >Priority: Minor > Labels: lhf > Attachments: CASSANDRA-11720-trunk.patch > > > Scenario: A larger node (in terms of data it holds) goes down. You realize > that it will take slightly more than `max_hint_window_in_ms` to fix it. You > have a the disk space to store some additional hints. > Proposal: Support changing `max_hint_window_in_ms` at runtime. The change > doesn't have to be persisted somewhere. I'm thinking similar to changing the > `compactionthroughput` etc. using `nodetool`. > Workaround: Change the value in the configuration file and do a rolling > restart of all the nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11720) Changing `max_hint_window_in_ms` at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490546#comment-15490546
]
Hiroyuki Nishi commented on CASSANDRA-11720:
Hello,
I fixed this issue. Below is a sample result.
{code}
$ ./bin/nodetool getmaxhintwindow
Current max hint window: 1080 ms
$ ./bin/nodetool setmaxhintwindow 0
$ ./bin/nodetool getmaxhintwindow
Current max hint window: 0 ms
{code}
Could someone review the attached patch?
I worked in trunk branch.
Thank you.
> Changing `max_hint_window_in_ms` at runtime
> ---
>
> Key: CASSANDRA-11720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11720
> Project: Cassandra
> Issue Type: Wish
> Components: Coordination
>Reporter: Jens Rantil
>Priority: Minor
> Labels: lhf
> Attachments: CASSANDRA-11720-trunk.patch
>
>
> Scenario: A larger node (in terms of data it holds) goes down. You realize
> that it will take slightly more than `max_hint_window_in_ms` to fix it. You
> have a the disk space to store some additional hints.
> Proposal: Support changing `max_hint_window_in_ms` at runtime. The change
> doesn't have to be persisted somewhere. I'm thinking similar to changing the
> `compactionthroughput` etc. using `nodetool`.
> Workaround: Change the value in the configuration file and do a rolling
> restart of all the nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11720) Changing `max_hint_window_in_ms` at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-11720: --- Attachment: CASSANDRA-11720-trunk.patch > Changing `max_hint_window_in_ms` at runtime > --- > > Key: CASSANDRA-11720 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11720 > Project: Cassandra > Issue Type: Wish > Components: Coordination >Reporter: Jens Rantil >Priority: Minor > Labels: lhf > Attachments: CASSANDRA-11720-trunk.patch > > > Scenario: A larger node (in terms of data it holds) goes down. You realize > that it will take slightly more than `max_hint_window_in_ms` to fix it. You > have a the disk space to store some additional hints. > Proposal: Support changing `max_hint_window_in_ms` at runtime. The change > doesn't have to be persisted somewhere. I'm thinking similar to changing the > `compactionthroughput` etc. using `nodetool`. > Workaround: Change the value in the configuration file and do a rolling > restart of all the nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12174) COPY FROM should raise error for non-existing input files
[
https://issues.apache.org/jira/browse/CASSANDRA-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395116#comment-15395116
]
Hiroyuki Nishi commented on CASSANDRA-12174:
Thank you for your review!
> COPY FROM should raise error for non-existing input files
> -
>
> Key: CASSANDRA-12174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12174
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Stefan Podkowinski
>Assignee: Hiroyuki Nishi
>Priority: Minor
> Labels: cqlsh, lhf
> Fix For: 3.10
>
> Attachments: CASSANDRA-12174-trunk.patch
>
>
> Currently the CSV COPY FROM command will not raise any error for non-existing
> paths. Instead only "0 rows imported" will be shown as result.
> As the COPY FROM command is often used for tutorials and getting started
> guides, I'd suggest to give a clear error message in case of a missing input
> file. Without such error it can be confusing for the user to see the command
> actually finish, without any clues why no rows have been imported.
> {noformat}
> CREATE KEYSPACE test
> WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'datacenter1' : 1
> };
> USE test;
> CREATE TABLE airplanes (
> name text PRIMARY KEY,
> manufacturer ascii,
> year int,
> mach float
> );
> COPY airplanes (name, manufacturer, year, mach) FROM '/tmp/1234-doesnotexist';
> Using 3 child processes
> Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
> Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
> 0 rows imported from 0 files in 0.216 seconds (0 skipped).
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12174) COPY FROM should raise error for non-existing input files
[
https://issues.apache.org/jira/browse/CASSANDRA-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391869#comment-15391869
]
Hiroyuki Nishi commented on CASSANDRA-12174:
Hi [~Stefania],
Thanks for your response.
I changed the patch as the following.
https://github.com/yhnishi/cassandra/commit/db75d9dd0d74d3476d500f6b99c22e117dc73ec6
Below is sample results.
Success:
{code}
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM '/tmp/1.csv';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Processed: 1 rows; Rate: 2 rows/s; Avg. rate: 2 rows/s
1 rows imported from 1 files in 0.420 seconds (0 skipped).
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM
'/tmp/1.csv,/tmp/2.csv';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Processed: 2 rows; Rate: 3 rows/s; Avg. rate: 5 rows/s
2 rows imported from 2 files in 0.418 seconds (0 skipped).
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM '/tmp/*.csv';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Processed: 2 rows; Rate: 3 rows/s; Avg. rate: 5 rows/s
2 rows imported from 2 files in 0.413 seconds (0 skipped).
{code}
Error:
{code}
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM
'/tmp/1234-doesnotexist';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Failed to import 0 rows: IOError - Can't open '/tmp/1234-doesnotexist' for
reading: file does not exist, given up after 1 attempts
Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
0 rows imported from 0 files in 0.218 seconds (0 skipped).
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM
'/tmp/*-doesnotexist';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Failed to import 0 rows: IOError - Can't open '/tmp/*-doesnotexist' for
reading: file does not exist, given up after 1 attempts
Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
0 rows imported from 0 files in 0.218 seconds (0 skipped).
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM
'/tmp/1234-doesnotexist,/tmp/1235-doesnotexist';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Failed to import 0 rows: IOError - Can't open '/tmp/1234-doesnotexist' for
reading: file does not exist, given up after 1 attempts
Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
0 rows imported from 0 files in 0.217 seconds (0 skipped).
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM
'/tmp/1.csv,/tmp/*-doesnotexist';
Using 7 child processes
Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
Failed to import 0 rows: IOError - Can't open '/tmp/*-doesnotexist' for
reading: file does not exist, given up after 1 attempts
Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
0 rows imported from 1 files in 0.219 seconds (0 skipped).
{code}
Please check the patch once again.
> COPY FROM should raise error for non-existing input files
> -
>
> Key: CASSANDRA-12174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12174
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Stefan Podkowinski
>Assignee: Hiroyuki Nishi
>Priority: Minor
> Labels: lhf
> Attachments: CASSANDRA-12174-trunk.patch
>
>
> Currently the CSV COPY FROM command will not raise any error for non-existing
> paths. Instead only "0 rows imported" will be shown as result.
> As the COPY FROM command is often used for tutorials and getting started
> guides, I'd suggest to give a clear error message in case of a missing input
> file. Without such error it can be confusing for the user to see the command
> actually finish, without any clues why no rows have been imported.
> {noformat}
> CREATE KEYSPACE test
> WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'datacenter1' : 1
> };
> USE test;
> CREATE TABLE airplanes (
> name text PRIMARY KEY,
> manufacturer ascii,
> year int,
> mach float
> );
> COPY airplanes (name, manufacturer, year, mach) FROM '/tmp/1234-doesnotexist';
> Using 3 child processes
> Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
> Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
> 0 rows imported from 0 files in 0.216 seconds (0 skipped).
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12174) COPY FROM should raise error for non-existing input files
[
https://issues.apache.org/jira/browse/CASSANDRA-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389270#comment-15389270
]
Hiroyuki Nishi commented on CASSANDRA-12174:
Hello,
I fixed this issue. Below is a sample result.
{code}
cqlsh> COPY test.airplanes (name, manufacturer, year, mach) FROM
'/tmp/1234-doesnotexist';
Could not open /tmp/1234-doesnotexist for import: file does not exist.
{code}
Could someone review the attached patch?
I worked in trunk branch.
Thank you.
> COPY FROM should raise error for non-existing input files
> -
>
> Key: CASSANDRA-12174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12174
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Stefan Podkowinski
>Priority: Minor
> Labels: lhf
> Attachments: CASSANDRA-12174-trunk.patch
>
>
> Currently the CSV COPY FROM command will not raise any error for non-existing
> paths. Instead only "0 rows imported" will be shown as result.
> As the COPY FROM command is often used for tutorials and getting started
> guides, I'd suggest to give a clear error message in case of a missing input
> file. Without such error it can be confusing for the user to see the command
> actually finish, without any clues why no rows have been imported.
> {noformat}
> CREATE KEYSPACE test
> WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'datacenter1' : 1
> };
> USE test;
> CREATE TABLE airplanes (
> name text PRIMARY KEY,
> manufacturer ascii,
> year int,
> mach float
> );
> COPY airplanes (name, manufacturer, year, mach) FROM '/tmp/1234-doesnotexist';
> Using 3 child processes
> Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
> Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
> 0 rows imported from 0 files in 0.216 seconds (0 skipped).
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12174) COPY FROM should raise error for non-existing input files
[
https://issues.apache.org/jira/browse/CASSANDRA-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hiroyuki Nishi updated CASSANDRA-12174:
---
Attachment: CASSANDRA-12174-trunk.patch
> COPY FROM should raise error for non-existing input files
> -
>
> Key: CASSANDRA-12174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12174
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Stefan Podkowinski
>Priority: Minor
> Labels: lhf
> Attachments: CASSANDRA-12174-trunk.patch
>
>
> Currently the CSV COPY FROM command will not raise any error for non-existing
> paths. Instead only "0 rows imported" will be shown as result.
> As the COPY FROM command is often used for tutorials and getting started
> guides, I'd suggest to give a clear error message in case of a missing input
> file. Without such error it can be confusing for the user to see the command
> actually finish, without any clues why no rows have been imported.
> {noformat}
> CREATE KEYSPACE test
> WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'datacenter1' : 1
> };
> USE test;
> CREATE TABLE airplanes (
> name text PRIMARY KEY,
> manufacturer ascii,
> year int,
> mach float
> );
> COPY airplanes (name, manufacturer, year, mach) FROM '/tmp/1234-doesnotexist';
> Using 3 child processes
> Starting copy of test.airplanes with columns [name, manufacturer, year, mach].
> Processed: 0 rows; Rate: 0 rows/s; Avg. rate: 0 rows/s
> 0 rows imported from 0 files in 0.216 seconds (0 skipped).
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379056#comment-15379056 ] Hiroyuki Nishi commented on CASSANDRA-12035: [~ifesdjeen] +1 from my side, too. I appreciate your kind response! > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json, > tablestats_result.txt, tablestats_result.yaml, tpstats_output.yaml, > tpstats_result.json, tpstats_result.txt, tpstats_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374715#comment-15374715 ] Hiroyuki Nishi commented on CASSANDRA-12035: Hi [~ifesdjeen], Thank you for your review and refactoring! I take another look at this code. https://github.com/ifesdjeen/cassandra/commit/a46ea376f02245428d05c9fb47488102babde4a6 Thereby, I have one question. I could not understand the necessity of toString() on below line. https://github.com/ifesdjeen/cassandra/blob/12035-trunk/src/java/org/apache/cassandra/tools/nodetool/stats/TpStatsHolder.java#L48 I don't think I have another problems. > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json, > tablestats_result.txt, tablestats_result.yaml, tpstats_output.yaml, > tpstats_result.json, tpstats_result.txt, tpstats_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367694#comment-15367694 ] Hiroyuki Nishi commented on CASSANDRA-12035: Hi [~ifesdjeen], Thank you for your review and feedback! I think so. I tried refactor DefaultPrinter on TpStatsPrinter as the following. https://github.com/yhnishi/cassandra/commit/cbdead281acf135fdcc66464ad3a7bfc1fd881d2 Is this what you mean by your suggestion? > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json, > tablestats_result.txt, tablestats_result.yaml, tpstats_result.json, > tpstats_result.txt, tpstats_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358609#comment-15358609 ] Hiroyuki Nishi commented on CASSANDRA-12035: Hi [~ifesdjeen], Thanks for your response. I tried to re-create the patch with latest trunk. Please check the patch once again. > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json, > tablestats_result.txt, tablestats_result.yaml, tpstats_result.json, > tpstats_result.txt, tpstats_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: tpstats_result.yaml tpstats_result.txt tpstats_result.json tablestats_result.yaml tablestats_result.txt tablestats_result.json CASSANDRA-12035-trunk.patch > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json, > tablestats_result.txt, tablestats_result.yaml, tpstats_result.json, > tpstats_result.txt, tpstats_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: tablestats_sample_result.yaml) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: tpstats_sample_result.txt) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: tpstats_sample_result.json) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: tablestats_sample_result.json) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: tablestats_sample_result.txt) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: tpstats_sample_result.yaml) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: (was: CASSANDRA-12035-trunk.patch) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: tablestats_sample_result.json, > tablestats_sample_result.txt, tablestats_sample_result.yaml, > tpstats_sample_result.json, tpstats_sample_result.txt, > tpstats_sample_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Status: Patch Available (was: Open) > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Assignee: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, > tablestats_sample_result.json, tablestats_sample_result.txt, > tablestats_sample_result.yaml, tpstats_sample_result.json, > tpstats_sample_result.txt, tpstats_sample_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341265#comment-15341265 ] Hiroyuki Nishi commented on CASSANDRA-12035: Unfortunately, I don't seem to have permissions to assign ticket in JIRA. Could you assign this ticket to me or grant me permission to do so? > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, > tablestats_sample_result.json, tablestats_sample_result.txt, > tablestats_sample_result.yaml, tpstats_sample_result.json, > tpstats_sample_result.txt, tpstats_sample_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroyuki Nishi updated CASSANDRA-12035: --- Attachment: tablestats_sample_result.yaml tablestats_sample_result.json tablestats_sample_result.txt tpstats_sample_result.yaml tpstats_sample_result.json tpstats_sample_result.txt CASSANDRA-12035-trunk.patch > Structure for tpstats output (JSON, YAML) > - > > Key: CASSANDRA-12035 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Hiroyuki Nishi >Priority: Minor > Attachments: CASSANDRA-12035-trunk.patch, > tablestats_sample_result.json, tablestats_sample_result.txt, > tablestats_sample_result.yaml, tpstats_sample_result.json, > tpstats_sample_result.txt, tpstats_sample_result.yaml > > > In CASSANDRA-5977, some extra output formats such as JSON and YAML were added > for nodetool tablestats. > Similarly, I would like to add the output formats in nodetool tpstats. > Also, I tried to refactor the tablestats's code about the output formats to > integrate the existing code with my code. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12035) Structure for tpstats output (JSON, YAML)
Hiroyuki Nishi created CASSANDRA-12035: -- Summary: Structure for tpstats output (JSON, YAML) Key: CASSANDRA-12035 URL: https://issues.apache.org/jira/browse/CASSANDRA-12035 Project: Cassandra Issue Type: Improvement Components: Tools Reporter: Hiroyuki Nishi Priority: Minor In CASSANDRA-5977, some extra output formats such as JSON and YAML were added for nodetool tablestats. Similarly, I would like to add the output formats in nodetool tpstats. Also, I tried to refactor the tablestats's code about the output formats to integrate the existing code with my code. Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
