[
https://issues.apache.org/jira/browse/CASSANDRA-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374715#comment-15374715
]
Hiroyuki Nishi commented on CASSANDRA-12035:
--------------------------------------------
Hi [~ifesdjeen],
Thank you for your review and refactoring!
I take another look at this code.
https://github.com/ifesdjeen/cassandra/commit/a46ea376f02245428d05c9fb47488102babde4a6
Thereby, I have one question. I could not understand the necessity of
toString() on below line.
https://github.com/ifesdjeen/cassandra/blob/12035-trunk/src/java/org/apache/cassandra/tools/nodetool/stats/TpStatsHolder.java#L48
I don't think I have another problems.
> Structure for tpstats output (JSON, YAML)
> -----------------------------------------
>
> Key: CASSANDRA-12035
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12035
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Hiroyuki Nishi
> Assignee: Hiroyuki Nishi
> Priority: Minor
> Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json,
> tablestats_result.txt, tablestats_result.yaml, tpstats_output.yaml,
> tpstats_result.json, tpstats_result.txt, tpstats_result.yaml
>
>
> In CASSANDRA-5977, some extra output formats such as JSON and YAML were added
> for nodetool tablestats.
> Similarly, I would like to add the output formats in nodetool tpstats.
> Also, I tried to refactor the tablestats's code about the output formats to
> integrate the existing code with my code.
> Please review the attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
