[jira] [Updated] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu updated CASSANDRA-18529: --- Status: Review In Progress (was: Changes Suggested) > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc, signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752434#comment-17752434 ] Timothy Tu commented on CASSANDRA-18529: [~brandon.williams] Not sure why the build failed, but it seems to be a Docker issue? > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc, signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752427#comment-17752427 ] Timothy Tu commented on CASSANDRA-18529: [~smiklosovic] Thank you for bringing that up, just fixed and updated. [~brandon.williams] Can we run Cl one last time? > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc, signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752106#comment-17752106 ] Timothy Tu commented on CASSANDRA-18529: [~smiklosovic] I added the compatibility. [~brandon.williams] can we run the Cl again? > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc, signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751213#comment-17751213 ] Timothy Tu commented on CASSANDRA-18529: We simply removed "cql3" and "native" which are pretty obsolete. There was no alternative to "cql3", specifying was redundant and confusing to users. "native" was also +very+ confusing becuase it was simply using the Java driver and to understand why it was there, you had to understand the internal "simplenative" driver, which is rarely, if ever used by users. No change to output formats. Original: cassandra-stress write n=2 -mode cql3 simplenative cassandra-stress write n=2 -mode cql3 native user=cassandra password=cassandra New: cassandra-stress write n=2 -mode simplenative cassandra-stress write n=2 -mode user=cassandra password=cassandra What we can do for compatibility is catch the old arguments ("cql3", "native") and show a warning message that they are obsolete and in the future will no longer be suported. We also removed "legacy" option which was undocumented and gave fair warning that it was to be removed by its name "legacy" since version 2.1. > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750476#comment-17750476 ] Timothy Tu commented on CASSANDRA-18529: [~brandon.williams] sorry about that, I was not compiling the right things on my end. Should work now. > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750335#comment-17750335 ] Timothy Tu commented on CASSANDRA-18529: [~brandon.williams] ,[~smiklosovic] does this look good or are there concerns? > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747663#comment-17747663 ] Timothy Tu commented on CASSANDRA-18529: https://github.com/apache/cassandra/pull/2522 > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode native cql3 user=cassandra password=xx > can be simplified to: > -mode user=cassandra password=xx > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738746#comment-17738746 ] Timothy Tu edited comment on CASSANDRA-18529 at 7/26/23 8:21 PM: - I will look at the prepared statement problem, but that should be a separate Jira. Removing legacy options here will eliminate ~400 lines of code. was (Author: JIRAUSER300775): I will look at the prepared statement problem > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18661) Update to cassandra-stress to use Apache Commons CLI
[ https://issues.apache.org/jira/browse/CASSANDRA-18661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18661: -- Assignee: (was: Timothy Tu) > Update to cassandra-stress to use Apache Commons CLI > > > Key: CASSANDRA-18661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18661 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Priority: Normal > > The Apache Commons CLI library provides an API for parsing command line > options with the package org.apache.commons.cli and this is already used by a > dozen of existing Cassandra utilities including: > {quote}SSTableMetadataViewer, StandaloneScrubber, StandaloneSplitter, > SSTableExport, BulkLoader, and others. > {quote} > However, cassandra-stress is an outlier which uses its own custom classes to > parse command line options with classes such as OptionsSimple. In addition, > the options syntax for username, password, and others are not aligned with > the format used by CQLSH. > > This suggestion is to: > > a) Upgrade cassandra-stress to use Apache Commons CLI (no new dependencies > are required as this library is already used by the project) > > b) Align the cassandra-stress CLI options with those in CQLSH, > > {quote}For example, using the new syntax like CQLSH: > {quote} > > cassandra-stress -username foo -password bar > {quote} > and replacing the old syntax: > {quote} > cassandra-stress -mode username=foo and password=bar > > This will simplify and unify the code base, eliminate code and reduce the > confusion between similar named classes such as > org.apache.cassandra.stress.settings.\{Option, OptionsMulti, OptionsSimple} > and org.apache.commons.cli.{Option, OptionGroup, Options) > > Note: documentation will need to be updated as well -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743890#comment-17743890 ] Timothy Tu commented on CASSANDRA-18659: Updated commit > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743220#comment-17743220 ] Timothy Tu commented on CASSANDRA-18659: Also should there be a readme somewhere documenting how to run these tests? > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743217#comment-17743217 ] Timothy Tu commented on CASSANDRA-18659: [~brandon.williams] I found the problem, it was line wrapping that had changed in 1.5.0, so I reformatted the tests around this. Also added a -h option for sstablemetadata. > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659 ] Timothy Tu deleted comment on CASSANDRA-18659: was (Author: JIRAUSER300775): I reviewed it (changes-report link above), but did not see anything regarding changes to default -h option. > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742179#comment-17742179 ] Timothy Tu commented on CASSANDRA-18659: I reviewed it (changes-report link above), but did not see anything regarding changes to default -h option. > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18661) Update to cassandra-stress to use Apache Commons CLI
[ https://issues.apache.org/jira/browse/CASSANDRA-18661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18661: -- Assignee: Timothy Tu > Update to cassandra-stress to use Apache Commons CLI > > > Key: CASSANDRA-18661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18661 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Normal > > The Apache Commons CLI library provides an API for parsing command line > options with the package org.apache.commons.cli and this is already used by a > dozen of existing Cassandra utilities including: > {quote}SSTableMetadataViewer, StandaloneScrubber, StandaloneSplitter, > SSTableExport, BulkLoader, and others. > {quote} > However, cassandra-stress is an outlier which uses its own custom classes to > parse command line options with classes such as OptionsSimple. In addition, > the options syntax for username, password, and others are not aligned with > the format used by CQLSH. > > This suggestion is to: > > a) Upgrade cassandra-stress to use Apache Commons CLI (no new dependencies > are required as this library is already used by the project) > > b) Align the cassandra-stress CLI options with those in CQLSH, > > {quote}For example, using the new syntax like CQLSH: > {quote} > > cassandra-stress -username foo -password bar > {quote} > and replacing the old syntax: > {quote} > cassandra-stress -mode username=foo and password=bar > > This will simplify and unify the code base, eliminate code and reduce the > confusion between similar named classes such as > org.apache.cassandra.stress.settings.\{Option, OptionsMulti, OptionsSimple} > and org.apache.commons.cli.{Option, OptionGroup, Options) > > Note: documentation will need to be updated as well -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu updated CASSANDRA-18659: --- Test and Documentation Plan: Updated commons cli from 1.1 to 1.5.0, verified by running sstablesplit, sstablemetadata, and sstabledump. Status: Patch Available (was: In Progress) > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18659: -- Assignee: Timothy Tu > Upgrade apache commons cli to 1.5.0 > --- > > Key: CASSANDRA-18659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > > Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
Timothy Tu created CASSANDRA-18659: -- Summary: Upgrade apache commons cli to 1.5.0 Key: CASSANDRA-18659 URL: https://issues.apache.org/jira/browse/CASSANDRA-18659 Project: Cassandra Issue Type: Improvement Reporter: Timothy Tu Upgrade apache commons cli to 1.1 (July 2007) to 1.5.0 (October 2021). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741034#comment-17741034 ] Timothy Tu commented on CASSANDRA-18639: Total Partitions is just the Counts all summed togethor as shown below: Total Partitions: 24306 Size (bytes) | Count (%) Histogram 35 (35 B) | 1 ( 0) 42 (42 B) | 98 ( 0) 50 (50 B) | 24207 ( 99) OO > Add duration and partition key count to sstablemetadata > --- > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The new additions will output metadata information for: > * Partition Key Count > * Duration > Partition key count is the total number of partitions in the sstable.. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}{{Total partitions: 2430}} > {{Total rows: 8000}} > {{Total column set: 10}} > {{...}} > {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}} > {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}} > {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}} > {quote} > The online docs in sstablemetadata.adoc will need to be updated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740755#comment-17740755 ] Timothy Tu commented on CASSANDRA-18639: I have updated the commit with the try statement hopefully it works now. > Add duration and partition key count to sstablemetadata > --- > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The new -m option will output metadata information for: > * Partition Key Count > * Duration > Partition key count is the total number of partitions in the sstable.. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}{{Total partitions: 2430}} > {{Total rows: 8000}} > {{Total column set: 10}} > {{...}} > {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}} > {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}} > {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}} > {quote} > The online docs in sstablemetadata.adoc will need to be updated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740697#comment-17740697 ] Timothy Tu commented on CASSANDRA-18639: [~brandon.williams] I added the close() should be all good now. > Add duration and partition key count to sstablemetadata > --- > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The new -m option will output metadata information for: > * Partition Key Count > * Duration > Partition key count is the total number of partitions in the sstable.. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}{{Total partitions: 2430}} > {{Total rows: 8000}} > {{Total column set: 10}} > {{...}} > {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}} > {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}} > {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}} > {quote} > The online docs in sstablemetadata.adoc will need to be updated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu updated CASSANDRA-18639: --- Impacts: Docs (was: None) Test and Documentation Plan: Injected mock data and validated output Added updated documentation for various options and updated output Status: Patch Available (was: Open) > Add duration and partition key count to sstablemetadata > --- > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The new -m option will output metadata information for: > * Partition Key Count > * Duration > Partition key count is the total number of partitions in the sstable.. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}{{Total partitions: 2430}} > {{Total rows: 8000}} > {{Total column set: 10}} > {{...}} > {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}} > {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}} > {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}} > {quote} > The online docs in sstablemetadata.adoc will need to be updated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add a metadata option to sstabledump
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738755#comment-17738755 ] Timothy Tu commented on CASSANDRA-18639: [~brandon.williams] that’s a good point, perhaps instead the suggested improvement should be to sstablemetadata * add Duration and Total Partitions to sstablemetadata > Add a metadata option to sstabledump > > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > > The new -m option will output metadata information for: > * Partition Key Count > * SSTable Level > * Droppable Tombstones (%age) > * Min Timestamp > * Max Timestamp > * Duration > Partition key count is the total number of partitions in the sstable. Level > is zero for STCS and TWC, and varies for LTCS. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}Partition Key Count: 24306 > Droppable Tombstones: 1000.0 (0.01%) > SSTable Level: 1 > Min Timestamp: 06/28/2023 15:15:04 > Max Timestamp: 06/28/2023 15:15:58 > Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738746#comment-17738746 ] Timothy Tu commented on CASSANDRA-18529: I will look at the prepared statement problem > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18529: -- Assignee: Timothy Tu > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18639) Add a metadata option to sstabledump
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18639: -- Assignee: Timothy Tu > Add a metadata option to sstabledump > > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > > The new -m option will output metadata information for: > * Partition Key Count > * SSTable Level > * Droppable Tombstones (%age) > * Min Timestamp > * Max Timestamp > * Duration > Partition key count is the total number of partitions in the sstable. Level > is zero for STCS and TWC, and varies for LTCS. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}Partition Key Count: 24306 > Droppable Tombstones: 1000.0 (0.01%) > SSTable Level: 1 > Min Timestamp: 06/28/2023 15:15:04 > Max Timestamp: 06/28/2023 15:15:58 > Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18639) Add a metadata option to sstabledump
Timothy Tu created CASSANDRA-18639: -- Summary: Add a metadata option to sstabledump Key: CASSANDRA-18639 URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 Project: Cassandra Issue Type: Improvement Components: Tool/sstable Reporter: Timothy Tu The new -m option will output metadata information for: * Partition Key Count * SSTable Level * Droppable Tombstones (%age) * Min Timestamp * Max Timestamp * Duration Partition key count is the total number of partitions in the sstable. Level is zero for STCS and TWC, and varies for LTCS. For Time Window Compaction (TWC), the min and max timestamps together with duration describe the bounds of the time window in the table. {quote}Partition Key Count: 24306 Droppable Tombstones: 1000.0 (0.01%) SSTable Level: 1 Min Timestamp: 06/28/2023 15:15:04 Max Timestamp: 06/28/2023 15:15:58 Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org