[jira] [Comment Edited] (CASSANDRA-12733) Throw an exception if there is a prepared statement id hash conflict.
[
https://issues.apache.org/jira/browse/CASSANDRA-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564760#comment-15564760
]
Alex Petrov edited comment on CASSANDRA-12733 at 10/11/16 9:36 AM:
---
CI looks good now (had to re-run trunk from my fork, although code is
identical). Also, {{CHANGES}} file is updated for 3.X (also, merges cleanly to
trunk).
|[3.X |https://github.com/ifesdjeen/cassandra/tree/12733-3.X]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-dtest/]
|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|
|[trunk|https://github.com/ifesdjeen/cassandra/tree/12733-trunk]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-dtest/]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|
was (Author: ifesdjeen):
CI looks good now (had to re-run trunk from my fork, although code is
identical). Also, {{CHANGES}} file is updated for 3.X (also, merges cleanly to
trunk).
|[3.X |https://github.com/ifesdjeen/cassandra/tree/12733-3.X]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|
|[trunk|https://github.com/ifesdjeen/cassandra/tree/12733-trunk]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|
> Throw an exception if there is a prepared statement id hash conflict.
> -
>
> Key: CASSANDRA-12733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12733
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Jeremiah Jordan
>Assignee: Jeremiah Jordan
>Priority: Minor
> Fix For: 3.x
>
>
> I seriously doubt there is any chance of actually getting two prepared
> statement strings that have the same MD5. But there should probably be
> checks in QueryProcessor.getStoredPreparedStatement that the query string of
> the statement being prepared matches the query string of the ID returned from
> the cache when one already exists there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12733) Throw an exception if there is a prepared statement id hash conflict.
[
https://issues.apache.org/jira/browse/CASSANDRA-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564760#comment-15564760
]
Alex Petrov edited comment on CASSANDRA-12733 at 10/11/16 8:36 AM:
---
CI looks good now (had to re-run trunk from my fork, although code is
identical). Also, {{CHANGES}} file is updated for 3.X (also, merges cleanly to
trunk).
|[3.X |https://github.com/ifesdjeen/cassandra/tree/12733-3.X]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|
|[trunk|https://github.com/ifesdjeen/cassandra/tree/12733-trunk]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|
was (Author: ifesdjeen):
CI looks good now (had to re-run trunk from my fork, although code is
identical). Also, {{CHANGES}} file is updated for 3.X.
|[3.X |https://github.com/ifesdjeen/cassandra/tree/12733-3.X]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|
|[trunk|https://github.com/ifesdjeen/cassandra/tree/12733-trunk]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|
> Throw an exception if there is a prepared statement id hash conflict.
> -
>
> Key: CASSANDRA-12733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12733
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Jeremiah Jordan
>Assignee: Jeremiah Jordan
>Priority: Minor
> Fix For: 3.x
>
>
> I seriously doubt there is any chance of actually getting two prepared
> statement strings that have the same MD5. But there should probably be
> checks in QueryProcessor.getStoredPreparedStatement that the query string of
> the statement being prepared matches the query string of the ID returned from
> the cache when one already exists there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12733) Throw an exception if there is a prepared statement id hash conflict.
[
https://issues.apache.org/jira/browse/CASSANDRA-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564760#comment-15564760
]
Alex Petrov edited comment on CASSANDRA-12733 at 10/11/16 8:36 AM:
---
CI looks good now (had to re-run trunk from my fork, although code is
identical). Also, {{CHANGES}} file is updated for 3.X.
|[3.X |https://github.com/ifesdjeen/cassandra/tree/12733-3.X]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-3.X-testall/]
|
|[trunk|https://github.com/ifesdjeen/cassandra/tree/12733-trunk]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|
was (Author: ifesdjeen):
CI looks good now (had to re-run trunk from my fork, although code is
identical).
|[3.X
|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-3X]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-3X-dtest/]|[utest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-3X-testall/]|
|[trunk|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-trunk]|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-dtest/]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12733-trunk-testall/]|
> Throw an exception if there is a prepared statement id hash conflict.
> -
>
> Key: CASSANDRA-12733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12733
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Jeremiah Jordan
>Assignee: Jeremiah Jordan
>Priority: Minor
> Fix For: 3.x
>
>
> I seriously doubt there is any chance of actually getting two prepared
> statement strings that have the same MD5. But there should probably be
> checks in QueryProcessor.getStoredPreparedStatement that the query string of
> the statement being prepared matches the query string of the ID returned from
> the cache when one already exists there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12733) Throw an exception if there is a prepared statement id hash conflict.
[ https://issues.apache.org/jira/browse/CASSANDRA-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554310#comment-15554310 ] Alex Petrov edited comment on CASSANDRA-12733 at 10/11/16 7:32 AM: --- LGTM code-wise. This might not solve the problem for prepares that are happening across the cluster, but in case there is a collision (extremely unlikely or even impossible), this may at least give a pointer. I've re-triggered both dtest CI jobs as trunk one has 80+ failures and 3.x one failed. was (Author: ifesdjeen): LGTM code-wise. I've re-triggered both dtest CI jobs as trunk one has 80+ failures and 3.x one failed. > Throw an exception if there is a prepared statement id hash conflict. > - > > Key: CASSANDRA-12733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12733 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: Jeremiah Jordan >Assignee: Jeremiah Jordan >Priority: Minor > Fix For: 3.x > > > I seriously doubt there is any chance of actually getting two prepared > statement strings that have the same MD5. But there should probably be > checks in QueryProcessor.getStoredPreparedStatement that the query string of > the statement being prepared matches the query string of the ID returned from > the cache when one already exists there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12733) Throw an exception if there is a prepared statement id hash conflict.
[ https://issues.apache.org/jira/browse/CASSANDRA-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554310#comment-15554310 ] Alex Petrov edited comment on CASSANDRA-12733 at 10/7/16 6:50 AM: -- LGTM code-wise. I've re-triggered both dtest CI jobs as trunk one has 80+ failures and 3.x one failed. was (Author: ifesdjeen): LGTM > Throw an exception if there is a prepared statement id hash conflict. > - > > Key: CASSANDRA-12733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12733 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: Jeremiah Jordan >Assignee: Jeremiah Jordan >Priority: Minor > Fix For: 3.x > > > I seriously doubt there is any chance of actually getting two prepared > statement strings that have the same MD5. But there should probably be > checks in QueryProcessor.getStoredPreparedStatement that the query string of > the statement being prepared matches the query string of the ID returned from > the cache when one already exists there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-12733) Throw an exception if there is a prepared statement id hash conflict.
[ https://issues.apache.org/jira/browse/CASSANDRA-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533728#comment-15533728 ] Jeremiah Jordan edited comment on CASSANDRA-12733 at 9/29/16 7:17 PM: -- ||branch||testall||dtest|| |[CASSANDRA-12733-3X|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-3X]|[testall|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-3X-testall/]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-3X-dtest/]| |[CASSANDRA-12733-trunk|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-trunk]|[testall|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-trunk-testall/]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-trunk-dtest/]| was (Author: jjordan): ||branch||testall||dtest|| |[CASSANDRA-12733-22|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-22]|[testall|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-22-testall/]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-22-dtest/]| |[CASSANDRA-12733-30|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-30]|[testall|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-30-testall/]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-30-dtest/]| |[CASSANDRA-12733-3X|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-3X]|[testall|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-3X-testall/]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-3X-dtest/]| |[CASSANDRA-12733-trunk|https://github.com/JeremiahDJordan/cassandra/tree/CASSANDRA-12733-trunk]|[testall|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-trunk-testall/]|[dtest|http://cassci.datastax.com/job/JeremiahDJordan-CASSANDRA-12733-trunk-dtest/]| 2.2 branch merges cleanly up to trunk. > Throw an exception if there is a prepared statement id hash conflict. > - > > Key: CASSANDRA-12733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12733 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: Jeremiah Jordan >Assignee: Jeremiah Jordan >Priority: Minor > > I seriously doubt there is any chance of actually getting two prepared > statement strings that have the same MD5. But there should probably be > checks in QueryProcessor.getStoredPreparedStatement that the query string of > the statement being prepared matches the query string of the ID returned from > the cache when one already exists there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
