[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-10-07 Thread Michael Semb Wever (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946159#comment-16946159
 ] 

Michael Semb Wever edited comment on CASSANDRA-14655 at 10/7/19 7:24 PM:
-

Committed as 38b49904dd1c71fcb16abfbc205edfd6ce008b76

(moved the CHANGES line entry to the top, they are in reverse chronological 
order)


was (Author: michaelsembwever):
Committed as 38b49904dd1c71fcb16abfbc205edfd6ce008b76

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.0-alpha
>
> Attachments: 14655-4.0.txt
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-09-27 Thread Michael Semb Wever (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939150#comment-16939150
 ] 

Michael Semb Wever edited comment on CASSANDRA-14655 at 9/27/19 6:02 AM:
-

{quote}
bq. Status of Tests 
(https://circleci.com/workflow-run/6ff402e1-a68b-4092-bc6a-62b10cc36d2d)

Thanks for that! It really is crap that dtests on asf jenkins is so flakey and 
circleci only works with paid accounts and lots of containers.
{quote}

This looks much better: 
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/682/

[~sumanth.pasupuleti], the circleci dtests you linked to include an additional 
commit 
[78cf2db|https://github.com/apache/cassandra/commit/78cf2db056312145b77102ee3247d1f688786a0e],
 is this to be included in the patch?


was (Author: mck):
{quote}
bq. Status of Tests 
(https://circleci.com/workflow-run/6ff402e1-a68b-4092-bc6a-62b10cc36d2d)

Thanks for that! It really is crap that dtests on asf jenkins is so flakey and 
circleci only works with paid accounts and lots of containers.
{quote}

This looks much better: 
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/682/

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-09-26 Thread Michael Semb Wever (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938464#comment-16938464
 ] 

Michael Semb Wever edited comment on CASSANDRA-14655 at 9/26/19 10:12 AM:
--

bq. Made changes to remove nativePort parameter from 
NativeSSTableLoaderClient's constructor. LoaderOptions.Builder.build() already 
puts nativePort into the hosts (line 152), so I didn't have to make any changes 
there - please let me know in case I missed out anything here.

Line 152 is only adding the default nativePort onto the {{hostArgs}} array, but 
that array is not parsed anymore (it's only part of a deprecated setter).
The newer {{hosts}} array, which accepts custom ports, does add the default 
nativePort if need be, ref line 376. But a problem here is that the default 
{{nativePort}} is not parsed until later on, ref line 432.

bq. Status of Tests 
(https://circleci.com/workflow-run/6ff402e1-a68b-4092-bc6a-62b10cc36d2d)

Thanks for that! It really is crap that dtests on asf jenkins is so flakey and 
circleci only works with paid accounts and lots of containers.


was (Author: mck):
bq. Made changes to remove nativePort parameter from 
NativeSSTableLoaderClient's constructor. LoaderOptions.Builder.build() already 
puts nativePort into the hosts (line 152), so I didn't have to make any changes 
there - please let me know in case I missed out anything here.

Line 152 is only adding the default nativePort onto the {{hostArgs}} array, but 
that array is not parsed anymore (it's only part of a deprecated setter).
The newer {{hosts}} array, which accepts custom ports, does add the default 
nativePort if need be, ref line 376. But a problem here is that the default 
{{nativePort}} is not parsed until later on, ref line 432.

bq. Status of Tests 
(https://circleci.com/workflow-run/6ff402e1-a68b-4092-bc6a-62b10cc36d2d)

Thanks for that! It really is crap that travis is so flakey and circleci only 
works with paid accounts and lots of containers.

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-09-25 Thread mck (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936427#comment-16936427
 ] 

mck edited comment on CASSANDRA-14655 at 9/25/19 3:01 PM:
--

[~sumanth.pasupuleti],
 - unit tests look good,
 - i think the {{"cassandra-driver-core"}} lines in the build.xml can now be 
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
 - for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie 
to use `host:port`?
 - is the {{nativePort}} parameter needed anymore in 
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the 
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster 
builder called instead with {{addContactPointsWithPorts(hosts)}},
 - i am still looking into the dtests…




bq. … the caller can put that into the {{hosts}} parameter, …

For example it looks like {{CqlBulkRecordWriter}} (in the call to 
{{resolveHostAddresses}}) does this, while {{BulkLoader}}+{{LoaderOptions}} 
could be doing similar if {{LoaderOptions.Builder.build()}} looped through its 
{{hosts}} and put in {{nativePort}} when undefined.


was (Author: michaelsembwever):
[~sumanth.pasupuleti],
 - unit tests look good,
 - i think the {{"cassandra-driver-core"}} lines in the build.xml can now be 
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
 - for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie 
to use `host:port`?
 - is the {{nativePort}} parameter needed anymore in 
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the 
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster 
builder called instead with {{addContactPointsWithPorts(hosts)}},
 - i am still looking into the dtests…


bq. … the caller can put that into the {{hosts}} parameter, …

For example it looks like {{CqlBulkRecordWriter}} (in the call to 
{{resolveHostAddresses}}), while {{BulkLoader}}+{{LoaderOptions}} could be 
doing similar if {{LoaderOptions.Builder.build()}} looped through its {{hosts}} 
and put in {{nativePort}} when undefined.

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-09-25 Thread Sumanth Pasupuleti (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937810#comment-16937810
 ] 

Sumanth Pasupuleti edited comment on CASSANDRA-14655 at 9/25/19 2:54 PM:
-

+1 to [~andrew.tolbert]'s comment on bringing this back into light. 

[~michaelsembwever] Thanks for your feedback. Will look into them today and get 
back. Will also run DTests on my end through CircleCI.


was (Author: sumanth.pasupuleti):
+1 to [~andrew.tolbert]'s comment of bringing this back into light. 

[~michaelsembwever] Thanks for your feedback. Will look into them today and get 
back. Will also run DTests on my end through CircleCI.

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-09-24 Thread mck (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936427#comment-16936427
 ] 

mck edited comment on CASSANDRA-14655 at 9/24/19 2:35 PM:
--

[~sumanth.pasupuleti],
 - unit tests look good,
 - i think the {{"cassandra-driver-core"}} lines in the build.xml can now be 
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
 - for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie 
to use `host:port`?
 - is the {{nativePort}} parameter needed anymore in 
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the 
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster 
builder called instead with {{addContactPointsWithPorts(hosts)}},
 - i am still looking into the dtests…


bq. … the caller can put that into the {{hosts}} parameter, …

For example it looks like {{CqlBulkRecordWriter}} (in the call to 
{{resolveHostAddresses}}), while {{BulkLoader}}+{{LoaderOptions}} could be 
doing similar if {{LoaderOptions.Builder.build()}} looped through its {{hosts}} 
and put in {{nativePort}} when undefined.


was (Author: michaelsembwever):
[~sumanth.pasupuleti],
 - unit tests look good,
 - i think the {{"cassandra-driver-core"}} lines in the build.xml can now be 
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
 - for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie 
to use `host:port`?
 - is the {{nativePort}} parameter needed anymore in 
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the 
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster 
builder called instead with {{addContactPointsWithPorts(hosts)}},
 - i am still looking into the dtests…

bq. … the caller can put that into the {{hosts}} parameter, …

For example it looks like {{CqlBulkRecordWriter}} (in the call to 
{{resolveHostAddresses}}), while {{BulkLoader}}+{{LoaderOptions}} could be 
doing similar if {{LoaderOptions.Builder.build()}} looped through its {{hosts}} 
and put in {{nativePort}} when undefined.

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)

2019-09-24 Thread mck (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936427#comment-16936427
 ] 

mck edited comment on CASSANDRA-14655 at 9/24/19 2:35 PM:
--

[~sumanth.pasupuleti],
 - unit tests look good,
 - i think the {{"cassandra-driver-core"}} lines in the build.xml can now be 
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
 - for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie 
to use `host:port`?
 - is the {{nativePort}} parameter needed anymore in 
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the 
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster 
builder called instead with {{addContactPointsWithPorts(hosts)}},
 - i am still looking into the dtests…

bq. … the caller can put that into the {{hosts}} parameter, …

For example it looks like {{CqlBulkRecordWriter}} (in the call to 
{{resolveHostAddresses}}), while {{BulkLoader}}+{{LoaderOptions}} could be 
doing similar if {{LoaderOptions.Builder.build()}} looped through its {{hosts}} 
and put in {{nativePort}} when undefined.


was (Author: michaelsembwever):
[~sumanth.pasupuleti],
 - unit tests look good,
 - i think the {{"cassandra-driver-core"}} lines in the build.xml can now be 
updated and uncommented, see {{"UPDATE AND UNCOMMENT"}} sections,
 - for LoaderOptions and CqlConfigHelper are there docs we want to update? (ie 
to use `host:`port`?
 - is the {{nativePort}} parameter needed anymore in 
{{NativeSSTableLoaderClient}}'s constructor? the caller can put that into the 
{{hosts}} parameter, (and then in the {{init(..)}} method (line 73) the cluster 
builder called instead with {{addContactPointsWithPorts(hosts)}},
 - i am still looking into the dtests…

> Upgrade C* to use latest guava (27.0)
> -
>
> Key: CASSANDRA-14655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14655
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
>  Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
>
> C* currently uses guava 23.3. This JIRA is about changing C* to use latest 
> guava (26.0). Originated from a discussion in the mailing list.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org