[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2017-01-03 Thread Stefania (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797394#comment-15797394
 ] 

Stefania commented on CASSANDRA-12348:
--

Committed to 3.0 as d2344683d3100168940230768c27206af2d75d95.

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.8, 3.0.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2017-01-03 Thread Paulo Motta (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794928#comment-15794928
 ] 

Paulo Motta commented on CASSANDRA-12348:
-

Sure, sounds good!

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.8, 3.0.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2017-01-02 Thread Stefania (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794386#comment-15794386
 ] 

Stefania commented on CASSANDRA-12348:
--

The patch committed to 3.8 applies cleanly to 3.0, see 
[here|https://github.com/stef1927/cassandra/tree/12348-3.0]. I'm multiplexing 
it 
[here|https://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-testall-multiplex/61/].
 If the results are positive, are you OK to commit it to 3.0 as well, 
[~pauloricardomg]?

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.8, 3.0.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2016-08-01 Thread Stefania (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403229#comment-15403229
 ] 

Stefania commented on CASSANDRA-12348:
--

Thanks for the review. I've added a comment to {{validateCFS}} and then 
committed the fix to 3.9 as e89028d34c699916b8c94b52f4cb3e086d8b81c1 and merged 
into trunk.

I did not add a {{LifecycleTransaction.waitForDeletions()}} after 
{{CompactionManager.instance.submitMaximal}} because we would have also had to 
wait on the future first. I think a better approach would be not to submit the 
maximal compaction task but to just check that there exists at least one. I 
think this was the intention of the test.

We can reopen this ticket or create a new one if we want to change this test 
further.

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.9
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2016-08-01 Thread Paulo Motta (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402170#comment-15402170
 ] 

Paulo Motta commented on CASSANDRA-12348:
-

and/or maybe add a {{LifecycleTransaction.waitForDeletions()}} after 
{{CompactionManager.instance.submitMaximal}} so if someone puts an assertion 
after {{validateCFS}} it will at least fail consistently..

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2016-08-01 Thread Paulo Motta (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402162#comment-15402162
 ] 

Paulo Motta commented on CASSANDRA-12348:
-

+1, but {{validateCFS}} having side-effects is pretty counter-intuitive, so 
before committing can you maybe add a comment on this method warning that it 
should be typically called after the last test assertion?

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12348) Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest

2016-08-01 Thread Stefania (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401721#comment-15401721
 ] 

Stefania commented on CASSANDRA-12348:
--

{{validateCFS(cfs)}} should be called after checking the counts, since it will 
launch a maximal compaction task.

||3.9||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/12348-3.9]|[patch|https://github.com/stef1927/cassandra/commits/12348]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12348-3.9-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12348-testall/]|

Multiplexed results:

http://cassci.datastax.com/job/stef1927-testall-multiplex/15/


> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Stefania
> Fix For: 3.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)