[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820039#comment-16820039
]
Aleksey Yeschenko commented on CASSANDRA-14412:
---
LGTM as well.
> Restore automatic snapshot of system keyspace during upgrade
>
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in
> system.local (if any) at startup. If these versions differ, the system
> keyspace is snapshotted before proceeding in order to enable a rollback if
> any other issue prevents startup from completing. Although the method to
> perform this check & snapshot is still present in {{SystemKeyspace}}, its
> only callsite was mistakenly removed from {{CassandraDaemon}} in
> CASSANDRA-12716.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819873#comment-16819873
]
Tommy Stendahl commented on CASSANDRA-14412:
I looked at the changes to the test case and it looks fine.
> Restore automatic snapshot of system keyspace during upgrade
>
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in
> system.local (if any) at startup. If these versions differ, the system
> keyspace is snapshotted before proceeding in order to enable a rollback if
> any other issue prevents startup from completing. Although the method to
> perform this check & snapshot is still present in {{SystemKeyspace}}, its
> only callsite was mistakenly removed from {{CassandraDaemon}} in
> CASSANDRA-12716.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818943#comment-16818943
]
Sam Tunnicliffe commented on CASSANDRA-14412:
-
Thanks [~tommy_s], I've added extra checks to the test, rebased and pushed:
||branch||CI||
|[14412-trunk|https://github.com/beobal/cassandra/tree/14412-trunk]|[circle|https://circleci.com/gh/beobal/workflows/cassandra/tree/cci%2F14412-trunk]|
> Restore automatic snapshot of system keyspace during upgrade
>
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in
> system.local (if any) at startup. If these versions differ, the system
> keyspace is snapshotted before proceeding in order to enable a rollback if
> any other issue prevents startup from completing. Although the method to
> perform this check & snapshot is still present in {{SystemKeyspace}}, its
> only callsite was mistakenly removed from {{CassandraDaemon}} in
> CASSANDRA-12716.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814452#comment-16814452
]
Tommy Stendahl commented on CASSANDRA-14412:
It would be nice to have this feature enabled again, it definitely looks like
it was removed by mistake. Extending this with snapshots of the
{{system_schema}} is a good thing.
I have looked at the patch and it LGTM with one comment:
* I think the test case
{{SystemKeyspaceTest.snapshotSystemKeyspaceIfUpgrading()}} should be extended
so it also check the snapshot for {{system_schema}}.
otherwise I'm +1 for this.
> Restore automatic snapshot of system keyspace during upgrade
>
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in
> system.local (if any) at startup. If these versions differ, the system
> keyspace is snapshotted before proceeding in order to enable a rollback if
> any other issue prevents startup from completing. Although the method to
> perform this check & snapshot is still present in {{SystemKeyspace}}, its
> only callsite was mistakenly removed from {{CassandraDaemon}} in
> CASSANDRA-12716.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448077#comment-16448077
]
Sam Tunnicliffe commented on CASSANDRA-14412:
-
Pushed a branch [here|https://github.com/beobal/cassandra/tree/14412] which
adds back the call to {{SystemKeyspace::snapshotOnVersionChange}}, minus the
call to {{SystemKeyspace::migrateDataDirs}} that it was previously guarding,
but which is genuinely no longer necessary. As snapshots are reasonably cheap
and an upgrade should be a rare event anyway, I've extended the original method
to also snapshot {{system_schema}}.
CI here: https://circleci.com/workflow-run/677d3b4e-85e5-4b90-bb41-309cd4b361f2
> Restore automatic snapshot of system keyspace during upgrade
>
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
> Issue Type: Bug
> Components: Lifecycle
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in
> system.local (if any) at startup. If these versions differ, the system
> keyspace is snapshotted before proceeding in order to enable a rollback if
> any other issue prevents startup from completing. Although the method to
> perform this check & snapshot is still present in {{SystemKeyspace}}, its
> only callsite was mistakenly removed from {{CassandraDaemon}} in
> CASSANDRA-12716.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
