[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597767#comment-16597767
]
Dinesh Joshi commented on CASSANDRA-14659:
--
Hi [~jasobrown] I have incorporated your feedback and pushed a new commit.
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597468#comment-16597468
]
Jason Brown commented on CASSANDRA-14659:
-
On the whole, this is almost there. I think the version check you have in
{{Message}} would be best located in {{ProtocolVersion.decode()}}, as that is
the section where we already do the general version check, and yours is an
extension to that.
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590563#comment-16590563
]
Dinesh Joshi commented on CASSANDRA-14659:
--
Hi [~molsson], thanks for the feedback. I have incorporated your suggestions.
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590152#comment-16590152
]
Marcus Olsson commented on CASSANDRA-14659:
---
[~djoshi3], sure, as I said I don't really have a strong opinion on this and I
think it would be useful as you said to have a test of client connections
before performing a major upgrade.
I haven't tested/verified the patches but I did glance over them and found a
few small things:
* In the nodetool command for
[DisableOldProtocolVersions|https://github.com/dineshjoshi/cassandra/blob/73f921d7f981f0be1efe688c6d02968eb784a15b/src/java/org/apache/cassandra/tools/nodetool/DisableOldProtocolVersions.java#L25]
the description is "Enable old protocol versions" rather than "Disable old
protocol versions".
* In the dtest I think it would be good to have a verification that it's still
possible to connect with the latest protocol version in between
disabling/enabling the feature.
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589148#comment-16589148
]
Dinesh Joshi commented on CASSANDRA-14659:
--
[~molsson], I wanted to keep this feature simple for now. I did consider a more
complex version of this. However, I felt it would be over complicating things.
This is useful to run a "scream" test prior to a major version upgrade.
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589071#comment-16589071
]
Marcus Olsson commented on CASSANDRA-14659:
---
It seems like we support V3, V4 and V5 protocols on trunk as of today. Would it
make sense to be able to be a bit more selective than to say only latest
protocol or all of them? One option could be to specify the minimum protocol
version to allow from clients.
I don't have a strong opinion on this but I thought it might potentially be
useful to have a bit more flexibility with this feature when multiple protocol
versions are supported.
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[
https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588063#comment-16588063
]
Dinesh Joshi commented on CASSANDRA-14659:
--
DTest PR is here:
https://github.com/apache/cassandra-dtest/compare/master...dineshjoshi:14659-master?expand=1
> Disable old protocol versions on demand
> ---
>
> Key: CASSANDRA-14659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14659
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
> Labels: usability
>
> This patch allows the operators to disable older protocol versions on demand.
> To use it, you can set {{native_transport_allow_older_protocols}} to false or
> use nodetool disableolderprotocolversions. Cassandra will reject requests
> from client coming in on any version except the current version. This will
> help operators selectively reject connections from clients that do not
> support the latest protoocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14659) Disable old protocol versions on demand
[ https://issues.apache.org/jira/browse/CASSANDRA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587684#comment-16587684 ] Dinesh Joshi commented on CASSANDRA-14659: -- ||version|| |[branch|https://github.com/dineshjoshi/cassandra/tree/restrict-protocol-version]| |[utests dtests|https://circleci.com/gh/dineshjoshi/workflows/cassandra/tree/restrict-protocol-version]| || > Disable old protocol versions on demand > --- > > Key: CASSANDRA-14659 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14659 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Major > Labels: usability > > This patch allows the operators to disable older protocol versions on demand. > To use it, you can set native_transport_honor_older_protocols to false or use > nodetool disableolderprotocolversions. Cassandra will reject requests from > client coming in on any version except the current version. This will help > operators selectively reject connections from clients that do not support the > latest protoocol. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
