[jira] [Commented] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests

2020-02-05 Thread Alex Petrov (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030567#comment-17030567
 ] 

Alex Petrov commented on CASSANDRA-15497:
-

Thank you! Committed to 2.2 with 
[9705d823cddfe24356ba4f3f083b9371cdbdeb4d|https://github.com/apache/cassandra/commit/9705d823cddfe24356ba4f3f083b9371cdbdeb4d]
 and merged up to 
[3.0|https://github.com/apache/cassandra/commit/3320f08269eaedd06418d0b8b8fdd2be6f467b51],
 
[3.11|https://github.com/apache/cassandra/commit/c09e709dccf797f3c65592cbbc530979310dafab]
 and 
[trunk|https://github.com/apache/cassandra/commit/a041b53d2996cb076f615bbe3dfc048ed77372d4].
 

> Implement node bootstrap in in-JVM tests
> 
>
> Key: CASSANDRA-15497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15497
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/dtest
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: High
>
> Currently, we do not have an ability to add nodes to the running in-jvm 
> cluster, either by bootstrap or replacement process. We need to add an 
> ability to add nodes in inactive state, start them up, and bootstrap to test 
> streaming, range movements, and operations that occur during these processes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests

2020-02-04 Thread Alex Petrov (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029722#comment-17029722
 ] 

Alex Petrov commented on CASSANDRA-15497:
-

Thank you for the review, posting patches and CI for all branches:

|2.2|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-2.2]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-2.2]|
|3.0|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.0]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.0]|
|3.11|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.11]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.11]|
|trunk|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-trunk]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-trunk]|

> Implement node bootstrap in in-JVM tests
> 
>
> Key: CASSANDRA-15497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15497
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/dtest
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: High
>
> Currently, we do not have an ability to add nodes to the running in-jvm 
> cluster, either by bootstrap or replacement process. We need to add an 
> ability to add nodes in inactive state, start them up, and bootstrap to test 
> streaming, range movements, and operations that occur during these processes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests

2020-01-29 Thread Marcus Eriksson (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025922#comment-17025922
 ] 

Marcus Eriksson commented on CASSANDRA-15497:
-

Nice! Minor comments;
* In {{AbstractCluster}}, the new {{version}} member - could we instead figure 
this out by the version of the currently running instances? Or leave it for 
later and just assert somewhere that we are not an {{UpgradeableCluster}} and 
call it {{initialVersion}} instead?
* In {{AbstractCluster#bootstrap}} - maybe assert that we have 
{{Feature.NETWORK}} and {{Feature.GOSSIP}} enabled to avoid hard-to-understand 
errors?
* In {{AbstractCluster#bootstrap}} - in the {{if (null != prev)}} case - maybe 
change the exception message to contain the instance number instead of 
{{broadcastAddressAndPort}} which is bound to be the same for both.
* {{// TODO: make token allocation strategy configurable}} could be removed I 
think?
* You could remove the {{repair}} step in the new test to make sure that 
bootstrap streaming works


> Implement node bootstrap in in-JVM tests
> 
>
> Key: CASSANDRA-15497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15497
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/dtest
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: High
>
> Currently, we do not have an ability to add nodes to the running in-jvm 
> cluster, either by bootstrap or replacement process. We need to add an 
> ability to add nodes in inactive state, start them up, and bootstrap to test 
> streaming, range movements, and operations that occur during these processes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests

2020-01-14 Thread Alex Petrov (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015143#comment-17015143
 ] 

Alex Petrov commented on CASSANDRA-15497:
-

Patch: https://github.com/apache/cassandra/pull/423
Circleci: 
https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap

> Implement node bootstrap in in-JVM tests
> 
>
> Key: CASSANDRA-15497
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15497
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/dtest
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: High
>
> Currently, we do not have an ability to add nodes to the running in-jvm 
> cluster, either by bootstrap or replacement process. We need to add an 
> ability to add nodes in inactive state, start them up, and bootstrap to test 
> streaming, range movements, and operations that occur during these processes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org