[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741192#comment-17741192
]
Marcus Eriksson commented on CASSANDRA-18639:
-
sure, +1
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741190#comment-17741190
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
https://github.com/apache/cassandra/pull/2472/commits/e10142cd3b3a294d783cb67b880705602f24f24e
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741187#comment-17741187
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Actually, there is a bug, it was there even before this change was introduced,
check this:
{code}
SSTable min local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
SSTable max local deletion time: 9223372036854775807 (08/17/292278994 08:12:55)
{code}
The year in 08/17/292278994 is just wrong.
As we are going to fix this, I would just keep the output as introduced in this
ticket and fixed the year.
Deal?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741182#comment-17741182
]
Marcus Eriksson commented on CASSANDRA-18639:
-
If we're changing the output back I think we should also revert the changes to
the other fields and just add the duration
We could probably motivate those changes though, since they are more clearly
improvements.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741177#comment-17741177
]
Brandon Williams commented on CASSANDRA-18639:
--
LGTM, I am +1 but let's wait for Marcus since he caught this problem for us.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741176#comment-17741176
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Based on this thread (1), how I got it is that we will not change the default
output unless there is JSON / YAML equivalent. Once there is, we can do
whatever we please with it.
I am fine with this compromise so I am +1 on that. The ninja is here
[https://github.com/apache/cassandra/pull/2472/files]
[~marcuse] do you want to take a look?
(1) [https://lists.apache.org/thread/72j5qfgbttjcmylhcmfq1ptboh641ns0]
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741157#comment-17741157
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
-1 on changing it back. We need to resolve this once for all on ML.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741155#comment-17741155
]
Marcus Eriksson commented on CASSANDRA-18639:
-
bq. make a new ticket to add serialization and change the output back
+1
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741078#comment-17741078
]
Brandon Williams commented on CASSANDRA-18639:
--
bq. Regardless of whether we eventually do that or not, I think that is too big
of a bite for this ticket in this stage. Let's just ninja it (and optionally
revert the output back to what it was for these two fields)
Alright, and make a new ticket to add serialization and change the output back?
bq. I also want to write an email to ML clarifying what we should do in cases
when we are going to change the output for majors. Not going to lie, it is
little bit irritating to hit this situation every now and then.
I totally agree, and that's why we need a serialized format so we don't run
into this situation and have the freedom to change whatever we want. We
already do this for a number of nodetool commands so it seems like the way.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741073#comment-17741073
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Regardless of whether we eventually do that or not, I think that is too big of
a bite for this ticket in this stage. Let's just ninja it (and optionally
revert the output back to what it was for these two fields)
I also want to write an email to ML clarifying what we should do in cases when
we are going to change the output for majors. Not going to lie, it is little
bit irritating to hit this situation every now and then.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741070#comment-17741070
]
Brandon Williams commented on CASSANDRA-18639:
--
All the display logic stays. We would have a new method that -j invokes that
does something like "return toJSON(stats)". That's not exactly concrete but
without actually doing it that's my idea.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741067#comment-17741067
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Could you please show me concrete example? What I have in mind is this would
need to be json:
[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/SSTableMetadataViewer.java#L355-L441]
I am sorry I am so pedantic here, I want to understand you exactly. What I have
in mind is that -j would just print all statistics in JSON format, so whole
output would be changed.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741065#comment-17741065
]
Brandon Williams commented on CASSANDRA-18639:
--
bq. but we would need to completely rework how this tool prints it
No, we would add a -j flag or whatever and when present, return json.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741064#comment-17741064
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Frankly speaking, I think we are over-thinking this. Sure, Yaml, JSON, why not,
we can add that, but we would need to completely rework how this tool prints
it. I mean ... complete overhaul. We would probably need to serialize
StatsMetadata and what about other statistics anyway?
Additionally, I need to meet just one person for which a change of the output
like suggested here (going to be introduced in {_}major{_}) is a problem. Is
not this really some kind of an urban story we are following blindly just
because ?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741063#comment-17741063
]
Brad Schoening commented on CASSANDRA-18639:
A JSON output option could be a good idea.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741060#comment-17741060
]
Brandon Williams commented on CASSANDRA-18639:
--
Json, yaml, whatever.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741059#comment-17741059
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I dont understand what you mean by "serialized output format".
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741058#comment-17741058
]
Brandon Williams commented on CASSANDRA-18639:
--
I can understand and get behind both arguments here. My litmus test in this
situation is "can this information be obtained in another way?" and if not, we
either shouldn't change it, or... we can take this opportunity to solve the
problem and add a serialized output format, obviating the need for screen
scraping now and forever. WDYT?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741043#comment-17741043
]
Brad Schoening commented on CASSANDRA-18639:
> Feels unnecessary potentially breaking existing scripts for users when its
> just a style change
Major releases are where breaking changes should go. The alternative is to
never change or improve the output of sstablemetadata.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741035#comment-17741035
]
Marcus Eriksson commented on CASSANDRA-18639:
-
bq. Since this goes to 5.0 I think we can just break this as this does not
apply to majors afaik.
Feels unnecessary potentially breaking existing scripts for users when its just
a style change
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741034#comment-17741034
]
Timothy Tu commented on CASSANDRA-18639:
Total Partitions is just the Counts all summed togethor as shown below:
Total Partitions: 24306
Size (bytes) | Count (%) Histogram
35 (35 B) | 1 ( 0)
42 (42 B) | 98 ( 0)
50 (50 B) | 24207 ( 99) OO
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741029#comment-17741029
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I ll do that as I am just on in, no worries.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741027#comment-17741027
]
Brad Schoening commented on CASSANDRA-18639:
[~timothytu] we should document these additional options:
usage: sstablemetadata [-c] [-g ] [-s] [-t ]
[-u]
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741023#comment-17741023
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
https://github.com/apache/cassandra/pull/2472/files
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741020#comment-17741020
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Since this goes to 5.0 I think we can just break this as this does not apply to
majors afaik.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741019#comment-17741019
]
Marcus Eriksson commented on CASSANDRA-18639:
-
we should probably keep them for backwards compatibility
and, we should probably not rename the totalColumnsSet/totalRows fields if
someone parses the output of this
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741017#comment-17741017
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I would keep it there because that one is just _estimation_. Right?
{code}
/**
* @return the number of unique elements in the stream or an estimate
thereof
*/
long cardinality();
{code}
But the figures under "-s" give you always exact numbers. So in theory they
might differ.
BTW this which was already in trunk before this change seems to be just
redundant because it will be printed also when '-s' is used.
{code}
field("totalColumnsSet", stats.totalColumnsSet);
field("totalRows", stats.totalRows);
{code}
It that same what we get after "-s"? If so, should not we remove this too? Or
we keep it?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741013#comment-17741013
]
Brandon Williams commented on CASSANDRA-18639:
--
We are already printing compaction.cardinalityEstimator.cardinality() in
'estimated cardinality' too.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741011#comment-17741011
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Hah really, damn, where have we been looking?! So this can just go away and we
keep duration only. I'll fix that.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741010#comment-17741010
]
Marcus Eriksson commented on CASSANDRA-18639:
-
yeah, we have the {{-s/--scan}} option to do slow operations like this, which
already outputs exact partition count
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741006#comment-17741006
]
Brandon Williams commented on CASSANDRA-18639:
--
Yes, we should probably reopen and fix that. It's not really just 'metadata'
if we're doing a heavy op.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741005#comment-17741005
]
Brad Schoening commented on CASSANDRA-18639:
This tool, sstablemetadata is a utility which would be infrequently run on a
single sstable at a time. It's not involved in the write path or compaction.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741002#comment-17741002
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
Why is that a problem? It just takes too long on big tables?
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740999#comment-17740999
]
Marcus Eriksson commented on CASSANDRA-18639:
-
Looks like this iterates over all the keys in the sstable to count the
partitions without any option to skip?
It should probably collect that information during compaction/flush, or just
use {{compaction.cardinalityEstimator.cardinality()}}
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new additions will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740931#comment-17740931
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
+1 too, I added some minor fixes on top.
Committed, thanks!
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740790#comment-17740790
]
Brandon Williams commented on CASSANDRA-18639:
--
Totally clean, +1 from me.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740760#comment-17740760
]
Brandon Williams commented on CASSANDRA-18639:
--
Third time's the charm, we hope.
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18639-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1119/workflows/cb2b7dc7-6706-4adf-bd2a-f5e0371e6085],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1119/workflows/6afeee77-4599-4445-a4f6-8f6f9dc34ce1]|
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740755#comment-17740755
]
Timothy Tu commented on CASSANDRA-18639:
I have updated the commit with the try statement hopefully it works now.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740750#comment-17740750
]
Brandon Williams commented on CASSANDRA-18639:
--
Ekaterina pointed out we use this pattern a lot and it passes:
{code}
try (KeyIterator iter = sstable.keyIterator())
{code}
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740737#comment-17740737
]
Brandon Williams commented on CASSANDRA-18639:
--
I think we probably need to add @SuppressWarnings at this point.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740727#comment-17740727
]
Brandon Williams commented on CASSANDRA-18639:
--
I have your
[commit|https://github.com/driftx/cassandra/commit/da6e59be2866e7669d6786cd40da71e9067336d8]
but it looks like eclipse-warnings is still unhappy on j8.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740702#comment-17740702
]
Brandon Williams commented on CASSANDRA-18639:
--
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18639-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1118/workflows/d5707b84-69dc-4274-9e5e-9a4a9d962ba8],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1118/workflows/ca53fcae-f89b-40fb-9664-019ed92e1699]|
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740701#comment-17740701
]
Brandon Williams commented on CASSANDRA-18639:
--
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18639-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1117/workflows/3545f39b-839c-4682-9984-3bf0f6ceaa68],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1117/workflows/82a2e3f5-28b1-4d75-a1a9-158c7d1ac9b8]|
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740697#comment-17740697
]
Timothy Tu commented on CASSANDRA-18639:
[~brandon.williams] I added the close() should be all good now.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740325#comment-17740325
]
Brandon Williams commented on CASSANDRA-18639:
--
eclipse-warnings is mad about the KeyIterator not being closed, but only on j8.
It's stupid, but we can't break j8 compat yet and eclipse-warnings hasn't been
replaced yet, so I think we just need to make it happy.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740316#comment-17740316
]
Brandon Williams commented on CASSANDRA-18639:
--
The nits can also be fixed on commit, but either way:
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18639-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1115/workflows/f635f612-08a6-4507-a343-a983931d6f73],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1115/workflows/aeb89429-508f-4b38-bafb-2b66959f9e9a]|
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740315#comment-17740315
]
Brad Schoening commented on CASSANDRA-18639:
[~brandon.williams] I've review it and it looks good, [~timothytu] can fix the
nits.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740310#comment-17740310
]
Stefan Miklosovic commented on CASSANDRA-18639:
---
I commented few nits on the PR. Might be done upon commit. Apart from briefly
looking at it, I have tested that.
Note: this might be a candidate to rewrite it to use TableBuilder instead of
StringBuilder but might be done in a separate ticket etc ... No need to deal
with this now (if ever, but still ... an idea)
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740309#comment-17740309
]
Brandon Williams commented on CASSANDRA-18639:
--
If this looks good to you [~bschoeni] I'll run CI.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739190#comment-17739190
]
Brandon Williams commented on CASSANDRA-18639:
--
Sounds good to me.
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add duration and partition key count to sstablemetadata
[
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739188#comment-17739188
]
Brad Schoening commented on CASSANDRA-18639:
[~brandon.williams] to improve readability, I'd suggest some minor formatting
changes also:
* renaming 'totalRows' and 'totalColumnsSet' -> Total Rows and Total Column
Cells.
* Changing timestamp to be data-time and add the milliseconds integer value in
parenthesis instead of the other way around, i.e.:
** Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)
> Add duration and partition key count to sstablemetadata
> ---
>
> Key: CASSANDRA-18639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
>Reporter: Timothy Tu
>Assignee: Timothy Tu
>Priority: Normal
> Fix For: 5.x
>
>
> The new -m option will output metadata information for:
> * Partition Key Count
> * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 10}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
