[jira] [Commented] (CASSANDRA-3297) truncate can still result in data being replayed after a restart
[ https://issues.apache.org/jira/browse/CASSANDRA-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121135#comment-13121135 ] Sylvain Lebresne commented on CASSANDRA-3297: - nitpick: the assert that segments is not empty in CL.createNewSegment() could be moved one line up since sync() already assume this. But otherwise, patch lgtm. +1. truncate can still result in data being replayed after a restart Key: CASSANDRA-3297 URL: https://issues.apache.org/jira/browse/CASSANDRA-3297 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.0 Reporter: Jonathan Ellis Assignee: Jonathan Ellis Labels: commitlog Fix For: 0.8.8 Attachments: 3297.txt Our first stab at fixing this was CASSANDRA-2950. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3297) truncate can still result in data being replayed after a restart
[ https://issues.apache.org/jira/browse/CASSANDRA-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121382#comment-13121382 ] Hudson commented on CASSANDRA-3297: --- Integrated in Cassandra-0.8 #364 (See [https://builds.apache.org/job/Cassandra-0.8/364/]) fix truncate allowing data to be replayed post-restart patch by jbellis; reviewed by slebresne for CASSANDRA-3297 jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179359 Files : * /cassandra/branches/cassandra-0.8/CHANGES.txt * /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/ColumnFamilyStore.java * /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/Truncation.java * /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java * /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java * /cassandra/branches/cassandra-0.8/test/unit/org/apache/cassandra/db/RecoveryManagerTruncateTest.java truncate can still result in data being replayed after a restart Key: CASSANDRA-3297 URL: https://issues.apache.org/jira/browse/CASSANDRA-3297 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.0 Reporter: Jonathan Ellis Assignee: Jonathan Ellis Labels: commitlog Fix For: 0.8.8, 1.0.0 Attachments: 3297.txt Our first stab at fixing this was CASSANDRA-2950. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3297) truncate can still result in data being replayed after a restart
[ https://issues.apache.org/jira/browse/CASSANDRA-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119488#comment-13119488 ] Jonathan Ellis commented on CASSANDRA-3297: --- (patch is against trunk) truncate can still result in data being replayed after a restart Key: CASSANDRA-3297 URL: https://issues.apache.org/jira/browse/CASSANDRA-3297 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.0 Reporter: Jonathan Ellis Assignee: Jonathan Ellis Labels: commitlog Fix For: 0.8.7, 1.0.0 Attachments: 3297.txt Our first stab at fixing this was CASSANDRA-2950. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
