[GitHub] blueorangutan commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
blueorangutan commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-300391453 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
blueorangutan commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300391458 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
borisstoyanov commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-300391317 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
borisstoyanov commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300391274 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
blueorangutan commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300385693 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
borisstoyanov commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300385466 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
blueorangutan commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-300385287 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
borisstoyanov commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-300385066 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] niteshsarda commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs
niteshsarda commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-300383535 tag:This is Ready to Merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayantpatil1234 commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs
jayantpatil1234 commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-300382829 Tested and working fine. **LGTM** for test.   This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayantpatil1234 commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs
jayantpatil1234 commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-300382829 Tested and working fine. **LGTM** for test.   This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115658118
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##
@@ -2072,6 +2121,17 @@ protected StartAnswer execute(StartCommand cmd) {
}
/**
+ * Update boot args with the new nic mac addresses.
+ */
+protected String replaceNicsMacSequenceInBootArgs(String oldMacSequence,
String newMacSequence, VirtualMachineTO vmSpec) {
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs) &&
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+return bootArgs.replace(oldMacSequence, newMacSequence);
+}
+return "";
Review comment:
@rafaelweingartner May not be possible. `oldMacSequence` and
`newMacSequence` are generated from the NICs info. Both would be empty only
when no NICs are specified for the VM, which will never happen. `bootArgs`
would hold more info including the nics sequence.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] priyankparihar commented on a change in pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
priyankparihar commented on a change in pull request #1894: CLOUDSTACK-9700
Allow user to Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#discussion_r115657468
##
File path:
api/src/org/apache/cloudstack/api/command/admin/template/RegisterTemplateCmdByAdmin.java
##
@@ -40,10 +40,23 @@
@Override
public void execute() throws ResourceAllocationException{
try {
+if ((zoneId != null) && (zoneIds != null && !zoneIds.isEmpty()))
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] priyankparihar commented on a change in pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
priyankparihar commented on a change in pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#discussion_r115657221 ## File path: api/src/org/apache/cloudstack/api/ResponseGenerator.java ## @@ -307,7 +307,11 @@ TemplateResponse createTemplateUpdateResponse(ResponseView view, VirtualMachineTemplate result); -List createTemplateResponses(ResponseView view, VirtualMachineTemplate result, Long zoneId, boolean readyOnly); +List createTemplateResponses(ResponseView view, VirtualMachineTemplate result, + Long zoneId, boolean readyOnly); Review comment: ok thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-300379396 With this PR, the user keypair (api key and secret key) which used to be in listUsers API response will now be returned by new getUserKeys API response that is allowed for User role type only (qq - we should allow all role types, if we're allowing the RoleType.User) -- does this beat the purpose of exposing user keypair? I do see the value of exposing this as a separate API though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115656830 ## File path: server/src/com/cloud/server/ManagementServerImpl.java ## @@ -2793,6 +2795,8 @@ public long getMemoryOrCpuCapacityByHost(final Long hostId, final short capacity cmdList.add(UpdateIsoCmd.class); cmdList.add(UpdateIsoPermissionsCmd.class); cmdList.add(ListAsyncJobsCmd.class); +cmdList.add(ListLongRunningAsyncJobsCmd.class); +cmdList.add(ListQueuedUpAsyncJobsCmd.class); Review comment: its in asyncjobmanagerimpl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey
is returned from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#discussion_r115656588
##
File path: server/test/com/cloud/user/AccountManagerImplTest.java
##
@@ -170,5 +175,40 @@ public void testAuthenticateUser() throws
UnknownHostException {
Mockito.verify(userAuthenticator,
Mockito.never()).authenticate("test", "", 1L, null);
}
+@Mock
+AccountVO callingAccount;
+@Mock
+DomainChecker domainChecker;
+@Mock
+AccountService accountService;
+@Mock
+private GetUserKeysCmd _listkeyscmd;
+@Mock
+private Account _account;
+@Mock
+private User _user;
+@Mock
+private UserAccountVO userAccountVO;
+
+
+@Test (expected = PermissionDeniedException.class)
+public void testgetUserCmd(){
+CallContext.register(callingUser, callingAccount); // Calling account
is user account i.e normal account
+Mockito.when(_listkeyscmd.getID()).thenReturn(1L);
+Mockito.when(accountManager.getActiveUser(1L)).thenReturn(_user);
+
Mockito.when(accountManager.getUserAccountById(1L)).thenReturn(userAccountVO);
+Mockito.when(userAccountVO.getAccountId()).thenReturn(1L);
+
Mockito.when(accountManager.getAccount(Mockito.anyLong())).thenReturn(_account);
// Queried account - admin account
+
+Mockito.when(callingUser.getAccountId()).thenReturn(1L);
+Mockito.when(_accountDao.findById(1L)).thenReturn(callingAccount);
+
+
Mockito.when(accountService.isNormalUser(Mockito.anyLong())).thenReturn(Boolean.TRUE);
+Mockito.when(_account.getAccountId()).thenReturn(2L);
+
+accountManager.getKeys(_listkeyscmd);
+
+}
Review comment:
Fix braces please `}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey
is returned from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#discussion_r115656568
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2632,4 +2651,27 @@ public void checkAccess(Account account, DiskOffering
dof)
assert false : "How can all of the security checkers pass on checking
this caller?";
throw new PermissionDeniedException("There's no way to confirm " +
account + " has access to " + dof);
}
+
+@Override
+public void checkAccess(User user, ControlledEntity entity)
+throws PermissionDeniedException {
+for(SecurityChecker checker : _securityCheckers){
+if(checker.checkAccess(user,entity)){
+if(s_logger.isDebugEnabled()){
+s_logger.debug("Access granted to " + user + "to " +
entity + "by " + checker.getName());
+}
+return;
Review comment:
@jayapalu is it assumed that checkAccess throws no exception? Can such a
case happen where depending on the sequence of security checkers, we might
allow an entity that may be failed by some other checker, i.e. should we return
here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey
is returned from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#discussion_r115656408
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2221,6 +,24 @@ private UserAccount getUserAccount(String username,
String password, Long domain
}
@Override
+public List getKeys(GetUserKeysCmd cmd){
Review comment:
Instead of a list should this be a Pair (keypair) of string, and rename the
method as getUserKeyPair() ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey
is returned from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#discussion_r115656291
##
File path: server/src/com/cloud/api/ApiDBUtils.java
##
@@ -1707,6 +1708,9 @@ public static UserResponse
newUserResponse(UserAccountJoinVO usr) {
public static UserResponse newUserResponse(UserAccountJoinVO usr, Long
domainId) {
UserResponse response = s_userAccountJoinDao.newUserResponse(usr);
+if(AccountManager.UseSecretKeyInResponse.value() == false){
Review comment:
we can use !?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey
is returned from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#discussion_r115656240
##
File path:
api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java
##
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.user;
+
+
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.RegisterResponse;
+import org.apache.cloudstack.api.response.UserResponse;
+
+import java.util.List;
+import java.util.logging.Logger;
+
+@APICommand(name = "getUserKeys",
+description = "This command allows the user to query the seceret
and API keys for the account",
+responseObject = RegisterResponse.class,
+requestHasSensitiveInfo = false,
+responseHasSensitiveInfo = true,
+authorized = {RoleType.User},
+since = "4.11.0")
+
+public class GetUserKeysCmd extends BaseCmd{
+
+@Parameter(name= ApiConstants.ID, type = CommandType.UUID, entityType =
UserResponse.class, required = true, description = "ID of the user whose keys
are required")
+private Long id;
+
+public static final Logger s_logger =
Logger.getLogger(RegisterCmd.class.getName());
+public static final String s_name = "getuserkeysresponse";
Review comment:
@jayapalu can we get rid of archai way of variable declaration and API
implementation, for example see this API:
https://github.com/apache/cloudstack/blob/master/api/src/org/apache/cloudstack/api/command/admin/acl/ListRolesCmd.java#L46
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
rhtyd commented on a change in pull request #1996: CLOUDSTACK-9099: SecretKey
is returned from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#discussion_r115656091
##
File path:
api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java
##
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.user;
+
+
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.RegisterResponse;
+import org.apache.cloudstack.api.response.UserResponse;
+
+import java.util.List;
+import java.util.logging.Logger;
+
+@APICommand(name = "getUserKeys",
+description = "This command allows the user to query the seceret
and API keys for the account",
+responseObject = RegisterResponse.class,
+requestHasSensitiveInfo = false,
+responseHasSensitiveInfo = true,
+authorized = {RoleType.User},
Review comment:
If you're allowing users, please allow all the role types.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115655899
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##
@@ -1928,6 +1929,54 @@ protected StartAnswer execute(StartCommand cmd) {
VirtualDevice nic;
int nicMask = 0;
int nicCount = 0;
+
+if (vmSpec.getType() == VirtualMachine.Type.DomainRouter) {
+int extraPublicNics = mgr.getRouterExtraPublicNics();
+if (extraPublicNics > 0 &&
vmSpec.getDetails().containsKey("PeerRouterInstanceName")) {
+//Set identical MAC address for RvR on extra public
interfaces
+String peerRouterInstanceName =
vmSpec.getDetails().get("PeerRouterInstanceName");
+
+VirtualMachineMO peerVmMo =
hyperHost.findVmOnHyperHost(peerRouterInstanceName);
+if (peerVmMo == null) {
+peerVmMo =
hyperHost.findVmOnPeerHyperHost(peerRouterInstanceName);
+}
+
+if (peerVmMo != null) {
+StringBuffer sbOldMacSequence = new StringBuffer();
+for (NicTO oldNicTo : sortNicsByDeviceId(nics)) {
+
sbOldMacSequence.append(oldNicTo.getMac()).append("|");
+}
+if (!sbOldMacSequence.toString().isEmpty()) {
+
sbOldMacSequence.deleteCharAt(sbOldMacSequence.length() - 1); //Remove extra
'|' char appended at the end
+}
+
+for (int nicIndex = nics.length - extraPublicNics;
nicIndex < nics.length; nicIndex++) {
+VirtualDevice nicDevice =
peerVmMo.getNicDeviceByIndex(nics[nicIndex].getDeviceId());
+if (nicDevice != null) {
+String mac =
((VirtualEthernetCard)nicDevice).getMacAddress();
+if (mac != null) {
+s_logger.info("Use same MAC as previous
RvR, the MAC is " + mac + " for extra NIC with device id: " +
nics[nicIndex].getDeviceId());
+nics[nicIndex].setMac(mac);
+}
+}
+}
+
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs)) {
+StringBuffer sbNewMacSequence = new StringBuffer();
Review comment:
Moved generating new nics mac sequence to a new private method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sarathkouk closed pull request #1377: CLOUDSTACK-8830 : VM snapshot creation fails for 12 min
sarathkouk closed pull request #1377: CLOUDSTACK-8830 : VM snapshot creation fails for 12 min URL: https://github.com/apache/cloudstack/pull/1377 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karuturi closed pull request #1152: CLOUDSTACK-9099: SecretKey is returned from the APIs - Fixed
karuturi closed pull request #1152: CLOUDSTACK-9099: SecretKey is returned from the APIs - Fixed URL: https://github.com/apache/cloudstack/pull/1152 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karuturi commented on issue #1152: CLOUDSTACK-9099: SecretKey is returned from the APIs - Fixed
karuturi commented on issue #1152: CLOUDSTACK-9099: SecretKey is returned from the APIs - Fixed URL: https://github.com/apache/cloudstack/pull/1152#issuecomment-300376088 closing in favor of #1996 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115654943
##
File path: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
##
@@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId) {
List results = customSearch(sc, null);
return results.get(0);
}
+
+@Override
+public Long getPeerRouterId(String publicMacAddress, final long routerId) {
+final SearchCriteria sc = PeerRouterSearch.create();
+sc.setParameters("instanceId", routerId);
+sc.setParameters("macAddress", publicMacAddress);
+sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
+NicVO nicVo = findOneBy(sc);
+if (nicVo != null) {
+return (new Long(nicVo.getInstanceId()));
Review comment:
Addressed this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115654696
##
File path: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
##
@@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId) {
List results = customSearch(sc, null);
return results.get(0);
}
+
+@Override
+public Long getPeerRouterId(String publicMacAddress, final long routerId) {
+final SearchCriteria sc = PeerRouterSearch.create();
+sc.setParameters("instanceId", routerId);
+sc.setParameters("macAddress", publicMacAddress);
+sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
+NicVO nicVo = findOneBy(sc);
+if (nicVo != null) {
+return (new Long(nicVo.getInstanceId()));
Review comment:
Addressed this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rashmidixit commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
rashmidixit commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300374993 The failed test in internal CI seem to be due to intermittent network error. Nothing caused due to changes in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harikrishna-patnala commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.
harikrishna-patnala commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#issuecomment-300372923 Thanks @bvbharatk , then based on these test results, this fix LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bvbharatk commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.
bvbharatk commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#issuecomment-300372715 HI, The test failure in the above CI run are not related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bvbharatk commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.
bvbharatk commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#issuecomment-300372715 HI, The test failure in the above CI run are not related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300319569 ### ACS CI BVT Run **Sumarry:** Build Number 673 Hypervisor xenserver NetworkType Advanced Passed=111 Failed=1 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300371579 ### ACS CI BVT Run **Sumarry:** Build Number 674 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=2 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_vm_snapshots.py * test_change_service_offering_for_vm_with_snapshots Failed * test_router_dns.py * test_router_dns_guestipquery Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300371558 I think few of the failures and errors are because of the test issues not because of changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harikrishna-patnala commented on issue #2006: CLOUDSTACK-9833: Move configuration parameters from Config.java to use configdepot
harikrishna-patnala commented on issue #2006: CLOUDSTACK-9833: Move configuration parameters from Config.java to use configdepot URL: https://github.com/apache/cloudstack/pull/2006#issuecomment-300366891 tag:mergeready This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] PranaliM commented on issue #1992: CLOUDSTACK-9824:Resource count for Primary storage is considered twice - while creating and while attaching the disk
PranaliM commented on issue #1992: CLOUDSTACK-9824:Resource count for Primary storage is considered twice - while creating and while attaching the disk URL: https://github.com/apache/cloudstack/pull/1992#issuecomment-300365409 tag:This is Ready to Merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300362251 Trillian test result (tid-1065) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52272 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2018-t1065-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 42 look ok, 10 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | `Failure` | 272.06 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Failure` | 423.17 | test_vpc_vpn.py test_01_create_volume | `Failure` | 156.22 | test_volumes.py test_04_rvpc_privategw_static_routes | `Failure` | 469.06 | test_privategw_acl.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 126.31 | test_internal_lb.py test_01_VPC_nics_after_destroy | `Error` | 182.16 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | `Error` | 312.82 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 106.60 | test_vpc_redundant.py test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.27 | test_primary_storage.py test_reboot_router | `Error` | 594.75 | test_network.py ContextSuite context=TestDeployVmRootSize>:setup | `Error` | 0.00 | test_deploy_vm_root_resize.py test_01_vpc_remote_access_vpn | Success | 166.83 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 385.01 | test_vpc_router_nics.py test_04_rvpc_network_garbage_collector_nics | Success | 1534.92 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 775.47 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 745.98 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 26.16 | test_volumes.py test_06_download_detached_volume | Success | 95.81 | test_volumes.py test_05_detach_volume | Success | 100.24 | test_volumes.py test_04_delete_attached_volume | Success | 15.26 | test_volumes.py test_03_download_attached_volume | Success | 20.32 | test_volumes.py test_02_attach_volume | Success | 69.80 | test_volumes.py test_change_service_offering_for_vm_with_snapshots | Success | 502.75 | test_vm_snapshots.py test_03_delete_vm_snapshots | Success | 280.27 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 237.32 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 166.72 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 252.82 | test_vm_life_cycle.py test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.88 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py test_08_migrate_vm | Success | 71.23 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.18 | test_vm_life_cycle.py test_03_reboot_vm | Success | 5.17 | test_vm_life_cycle.py test_02_start_vm | Success | 25.28 | test_vm_life_cycle.py test_01_stop_vm | Success | 10.17 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 362.50 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 30.55 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.17 | test_templates.py test_01_create_template | Success | 292.00 | test_templates.py test_10_destroy_cpvm | Success | 231.86 | test_ssvm.py test_09_destroy_ssvm | Success | 299.07 | test_ssvm.py test_08_reboot_cpvm | Success | 156.60 | test_ssvm.py test_07_reboot_ssvm | Success | 158.44 | test_ssvm.py test_06_stop_cpvm | Success | 182.02 | test_ssvm.py tes
[GitHub] sureshanaparti commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
sureshanaparti commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-300361646 @borisstoyanov Can you please run VMware trillian tests on this PR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
sureshanaparti commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300361566 @borisstoyanov Can you please kick off VMware trillian tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #544: CLOUDSTACK-8599. CS reports failure for a successful migration.
sureshanaparti commented on issue #544: CLOUDSTACK-8599. CS reports failure for a successful migration. URL: https://github.com/apache/cloudstack/pull/544#issuecomment-300360363 Continuing with the code changes here in a new PR #2092. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti opened a new pull request #2092: CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out
sureshanaparti opened a new pull request #2092: CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out URL: https://github.com/apache/cloudstack/pull/2092 [VMware] Successful migration was reported as failure when vCenter session timed out. - When cancelling a vCenter task, Check whether the vCenter task is cancellable or not. If not, wait for the task to complete. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-300329342 Trillian test result (tid-1064) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40461 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2074-t1064-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 50 look ok, 1 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 498.59 | test_privategw_acl.py test_01_vpc_site2site_vpn | Success | 196.48 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 76.43 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 316.96 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 332.96 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 655.15 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 584.43 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1452.18 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 555.32 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 792.94 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1329.65 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.85 | test_volumes.py test_08_resize_volume | Success | 156.72 | test_volumes.py test_07_resize_fail | Success | 156.77 | test_volumes.py test_06_download_detached_volume | Success | 156.58 | test_volumes.py test_05_detach_volume | Success | 150.82 | test_volumes.py test_04_delete_attached_volume | Success | 151.43 | test_volumes.py test_03_download_attached_volume | Success | 156.53 | test_volumes.py test_02_attach_volume | Success | 124.61 | test_volumes.py test_01_create_volume | Success | 651.93 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 105.90 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 177.49 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 268.05 | test_vm_life_cycle.py test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.87 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.29 | test_vm_life_cycle.py test_08_migrate_vm | Success | 31.01 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.99 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.97 | test_vm_life_cycle.py test_02_start_vm | Success | 10.20 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.37 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 131.28 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.10 | test_templates.py test_04_extract_template | Success | 5.21 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.19 | test_templates.py test_01_create_template | Success | 75.87 | test_templates.py test_10_destroy_cpvm | Success | 161.81 | test_ssvm.py test_09_destroy_ssvm | Success | 194.19 | test_ssvm.py test_08_reboot_cpvm | Success | 161.67 | test_ssvm.py test_07_reboot_ssvm | Success | 133.66 | test_ssvm.py test_06_stop_cpvm | Success | 131.84 | test_ssvm.py test_05_stop_ssvm | Success | 133.85 | test_ssvm.py test_04_cpvm_internals | Success | 1.55 | test_ssvm.py test_03_ssvm_internals | Success | 3.60 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_02_list_snapshots_with_removed_data_store | Success | 87.43 | test_snapshots.py test_01_snapshot_root_disk | Success | 16.53 | test_snapshots.py test_04_change_offering_small | Success | 209.79 | test_service_offerings.py test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py test_01_create_service_offering | Success | 0.15 | test_service_offerings.py test_02_sys_template_ready | Success | 0.17 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.25 | test_secondary_storage.py test_09_reboot_router | Success | 40.38 | test_routers.py test_08_start_router | Success | 35.37 | test_routers.py tes
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300319569 ### ACS CI BVT Run **Sumarry:** Build Number 673 Hypervisor xenserver NetworkType Advanced Passed=111 Failed=1 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-299364306 ### ACS CI BVT Run **Sumarry:** Build Number 623 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=2 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_router_dns.py * test_router_dns_guestipquery Failed * test_routers_network_ops.py * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2087: [CLOUDSTACK-9910] API: display zone capacity data only to admin
resmo commented on issue #2087: [CLOUDSTACK-9910] API: display zone capacity data only to admin URL: https://github.com/apache/cloudstack/pull/2087#issuecomment-300318344 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2089: vRouters fixes & performance improvement
resmo commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300316479 LGTM based on code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti opened a new pull request #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
sureshanaparti opened a new pull request #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091 [VMware] VM is not accessible after migration across clusters. - Once a VM is successfully started, don't delete the files associated with the unregistered VM, if the files are in a storage that is being used by the new VM. - Attempt to unregister a VM in another DC, only if there is a host associated with a VM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
sureshanaparti commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300274961 @DaanHoogland @wilderrodrigues Please review the changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti opened a new pull request #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
sureshanaparti opened a new pull request #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090 In VMware environment, SSVM shutdown during snapshot operation leaves behind partial unusable disks in secondary storage and VM snapshots. Fix: Enhance storage garbage collector to delete the partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot. This closes #540 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harikrishna-patnala commented on issue #2016: CLOUDSTACK-9835 : To make management server and SSVM to be in time sync
harikrishna-patnala commented on issue #2016: CLOUDSTACK-9835 : To make management server and SSVM to be in time sync URL: https://github.com/apache/cloudstack/pull/2016#issuecomment-300251652 Thank you @DaanHoogland @wido @kishankavala . Can we get another LGTM on this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
blueorangutan commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-300247167 Trillian test result (tid-1063) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34543 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2075-t1063-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Test completed. 46 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 479.76 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py test_DeployVmAntiAffinityGroup | `Error` | 96.03 | test_affinity_groups.py test_01_vpc_site2site_vpn | Success | 212.40 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 96.65 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 331.80 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 410.68 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 637.11 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 549.87 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1377.22 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 640.56 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 874.68 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1445.10 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.86 | test_volumes.py test_08_resize_volume | Success | 156.75 | test_volumes.py test_07_resize_fail | Success | 161.75 | test_volumes.py test_06_download_detached_volume | Success | 156.52 | test_volumes.py test_05_detach_volume | Success | 150.97 | test_volumes.py test_04_delete_attached_volume | Success | 151.56 | test_volumes.py test_03_download_attached_volume | Success | 156.64 | test_volumes.py test_02_attach_volume | Success | 91.03 | test_volumes.py test_01_create_volume | Success | 731.55 | test_volumes.py test_deploy_vm_multiple | Success | 500.12 | test_vm_life_cycle.py test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.77 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.30 | test_vm_life_cycle.py test_08_migrate_vm | Success | 56.31 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.25 | test_vm_life_cycle.py test_06_destroy_vm | Success | 131.08 | test_vm_life_cycle.py test_03_reboot_vm | Success | 131.04 | test_vm_life_cycle.py test_02_start_vm | Success | 15.27 | test_vm_life_cycle.py test_01_stop_vm | Success | 50.46 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 116.29 | test_templates.py test_08_list_system_templates | Success | 0.06 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.21 | test_templates.py test_03_delete_template | Success | 5.16 | test_templates.py test_02_edit_template | Success | 90.17 | test_templates.py test_01_create_template | Success | 186.57 | test_templates.py test_10_destroy_cpvm | Success | 191.86 | test_ssvm.py test_09_destroy_ssvm | Success | 163.83 | test_ssvm.py test_08_reboot_cpvm | Success | 132.16 | test_ssvm.py test_07_reboot_ssvm | Success | 133.81 | test_ssvm.py test_06_stop_cpvm | Success | 136.84 | test_ssvm.py test_05_stop_ssvm | Success | 133.82 | test_ssvm.py test_04_cpvm_internals | Success | 1.31 | test_ssvm.py test_03_ssvm_internals | Success | 3.51 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_01_snapshot_root_disk | Success | 16.22 | test_snapshots.py test_04_change_offering_small | Success | 239.78 | test_service_offerings.py test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py test_02_edit_service_offering | Success | 0.10 | test_service_offerings.py test_01_create_service_offering | Success | 0.12 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py test_09_reboot_router | Success | 60.55 | test_routers.py test_08_st
[GitHub] cloudmonger commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
cloudmonger commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-300217575 ### ACS CI BVT Run **Sumarry:** Build Number 669 Hypervisor xenserver NetworkType Advanced Passed=106 Failed=6 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_loadbalance.py * test_01_create_lb_rule_src_nat Failed * test_02_create_lb_rule_non_nat Failed * test_assign_and_removal_lb Failed * test_volumes.py * test_02_attach_volume Failed * test_routers_network_ops.py * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 2 runs * test_03_RVR_Network_check_router_state Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS
sateesh-chodapuneedi commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS URL: https://github.com/apache/cloudstack/pull/1872#issuecomment-300164658 ping @karuturi This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] priyankparihar commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS
priyankparihar commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS URL: https://github.com/apache/cloudstack/pull/1872#issuecomment-300162980 Hi, Code is tested on master branch. VR, SSVM, CPVM and User VM all are coming up properly. "StartCommand failed due to Exception: com.vmware.vim25.AlreadyExists." is not observed during testing of this patch. Test procedure followed --- Breakpoint is placed before "Line 55: synchronized (uniquedvPortGroupPerDvs.intern())..". Breakpoint is disabled when multiple threads arrives at barrier(Breakpoint). This approach is followed, because earlier this issue was coming because of concurrent attempts to create same dv portgroup on same dvSwitch by manager threads of CPVM and SSVM when both are started at same time as mention in issue. vSphere image PFA. https://cloud.githubusercontent.com/assets/13674052/25852899/85fc3fb0-34e8-11e7-9ede-865572b21552.png";> https://cloud.githubusercontent.com/assets/13674052/25852893/82f2edf0-34e8-11e7-9cc0-6cddee58f6ec.png";> https://cloud.githubusercontent.com/assets/13674052/25852892/82f11b56-34e8-11e7-9d92-bcb227a2b1d8.png";> I would like to give Test LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300151431 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300151332 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300144901 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300144732 Sure @jayapalu @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300144222 @borisstoyanov I have updated the PR. Can you please trigger the Trillian This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-300143446 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
borisstoyanov commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-300143393 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sudhansu7 commented on issue #1869: CLOUDSTACK-9701: Local storage capacity is not handled properly
sudhansu7 commented on issue #1869: CLOUDSTACK-9701: Local storage capacity is not handled properly URL: https://github.com/apache/cloudstack/pull/1869#issuecomment-300134203 tag:mergeready This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
sateesh-chodapuneedi commented on issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing vmware zone URL: https://github.com/apache/cloudstack/pull/1841#issuecomment-300122019 tag:mergeready This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch systemVM keyfile
sateesh-chodapuneedi commented on issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch systemVM keyfile URL: https://github.com/apache/cloudstack/pull/1862#issuecomment-300121913 @karuturi Can you please merge this PR? It has required LGTMs and test results as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
sateesh-chodapuneedi commented on issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing vmware zone URL: https://github.com/apache/cloudstack/pull/1841#issuecomment-300121938 @karuturi Can you please merge this PR? It has required LGTMs and test results as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yvsubhash commented on issue #1992: CLOUDSTACK-9824:Resource count for Primary storage is considered twice - while creating and while attaching the disk
yvsubhash commented on issue #1992: CLOUDSTACK-9824:Resource count for Primary storage is considered twice - while creating and while attaching the disk URL: https://github.com/apache/cloudstack/pull/1992#issuecomment-300116347 Code changes looks good to me LGTM for code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SudharmaJain commented on issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached volume
SudharmaJain commented on issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached volume URL: https://github.com/apache/cloudstack/pull/1911#issuecomment-300116254 LGTM for the code changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.
yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-300114802 @DaanHoogland usage events are a mostly a subset of events. However we are inserting in both the tables separately. So text inserted into events should not affect events. The ID to UUID conversion happens in param processor code before the api actually gets invoked. So I dont see a reason why it would not work for some of the apis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on a change in pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration
borisstoyanov commented on a change in pull request #2026: CLOUDSTACK-9861:
Expire VM snapshots after configured duration
URL: https://github.com/apache/cloudstack/pull/2026#discussion_r115441355
##
File path: server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java
##
@@ -220,6 +237,26 @@ private void checkStatusOfCurrentlyExecutingSnapshots() {
}
@DB
+protected void deleteExpiredVMSnapshots() {
+String displayTime =
DateUtil.displayDateInTimezone(DateUtil.GMT_TIMEZONE, _currentTimestamp);
+Date now = new Date();
+
+List vmSnapshots = _vmSnapshotDao.listAll();
+for (VMSnapshotVO vmSnapshot : vmSnapshots) {
+long accountId = vmSnapshot.getAccountId();
+int expiration_interval_hours =
VMSnapshotManager.VMSnapshotExpireInterval.valueIn(accountId);
+if (expiration_interval_hours < 0 ) {
+continue;
+}
+Date creationTime = vmSnapshot.getCreated();
+long diffInHours = TimeUnit.MILLISECONDS.toHours(now.getTime() -
creationTime.getTime());
+if (diffInHours > expiration_interval_hours) {
Review comment:
but `long diffHours` can be either 4 or 5, in our case 4th hour will be the
time between 3 and 4. When it gets to 4 it's in the 5th hour already. I'm +1 on
'>='
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abhinandanprateek commented on a change in pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration
abhinandanprateek commented on a change in pull request #2026: CLOUDSTACK-9861:
Expire VM snapshots after configured duration
URL: https://github.com/apache/cloudstack/pull/2026#discussion_r115434307
##
File path: server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java
##
@@ -220,6 +237,26 @@ private void checkStatusOfCurrentlyExecutingSnapshots() {
}
@DB
+protected void deleteExpiredVMSnapshots() {
+String displayTime =
DateUtil.displayDateInTimezone(DateUtil.GMT_TIMEZONE, _currentTimestamp);
+Date now = new Date();
+
+List vmSnapshots = _vmSnapshotDao.listAll();
+for (VMSnapshotVO vmSnapshot : vmSnapshots) {
+long accountId = vmSnapshot.getAccountId();
+int expiration_interval_hours =
VMSnapshotManager.VMSnapshotExpireInterval.valueIn(accountId);
+if (expiration_interval_hours < 0 ) {
+continue;
+}
+Date creationTime = vmSnapshot.getCreated();
+long diffInHours = TimeUnit.MILLISECONDS.toHours(now.getTime() -
creationTime.getTime());
+if (diffInHours > expiration_interval_hours) {
Review comment:
@PaulAngus thanks for pointing it out...i see the issue
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abhinandanprateek commented on a change in pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration
abhinandanprateek commented on a change in pull request #2026: CLOUDSTACK-9861:
Expire VM snapshots after configured duration
URL: https://github.com/apache/cloudstack/pull/2026#discussion_r115434307
##
File path: server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java
##
@@ -220,6 +237,26 @@ private void checkStatusOfCurrentlyExecutingSnapshots() {
}
@DB
+protected void deleteExpiredVMSnapshots() {
+String displayTime =
DateUtil.displayDateInTimezone(DateUtil.GMT_TIMEZONE, _currentTimestamp);
+Date now = new Date();
+
+List vmSnapshots = _vmSnapshotDao.listAll();
+for (VMSnapshotVO vmSnapshot : vmSnapshots) {
+long accountId = vmSnapshot.getAccountId();
+int expiration_interval_hours =
VMSnapshotManager.VMSnapshotExpireInterval.valueIn(accountId);
+if (expiration_interval_hours < 0 ) {
+continue;
+}
+Date creationTime = vmSnapshot.getCreated();
+long diffInHours = TimeUnit.MILLISECONDS.toHours(now.getTime() -
creationTime.getTime());
+if (diffInHours > expiration_interval_hours) {
Review comment:
@PaulAngus thanks for pointing it out...i see the issue
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
blueorangutan commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-300093346 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
borisstoyanov commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-300093162 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1836: [4.10/master] Smoketest Health
rhtyd commented on issue #1836: [4.10/master] Smoketest Health URL: https://github.com/apache/cloudstack/pull/1836#issuecomment-300087570 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
blueorangutan commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-300087423 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
borisstoyanov commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-300087380 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #2089: vRouters fixes & performance improvement
wido commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300086572 I am not going to give a LGTM on this code as a co-authored/debugged this code with @The-Loeki . Just want to add that together with #2077 we were able to provision the VR within 5 minutes coming from 2 hours(!!). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2089: vRouters fixes & performance improvement
DaanHoogland commented on a change in pull request #2089: vRouters fixes &
performance improvement
URL: https://github.com/apache/cloudstack/pull/2089#discussion_r115423999
##
File path: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh
##
@@ -27,39 +27,30 @@ log_it() {
echo "$(date) : $*" >> $log
}
-while getopts 'c:' OPTION
-do
- case $OPTION in
- c) cfg="$OPTARG"
- ;;
- esac
+while getopts 'c:' OPTION; do
+case $OPTION in
+c) cfg="$OPTARG" ;;
+esac
Review comment:
thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-300082253 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
borisstoyanov commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-300082220 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1837: [4.9] Smoketest Health
rhtyd commented on issue #1837: [4.9] Smoketest Health URL: https://github.com/apache/cloudstack/pull/1837#issuecomment-300081428 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1837: [4.9] Smoketest Health
rhtyd commented on issue #1837: [4.9] Smoketest Health URL: https://github.com/apache/cloudstack/pull/1837#issuecomment-300081597 Kicking one more time @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1837: [4.9] Smoketest Health
rhtyd commented on issue #1837: [4.9] Smoketest Health URL: https://github.com/apache/cloudstack/pull/1837#issuecomment-300062779 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1837: [4.9] Smoketest Health
rhtyd commented on issue #1837: [4.9] Smoketest Health URL: https://github.com/apache/cloudstack/pull/1837#issuecomment-300081428 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
