[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115915881 ## File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1107,6 +1110,13 @@ public void orchestrateStart(final String vmUuid, final Map
[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job
framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914969
##
File path: engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java
##
@@ -399,10 +414,22 @@ public void send(final Request req, final Listener
listener) throws AgentUnavail
try {
for (int i = 0; i < 2; i++) {
Answer[] answers = null;
+job = _agentMgr._asyncJobDao.findById(jobId);
+if (job != null && job.getStatus() ==
JobInfo.Status.CANCELLED) {
+throw new OperationCancelledException(req.getCommands(),
_id, seq, wait, false);
+}
try {
answers = sl.waitFor(wait);
+job = _agentMgr._asyncJobDao.findById(jobId);
+if (job != null && job.getStatus() ==
JobInfo.Status.CANCELLED) {
+throw new
OperationCancelledException(req.getCommands(), _id, seq, wait, false);
Review comment:
I agree. will do the change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914866 ## File path: engine/components-api/src/com/cloud/agent/AgentManager.java ## @@ -80,9 +81,9 @@ *should the agent stop execution on the first error. * @return an array of Answer */ -Answer[] send(Long hostId, Commands cmds) throws AgentUnavailableException, OperationTimedoutException; +Answer[] send(Long hostId, Commands cmds) throws AgentUnavailableException, OperationTimedoutException, OperationCancelledException; -Answer[] send(Long hostId, Commands cmds, int timeout) throws AgentUnavailableException, OperationTimedoutException; +Answer[] send(Long hostId, Commands cmds, int timeout) throws AgentUnavailableException, OperationTimedoutException, OperationCancelledException; Review comment: OperationCancelledException is a checked exception. There will be compiler errors if its not thrown by the right methods. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914811 ## File path: engine/api/src/com/cloud/vm/VirtualMachineManager.java ## @@ -108,7 +109,7 @@ void orchestrateStart(String vmUuid, Map pa void advanceStop(String vmUuid, boolean cleanupEvenIfUnableToStop) throws ResourceUnavailableException, OperationTimedoutException, ConcurrentOperationException; -void advanceExpunge(String vmUuid) throws ResourceUnavailableException, OperationTimedoutException, ConcurrentOperationException; +void advanceExpunge(String vmUuid) throws ResourceUnavailableException, OperationTimedoutException, ConcurrentOperationException, OperationCancelledException; Review comment: OperationCancelledException is a checked exception. There will be compiler errors if its not thrown by the right methods. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job
framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914294
##
File path:
api/src/org/apache/cloudstack/api/command/user/job/CancelAsyncJobCmd.java
##
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.job;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.vm.DestroyVMCmd;
+import org.apache.cloudstack.api.response.AsyncJobResponse;
+import org.apache.cloudstack.jobs.AsyncJobService;
+import org.apache.log4j.Logger;
+import com.google.common.base.Strings;
+
+import javax.inject.Inject;
+
+@APICommand(name = "cancelAsyncJob", description = "Cancel asynchronous job.",
+responseObject = AsyncJobResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.7.1", authorized = {RoleType.Admin})
+public class CancelAsyncJobCmd extends BaseCmd {
+public static final Logger s_logger =
Logger.getLogger(DestroyVMCmd.class.getName());
+
+private static final String s_name = "cancelasyncjobresponse";
+
+@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
AsyncJobResponse.class,
+required = true, description = "The ID of the job to cancel")
+protected Long id;
+
+@Inject
+private AsyncJobService asyncJobService;
+
+
+public String getEventType() {
+return EventTypes.EVENT_JOB_CANCEL;
+}
+
+public String getEventDescription() {
+return "cancelling job with id: " + id;
+}
+
+@Override
+public void execute() throws ResourceUnavailableException,
ClassNotFoundException {
+String errorString = asyncJobService.cancelAsyncJob(id, "cancel
request by user using cancelAsyncJob api");
+if(Strings.isNullOrEmpty(errorString)) {
Review comment:
cancelasyncjob will not return a blank string. this check should be
sufficient.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-300694623 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics
borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-300694536 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-300694256 Packaging result: ?centos6 ?centos7 ?debian. JID-708 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2089: vRouters fixes & performance improvement
blueorangutan commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300690085 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2089: vRouters fixes & performance improvement
borisstoyanov commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300689984 Trillian job failed, will re-run @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
blueorangutan commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300689936 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
borisstoyanov commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-300689877 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-300689809 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics
borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-300689778 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #1866: Advanced isolated network egress destination cidr support added
swill commented on issue #1866: Advanced isolated network egress destination cidr support added URL: https://github.com/apache/cloudstack/pull/1866#issuecomment-300682297 Do we know why the egress tests are failing. There are a lot of network tests failing in this PR. I don't think this is ready to merge without another run of the CI tests to clarify if there are still network failures. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300642696 ### ACS CI BVT Run **Sumarry:** Build Number 678 Hypervisor xenserver NetworkType Advanced Passed=108 Failed=4 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_vm_snapshots.py * test_change_service_offering_for_vm_with_snapshots Failed * test_network.py * test_delete_account Failed * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 2 runs * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300680835 ### ACS CI BVT Run **Sumarry:** Build Number 679 Hypervisor xenserver NetworkType Advanced Passed=111 Failed=1 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 4 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300452430 ### ACS CI BVT Run **Sumarry:** Build Number 675 Hypervisor xenserver NetworkType Advanced Passed=111 Failed=1 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300642696 ### ACS CI BVT Run **Sumarry:** Build Number 678 Hypervisor xenserver NetworkType Advanced Passed=108 Failed=4 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_vm_snapshots.py * test_change_service_offering_for_vm_with_snapshots Failed * test_network.py * test_delete_account Failed * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 2 runs * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300641853 Trillian test result (tid-1072) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50558 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2018-t1072-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 46 look ok, 6 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_volume | `Failure` | 189.58 | test_volumes.py test_04_rvpc_privategw_static_routes | `Failure` | 915.18 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 222.43 | test_privategw_acl.py test_01_vpc_privategw_acl | `Failure` | 121.93 | test_privategw_acl.py test_04_rvpc_network_garbage_collector_nics | `Error` | 136.77 | test_vpc_redundant.py test_01_primary_storage_nfs | `Error` | 0.19 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.37 | test_primary_storage.py ContextSuite context=TestDeployVmRootSize>:setup | `Error` | 0.00 | test_deploy_vm_root_resize.py test_01_vpc_site2site_vpn | Success | 477.34 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 181.79 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 708.90 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 400.62 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 757.27 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 724.24 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 756.74 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 707.42 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1493.92 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 31.01 | test_volumes.py test_06_download_detached_volume | Success | 80.76 | test_volumes.py test_05_detach_volume | Success | 100.31 | test_volumes.py test_04_delete_attached_volume | Success | 20.26 | test_volumes.py test_03_download_attached_volume | Success | 20.34 | test_volumes.py test_02_attach_volume | Success | 64.90 | test_volumes.py test_change_service_offering_for_vm_with_snapshots | Success | 608.06 | test_vm_snapshots.py test_03_delete_vm_snapshots | Success | 280.25 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 232.35 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 161.68 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 444.09 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 27.02 | test_vm_life_cycle.py test_09_expunge_vm | Success | 185.35 | test_vm_life_cycle.py test_08_migrate_vm | Success | 71.33 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.16 | test_vm_life_cycle.py test_03_reboot_vm | Success | 5.15 | test_vm_life_cycle.py test_02_start_vm | Success | 20.25 | test_vm_life_cycle.py test_01_stop_vm | Success | 5.13 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 347.45 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.05 | test_templates.py test_05_template_permissions | Success | 0.08 | test_templates.py test_04_extract_template | Success | 20.29 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 181.30 | test_templates.py test_10_destroy_cpvm | Success | 267.00 | test_ssvm.py test_09_destroy_ssvm | Success | 268.97 | test_ssvm.py test_08_reboot_cpvm | Success | 156.58 | test_ssvm.py test_07_reboot_ssvm | Success | 158.59 | test_ssvm.py test_06_stop_cpvm | Success | 177.00 | test_ssvm.py test_05_stop_ssvm | Success | 213.98 | test_ssvm.py test_04_cpvm_internals | Success | 1.30 | test_ssvm.py test_03_ssvm_internals | Success | 3.84 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.14 | test_ssvm
[GitHub] sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards
sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-300615923 @serg38 @sateesh-chodapuneedi Removed the config parameter "vmware.ports.per.dvportgroup". Ports per dvportgroup is defaulted to 8 and for vSphere 4.x, it is 256. Please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters
blueorangutan commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-300598193 Trillian test result (tid-1070) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38743 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2091-t1070-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Test completed. 48 look ok, 4 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 391.95 | test_privategw_acl.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_01_vpc_site2site_vpn | Success | 185.72 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 71.24 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 286.26 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 270.83 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 589.27 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 538.76 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1352.07 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 580.14 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 775.69 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1318.43 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.66 | test_volumes.py test_08_resize_volume | Success | 156.46 | test_volumes.py test_07_resize_fail | Success | 161.62 | test_volumes.py test_06_download_detached_volume | Success | 151.42 | test_volumes.py test_05_detach_volume | Success | 150.83 | test_volumes.py test_04_delete_attached_volume | Success | 151.32 | test_volumes.py test_03_download_attached_volume | Success | 156.48 | test_volumes.py test_02_attach_volume | Success | 89.63 | test_volumes.py test_01_create_volume | Success | 711.94 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.21 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 100.89 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 168.96 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 293.09 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.04 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.80 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py test_08_migrate_vm | Success | 30.98 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.90 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.92 | test_vm_life_cycle.py test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.30 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 141.51 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.05 | test_templates.py test_05_template_permissions | Success | 0.07 | test_templates.py test_04_extract_template | Success | 5.20 | test_templates.py test_03_delete_template | Success | 5.12 | test_templates.py test_02_edit_template | Success | 90.22 | test_templates.py test_01_create_template | Success | 85.76 | test_templates.py test_10_destroy_cpvm | Success | 161.69 | test_ssvm.py test_09_destroy_ssvm | Success | 193.79 | test_ssvm.py test_08_reboot_cpvm | Success | 131.79 | test_ssvm.py test_07_reboot_ssvm | Success | 133.64 | test_ssvm.py test_06_stop_cpvm | Success | 131.86 | test_ssvm.py test_05_stop_ssvm | Success | 138.81 | test_ssvm.py test_04_cpvm_internals | Success | 1.24 | test_ssvm.py test_03_ssvm_internals | Success | 3.67 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.16 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py test_02_list_snapshots_with_removed_data_store | Success | 87.06 | test_snapshots.py test_01_snapshot_root_disk | Success | 16.38 | test_snapshots.py test_04_change_offering_small | Success | 239.69 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | te
[GitHub] sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration p
sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733:
Concurrent volume snapshots of a VM are not allowed and are not limited per
host as per the global configuration parameter
"concurrent.snapshots.threshold.perhost".
URL: https://github.com/apache/cloudstack/pull/1897#discussion_r115839385
##
File path:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
##
@@ -374,10 +374,14 @@ public SnapshotInfo takeSnapshot(SnapshotInfo snapshot) {
throw new CloudRuntimeException(result.getResult());
}
} finally {
-if (result != null && result.isSuccess()) {
-volumeInfo.stateTransit(Volume.Event.OperationSucceeded);
-} else {
-volumeInfo.stateTransit(Volume.Event.OperationFailed);
+List activeVolumeSnapshots =
snapshotDao.listByStatus(snapshot.getVolumeId(), Snapshot.State.Creating);
+if (activeVolumeSnapshots.isEmpty()) {
Review comment:
@kishankavala The active snapshots jobs for that volume will be checked here
from the snapshots table. Lock is acquired on snapshots table when this is
performed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration p
sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost". URL: https://github.com/apache/cloudstack/pull/1897#discussion_r115838455 ## File path: setup/db/db/schema-4920to41000.sql ## @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL) AND -- CLOUDSTACK-9827: Storage tags stored in multiple places DROP VIEW IF EXISTS `cloud`.`storage_tag_view`; + +DELETE FROM `cloud`.`configuration` where name = 'concurrent.snapshots.threshold.perhost'; Review comment: @kishankavala Updated. Not deleting this param as it might impact the existing config. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. URL: https://github.com/apache/cloudstack/pull/1878#issuecomment-300593595 @rafaelweingartner Changes addressed as suggested. Please take a look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115835020
##
File path:
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
##
@@ -216,6 +216,20 @@ public void testScaleVMF1() throws Exception {
}
@Test
+public void testReplaceNicsMacSequenceInBootArgs() throws Exception {
Review comment:
Yes. Thanks for correcting me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115654696
##
File path: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
##
@@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId) {
List results = customSearch(sc, null);
return results.get(0);
}
+
+@Override
+public Long getPeerRouterId(String publicMacAddress, final long routerId) {
+final SearchCriteria sc = PeerRouterSearch.create();
+sc.setParameters("instanceId", routerId);
+sc.setParameters("macAddress", publicMacAddress);
+sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
+NicVO nicVo = findOneBy(sc);
+if (nicVo != null) {
+return (new Long(nicVo.getInstanceId()));
Review comment:
Addressed this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sureshanaparti commented on a change in pull request #1878: CLOUDSTACK-9717:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#discussion_r115655899
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##
@@ -1928,6 +1929,54 @@ protected StartAnswer execute(StartCommand cmd) {
VirtualDevice nic;
int nicMask = 0;
int nicCount = 0;
+
+if (vmSpec.getType() == VirtualMachine.Type.DomainRouter) {
+int extraPublicNics = mgr.getRouterExtraPublicNics();
+if (extraPublicNics > 0 &&
vmSpec.getDetails().containsKey("PeerRouterInstanceName")) {
+//Set identical MAC address for RvR on extra public
interfaces
+String peerRouterInstanceName =
vmSpec.getDetails().get("PeerRouterInstanceName");
+
+VirtualMachineMO peerVmMo =
hyperHost.findVmOnHyperHost(peerRouterInstanceName);
+if (peerVmMo == null) {
+peerVmMo =
hyperHost.findVmOnPeerHyperHost(peerRouterInstanceName);
+}
+
+if (peerVmMo != null) {
+StringBuffer sbOldMacSequence = new StringBuffer();
+for (NicTO oldNicTo : sortNicsByDeviceId(nics)) {
+
sbOldMacSequence.append(oldNicTo.getMac()).append("|");
+}
+if (!sbOldMacSequence.toString().isEmpty()) {
+
sbOldMacSequence.deleteCharAt(sbOldMacSequence.length() - 1); //Remove extra
'|' char appended at the end
+}
+
+for (int nicIndex = nics.length - extraPublicNics;
nicIndex < nics.length; nicIndex++) {
+VirtualDevice nicDevice =
peerVmMo.getNicDeviceByIndex(nics[nicIndex].getDeviceId());
+if (nicDevice != null) {
+String mac =
((VirtualEthernetCard)nicDevice).getMacAddress();
+if (mac != null) {
+s_logger.info("Use same MAC as previous
RvR, the MAC is " + mac + " for extra NIC with device id: " +
nics[nicIndex].getDeviceId());
+nics[nicIndex].setMac(mac);
+}
+}
+}
+
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs)) {
+StringBuffer sbNewMacSequence = new StringBuffer();
Review comment:
Moved generating new nics mac sequence to a new private method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cloudmonger commented on issue #1866: Advanced isolated network egress destination cidr support added
cloudmonger commented on issue #1866: Advanced isolated network egress destination cidr support added URL: https://github.com/apache/cloudstack/pull/1866#issuecomment-283817472 ### ACS CI BVT Run **Sumarry:** Build Number 415 Hypervisor xenserver NetworkType Advanced Passed=100 Failed=5 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failed * test_02_isolate_network_FW_PF_default_routes_egress_false Failed * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed * test_03_RVR_Network_check_router_state Failed **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1866: Advanced isolated network egress destination cidr support added
cloudmonger commented on issue #1866: Advanced isolated network egress destination cidr support added URL: https://github.com/apache/cloudstack/pull/1866#issuecomment-300588390 ### ACS CI BVT Run **Sumarry:** Build Number 677 Hypervisor xenserver NetworkType Advanced Passed=108 Failed=4 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failed * test_02_isolate_network_FW_PF_default_routes_egress_false Failed * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 2 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places
GabrielBrascher commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2095#issuecomment-300547857 Updated code and Jira description. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kiwiflyer commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate
kiwiflyer commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-300536990 @Slair1 @swill Gents, where do we stand on this PR? I know there is a whole bunch of stuff related to this in 4.10, but this was opened against 4.9. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places
GabrielBrascher commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2095#issuecomment-300533439 Thanks @rafaelweingartner, I think that both points are valid, I will update them soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #2094: Agent logrotation
wido commented on issue #2094: Agent logrotation URL: https://github.com/apache/cloudstack/pull/2094#issuecomment-300533745 In this case it's Ubuntu only, not RPM. Didn't check them yet. But LGTM for Ubuntu in this case This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places
GabrielBrascher commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2095#issuecomment-300533439 Thanks @rafaelweingartner, I think that both points are valid, I will update them soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places
rafaelweingartner commented on issue #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2095#issuecomment-300529461 @GabrielBrascher is there any reason that you did not use the schema-4920to41000.sql? It does not seem to be required to use Java code for this change. Also, could you make it clearer why we need more decimal places? I think a more detailed explanation in the Jira ticket would do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher opened a new pull request #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places
GabrielBrascher opened a new pull request #2095: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2095 **Summary:** this commit alters column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. The current implementation allows up to 2 decimal places. **Issue:** need to use more than 2 decimal places to define resources values in Quota tariff. **Solution:** modify column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. Values with more than 5 decimal places will be displayed with scientific notation in the user interface. SQL command: "ALTER TABLE `cloud_usage`.`quota_tariff` MODIFY `currency_value` DECIMAL(15,5) not null" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] The-Loeki opened a new pull request #2093: Agent logrotation fixes
The-Loeki opened a new pull request #2093: Agent logrotation fixes URL: https://github.com/apache/cloudstack/pull/2093 The logrotation configuration file doesn't work for a variety of reasons, security_group logs aren't considered at all. This PR should fix those issues This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] The-Loeki opened a new pull request #2094: Agent logrotation
The-Loeki opened a new pull request #2094: Agent logrotation URL: https://github.com/apache/cloudstack/pull/2094 The logrotation configuration file doesn't work for a variety of reasons, security_group logs aren't considered at all. This PR should fix those issues This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] The-Loeki closed pull request #2093: Agent logrotation fixes
The-Loeki closed pull request #2093: Agent logrotation fixes URL: https://github.com/apache/cloudstack/pull/2093 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.
DaanHoogland commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-300482848 ok @yvsubhash thanks for the explanation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Divyanimmagadda commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster
Divyanimmagadda commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-300466615 Verified the PR with space in cluster name & data center name. Was able to attach a host in both cases. LGTM    This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Divyanimmagadda commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster
Divyanimmagadda commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-300466615 Verified the PR with space in cluster name & data center name. Was able to attach a host in both cases. LGTM    This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pavanb018 commented on issue #1322: Automation for CLOUDSTACK-9217 script to test block volume migration to a pool in maintenance mode
pavanb018 commented on issue #1322: Automation for CLOUDSTACK-9217 script to test block volume migration to a pool in maintenance mode URL: https://github.com/apache/cloudstack/pull/1322#issuecomment-300461482 Rebased this PR with latest master , the failure in travis is not related to the changes in this commit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300452430 ### ACS CI BVT Run **Sumarry:** Build Number 675 Hypervisor xenserver NetworkType Advanced Passed=111 Failed=1 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300371579 ### ACS CI BVT Run **Sumarry:** Build Number 674 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=2 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_vm_snapshots.py * test_change_service_offering_for_vm_with_snapshots Failed * test_router_dns.py * test_router_dns_guestipquery Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #1866: Advanced isolated network egress destination cidr support added
jayapalu commented on issue #1866: Advanced isolated network egress destination cidr support added URL: https://github.com/apache/cloudstack/pull/1866#issuecomment-300447696 This PR has template change (ipset command installation). So while testing this PR we need to generate new template and use it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor
sateesh-chodapuneedi commented on issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor URL: https://github.com/apache/cloudstack/pull/1664#issuecomment-300443992 Merged PR https://github.com/apache/cloudstack/pull/1417 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor
sateesh-chodapuneedi commented on issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor URL: https://github.com/apache/cloudstack/pull/1664#issuecomment-300443992 Merged PR https://github.com/apache/cloudstack/pull/1417 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2089: vRouters fixes & performance improvement
rhtyd commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300432412 Thanks for the tip @resmo will use it next time :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2089: vRouters fixes & performance improvement
rhtyd commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300432312 Thanks @The-Loeki This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
jayapalu commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-300431382 Code LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] The-Loeki commented on issue #2089: vRouters fixes & performance improvement
The-Loeki commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300426479 I just gave the -f This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2089: vRouters fixes & performance improvement
resmo commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300424361 @rhtyd btw, you can kick the travis job (since your are a github member) by yourself. Just authenticate by github and click the button "rebuild" on the top right corner ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2089: vRouters fixes & performance improvement
blueorangutan commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300416646 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2089: vRouters fixes & performance improvement
rhtyd commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300416450 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300413489 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300413415 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yvsubhash commented on a change in pull request #1985: CLOUDSTACK-9812:Update "updatePortForwardingRule" api to include additional parameter to update the end port in case of port range
yvsubhash commented on a change in pull request #1985: CLOUDSTACK-9812:Update
"updatePortForwardingRule" api to include additional parameter to update the
end port in case of port range
URL: https://github.com/apache/cloudstack/pull/1985#discussion_r115680398
##
File path: server/src/com/cloud/network/rules/RulesManagerImpl.java
##
@@ -1578,8 +1593,13 @@ public PortForwardingRule updatePortForwardingRule(long
id, Integer privatePort,
rule.setState(State.Add);
if (privatePort != null) {
rule.setDestinationPortStart(privatePort.intValue());
-rule.setDestinationPortEnd(privatePort.intValue());
+rule.setDestinationPortEnd((privateEndPort == null) ?
privatePort.intValue() : privateEndPort.intValue());
+}
+if (privateEndPort != null) {
+rule.setDestinationPortStart((privatePort == null) ?
privateEndPort.intValue() : privatePort.intValue());
Review comment:
else of part of conditional is redundant. already taken care in previous if
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yvsubhash commented on a change in pull request #1985: CLOUDSTACK-9812:Update "updatePortForwardingRule" api to include additional parameter to update the end port in case of port range
yvsubhash commented on a change in pull request #1985: CLOUDSTACK-9812:Update
"updatePortForwardingRule" api to include additional parameter to update the
end port in case of port range
URL: https://github.com/apache/cloudstack/pull/1985#discussion_r115680171
##
File path: server/src/com/cloud/network/rules/RulesManagerImpl.java
##
@@ -1578,8 +1593,13 @@ public PortForwardingRule updatePortForwardingRule(long
id, Integer privatePort,
rule.setState(State.Add);
if (privatePort != null) {
rule.setDestinationPortStart(privatePort.intValue());
-rule.setDestinationPortEnd(privatePort.intValue());
+rule.setDestinationPortEnd((privateEndPort == null) ?
privatePort.intValue() : privateEndPort.intValue());
+}
+if (privateEndPort != null) {
+rule.setDestinationPortStart((privatePort == null) ?
privateEndPort.intValue() : privatePort.intValue());
+rule.setDestinationPortEnd(privateEndPort);
Review comment:
This line is not needed. It would have got set already
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS
sateesh-chodapuneedi commented on issue #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS URL: https://github.com/apache/cloudstack/pull/1872#issuecomment-300410335 tag:mergeready This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2089: vRouters fixes & performance improvement
blueorangutan commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300409755 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2089: vRouters fixes & performance improvement
rhtyd commented on issue #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-300409504 @The-Loeki can you push -f again to rekick Travis, thanks @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking
for the iptables commands
URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300395989
In my local test test_02_redundant_VPC_default_routes is passed.
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
--
Ran 1 test in 795.766s
OK
===In Trillian it is failred because the VPC creation
failed.=
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : EXCEPTION ===
ERROR
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status :
FAILED ===
FAIL
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status :
FAILED ===
FAIL
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : FAILED ===
FAIL
=== TestName: test_05_rvpc_multi_tiers | Status : EXCEPTION ===
ERROR
==
ERROR: Create a redundant VPC with two networks with two VMs in each network
--
Traceback (most recent call last):
File "/marvin/tests/smoke/test_vpc_redundant.py", line 318, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4344, in
create
return VPC(apiclient.createVPC(cmd).__dict__)
File
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py",
line 2048, in createVPC
response = self.connection.marvinRequest(command,
response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py",
line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created :
u'2017-05-04T17:28:42+', jobresult : {errorcode : 530, errortext :
u'**Failed to create VPC**'}, cmd :
u'org.apache.cloudstack.api.command.admin.vpc.CreateVPCCmdByAdmin', userid :
u'42cfe558-308f-11e7-9381-06dcb4010722', jobstatus : 2, jobid :
u'd2bf42c3-76f1-403d-81cc-a5f660859faa', jobresultcode : 530, jobresulttype :
u'object', jobinstancetype : u'None', accountid :
u'42cfd80c-308f-11e7-9381-06dcb4010722'}
>> begin captured stdout << -
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status
: EXCEPTION ===
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] karuturi commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time
karuturi commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-300395543 @rashmidixit can you rebase with current master? The number of commits in this PR(109) doesnt seem right. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300394692 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
rhtyd commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-300394503 @jayapalu we'll need to reference the failures against baseline, I'll re-run the tests @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
