[GitHub] cloudmonger commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[git]

cloudmonger commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan 
range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-324821108
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 1142
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=4
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 7 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
134 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 
129 runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
129 runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_router_dnsservice.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

cloudmonger commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-324780057
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 1141
Hypervisor xenserver
NetworkType Advanced
Passed=112
Failed=7
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_volumes.py
   
* test_06_download_detached_volume Failing since 4 runs
   
   * test_host_annotations.py
   
* test_05_add_annotation_for_invvalid_entityType Failed
   
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 6 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
133 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 
128 runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
128 runs
   
* test_03_RVR_Network_check_router_state Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_router_dnsservice.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

cloudmonger commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316600302
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 987
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=7
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_deploy_vm_iso.py
   
* test_deploy_vm_from_iso Failing since 45 runs
   
   * test_vm_life_cycle.py
   
* test_10_attachAndDetach_iso Failing since 45 runs
   
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 78 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
78 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 76 
runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
76 runs
   
* test_03_RVR_Network_check_router_state Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_host_annotations.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents 
Communications
URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324736400
 
 
   Trillian test result (tid-1420)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47551 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2239-t1420-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 52 look OK, 6 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 126.54 | test_vpc_vpn.py
   test_05_rvpc_multi_tiers | `Failure` | 509.32 | test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 471.29 | 
test_vpc_redundant.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
437.19 | test_routers_network_ops.py
   test_04_rvpc_privategw_static_routes | `Failure` | 658.11 | 
test_privategw_acl.py
   test_05_iso_permissions | `Failure` | 0.06 | test_iso.py
   test_02_edit_iso | `Failure` | 0.07 | test_iso.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 536.09 | 
test_privategw_acl.py
   runTest | `Error` | 0.00 | test_certauthority_root.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_06_verify_guest_lspci_again | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_05_change_vm_ostype_restart | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_04_verify_guest_lspci | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py
   test_03_verify_libvirt_attach_disk | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_02_verify_libvirt_after_restart | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_verify_libvirt | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nathanejohnson opened a new pull request #2248: CLOUDSTACK-10056

[git]

nathanejohnson opened a new pull request #2248: CLOUDSTACK-10056
URL: https://github.com/apache/cloudstack/pull/2248
 
 
   fix bug where disk controller specified via vm details throws
   a NumberFormatException, since "scsi" is not a number.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1985: CLOUDSTACK-9812:Update "updatePortForwardingRule" api to include additional parameter to update the end port in case of port range

[git]

cloudmonger commented on issue #1985: CLOUDSTACK-9812:Update 
"updatePortForwardingRule" api to include additional parameter to update the 
end port in case of port range
URL: https://github.com/apache/cloudstack/pull/1985#issuecomment-324718999
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 1140
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=6
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_non_contigiousvlan.py
   
* test_extendPhysicalNetworkVlan Failed
   
   * test_volumes.py
   
* test_06_download_detached_volume Failing since 3 runs
   
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 5 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
132 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 
127 runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
127 runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_router_dnsservice.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_portforwardingrules.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1985: CLOUDSTACK-9812:Update "updatePortForwardingRule" api to include additional parameter to update the end port in case of port range

[git]

cloudmonger commented on issue #1985: CLOUDSTACK-9812:Update 
"updatePortForwardingRule" api to include additional parameter to update the 
end port in case of port range
URL: https://github.com/apache/cloudstack/pull/1985#issuecomment-304549448
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 764
Hypervisor xenserver
NetworkType Advanced
Passed=112
Failed=0
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

[git]

blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties 
has hardcoded id
URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324713763
 
 
   Trillian test result (tid-1419)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42493 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2243-t1419-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 52 look OK, 5 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 166.79 | test_vpc_vpn.py
   test_01_create_volume | `Failure` | 190.04 | test_volumes.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
407.76 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
442.30 | test_routers_network_ops.py
   test_04_rvpc_privategw_static_routes | `Failure` | 763.52 | 
test_privategw_acl.py
   test_05_iso_permissions | `Failure` | 0.07 | test_iso.py
   test_02_edit_iso | `Failure` | 0.08 | test_iso.py
   test_08_resize_volume | Skipped | 5.11 | test_volumes.py
   test_07_resize_fail | Skipped | 10.27 | test_volumes.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 34.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_06_verify_guest_lspci_again | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_05_change_vm_ostype_restart | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_04_verify_guest_lspci | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py
   test_03_verify_libvirt_attach_disk | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_02_verify_libvirt_after_restart | Skipped | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_verify_libvirt | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py
   test_deploy_vgpu_enabled_vm | Skipped | 1.23 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324706796
 
 
   Thanks @borisstoyanov , I'll keep this open for now until we receive the 
xenserver smoke test results. I'll merge this on satisfactory results.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[git]

yvsubhash commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan 
range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-324663047
 
 
   @ustcweizhou  Please review
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

cloudmonger commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-324217913
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 1131
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=8
Skipped=40
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_scale_vm.py
   
* ContextSuite context=TestScaleVm>:setup Failing since 37 runs
   
   * test_router_dns.py
   
* test_router_dns_guestipquery Failed
   
   * test_non_contigiousvlan.py
   
* test_extendPhysicalNetworkVlan Failed
   
   * test_list_ids_parameter.py
   
* ContextSuite context=TestListIdsParams>:setup Failing since 50 runs
   
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 
126 runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
126 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 
122 runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
122 runs
   
   
   **Skipped tests:**
   test_ha_kvm_host_degraded
   test_ha_kvm_host_fencing
   test_ha_kvm_host_recovering
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_disable_oobm_ha_state_ineligible
   test_hostha_configure_default_driver
   test_hostha_enable_ha_when_host_disabled
   test_hostha_enable_ha_when_host_disconected
   test_hostha_enable_ha_when_host_inMaintenance
   test_remove_ha_provider_not_possible
   test_configure_ha_provider_invalid
   test_configure_ha_provider_valid
   test_ha_disable_feature_invalid
   test_ha_enable_feature_invalid
   test_ha_enabledisable_across_clusterzones
   test_ha_list_providers
   test_ha_multiple_mgmt_server_ownership
   test_ha_verify_fsm_available
   test_ha_verify_fsm_degraded
   test_ha_verify_fsm_fenced
   test_ha_verify_fsm_recovering
   test_hostha_configure_default_driver
   test_hostha_configure_invalid_provider
   test_hostha_disable_feature_valid
   test_hostha_enable_feature_valid
   test_hostha_enable_feature_without_setting_provider
   test_list_ha_for_host
   test_list_ha_for_host_invalid
   test_list_ha_for_host_valid
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_router_dnsservice.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_outofbandmanagement_nestedplugin.py
   test_login.py
   test_deploy_vm_iso.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[git]

cloudmonger commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-324659451
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 1139
Hypervisor xenserver
NetworkType Advanced
Passed=115
Failed=5
Skipped=40
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_volumes.py
   
* test_06_download_detached_volume Failing since 2 runs
   
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 4 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
131 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 
126 runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
126 runs
   
   
   **Skipped tests:**
   test_ha_kvm_host_degraded
   test_ha_kvm_host_fencing
   test_ha_kvm_host_recovering
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_disable_oobm_ha_state_ineligible
   test_hostha_configure_default_driver
   test_hostha_enable_ha_when_host_disabled
   test_hostha_enable_ha_when_host_disconected
   test_hostha_enable_ha_when_host_inMaintenance
   test_remove_ha_provider_not_possible
   test_configure_ha_provider_invalid
   test_configure_ha_provider_valid
   test_ha_disable_feature_invalid
   test_ha_enable_feature_invalid
   test_ha_enabledisable_across_clusterzones
   test_ha_list_providers
   test_ha_multiple_mgmt_server_ownership
   test_ha_verify_fsm_available
   test_ha_verify_fsm_degraded
   test_ha_verify_fsm_fenced
   test_ha_verify_fsm_recovering
   test_hostha_configure_default_driver
   test_hostha_configure_invalid_provider
   test_hostha_disable_feature_valid
   test_hostha_enable_feature_valid
   test_hostha_enable_feature_without_setting_provider
   test_list_ha_for_host
   test_list_ha_for_host_invalid
   test_list_ha_for_host_valid
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_router_dnsservice.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_outofbandmanagement_nestedplugin.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324619991
 
 
   Thanks @DaanHoogland @nvazquez for reviewing
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing 
Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r135000362
 
 

 ##
 File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java
 ##
 @@ -0,0 +1,427 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.ca;
+
+import java.io.IOException;
+import java.math.BigInteger;
+import java.security.GeneralSecurityException;
+import java.security.cert.CertificateExpiredException;
+import java.security.cert.CertificateNotYetValidException;
+import java.security.cert.X509Certificate;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLEngine;
+
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.ca.IssueCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCAProvidersCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCaCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ProvisionCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.RevokeCertificateCmd;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.framework.ca.CAProvider;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.poll.BackgroundPollManager;
+import org.apache.cloudstack.poll.BackgroundPollTask;
+import org.apache.cloudstack.utils.identity.ManagementServerNode;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+import com.cloud.agent.AgentManager;
+import com.cloud.alert.AlertManager;
+import com.cloud.certificate.CrlVO;
+import com.cloud.certificate.dao.CrlDao;
+import com.cloud.event.ActionEvent;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.AgentUnavailableException;
+import com.cloud.exception.OperationTimedoutException;
+import com.cloud.host.Host;
+import com.cloud.host.Status;
+import com.cloud.host.dao.HostDao;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.google.common.base.Strings;
+
+public class CAManagerImpl extends ManagerBase implements CAManager {
+public static final Logger LOG = Logger.getLogger(CAManagerImpl.class);
+
+@Inject
+private CrlDao crlDao;
+@Inject
+private HostDao hostDao;
+@Inject
+private AgentManager agentManager;
+@Inject
+private BackgroundPollManager backgroundPollManager;
+@Inject
+private AlertManager alertManager;
+
+private static CAProvider configuredCaProvider;
+private static Map caProviderMap = new HashMap<>();
+private static Map alertMap = new ConcurrentHashMap<>();
+private static Map activeCertMap = new 
ConcurrentHashMap<>();
+
+private List caProviders;
+
+private CAProvider getConfiguredCaProvider() {
+if (configuredCaProvider == null && 
caProviderMap.containsKey(CAProviderPlugin.value())) {
+configuredCaProvider = caProviderMap.get(CAProviderPlugin.value());
+}
+if (configuredCaProvider == null) {
+throw new CloudRuntimeException("Failed to find default configured 
CA provider plugin");
+}
+return configuredCaProvider;
+}
 
 Review comment:
   @nvazquez thanks, anyway I made a change
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about 

[GitHub] marcaurele opened a new pull request #2247: Load SQL schema scripts from JAR

[git]

marcaurele opened a new pull request #2247: Load SQL schema scripts from JAR
URL: https://github.com/apache/cloudstack/pull/2247
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

[git]

blueorangutan commented on issue #2109: CLOUDSTACK-9922 Unable to use 8081 port 
for Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#issuecomment-324615099
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1020
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2225: [master] Smoketest health checkrun

[git]

blueorangutan commented on issue #2225: [master] Smoketest health checkrun
URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-324615091
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1019
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

[git]

blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for 
limit to CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-324615076
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1018
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

nvazquez commented on a change in pull request #2239: CLOUDSTACK-9993: Securing 
Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134995533
 
 

 ##
 File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java
 ##
 @@ -0,0 +1,427 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.ca;
+
+import java.io.IOException;
+import java.math.BigInteger;
+import java.security.GeneralSecurityException;
+import java.security.cert.CertificateExpiredException;
+import java.security.cert.CertificateNotYetValidException;
+import java.security.cert.X509Certificate;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLEngine;
+
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.ca.IssueCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCAProvidersCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCaCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ProvisionCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.RevokeCertificateCmd;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.framework.ca.CAProvider;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.poll.BackgroundPollManager;
+import org.apache.cloudstack.poll.BackgroundPollTask;
+import org.apache.cloudstack.utils.identity.ManagementServerNode;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+import com.cloud.agent.AgentManager;
+import com.cloud.alert.AlertManager;
+import com.cloud.certificate.CrlVO;
+import com.cloud.certificate.dao.CrlDao;
+import com.cloud.event.ActionEvent;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.AgentUnavailableException;
+import com.cloud.exception.OperationTimedoutException;
+import com.cloud.host.Host;
+import com.cloud.host.Status;
+import com.cloud.host.dao.HostDao;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.google.common.base.Strings;
+
+public class CAManagerImpl extends ManagerBase implements CAManager {
+public static final Logger LOG = Logger.getLogger(CAManagerImpl.class);
+
+@Inject
+private CrlDao crlDao;
+@Inject
+private HostDao hostDao;
+@Inject
+private AgentManager agentManager;
+@Inject
+private BackgroundPollManager backgroundPollManager;
+@Inject
+private AlertManager alertManager;
+
+private static CAProvider configuredCaProvider;
+private static Map caProviderMap = new HashMap<>();
+private static Map alertMap = new ConcurrentHashMap<>();
+private static Map activeCertMap = new 
ConcurrentHashMap<>();
+
+private List caProviders;
+
+private CAProvider getConfiguredCaProvider() {
+if (configuredCaProvider == null && 
caProviderMap.containsKey(CAProviderPlugin.value())) {
+configuredCaProvider = caProviderMap.get(CAProviderPlugin.value());
+}
+if (configuredCaProvider == null) {
+throw new CloudRuntimeException("Failed to find default configured 
CA provider plugin");
+}
+return configuredCaProvider;
+}
 
 Review comment:
   You are right, sorry I ommited set line, then makes no sense to refactor in 
my opinion
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above 

[GitHub] blueorangutan commented on issue #2225: [master] Smoketest health checkrun

[git]

blueorangutan commented on issue #2225: [master] Smoketest health checkrun
URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-324608454
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

[git]

blueorangutan commented on issue #2109: CLOUDSTACK-9922 Unable to use 8081 port 
for Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#issuecomment-324608461
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

[git]

rhtyd commented on issue #2109: CLOUDSTACK-9922 Unable to use 8081 port for 
Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#issuecomment-324608347
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2225: [master] Smoketest health checkrun

[git]

rhtyd commented on issue #2225: [master] Smoketest health checkrun
URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-324608432
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

[git]

blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for 
limit to CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-324608068
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

[git]

rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to 
CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-324607928
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9996: Fix juniper vlan untagged jedgement and xml element replacment (#2174)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new a8c09f2  CLOUDSTACK-9996: Fix juniper vlan untagged jedgement and xml 
element replacment (#2174)
a8c09f2 is described below

commit a8c09f2a1980757eb7a9da4a178dc27da08df2ed
Author: digitalgust 
AuthorDate: Thu Aug 24 19:22:06 2017 +0800

CLOUDSTACK-9996: Fix juniper vlan untagged jedgement and xml element 
replacment (#2174)

Fix  juniper vlan untagged jedgement and xml element replacment.
---
 .../src/com/cloud/network/resource/JuniperSrxResource.java| 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
 
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
index d60ccb6..75c7583 100644
--- 
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
+++ 
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
@@ -2841,8 +2841,8 @@ public class JuniperSrxResource implements ServerResource 
{
 action = "";
 }
 
-xml = replaceXmlValue(xml, "action", action);
 }
+xml = replaceXmlValue(xml, "action", action);
 } else {
 xml = replaceXmlValue(xml, "from-zone", fromZone);
 xml = replaceXmlValue(xml, "to-zone", toZone);
@@ -3611,7 +3611,7 @@ public class JuniperSrxResource implements ServerResource 
{
 
 private Long getVlanTag(String vlan) throws ExecutionException {
 Long publicVlanTag = null;
-if (!vlan.equals("untagged")) {
+if (!vlan.contains("untagged")) {
 try {
 // make sure this vlan is numeric
 publicVlanTag = 
Long.parseLong(BroadcastDomainType.getValue(vlan));

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd closed pull request #2174: CLOUDSTACK-9996 : bug in juniper srx Resource vlan untagged jedgement and xml element replacment.

[git]

rhtyd closed pull request #2174: CLOUDSTACK-9996 :  bug in juniper srx Resource 
vlan untagged jedgement and xml element replacment.
URL: https://github.com/apache/cloudstack/pull/2174
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9915 ListSnapshots API does not provide virtual size information of the snapshots (#2101)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 4b38d36  CLOUDSTACK-9915  ListSnapshots API does not provide virtual 
size information of the snapshots (#2101)
4b38d36 is described below

commit 4b38d362842aab1ff459d76f75e09c19fe0fa6f0
Author: vedulasantosh 
AuthorDate: Thu Aug 24 16:51:13 2017 +0530

CLOUDSTACK-9915  ListSnapshots API does not provide virtual size 
information of the snapshots (#2101)
---
 api/src/org/apache/cloudstack/api/ApiConstants.java  | 1 +
 api/src/org/apache/cloudstack/api/response/SnapshotResponse.java | 8 
 server/src/com/cloud/api/ApiResponseHelper.java  | 1 +
 3 files changed, 10 insertions(+)

diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index 6421fb3..b77b83a 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -653,6 +653,7 @@ public class ApiConstants {
 public static final String OVM3_CLUSTER = "ovm3cluster";
 public static final String OVM3_VIP = "ovm3vip";
 public static final String CLEAN_UP_DETAILS = "cleanupdetails";
+public static final String VIRTUAL_SIZE = "virtualsize";
 public static final String NETSCALER_CONTROLCENTER_ID = 
"netscalercontrolcenterid";
 public static final String NETSCALER_SERVICEPACKAGE_ID = 
"netscalerservicepackageid";
 
diff --git a/api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 
b/api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
index a49a4e3..bb2ff7f 100644
--- a/api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
+++ b/api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
@@ -112,6 +112,10 @@ public class SnapshotResponse extends BaseResponse 
implements ControlledEntityRe
 @Param(description = "display name of the os on volume")
 private String osDisplayName;
 
+@SerializedName(ApiConstants.VIRTUAL_SIZE)
+@Param(description = "virtual size of backedup snapshot on image store")
+private long virtualSize;
+
 @Override
 public String getObjectId() {
 return this.getId();
@@ -221,4 +225,8 @@ public class SnapshotResponse extends BaseResponse 
implements ControlledEntityRe
 public void setOsDisplayName(String osDisplayName) {
 this.osDisplayName = osDisplayName;
 }
+
+public void setVirtualSize(long virtualSize) {
+this.virtualSize = virtualSize;
+}
 }
\ No newline at end of file
diff --git a/server/src/com/cloud/api/ApiResponseHelper.java 
b/server/src/com/cloud/api/ApiResponseHelper.java
index 80633e1..82f9397 100644
--- a/server/src/com/cloud/api/ApiResponseHelper.java
+++ b/server/src/com/cloud/api/ApiResponseHelper.java
@@ -480,6 +480,7 @@ public class ApiResponseHelper implements ResponseGenerator 
{
 snapshotResponse.setVolumeId(volume.getUuid());
 snapshotResponse.setVolumeName(volume.getName());
 snapshotResponse.setVolumeType(volume.getVolumeType().name());
+snapshotResponse.setVirtualSize(volume.getSize());
 DataCenter zone = 
ApiDBUtils.findZoneById(volume.getDataCenterId());
 if (zone != null) {
 snapshotResponse.setZoneId(zone.getUuid());

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd closed pull request #2101: CLOUDSTACK-9915 ListSnapshots API does not provide virtual size information of the snapshots

[git]

rhtyd closed pull request #2101: CLOUDSTACK-9915  ListSnapshots API does not 
provide virtual size information of the snapshots
URL: https://github.com/apache/cloudstack/pull/2101
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2101: CLOUDSTACK-9915 ListSnapshots API does not provide virtual size information of the snapshots

[git]

rhtyd commented on issue #2101: CLOUDSTACK-9915  ListSnapshots API does not 
provide virtual size information of the snapshots
URL: https://github.com/apache/cloudstack/pull/2101#issuecomment-324607677
 
 
   LGTM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing 
Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134988726
 
 

 ##
 File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java
 ##
 @@ -0,0 +1,427 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.ca;
+
+import java.io.IOException;
+import java.math.BigInteger;
+import java.security.GeneralSecurityException;
+import java.security.cert.CertificateExpiredException;
+import java.security.cert.CertificateNotYetValidException;
+import java.security.cert.X509Certificate;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLEngine;
+
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.ca.IssueCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCAProvidersCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCaCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ProvisionCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.RevokeCertificateCmd;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.framework.ca.CAProvider;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.poll.BackgroundPollManager;
+import org.apache.cloudstack.poll.BackgroundPollTask;
+import org.apache.cloudstack.utils.identity.ManagementServerNode;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+import com.cloud.agent.AgentManager;
+import com.cloud.alert.AlertManager;
+import com.cloud.certificate.CrlVO;
+import com.cloud.certificate.dao.CrlDao;
+import com.cloud.event.ActionEvent;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.AgentUnavailableException;
+import com.cloud.exception.OperationTimedoutException;
+import com.cloud.host.Host;
+import com.cloud.host.Status;
+import com.cloud.host.dao.HostDao;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.google.common.base.Strings;
+
+public class CAManagerImpl extends ManagerBase implements CAManager {
+public static final Logger LOG = Logger.getLogger(CAManagerImpl.class);
+
+@Inject
+private CrlDao crlDao;
+@Inject
+private HostDao hostDao;
+@Inject
+private AgentManager agentManager;
+@Inject
+private BackgroundPollManager backgroundPollManager;
+@Inject
+private AlertManager alertManager;
+
+private static CAProvider configuredCaProvider;
+private static Map caProviderMap = new HashMap<>();
+private static Map alertMap = new ConcurrentHashMap<>();
+private static Map activeCertMap = new 
ConcurrentHashMap<>();
+
+private List caProviders;
+
+private CAProvider getConfiguredCaProvider() {
+if (configuredCaProvider == null && 
caProviderMap.containsKey(CAProviderPlugin.value())) {
+configuredCaProvider = caProviderMap.get(CAProviderPlugin.value());
+}
+if (configuredCaProvider == null) {
+throw new CloudRuntimeException("Failed to find default configured 
CA provider plugin");
+}
+return configuredCaProvider;
+}
 
 Review comment:
   @nvazquez sure, however if the second `else if`, we want to set and then 
return, it would be the same kind of code again.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log 

[GitHub] nvazquez commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

nvazquez commented on a change in pull request #2239: CLOUDSTACK-9993: Securing 
Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134985306
 
 

 ##
 File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java
 ##
 @@ -0,0 +1,427 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.ca;
+
+import java.io.IOException;
+import java.math.BigInteger;
+import java.security.GeneralSecurityException;
+import java.security.cert.CertificateExpiredException;
+import java.security.cert.CertificateNotYetValidException;
+import java.security.cert.X509Certificate;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLEngine;
+
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.ca.IssueCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCAProvidersCmd;
+import org.apache.cloudstack.api.command.admin.ca.ListCaCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.ProvisionCertificateCmd;
+import org.apache.cloudstack.api.command.admin.ca.RevokeCertificateCmd;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.framework.ca.CAProvider;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.poll.BackgroundPollManager;
+import org.apache.cloudstack.poll.BackgroundPollTask;
+import org.apache.cloudstack.utils.identity.ManagementServerNode;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+import com.cloud.agent.AgentManager;
+import com.cloud.alert.AlertManager;
+import com.cloud.certificate.CrlVO;
+import com.cloud.certificate.dao.CrlDao;
+import com.cloud.event.ActionEvent;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.AgentUnavailableException;
+import com.cloud.exception.OperationTimedoutException;
+import com.cloud.host.Host;
+import com.cloud.host.Status;
+import com.cloud.host.dao.HostDao;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.google.common.base.Strings;
+
+public class CAManagerImpl extends ManagerBase implements CAManager {
+public static final Logger LOG = Logger.getLogger(CAManagerImpl.class);
+
+@Inject
+private CrlDao crlDao;
+@Inject
+private HostDao hostDao;
+@Inject
+private AgentManager agentManager;
+@Inject
+private BackgroundPollManager backgroundPollManager;
+@Inject
+private AlertManager alertManager;
+
+private static CAProvider configuredCaProvider;
+private static Map caProviderMap = new HashMap<>();
+private static Map alertMap = new ConcurrentHashMap<>();
+private static Map activeCertMap = new 
ConcurrentHashMap<>();
+
+private List caProviders;
+
+private CAProvider getConfiguredCaProvider() {
+if (configuredCaProvider == null && 
caProviderMap.containsKey(CAProviderPlugin.value())) {
+configuredCaProvider = caProviderMap.get(CAProviderPlugin.value());
+}
+if (configuredCaProvider == null) {
+throw new CloudRuntimeException("Failed to find default configured 
CA provider plugin");
+}
+return configuredCaProvider;
+}
 
 Review comment:
   What about refactoring method a little bit to something like
   
   if (configuredCaProvider != null) return configuredCaProvider
   else if (caProviderMap.containsKey(..) && caProviderMap.get(..) != null) 
return caProviderMap.get(..);
   else throw new 

[GitHub] cloudmonger commented on issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached volume

[git]

cloudmonger commented on issue #1911: CLOUDSTACK-9742:Simultaneous snapshots 
for detached volume
URL: https://github.com/apache/cloudstack/pull/1911#issuecomment-308278559
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 837
Hypervisor xenserver
NetworkType Advanced
Passed=108
Failed=5
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 25 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
25 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 25 
runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
25 runs
   
* test_03_RVR_Network_check_router_state Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached volume

[git]

cloudmonger commented on issue #1911: CLOUDSTACK-9742:Simultaneous snapshots 
for detached volume
URL: https://github.com/apache/cloudstack/pull/1911#issuecomment-324602107
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 1138
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=8
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_loadbalance.py
   
* test_01_create_lb_rule_src_nat Failed
   
* test_02_create_lb_rule_non_nat Failed
   
* test_assign_and_removal_lb Failed
   
   * test_volumes.py
   
* test_06_download_detached_volume Failed
   
   * test_routers_network_ops.py
   
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 3 
runs
   
* test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 
130 runs
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 
125 runs
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
125 runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_router_dnsservice.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134984040
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/annotation/ListAnnotationsCmd.java
 ##
 @@ -0,0 +1,81 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+
+@APICommand(name = ListAnnotationsCmd.APINAME, description = "Lists 
annotations.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, 
since = "4.11", authorized = {RoleType.Admin})
 
 Review comment:
   I don't see an above which is probably obfuscated by a rebase but as for 
this; we do not allow anybody but admins to annotate for now. When we find use 
cases we can add them here
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134983298
 
 

 ##
 File path: 
server/src/org/apache/cloudstack/annotation/AnnotationManagerImpl.java
 ##
 @@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.annotation;
+
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.component.PluggableService;
+import org.apache.cloudstack.annotation.dao.AnnotationDao;
+import org.apache.cloudstack.api.command.admin.annotation.AddAnnotationCmd;
+import org.apache.cloudstack.api.command.admin.annotation.ListAnnotationsCmd;
+import org.apache.cloudstack.api.command.admin.annotation.RemoveAnnotationCmd;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * @since 4.11
+ */
+public final class AnnotationManagerImpl extends ManagerBase implements 
AnnotationService, PluggableService {
+public static final Logger s_logger = 
Logger.getLogger(AnnotationManagerImpl.class);
+
+@Inject
+private AnnotationDao annotationDao;
+
+@Override
+public ListResponse 
searchForAnnotations(ListAnnotationsCmd cmd) {
+List annotations =
+getAnnotationsForApiCmd(cmd);
+List annotationResponses =
+convertAnnotationsToResponses(annotations);
+return createAnnotationsResponseList(annotationResponses);
+}
+
+@Override
+public AnnotationResponse addAnnotation(AddAnnotationCmd addAnnotationCmd) 
{
+return addAnnotation(addAnnotationCmd.getAnnotation(), 
addAnnotationCmd.getEntityType(), addAnnotationCmd.getEntityUuid());
+}
+
+public AnnotationResponse addAnnotation(String text, EntityType type, 
String uuid) {
 
 Review comment:
   will add
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134983243
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/annotation/RemoveAnnotationCmd.java
 ##
 @@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+
+/**
+ * @since 4.11
+ */
+@APICommand(name = RemoveAnnotationCmd.APINAME, description = "remove an 
annotation.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class RemoveAnnotationCmd extends BaseCmd{
+
+@Parameter(name = ApiConstants.ID, type = CommandType.STRING, required = 
true, description = "the id of the annotation")
+private String uuid;
+
+public String getUuid() {
 
 Review comment:
   I addressed this earlier, don't know why it stuck here but as clear from the 
fragment the variable is above the getter.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134983068
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/response/AnnotationResponse.java
 ##
 @@ -0,0 +1,121 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.response;
+
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.annotation.Annotation;
+import org.apache.cloudstack.annotation.AnnotationService;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseResponse;
+import org.apache.cloudstack.api.EntityReference;
+
+import java.util.Date;
+
+/**
+ * @since 4.11
 
 Review comment:
   I'm just answerring this once for all the below as well: This is javadoc 
that might be helpfull for a developer working in an IDE in several versions at 
once. It is not useless unless there is a regular annotation as well.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134981905
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/BaseCmd.java
 ##
 @@ -192,6 +191,8 @@
 public AlertService _alertSvc;
 @Inject
 public UUIDManager _uuidMgr;
+@Inject
+public AnnotationService annotationService;
 
 Review comment:
   As discussed, this is a breakage of pattern in the code base that goes two 
ways. Adhering to one and not the other has downsides either way. Not important 
now (in this PR) but worth revisiting is how to poetically describe used 
services per API without having to describe the samething over and over per set 
of API, i.e. the Annotation APIs.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131885935
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/BaseCmd.java
 ##
 @@ -192,6 +191,8 @@
 public AlertService _alertSvc;
 @Inject
 public UUIDManager _uuidMgr;
+@Inject
+public AnnotationService annotationService;
 
 Review comment:
   addressed with the a contains method on the Enum and precondition, @rhtyd 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on a change in pull request #2181: CLOUDSTACK-9957 
Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134981342
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java
 ##
 @@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.google.common.base.Preconditions;
+import org.apache.cloudstack.annotation.AnnotationService;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+
+/**
+ * @since 4.11
+ */
+@APICommand(name = AddAnnotationCmd.APINAME, description = "add an 
annotation.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class AddAnnotationCmd extends BaseCmd{
+
+@Parameter(name = ApiConstants.ANNOTATION, type = CommandType.STRING, 
description = "the annotation text")
+private String annotation;
+@Parameter(name = ApiConstants.ENTITY_TYPE, type = CommandType.STRING, 
description = "the entity type")
+private String entityType;
+@Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING, 
description = "the id of the entity to annotate")
+private String entityUuid;
+
+public String getAnnotation() {
+return annotation;
+}
+
+public AnnotationService.EntityType getEntityType() {
+return AnnotationService.EntityType.valueOf(entityType);
 
 Review comment:
   addressed with the a contains method on the Enum and precondition,
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316559048
 
 
   Trillian test result (tid-1210)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40257 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2181-t1210-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Test completed. 49 look ok, 5 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 521.92 | 
test_privategw_acl.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_vpc_site2site_vpn | Success | 175.00 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 66.11 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 320.81 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 269.49 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 599.06 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 525.39 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1415.94 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 578.22 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 783.46 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1315.03 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 156.70 | test_volumes.py
   test_08_resize_volume | Success | 156.46 | test_volumes.py
   test_07_resize_fail | Success | 161.46 | test_volumes.py
   test_06_download_detached_volume | Success | 151.31 | test_volumes.py
   test_05_detach_volume | Success | 150.81 | test_volumes.py
   test_04_delete_attached_volume | Success | 146.23 | test_volumes.py
   test_03_download_attached_volume | Success | 156.25 | test_volumes.py
   test_02_attach_volume | Success | 89.29 | test_volumes.py
   test_01_create_volume | Success | 713.10 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 100.82 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 163.87 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 252.57 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.77 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 30.91 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.83 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.15 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 70.61 | test_templates.py
   test_08_list_system_templates | Success | 0.04 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.06 | test_templates.py
   test_04_extract_template | Success | 5.15 | test_templates.py
   test_03_delete_template | Success | 5.10 | test_templates.py
   test_02_edit_template | Success | 90.16 | test_templates.py
   test_01_create_template | Success | 60.56 | test_templates.py
   test_10_destroy_cpvm | Success | 161.69 | test_ssvm.py
   test_09_destroy_ssvm | Success | 163.59 | test_ssvm.py
   test_08_reboot_cpvm | Success | 131.72 | test_ssvm.py
   test_07_reboot_ssvm | Success | 133.74 | test_ssvm.py
   test_06_stop_cpvm | Success | 161.88 | test_ssvm.py
   test_05_stop_ssvm | Success | 164.03 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.25 | test_ssvm.py
   test_03_ssvm_internals | Success | 4.11 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 81.83 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 16.25 | test_snapshots.py
   test_04_change_offering_small | Success | 239.81 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py
   test_02_edit_service_offering | 

[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316379076
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-805
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316379199
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316379181
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316372409
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations

[git]

DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-316372228
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

[git]

rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r134980232
 
 

 ##
 File path: api/src/org/apache/cloudstack/annotation/AnnotationService.java
 ##
 @@ -0,0 +1,49 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.annotation;
+
+import org.apache.cloudstack.api.command.admin.annotation.AddAnnotationCmd;
+import org.apache.cloudstack.api.command.admin.annotation.ListAnnotationsCmd;
+import org.apache.cloudstack.api.command.admin.annotation.RemoveAnnotationCmd;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+
+public interface AnnotationService {
+ListResponse searchForAnnotations(ListAnnotationsCmd 
cmd);
+
+AnnotationResponse addAnnotation(AddAnnotationCmd addAnnotationCmd);
+AnnotationResponse addAnnotation(String text, EntityType type, String 
uuid);
+
+AnnotationResponse removeAnnotation(RemoveAnnotationCmd 
removeAnnotationCmd);
+
+enum EntityType {
+HOST("host"), DOMAIN("domain"), VM("vm_instance");
+private String tableName;
+
+EntityType(String tableName) {
+this.tableName = tableName;
+}
+static public boolean contains(String representation) {
+try {
+/* EntityType tiep = */ valueOf(representation);
 
 Review comment:
   Maybe remove comments throughout the code base that are may not be very 
useful or obvious 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs

[git]

blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make 
marvin work with projects and VPCs
URL: https://github.com/apache/cloudstack/pull/2206#issuecomment-324566241
 
 
   Trillian test result (tid-1415)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44675 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2206-t1415-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 51 look OK, 6 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 81.08 | test_vpc_vpn.py
   test_04_rvpc_privategw_static_routes | `Failure` | 416.55 | 
test_privategw_acl.py
   test_05_iso_permissions | `Failure` | 0.05 | test_iso.py
   test_02_edit_iso | `Failure` | 0.05 | test_iso.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1817.24 
| test_routers_network_ops.py
   ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 78.79 | 
test_deploy_virtio_scsi_vm.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.01 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

[git]

blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation 
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324550168
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

[git]

DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for 
any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324549949
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

[git]

blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns 
malformed URL after migrating?
URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324548909
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1017
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents 
Communications
URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324545007
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

[git]

blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns 
malformed URL after migrating?
URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324544827
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

[git]

rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324544888
 
 
   @blueorangutan test centos7 xenserver-65sp1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

[git]

blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties 
has hardcoded id
URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324544673
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

[git]

rhtyd commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns 
malformed URL after migrating?
URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324544744
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

[git]

rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has 
hardcoded id
URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324544552
 
 
   @mrunalinikankariya can you check and fix the errors, are issues around iso 
permissions (public or not) should not happen, the test failed twice.
   @blueorangutan test centos7 vmware-55u3
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services