date:20170914

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139068658
 
 

 ##
 File path: test/integration/component/test_host.py
 ##
 @@ -0,0 +1,205 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __builtin__ import False
+""" BVT tests for Hosts Test
+"""
+
+# Import Local Modules
+from marvin.codes import FAILED
+from marvin.cloudstackTestCase import *
+from marvin.cloudstackAPI import *
+from marvin.lib.utils import *
+from marvin.lib.base import *
+from marvin.lib.common import *
+from nose.plugins.attrib import attr
+from marvin.sshClient import SshClient
+import time
+from time import sleep
+
+_multiprocess_shared_ = False
+
+
+class TestHostHA(cloudstackTestCase):
 
 Review comment:
   @mrunalinikankariya please send a new PR with requested changes
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting 
cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-329688178
 
 
   I reviewed the code, as @koushik-das mentioned further investigation may be 
needed to look into why hosts would not be accepted immediately. The solution 
might work, however, we may need further analysis. @mrunalinikankariya 
@SudharmaJain @yvsubhash @vedulasantosh JIRA ticket does not mention, can you 
comment which hypervisors/hosts you had seen this issue?  It seems only direct 
agents such as xen, vmware resources may be affected, then indirect agents such 
as KVM (agents).
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139067324
 
 

 ##
 File path: test/integration/component/test_host.py
 ##
 @@ -0,0 +1,205 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __builtin__ import False
+""" BVT tests for Hosts Test
+"""
+
+# Import Local Modules
+from marvin.codes import FAILED
+from marvin.cloudstackTestCase import *
+from marvin.cloudstackAPI import *
+from marvin.lib.utils import *
+from marvin.lib.base import *
+from marvin.lib.common import *
+from nose.plugins.attrib import attr
+from marvin.sshClient import SshClient
+import time
+from time import sleep
+
+_multiprocess_shared_ = False
+
+
+class TestHostHA(cloudstackTestCase):
 
 Review comment:
   @mrunalinikankariya the ping timeout/intervals are configurable to speed up 
wait time, also in the code you've put `wait_until(10,10` if this already 
passes then the test should run in likely 100seconds or less, that less than 10 
minutes and qualifies the test to be put in smoke tests. I also see an 
outstanding comment from Koushik which was not answered.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 
: After restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139063678
 
 

 ##
 File path: test/integration/component/test_host.py
 ##
 @@ -0,0 +1,205 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __builtin__ import False
+""" BVT tests for Hosts Test
+"""
+
+# Import Local Modules
+from marvin.codes import FAILED
+from marvin.cloudstackTestCase import *
+from marvin.cloudstackAPI import *
+from marvin.lib.utils import *
+from marvin.lib.base import *
+from marvin.lib.common import *
+from nose.plugins.attrib import attr
+from marvin.sshClient import SshClient
+import time
+from time import sleep
+
+_multiprocess_shared_ = False
+
+
+class TestHostHA(cloudstackTestCase):
 
 Review comment:
   This test wait for management-server to be up and hence it takes long time 
to run. So this cannot be move to smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nathanejohnson commented on issue #2248: CLOUDSTACK-10056

2017-09-14 Thread git

nathanejohnson commented on issue #2248: CLOUDSTACK-10056
URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329600465
 
 
   @rthyd that sounds like a better approach.  I'll get this updated ASAP
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to 
KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329591545
 
 
   Trillian test result (tid-1510)
   Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35164 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t1510-kvm-centos6.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 57 look OK, 5 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 61.02 | test_vpc_vpn.py
   test_04_rvpc_privategw_static_routes | `Failure` | 395.96 | 
test_privategw_acl.py
   test_05_iso_permissions | `Failure` | 0.05 | test_iso.py
   test_02_edit_iso | `Failure` | 0.14 | test_iso.py
   test_05_change_vm_ostype_restart | `Failure` | 16.17 | 
test_deploy_virtio_scsi_vm.py
   test_03_verify_libvirt_attach_disk | `Failure` | 10.88 | 
test_deploy_virtio_scsi_vm.py
   test_02_verify_libvirt_after_restart | `Failure` | 141.72 | 
test_deploy_virtio_scsi_vm.py
   test_01_verify_libvirt | `Failure` | 0.65 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | 
test_list_ids_parameter.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Skipped | 0.00 | 
test_snapshots.py
   test_01_snapshot_root_disk | Skipped | 0.00 | test_snapshots.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | Skipped | 0.02 | 
test_hostha_simulator.py
   test_hostha_enable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_configure_invalid_provider | Skipped | 0.02 | 
test_hostha_simulator.py
   test_hostha_configure_default_driver | Skipped | 0.02 | 
test_hostha_simulator.py
   test_ha_verify_fsm_recovering | Skipped | 0.04 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simulator.py
   test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | 
test_hostha_simulator.py
   test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | Skipped | 0.03 | test_hostha_simulator.py
   test_configure_ha_provider_invalid | Skipped | 0.03 | 
test_hostha_simulator.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-14 Thread git

blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation 
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329473928
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1084
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID

2017-09-14 Thread git

blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance 
improvement: caching of NuageVsp ID
URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329473736
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1083
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879584
 
 

 ##
 File path: test/integration/component/test_host.py
 ##
 @@ -0,0 +1,205 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __builtin__ import False
+""" BVT tests for Hosts Test
+"""
+
+# Import Local Modules
+from marvin.codes import FAILED
+from marvin.cloudstackTestCase import *
+from marvin.cloudstackAPI import *
+from marvin.lib.utils import *
+from marvin.lib.base import *
+from marvin.lib.common import *
+from nose.plugins.attrib import attr
+from marvin.sshClient import SshClient
+import time
+from time import sleep
+
+_multiprocess_shared_ = False
+
+
+class TestHostHA(cloudstackTestCase):
 
 Review comment:
   @mrunalinikankariya @harikrishna-patnala  advise if this test can run rather 
quickly -- if so let's include them in smoke tests folder instead? Also, the PR 
has no test results/reports from this new test.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879356
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -991,7 +995,9 @@ public boolean updateState(Status oldStatus, Event event, 
Status newStatus, Host
 }
 }
 if (event.equals(Event.ManagementServerDown)) {
-ub.set(host, _pingTimeAttr, ((System.currentTimeMillis() >> 10) - 
(10 * 60)));
+Float pingTimeout = 
NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"), 2.5f);
 
 Review comment:
   @mrunalinikankariya please move towards using ConfigKeys, refactorings are 
requested.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879256
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -144,6 +146,8 @@
 protected HostTransferMapDao _hostTransferDao;
 @Inject
 protected ClusterDao _clusterDao;
+@Inject
+private ConfigurationDao _configDao;
 
 Review comment:
   @mrunalinikankariya please re-submit a PR that uses a ConfigKey based 
approach than use direct read/manipulation based on `configDao`.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting 
cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-329467492
 
 
   @harikrishna-patnala why was this PR merged without tests? This affects 
clustering of management servers and the code/commit was pushed after last BVT 
test results/reports, in which case a fresh test run would be been perfect. In 
future you or anyone may ping @borisstoyanov or I and we can help with 
reviewing and running tests. Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2248: CLOUDSTACK-10056

2017-09-14 Thread git

rhtyd commented on issue #2248: CLOUDSTACK-10056
URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329466076
 
 
   @bvbharat @bvbharatk comment please?
   @nathanejohnson can you change the implementation to restrict the double bye 
handling code to work only for details keys - `cpuNumber`, `cpuSpeed` and 
`memory`? For rest we should simply read the string value with no addtional 
transformations.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-14 Thread git

blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation 
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329465920
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-09-14 Thread git

rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any 
java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329465744
 
 
   @DaanHoogland @borisstoyanov @nvazquez we happy with the review, tests?
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10019: template.properties has hardcoded id (#2243)

2017-09-14 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new c7a55eb  CLOUDSTACK-10019: template.properties has hardcoded id (#2243)
c7a55eb is described below

commit c7a55eb812b6b85e0e9715b95f3049c143ca0d39
Author: mrunalinikankariya 
AuthorDate: Thu Sep 14 17:54:12 2017 +0530

CLOUDSTACK-10019: template.properties has hardcoded id (#2243)

The template.properties file created after creating template from snapshot 
has hardcoded id = 1.
The id should have template ID.
---
 .../cloudstack/storage/resource/NfsSecondaryStorageResource.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
 
b/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
index 4980d97..68569ea 100644
--- 
a/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
+++ 
b/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
@@ -463,7 +463,7 @@ public class NfsSecondaryStorageResource extends 
ServerResourceBase implements S
 FormatInfo info = processor.process(destPath, null, templateUuid);
 
 TemplateLocation loc = new TemplateLocation(_storage, destPath);
-loc.create(1, true, templateUuid);
+loc.create(destData.getId(), true, templateUuid);
 loc.addFormat(info);
 loc.save();
 TemplateProp prop = loc.getTemplateInfo();
@@ -553,7 +553,7 @@ public class NfsSecondaryStorageResource extends 
ServerResourceBase implements S
 
 FormatInfo info = processor.process(destPath, null, 
templateName);
 TemplateLocation loc = new TemplateLocation(_storage, 
destPath);
-loc.create(1, true, destData.getName());
+loc.create(destData.getId(), true, destData.getName());
 loc.addFormat(info);
 loc.save();
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd closed pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-09-14 Thread git

rhtyd closed pull request #2243: CLOUDSTACK-10019:template.properties has 
hardcoded id
URL: https://github.com/apache/cloudstack/pull/2243
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID

2017-09-14 Thread git

blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance 
improvement: caching of NuageVsp ID
URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329465465
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-09-14 Thread git

rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has 
hardcoded id
URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-329465479
 
 
   LGTM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID

2017-09-14 Thread git

rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: 
caching of NuageVsp ID
URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329465338
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?

2017-09-14 Thread git

rhtyd closed pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py 
assertions are equating srt and?
URL: https://github.com/apache/cloudstack/pull/2261
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10068: Fixing test_iso.py assertions are equating srt and bool instead of the same types (#2261)

2017-09-14 Thread bhaisaab

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new d84585f  CLOUDSTACK-10068: Fixing test_iso.py assertions are equating 
srt and bool instead of the same types (#2261)
d84585f is described below

commit d84585fa6ea23a33392a85b3fa7532308c722d1e
Author: Boris Stoyanov - a.k.a Bobby 
AuthorDate: Thu Sep 14 15:22:09 2017 +0300

CLOUDSTACK-10068: Fixing test_iso.py assertions are equating srt and bool 
instead of the same types (#2261)

It appears that asserts.equal(boolean.True, str.True) which seems to be 
causing the issue. Probably related to some api changes in recent PRs. Will fix 
the equation to str.lower() so it'll pass.

Strangely when running the tests from Pycharm CE they pass, it seems the 
IDE resolves the type issue during comparison. But when running from command 
line it failes...

After fixing this results came back as expected:
---
 test/integration/smoke/test_iso.py | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/integration/smoke/test_iso.py 
b/test/integration/smoke/test_iso.py
index 9bad575..f55f818 100755
--- a/test/integration/smoke/test_iso.py
+++ b/test/integration/smoke/test_iso.py
@@ -320,8 +320,8 @@ class TestISO(cloudstackTestCase):
 "Check display text of updated ISO"
 )
 self.assertEqual(
-iso_response.bootable,
-self.services["bootable"],
+str(iso_response.bootable).lower(),
+str(self.services["bootable"]).lower(),
 "Check if image is bootable of updated ISO"
 )
 
@@ -473,14 +473,14 @@ class TestISO(cloudstackTestCase):
 "Check ISO ID"
 )
 self.assertEqual(
-iso_response.ispublic,
-self.services["ispublic"],
+str(iso_response.ispublic).lower(),
+str(self.services["ispublic"]).lower(),
 "Check ispublic permission of ISO"
 )
 
 self.assertEqual(
-iso_response.isfeatured,
-self.services["isfeatured"],
+str(iso_response.isfeatured).lower(),
+str(self.services["isfeatured"]).lower(),
 "Check isfeatured permission of ISO"
 )
 return

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd commented on issue #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?

2017-09-14 Thread git

rhtyd commented on issue #2261: CLOUDSTACK-10068 - Fixing test_iso.py 
assertions are equating srt and?
URL: https://github.com/apache/cloudstack/pull/2261#issuecomment-329465084
 
 
   @borisstoyanov let's revisit if we've any future issues, merging this now.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM 
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329464938
 
 
   @wido @GabrielBrascher sure, I've already kicked a final test run with 
Trillian and centos6 boxes; I can merge as soon as the results come clean. 
Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM 
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329461735
 
 
   Ok, thanks! I added the label so that it can be merged.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git

wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329461603
 
 
   I find it hard to believe a test failure is related to these changes. It 
doesn't change anything to the default behavior of the Agent. Still, I could be 
wrong.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] larstobi commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system

2017-09-14 Thread git

larstobi commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 
'ro' or 'roo' exists on the system
URL: https://github.com/apache/cloudstack/pull/2252#issuecomment-329455934
 
 
   @GabrielBrascher Check!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git

borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM 
overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329442852
 
 
   How about the load balancer @bwsw ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git

borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM 
overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329442852
 
 
   How about the internal load balancer @bwsw ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] harikrishna-patnala closed pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-14 Thread git

harikrishna-patnala closed pull request #2054: CLOUDSTACK-9886 : After 
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2054 from Accelerite/cs-51009

2017-09-14 Thread harikrishna

This is an automated email from the ASF dual-hosted git repository.

harikrishna pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit b655f9be06cd88383d8b118d818a9a0d113211bf
Merge: c4ca420 e894022
Author: harikrishna-patnala 
AuthorDate: Thu Sep 14 15:48:01 2017 +0530

Merge pull request #2054 from Accelerite/cs-51009

CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to 
connect hosts

 .../schema/src/com/cloud/host/dao/HostDaoImpl.java |   8 +-
 test/integration/component/test_host.py| 205 +
 2 files changed, 212 insertions(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] branch master updated (c4ca420 -> b655f9b)

2017-09-14 Thread harikrishna

This is an automated email from the ASF dual-hosted git repository.

harikrishna pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from c4ca420  CLOUDSTACK-8969: VPN customer gateway can't be registered 
with hostname (#955)
 add e894022  CLOUDSTACK-9886 : After restarting cloudstack-management , It 
takes time to connect hosts
 new b655f9b  Merge pull request #2054 from Accelerite/cs-51009

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../schema/src/com/cloud/host/dao/HostDaoImpl.java |   8 +-
 test/integration/component/test_host.py| 205 +
 2 files changed, 212 insertions(+), 1 deletion(-)
 create mode 100644 test/integration/component/test_host.py

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to 
KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437500
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM 
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437377
 
 
   @blueorangutan test centos7 kvm-centos6
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to 
KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437124
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1082
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-09-14 Thread git

rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests 
and adding them in travis
URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329432167
 
 
   @borisstoyanov okay I've rekicked the failing job, can you compare the test 
time take for each of the jobs and try to consolidate them (rearrange tests) 
such that each job may be completed in less or equal to 50 minutes? Some tests 
that run in 20-25 minutes are prime targets. The first job may be refactored to 
get more tests as well (that run quite quickly?).
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM 
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430475
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to 
KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430510
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git

bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329417873
 
 
   @borisstoyanov 
   
   ```
   sshClient: DEBUG: {Cmd: ssh -i ~/.ssh/id_rsa.cloud 
-ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.3.66 
/usr/local/cloud/systemvm/ssvm-check.sh |grep -e ERROR -e WARNING -e FAIL via 
Host: 10.2.2.67} {returns: [u'WARNING: cannot ping DNS server', u'Tests 
Complete. Look for ERROR or WARNING above.']}
   paramiko.transport: DEBUG: EOF in transport thread
   test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): DEBUG: SSVM script 
output: [u'WARNING: cannot ping DNS server', u'Tests Complete. Look for ERROR 
or WARNING above.']
   test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): CRITICAL: FAILED: 
test_07_reboot_ssvm: ['Traceback (most recent call last):\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n', 
'  File "/marvin/tests/smoke/test_ssvm.py", line 929, in test_07_reboot_ssvm\n  
  self.test_03_ssvm_internals()\n', '  File "/marvin/tests/smoke/test_ssvm.py", 
line 449, in test_03_ssvm_internals\n"Check for warnings in tests"\n', '  
File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n
assertion_func(first, second, msg=msg)\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n
raise self.failureException(msg)\n', 'AssertionError: Check for warnings in 
tests\n']
   ```
   
   In test log before failure. I don't know if it's relevant to the case, 
because If it affected it would affect on VM start, beacause external 
specification doesn't change at all and default value for new parameter is 0, 
so it doesn't affect on actual test results.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM 
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329418016
 
 
   Thanks @rhtyd 
   
   I addressed @GaborApatiNagy his comment, the XML parser now skips the entry 
if the model is null or empty. We got back a invalid XML from libvirt then.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git

bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329417873
 
 
   @borisstoyanov 
   
   ```
   sshClient: DEBUG: {Cmd: ssh -i ~/.ssh/id_rsa.cloud 
-ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.3.66 
/usr/local/cloud/systemvm/ssvm-check.sh |grep -e ERROR -e WARNING -e FAIL via 
Host: 10.2.2.67} {returns: [u'WARNING: cannot ping DNS server', u'Tests 
Complete. Look for ERROR or WARNING above.']}
   paramiko.transport: DEBUG: EOF in transport thread
   test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): DEBUG: SSVM script 
output: [u'WARNING: cannot ping DNS server', u'Tests Complete. Look for ERROR 
or WARNING above.']
   test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): CRITICAL: FAILED: 
test_07_reboot_ssvm: ['Traceback (most recent call last):\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n', 
'  File "/marvin/tests/smoke/test_ssvm.py", line 929, in test_07_reboot_ssvm\n  
  self.test_03_ssvm_internals()\n', '  File "/marvin/tests/smoke/test_ssvm.py", 
line 449, in test_03_ssvm_internals\n"Check for warnings in tests"\n', '  
File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n
assertion_func(first, second, msg=msg)\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n
raise self.failureException(msg)\n', 'AssertionError: Check for warnings in 
tests\n']
   ```
   
   In test log before failure. I don't know if it's relevant to the case, 
because If it affects it should affect on VM start, beacause external 
specification doesn't change at all and default value for new parameter is 0, 
so it doesn't affect on actual test results.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-14 Thread git

wido commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog 
timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138831591
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 ##
 @@ -237,6 +241,23 @@ public boolean parseDomainXML(String domXML) {
 rngDefs.add(def);
 }
 
+NodeList watchDogs = devices.getElementsByTagName("watchdog");
+for (int i = 0; i < watchDogs.getLength(); i++) {
+WatchDogDef def = null;
+Element watchDog = (Element)watchDogs.item(i);
+String action = watchDog.getAttribute("action");
+String model = watchDog.getAttribute("model");
+
+if (Strings.isNullOrEmpty(action)) {
+def = new 
WatchDogDef(WatchDogModel.valueOf(model.toUpperCase()));
+} else {
+def = new 
WatchDogDef(WatchDogAction.valueOf(action.toUpperCase()),
+  
WatchDogModel.valueOf(model.toUpperCase()));
+}
+
+watchDogDefs.add(def);
+}
 
 Review comment:
   I can do a check for that, but it's libvirt which will always return a model 
there. I'll add a if-statement around it, but that shouldn't make a huge 
difference. Thanks for the feedback!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-14 Thread git

wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329413011
 
 
   LGTM based on the code
   
   Interesting idea using 3D-Xpoint SSDs as SWAP :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-09-14 Thread git

borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component 
tests and adding them in travis
URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329412375
 
 
   @rhtyd current travis failure is not related to the changes I've made
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

44 matches

Mail list logo