[GitHub] marcaurele commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

marcaurele commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-364021031
 
 
   @DaanHoogland Can't you try to address the dependencies CVE too in this PR 
by updating them to the fixed ones? Then you'll be able to put flag the build 
as failed if any new CVE happens.
   Just to note that a same build can then start to fail even though it did not 
in the past!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring

[GitBox]

nvazquez commented on a change in pull request #2447: Add retry logic to direct 
download and checksum, also refactoring
URL: https://github.com/apache/cloudstack/pull/2447#discussion_r166802567
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -170,15 +177,45 @@ private String getChecksumCommandFromAlgorithm(String 
algorithm) {
 }
 }
 
+/**
+ * Delete and create download file
+ */
+private void resetDownloadFile() {
+File f = new File(getDownloadedFilePath());
+s_logger.debug("Resetting download file: " + getDownloadedFilePath() + 
", in order to re-download and persist template " + templateId + " on it");
+try {
+if (f.exists()) {
+f.delete();
+}
+f.createNewFile();
+} catch (IOException e) {
+s_logger.error("Error creating file to download on: " + 
getDownloadedFilePath() + " due to: " + e.getMessage());
+throw new CloudRuntimeException("Failed to create download file 
for direct download");
+}
+}
+
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
+int retry = 3;
+boolean valid = false;
 ChecksumValue providedChecksum = new ChecksumValue(checksum);
 String algorithm = providedChecksum.getAlgorithm();
 String checksumCommand = "echo '%s %s' | %s -c --quiet";
 String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+int result;
+while (!valid && retry > 0) {
+s_logger.debug("Performing checksum validation for downloaded 
template " + templateId + ", retries left: " + retry);
+result = Script.runSimpleBashScriptForExitValue(cmd);
 
 Review comment:
   Sure, rebasing 4.11 now that java implementation for checksum is merged


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363951727
 
 
   Trillian test result (tid-2237)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 17277 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2448-t2237-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_migration.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 21 look OK, 46 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.34 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.32 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.35 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.35 | test_iso.py
   test_01_create_iso | `Failure` | 1511.63 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3024.57 | test_iso.py
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 0.94 | test_accounts.py
   test_forceDeleteDomain | `Error` | 0.94 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.16 | 

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363943519
 
 
   Trillian test result (tid-2235)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 17565 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2309-t2235-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_migration.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 21 look OK, 46 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.44 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.42 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.42 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.44 | test_iso.py
   test_01_create_iso | `Failure` | 1514.09 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3029.01 | test_iso.py
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 1.38 | test_accounts.py
   test_forceDeleteDomain | `Error` | 1.37 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.70 | 

[GitHub] khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

[GitBox]

khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy 
support for swift as secondary?
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363918686
 
 
   @rhtyd @DaanHoogland do you have any idea why packaging is not finished yet? 
Is it normal?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fmaximus opened a new pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag

[GitBox]

fmaximus opened a new pull request #2441: CLOUDSTACK-10261: Libvirt metadata: 
only create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag

[GitBox]

DaanHoogland closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: 
only create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
index 385fe79ef2a..90674eb99a8 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
@@ -1543,16 +1543,15 @@ public void addNuageExtension(String macAddress, String 
vrIp) {
 @Override
 public String toString() {
 StringBuilder fsBuilder = new StringBuilder();
+fsBuilder.append("\n");
 for (Map.Entry address : addresses.entrySet()) {
-fsBuilder.append("\n")
-.append("  \n")
-.append("\n");
+fsBuilder.append("  \n");
 }
-return fsBuilder.toString();
+return fsBuilder.append("\n").toString();
 }
 }
 
diff --git 
a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
 
b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
index 006562c213e..b391b94e740 100644
--- 
a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
+++ 
b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
@@ -209,4 +209,21 @@ public void testSCSIDef() {
 assertEquals(str, expected);
 }
 
+public void testMetadataDef() {
+LibvirtVMDef.MetadataDef metadataDef = new LibvirtVMDef.MetadataDef();
+
+
metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac1",
 "ip1");
+
metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac2",
 "ip2");
+
+String xmlDef = metadataDef.toString();
+String expectedXml = "\n" +
+"\n" +
+"  \n" +
+"  \n" +
+"\n" +
+"\n";
+
+assertEquals(xmlDef, expectedXml);
+}
+
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363868696
 
 
   Trillian test result (tid-2236)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2309-t2236-kvm-centos7.zip
   Smoke tests completed. 1 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

DaanHoogland commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363866214
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363866253
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363864291
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1694


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

blueorangutan commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363856187
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

DaanHoogland commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363855922
 
 
   @NuxRo i mean
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be 
designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363852787
 
 
   @DaanHoogland Alas I had to scale back whatever infra I had dedicated for 
ACS building as we focused elsewhere...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

[GitBox]

sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for 
forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166691968
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   You are right, the name of the boolean is a bit misleading. It is in fact a 
VRAddedToNuage check (for example when there was no user data in the network 
and a user wants to add the VR as user data provider). I will change it 
tomorrow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

[GitBox]

DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166688501
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   How about when more then one provider type is used in an install? Can we 
guarantee this call is only called when? either the name 
isUpgradeNetworkOffering is deceiving or the test is incomplete. Is this meant 
to be a 'only if migrating from VR to nuage implementation' check?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363835965
 
 
   Trillian test result (tid-2233)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 17493 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2309-t2233-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_migration.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 22 look OK, 45 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.44 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.44 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.45 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.45 | test_iso.py
   test_01_create_iso | `Failure` | 1514.07 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3029.37 | test_iso.py
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 1.39 | test_accounts.py
   test_forceDeleteDomain | `Error` | 1.42 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.71 | 
test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 5.84 

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package 
script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363834818
 
 
   @rhtyd can you paste the command you ran that produced the screenshot you 
attached?
   If you don't do any _hacking_ around it and just pass the information and 
let the script manages it, you should be getting `-SNAPSHOT` in the final 
package name (without `--use-timestamp`). The sed/remove is to get the real 
version without the snapshot, and it has been there in the script since long 
time ago.
   
   Our custom-versioned POM is `4.12.0.0-co-SNAPSHOT` and with:
   
   Flags | Artifacts
   --- | ---
   `--distribution centos7` | 
`cloudstack-management-4.12.0.0-co.SNAPSHOT.el7.centos.x86_64.rpm`
   `--distribution centos7 --use-timestamp` | 
`cloudstack-management-4.12.0.0-co.1516920012.el7.centos.x86_64.rpm`
   `--distribution centos7 --release 65` | 
`cloudstack-management-4.12.0.0-co.SNAPSHOT65.el7.centos.x86_64.rpm`
   `--distribution centos7 --use-timestamp  --release 67` | 
`cloudstack-management-4.12.0.0-co.151802073867.el7.centos.x86_64.rpm`
   
   @rafaelweingartner completely forgot about Debian packages! ;) I'll look 
into it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

nvazquez commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be 
designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363823385
 
 
   Just pushed force to re kick start Jenkins, sure I'll package after it 
finishes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363818026
 
 
   Trillian test result (tid-2232)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 17201 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2444-t2232-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_migration.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 22 look OK, 45 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.34 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.32 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.33 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.33 | test_iso.py
   test_01_create_iso | `Failure` | 1511.54 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3024.31 | test_iso.py
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 0.94 | test_accounts.py
   test_forceDeleteDomain | `Error` | 0.98 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.18 | 
test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 5.22 | 

[GitHub] sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

[GitBox]

sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for 
forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166640325
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   @DaanHoogland if the old offering had a VR and the new has one as well; in 
that case the broadcast uri does not need to be updated because the VR ip does 
not change. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

[GitBox]

sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for 
forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166640325
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   @DaanHoogland if the old offering had a VR and the new has, in that case the 
broadcast uri does not need to be updated because the VR ip does not change. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

[GitBox]

DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166639544
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   @sgoeminn how about this question?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be 
designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-363783638
 
 
   Once all the errors are fixed, can we ask the blue orangutan to package it 
so I can test?
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363758343
 
 
   Yes, I think we should not remove anything from the version as declared in 
the pom.xml file, i.e. keep the -SNAPSHOT don't sed/remove it @khos2ow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363757488
 
 
   @rhtyd I believe it should be consistent across different OSs. This looks 
like a "bug". @khos2ow can you take a look into this issue that was reported?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

nvazquez opened a new pull request #2448: CLOUDSTACK-10274: L2 network refused 
to be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448
 
 
   JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10274
   
   Issue reported by @NuxRo while trying to add an L2 network on a VXLAN 
physical network:
   
   
   2018-02-06 11:20:27,748 DEBUG [c.c.n.NetworkServiceImpl] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Found physical 
network id=201 based on requested tags mellanoxvxlan
   2018-02-06 11:20:27,749 DEBUG [c.c.n.NetworkServiceImpl] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Found physical 
network id=201 based on requested tags mellanoxvxlan
   2018-02-06 11:20:27,766 DEBUG [c.c.n.g.BigSwitchBcfGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design this network, the physical isolation type is not BCF_SEGMENT
   2018-02-06 11:20:27,766 DEBUG [o.a.c.n.c.m.ContrailGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design this network
   2018-02-06 11:20:27,767 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design this network
   2018-02-06 11:20:27,767 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design this network
   2018-02-06 11:20:27,767 DEBUG [c.c.n.g.OvsGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design this network
   2018-02-06 11:20:27,769 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) SSP not 
configured to be active
   2018-02-06 11:20:27,769 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design this network
   2018-02-06 11:20:27,769 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Refusing to 
design network using network offering 19 on physical network 201
   2018-02-06 11:20:27,770 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Releasing lock 
for Acct[6af2875b-04fc-11e8-923e-002590474525-admin]
   2018-02-06 11:20:27,789 DEBUG [c.c.u.d.T.Transaction] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) Rolling back the 
transaction: Time = 38 Name =  qtp788117692-390; called by 
-TransactionLegacy.rollback:889-TransactionLegacy.removeUpTo:832-TransactionLegacy.close:656-Transaction.execute:43-Transaction.execute:47-NetworkOrchestrator.createGuestNetwork:2315-NetworkServiceImpl$4.doInTransaction:1383-NetworkServiceImpl$4.doInTransaction:1331-Transaction.execute:40-NetworkServiceImpl.commitNetwork:1331-NetworkServiceImpl.createGuestNetwork:1294-NativeMethodAccessorImpl.invoke0:-2
   2018-02-06 11:20:27,798 ERROR [c.c.a.ApiServer] 
(qtp788117692-390:ctx-f1a980be ctx-61be30e8) (logid:0ca0c866) unhandled 
exception executing api command: [Ljava.lang.String;@43b9df02
   com.cloud.utils.exception.CloudRuntimeException: Unable to convert network 
offering with specified id to network profile
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.setupNetwork(NetworkOrchestrator.java:726)
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$10.doInTransaction(NetworkOrchestrator.java:2364)
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$10.doInTransaction(NetworkOrchestrator.java:2315)
   at 
com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:50)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:40)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:47)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

DaanHoogland commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-363748947
 
 
   yes, they are ignorable, just a help but afcourse we can set them to block 
the build. You don't want to do that in the present state though


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for 
owasp dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-363748671
 
 
   because it might start breaking our builds and then we will have to fix it?
   I wonder if this report will be something like the Coverity report that we 
had or even the sonar report that we had (do we still have them?) that people 
just ignore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for 
owasp dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-363748671
 
 
   because it might start breaking our builds and then we will have to fix it?
   I wonder if this report generate will not be something like the Coverity 
report that we had or even the sonar report that we had (do we still have 
them?) that people just ignore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363748414
 
 
   I am neutral on this as i don't oversee the consequences, i think


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

DaanHoogland commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-363747676
 
 
   @rafaelweingartner i don't want to think about that yet.. :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363743242
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

borisstoyanov commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363743127
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363741773
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1693


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

blueorangutan commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363735572
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents

[GitBox]

borisstoyanov commented on issue #2309: CLOUDSTACK-10132: Multiple Management 
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#issuecomment-363735353
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363731713
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363731571
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363730197
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1692


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363720883
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363723194
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363723070
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1691


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363723135
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363723070
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1691


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363720848
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363720883
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363720848
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719741
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719714
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719741
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719038
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719126
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363715523
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719714
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363715437
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719126
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name 
to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363719038
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363718527
 
 
   @DaanHoogland @khos2ow in the built packages ^^, it removes the `-SNAPSHOT` 
from rpm package names only but not in the Debian package names. I think we 
should keep whatever is in the pom.xml's version, but if that's what needed I 
would not block the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

rafaelweingartner commented on issue #2446: CLOUDSTACK-10271 maven plugin for 
owasp dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-363717280
 
 
   Is there a property to fail the build in case we find a vulnerable component?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363715523
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

[GitBox]

borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role 
set name to null
URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363715437
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland closed pull request #2405: CLOUDSTACK-10146 checksum in java instead of script

[GitBox]

DaanHoogland closed pull request #2405: CLOUDSTACK-10146 checksum in java 
instead of script
URL: https://github.com/apache/cloudstack/pull/2405
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java 
b/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
index 3b6bc9a6dd3..e120d847b17 100644
--- 
a/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
+++ 
b/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
@@ -20,10 +20,13 @@
 
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.script.Script;
-import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.cloudstack.utils.security.DigestHelper;
 import org.apache.commons.lang.StringUtils;
 
 import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.security.NoSuchAlgorithmException;
 import java.util.UUID;
 
 public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
@@ -149,36 +152,16 @@ public DirectTemplateInformation getTemplateInformation() 
{
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath,e);
+} catch (NoSuchAlgorithmException e) {
+throw new CloudRuntimeException("Unknown checksum algorithm: " 
+ checksum, e);
+}
 }
 return true;
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: CLOUDSTACK-10146 checksum in java instead of script (#2405)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 123c20d  CLOUDSTACK-10146 checksum in java instead of script (#2405)
123c20d is described below

commit 123c20dc57d809f89bc1b012303e71b6892c8729
Author: dahn 
AuthorDate: Wed Feb 7 10:48:51 2018 +0100

CLOUDSTACK-10146 checksum in java instead of script (#2405)

* CLOUDSTACK-10146 checksum in java instead of script

* root cause passing
---
 .../download/DirectTemplateDownloaderImpl.java | 39 ++
 1 file changed, 11 insertions(+), 28 deletions(-)

diff --git 
a/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java 
b/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
index 3b6bc9a..e120d84 100644
--- 
a/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
+++ 
b/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
@@ -20,10 +20,13 @@ package com.cloud.agent.direct.download;
 
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.script.Script;
-import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.cloudstack.utils.security.DigestHelper;
 import org.apache.commons.lang.StringUtils;
 
 import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.security.NoSuchAlgorithmException;
 import java.util.UUID;
 
 public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
@@ -149,36 +152,16 @@ public abstract class DirectTemplateDownloaderImpl 
implements DirectTemplateDown
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath,e);
+} catch (NoSuchAlgorithmException e) {
+throw new CloudRuntimeException("Unknown checksum algorithm: " 
+ checksum, e);
+}
 }
 return true;
 }

-- 
To stop receiving notification emails like this one, please contact
d...@apache.org.

[GitHub] DaanHoogland commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

DaanHoogland commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-363711508
 
 
   @bvbharatk care to review this?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363706745
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1690


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

DaanHoogland commented on a change in pull request #2446: CLOUDSTACK-10271 
maven plugin for owasp dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#discussion_r166556982
 
 

 ##
 File path: pom.xml
 ##
 @@ -569,6 +569,22 @@
   
 install
 
+  
+org.owasp
+dependency-check-maven
+3.1.1
 
 Review comment:
   of course, good point


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363699511
 
 
   @DaanHoogland see comments above on why I initially was -1 on it.
   
   Will investigate bo failure separately, but found this from last run. Built 
packages look good: (the identifer shapeblue is the jenkins build id)
   ![screenshot from 2018-02-07 
09-51-25](https://user-images.githubusercontent.com/95203/35906926-9612bc68-0bec-11e8-9db8-f020db05af54.png)
   
   Minor issue - the built packages seem to be removing -SNAPSHOT. I'll kick 
the packaging jobs manually.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363699511
 
 
   @DaanHoogland see comments above on why I initially was -1 on it.
   
   Will investigate bo failure separately, but found this from last run. LGTM 
based on the built packages: (the identifer shapeblue is the jenkins build 
id)
   ![screenshot from 2018-02-07 
09-51-25](https://user-images.githubusercontent.com/95203/35906926-9612bc68-0bec-11e8-9db8-f020db05af54.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363699511
 
 
   @DaanHoogland see comments above on why I initially was -1 on it.
   
   Will investigate bo failure separately, but found this from last run. LGTM 
based on the built packages:
   ![screenshot from 2018-02-07 
09-51-25](https://user-images.githubusercontent.com/95203/35906926-9612bc68-0bec-11e8-9db8-f020db05af54.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services