[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management

[GitBox]

mike-tutkowski commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-386774645
 
 
   Yes, @rhtyd, you are correct that this PR is a good candidate for 4.11.1. I 
can create a PR to back port it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386761041
 
 
   Trillian test result (tid-2610)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 9396 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2626-t2610-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_migration.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 30 look OK, 37 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_list_vms_metrics | `Error` | 4.40 | test_metrics_api.py
   ContextSuite context=TestAddVmToSubDomain>:teardown | `Error` | 9.42 | 
test_accounts.py
   test_forceDeleteDomain | `Failure` | 287.74 | test_accounts.py
   test_move_user_to_different_domain | `Error` | 43.73 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 40.68 | test_accounts.py
   ContextSuite context=TestUserAPIKeys>:teardown | `Error` | 56.12 | 
test_accounts.py
   test_ApiListDomain | `Error` | 55.37 | test_accounts.py
   test_01_native_to_native_network_migration | `Error` | 6.17 | 
test_migration.py
   test_02_native_to_native_vpc_migration | `Error` | 2.90 | test_migration.py
   test_network_acl | `Error` | 1.15 | test_network_acl.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_deploy_vm_from_iso | `Error` | 10.09 | test_deploy_vm_iso.py
   test_delete_account | `Error` | 5.11 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 8.51 | test_network.py
   test_deploy_vm_l2network | `Error` | 6.42 | test_network.py
   test_l2network_restart | `Error` | 9.94 | test_network.py
   ContextSuite context=TestL2Networks>:teardown | `Error` | 11.04 | 
test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 16.18 | 
test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 17.76 | test_network.py
   test_reboot_router | `Error` | 4.05 | test_network.py
   test_releaseIP | `Error` | 4.05 | test_network.py
   ContextSuite context=TestRouterRules>:setup | 

[GitHub] blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386727428
 
 
   Trillian test result (tid-2609)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 8855 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2626-t2609-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_migration.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 30 look OK, 37 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_list_vms_metrics | `Error` | 3.35 | test_metrics_api.py
   ContextSuite context=TestAddVmToSubDomain>:teardown | `Error` | 22.73 | 
test_accounts.py
   test_forceDeleteDomain | `Failure` | 251.94 | test_accounts.py
   test_move_user_to_different_domain | `Error` | 39.61 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 38.76 | test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:teardown | `Error` | 55.40 | 
test_accounts.py
   ContextSuite context=TestUserAPIKeys>:teardown | `Error` | 58.38 | 
test_accounts.py
   test_ApiListDomain | `Error` | 54.37 | test_accounts.py
   test_01_native_to_native_network_migration | `Error` | 7.18 | 
test_migration.py
   test_02_native_to_native_vpc_migration | `Error` | 2.88 | test_migration.py
   test_network_acl | `Error` | 1.17 | test_network_acl.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_deploy_vm_from_iso | `Error` | 11.15 | test_deploy_vm_iso.py
   test_delete_account | `Error` | 4.06 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 5.46 | test_network.py
   test_deploy_vm_l2network | `Error` | 5.41 | test_network.py
   test_l2network_restart | `Error` | 7.91 | test_network.py
   ContextSuite context=TestL2Networks>:teardown | `Error` | 9.01 | 
test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 15.12 | 
test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 16.71 | 

[GitHub] blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386727741
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

rhtyd commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM 
host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386727555
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2607: Allow changing disk offering of VMs' root volume during volume migration

[GitBox]

blueorangutan commented on issue #2607: Allow changing disk offering of VMs' 
root volume during volume migration
URL: https://github.com/apache/cloudstack/pull/2607#issuecomment-386727032
 
 
   Trillian test result (tid-2588)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 107697 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2607-t2588-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 60 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 128.31 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_secured_vm_migration | `Error` | 38.50 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 38.48 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 38.47 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 38.48 | 
test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 137.66 | test_volumes.py
   test_11_migrate_volume_and_change_offering | `Error` | 130.24 | 
test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 270.97 | 
test_vpc_redundant.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 164.53 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 171.57 | test_vpc_vpn.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.31 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386721530
 
 
   Trillian test result (tid-2608)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28364 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2508-t2608-vmware-65.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 251.08 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow opened a new pull request #2627: Catch error in packagin script and fail the build

[GitBox]

khos2ow opened a new pull request #2627: Catch error in packagin script and 
fail the build
URL: https://github.com/apache/cloudstack/pull/2627
 
 
   This is to fix the regression added in 1708838518
   
   ## Description
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386690809
 
 
   Trillian test result (tid-2605)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22750 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2615-t2605-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 144.29 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 166.57 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2613: Cleanup POMs

[GitBox]

khos2ow commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386690495
 
 
   This PR should be good now. Call for reviewing: @rhtyd @rafaelweingartner 
@marcaurele @DaanHoogland @GabrielBrascher @wido @borisroman @swill 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2613: Cleanup POMs

[GitBox]

khos2ow commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386684256
 
 
   @DaanHoogland it's still failing. Are you running customized command for 
building deb packages? I cannot reproduce this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386674430
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

rhtyd commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM 
host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386674298
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-386673916
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2012


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

blueorangutan commented on issue #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-38801
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

rhtyd commented on issue #2626: bionic: allow Ubuntu 18.04 to be added as KVM 
host
URL: https://github.com/apache/cloudstack/pull/2626#issuecomment-38528
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2626: bionic: allow Ubuntu 18.04 to be added as KVM host

[GitBox]

rhtyd opened a new pull request #2626: bionic: allow Ubuntu 18.04 to be added 
as KVM host
URL: https://github.com/apache/cloudstack/pull/2626
 
 
   This adds and allows Ubuntu 18.04 to be used as KVM host. In addition,
   on the UI when hypervisor version key is missing, this adds and display
   the host os and version detail which is useful to show the KVM host
   os and version.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

DaanHoogland commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186144706
 
 

 ##
 File path: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -2868,6 +2849,89 @@ public boolean restartNetwork(final Long networkId, 
final Account callerAccount,
 }
 }
 
+@Override
+public void destroyExpendableRouters(final List 
routers, final ReservationContext context) throws ResourceUnavailableException {
+final List remainingRouters = new ArrayList<>();
+for (final VirtualRouter router : routers) {
+if (router.getState() == VirtualMachine.State.Stopped ||
+router.getState() == VirtualMachine.State.Error ||
+router.getState() == VirtualMachine.State.Shutdowned ||
+router.getState() == VirtualMachine.State.Unknown) {
+s_logger.debug("Destroying old router " + router);
+_routerService.destroyRouter(router.getId(), 
context.getAccount(), context.getCaller().getId());
+} else {
+remainingRouters.add(router);
+}
+}
+
+if (remainingRouters.size() < 2) {
+return;
+}
+
+VirtualRouter backupRouter = null;
+for (final VirtualRouter router : remainingRouters) {
+if (router.getRedundantState() == 
VirtualRouter.RedundantState.BACKUP) {
+backupRouter = router;
+}
+}
+if (backupRouter == null) {
+backupRouter = routers.get(routers.size() - 1);
+}
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), 
context.getAccount(), context.getCaller().getId());
 
 Review comment:
   got it @rhtyd. I still dread this public method being called from places 
that do not intent what it was programmed to do. As in this method a backup 
router will be destroyed no matter what. How about adding some javadoc:
   ```
   /**
 * This method will first destroy and router in state Stopped, Error, 
Shutdowned or Unknown
 * After that it will destroy any backup router or, if it can find non the 
last router in the list
 */
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

DaanHoogland commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186144706
 
 

 ##
 File path: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -2868,6 +2849,89 @@ public boolean restartNetwork(final Long networkId, 
final Account callerAccount,
 }
 }
 
+@Override
+public void destroyExpendableRouters(final List 
routers, final ReservationContext context) throws ResourceUnavailableException {
+final List remainingRouters = new ArrayList<>();
+for (final VirtualRouter router : routers) {
+if (router.getState() == VirtualMachine.State.Stopped ||
+router.getState() == VirtualMachine.State.Error ||
+router.getState() == VirtualMachine.State.Shutdowned ||
+router.getState() == VirtualMachine.State.Unknown) {
+s_logger.debug("Destroying old router " + router);
+_routerService.destroyRouter(router.getId(), 
context.getAccount(), context.getCaller().getId());
+} else {
+remainingRouters.add(router);
+}
+}
+
+if (remainingRouters.size() < 2) {
+return;
+}
+
+VirtualRouter backupRouter = null;
+for (final VirtualRouter router : remainingRouters) {
+if (router.getRedundantState() == 
VirtualRouter.RedundantState.BACKUP) {
+backupRouter = router;
+}
+}
+if (backupRouter == null) {
+backupRouter = routers.get(routers.size() - 1);
+}
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), 
context.getAccount(), context.getCaller().getId());
 
 Review comment:
   got it @rhtyd. I still dread this public method being called from places 
that do not intent what it was programmed to do. As in this method a backup 
router will be destroyed no matter what. How about adding some javadoc:
   ```
   /**
 * This method will first destroy and router in state Stopped, Error, 
Shutdowned or Unknown
 * Afterthat it will destroy any backup router or, if it can find non the 
last router in the list
 */
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

DaanHoogland commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186144706
 
 

 ##
 File path: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -2868,6 +2849,89 @@ public boolean restartNetwork(final Long networkId, 
final Account callerAccount,
 }
 }
 
+@Override
+public void destroyExpendableRouters(final List 
routers, final ReservationContext context) throws ResourceUnavailableException {
+final List remainingRouters = new ArrayList<>();
+for (final VirtualRouter router : routers) {
+if (router.getState() == VirtualMachine.State.Stopped ||
+router.getState() == VirtualMachine.State.Error ||
+router.getState() == VirtualMachine.State.Shutdowned ||
+router.getState() == VirtualMachine.State.Unknown) {
+s_logger.debug("Destroying old router " + router);
+_routerService.destroyRouter(router.getId(), 
context.getAccount(), context.getCaller().getId());
+} else {
+remainingRouters.add(router);
+}
+}
+
+if (remainingRouters.size() < 2) {
+return;
+}
+
+VirtualRouter backupRouter = null;
+for (final VirtualRouter router : remainingRouters) {
+if (router.getRedundantState() == 
VirtualRouter.RedundantState.BACKUP) {
+backupRouter = router;
+}
+}
+if (backupRouter == null) {
+backupRouter = routers.get(routers.size() - 1);
+}
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), 
context.getAccount(), context.getCaller().getId());
 
 Review comment:
   got it @rhtyd. I still dread this public method being called from places 
that do not intent what it was programmed to do. As in this method a backup 
router will be destroyed no matter what. How about adding some javadoc:
   /**
 * This method will first destroy and router in state Stopped, Error, 
Shutdowned or Unknown
 * Afterthat it will destroy any backup router or, if it can find non the 
last router in the list
 */


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nathanejohnson commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

[GitBox]

nathanejohnson commented on issue #2611: Ceph RBD primary storage fails 
connection and renders node unusable
URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-386649977
 
 
   @giorgiomassar8 here are the logs from when the rbd pool was configured on 
our host:
   
   2018-05-02 12:07:01,225 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-3:null) (logid:328be924) Request:Seq 
1-8891231564336201737:  { Cmd , MgmtId: 14038005752684, via: 1, Ver: v1, Flags: 
100011, 
[{"com.cloud.agent.api.CreateStoragePoolCommand":{"_createDatastore":false,"add":true,"pool":{"id":3,"uuid":"e485c675-896a-303e-be82-c42357c6b4c1","host":"192.168.100.100","path":"acs411testing","userInfo":"acs411testing:supersecretkeygoeshere==","port":6789,"type":"RBD"},"localPath":"/mnt//dcf0b890-984a-3c12-9190-050f3294a590","wait":0}}]
 }
   2018-05-02 12:07:01,225 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-3:null) (logid:328be924) Processing command: 
com.cloud.agent.api.CreateStoragePoolCommand
   2018-05-02 12:07:01,225 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-3:null) (logid:328be924) Seq 1-8891231564336201737:  { 
Ans: , MgmtId: 14038005752684, via: 1, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.Answer":{"result":true,"details":"success","wait":0}}] }
   2018-05-02 12:07:01,313 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-5:null) (logid:328be924) Request:Seq 
1-8891231564336201738:  { Cmd , MgmtId: 14038005752684, via: 1, Ver: v1, Flags: 
100011, 
[{"com.cloud.agent.api.ModifyStoragePoolCommand":{"add":true,"pool":{"id":3,"uuid":"e485c675-896a-303e-be82-c42357c6b4c1","host":"192.168.100.100","path":"acs411testing","userInfo":"acs411testing:supersecretkeygoeshere==","port":6789,"type":"RBD"},"localPath":"/mnt//dcf0b890-984a-3c12-9190-050f3294a590","wait":0}}]
 }
   2018-05-02 12:07:01,313 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-5:null) (logid:328be924) Processing command: 
com.cloud.agent.api.ModifyStoragePoolCommand
   2018-05-02 12:07:01,313 INFO  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Attempting to create storage 
pool e485c675-896a-303e-be82-c42357c6b4c1 (RBD) in libvirt
   2018-05-02 12:07:01,313 DEBUG [kvm.resource.LibvirtConnection] 
(agentRequest-Handler-5:null) (logid:328be924) Looking for libvirtd connection 
at: qemu:///system
   2018-05-02 12:07:01,319 WARN  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Storage pool 
e485c675-896a-303e-be82-c42357c6b4c1 was not found running in libvirt. Need to 
create it.
   2018-05-02 12:07:01,319 INFO  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Didn't find an existing storage 
pool e485c675-896a-303e-be82-c42357c6b4c1 by UUID, checking for pools with 
duplicate paths
   2018-05-02 12:07:01,319 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Checking path of existing pool 
d358f5c2-f5fd-43a8-844e-cf01183de220 against pool we want to create
   2018-05-02 12:07:01,322 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Attempting to create storage 
pool e485c675-896a-303e-be82-c42357c6b4c1
   2018-05-02 12:07:01,323 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) 
   e485c675-896a-303e-be82-c42357c6b4c1
   
   acs411testing@192.168.100.100:6789/acs411testing
   
   
   
   2018-05-02 12:07:01,388 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) 
   e485c675-896a-303e-be82-c42357c6b4c1
   e485c675-896a-303e-be82-c42357c6b4c1
   
   
   acs411testing
   
   
   
   
   
   
   2018-05-02 12:07:01,434 INFO  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Trying to fetch storage pool 
e485c675-896a-303e-be82-c42357c6b4c1 from libvirt
   2018-05-02 12:07:01,434 DEBUG [kvm.resource.LibvirtConnection] 
(agentRequest-Handler-5:null) (logid:328be924) Looking for libvirtd connection 
at: qemu:///system
   2018-05-02 12:07:01,439 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-5:null) (logid:328be924) Succesfully refreshed pool 
e485c675-896a-303e-be82-c42357c6b4c1 Capacity: 11413921890304 Used: 0 
Available: 10496547282944
   
   
   do you see the key go across before it attempts to create the libvirt 
storage pool?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386648466
 
 
   Trillian test result (tid-2597)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 25980 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2621-t2597-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 162.63 | 
test_internal_lb.py
   test_01_secured_vm_migration | `Error` | 0.23 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 1.31 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.16 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.14 | 
test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 5.37 | test_vm_life_cycle.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 210.55 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 145.02 | test_vpc_vpn.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.12 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 29.02 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2613: Cleanup POMs

[GitBox]

blueorangutan commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386647017
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2011


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2613: Cleanup POMs

[GitBox]

blueorangutan commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386639485
 
 
   @khos2ow a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2613: Cleanup POMs

[GitBox]

khos2ow commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386639382
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] izenk opened a new issue #2625: Could not connect to SMTP host

[GitBox]

izenk opened a new issue #2625: Could not connect to SMTP host
URL: https://github.com/apache/cloudstack/issues/2625
 
 
   
   
    ISSUE TYPE

   **Other**
   
   
    COMPONENT NAME
   
   **Management Node**
   
    CLOUDSTACK VERSION
   
   **4.11.0**
   
    CONFIGURATION
   
   * **Advanced Networking**
   * **KVM**
   
    OS / ENVIRONMENT
   
   **CentOS Linux release 7.4.1708**
   
    Summary
   Goal: integrate CloudStack with external SMTP relay.
   SMTP relay is Office365 relay from Office365 subscription.
   Parameters to connect: smtp.office365.com:587
   
   In general there are two cases for secure connection:
   * SSL (First SSL handshake, then SMTP HELO)
   * TLS (First SMTP HELO, then STARTLS)
   
   CS does not allow to specify method to use and by default use SSL, what 
leads to errors:
   ~~~
   2018-04-25 13:32:59,733 ERROR [c.c.a.AlertManagerImpl] 
(Email-Alerts-Sender-1:null) (logid:)  Failed to send email alert javax.mail.Mes
   sagingException: Could not connect to SMTP host: smtp.office365.com, port: 
587;
 nested exception is:
   javax.net.ssl.SSLException: Unrecognized SSL message, plaintext 
connection?
   ~~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] izenk opened a new issue #2624: Unknown parameters : projectid

[GitBox]

izenk opened a new issue #2624: Unknown parameters : projectid
URL: https://github.com/apache/cloudstack/issues/2624
 
 
   
   
    ISSUE TYPE

   **Other**
   
   
    COMPONENT NAME
   
   **Management Node**
   
    CLOUDSTACK VERSION
   
   **4.11.0**
   
    CONFIGURATION
   
   * **Advanced Networking**
   * **KVM**
   
    OS / ENVIRONMENT
   
   **CentOS Linux release 7.4.1708**
   
    SUMMARY
   
   During different UI operations (VPC creation, VM management, Forwarding 
Rules managements and etc.) I can see such WARNINGS:
   ~~~
   2018-05-04 16:45:33,690 WARN  [c.c.a.d.ParamGenericValidationWorker] 
(qtp788117692-323:ctx-9c5a250d ctx-83e49862) (logid:87d0fc5a) Received unknown 
parameters for command listNics. Unknown parameters : projectid
   2018-05-04 16:45:35,497 WARN  [c.c.a.d.ParamGenericValidationWorker] 
(qtp788117692-13:ctx-a6e4db2e ctx-06296171) (logid:7cb8a0e1) Received unknown 
parameters for command createPortForwardingRule. Unknown parameters : projectid
   ~~~
    STEPS TO REPRODUCE
   
   
   I don't now if such messages mean that something will go wrong. But as I 
understand if you create some entity under project, cs should link somehow this 
entity to the project


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] AlexanderStock commented on issue #2604: No volume name and virtualmachine ID in volume usagerecord

[GitBox]

AlexanderStock commented on issue #2604: No volume name and virtualmachine ID 
in volume usagerecord
URL: https://github.com/apache/cloudstack/issues/2604#issuecomment-386630113
 
 
   Hi,
   
   it was not working in previous versions.
   I checked the cloud_usage.usage_event table and found the column 
"resource_name" which would be sufficient for the volume name problem.
   Regarding the missing vm id: Maybe two additional event types like 
"VOLUME.ATTACH" and "VOLUME.DETACH" plus a new column in the usage_event table, 
maybe called "parentid", could solve the problem.
   This is just a rough guess. Maybe there is a more efficient way to do this.
   
   BR
   Alexander


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r186106111
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -64,10 +71,17 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
- xen-domU|xen-hvm)
+ xen-pv)
   cat /proc/cmdline > $CMDLINE
   sed -i "s/%/ /g" $CMDLINE
   ;;
+ xen-hvm)
+  if [ ! -f /usr/sbin/xenstore-read ]; then
+log_it "ERROR: xentools not installed, cannot found xenstore-read" 
&& exit 5
+  fi
+  /usr/sbin/xenstore-read vm-data/cloudstack/init > 
/var/cache/cloud/cmdline
 
 Review comment:
   Thanks @rhtyd for the update, that's exactly how I have been testing, I'm 
gonna double check on my side once again, but if you've done the testing and 
validated the changes are good that's really good news.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] giorgiomassar8 commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

[GitBox]

giorgiomassar8 commented on issue #2611: Ceph RBD primary storage fails 
connection and renders node unusable
URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-386623607
 
 
   @nathanejohnson nope I don't see qcow2/raw mismatch errors here, I do 
believe the issue is related to the fact that for some reasons, no 
authentication information is put in the pool's XML sent to libvirt.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386622701
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2010


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2613: Cleanup POMs

[GitBox]

khos2ow commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386618114
 
 
   Thanks @DaanHoogland, it is fixed already, I haven't pushed yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2613: Cleanup POMs

[GitBox]

DaanHoogland commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-386616458
 
 
   debian failed @khos2ow . not sure if it is helpful but here is the last few 
log lines of the job:
   ```
   + cat /jenkins/workspace/acs-pr-deb-pkg-builder/debian/changelog
   + mv /jenkins/workspace/acs-pr-deb-pkg-builder/newchangelog 
/jenkins/workspace/acs-pr-deb-pkg-builder/debian/changelog
   + cd /jenkins/workspace/acs-pr-deb-pkg-builder
   + dpkg-buildpackage -uc -us -b
   dpkg-buildpackage: warning: debian/changelog(l1): badly formatted 
heading line
   LINE: cloudstack () unstable; urgency=low
   dpkg-buildpackage: warning: debian/changelog(l2): found blank line where 
expected first heading
   dpkg-buildpackage: warning: debian/changelog(l3): found change data 
where expected first heading
   LINE:   * Update the version to 
   Can't call method "as_string" on an undefined value at 
/usr/share/perl5/Dpkg/Changelog.pm line 249.
   Build step 'Execute shell' marked build as failure
   Stopping all containers
   Finished: FAILURE
   ```
   not sure if it should matter either ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX".

[GitBox]

DaanHoogland commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX" 
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-386613917
 
 
   these test resulta are dissappointing so i did a recursive case insensitive 
search of the changed method names:
   for i in 
getOfferHa,isOfferHa,GetLimitCpuUse,isLimitCpuUse,getVolatileVm,isVolatileVm,getForVirtualNetwork,isForVirtualNetwork,getIsSourceNat,isSourceNat,getIsStaticNat,isStaticNat,getRestartRequired,isRestartRequired,getSpecifyIpRanges,isSpecifyIpRanges,getDisplayVm,isDisplayVm,getDisplayVpc,isDisplayVpc,getLocalStorageActive,isLocalStorageActive,getHasEnoughCapacity,hasEnoughCapacity,getSuitableForMigration,isSuitableForMigration,getDefaultUse,isDefaultUse,getForDisplay,isForDisplay,getDestroyed,isDestroyed,getListAll,isListAll,getSparseVolumes,isSparseVolumes,getPasswordEnabled,isPasswordEnabled,getRequiresHVM,isRequiresHVM,getIsPublic,isPublic,getFeatured,isFeatured,getIsExtractable,isExtractable,getBootable,isBootable,getSshKeyEnabled,isSshKeyEnabled
   do
 grep -ir $i *
   done
   ```
   baloujak:pr2600-t2589-kvm-centos7 dahn$ for i in 
getOfferHa,isOfferHa,GetLimitCpuUse,isLimitCpuUse,getVolatileVm,isVolatileVm,getForVirtualNetwork,isForVirtualNetwork,getIsSourceNat,isSourceNat,getIsStaticNat,isStaticNat,getRestartRequired,isRestartRequired,getSpecifyIpRanges,isSpecifyIpRanges,getDisplayVm,isDisplayVm,getDisplayVpc,isDisplayVpc,getLocalStorageActive,isLocalStorageActive,getHasEnoughCapacity,hasEnoughCapacity,getSuitableForMigration,isSuitableForMigration,getDefaultUse,isDefaultUse,getForDisplay,isForDisplay,getDestroyed,isDestroyed,getListAll,isListAll,getSparseVolumes,isSparseVolumes,getPasswordEnabled,isPasswordEnabled,getRequiresHVM,isRequiresHVM,getIsPublic,isPublic,getFeatured,isFeatured,getIsExtractable,isExtractable,getBootable,isBootable,getSshKeyEnabled,isSshKeyEnabled
   > do
   >   grep -ir $i *
   > done
   baloujak:pr2600-t2589-kvm-centos7 dahn$
   ```
   
   no results are good results. I think we can go agead with this @rhtyd 
@rafaelweingartner ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386613636
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2621: Backports for 4.11 branch

[GitBox]

rhtyd commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386613420
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2621: Backports for 4.11 branch

[GitBox]

rafaelweingartner commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386608722
 
 
   @rhtyd Travis was not passing because of some problems that were created 
after the `cherry-pick`. I have fixed them, and now everything seems to be fine.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

[GitBox]

DaanHoogland commented on issue #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-386605808
 
 
   @rhtyd thanks. I still want comments from @jayapalu and @fmaximus and maybe 
@kiwiflyer 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

[GitBox]

GabrielBrascher commented on issue #2611: Ceph RBD primary storage fails 
connection and renders node unusable
URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-386602249
 
 
   I will see if I can deploy a test environment to reproduce this issue 
meanwhile.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

DaanHoogland commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386602102
 
 
   code looks good so far (just in case I don't pass by anymore) I like the 
checkbox option to prevent the selection of unsupported services. Better would 
be if unsupported services wouldn't be visible but as long as it is only one 
there is no difference.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2615: config-drive: support user data on L2 networks

[GitBox]

rhtyd commented on a change in pull request #2615: config-drive: support user 
data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#discussion_r186073639
 
 

 ##
 File path: ui/scripts/configuration.js
 ##
 @@ -2415,7 +2415,7 @@
 $supportedServices.css('display', 
'inline-block');
 } else if ($guestTypeField.val() == 
'L2') {
 $useVpc.hide();
-$supportedServices.hide();
+$supportedServices.css('display', 
'inline-block');
 
 Review comment:
   Cool, Monday is fine too. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2615: config-drive: support user data on L2 networks

[GitBox]

nvazquez commented on a change in pull request #2615: config-drive: support 
user data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#discussion_r186072756
 
 

 ##
 File path: ui/scripts/configuration.js
 ##
 @@ -2415,7 +2415,7 @@
 $supportedServices.css('display', 
'inline-block');
 } else if ($guestTypeField.val() == 
'L2') {
 $useVpc.hide();
-$supportedServices.hide();
+$supportedServices.css('display', 
'inline-block');
 
 Review comment:
   Sure, I can pick it up during the weekend


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2615: config-drive: support user data on L2 networks

[GitBox]

rhtyd commented on a change in pull request #2615: config-drive: support user 
data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#discussion_r186068756
 
 

 ##
 File path: ui/scripts/configuration.js
 ##
 @@ -2415,7 +2415,7 @@
 $supportedServices.css('display', 
'inline-block');
 } else if ($guestTypeField.val() == 
'L2') {
 $useVpc.hide();
-$supportedServices.hide();
+$supportedServices.css('display', 
'inline-block');
 
 Review comment:
   Good idea, perhaps you or Ernie can improve the UI changes. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2615: config-drive: support user data on L2 networks

[GitBox]

nvazquez commented on a change in pull request #2615: config-drive: support 
user data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#discussion_r186066103
 
 

 ##
 File path: ui/scripts/configuration.js
 ##
 @@ -2415,7 +2415,7 @@
 $supportedServices.css('display', 
'inline-block');
 } else if ($guestTypeField.val() == 
'L2') {
 $useVpc.hide();
-$supportedServices.hide();
+$supportedServices.css('display', 
'inline-block');
 
 Review comment:
   @rhtyd what if we display a checkbox with label 'User data (ConfigDrive)'? 
If it is checked, we can set serviceProviderList parameter to ConfigDrive and 
if not we'll pass it blank. This way we avoid user selecting unsupported 
services from the UI. What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

GabrielBrascher commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186064121
 
 

 ##
 File path: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -2868,6 +2849,89 @@ public boolean restartNetwork(final Long networkId, 
final Account callerAccount,
 }
 }
 
+@Override
+public void destroyExpendableRouters(final List 
routers, final ReservationContext context) throws ResourceUnavailableException {
+final List remainingRouters = new ArrayList<>();
+for (final VirtualRouter router : routers) {
+if (router.getState() == VirtualMachine.State.Stopped ||
+router.getState() == VirtualMachine.State.Error ||
+router.getState() == VirtualMachine.State.Shutdowned ||
+router.getState() == VirtualMachine.State.Unknown) {
+s_logger.debug("Destroying old router " + router);
+_routerService.destroyRouter(router.getId(), 
context.getAccount(), context.getCaller().getId());
+} else {
+remainingRouters.add(router);
+}
+}
+
+if (remainingRouters.size() < 2) {
+return;
+}
+
+VirtualRouter backupRouter = null;
+for (final VirtualRouter router : remainingRouters) {
+if (router.getRedundantState() == 
VirtualRouter.RedundantState.BACKUP) {
+backupRouter = router;
 
 Review comment:
   Got it, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2621: Backports for 4.11 branch

[GitBox]

rhtyd commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386578382
 
 
   Thanks @rafaelweingartner that's great. Can you check travis, looks like 
some build errors have occurred. I'll kick tests once travis is green.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386577955
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386577911
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-cloudmonkey] 02/02: api: fix linting issue and order by filter keys

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 17561b66f41511e8418ea264ee732fea687e5b75
Author: Rohit Yadav 
AuthorDate: Fri May 4 17:20:12 2018 +0530

api: fix linting issue and order by filter keys

Signed-off-by: Rohit Yadav 
---
 cmd/api.go | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/cmd/api.go b/cmd/api.go
index c13a2c8..ba7b70d 100644
--- a/cmd/api.go
+++ b/cmd/api.go
@@ -79,18 +79,20 @@ func printResult(outputType string, response 
map[string]interface{}, filter []st
}
 
if len(header) == 0 {
-   for field, _ := range row {
-   if filter != nil && 
len(filter) > 0 {
-   for _, 
filterKey := range filter {
+   if filter != nil && len(filter) 
> 0 {
+   for _, filterKey := 
range filter {
+   for field := 
range row {
if 
filterKey == field {

header = append(header, field)
}
}
-   continue
}
-   header = append(header, 
field)
+   } else {
+   for field := range row {
+   header = 
append(header, field)
+   }
+   sort.Strings(header)
}
-   sort.Strings(header)
table.SetHeader(header)
}
var rowArray []string

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch master updated (463384e -> 17561b6)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


from 463384e  vendor: add missing go-runewidth dependency
 new 7e2aae2  config: allow custom prompt
 new 17561b6  api: fix linting issue and order by filter keys

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 cmd/api.go   | 14 --
 cmd/set.go   |  1 +
 config/cache.go  |  1 +
 config/config.go |  4 
 config/prompt.go |  9 ++---
 5 files changed, 20 insertions(+), 9 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 01/02: config: allow custom prompt

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 7e2aae2acca8f946d59ac7853e0090efe332da01
Author: Rohit Yadav 
AuthorDate: Fri May 4 17:19:48 2018 +0530

config: allow custom prompt

Signed-off-by: Rohit Yadav 
---
 cmd/set.go   | 1 +
 config/cache.go  | 1 +
 config/config.go | 4 
 config/prompt.go | 9 ++---
 4 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/cmd/set.go b/cmd/set.go
index 961decb..1755227 100644
--- a/cmd/set.go
+++ b/cmd/set.go
@@ -27,6 +27,7 @@ func init() {
Name: "set",
Help: "Configures options for cmk",
SubCommands: map[string][]string{
+   "prompt": {"", "random"},
"asyncblock": {"true", "false"},
"timeout":{"600", "1800", "3600"},
"output": {"json", "text", "table", "xml"},
diff --git a/config/cache.go b/config/cache.go
index 8fc9089..a40fdf5 100644
--- a/config/cache.go
+++ b/config/cache.go
@@ -26,6 +26,7 @@ import (
"unicode"
 )
 
+// FAKE is used for fake CLI only options like filter=
 const FAKE = "fake"
 
 // APIArg are the args passable to an API
diff --git a/config/config.go b/config/config.go
index 16bda15..046f134 100644
--- a/config/config.go
+++ b/config/config.go
@@ -48,6 +48,7 @@ type ServerProfile struct {
 
 // Core block describes common options for the CLI
 type Core struct {
+   Prompt  string `ini:"prompt"`
AsyncBlock  bool   `ini:"asyncblock"`
Timeout int`ini:"timeout"`
Output  string `ini:"output"`
@@ -76,6 +77,7 @@ func getDefaultConfigDir() string {
 
 func defaultCoreConfig() Core {
return Core{
+   Prompt:  "",
AsyncBlock:  false,
Timeout: 1800,
Output:  JSON,
@@ -194,6 +196,8 @@ func reloadConfig(cfg *Config) *Config {
 // UpdateConfig updates and saves config
 func (c *Config) UpdateConfig(key string, value string) {
switch key {
+   case "prompt":
+   c.Core.Prompt = value
case "asyncblock":
c.Core.AsyncBlock = value == "true"
case "output":
diff --git a/config/prompt.go b/config/prompt.go
index 83b04b1..fe002d1 100644
--- a/config/prompt.go
+++ b/config/prompt.go
@@ -36,14 +36,17 @@ func emoji() string {
return emojis[rand.Intn(len(emojis)-1)]
 }
 
-func promptMoji() string {
+func renderPrompt(prompt string) string {
if runtime.GOOS == "windows" {
return "cmk"
}
-   return emoji() // 
+   if prompt == "random" {
+   return emoji()
+   }
+   return prompt
 }
 
 // GetPrompt returns prompt that the CLI should use
 func (c *Config) GetPrompt() string {
-   return fmt.Sprintf("(%s) %s > ", c.Core.ProfileName, promptMoji())
+   return fmt.Sprintf("(%s) %s > ", c.Core.ProfileName, 
renderPrompt(c.Core.Prompt))
 }

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386576137
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2009


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2621: Backports for 4.11 branch

[GitBox]

rafaelweingartner commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386575106
 
 
   @rhtyd I backported most of the bug PRs I created to master here. There were 
only two that I did not consider because of the volume of changes that I have 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386572689
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

rhtyd commented on issue #2615: config-drive: support user data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386572585
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386572216
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2008


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386571081
 
 
   @GabrielBrascher I've addressed your comment, please re-review and lgtm if 
you're okay with them. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rhtyd commented on issue #2443:  [CLOUDSTACK-9338] ACS is not accounting 
resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-386570900
 
 
   @rafaelweingartner cherry-pick might fail, can you submit a PR to 4.11 
branch or you can also push on my backport PR: 
https://github.com/apache/cloudstack/pull/2621 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386570776
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386544246
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2007


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385347107
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385353120
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1981


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386570594
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385347017
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR 
downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186052946
 
 

 ##
 File path: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -1216,6 +1180,32 @@ public void implementNetworkElementsAndResources(final 
DeployDestination dest, f
 }
 }
 
+protected void implementNetworkElements(final DeployDestination dest, 
final ReservationContext context, final Network network, final NetworkOffering 
offering, final List providersToImplement)
 
 Review comment:
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR 
downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r186052903
 
 

 ##
 File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
 ##
 @@ -2435,4 +2444,43 @@ public boolean isSrcNatIpRequired(long vpcOfferingId) {
 final Map 
vpcOffSvcProvidersMap = getVpcOffSvcProvidersMap(vpcOfferingId);
 return 
vpcOffSvcProvidersMap.get(Network.Service.SourceNat).contains(Network.Provider.VPCVirtualRouter);
 }
+
+private boolean rollingRestartVpc(final Vpc vpc, final ReservationContext 
context) throws ResourceUnavailableException, ConcurrentOperationException, 
InsufficientCapacityException {
+s_logger.debug("Performing rolling restart of routers of VPC " + vpc);
+_ntwkMgr.destroyExpendableRouters(_routerDao.listByVpcId(vpc.getId()), 
context);
+
+final DeployDestination dest = new 
DeployDestination(_dcDao.findById(vpc.getZoneId()), null, null, null);
+final List oldRouters = 
_routerDao.listByVpcId(vpc.getId());
+
+// Create a new router
+if (oldRouters.size() > 0) {
+vpc.setRollingRestart(true);
+}
+startVpc(vpc, dest, context);
+if (oldRouters.size() > 0) {
+vpc.setRollingRestart(false);
+}
+
+// For redundant vpc wait for 3*advert_int+skew_seconds for VRRP to 
kick in
+if (vpc.isRedundant() || (oldRouters.size() == 1 && 
oldRouters.get(0).getIsRedundantRouter())) {
+try {
+Thread.sleep(1L);
 
 Review comment:
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: [migrateVolume API method] Filter disk offerings based on storage pool selected (#2612)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 883b313  [migrateVolume API method] Filter disk offerings based on 
storage pool selected (#2612)
883b313 is described below

commit 883b313b9dccfeac272e2bf0f0a0d1bfbd056cc1
Author: Rafael Weingärtner 
AuthorDate: Fri May 4 08:04:10 2018 -0300

[migrateVolume API method] Filter disk offerings based on storage pool 
selected (#2612)

After using the feature introduced by #2486 in production, we felt the need 
for an improvement in the UI.  It is interesting to filter the displayed disk 
offerings according to the type of storage selected (local/shared) to migrate 
the volume to.
---
 ui/scripts/autoscaler.js  |  35 
 ui/scripts/configuration.js   |  33 
 ui/scripts/sharedFunctions.js |  31 
 ui/scripts/storage.js | 181 ++
 4 files changed, 138 insertions(+), 142 deletions(-)

diff --git a/ui/scripts/autoscaler.js b/ui/scripts/autoscaler.js
index e8ac044..da963fc 100644
--- a/ui/scripts/autoscaler.js
+++ b/ui/scripts/autoscaler.js
@@ -414,27 +414,20 @@
 isHidden: true,
 dependsOn: 'isAdvanced',
 select: function(args) {
-$.ajax({
-url: createURL("listDiskOfferings=true"),
-dataType: "json",
-async: true,
-success: function(json) {
-var diskofferings = 
json.listdiskofferingsresponse.diskoffering;
-var items = [];
-items.push({
-id: "",
-description: ""
-});
-$(diskofferings).each(function() {
-items.push({
-id: this.id,
-description: this.name
-});
-});
-args.response.success({
-data: items
-});
-}
+var diskOfferings = 
cloudStack.listDiskOfferings({listAll: true});
+var items = [];
+items.push({
+id: "",
+description: ""
+});
+$(diskOfferings).each(function() {
+items.push({
+id: this.id,
+description: this.name
+});
+});
+args.response.success({
+data: items
 });
 }
 },
diff --git a/ui/scripts/configuration.js b/ui/scripts/configuration.js
index 79916f5..3126191 100644
--- a/ui/scripts/configuration.js
+++ b/ui/scripts/configuration.js
@@ -1683,19 +1683,16 @@
 dataProvider: function(args) {
 var data = {};
 listViewDataProvider(args, data);
-
-$.ajax({
-url: 
createURL('listDiskOfferings=true'),
+var listDiskOfferingsOptions = {
+isRecursive: true,
 data: data,
-success: function(json) {
-var items = 
json.listdiskofferingsresponse.diskoffering;
-args.response.success({
-data: items
-});
-},
 error: function(data) {
 
args.response.error(parseXMLHttpResponse(data));
 }
+};
+var diskOfferings = 
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
+args.response.success({
+data: diskOfferings
 });
 },
 
@@ -2297,16 +2294,14 @@
 var data = {
 id: args.context.diskOfferings[0].id
 };
-$.ajax({
-url: 
createURL('listDiskOfferings=true'),
-data: data,
-  

[GitHub] rafaelweingartner closed pull request #2612: [migrateVolume API method] Filter disk offerings based on target storage pool selected

[GitBox]

rafaelweingartner closed pull request #2612: [migrateVolume API method] Filter 
disk offerings based on target storage pool selected
URL: https://github.com/apache/cloudstack/pull/2612
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/autoscaler.js b/ui/scripts/autoscaler.js
index e8ac0443662..da963fc1a2b 100644
--- a/ui/scripts/autoscaler.js
+++ b/ui/scripts/autoscaler.js
@@ -414,27 +414,20 @@
 isHidden: true,
 dependsOn: 'isAdvanced',
 select: function(args) {
-$.ajax({
-url: createURL("listDiskOfferings=true"),
-dataType: "json",
-async: true,
-success: function(json) {
-var diskofferings = 
json.listdiskofferingsresponse.diskoffering;
-var items = [];
-items.push({
-id: "",
-description: ""
-});
-$(diskofferings).each(function() {
-items.push({
-id: this.id,
-description: this.name
-});
-});
-args.response.success({
-data: items
-});
-}
+var diskOfferings = 
cloudStack.listDiskOfferings({listAll: true});
+var items = [];
+items.push({
+id: "",
+description: ""
+});
+$(diskOfferings).each(function() {
+items.push({
+id: this.id,
+description: this.name
+});
+});
+args.response.success({
+data: items
 });
 }
 },
diff --git a/ui/scripts/configuration.js b/ui/scripts/configuration.js
index fdc9e492da7..81b49d98feb 100644
--- a/ui/scripts/configuration.js
+++ b/ui/scripts/configuration.js
@@ -1683,19 +1683,16 @@
 dataProvider: function(args) {
 var data = {};
 listViewDataProvider(args, data);
-
-$.ajax({
-url: 
createURL('listDiskOfferings=true'),
+var listDiskOfferingsOptions = {
+isRecursive: true,
 data: data,
-success: function(json) {
-var items = 
json.listdiskofferingsresponse.diskoffering;
-args.response.success({
-data: items
-});
-},
 error: function(data) {
 
args.response.error(parseXMLHttpResponse(data));
 }
+};
+var diskOfferings = 
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
+args.response.success({
+data: diskOfferings
 });
 },
 
@@ -2297,16 +2294,14 @@
 var data = {
 id: args.context.diskOfferings[0].id
 };
-$.ajax({
-url: 
createURL('listDiskOfferings=true'),
-data: data,
-success: function(json) {
-var item = 
json.listdiskofferingsresponse.diskoffering[0];
-args.response.success({
-actionFilter: 
diskOfferingActionfilter,
-data: item
-});
-}
+var listDiskOfferingsOptions = {
+isRecursive: true,
+data: data
+ 

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rafaelweingartner commented on issue #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-386567922
 
 
   Sure. Would you like me do to the cherry-pick on 4.11 branch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rhtyd commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing 
Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-386567835
 
 
   @rafaelweingartner fair enough, but this seems a useful fix for LTS 
nonetheless. I'll leave the decision of backporting to you on this (and other 
PRs).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rhtyd commented on issue #2443:  [CLOUDSTACK-9338] ACS is not accounting 
resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-386567646
 
 
   @rafaelweingartner yes, but any bug fixes are welcome on LTS branch. The 
issue such as this may affect users around usage/billing if cloudstack 
providers are offering custom offering to users.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386566686
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

rhtyd commented on issue #2615: config-drive: support user data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386566527
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2623: fixes #2611

[GitBox]

blueorangutan commented on issue #2623: fixes #2611
URL: https://github.com/apache/cloudstack/pull/2623#issuecomment-386565467
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2623: fixes #2611

[GitBox]

rhtyd commented on issue #2623: fixes #2611
URL: https://github.com/apache/cloudstack/pull/2623#issuecomment-386565406
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

[GitBox]

rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file 
SRs being created in XenServer pools
URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-386556285
 
 
   I would leave it only for 4.12 due to its size. Only we seemed to have this 
issue so far.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

[GitBox]

rafaelweingartner commented on issue #2404: [CLOUDSTACK-10230] User should not 
be able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-386555916
 
 
   This PR might be interesting. However, due to the amount of changes (I 
refactored the whole method), I preferred to introduced it only on master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rafaelweingartner commented on issue #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-386555493
 
 
   I have not seen complains about this before. That is one of the reason why I 
target most of these things to master. It seems that we were the only ones 
having these needs. This one only happens if you use custom service offering.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-386554881
 
 
   I do not think so. It seems that no other people had this necessity so far. 
This PR enables people to use local storage and pre-setup storage at the same 
time. Moreover, I organized things, and now it is possible to have more than a 
single local storage per host.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386544246
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2007


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2623: fixes #2611

[GitBox]

blueorangutan commented on issue #2623: fixes #2611
URL: https://github.com/apache/cloudstack/pull/2623#issuecomment-386544244
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2006


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-386536596
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-386536550
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-386522681
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2621: Backports for 4.11 branch

[GitBox]

borisstoyanov commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386264136
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2621: Backports for 4.11 branch

[GitBox]

rhtyd commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386270517
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386270586
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386277850
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2002


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2621: Backports for 4.11 branch

[GitBox]

borisstoyanov commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386278034
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2621: Backports for 4.11 branch

[GitBox]

rhtyd commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386535323
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386498228
 
 
   Trillian test result (tid-2587)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52791 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2621-t2587-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 334.26 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 285.76 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 637.73 | 
test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 413.73 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.28 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 138.56 | test_volumes.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.44 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386535381
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-386278062
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2623: fixes #2611

[GitBox]

blueorangutan commented on issue #2623: fixes #2611
URL: https://github.com/apache/cloudstack/pull/2623#issuecomment-386535172
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2623: fixes #2611

[GitBox]

rhtyd commented on issue #2623: fixes #2611
URL: https://github.com/apache/cloudstack/pull/2623#issuecomment-386534942
 
 
   @blueorangutan package
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2615: WIP: Supporting ConfigDrive user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: WIP: Supporting ConfigDrive user data 
on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386534723
 
 
   @PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2615: WIP: Supporting ConfigDrive user data on L2 networks

[GitBox]

PaulAngus commented on issue #2615: WIP: Supporting ConfigDrive user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386534587
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2499: Updates to capacity management

[GitBox]

rhtyd commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-386533614
 
 
   @mike-tutkowski  I scanned PRs merged on master but not 4.11 and came across 
this PR, do you think this would be useful for 4.11? If so, can you help create 
a backport PR for 4.11?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rhtyd commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing 
Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-386533549
 
 
   @rafaelweingartner I scanned PRs merged on master but not 4.11 and came 
across this PR, do you think this would be useful for 4.11? If so, can you help 
create a backport PR for 4.11?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rhtyd commented on issue #2443:  [CLOUDSTACK-9338] ACS is not accounting 
resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-386533377
 
 
   @rafaelweingartner I scanned PRs merged on master but not 4.11 and came 
across this PR, since this is marked 'bug' do you think this would be useful 
for 4.11? If so, can you help create a backport PR for 4.11?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services